X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-utils.c;h=f56a3a8d0249b7f2d9214221678393da20ee4dcd;hp=019504c4e54c2e26c890795b8a7e8d349560dc34;hb=b969746bd8d9e021f79a19350e85a6fdbd3226a5;hpb=f918993cb9493d5edf6136b5c5d251b34a2672b1 diff --git a/src/modest-utils.c b/src/modest-utils.c index 019504c..f56a3a8 100644 --- a/src/modest-utils.c +++ b/src/modest-utils.c @@ -71,7 +71,7 @@ modest_utils_folder_writable (const gchar *filename) if (!filename) return FALSE; - if (g_strncasecmp (filename, "obex", 4) != 0) { + if (g_ascii_strncasecmp (filename, "obex", 4) != 0) { GnomeVFSFileInfo *folder_info = NULL; GnomeVFSResult result = GNOME_VFS_OK; GnomeVFSURI *uri = NULL; @@ -106,16 +106,20 @@ modest_utils_folder_writable (const gchar *filename) gboolean modest_utils_file_exists (const gchar *filename) { - GnomeVFSURI *uri = NULL; gboolean result = FALSE; + gchar *path; g_return_val_if_fail (filename, FALSE); - uri = gnome_vfs_uri_new (filename); - if (uri) { - result = gnome_vfs_uri_exists (uri); - gnome_vfs_uri_unref (uri); - } + path = strstr (filename, "file://"); + if (!path) + path = (gchar *) filename; + else + path = (gchar *) filename + strlen ("file://"); + + if (g_access (path, F_OK) == 0) + result = TRUE; + return result; } @@ -136,7 +140,7 @@ modest_utils_create_temp_stream (const gchar *orig_name, const gchar *hash_base, return NULL; } - if (g_strstr_len (orig_name, strlen(orig_name), "/") != NULL) { + if (g_strstr_len (orig_name, strlen (orig_name), "/") != NULL) { g_warning ("%s: filename contains '/' character(s) (%s)", __FUNCTION__, orig_name); return NULL; @@ -156,15 +160,14 @@ modest_utils_create_temp_stream (const gchar *orig_name, const gchar *hash_base, return NULL; } - filepath = g_strconcat (tmpdir, "/", orig_name, NULL); + filepath = g_build_filename (tmpdir, orig_name, NULL); /* if file exists, first we try to remove it */ - if (modest_utils_file_exists (filepath)) { + if (g_access (filepath, F_OK) == 0) g_unlink (filepath); - } /* don't overwrite if it already exists, even if it is writable */ - if (modest_utils_file_exists (filepath)) { + if (g_access (filepath, F_OK) == 0) { if (path!=NULL) { *path = filepath; } else { @@ -830,81 +833,28 @@ modest_utils_on_entry_invalid_character (ModestValidatingEntry *self, } FILE* -modest_utils_open_mcc_mapping_file (gboolean from_lc_messages, gboolean *translated) +modest_utils_open_mcc_mapping_file (void) { FILE* result = NULL; const gchar* path; - const gchar *env_list; - gchar **parts, **node; - if (from_lc_messages) { - env_list = setlocale (LC_MESSAGES, NULL); + if (access (MODEST_OPERATOR_WIZARD_MCC_MAPPING, R_OK) == 0) { + path = MODEST_OPERATOR_WIZARD_MCC_MAPPING; + } else if (access (MODEST_MCC_MAPPING, R_OK) == 0) { + path = MODEST_MCC_MAPPING; } else { - env_list = getenv ("LANG"); - } - parts = g_strsplit (env_list, ":", 0); - gchar *path1 = NULL; - const gchar* path2 = MODEST_MCC_MAPPING; - - if (translated) - *translated = TRUE; - - path = NULL; - for (node = parts; path == NULL && node != NULL && *node != NULL && **node != '\0'; node++) { - path1 = g_strdup_printf ("%s.%s", MODEST_OPERATOR_WIZARD_MCC_MAPPING, *node); - if (access (path1, R_OK) == 0) { - path = path1; - break; - } else { - g_free (path1); - path1 = NULL; - } - } - g_strfreev (parts); - - if (path == NULL) { - if (access (MODEST_OPERATOR_WIZARD_MCC_MAPPING, R_OK) == 0) { - path = MODEST_OPERATOR_WIZARD_MCC_MAPPING; - if (translated) - *translated = FALSE; - } else if (access (path2, R_OK) == 0) { - path = path2; - } else { - g_warning ("%s: neither '%s' nor '%s' is a readable mapping file", - __FUNCTION__, path1, path2); - goto end; - } + g_warning ("%s: neither '%s' nor '%s' is a readable mapping file", + __FUNCTION__, MODEST_OPERATOR_WIZARD_MCC_MAPPING, MODEST_MCC_MAPPING); + return NULL; } result = fopen (path, "r"); if (!result) { g_warning ("%s: error opening mapping file '%s': %s", __FUNCTION__, path, strerror(errno)); - goto end; } - end: - g_free (path1); - return result; -} -/* cluster mcc's, based on the list - * http://en.wikipedia.org/wiki/Mobile_country_code - */ -static int -effective_mcc (gint mcc) -{ - switch (mcc) { - case 405: return 404; /* india */ - case 441: return 440; /* japan */ - case 235: return 234; /* united kingdom */ - case 311: - case 312: - case 313: - case 314: - case 315: - case 316: return 310; /* united states */ - default: return mcc; - } + return result; } /* each line is of the form: @@ -913,12 +863,6 @@ effective_mcc (gint mcc) NOTE: this function is NOT re-entrant, the out-param country are static strings that should NOT be freed. and will change when calling this function again - - also note, this function will return the "effective mcc", which - is the normalized mcc for a country - ie. even if the there - are multiple entries for the United States with various mccs, - this function will always return 310, even if the real mcc parsed - would be 314. see the 'effective_mcc' function above. */ static int parse_mcc_mapping_line (const char* line, char** country) @@ -939,8 +883,9 @@ parse_mcc_mapping_line (const char* line, char** country) *country = g_utf8_find_next_char (tab, NULL); /* Replace by end of string. We need to use strlen, because - g_utf8_strrchr expects bytes and not UTF8 characters */ - final = g_utf8_strrchr (tab, strlen (tab) + 1, '\n'); + g_utf8_strrchr expects bytes and not UTF8 characters. File + lines end with \r\n */ + final = g_utf8_strrchr (tab, strlen (tab) + 1, '\r'); if (G_LIKELY (final)) *final = '\0'; else @@ -954,7 +899,7 @@ parse_mcc_mapping_line (const char* line, char** country) mcc[2] = g_utf8_get_char (iter); mcc[3] = '\0'; - return effective_mcc ((int) strtol ((const char*)mcc, NULL, 10)); + return (int) strtol ((const char*)mcc, NULL, 10); } #define MCC_FILE_MAX_LINE_LEN 128 /* max length of a line in MCC file */ @@ -975,7 +920,6 @@ modest_utils_create_country_model (void) void modest_utils_fill_country_model (GtkTreeModel *model, gint *locale_mcc) { - gboolean translated; char line[MCC_FILE_MAX_LINE_LEN]; guint previous_mcc = 0; gchar *territory; @@ -983,14 +927,16 @@ modest_utils_fill_country_model (GtkTreeModel *model, gint *locale_mcc) FILE *file; /* First we need to know our current region */ - file = modest_utils_open_mcc_mapping_file (FALSE, &translated); + file = modest_utils_open_mcc_mapping_file (); if (!file) { g_warning ("Could not open mcc_mapping file"); return; } /* Get the territory specified for the current locale */ - territory = nl_langinfo (_NL_ADDRESS_COUNTRY_NAME); + territory = nl_langinfo (_NL_IDENTIFICATION_TERRITORY); + + setlocale (LC_MESSAGES, "en_GB"); while (fgets (line, MCC_FILE_MAX_LINE_LEN, file) != NULL) { int mcc; @@ -1009,25 +955,16 @@ modest_utils_fill_country_model (GtkTreeModel *model, gint *locale_mcc) previous_mcc = mcc; if (!(*locale_mcc)) { - if (translated) { - if (!g_utf8_collate (country, territory)) - *locale_mcc = mcc; - } else { - gchar *translation = dgettext ("osso-countries", country); - if (!g_utf8_collate (translation, territory)) - *locale_mcc = mcc; - } + gchar *translation = dgettext ("osso-countries", country); + if (!g_utf8_collate (translation, territory)) + *locale_mcc = mcc; } } - fclose (file); - /* Now we fill the model */ - file = modest_utils_open_mcc_mapping_file (TRUE, &translated); - if (!file) { - g_warning ("Could not open mcc_mapping file"); - return; - } + setlocale (LC_MESSAGES, ""); + /* Now we fill the model */ + rewind (file); country_hash = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, NULL); while (fgets (line, MCC_FILE_MAX_LINE_LEN, file) != NULL) { @@ -1053,12 +990,16 @@ modest_utils_fill_country_model (GtkTreeModel *model, gint *locale_mcc) name_translated = dgettext ("osso-countries", country); - /* Add the row to the model: */ - gtk_list_store_append (GTK_LIST_STORE (model), &iter); - gtk_list_store_set(GTK_LIST_STORE (model), &iter, - MODEST_UTILS_COUNTRY_MODEL_COLUMN_MCC, mcc, - MODEST_UTILS_COUNTRY_MODEL_COLUMN_NAME, name_translated, - -1); + /* Add the row to the model if we have translation for it */ + if (g_utf8_collate (country, name_translated)) { + gtk_list_store_append (GTK_LIST_STORE (model), &iter); + gtk_list_store_set(GTK_LIST_STORE (model), &iter, + MODEST_UTILS_COUNTRY_MODEL_COLUMN_MCC, mcc, + MODEST_UTILS_COUNTRY_MODEL_COLUMN_NAME, name_translated, + -1); + } else { + g_debug ("%s no translation for %s", __FUNCTION__, country); + } } @@ -1131,6 +1072,8 @@ free_notification_data (gpointer data, g_free (notification_data->from); g_free (notification_data->subject); g_free (notification_data->uri); + + g_slice_free (ModestMsgNotificationData, notification_data); } void @@ -1149,15 +1092,18 @@ modest_utils_flush_send_queue (const gchar *account_id) /* Get the transport account */ account = (TnyTransportAccount *) - modest_tny_account_store_get_tny_account_by (modest_runtime_get_account_store (), - MODEST_TNY_ACCOUNT_STORE_QUERY_ID, - account_id); - + modest_tny_account_store_get_server_account (modest_runtime_get_account_store (), + account_id, + TNY_ACCOUNT_TYPE_TRANSPORT); if (account) { + ModestMailOperation *wakeup_op; ModestTnySendQueue *send_queue = modest_runtime_get_send_queue (account, TRUE); /* Flush it! */ - tny_camel_send_queue_flush ((TnyCamelSendQueue *) send_queue); + wakeup_op = modest_mail_operation_new (NULL); + modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), + wakeup_op); + modest_mail_operation_queue_wakeup (wakeup_op, send_queue); g_object_unref (account); }