X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fmodest-widget-memory.c;h=56ab18aef2ed49fd1480a72d124069938a42178f;hp=23059332be2b11ac93eac2cce8b8fec4a14ce67d;hb=c5c7a9164713055c43ec69bdda8c2767271515a1;hpb=62d983888e426a7c4c483fc16f6a4ded65e583e3 diff --git a/src/modest-widget-memory.c b/src/modest-widget-memory.c index 2305933..56ab18a 100644 --- a/src/modest-widget-memory.c +++ b/src/modest-widget-memory.c @@ -27,22 +27,28 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -#include "modest-widget-memory.h" +#include +#include +#include +#include +#include +#include +#include #include +#include +#include +#include "widgets/modest-main-window.h" #include -#define PARAM_X "x" -#define PARAM_Y "y" -#define PARAM_HEIGHT "height" -#define PARAM_WIDTH "width" -#define PARAM_POS "pos" -#define PARAM_COLUMN_WIDTH "column-width" - -static gchar* -get_keyname (ModestConf *conf, const gchar *name, const gchar *param) +gchar* +_modest_widget_memory_get_keyname (const gchar *name, const gchar *param) { gchar *esc_name, *keyname; - esc_name = modest_conf_key_escape (conf, name); + + g_return_val_if_fail (name, NULL); + g_return_val_if_fail (param, NULL); + + esc_name = modest_conf_key_escape (name); keyname = g_strdup_printf ("%s/%s/%s", MODEST_CONF_WIDGET_NAMESPACE, @@ -52,17 +58,56 @@ get_keyname (ModestConf *conf, const gchar *name, const gchar *param) } +gchar* +_modest_widget_memory_get_keyname_with_type (const gchar *name, guint type, + const gchar *param) +{ + gchar *esc_name, *keyname; + + g_return_val_if_fail (name, NULL); + g_return_val_if_fail (param, NULL); + + esc_name = modest_conf_key_escape (name); + + keyname = g_strdup_printf ("%s/%s/%s_%d", + MODEST_CONF_WIDGET_NAMESPACE, + esc_name, param, type); + g_free (esc_name); + return keyname; +} + + +gchar* +_modest_widget_memory_get_keyname_with_double_type (const gchar *name, + guint type1, guint type2, + const gchar *param) +{ + gchar *esc_name, *keyname; + + g_return_val_if_fail (name, NULL); + g_return_val_if_fail (param, NULL); + + esc_name = modest_conf_key_escape (name); + + keyname = g_strdup_printf ("%s/%s/%s_%d_%d", + MODEST_CONF_WIDGET_NAMESPACE, + esc_name, param, type1, type2); + g_free (esc_name); + return keyname; +} + + static gboolean save_settings_widget (ModestConf *conf, GtkWidget *widget, const gchar *name) { gchar *key; - key = get_keyname (conf, name, PARAM_HEIGHT); + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_HEIGHT); modest_conf_set_int (conf, key, GTK_WIDGET(widget)->allocation.height, NULL); g_free (key); - key = get_keyname (conf, name, PARAM_WIDTH); + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_WIDTH); modest_conf_set_int (conf, key, GTK_WIDGET(widget)->allocation.width, NULL); g_free (key); @@ -76,14 +121,14 @@ restore_settings_widget (ModestConf *conf, GtkWidget *widget, const gchar *name) GtkRequisition req; gchar *key; - key = get_keyname (conf, name, PARAM_HEIGHT); + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_HEIGHT); if (modest_conf_key_exists (conf, key, NULL)) req.height = modest_conf_get_int (conf, key, NULL); g_free (key); - key = get_keyname (conf, name, PARAM_WIDTH); + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_WIDTH); if (modest_conf_key_exists (conf, key, NULL)) req.width = modest_conf_get_int (conf, key, NULL); g_free (key); @@ -105,13 +150,22 @@ save_settings_window (ModestConf *conf, GtkWindow *win, const gchar *name) gtk_window_get_size (win, &width, &height); - key = get_keyname (conf, name, PARAM_HEIGHT); + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_HEIGHT); modest_conf_set_int (conf, key, height, NULL); g_free (key); - key = get_keyname (conf, name, PARAM_WIDTH); + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_WIDTH); modest_conf_set_int (conf, key, width, NULL); g_free (key); + + /* Save also the main window style */ + if (MODEST_IS_MAIN_WINDOW (win)) { + ModestMainWindowStyle style = modest_main_window_get_style (MODEST_MAIN_WINDOW (win)); + + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_WINDOW_STYLE); + modest_conf_set_int (conf, key, style, NULL); + g_free (key); + } return TRUE; } @@ -123,21 +177,39 @@ restore_settings_window (ModestConf *conf, GtkWindow *win, const gchar *name) gchar *key; int height = 0, width = 0; - key = get_keyname (conf, name, PARAM_HEIGHT); + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_HEIGHT); if (modest_conf_key_exists (conf, key, NULL)) height = modest_conf_get_int (conf, key, NULL); g_free (key); - key = get_keyname (conf, name, PARAM_WIDTH); + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_WIDTH); if (modest_conf_key_exists (conf, key, NULL)) width = modest_conf_get_int (conf, key, NULL); g_free (key); + /* Added this ugly ifdef, because in Maemo the + gtk_window_set_default_size() makes "drag-motion" signal + report bad coordinates, so drag-and-drop do not work + properly */ +#ifdef MODEST_PLATFORM_GNOME if (height && width) gtk_window_set_default_size (win, width, height); +#endif + + /* Restore also the main window style */ + if (MODEST_IS_MAIN_WINDOW (win)) { + ModestMainWindowStyle style; + + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_WINDOW_STYLE); + if (modest_conf_key_exists (conf, key, NULL)) { + style = (ModestMainWindowStyle) modest_conf_get_int (conf, key, NULL); + modest_main_window_set_style (MODEST_MAIN_WINDOW (win), style); + g_free (key); + } + } return TRUE; } @@ -147,13 +219,19 @@ static gboolean save_settings_paned (ModestConf *conf, GtkPaned *paned, const gchar *name) { gchar *key; - int pos; - - pos = gtk_paned_get_position (paned); - - key = get_keyname (conf, name, PARAM_POS); - modest_conf_set_int (conf, key, pos, NULL); - g_free (key); + gint pos; + gdouble percent; + + /* Don't save the paned position if it's not visible, + * because it could not be correct: */ + if (GTK_WIDGET_REALIZED (GTK_WIDGET (paned))) { + pos = gtk_paned_get_position (paned); + percent = (gdouble) (pos * 100) / (gdouble) GTK_WIDGET (paned)->allocation.width; + + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_POS); + modest_conf_set_float (conf, key, percent, NULL); + g_free (key); + } return TRUE; } @@ -163,12 +241,14 @@ static gboolean restore_settings_paned (ModestConf *conf, GtkPaned *paned, const gchar *name) { gchar *key; - int pos; + gdouble percent; + gint pos; - key = get_keyname (conf, name, PARAM_POS); + key = _modest_widget_memory_get_keyname (name, MODEST_WIDGET_MEMORY_PARAM_POS); + percent = modest_conf_get_float (conf, key, NULL); - if (modest_conf_key_exists (conf, key, NULL)) { - pos = modest_conf_get_int (conf, key, NULL); + if (GTK_WIDGET_VISIBLE (GTK_WIDGET (paned)) && GTK_WIDGET_REALIZED (GTK_WIDGET (paned))) { + pos = GTK_WIDGET (paned)->allocation.width * percent /100; gtk_paned_set_position (paned, pos); } @@ -182,123 +262,315 @@ save_settings_header_view (ModestConf *conf, ModestHeaderView *header_view, const gchar *name) { gchar *key; + gchar *sort_key; + gchar *sort_value; GString *str; GList *cols, *cursor; + TnyFolder *folder; + TnyFolderType type; + ModestHeaderViewStyle style; + gint sort_colid; + GtkSortType sort_type; + gint sort_flag_id = 0; + + folder = modest_header_view_get_folder (header_view); + if (!folder || modest_header_view_is_empty (header_view)) { + if (folder) + g_object_unref (folder); + return TRUE; /* no non-empty folder: no settings */ + } + + type = modest_tny_folder_guess_folder_type (folder); + if (type == TNY_FOLDER_TYPE_INVALID) + g_warning ("%s: BUG: TNY_FOLDER_TYPE_INVALID", __FUNCTION__); + + style = modest_header_view_get_style (header_view); + + key = _modest_widget_memory_get_keyname_with_double_type (name, type, style, + MODEST_WIDGET_MEMORY_PARAM_COLUMN_WIDTH); + sort_key = _modest_widget_memory_get_keyname_with_double_type (name, type, style, + MODEST_WIDGET_MEMORY_PARAM_COLUMN_SORT); cursor = cols = modest_header_view_get_columns (header_view); - str = g_string_new (NULL); + if (!cols) { + g_warning ("DEBUG: %s: modest_header_view_get_columns() returned NULL.", + __FUNCTION__); + } + str = g_string_new (NULL); + + /* NOTE: the exact details of this format are important, as they + * are also used in modest-init. + */ + sort_colid = modest_header_view_get_sort_column_id (header_view, type); + sort_type = modest_header_view_get_sort_type (header_view, type); + while (cursor) { - int col_id, width; + int col_id, width, sort; GtkTreeViewColumn *col; + int column_sort_flag; col = GTK_TREE_VIEW_COLUMN (cursor->data); col_id = GPOINTER_TO_INT(g_object_get_data (G_OBJECT(col), MODEST_HEADER_VIEW_COLUMN)); width = gtk_tree_view_column_get_width (col); + sort = 0; + if (sort_colid == col_id) + sort = (sort_type == GTK_SORT_ASCENDING) ? 1:0; + column_sort_flag = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (col), MODEST_HEADER_VIEW_FLAG_SORT)); + if (column_sort_flag != 0) + sort_flag_id = column_sort_flag; - g_string_append_printf (str, "%d:%d ", col_id, width); - + g_string_append_printf (str, "%d:%d:%d ", col_id, width, sort); cursor = g_list_next (cursor); } - key = get_keyname (conf, name, PARAM_COLUMN_WIDTH); - modest_conf_set_string (conf, key, str->str, NULL); - + if ((str->str == NULL) || (strlen(str->str) == 0)) { + /* TODO: Find out why this happens sometimes. */ + g_warning ("DEBUG: %s: Attempting to write an empty value to " + "gconf key %s. Preventing.", __FUNCTION__, key); + } + else + modest_conf_set_string (conf, key, str->str, NULL); + + /* store current sort column for compact view */ + if (sort_colid >= 0) { + sort_value = g_strdup_printf("%d:%d:%d", sort_colid, sort_type, sort_flag_id); + modest_conf_set_string (conf, sort_key, sort_value, NULL); + g_free (sort_value); + } + + + + g_free (key); + g_free (sort_key); g_string_free (str, TRUE); g_list_free (cols); + g_object_unref (G_OBJECT (folder)); return TRUE; } - static gboolean restore_settings_header_view (ModestConf *conf, ModestHeaderView *header_view, const gchar *name) { - gchar *key; - key = get_keyname (conf, name, PARAM_COLUMN_WIDTH); + guint col, width; + gint sort; + gchar *key; + gchar *sort_key; + TnyFolder *folder; + TnyFolderType type; + ModestHeaderViewStyle style; + gint sort_flag_id = 0; + gint sort_colid = -1, sort_type = GTK_SORT_DESCENDING; - if (modest_conf_key_exists (conf, key, NULL)) { + folder = modest_header_view_get_folder (header_view); + if (!folder) + return TRUE; /* no folder: no settings */ + + type = modest_tny_folder_guess_folder_type (folder); + if (type == TNY_FOLDER_TYPE_INVALID) + g_warning ("%s: BUG: TNY_FOLDER_TYPE_INVALID", __FUNCTION__); + + style = modest_header_view_get_style (header_view); + + key = _modest_widget_memory_get_keyname_with_double_type (name, type, style, + MODEST_WIDGET_MEMORY_PARAM_COLUMN_WIDTH); + sort_key = _modest_widget_memory_get_keyname_with_double_type (name, type, style, + MODEST_WIDGET_MEMORY_PARAM_COLUMN_SORT); + if (modest_conf_key_exists (conf, sort_key, NULL)) { + gchar *value = modest_conf_get_string (conf, sort_key, NULL); + sscanf (value, "%d:%d:%d", &sort_colid, &sort_type, &sort_flag_id); + g_free (value); + } + + if (modest_conf_key_exists (conf, key, NULL)) { + gchar *data, *cursor; - guint col, width; GList *cols = NULL; GList *colwidths = NULL; - + GList *colsortables = NULL; + GtkTreeModel *sortable; + cursor = data = modest_conf_get_string (conf, key, NULL); - while (cursor && sscanf (cursor, "%u:%u ", &col, &width) == 2) { + while (cursor && sscanf (cursor, "%d:%d:%d ", &col, &width, &sort) == 3) { + cols = g_list_append (cols, GINT_TO_POINTER(col)); colwidths = g_list_append (colwidths, GINT_TO_POINTER(width)); + colsortables = g_list_append (colsortables, GINT_TO_POINTER(sort)); cursor = strchr (cursor + 1, ' '); } g_free (data); + /* Use defaults if gconf has no, or empty information: */ + /* We don't know why the value is empty sometimes. */ + if (g_list_length(cols) == 0) { + g_warning("%s: gconf key %s was empty. Using default column IDs.\n", + __FUNCTION__, key); + g_list_free (cols); + cols = NULL; + } + + if (!cols) + cols = modest_init_get_default_header_view_column_ids (type, style); + if (cols) { GList *viewcolumns, *colcursor, *widthcursor; - modest_header_view_set_columns (header_view, cols); + modest_header_view_set_columns (header_view, cols, type); + sortable = gtk_tree_view_get_model (GTK_TREE_VIEW (header_view)); widthcursor = colwidths; colcursor = viewcolumns = gtk_tree_view_get_columns (GTK_TREE_VIEW(header_view)); while (colcursor && widthcursor) { - gtk_tree_view_column_set_fixed_width(GTK_TREE_VIEW_COLUMN(colcursor->data), - GPOINTER_TO_INT(widthcursor->data)); + int width = GPOINTER_TO_INT(widthcursor->data); + int view_column_id = GPOINTER_TO_INT (g_object_get_data ( + G_OBJECT (colcursor->data), + MODEST_HEADER_VIEW_COLUMN)); + if (width > 0) + gtk_tree_view_column_set_max_width(GTK_TREE_VIEW_COLUMN(colcursor->data), + width); + if (((view_column_id == MODEST_HEADER_VIEW_COLUMN_COMPACT_HEADER_IN) || + (view_column_id == MODEST_HEADER_VIEW_COLUMN_COMPACT_HEADER_OUT)) && + (sort_flag_id != 0)) + g_object_set_data (G_OBJECT (colcursor->data), + MODEST_HEADER_VIEW_FLAG_SORT, GINT_TO_POINTER (sort_flag_id)); colcursor = g_list_next (colcursor); widthcursor = g_list_next (widthcursor); } + g_list_free (cols); g_list_free (colwidths); + g_list_free (colsortables); g_list_free (viewcolumns); } } + if (sort_colid >= 0) { + GtkTreeModel *sortable = + gtk_tree_model_filter_get_model ( + GTK_TREE_MODEL_FILTER (gtk_tree_view_get_model (GTK_TREE_VIEW (header_view)))); + if (sort_colid == TNY_GTK_HEADER_LIST_MODEL_FLAGS_COLUMN) + modest_header_view_sort_by_column_id (header_view, 0, sort_type); + gtk_tree_sortable_set_sort_column_id (GTK_TREE_SORTABLE(sortable), + sort_colid, + sort_type); + modest_header_view_sort_by_column_id (header_view, sort_colid, sort_type); + gtk_tree_sortable_sort_column_changed (GTK_TREE_SORTABLE(sortable)); + } + g_free (key); + g_free (sort_key); + + g_object_unref (G_OBJECT (folder)); + return TRUE; } + +static gboolean +save_settings_folder_view (ModestConf *conf, ModestFolderView *folder_view, + const gchar *name) +{ + return TRUE; +} + +static gboolean +restore_settings_folder_view (ModestConf *conf, + ModestFolderView *folder_view, + const gchar *name) +{ + ModestAccountMgr *mgr; + gchar *default_acc; + + /* Always show the default account as visible server account */ + mgr = modest_runtime_get_account_mgr (); + default_acc = modest_account_mgr_get_default_account (mgr); + if (default_acc) { + ModestAccountSettings *settings; + ModestServerAccountSettings *store_settings; + const gchar *server_acc_id; + + settings = modest_account_mgr_load_account_settings (mgr, (const gchar*) default_acc); + store_settings = modest_account_settings_get_store_settings (settings); + server_acc_id = modest_server_account_settings_get_account_name (store_settings); + + modest_folder_view_set_account_id_of_visible_server_account (folder_view, server_acc_id); + g_object_unref (store_settings); + g_object_unref (settings); + g_free (default_acc); + } + return TRUE; +} + + +static gboolean +save_settings_msg_view (ModestConf *conf, + ModestMsgView *msg_view, + const gchar *name) +{ + return TRUE; /* FIXME: implement this */ +} + +static gboolean +restore_settings_msg_view (ModestConf *conf, ModestMsgView *msg_view, + const gchar *name) +{ + return TRUE; /* FIXME: implement this */ +} + + + gboolean -modest_widget_memory_save_settings (ModestConf *conf, GtkWidget *widget, - const gchar *name) +modest_widget_memory_save (ModestConf *conf, GObject *widget, const gchar *name) { g_return_val_if_fail (conf, FALSE); g_return_val_if_fail (widget, FALSE); g_return_val_if_fail (name, FALSE); - + if (GTK_IS_WINDOW(widget)) return save_settings_window (conf, GTK_WINDOW(widget), name); else if (GTK_IS_PANED(widget)) return save_settings_paned (conf, GTK_PANED(widget), name); else if (MODEST_IS_HEADER_VIEW(widget)) return save_settings_header_view (conf, MODEST_HEADER_VIEW(widget), name); + else if (MODEST_IS_FOLDER_VIEW(widget)) + return save_settings_folder_view (conf, MODEST_FOLDER_VIEW(widget), name); + else if (MODEST_IS_MSG_VIEW(widget)) + return save_settings_msg_view (conf, MODEST_MSG_VIEW(widget), name); else if (GTK_IS_WIDGET(widget)) - return save_settings_widget (conf, widget, name); + return save_settings_widget (conf, GTK_WIDGET(widget), name); - g_printerr ("modest: %p is not a known widget\n", widget); + g_printerr ("modest: %p (%s) is not a known widget\n", widget, name); return FALSE; } gboolean -modest_widget_memory_restore_settings (ModestConf *conf, GtkWidget *widget, - const gchar *name) +modest_widget_memory_restore (ModestConf *conf, GObject *widget, const gchar *name) { g_return_val_if_fail (conf, FALSE); g_return_val_if_fail (widget, FALSE); g_return_val_if_fail (name, FALSE); - + if (GTK_IS_WINDOW(widget)) return restore_settings_window (conf, GTK_WINDOW(widget), name); else if (GTK_IS_PANED(widget)) return restore_settings_paned (conf, GTK_PANED(widget), name); else if (MODEST_IS_HEADER_VIEW(widget)) return restore_settings_header_view (conf, MODEST_HEADER_VIEW(widget), name); + else if (MODEST_IS_FOLDER_VIEW(widget)) + return restore_settings_folder_view (conf, MODEST_FOLDER_VIEW(widget), name); + else if (MODEST_IS_MSG_VIEW(widget)) + return restore_settings_msg_view (conf, MODEST_MSG_VIEW(widget), name); else if (GTK_IS_WIDGET(widget)) - return restore_settings_widget (conf, widget, name); + return restore_settings_widget (conf, GTK_WIDGET(widget), name); - g_printerr ("modest: %p is not a known widget\n", widget); + g_printerr ("modest: %p (%s) is not a known widget\n", widget, name); return FALSE; }