X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fwidgets%2Fmodest-header-view-render.c;h=d2a6c969cc0151680f7a016942e7d2bf62e7e608;hp=825ada5dfd98cdc894db504fe1b10434d11be998;hb=4d4e53bc3b65b7f9d5ce0496b5e79053e731f8c8;hpb=434d0476d22cca10d080097e5c181d33eaeb1b7a diff --git a/src/widgets/modest-header-view-render.c b/src/widgets/modest-header-view-render.c index 825ada5..d2a6c96 100644 --- a/src/widgets/modest-header-view-render.c +++ b/src/widgets/modest-header-view-render.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -41,6 +42,14 @@ #include #include +#ifdef MODEST_TOOLKIT_HILDON2 +#define SMALL_ICON_SIZE MODEST_ICON_SIZE_SMALL +#else +#define SMALL_ICON_SIZE MODEST_ICON_SIZE_SMALL +#endif + +#define MODEST_HEADER_VIEW_MAX_TEXT_LENGTH 128 + static const gchar * get_status_string (ModestTnySendQueueStatus status) { @@ -78,34 +87,34 @@ get_pixbuf_for_flag (TnyHeaderFlags flag) case TNY_HEADER_FLAG_DELETED: if (G_UNLIKELY(!deleted_pixbuf)) deleted_pixbuf = modest_platform_get_icon (MODEST_HEADER_ICON_DELETED, - MODEST_ICON_SIZE_SMALL); + SMALL_ICON_SIZE); return deleted_pixbuf; case TNY_HEADER_FLAG_SEEN: if (G_UNLIKELY(!seen_pixbuf)) seen_pixbuf = modest_platform_get_icon (MODEST_HEADER_ICON_READ, - MODEST_ICON_SIZE_SMALL); + SMALL_ICON_SIZE); return seen_pixbuf; case TNY_HEADER_FLAG_ATTACHMENTS: if (G_UNLIKELY(!attachments_pixbuf)) attachments_pixbuf = modest_platform_get_icon (MODEST_HEADER_ICON_ATTACH, - MODEST_ICON_SIZE_SMALL); + SMALL_ICON_SIZE); return attachments_pixbuf; case TNY_HEADER_FLAG_HIGH_PRIORITY: if (G_UNLIKELY(!high_pixbuf)) high_pixbuf = modest_platform_get_icon (MODEST_HEADER_ICON_HIGH, - MODEST_ICON_SIZE_SMALL); + SMALL_ICON_SIZE); return high_pixbuf; case TNY_HEADER_FLAG_LOW_PRIORITY: if (G_UNLIKELY(!low_pixbuf)) low_pixbuf = modest_platform_get_icon (MODEST_HEADER_ICON_LOW, - MODEST_ICON_SIZE_SMALL); + SMALL_ICON_SIZE); return low_pixbuf; case TNY_HEADER_FLAG_NORMAL_PRIORITY: return NULL; default: if (G_UNLIKELY(!unread_pixbuf)) unread_pixbuf = modest_platform_get_icon (MODEST_HEADER_ICON_UNREAD, - MODEST_ICON_SIZE_SMALL); + SMALL_ICON_SIZE); return unread_pixbuf; } } @@ -120,21 +129,67 @@ set_common_flags (GtkCellRenderer *renderer, TnyHeaderFlags flags) } static void -set_cell_text (GtkCellRenderer *renderer, - const gchar *text, +set_cell_text (GtkCellRenderer *renderer, + const gchar *text, TnyHeaderFlags flags) { - PangoWeight weight; gboolean strikethrough; + gboolean bold_is_active_color; + GdkColor *color = NULL; + PangoWeight weight; + gchar *newtext = NULL; + + /* We have to limit the size of the text. Otherwise Pango + could cause freezes trying to render too large texts. This + prevents DoS attacks with specially malformed emails */ + if (g_utf8_validate(text, -1, NULL)) { + if (g_utf8_strlen (text, -1) > MODEST_HEADER_VIEW_MAX_TEXT_LENGTH) { + /* UTF-8 bytes are 4 bytes length in the worst case */ + newtext = g_malloc0 (MODEST_HEADER_VIEW_MAX_TEXT_LENGTH * 4); + g_utf8_strncpy (newtext, text, MODEST_HEADER_VIEW_MAX_TEXT_LENGTH); + text = newtext; + } + } else { + if (strlen (text) > MODEST_HEADER_VIEW_MAX_TEXT_LENGTH) { + newtext = g_malloc0 (MODEST_HEADER_VIEW_MAX_TEXT_LENGTH); + strncpy (newtext, text, MODEST_HEADER_VIEW_MAX_TEXT_LENGTH); + text = newtext; + } + } + + bold_is_active_color = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (renderer), BOLD_IS_ACTIVE_COLOR)); + if (bold_is_active_color) { + color = g_object_get_data (G_OBJECT (renderer), ACTIVE_COLOR); + } - weight = (flags & TNY_HEADER_FLAG_SEEN) ? PANGO_WEIGHT_NORMAL: PANGO_WEIGHT_ULTRABOLD; +#ifdef MODEST_TOOLKIT_HILDON2 + weight = PANGO_WEIGHT_NORMAL; +#else + weight = (bold_is_active_color || (flags & TNY_HEADER_FLAG_SEEN)) ? PANGO_WEIGHT_NORMAL: PANGO_WEIGHT_ULTRABOLD; +#endif strikethrough = (flags & TNY_HEADER_FLAG_DELETED) ? TRUE:FALSE; g_object_freeze_notify (G_OBJECT (renderer)); g_object_set (G_OBJECT (renderer), "text", text, - "weight", (flags & TNY_HEADER_FLAG_SEEN) ? PANGO_WEIGHT_NORMAL : PANGO_WEIGHT_ULTRABOLD, + "weight", weight, "strikethrough", (flags &TNY_HEADER_FLAG_DELETED) ? TRUE : FALSE, NULL); + if (bold_is_active_color && color) { + if (flags & TNY_HEADER_FLAG_SEEN) { + g_object_set (G_OBJECT (renderer), + "foreground-set", FALSE, + NULL); + } else { + g_object_set (G_OBJECT (renderer), + "foreground-gdk", color, + "foreground-set", TRUE, + NULL); + } + } + + if (newtext) + g_free (newtext); + g_object_thaw_notify (G_OBJECT (renderer)); } @@ -211,14 +266,14 @@ _modest_header_view_sender_receiver_cell_data (GtkTreeViewColumn *column, sender_receiver_col = TNY_GTK_HEADER_LIST_MODEL_FROM_COLUMN; else sender_receiver_col = TNY_GTK_HEADER_LIST_MODEL_TO_COLUMN; - + gtk_tree_model_get (tree_model, iter, sender_receiver_col, &address, TNY_GTK_HEADER_LIST_MODEL_FLAGS_COLUMN, &flags, -1); - + modest_text_utils_get_display_address (address); /* string is changed in-place */ - + set_cell_text (renderer, (address && address[0] != '\0')?address:_("mail_va_no_to"), flags); g_free (address); @@ -232,27 +287,21 @@ void _modest_header_view_compact_header_cell_data (GtkTreeViewColumn *column, GtkCellRenderer *renderer, GtkTreeModel *tree_model, GtkTreeIter *iter, gpointer user_data) { - /* Note that GtkTreeModel is a GtkTreeModelFilter. */ - - /* printf ("DEBUG: %s: tree_model gtype=%s\n", __FUNCTION__, G_OBJECT_TYPE_NAME (tree_model)); */ - TnyHeaderFlags flags = 0; - gchar *address = NULL; + gchar *recipients = NULL, *addresses; gchar *subject = NULL; time_t date; - -#ifdef MAEMO_CHANGES -#ifdef HAVE_GTK_TREE_VIEW_COLUMN_GET_CELL_DATA_HINT - GtkTreeCellDataHint hint; -#endif -#endif - GtkCellRenderer *recipient_cell, *date_or_status_cell, *subject_cell, *attach_cell, *priority_cell, *recipient_box, *subject_box = NULL; TnyHeader *msg_header = NULL; TnyHeaderFlags prio = 0; +#ifdef MAEMO_CHANGES +#ifdef HAVE_GTK_TREE_VIEW_COLUMN_GET_CELL_DATA_HINT + GtkTreeCellDataHint hint; +#endif +#endif g_return_if_fail (GTK_IS_TREE_VIEW_COLUMN (column)); g_return_if_fail (GTK_IS_CELL_RENDERER (renderer)); @@ -266,7 +315,7 @@ _modest_header_view_compact_header_cell_data (GtkTreeViewColumn *column, GtkCe return; #endif #endif - + recipient_box = GTK_CELL_RENDERER (g_object_get_data (G_OBJECT (renderer), "recpt-box-renderer")); subject_box = GTK_CELL_RENDERER (g_object_get_data (G_OBJECT (renderer), "subject-box-renderer")); priority_cell = GTK_CELL_RENDERER (g_object_get_data (G_OBJECT (subject_box), "priority-renderer")); @@ -280,7 +329,7 @@ _modest_header_view_compact_header_cell_data (GtkTreeViewColumn *column, GtkCe if (header_mode == MODEST_HEADER_VIEW_COMPACT_HEADER_MODE_IN) gtk_tree_model_get (tree_model, iter, TNY_GTK_HEADER_LIST_MODEL_FLAGS_COLUMN, &flags, - TNY_GTK_HEADER_LIST_MODEL_FROM_COLUMN, &address, + TNY_GTK_HEADER_LIST_MODEL_FROM_COLUMN, &recipients, TNY_GTK_HEADER_LIST_MODEL_SUBJECT_COLUMN, &subject, TNY_GTK_HEADER_LIST_MODEL_DATE_RECEIVED_TIME_T_COLUMN, &date, TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, &msg_header, @@ -288,7 +337,7 @@ _modest_header_view_compact_header_cell_data (GtkTreeViewColumn *column, GtkCe else gtk_tree_model_get (tree_model, iter, TNY_GTK_HEADER_LIST_MODEL_FLAGS_COLUMN, &flags, - TNY_GTK_HEADER_LIST_MODEL_TO_COLUMN, &address, + TNY_GTK_HEADER_LIST_MODEL_TO_COLUMN, &recipients, TNY_GTK_HEADER_LIST_MODEL_SUBJECT_COLUMN, &subject, TNY_GTK_HEADER_LIST_MODEL_DATE_SENT_TIME_T_COLUMN, &date, TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, &msg_header, @@ -313,12 +362,13 @@ _modest_header_view_compact_header_cell_data (GtkTreeViewColumn *column, GtkCe flags); g_free (subject); - /* FIXME: we hardcode the color to #666666; instead we should use SecondaryTextColour from the - * theme (gtkrc file) */ - modest_text_utils_get_display_address (address); /* changed in-place */ - set_cell_text (recipient_cell, (address && address[0] != '\0')?address:_("mail_va_no_to"), flags); - g_free (address); - + /* Show the list of senders/recipients */ + addresses = modest_text_utils_get_display_addresses ((const gchar *) recipients); + set_cell_text (recipient_cell, (addresses) ? addresses : _("mail_va_no_to"), flags); + g_free (addresses); + g_free (recipients); + + /* Show status (outbox folder) or sent date */ if (header_mode == MODEST_HEADER_VIEW_COMPACT_HEADER_MODE_OUTBOX) { ModestTnySendQueueStatus status = MODEST_TNY_SEND_QUEUE_UNKNOWN; const gchar *status_str = ""; @@ -328,7 +378,7 @@ _modest_header_view_compact_header_cell_data (GtkTreeViewColumn *column, GtkCe tny_header_set_flag (msg_header, TNY_HEADER_FLAG_SUSPENDED); } } - + status_str = get_status_string (status); set_cell_text (date_or_status_cell, status_str, flags); } else {