X-Git-Url: http://git.maemo.org/git/?p=modest;a=blobdiff_plain;f=src%2Fwidgets%2Fmodest-header-view.c;h=03e1ed8bd80302ee2ef597d63e3382de473ce40a;hp=c4f239df866433363b271d8aa429b92a8da9cc7f;hb=aab537f6ce755830767baa7260d7879449ceeb38;hpb=32aa324fb6312e9a86f9b244f63178fa1807043d diff --git a/src/widgets/modest-header-view.c b/src/widgets/modest-header-view.c index c4f239d..03e1ed8 100644 --- a/src/widgets/modest-header-view.c +++ b/src/widgets/modest-header-view.c @@ -31,6 +31,7 @@ #include #include #include +#include #include #include @@ -38,6 +39,8 @@ #include #include +#include + #include #include #include @@ -49,17 +52,30 @@ static void modest_header_view_class_init (ModestHeaderViewClass *klass); static void modest_header_view_init (ModestHeaderView *obj); static void modest_header_view_finalize (GObject *obj); +static void modest_header_view_dispose (GObject *obj); -static gboolean on_header_clicked (GtkWidget *widget, - GdkEventButton *event, - gpointer user_data); +static void on_header_row_activated (GtkTreeView *treeview, GtkTreePath *path, + GtkTreeViewColumn *column, gpointer userdata); static gint cmp_rows (GtkTreeModel *tree_model, GtkTreeIter *iter1, GtkTreeIter *iter2, gpointer user_data); -static void on_selection_changed (GtkTreeSelection *sel, +static gint cmp_subject_rows (GtkTreeModel *tree_model, + GtkTreeIter *iter1, + GtkTreeIter *iter2, + gpointer user_data); + +static gboolean filter_row (GtkTreeModel *model, + GtkTreeIter *iter, + gpointer data); + +static void on_account_removed (TnyAccountStore *self, + TnyAccount *account, + gpointer user_data); + +static void on_selection_changed (GtkTreeSelection *sel, gpointer user_data); static void setup_drag_and_drop (GtkTreeView *self); @@ -75,6 +91,26 @@ static void folder_monitor_update (TnyFolderObserver *self, static void tny_folder_observer_init (TnyFolderObserverIface *klass); +static void _clipboard_set_selected_data (ModestHeaderView *header_view, gboolean delete); + +static void _clear_hidding_filter (ModestHeaderView *header_view); + +static void modest_header_view_notify_observers( + ModestHeaderView *header_view, + GtkTreeModel *model, + const gchar *tny_folder_id); + +static gboolean modest_header_view_on_expose_event( + GtkTreeView *header_view, + GdkEventExpose *event, + gpointer user_data); + +typedef enum { + HEADER_VIEW_NON_EMPTY, + HEADER_VIEW_EMPTY, + HEADER_VIEW_INIT +} HeaderViewStatus; + typedef struct _ModestHeaderViewPrivate ModestHeaderViewPrivate; struct _ModestHeaderViewPrivate { TnyFolder *folder; @@ -83,12 +119,33 @@ struct _ModestHeaderViewPrivate { TnyFolderMonitor *monitor; GMutex *observers_lock; - gint sort_colid[2][TNY_FOLDER_TYPE_NUM]; - gint sort_type[2][TNY_FOLDER_TYPE_NUM]; + /*header-view-observer observer*/ + GMutex *observer_list_lock; + GSList *observer_list; + + /* not unref this object, its a singlenton */ + ModestEmailClipboard *clipboard; + /* Filter tree model */ + gchar **hidding_ids; + guint n_selected; + gint sort_colid[2][TNY_FOLDER_TYPE_NUM]; + gint sort_type[2][TNY_FOLDER_TYPE_NUM]; + + gulong selection_changed_handler; + gulong acc_removed_handler; + + HeaderViewStatus status; +}; + +typedef struct _HeadersCountChangedHelper HeadersCountChangedHelper; +struct _HeadersCountChangedHelper { + ModestHeaderView *self; + TnyFolderChange *change; }; + #define MODEST_HEADER_VIEW_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE((o), \ MODEST_TYPE_HEADER_VIEW, \ ModestHeaderViewPrivate)) @@ -101,7 +158,7 @@ enum { HEADER_SELECTED_SIGNAL, HEADER_ACTIVATED_SIGNAL, ITEM_NOT_FOUND_SIGNAL, - STATUS_UPDATE_SIGNAL, + MSG_COUNT_CHANGED_SIGNAL, LAST_SIGNAL }; @@ -155,6 +212,7 @@ modest_header_view_class_init (ModestHeaderViewClass *klass) parent_class = g_type_class_peek_parent (klass); gobject_class->finalize = modest_header_view_finalize; + gobject_class->dispose = modest_header_view_dispose; g_type_class_add_private (gobject_class, sizeof(ModestHeaderViewPrivate)); @@ -186,14 +244,14 @@ modest_header_view_class_init (ModestHeaderViewClass *klass) g_cclosure_marshal_VOID__INT, G_TYPE_NONE, 1, G_TYPE_INT); - signals[STATUS_UPDATE_SIGNAL] = - g_signal_new ("status_update", + signals[MSG_COUNT_CHANGED_SIGNAL] = + g_signal_new ("msg_count_changed", G_TYPE_FROM_CLASS (gobject_class), G_SIGNAL_RUN_FIRST, - G_STRUCT_OFFSET (ModestHeaderViewClass,status_update), + G_STRUCT_OFFSET (ModestHeaderViewClass, msg_count_changed), NULL, NULL, - modest_marshal_VOID__STRING_INT_INT, - G_TYPE_NONE, 3, G_TYPE_STRING, G_TYPE_INT, G_TYPE_INT); + modest_marshal_VOID__POINTER_POINTER, + G_TYPE_NONE, 2, G_TYPE_POINTER, G_TYPE_POINTER); } static void @@ -216,7 +274,7 @@ get_new_column (const gchar *name, GtkCellRenderer *renderer, if (resizable) gtk_tree_view_column_set_expand (column, TRUE); - if (show_as_text) + if (show_as_text) gtk_tree_view_column_add_attribute (column, renderer, "text", sort_col_id); if (sort_col_id >= 0) @@ -248,11 +306,11 @@ remove_all_columns (ModestHeaderView *obj) gboolean modest_header_view_set_columns (ModestHeaderView *self, const GList *columns, TnyFolderType type) { - GtkTreeModel *sortable; + GtkTreeModel *tree_filter, *sortable; GtkTreeViewColumn *column=NULL; GtkTreeSelection *selection = NULL; GtkCellRenderer *renderer_msgtype,*renderer_header, - *renderer_attach, *renderer_compact_date; + *renderer_attach, *renderer_compact_date_or_status; GtkCellRenderer *renderer_compact_header, *renderer_recpt_box, *renderer_subject, *renderer_subject_box, *renderer_recpt, *renderer_priority; @@ -273,7 +331,7 @@ modest_header_view_set_columns (ModestHeaderView *self, const GList *columns, Tn renderer_subject_box = modest_hbox_cell_renderer_new (); renderer_recpt = gtk_cell_renderer_text_new (); renderer_subject = gtk_cell_renderer_text_new (); - renderer_compact_date = gtk_cell_renderer_text_new (); + renderer_compact_date_or_status = gtk_cell_renderer_text_new (); modest_vbox_cell_renderer_append (MODEST_VBOX_CELL_RENDERER (renderer_compact_header), renderer_subject_box, FALSE); g_object_set_data (G_OBJECT (renderer_compact_header), "subject-box-renderer", renderer_subject_box); @@ -287,30 +345,40 @@ modest_header_view_set_columns (ModestHeaderView *self, const GList *columns, Tn g_object_set_data (G_OBJECT (renderer_recpt_box), "attach-renderer", renderer_attach); modest_hbox_cell_renderer_append (MODEST_HBOX_CELL_RENDERER (renderer_recpt_box), renderer_recpt, TRUE); g_object_set_data (G_OBJECT (renderer_recpt_box), "recipient-renderer", renderer_recpt); - modest_hbox_cell_renderer_append (MODEST_HBOX_CELL_RENDERER (renderer_recpt_box), renderer_compact_date, FALSE); - g_object_set_data (G_OBJECT (renderer_recpt_box), "date-renderer", renderer_compact_date); + modest_hbox_cell_renderer_append (MODEST_HBOX_CELL_RENDERER (renderer_recpt_box), renderer_compact_date_or_status, FALSE); + g_object_set_data (G_OBJECT (renderer_recpt_box), "date-renderer", renderer_compact_date_or_status); + g_object_set (G_OBJECT (renderer_subject_box), "yalign", 1.0, NULL); + gtk_cell_renderer_set_fixed_size (renderer_subject_box, -1, 32); + gtk_cell_renderer_set_fixed_size (renderer_recpt_box, -1, 32); + g_object_set (G_OBJECT (renderer_recpt_box), "yalign", 0.0, NULL); g_object_set(G_OBJECT(renderer_header), "ellipsize", PANGO_ELLIPSIZE_END, NULL); g_object_set (G_OBJECT (renderer_subject), - "ellipsize", PANGO_ELLIPSIZE_END, + "ellipsize", PANGO_ELLIPSIZE_END, "yalign", 1.0, NULL); g_object_set (G_OBJECT (renderer_recpt), - "ellipsize", PANGO_ELLIPSIZE_END, + "ellipsize", PANGO_ELLIPSIZE_END, "yalign", 0.0, NULL); - g_object_set(G_OBJECT(renderer_compact_date), - "xalign", 1.0, + g_object_set(G_OBJECT(renderer_compact_date_or_status), + "xalign", 1.0, "yalign", 0.0, NULL); - - gtk_cell_renderer_set_fixed_size (renderer_attach, 32, 32); - gtk_cell_renderer_set_fixed_size (renderer_priority, 32, 32); + g_object_set (G_OBJECT (renderer_priority), + "yalign", 1.0, NULL); + g_object_set (G_OBJECT (renderer_attach), + "yalign", 0.0, NULL); + + gtk_cell_renderer_set_fixed_size (renderer_attach, 32, 26); + gtk_cell_renderer_set_fixed_size (renderer_priority, 32, 26); + gtk_cell_renderer_set_fixed_size (renderer_compact_header, -1, 64); remove_all_columns (self); selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(self)); gtk_tree_selection_set_mode(selection, GTK_SELECTION_MULTIPLE); - sortable = gtk_tree_view_get_model (GTK_TREE_VIEW (self)); + tree_filter = gtk_tree_view_get_model (GTK_TREE_VIEW (self)); + sortable = gtk_tree_model_filter_get_model (GTK_TREE_MODEL_FILTER(tree_filter)); /* Add new columns */ for (cursor = columns; cursor; cursor = g_list_next(cursor)) { @@ -364,16 +432,18 @@ modest_header_view_set_columns (ModestHeaderView *self, const GList *columns, Tn TNY_GTK_HEADER_LIST_MODEL_FROM_COLUMN, FALSE, (GtkTreeCellDataFunc)_modest_header_view_compact_header_cell_data, - GINT_TO_POINTER(TRUE)); + GINT_TO_POINTER(MODEST_HEADER_VIEW_COMPACT_HEADER_MODE_IN)); compact_column = column; break; case MODEST_HEADER_VIEW_COLUMN_COMPACT_HEADER_OUT: column = get_new_column (_("Header"), renderer_compact_header, TRUE, - TNY_GTK_HEADER_LIST_MODEL_FROM_COLUMN, - FALSE, - (GtkTreeCellDataFunc)_modest_header_view_compact_header_cell_data, - GINT_TO_POINTER(FALSE)); + TNY_GTK_HEADER_LIST_MODEL_FROM_COLUMN, + FALSE, + (GtkTreeCellDataFunc)_modest_header_view_compact_header_cell_data, + GINT_TO_POINTER((type == TNY_FOLDER_TYPE_OUTBOX)? + MODEST_HEADER_VIEW_COMPACT_HEADER_MODE_OUTBOX: + MODEST_HEADER_VIEW_COMPACT_HEADER_MODE_OUT)); compact_column = column; break; @@ -410,7 +480,7 @@ modest_header_view_set_columns (ModestHeaderView *self, const GList *columns, Tn NULL); break; case MODEST_HEADER_VIEW_COLUMN_STATUS: - column = get_new_column (_("Status"), renderer_compact_date, TRUE, + column = get_new_column (_("Status"), renderer_compact_date_or_status, TRUE, TNY_GTK_HEADER_LIST_MODEL_MESSAGE_SIZE_COLUMN, FALSE, (GtkTreeCellDataFunc)_modest_header_view_status_cell_data, @@ -436,6 +506,10 @@ modest_header_view_set_columns (ModestHeaderView *self, const GList *columns, Tn TNY_GTK_HEADER_LIST_MODEL_FLAGS_COLUMN, (GtkTreeIterCompareFunc) cmp_rows, compact_column, NULL); + gtk_tree_sortable_set_sort_func (GTK_TREE_SORTABLE (sortable), + TNY_GTK_HEADER_LIST_MODEL_SUBJECT_COLUMN, + (GtkTreeIterCompareFunc) cmp_subject_rows, + compact_column, NULL); } @@ -455,6 +529,17 @@ modest_header_view_init (ModestHeaderView *obj) priv->monitor = NULL; priv->observers_lock = g_mutex_new (); + priv->status = HEADER_VIEW_INIT; + + priv->observer_list_lock = g_mutex_new(); + priv->observer_list = NULL; + + priv->clipboard = modest_runtime_get_email_clipboard (); + priv->hidding_ids = NULL; + priv->n_selected = 0; + priv->selection_changed_handler = 0; + priv->acc_removed_handler = 0; + /* Sort parameters */ for (j=0; j < 2; j++) { for (i=0; i < TNY_FOLDER_TYPE_NUM; i++) { @@ -467,6 +552,34 @@ modest_header_view_init (ModestHeaderView *obj) } static void +modest_header_view_dispose (GObject *obj) +{ + ModestHeaderView *self; + ModestHeaderViewPrivate *priv; + GtkTreeSelection *sel; + + self = MODEST_HEADER_VIEW(obj); + priv = MODEST_HEADER_VIEW_GET_PRIVATE(self); + + /* Free in the dispose to avoid unref cycles */ + if (priv->folder) { + tny_folder_remove_observer (priv->folder, TNY_FOLDER_OBSERVER (obj)); + g_object_unref (G_OBJECT (priv->folder)); + priv->folder = NULL; + } + + /* We need to do this here in the dispose because the + selection won't exist when finalizing */ + sel = gtk_tree_view_get_selection (GTK_TREE_VIEW(self)); + if (sel && g_signal_handler_is_connected (sel, priv->selection_changed_handler)) { + g_signal_handler_disconnect (sel, priv->selection_changed_handler); + priv->selection_changed_handler = 0; + } + + G_OBJECT_CLASS(parent_class)->dispose (obj); +} + +static void modest_header_view_finalize (GObject *obj) { ModestHeaderView *self; @@ -475,6 +588,17 @@ modest_header_view_finalize (GObject *obj) self = MODEST_HEADER_VIEW(obj); priv = MODEST_HEADER_VIEW_GET_PRIVATE(self); + if (g_signal_handler_is_connected (modest_runtime_get_account_store (), + priv->acc_removed_handler)) { + g_signal_handler_disconnect (modest_runtime_get_account_store (), + priv->acc_removed_handler); + } + + /* There is no need to lock because there should not be any + * reference to self now. */ + g_mutex_free(priv->observer_list_lock); + g_slist_free(priv->observer_list); + g_mutex_lock (priv->observers_lock); if (priv->monitor) { tny_folder_monitor_stop (priv->monitor); @@ -483,11 +607,8 @@ modest_header_view_finalize (GObject *obj) g_mutex_unlock (priv->observers_lock); g_mutex_free (priv->observers_lock); - if (priv->folder) { - tny_folder_remove_observer (priv->folder, TNY_FOLDER_OBSERVER (obj)); - g_object_unref (G_OBJECT (priv->folder)); - priv->folder = NULL; - } + /* Clear hidding array created by cut operation */ + _clear_hidding_filter (MODEST_HEADER_VIEW (obj)); G_OBJECT_CLASS(parent_class)->finalize (obj); } @@ -509,7 +630,7 @@ modest_header_view_new (TnyFolder *folder, ModestHeaderViewStyle style) priv = MODEST_HEADER_VIEW_GET_PRIVATE(self); modest_header_view_set_style (self, style); - modest_header_view_set_folder (self, NULL); +/* modest_header_view_set_folder (self, NULL, NULL, NULL); */ gtk_tree_view_columns_autosize (GTK_TREE_VIEW(obj)); gtk_tree_view_set_fixed_height_mode (GTK_TREE_VIEW(obj),TRUE); @@ -517,21 +638,62 @@ modest_header_view_new (TnyFolder *folder, ModestHeaderViewStyle style) gtk_tree_view_set_rules_hint (GTK_TREE_VIEW(obj), TRUE); /* alternating row colors */ - sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(self)); - - g_signal_connect (sel, "changed", - G_CALLBACK(on_selection_changed), self); + + sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(self)); + priv->selection_changed_handler = + g_signal_connect_after (sel, "changed", + G_CALLBACK(on_selection_changed), self); - g_signal_connect (self, "button-press-event", - G_CALLBACK(on_header_clicked), NULL); + g_signal_connect (self, "row-activated", + G_CALLBACK (on_header_row_activated), NULL); g_signal_connect (self, "focus-in-event", G_CALLBACK(on_focus_in), NULL); + priv->acc_removed_handler = g_signal_connect (modest_runtime_get_account_store (), + "account_removed", + G_CALLBACK (on_account_removed), + self); + + g_signal_connect (self, "expose-event", + G_CALLBACK(modest_header_view_on_expose_event), + NULL); + return GTK_WIDGET(self); } +guint +modest_header_view_count_selected_headers (ModestHeaderView *self) +{ + GtkTreeSelection *sel; + guint selected_rows; + + g_return_val_if_fail (self, 0); + + /* Get selection object and check selected rows count */ + sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(self)); + selected_rows = gtk_tree_selection_count_selected_rows (sel); + + return selected_rows; +} + +gboolean +modest_header_view_has_selected_headers (ModestHeaderView *self) +{ + GtkTreeSelection *sel; + gboolean empty; + + g_return_val_if_fail (self, FALSE); + + /* Get selection object and check selected rows count */ + sel = gtk_tree_view_get_selection(GTK_TREE_VIEW(self)); + empty = gtk_tree_selection_count_selected_rows (sel) == 0; + + return !empty; +} + + TnyList * modest_header_view_get_selected_headers (ModestHeaderView *self) { @@ -668,13 +830,6 @@ modest_header_view_get_columns (ModestHeaderView *self) } -gboolean -modest_header_view_is_empty (ModestHeaderView *self) -{ - g_return_val_if_fail (self, FALSE); - return FALSE; /* FIXME */ -} - gboolean modest_header_view_set_style (ModestHeaderView *self, @@ -718,6 +873,35 @@ modest_header_view_get_style (ModestHeaderView *self) return MODEST_HEADER_VIEW_GET_PRIVATE(self)->style; } +/* This is used to automatically select the first header if the user + * has not selected any header yet. + */ +static gboolean +modest_header_view_on_expose_event(GtkTreeView *header_view, + GdkEventExpose *event, + gpointer user_data) +{ + GtkTreeSelection *sel; + GtkTreeModel *model; + GtkTreeIter tree_iter; + + /* I'm invalidating this method because it causes an annoying + efect, the focus changes to the header view when selecting + a folder in the folder view because of this code and it + shouldn't. We need to find another way to set the passive + focus on it. Sergio. */ + return FALSE; + + model = gtk_tree_view_get_model(header_view); + + sel = gtk_tree_view_get_selection(header_view); + if(!gtk_tree_selection_count_selected_rows(sel)) + if (gtk_tree_model_get_iter_first(model, &tree_iter)) + gtk_tree_selection_select_iter(sel, &tree_iter); + + return FALSE; +} + /* * This function sets a sortable model in the header view. It's just * used for developing purposes, because it only does a @@ -726,21 +910,17 @@ modest_header_view_get_style (ModestHeaderView *self) static void modest_header_view_set_model (GtkTreeView *header_view, GtkTreeModel *model) { - GtkTreeModel *old_model_sort = gtk_tree_view_get_model (GTK_TREE_VIEW (header_view)); - - if (old_model_sort && GTK_IS_TREE_MODEL_SORT (old_model_sort)) { - GtkTreeModel *old_model; - ModestHeaderViewPrivate *priv; - - priv = MODEST_HEADER_VIEW_GET_PRIVATE (header_view); - old_model = gtk_tree_model_sort_get_model (GTK_TREE_MODEL_SORT (old_model_sort)); - - /* Set new model */ - gtk_tree_view_set_model (header_view, model); - } else - gtk_tree_view_set_model (header_view, model); - - return; +/* GtkTreeModel *old_model_sort = gtk_tree_view_get_model (GTK_TREE_VIEW (header_view)); */ +/* if (old_model_sort && GTK_IS_TREE_MODEL_SORT (old_model_sort)) { */ +/* GtkTreeModel *old_model; */ +/* ModestHeaderViewPrivate *priv; */ +/* priv = MODEST_HEADER_VIEW_GET_PRIVATE (header_view); */ +/* old_model = gtk_tree_model_sort_get_model (GTK_TREE_MODEL_SORT (old_model_sort)); */ + +/* /\* Set new model *\/ */ +/* gtk_tree_view_set_model (header_view, model); */ +/* } else */ + gtk_tree_view_set_model (header_view, model); } TnyFolder* @@ -762,7 +942,7 @@ modest_header_view_set_folder_intern (ModestHeaderView *self, TnyFolder *folder) TnyList *headers; ModestHeaderViewPrivate *priv; GList *cols, *cursor; - GtkTreeModel *sortable; + GtkTreeModel *filter_model, *sortable; guint sort_colid; GtkSortType sort_type; @@ -783,12 +963,22 @@ modest_header_view_set_folder_intern (ModestHeaderView *self, TnyFolder *folder) priv->monitor = TNY_FOLDER_MONITOR (tny_folder_monitor_new (folder)); tny_folder_monitor_add_list (priv->monitor, TNY_LIST (headers)); tny_folder_monitor_start (priv->monitor); - tny_folder_add_observer (folder, TNY_FOLDER_OBSERVER (self)); g_mutex_unlock (priv->observers_lock); sortable = gtk_tree_model_sort_new_with_model (GTK_TREE_MODEL(headers)); g_object_unref (G_OBJECT (headers)); + /* Init filter_row function to examine empty status */ + priv->status = HEADER_VIEW_INIT; + + /* Create a tree model filter to hide and show rows for cut operations */ + filter_model = gtk_tree_model_filter_new (sortable, NULL); + gtk_tree_model_filter_set_visible_func (GTK_TREE_MODEL_FILTER (filter_model), + filter_row, + self, + NULL); + g_object_unref (G_OBJECT (sortable)); + /* install our special sorting functions */ cursor = cols = gtk_tree_view_get_columns (GTK_TREE_VIEW(self)); @@ -804,11 +994,19 @@ modest_header_view_set_folder_intern (ModestHeaderView *self, TnyFolder *folder) TNY_GTK_HEADER_LIST_MODEL_FLAGS_COLUMN, (GtkTreeIterCompareFunc) cmp_rows, cols->data, NULL); + gtk_tree_sortable_set_sort_func (GTK_TREE_SORTABLE(sortable), + TNY_GTK_HEADER_LIST_MODEL_SUBJECT_COLUMN, + (GtkTreeIterCompareFunc) cmp_subject_rows, + cols->data, NULL); } /* Set new model */ - modest_header_view_set_model (GTK_TREE_VIEW (self), sortable); - g_object_unref (G_OBJECT (sortable)); + modest_header_view_set_model (GTK_TREE_VIEW (self), filter_model); + modest_header_view_notify_observers(self, GTK_TREE_MODEL(filter_model), + tny_folder_get_id(folder)); + g_object_unref (G_OBJECT (filter_model)); +/* modest_header_view_set_model (GTK_TREE_VIEW (self), sortable); */ +/* g_object_unref (G_OBJECT (sortable)); */ /* Free */ g_list_free (cols); @@ -820,12 +1018,14 @@ modest_header_view_sort_by_column_id (ModestHeaderView *self, GtkSortType sort_type) { ModestHeaderViewPrivate *priv = NULL; - GtkTreeModel *sortable = NULL; + GtkTreeModel *tree_filter, *sortable = NULL; TnyFolderType type; /* Get model and private data */ priv = MODEST_HEADER_VIEW_GET_PRIVATE(self); - sortable = gtk_tree_view_get_model (GTK_TREE_VIEW (self)); + tree_filter = gtk_tree_view_get_model (GTK_TREE_VIEW (self)); + sortable = gtk_tree_model_filter_get_model (GTK_TREE_MODEL_FILTER(tree_filter)); +/* sortable = gtk_tree_view_get_model (GTK_TREE_VIEW (self)); */ /* Sort tree model */ type = modest_tny_folder_guess_folder_type (priv->folder); @@ -883,11 +1083,51 @@ modest_header_view_get_sort_type (ModestHeaderView *self, return priv->sort_type[style][type]; } -void -modest_header_view_set_folder (ModestHeaderView *self, TnyFolder *folder) +typedef struct { + ModestHeaderView *header_view; + RefreshAsyncUserCallback cb; + gpointer user_data; +} SetFolderHelper; + +static void +folder_refreshed_cb (ModestMailOperation *mail_op, + TnyFolder *folder, + gpointer user_data) { ModestHeaderViewPrivate *priv; + SetFolderHelper *info; + + info = (SetFolderHelper*) user_data; + + priv = MODEST_HEADER_VIEW_GET_PRIVATE(info->header_view); + + /* User callback */ + if (info->cb) + info->cb (mail_op, folder, info->user_data); + /* Start the folder count changes observer. We do not need it + before the refresh. Note that the monitor could still be + called for this refresh but now we know that the callback + was previously called */ + g_mutex_lock (priv->observers_lock); + tny_folder_add_observer (folder, TNY_FOLDER_OBSERVER (info->header_view)); + g_mutex_unlock (priv->observers_lock); + + /* Frees */ + g_free (info); +} + +void +modest_header_view_set_folder (ModestHeaderView *self, + TnyFolder *folder, + RefreshAsyncUserCallback callback, + gpointer user_data) +{ + ModestHeaderViewPrivate *priv; + ModestWindowMgr *mgr = NULL; + GObject *source = NULL; + SetFolderHelper *info; + priv = MODEST_HEADER_VIEW_GET_PRIVATE(self); if (priv->folder) { @@ -899,7 +1139,12 @@ modest_header_view_set_folder (ModestHeaderView *self, TnyFolder *folder) } if (folder) { - ModestMailOperation *mail_op; + ModestMailOperation *mail_op = NULL; + GtkTreeSelection *selection; + + /* Get main window to use it as source of mail operation */ + mgr = modest_runtime_get_window_mgr (); + source = G_OBJECT (modest_window_mgr_get_main_window (modest_runtime_get_window_mgr ())); /* Set folder in the model */ modest_header_view_set_folder_intern (self, folder); @@ -907,20 +1152,30 @@ modest_header_view_set_folder (ModestHeaderView *self, TnyFolder *folder) /* Pick my reference. Nothing to do with the mail operation */ priv->folder = g_object_ref (folder); - /* no message selected */ + /* Clear the selection if exists */ + selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(self)); + gtk_tree_selection_unselect_all(selection); g_signal_emit (G_OBJECT(self), signals[HEADER_SELECTED_SIGNAL], 0, NULL); - /* Create the mail operation */ - mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_RECEIVE, NULL); + /* create the helper */ + info = g_malloc0 (sizeof(SetFolderHelper)); + info->header_view = self; + info->cb = callback; + info->user_data = user_data; + + /* Create the mail operation (source will be the parent widget) */ + mail_op = modest_mail_operation_new (MODEST_MAIL_OPERATION_TYPE_RECEIVE, source); modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (), mail_op); /* Refresh the folder asynchronously */ - modest_mail_operation_refresh_folder (mail_op, folder); + modest_mail_operation_refresh_folder (mail_op, + folder, + folder_refreshed_cb, + info); /* Free */ g_object_unref (mail_op); - } else { g_mutex_lock (priv->observers_lock); @@ -931,56 +1186,64 @@ modest_header_view_set_folder (ModestHeaderView *self, TnyFolder *folder) } modest_header_view_set_model (GTK_TREE_VIEW (self), NULL); + modest_header_view_notify_observers(self, NULL, NULL); + g_mutex_unlock (priv->observers_lock); } } -static gboolean -on_header_clicked (GtkWidget *widget, GdkEventButton *event, gpointer user_data) +static void +on_header_row_activated (GtkTreeView *treeview, GtkTreePath *path, + GtkTreeViewColumn *column, gpointer userdata) { ModestHeaderView *self = NULL; ModestHeaderViewPrivate *priv = NULL; - GtkTreePath *path = NULL; GtkTreeIter iter; GtkTreeModel *model = NULL; - TnyHeader *header; - /* ignore everything but doubleclick */ - if (event->type != GDK_2BUTTON_PRESS) - return FALSE; + TnyHeader *header = NULL; + TnyHeaderFlags flags; - self = MODEST_HEADER_VIEW (widget); + self = MODEST_HEADER_VIEW (treeview); priv = MODEST_HEADER_VIEW_GET_PRIVATE(self); - - path = get_selected_row (GTK_TREE_VIEW(self), &model); + + model = gtk_tree_view_get_model (treeview); if ((path == NULL) || (!gtk_tree_model_get_iter(model, &iter, path))) - return FALSE; - + goto frees; + /* get the first selected item */ gtk_tree_model_get (model, &iter, - TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, - &header, -1); + TNY_GTK_HEADER_LIST_MODEL_FLAGS_COLUMN, &flags, + TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, &header, + -1); + + /* Dont open DELETED messages */ + if (flags & TNY_HEADER_FLAG_DELETED) { + modest_platform_information_banner (NULL, NULL, _("mcen_ib_message_already_deleted")); + goto frees; + } + /* Emit signal */ g_signal_emit (G_OBJECT(self), signals[HEADER_ACTIVATED_SIGNAL], 0, header); /* Free */ - g_object_unref (G_OBJECT (header)); - gtk_tree_path_free(path); + frees: + if (header != NULL) + g_object_unref (G_OBJECT (header)); - return TRUE; } - static void on_selection_changed (GtkTreeSelection *sel, gpointer user_data) { GtkTreeModel *model; - TnyHeader *header; + TnyHeader *header = NULL; GtkTreePath *path = NULL; GtkTreeIter iter; ModestHeaderView *self; ModestHeaderViewPrivate *priv; + GList *selected = NULL; g_return_if_fail (sel); g_return_if_fail (user_data); @@ -988,7 +1251,9 @@ on_selection_changed (GtkTreeSelection *sel, gpointer user_data) self = MODEST_HEADER_VIEW (user_data); priv = MODEST_HEADER_VIEW_GET_PRIVATE(self); - path = get_selected_row (GTK_TREE_VIEW(self), &model); + selected = gtk_tree_selection_get_selected_rows (sel, &model); + if (selected != NULL) + path = (GtkTreePath *) selected->data; if ((path == NULL) || (!gtk_tree_model_get_iter(model, &iter, path))) return; /* msg was _un_selected */ @@ -1002,7 +1267,10 @@ on_selection_changed (GtkTreeSelection *sel, gpointer user_data) 0, header); g_object_unref (G_OBJECT (header)); - gtk_tree_path_free(path); + + /* free all items in 'selected' */ + g_list_foreach (selected, (GFunc)gtk_tree_path_free, NULL); + g_list_free (selected); } @@ -1020,6 +1288,16 @@ _modest_header_view_change_selection (GtkTreeSelection *selection, on_selection_changed (selection, user_data); } +static gint compare_priorities (TnyHeaderFlags p1, TnyHeaderFlags p2) +{ + p1 = p1 & TNY_HEADER_FLAG_PRIORITY; + p2 = p2 & TNY_HEADER_FLAG_PRIORITY; + if (p1 == 0) + p1 = TNY_HEADER_FLAG_LOW_PRIORITY + 1; + if (p2 == 0) + p2 = TNY_HEADER_FLAG_LOW_PRIORITY + 1; + return p1 - p2; +} static gint cmp_rows (GtkTreeModel *tree_model, GtkTreeIter *iter1, GtkTreeIter *iter2, @@ -1029,19 +1307,13 @@ cmp_rows (GtkTreeModel *tree_model, GtkTreeIter *iter1, GtkTreeIter *iter2, gint t1, t2; gint val1, val2; gint cmp; - static int counter = 0; +/* static int counter = 0; */ g_return_val_if_fail (GTK_IS_TREE_VIEW_COLUMN(user_data), 0); /* col_id = gtk_tree_sortable_get_sort_column_id (GTK_TREE_SORTABLE (tree_model)); */ col_id = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(user_data), MODEST_HEADER_VIEW_FLAG_SORT)); + - if (!(++counter % 100)) { - GObject *header_view = g_object_get_data(G_OBJECT(user_data), - MODEST_HEADER_VIEW_PTR); - g_signal_emit (header_view, - signals[STATUS_UPDATE_SIGNAL], - 0, _("Sorting..."), 0, 0); - } switch (col_id) { case TNY_HEADER_FLAG_ATTACHMENTS: @@ -1063,10 +1335,7 @@ cmp_rows (GtkTreeModel *tree_model, GtkTreeIter *iter1, GtkTreeIter *iter2, /* This is for making priority values respect the intuitive sort relationship * as HIGH is 11, LOW is 01, and we put NORMAL AS 10 (2) */ - if (val1 == 0) val1 = 2; - if (val2 == 0) val2 = 2; - - cmp = (val1 & TNY_HEADER_FLAG_PRIORITY) - (val2 & TNY_HEADER_FLAG_PRIORITY); + cmp = compare_priorities (val1, val2); return cmp ? cmp : t1 - t2; @@ -1075,6 +1344,30 @@ cmp_rows (GtkTreeModel *tree_model, GtkTreeIter *iter1, GtkTreeIter *iter2, } } +static gint +cmp_subject_rows (GtkTreeModel *tree_model, GtkTreeIter *iter1, GtkTreeIter *iter2, + gpointer user_data) +{ + gint t1, t2; + gchar *val1, *val2; + gint cmp; +/* static int counter = 0; */ + + g_return_val_if_fail (GTK_IS_TREE_VIEW_COLUMN(user_data), 0); + + gtk_tree_model_get (tree_model, iter1, TNY_GTK_HEADER_LIST_MODEL_SUBJECT_COLUMN, &val1, + TNY_GTK_HEADER_LIST_MODEL_DATE_SENT_TIME_T_COLUMN, &t1, -1); + gtk_tree_model_get (tree_model, iter2, TNY_GTK_HEADER_LIST_MODEL_SUBJECT_COLUMN, &val2, + TNY_GTK_HEADER_LIST_MODEL_DATE_SENT_TIME_T_COLUMN, &t2, -1); + + cmp = modest_text_utils_utf8_strcmp (val1 + modest_text_utils_get_subject_prefix_len(val1), + val2 + modest_text_utils_get_subject_prefix_len(val2), + TRUE); + g_free (val1); + g_free (val2); + return cmp; +} + /* Drag and drop stuff */ static void drag_data_get_cb (GtkWidget *widget, GdkDragContext *context, @@ -1084,8 +1377,10 @@ drag_data_get_cb (GtkWidget *widget, GdkDragContext *context, GtkTreeModel *model = NULL; GtkTreeIter iter; GtkTreePath *source_row = NULL; +/* GtkTreeSelection *sel = NULL;*/ source_row = get_selected_row (GTK_TREE_VIEW (widget), &model); + if ((source_row == NULL) || (!gtk_tree_model_get_iter(model, &iter, source_row))) return; switch (info) { @@ -1093,7 +1388,7 @@ drag_data_get_cb (GtkWidget *widget, GdkDragContext *context, gtk_tree_set_row_drag_data (selection_data, model, source_row); break; case MODEST_MSG: { - TnyHeader *hdr; + TnyHeader *hdr = NULL; gtk_tree_model_get (model, &iter, TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, &hdr, -1); @@ -1106,7 +1401,15 @@ drag_data_get_cb (GtkWidget *widget, GdkDragContext *context, g_message ("%s: default switch case.", __FUNCTION__); } + /* commenting out the next, fixes NB#62963 */ +#if 0 + /* Set focus on next header */ + sel = gtk_tree_view_get_selection(GTK_TREE_VIEW (widget)); + gtk_tree_path_next (source_row); + gtk_tree_selection_select_path (sel, source_row); + gtk_tree_path_free (source_row); +#endif } /* Header view drag types */ @@ -1187,6 +1490,7 @@ on_focus_in (GtkWidget *self, /* Need to get the all the rows because is selection multiple */ selected = gtk_tree_selection_get_selected_rows (selection, &model); + if (selected == NULL) return FALSE; selected_path = (GtkTreePath *) selected->data; /* Check if we need to scroll */ @@ -1209,6 +1513,11 @@ on_focus_in (GtkWidget *self, 0.0); } } + if (start_path) + gtk_tree_path_free (start_path); + if (end_path) + gtk_tree_path_free (end_path); + #endif /* GTK_CHECK_VERSION */ /* Frees */ @@ -1219,33 +1528,339 @@ on_focus_in (GtkWidget *self, } static void +idle_notify_headers_count_changed_destroy (gpointer data) +{ + HeadersCountChangedHelper *helper = NULL; + + g_return_if_fail (data != NULL); + helper = (HeadersCountChangedHelper *) data; + + g_object_unref (helper->change); + g_slice_free (HeadersCountChangedHelper, helper); +} + +static gboolean +idle_notify_headers_count_changed (gpointer data) +{ + TnyFolder *folder = NULL; + ModestHeaderViewPrivate *priv = NULL; + HeadersCountChangedHelper *helper = NULL; + + g_return_val_if_fail (data != NULL, FALSE); + helper = (HeadersCountChangedHelper *) data; + g_return_val_if_fail (MODEST_IS_HEADER_VIEW(helper->self), FALSE); + g_return_val_if_fail (TNY_FOLDER_CHANGE(helper->change), FALSE); + + folder = tny_folder_change_get_folder (helper->change); + + priv = MODEST_HEADER_VIEW_GET_PRIVATE (helper->self); + + g_mutex_lock (priv->observers_lock); + + /* Emit signal to evaluate how headers changes affects to the window view */ + g_signal_emit (G_OBJECT(helper->self), + signals[MSG_COUNT_CHANGED_SIGNAL], + 0, folder, helper->change); + + /* Added or removed headers, so data stored on cliboard are invalid */ + if (modest_email_clipboard_check_source_folder (priv->clipboard, folder)) + modest_email_clipboard_clear (priv->clipboard); + + g_mutex_unlock (priv->observers_lock); + + return FALSE; +} + +static void folder_monitor_update (TnyFolderObserver *self, TnyFolderChange *change) { - ModestHeaderViewPrivate *priv = MODEST_HEADER_VIEW_GET_PRIVATE (self); + ModestHeaderViewPrivate *priv = NULL; TnyFolderChangeChanged changed; - - g_mutex_lock (priv->observers_lock); + HeadersCountChangedHelper *helper = NULL; + TnyFolder *folder = NULL; changed = tny_folder_change_get_changed (change); + + /* Do not notify the observers if the folder of the header + view has changed before this call to the observer + happens */ + priv = MODEST_HEADER_VIEW_GET_PRIVATE (MODEST_HEADER_VIEW (self)); + folder = tny_folder_change_get_folder (change); + if (folder != priv->folder) + goto frees; + + /* Check folder count */ + if ((changed & TNY_FOLDER_CHANGE_CHANGED_ADDED_HEADERS) || + (changed & TNY_FOLDER_CHANGE_CHANGED_EXPUNGED_HEADERS)) { + helper = g_slice_new0 (HeadersCountChangedHelper); + helper->self = MODEST_HEADER_VIEW(self); + helper->change = g_object_ref(change); + +/* if (folder != NULL) */ +/* tny_folder_poke_status (folder); */ + + idle_notify_headers_count_changed (helper); + idle_notify_headers_count_changed_destroy (helper); + } + + /* Free */ + frees: + if (folder != NULL) + g_object_unref (folder); +} + +gboolean +modest_header_view_is_empty (ModestHeaderView *self) +{ + ModestHeaderViewPrivate *priv = NULL; + + priv = MODEST_HEADER_VIEW_GET_PRIVATE (MODEST_HEADER_VIEW (self)); + + return priv->status == HEADER_VIEW_EMPTY; +} + +void +modest_header_view_clear (ModestHeaderView *self) +{ + modest_header_view_set_folder (self, NULL, NULL, NULL); +} - if (changed & TNY_FOLDER_CHANGE_CHANGED_ADDED_HEADERS) { -/* TnyIterator *iter; */ -/* TnyList *list; */ -/* /\* The added headers *\/ */ -/* list = tny_simple_list_new (); */ -/* tny_folder_change_get_added_headers (change, list); */ -/* iter = tny_list_create_iterator (list); */ -/* while (!tny_iterator_is_done (iter)) */ -/* { */ -/* TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iter)); */ -/* g_object_unref (G_OBJECT (header)); */ -/* tny_iterator_next (iter); */ -/* } */ -/* g_object_unref (G_OBJECT (iter)); */ -/* g_object_unref (G_OBJECT (list)); */ - modest_platform_on_new_msg (); +void +modest_header_view_copy_selection (ModestHeaderView *header_view) +{ + /* Copy selection */ + _clipboard_set_selected_data (header_view, FALSE); +} + +void +modest_header_view_cut_selection (ModestHeaderView *header_view) +{ + ModestHeaderViewPrivate *priv = NULL; + const gchar **hidding = NULL; + guint i, n_selected; + + g_return_if_fail (MODEST_IS_HEADER_VIEW (header_view)); + priv = MODEST_HEADER_VIEW_GET_PRIVATE (header_view); + + /* Copy selection */ + _clipboard_set_selected_data (header_view, TRUE); + + /* Get hidding ids */ + hidding = modest_email_clipboard_get_hidding_ids (priv->clipboard, &n_selected); + + /* Clear hidding array created by previous cut operation */ + _clear_hidding_filter (MODEST_HEADER_VIEW (header_view)); + + /* Copy hidding array */ + priv->n_selected = n_selected; + priv->hidding_ids = g_malloc0(sizeof(gchar *) * n_selected); + for (i=0; i < n_selected; i++) + priv->hidding_ids[i] = g_strdup(hidding[i]); + + /* Hide cut headers */ + modest_header_view_refilter (header_view); +} + + + + +static void +_clipboard_set_selected_data (ModestHeaderView *header_view, + gboolean delete) +{ + ModestHeaderViewPrivate *priv = NULL; + TnyList *headers = NULL; + + g_return_if_fail (MODEST_IS_HEADER_VIEW (header_view)); + priv = MODEST_HEADER_VIEW_GET_PRIVATE (header_view); + + /* Set selected data on clipboard */ + g_return_if_fail (MODEST_IS_EMAIL_CLIPBOARD (priv->clipboard)); + headers = modest_header_view_get_selected_headers (header_view); + modest_email_clipboard_set_data (priv->clipboard, priv->folder, headers, delete); + + /* Free */ + g_object_unref (headers); +} + + + +static gboolean +filter_row (GtkTreeModel *model, + GtkTreeIter *iter, + gpointer user_data) +{ + ModestHeaderViewPrivate *priv = NULL; + TnyHeaderFlags flags; + TnyHeader *header = NULL; + guint i; + gchar *id = NULL; + gboolean visible = TRUE; + gboolean found = FALSE; + + g_return_val_if_fail (MODEST_IS_HEADER_VIEW (user_data), FALSE); + priv = MODEST_HEADER_VIEW_GET_PRIVATE (user_data); + + /* Get header from model */ + gtk_tree_model_get (model, iter, + TNY_GTK_HEADER_LIST_MODEL_FLAGS_COLUMN, &flags, + TNY_GTK_HEADER_LIST_MODEL_INSTANCE_COLUMN, &header, + -1); + + /* Hide mark as deleted heders */ + if (flags & TNY_HEADER_FLAG_DELETED) { + visible = FALSE; + goto frees; } - g_mutex_unlock (priv->observers_lock); + /* If no data on clipboard, return always TRUE */ + if (modest_email_clipboard_cleared(priv->clipboard)) { + visible = TRUE; + goto frees; + } + + /* Get message id from header (ensure is a valid id) */ + if (!header) return FALSE; + id = g_strdup(tny_header_get_message_id (header)); + + /* Check hiding */ + if (priv->hidding_ids != NULL) { + for (i=0; i < priv->n_selected && !found; i++) + if (priv->hidding_ids[i] != NULL && id != NULL) + found = (!strcmp (priv->hidding_ids[i], id)); + + visible = !found; + } + + frees: + priv->status = ((gboolean) priv->status) && !visible; + + /* Free */ + if (header) + g_object_unref (header); + g_free(id); + + return visible; +} + +static void +_clear_hidding_filter (ModestHeaderView *header_view) +{ + ModestHeaderViewPrivate *priv = NULL; + guint i; + + g_return_if_fail (MODEST_IS_HEADER_VIEW (header_view)); + priv = MODEST_HEADER_VIEW_GET_PRIVATE(header_view); + + if (priv->hidding_ids != NULL) { + for (i=0; i < priv->n_selected; i++) + g_free (priv->hidding_ids[i]); + g_free(priv->hidding_ids); + } +} + +void +modest_header_view_refilter (ModestHeaderView *header_view) +{ + GtkTreeModel *model = NULL; + ModestHeaderViewPrivate *priv = NULL; + + g_return_if_fail (MODEST_IS_HEADER_VIEW (header_view)); + priv = MODEST_HEADER_VIEW_GET_PRIVATE(header_view); + + priv->status = HEADER_VIEW_EMPTY; + + /* Hide cut headers */ + model = gtk_tree_view_get_model (GTK_TREE_VIEW (header_view)); + if (GTK_IS_TREE_MODEL_FILTER (model)) + gtk_tree_model_filter_refilter (GTK_TREE_MODEL_FILTER (model)); +} + +/* + * Called when an account is removed. If I'm showing a folder of the + * account that has been removed then clear the view + */ +static void +on_account_removed (TnyAccountStore *self, + TnyAccount *account, + gpointer user_data) +{ + ModestHeaderViewPrivate *priv = NULL; + + /* Ignore changes in transport accounts */ + if (TNY_IS_TRANSPORT_ACCOUNT (account)) + return; + + g_print ("--------------------- HEADER ---------------\n"); + + priv = MODEST_HEADER_VIEW_GET_PRIVATE (user_data); + + if (priv->folder) { + TnyAccount *my_account; + + my_account = tny_folder_get_account (priv->folder); + if (my_account == account) + modest_header_view_clear (MODEST_HEADER_VIEW (user_data)); + g_object_unref (account); + } } + +void modest_header_view_add_observer( + ModestHeaderView *header_view, + ModestHeaderViewObserver *observer) +{ + ModestHeaderViewPrivate *priv = NULL; + + g_assert(MODEST_IS_HEADER_VIEW(header_view)); + g_assert(observer != NULL); + g_assert(MODEST_IS_HEADER_VIEW_OBSERVER(observer)); + + priv = MODEST_HEADER_VIEW_GET_PRIVATE(header_view); + + g_mutex_lock(priv->observer_list_lock); + priv->observer_list = g_slist_prepend(priv->observer_list, observer); + g_mutex_unlock(priv->observer_list_lock); +} + +void modest_header_view_remove_observer( + ModestHeaderView *header_view, + ModestHeaderViewObserver *observer) +{ + ModestHeaderViewPrivate *priv = NULL; + + g_assert(MODEST_IS_HEADER_VIEW(header_view)); + g_assert(observer != NULL); + g_assert(MODEST_IS_HEADER_VIEW_OBSERVER(observer)); + + priv = MODEST_HEADER_VIEW_GET_PRIVATE(header_view); + + g_mutex_lock(priv->observer_list_lock); + priv->observer_list = g_slist_remove(priv->observer_list, observer); + g_mutex_unlock(priv->observer_list_lock); +} + +static void modest_header_view_notify_observers( + ModestHeaderView *header_view, + GtkTreeModel *model, + const gchar *tny_folder_id) +{ + ModestHeaderViewPrivate *priv = NULL; + GSList *iter; + ModestHeaderViewObserver *observer; + + g_assert(MODEST_IS_HEADER_VIEW(header_view)); + + priv = MODEST_HEADER_VIEW_GET_PRIVATE(header_view); + + g_mutex_lock(priv->observer_list_lock); + iter = priv->observer_list; + while(iter != NULL){ + observer = MODEST_HEADER_VIEW_OBSERVER(iter->data); + modest_header_view_observer_update(observer, model, + tny_folder_id); + iter = g_slist_next(iter); + } + g_mutex_unlock(priv->observer_list_lock); +} +