Work to fix NB#82451.

* src/maemo/modest-account-settings-dialog.c:
        * Properly use the save password flag to only avoid showing the
          settings saved banner if the dialog was not requested by a
          wrong password event.
* src/modest-tny-account-store.c:
        * Properly set the settings dialog as being called for saving
          a password on wrong password event.

pmo-trunk-r4323

diff --git a/src/maemo/modest-account-settings-dialog.c b/src/maemo/modest-account-settings-dialog.c
index d96fbf0..bb1701b 100644 (file)
--- a/src/maemo/modest-account-settings-dialog.c
+++ b/src/maemo/modest-account-settings-dialog.c
@@ -1128,7 +1128,7 @@ on_response (GtkDialog *wizard_dialog,
                                        g_object_unref (store_settings);
                                        g_object_unref (transport_settings);
                                        
-                                       if (self->save_password)
+                                       if (!self->save_password)
                                                hildon_banner_show_information(NULL, NULL, _("mcen_ib_advsetup_settings_saved"));
                                }
                        } else {

diff --git a/src/modest-tny-account-store.c b/src/modest-tny-account-store.c
index 22bb121..3f3953e 100644 (file)
--- a/src/modest-tny-account-store.c
+++ b/src/modest-tny-account-store.c
@@ -537,6 +537,7 @@ show_wrong_password_dialog (TnyAccount *account)
        }
        
        dialog = modest_tny_account_store_show_account_settings_dialog (self, modest_account_name);
+       modest_account_settings_dialog_save_password (MODEST_ACCOUNT_SETTINGS_DIALOG (dialog));
        /* Show an explanatory temporary banner: */
        modest_platform_information_banner (GTK_WIDGET(dialog), NULL, _("mcen_ib_username_pw_incorrect"));
 }