2007-05-23 Christian Kellner <ckellner@openismus.com>

* src/modest-mail-operation.c:
	(modest_mail_operation_update_account):
	Use info->max_size instead of unintialized local var [small
	build fix]. (Added TODO to review that change since I don't
	know the code)

pmo-trunk-r1962

diff --git a/ChangeLog2 b/ChangeLog2
index dab6a4d..22ab4f1 100644 (file)
--- a/ChangeLog2
+++ b/ChangeLog2
@@ -1,3 +1,11 @@
+2007-05-23  Christian Kellner  <ckellner@openismus.com>
+
+       * src/modest-mail-operation.c:
+       (modest_mail_operation_update_account):
+       Use info->max_size instead of unintialized local var [small
+       build fix]. (Added TODO to review that change since I don't
+       know the code)
+

 2007-05-23  Marcus Bauer  <marcusb@openismus.com>
 
        * libmodest-dbus-client/libmodest-dbus-client.c:
 2007-05-23  Marcus Bauer  <marcusb@openismus.com>
 
        * libmodest-dbus-client/libmodest-dbus-client.c:

diff --git a/src/modest-mail-operation.c b/src/modest-mail-operation.c
index 7ccdcb4..a551a16 100644 (file)
--- a/src/modest-mail-operation.c
+++ b/src/modest-mail-operation.c
@@ -604,7 +604,6 @@ modest_mail_operation_update_account (ModestMailOperation *self,
        ModestAccountMgr *mgr;
        TnyStoreAccount *modest_account;
        TnyTransportAccount *transport_account;
        ModestAccountMgr *mgr;
        TnyStoreAccount *modest_account;
        TnyTransportAccount *transport_account;

-       gint max_size;

 
        g_return_val_if_fail (MODEST_IS_MAIL_OPERATION (self), FALSE);
        g_return_val_if_fail (account_name, FALSE);
 
        g_return_val_if_fail (MODEST_IS_MAIL_OPERATION (self), FALSE);
        g_return_val_if_fail (account_name, FALSE);

@@ -657,7 +656,7 @@ modest_mail_operation_update_account (ModestMailOperation *self,
        if (info->max_size == 0)
                info->max_size = G_MAXINT;
        else
        if (info->max_size == 0)
                info->max_size = G_MAXINT;
        else

-               info->max_size = max_size * KB;
+               info->max_size = info->max_size * KB; /* TODO: review this fix */

 
        mgr = modest_runtime_get_account_mgr ();
        info->retrieve_type = modest_account_mgr_get_string (mgr, account_name, MODEST_ACCOUNT_RETRIEVE, FALSE);
 
        mgr = modest_runtime_get_account_mgr ();
        info->retrieve_type = modest_account_mgr_get_string (mgr, account_name, MODEST_ACCOUNT_RETRIEVE, FALSE);