Add support for disabling size in details dialog

pmo-trunk-r8922

diff --git a/src/gnome/modest-platform.c b/src/gnome/modest-platform.c
index 1cf8680..a4817aa 100644 (file)
--- a/src/gnome/modest-platform.c
+++ b/src/gnome/modest-platform.c
@@ -551,7 +551,7 @@ modest_platform_run_header_details_dialog (GtkWindow *parent_window,
        GtkWidget *dialog;
        
        /* Create dialog */
-       dialog = modest_details_dialog_new_with_header (parent_window, header);
+       dialog = modest_details_dialog_new_with_header (parent_window, header, TRUE);
 
        /* Run dialog */
        modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), 

diff --git a/src/hildon2/modest-hildon2-details-dialog.c b/src/hildon2/modest-hildon2-details-dialog.c
index 89675c3..2bc983a 100644 (file)
--- a/src/hildon2/modest-hildon2-details-dialog.c
+++ b/src/hildon2/modest-hildon2-details-dialog.c
@@ -89,7 +89,8 @@ modest_hildon2_details_dialog_init (ModestHildon2DetailsDialog *self)
 
 GtkWidget*
 modest_hildon2_details_dialog_new_with_header (GtkWindow *parent, 
-                                              TnyHeader *header)
+                                              TnyHeader *header,
+                                              gboolean get_size)
 {
        ModestDetailsDialog *dialog;
 
@@ -101,7 +102,7 @@ modest_hildon2_details_dialog_new_with_header (GtkWindow *parent,
                                                        NULL));
 
        MODEST_DETAILS_DIALOG_GET_CLASS (dialog)->create_container_func (dialog);
-       MODEST_DETAILS_DIALOG_GET_CLASS (dialog)->set_header_func (dialog, header);
+       MODEST_DETAILS_DIALOG_GET_CLASS (dialog)->set_header_func (dialog, header, get_size);
 
        return GTK_WIDGET (dialog);
 }

diff --git a/src/hildon2/modest-hildon2-details-dialog.h b/src/hildon2/modest-hildon2-details-dialog.h
index 493e3de..c063d39 100644 (file)
--- a/src/hildon2/modest-hildon2-details-dialog.h
+++ b/src/hildon2/modest-hildon2-details-dialog.h
@@ -72,7 +72,8 @@ typedef struct {
 GType modest_hildon2_details_dialog_get_type (void);
 
 GtkWidget* modest_hildon2_details_dialog_new_with_header (GtkWindow *parent, 
-                                                         TnyHeader *header);
+                                                         TnyHeader *header,
+                                                         gboolean get_size);
 
 GtkWidget* modest_hildon2_details_dialog_new_with_folder  (GtkWindow *parent, 
                                                           TnyFolder *folder);

diff --git a/src/hildon2/modest-platform.c b/src/hildon2/modest-platform.c
index 4c29634..9ce024a 100644 (file)
--- a/src/hildon2/modest-platform.c
+++ b/src/hildon2/modest-platform.c
@@ -2441,7 +2441,7 @@ modest_platform_run_header_details_dialog (GtkWindow *parent_window,
        GtkWidget *dialog;
 
        /* Create dialog */
-       dialog = modest_hildon2_details_dialog_new_with_header (parent_window, header);
+       dialog = modest_hildon2_details_dialog_new_with_header (parent_window, header, TRUE);
 
        /* Run dialog */
        modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), 

diff --git a/src/maemo/modest-platform.c b/src/maemo/modest-platform.c
index 83ef31e..08cc03b 100644 (file)
--- a/src/maemo/modest-platform.c
+++ b/src/maemo/modest-platform.c
@@ -2153,7 +2153,7 @@ modest_platform_run_header_details_dialog (GtkWindow *parent_window,
        GtkWidget *dialog;
        
        /* Create dialog */
-       dialog = modest_details_dialog_new_with_header (parent_window, header);
+       dialog = modest_details_dialog_new_with_header (parent_window, header, TRUE);
 
        /* Run dialog */
        modest_window_mgr_set_modal (modest_runtime_get_window_mgr (), 

diff --git a/src/widgets/modest-details-dialog.c b/src/widgets/modest-details-dialog.c
index c269c4a..ade62c9 100644 (file)
--- a/src/widgets/modest-details-dialog.c
+++ b/src/widgets/modest-details-dialog.c
@@ -46,11 +46,15 @@
 #include <string.h> /* for strlen */
 
 static void    modest_details_dialog_set_header_default          (ModestDetailsDialog *self,
-                                                                 TnyHeader *header);
+                                                                 TnyHeader *header,
+                                                                 gboolean get_size);
 
 static void    modest_details_dialog_set_folder_default          (ModestDetailsDialog *self,
                                                                  TnyFolder *foler);
 
+static void    modest_details_dialog_set_message_size_default    (ModestDetailsDialog *self, 
+                                                                 guint message_size);
+
 static void    modest_details_dialog_create_container_default    (ModestDetailsDialog *self);
 
 static void    modest_details_dialog_add_data_default            (ModestDetailsDialog *self,
@@ -90,6 +94,7 @@ modest_details_dialog_class_init (ModestDetailsDialogClass *klass)
        klass->create_container_func = modest_details_dialog_create_container_default;
        klass->add_data_func = modest_details_dialog_add_data_default;
        klass->set_header_func = modest_details_dialog_set_header_default;
+       klass->set_message_size_func = modest_details_dialog_set_message_size_default;
        klass->set_folder_func = modest_details_dialog_set_folder_default;
 }
 
@@ -100,7 +105,8 @@ modest_details_dialog_init (ModestDetailsDialog *self)
 
 GtkWidget*
 modest_details_dialog_new_with_header (GtkWindow *parent, 
-                                      TnyHeader *header)
+                                      TnyHeader *header,
+                                      gboolean get_size)
 {
        ModestDetailsDialog *dialog;
 
@@ -112,7 +118,7 @@ modest_details_dialog_new_with_header (GtkWindow *parent,
                                                        NULL));
 
        MODEST_DETAILS_DIALOG_GET_CLASS (dialog)->create_container_func (dialog);
-       MODEST_DETAILS_DIALOG_GET_CLASS (dialog)->set_header_func (dialog, header);
+       MODEST_DETAILS_DIALOG_GET_CLASS (dialog)->set_header_func (dialog, header, get_size);
 
        /* Add close button */
        gtk_dialog_add_button (GTK_DIALOG (dialog), _("mcen_bd_close"), GTK_RESPONSE_CLOSE);
@@ -150,6 +156,13 @@ modest_details_dialog_add_data (ModestDetailsDialog *self,
        MODEST_DETAILS_DIALOG_GET_CLASS (self)->add_data_func (self, label, value);
 }
 
+void
+modest_details_dialog_set_message_size (ModestDetailsDialog *self,
+                                       guint size)
+{
+       MODEST_DETAILS_DIALOG_GET_CLASS (self)->set_message_size_func (self, size);
+}
+
 static void
 modest_details_dialog_add_data_default (ModestDetailsDialog *self,
                                        const gchar *label,
@@ -204,7 +217,8 @@ replace_recipients (gchar **recipients)
 
 static void
 modest_details_dialog_set_header_default (ModestDetailsDialog *self,
-                                         TnyHeader *header)
+                                         TnyHeader *header,
+                                         gboolean get_size)
 {
        gchar *from = NULL, *subject = NULL, *to = NULL, *cc = NULL, *bcc = NULL;
        time_t received, sent;
@@ -238,7 +252,11 @@ modest_details_dialog_set_header_default (ModestDetailsDialog *self,
        bcc = tny_header_dup_bcc (header);
        received = tny_header_get_date_received (header);
        sent = tny_header_get_date_sent (header);
-       size = tny_header_get_message_size (header);
+       if (get_size) {
+               size = tny_header_get_message_size (header);
+       } else {
+               size = -1;
+       }
 
        replace_recipients (&from);
        replace_recipients (&to);
@@ -299,9 +317,11 @@ modest_details_dialog_set_header_default (ModestDetailsDialog *self,
        }
 
        /* Set size */
-       size_s = modest_text_utils_get_display_size (size);
-       modest_details_dialog_add_data (self, _("mcen_fi_message_properties_size"), size_s);
-       g_free (size_s);
+       if (get_size) {
+               size_s = modest_text_utils_get_display_size (size);
+               modest_details_dialog_add_data (self, _("mcen_fi_message_properties_size"), size_s);
+               g_free (size_s);
+       }
 
        /* Frees */
        g_object_unref (datetime_formatter);
@@ -313,6 +333,16 @@ modest_details_dialog_set_header_default (ModestDetailsDialog *self,
 }
 
 static void
+modest_details_dialog_set_message_size_default (ModestDetailsDialog *self,
+                                               guint size)
+{
+       gchar *size_s;
+       size_s = modest_text_utils_get_display_size (size);
+       modest_details_dialog_add_data (self, _("mcen_fi_message_properties_size"), size_s);
+       g_free (size_s);
+}
+
+static void
 modest_details_dialog_set_folder_default (ModestDetailsDialog *self,
                                          TnyFolder *folder)
 {

diff --git a/src/widgets/modest-details-dialog.h b/src/widgets/modest-details-dialog.h
index 47ab7d4..ae9ba17 100644 (file)
--- a/src/widgets/modest-details-dialog.h
+++ b/src/widgets/modest-details-dialog.h
@@ -70,15 +70,17 @@ typedef struct {
        /* virtual methods */
        void (*create_container_func) (ModestDetailsDialog *self);
        void (*add_data_func) (ModestDetailsDialog *self, const gchar *label, const gchar *value);
-       void (*set_header_func) (ModestDetailsDialog *self, TnyHeader *header);
+       void (*set_header_func) (ModestDetailsDialog *self, TnyHeader *header, gboolean get_size);
        void (*set_folder_func) (ModestDetailsDialog *self, TnyFolder *folder);
+       void (*set_message_size_func) (ModestDetailsDialog *self, guint message_size);
 
 } ModestDetailsDialogClass;
 
 GType modest_details_dialog_get_type (void);
 
 GtkWidget* modest_details_dialog_new_with_header  (GtkWindow *parent, 
-                                                  TnyHeader *header);
+                                                  TnyHeader *header,
+                                                  gboolean get_size);
 
 GtkWidget* modest_details_dialog_new_with_folder  (GtkWindow *parent, 
                                                   TnyFolder *folder);