2007-06-22 Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
        Remove the call to tny_account_set_user() because this actually crashes.
        As mentioned in the last commit, it is known to not work anyway.

pmo-trunk-r2374

diff --git a/ChangeLog2 b/ChangeLog2
index 94ae0c8..ca97d9d 100644 (file)
--- a/ChangeLog2
+++ b/ChangeLog2
@@ -1,6 +1,12 @@
 2007-06-22  Murray Cumming  <murrayc@murrayc.com>
 
        * src/modest-tny-account-store.c: (get_password):
+       Remove the call to tny_account_set_user() because this actually crashes.
+       As mentioned in the last commit, it is known to not work anyway.
+
+2007-06-22  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/modest-tny-account-store.c: (get_password):
        Use tny_account_set_username() to tell tinymail that the username might 
        have changed too. But tinymail ignores this: see projects.maemo.org 
        bug #61463.

diff --git a/src/modest-tny-account-store.c b/src/modest-tny-account-store.c
index dacd687..c98b821 100644 (file)
--- a/src/modest-tny-account-store.c
+++ b/src/modest-tny-account-store.c
@@ -440,7 +440,10 @@ get_password (TnyAccount *account, const gchar * prompt_not_used, gboolean *canc
                if (!*cancel) {
                        /* The password will be returned as the result,
                         * but we need to tell tinymail about the username too: */
-                       tny_account_set_user (account, username);
+                       /* TODO: This causes a crash because it frees memory that 
+                        * tinymail is already using. tinymail needs to detect the change 
+                        * and stop using the old username: 
+                        * tny_account_set_user (account, username); */
                        
                        if (remember) {
                                printf ("%s: Storing username=%s, password=%s\n",