2007-09-11 Murray Cumming <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name): Set the incoming
secure-auth checkbox only when a secure auth method is really specified
in gconf. For some reason, it was set also if a secure connection was
chosen, but that does not make sense to me, and was not commented.
For instance, this stops the user from seeing an error about unsupported
secure authentication when editing a gmail account.

pmo-trunk-r3274

diff --git a/ChangeLog2 b/ChangeLog2
index c8d69a0..3b8a2ee 100644 (file)
--- a/ChangeLog2
+++ b/ChangeLog2
@@ -1,3 +1,13 @@
+2007-09-11  Murray Cumming  <murrayc@murrayc.com>
+
+       * src/maemo/modest-account-settings-dialog.c:
+       (modest_account_settings_dialog_set_account_name): Set the incoming 
+       secure-auth checkbox only when a secure auth method is really specified 
+       in gconf. For some reason, it was set also if a secure connection was 
+       chosen, but that does not make sense to me, and was not commented.
+       For instance, this stops the user from seeing an error about unsupported 
+       secure authentication when editing a gmail account.
+
 2007-09-05  Murray Cumming  <murrayc@murrayc.com>
 
        * src/maemo/modest-maemo-utils.c:

diff --git a/src/maemo/modest-account-settings-dialog.c b/src/maemo/modest-account-settings-dialog.c
index fea16da..922ba55 100644 (file)
--- a/src/maemo/modest-account-settings-dialog.c
+++ b/src/maemo/modest-account-settings-dialog.c
@@ -1316,8 +1316,7 @@ void modest_account_settings_dialog_set_account_name (ModestAccountSettingsDialo
                const ModestAuthProtocol secure_auth = modest_server_account_get_secure_auth(
                        dialog->account_manager, incoming_account->account_name);
                dialog->protocol_authentication_incoming = secure_auth;
-               if (modest_protocol_info_is_secure(security) || 
-                               modest_protocol_info_auth_is_secure(secure_auth))
+               if (modest_protocol_info_auth_is_secure(secure_auth))
                {
                        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON (dialog->checkbox_incoming_auth), 
                                                                                                                                         TRUE);