2007-05-16 Murray Cumming <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account):
        Excplicitly use ANONYMOUS secure authentication, instead of PLAIN for
        SMTP when None was chosen by the user. However, with my SMTP server that
        does not support ANONYMOUS, the emails do not leave the Outbox and I see
        no error dialog.

pmo-trunk-r1893

diff --git a/ChangeLog2 b/ChangeLog2
index 48d6fa3..9672f04 100644 (file)
--- a/ChangeLog2
+++ b/ChangeLog2
@@ -1,5 +1,14 @@
 2007-05-16  Murray Cumming  <murrayc@murrayc.com>
 
+       * src/modest-tny-account.c:
+       (modest_tny_account_new_from_server_account):
+       Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for 
+       SMTP when "None" was chosen by the user. However, with my SMTP server that 
+       does not support ANONYMOUS, the emails do not leave the Outbox and I see 
+       no error dialog.
+
+2007-05-16  Murray Cumming  <murrayc@murrayc.com>
+
        * src/modest-pair.h: Improve the documentation for modest_combo_box_new() 
        to explain the memory management issue with the ID in the ModestPair.
        

diff --git a/src/maemo/modest-main-window.c b/src/maemo/modest-main-window.c
index b5c212f..0d137bd 100644 (file)
--- a/src/maemo/modest-main-window.c
+++ b/src/maemo/modest-main-window.c
@@ -175,6 +175,7 @@ static GtkWindowClass *parent_class = NULL;
 
 
 /* Private actions */
+/* This is the context sensitive menu: */
 static const GtkActionEntry modest_folder_view_action_entries [] = {
 
        /* Folder View CSM actions */

diff --git a/src/modest-tny-account.c b/src/modest-tny-account.c
index d2a9f20..2e8df2f 100644 (file)
--- a/src/modest-tny-account.c
+++ b/src/modest-tny-account.c
@@ -110,10 +110,11 @@ modest_tny_account_get_special_folder (TnyAccount *account,
  * camel_sasl_authtype() seems to list some possible values.
  */
  
- /* Note that evolution does not offer this for IMAP: */
+/* Note that evolution does not offer these for IMAP: */
 #define MODEST_ACCOUNT_AUTH_PLAIN "PLAIN"
+#define MODEST_ACCOUNT_AUTH_ANONYMOUS "ANONYMOUS"
 
-/* IMAP uses NULL instead.
+/* Caeml's IMAP uses NULL instead for "Password".
  * Also, not that Evolution offers "Password" for IMAP, but "Login" for SMTP.*/
 #define MODEST_ACCOUNT_AUTH_PASSWORD "LOGIN" 
 #define MODEST_ACCOUNT_AUTH_CRAMMD5 "CRAM-MD5"
@@ -209,6 +210,8 @@ modest_tny_account_new_from_server_account (ModestAccountMgr *account_mgr,
                         * This setting should never happen anyway. */
                        if (account_data->proto == MODEST_PROTOCOL_STORE_IMAP)
                                auth_mech_name = NULL;
+                       else if (account_data->proto == MODEST_PROTOCOL_TRANSPORT_SMTP)
+                               auth_mech_name = MODEST_ACCOUNT_AUTH_ANONYMOUS;
                        else
                                auth_mech_name = MODEST_ACCOUNT_AUTH_PLAIN;
                        break;