2007-06-14 Armin Burgmeier <armin@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
	* src/maemo/modest-account-settings-dialog.c: Show "invalid email
	address" info in banner instead of node, and select all the text as
	per UI spec. This fixes projects.maemo.org bug NB#60550.

pmo-trunk-r2239

diff --git a/ChangeLog2 b/ChangeLog2
index 503fa59..cb751cd 100644 (file)
--- a/ChangeLog2
+++ b/ChangeLog2
@@ -1,3 +1,10 @@
+2007-06-14  Armin Burgmeier  <armin@openismus.com>
+
+       * src/maemo/easysetup/modest-easysetup-wizard.c:
+       * src/maemo/modest-account-settings-dialog.c: Show "invalid email
+       address" info in banner instead of node, and select all the text as
+       per UI spec. This fixes projects.maemo.org bug NB#60550.
+
 2007-06-14  set REAL_NAME environment variable  <set EMAIL_ADDRESS environment variable>
 
        reviewed by: <delete if not using a buddy>

diff --git a/src/maemo/easysetup/modest-easysetup-wizard.c b/src/maemo/easysetup/modest-easysetup-wizard.c
index f6af87d..eed4517 100644 (file)
--- a/src/maemo/easysetup/modest-easysetup-wizard.c
+++ b/src/maemo/easysetup/modest-easysetup-wizard.c
@@ -1231,11 +1231,12 @@ on_before_next (ModestWizardDialog *dialog, GtkWidget *current_page, GtkWidget *
                        
                if (!modest_text_utils_validate_email_address (email_address)) {
                        /* Warn the user via a dialog: */
-                       show_error (GTK_WINDOW (account_wizard), _("mcen_ib_invalid_email"));
+                       hildon_banner_show_information (NULL, NULL, _("mcen_ib_invalid_email"));
                                              
                        /* Return focus to the email address entry: */
                        gtk_widget_grab_focus (account_wizard->entry_user_email);
-            
+                       gtk_editable_select_region (GTK_EDITABLE (account_wizard->entry_user_email), 0, -1);
+
                        return FALSE;
                }
                

diff --git a/src/maemo/modest-account-settings-dialog.c b/src/maemo/modest-account-settings-dialog.c
index 65c5fae..e3dbef1 100644 (file)
--- a/src/maemo/modest-account-settings-dialog.c
+++ b/src/maemo/modest-account-settings-dialog.c
@@ -837,11 +837,12 @@ check_data (ModestAccountSettingsDialog *self)
                        
        if (!modest_text_utils_validate_email_address (email_address)) {
                /* Warn the user via a dialog: */
-               show_error (GTK_WINDOW (self), _("mcen_ib_invalid_email"));
+               /*show_error (GTK_WINDOW (self), _("mcen_ib_invalid_email"));*/
+               hildon_banner_show_information (NULL, NULL, _("mcen_ib_invalid_email"));
                                          
-        /* Return focus to the email address entry: */
-        gtk_widget_grab_focus (self->entry_user_email);
-        
+               /* Return focus to the email address entry: */
+               gtk_widget_grab_focus (self->entry_user_email);
+               gtk_editable_select_region (GTK_EDITABLE (self->entry_user_email), 0, -1);
                return FALSE;
        }
        
@@ -883,7 +884,7 @@ on_response (GtkDialog *wizard_dialog,
        if (prevent_response) {
                /* This is a nasty hack. murrayc. */
                /* Don't let the dialog close */
-       g_signal_stop_emission_by_name (wizard_dialog, "response");
+               g_signal_stop_emission_by_name (wizard_dialog, "response");
                return; 
        }