+2007-08-16 Armin Burgmeier <armin@openismus.com>
+
+ * src/modest-ui-actions.c: Show a banner instead of a dialog when
+ renaming a folder fails, to stay consistent with what happens when
+ creating a folder fails.
+
+ * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
+ slightly country loading from the mmc_mappings file, fixed a memory
+ leak.
+
2007-08-16 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (volume_path_is_mounted):
2007-07-16 Armin Burgmeier <armin@openismus.com>
* src/modest-ui-actions.c: Added a button to create a folder to the
- move-to dialog. This fixes projects.maemo.org bug NB#.
+ move-to dialog. This fixes projects.maemo.org bug NB#59863.
2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
}
GtkListStore *liststore = GTK_LIST_STORE (priv->model);
-
+
/* We use the getline() GNU extension,
* because it reads per line, which simplifies our code,
* and it doesn't require us to hard-code a buffer length.
if (previous_country) {
/* printf (" debug: storing id=%d for country=%s\n", previous_id, previous_country); */
- list = g_slist_append (list, GUINT_TO_POINTER (previous_id));
+ list = g_slist_prepend (list, GUINT_TO_POINTER (previous_id));
}
/* Group multiple MMC IDs for the same country together:
}
g_free (previous_country);
- previous_country = g_strdup (country);
+ previous_country = country;
const guint id = (guint)g_ascii_strtod(id_str, NULL); /* Note that this parses locale-independent text. */
previous_id = id;
}
+ else if (country) {
+ g_free (country);
+ }
g_free (id_str);
- g_free (country);
}
/* Deal with the last country: */
GtkTreeIter iter;
gtk_list_store_append (liststore, &iter);
gtk_list_store_set(liststore, &iter, MODEL_COL_IDS, list, MODEL_COL_NAME, name_translated, -1);
-
+
+ g_free(previous_country);
+
if (list) {
g_slist_free (list);
list = NULL;
modest_ui_actions_rename_folder_error_handler (ModestMailOperation *mail_op,
gpointer user_data)
{
- GObject *win = modest_mail_operation_get_source (mail_op);
+ ModestMainWindow *window = MODEST_MAIN_WINDOW (user_data);
const GError *error = NULL;
const gchar *message = NULL;
message = _("!!! FIXME: Unable to rename");
}
- /* Show notification dialog */
- modest_platform_run_information_dialog ((win) ? GTK_WINDOW (win) : NULL, message);
- g_object_unref (win);
+ modest_platform_information_banner (GTK_WIDGET (window), NULL,
+ message);
}
void
ModestMailOperation *mail_op;
mail_op =
- modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_INFO,
+ modest_mail_operation_new_with_error_handling (MODEST_MAIL_OPERATION_TYPE_INFO,
G_OBJECT(main_window),
modest_ui_actions_rename_folder_error_handler,
- NULL);
-
+ main_window);
modest_mail_operation_queue_add (modest_runtime_get_mail_operation_queue (),
mail_op);
modest_folder_view_select_folder (MODEST_FOLDER_VIEW(folder_view),
TNY_FOLDER(folder), TRUE);
-
modest_header_view_clear ((ModestHeaderView *) header_view);
modest_mail_operation_rename_folder (mail_op,