From: Alberto Garcia <agarcia@igalia.com>
Date: Tue, 29 Jan 2008 17:31:55 +0000 (+0000)
Subject: Fixed a leak in modest_mail_operation_get_msgs_full()
X-Git-Tag: git_migration_finished~1747
X-Git-Url: http://git.maemo.org/git/?p=modest;a=commitdiff_plain;h=453f87bea325c0bf319bec40335c4faa24a5ae14

Fixed a leak in modest_mail_operation_get_msgs_full()

pmo-trunk-r4104
---

diff --git a/src/modest-mail-operation.c b/src/modest-mail-operation.c
index a15ea5d..151f2d8 100644
--- a/src/modest-mail-operation.c
+++ b/src/modest-mail-operation.c
@@ -2240,8 +2240,8 @@ modest_mail_operation_get_msgs_full (ModestMailOperation *self,
 
 	/* Get account and set it into mail_operation */
 	if (tny_list_get_length (header_list) >= 1) {
-		iter = tny_list_create_iterator (header_list);
-		TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iter));
+		TnyIterator *iterator = tny_list_create_iterator (header_list);
+		TnyHeader *header = TNY_HEADER (tny_iterator_get_current (iterator));
 		if (header) {
 			TnyFolder *folder = tny_header_get_folder (header);
 			if (folder) {		
@@ -2250,11 +2250,7 @@ modest_mail_operation_get_msgs_full (ModestMailOperation *self,
 			}
 			g_object_unref (header);
 		}
-
-		if (tny_list_get_length (header_list) == 1) {
-			g_object_unref (iter);
-			iter = NULL;
-		}
+		g_object_unref (iterator);
 	}
 
 	msg_list_size = compute_message_list_size (header_list);