modest
16 years ago* this is dirk's version of sergio's patch to only create
Dirk-Jan C. Binnema [Wed, 31 Oct 2007 10:50:09 +0000 (10:50 +0000)]
* this is dirk's version of sergio's patch to only create
  main-windows when we really need to.

it adds a boolean 'create' parameter to modest_window_mgr_get_main_window,
  and only if this parameter is TRUE will this function create a main_window
  if it was not yet existing.

  also, patch makes warning dialogs not show up if there is no main window,
  including password, cert verification dialogs. thus, the user will not be
  annoyed unexpectedly anymore.

pmo-trunk-r3606

16 years ago* don't accept certificate when user clicked cancel
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 13:30:05 +0000 (13:30 +0000)]
* don't accept certificate when user clicked cancel

pmo-trunk-r3604

16 years agospelling: s/conformation/confirmation
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 12:13:51 +0000 (12:13 +0000)]
spelling: s/conformation/confirmation

pmo-trunk-r3602

16 years ago* fix for the crash in NB#74605
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 11:49:38 +0000 (11:49 +0000)]
* fix for the crash in NB#74605
* code cleanup

pmo-trunk-r3601

16 years ago* src/modest-account-mgr-helpers.c:
Jose Dapena Paz [Tue, 30 Oct 2007 11:10:49 +0000 (11:10 +0000)]
* src/modest-account-mgr-helpers.c:
        * On removing a smtp connection account, we shouldn't spoil
          the list of accounts.
* src/maemo/modest-connection-specific-smtp-window.c:
        * Now we can remove accounts simply removing the hostname of the
          server (fixes NB#65559).
* src/maemo/modest-connection-specific-smtp-edit-window.c:
        * Now we accept empty hostnames as valid, so that we can remove
          accounts.

pmo-trunk-r3600

16 years ago* do some parameter checks for is_busy / set_busy,
Dirk-Jan C. Binnema [Tue, 30 Oct 2007 10:56:04 +0000 (10:56 +0000)]
* do some parameter checks for is_busy / set_busy,
  and code style cleanup

pmo-trunk-r3599

16 years ago* check for invalid folders in many places
Dirk-Jan C. Binnema [Mon, 29 Oct 2007 14:06:11 +0000 (14:06 +0000)]
* check for invalid folders in many places
* add TNY_FOLDER_TYPE_INVALID (todo: move this to tinymail)
* add the check when moving messages to folders (this fixes
  a crasher)

Fixes: NB#74469

pmo-trunk-r3597

16 years agofixes NB#66958
Felipe Erias Morandeira [Mon, 29 Oct 2007 12:04:28 +0000 (12:04 +0000)]
fixes NB#66958

pmo-trunk-r3596

16 years agoPriority flags changes.
Jose Dapena Paz [Mon, 29 Oct 2007 10:27:50 +0000 (10:27 +0000)]
Priority flags changes.
* src/widgets/modest-gtkhtml-msg-view.c:
        * Remove all internal priority mask to delefate on headers view.
* src/widgets/modest-header-view.c:
        * Replace old priority comparison code to be proper for the
          priority flags after last changes in tinymail.
* src/widgets/modest-header-view-render.c:
        * If we try to get the pixbuf for 0, we get NULL pixbuf.
        * Update the priority flags management showing priority pixbufs.
* src/widgets/modest-mail-header-view.c:
        * Use new priority flags in tinymail.
* src/widgets/modest-mozembed-msg-view.c:
        * Use mail header view priorities instead of storing a local
          copy of priorities.
* src/maemo/modest-msg-edit-window.c:
        * Use new priority flags api from tinymail.
* src/maemo/modest-platform.c:
        * Use new priority flags api from tinymail.
* src/modest-tny-send-queue.c:
        * Use the new priority/suspended flags api. Now we don't unset
          the flags if message send failed.

Mozembed changes:
* src/widgets/modest-mozembed-msg-view.c:
        * Use scroll area (pending on changes in gtkmozembed to be
          scrollable).
* src/widgets/modest-mozembed-mime-part-view.c:
        * Implementation of ModestISearchView interface for incremental
          search.
* src/maemo/modest-msg-view-window.c:
        * More integration with mozembed (adaptation for future
          scrollable gtkmozembed widget).

pmo-trunk-r3595

16 years agoremove garbage in function comment
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 15:19:22 +0000 (15:19 +0000)]
remove garbage in function comment

pmo-trunk-r3594

16 years ago* add support for special port numbers; this fixes the
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 15:12:09 +0000 (15:12 +0000)]
* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts* add support for special port numbers; this fixes the
  easysetup for ".mac"-accounts

pmo-trunk-r3593

16 years ago* forgot these (see r3591)
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 14:11:25 +0000 (14:11 +0000)]
* forgot these (see r3591)

pmo-trunk-r3592

16 years ago* make osso-addressbook (libosso-abook-dev) optional; if it's
Dirk-Jan C. Binnema [Fri, 26 Oct 2007 14:06:34 +0000 (14:06 +0000)]
* make osso-addressbook (libosso-abook-dev) optional; if it's
  not there, we'll use modest-address-book-dummy.c

pmo-trunk-r3591

16 years agoweek 44 bugs added.
Vivek Sekar [Fri, 26 Oct 2007 12:42:35 +0000 (12:42 +0000)]
week 44 bugs added.

pmo-trunk-r3587

16 years ago * Some improvements for the connect_and_wait, there is no need to disconnect the...
Sergio Villar Senin [Fri, 26 Oct 2007 08:41:13 +0000 (08:41 +0000)]
* Some improvements for the connect_and_wait, there is no need to disconnect the signal when we've called tny_camel_account_set_online

pmo-trunk-r3582

16 years ago * Fixed a very stupid mistake by myself in the connect_and_wait function. It could...
Sergio Villar Senin [Thu, 25 Oct 2007 17:50:27 +0000 (17:50 +0000)]
* Fixed a very stupid mistake by myself in the connect_and_wait function. It could cause a SIGSEV and was not taking into account the case where the device was online and the account was not and was not reconnecting as well.

pmo-trunk-r3581

16 years agoFixed typo
Alberto Garcia [Thu, 25 Oct 2007 17:49:12 +0000 (17:49 +0000)]
Fixed typo

pmo-trunk-r3580

16 years ago* modest-tny-account-store:
Alberto Garcia [Thu, 25 Oct 2007 17:22:47 +0000 (17:22 +0000)]
* modest-tny-account-store:
  (modest_tny_account_store_get_transport_account_from_outbox_header)
  New function to obtain the transport account from a message in the
  outbox

* modest-ui-actions:
  (open_msg_cb)
  Open Failed messages in the outbox with the editor and not with the
  viewer.

Fixes NB#74147

pmo-trunk-r3579

16 years ago* only set auto-update alarms when there are accounts;
Dirk-Jan C. Binnema [Thu, 25 Oct 2007 15:42:12 +0000 (15:42 +0000)]
* only set auto-update alarms when there are accounts;
  also check with account addition/deletion.

Fixes: NB#64945

pmo-trunk-r3578

16 years ago * Removed a public method
Sergio Villar Senin [Thu, 25 Oct 2007 11:42:51 +0000 (11:42 +0000)]
* Removed a public method

pmo-trunk-r3577

16 years ago * Reimplementation of the connect_and_wait function
Sergio Villar Senin [Thu, 25 Oct 2007 10:22:14 +0000 (10:22 +0000)]
* Reimplementation of the connect_and_wait function
* Fixes NB#66769

pmo-trunk-r3576

16 years ago * Fixes NB#74180, the New folder, Rename and Delete options of the folder CSM are...
Sergio Villar Senin [Wed, 24 Oct 2007 17:03:06 +0000 (17:03 +0000)]
* Fixes NB#74180, the New folder, Rename and Delete options of the folder CSM are dimmed when in transfer mode

pmo-trunk-r3574

16 years agoUse the constant name (TNY_HEADER_FLAG_NORMAL_PRIORITY) and
Alberto Garcia [Wed, 24 Oct 2007 15:21:27 +0000 (15:21 +0000)]
Use the constant name (TNY_HEADER_FLAG_NORMAL_PRIORITY) and
not its value (0) to check the priority of a message.

pmo-trunk-r3573

16 years ago * Fixes NB#74182, the paste option is removed from the csm
Sergio Villar Senin [Wed, 24 Oct 2007 15:03:52 +0000 (15:03 +0000)]
* Fixes NB#74182, the paste option is removed from the csm

pmo-trunk-r3572

16 years ago* fix for NB#74144 (modest thinks foo/drafts is Drafts)
Dirk-Jan C. Binnema [Wed, 24 Oct 2007 12:01:50 +0000 (12:01 +0000)]
* fix for NB#74144 (modest thinks foo/drafts is Drafts)
  - made the check more precise, ie. compare the full path, not just the name
  - cleaned up the code and its callers

pmo-trunk-r3569

16 years agofixes NB#74061
Felipe Erias Morandeira [Wed, 24 Oct 2007 09:06:25 +0000 (09:06 +0000)]
fixes NB#74061

pmo-trunk-r3567

16 years ago * Fixed a typo
Sergio Villar Senin [Wed, 24 Oct 2007 08:03:02 +0000 (08:03 +0000)]
* Fixed a typo

pmo-trunk-r3566

16 years ago * Restored some code deleted by error
Sergio Villar Senin [Wed, 24 Oct 2007 07:58:36 +0000 (07:58 +0000)]
* Restored some code deleted by error

pmo-trunk-r3565

16 years ago* remove package dependency of libmodest-dbus-client on modest
Dirk-Jan C. Binnema [Wed, 24 Oct 2007 07:50:20 +0000 (07:50 +0000)]
* remove package dependency of libmodest-dbus-client on modest

pmo-trunk-r3564

16 years agopatch for NB#73896
Felipe Erias Morandeira [Tue, 23 Oct 2007 16:37:58 +0000 (16:37 +0000)]
patch for NB#73896

pmo-trunk-r3563

16 years agoShow all accounts in the "Move To" dialog, not just the active one
Alberto Garcia [Tue, 23 Oct 2007 15:51:59 +0000 (15:51 +0000)]
Show all accounts in the "Move To" dialog, not just the active one

pmo-trunk-r3562

16 years ago * Removed an invalid indirection of a function call as Philip correctly suggested
Sergio Villar Senin [Tue, 23 Oct 2007 11:59:54 +0000 (11:59 +0000)]
* Removed an invalid indirection of a function call as Philip correctly suggested

pmo-trunk-r3561

16 years ago * The viewer handler could not exist if the viewer window was created without a...
Sergio Villar Senin [Tue, 23 Oct 2007 11:06:16 +0000 (11:06 +0000)]
* The viewer handler could not exist if the viewer window was created without a main window present (for example when opening a message through D-Bus)

pmo-trunk-r3560

16 years ago* use _CS to get translation from right domain, fixes #NB74006
Dirk-Jan C. Binnema [Tue, 23 Oct 2007 10:02:10 +0000 (10:02 +0000)]
* use _CS to get translation from right domain, fixes #NB74006

pmo-trunk-r3559

16 years agoFix DBUS mailto: test
Alberto Garcia [Tue, 23 Oct 2007 09:19:56 +0000 (09:19 +0000)]
Fix DBUS mailto: test

pmo-trunk-r3558

16 years ago * Fixed an invalid g_object_ref/unref
Sergio Villar Senin [Tue, 23 Oct 2007 06:35:59 +0000 (06:35 +0000)]
* Fixed an invalid g_object_ref/unref
* Added a refilter whenever an account is added/removed/modified in the folder view widget (following a Philip's comment)

pmo-trunk-r3557

16 years ago* Offer the account creation in the MailTo DBUS handler
Alberto Garcia [Mon, 22 Oct 2007 15:33:51 +0000 (15:33 +0000)]
* Offer the account creation in the MailTo DBUS handler
* Fixed memory leaks

pmo-trunk-r3556

16 years agoSimplified the MailTo DBUS handler
Alberto Garcia [Mon, 22 Oct 2007 15:02:50 +0000 (15:02 +0000)]
Simplified the MailTo DBUS handler

pmo-trunk-r3555

16 years agoMore refactoring of the ComposeMail DBUS handler, now everything
Alberto Garcia [Mon, 22 Oct 2007 14:56:42 +0000 (14:56 +0000)]
More refactoring of the ComposeMail DBUS handler, now everything
is done in modest-ui-actions

pmo-trunk-r3554

16 years agoRefactored the code of modest_ui_actions_on_new_msg() and
Alberto Garcia [Mon, 22 Oct 2007 14:22:21 +0000 (14:22 +0000)]
Refactored the code of modest_ui_actions_on_new_msg() and
the ComposeMessage DBUS handler

pmo-trunk-r3553

16 years ago * Fixes NB#65926, do not show Junk numbers (actually bytes transferred) when moving...
Sergio Villar Senin [Mon, 22 Oct 2007 07:42:27 +0000 (07:42 +0000)]
* Fixes NB#65926, do not show Junk numbers (actually bytes transferred) when moving messages. Now we show "Receiving x of y and the progress bar shows the amount of bytes transferred
* Removed some commented code

pmo-trunk-r3544

16 years ago * Do not modify the header view contents style when new messages are received
Sergio Villar Senin [Fri, 19 Oct 2007 17:06:33 +0000 (17:06 +0000)]
* Do not modify the header view contents style when new messages are received

pmo-trunk-r3543

16 years ago * Remove some invalid code from the D-Bus callback, the refresh of the curren...
Sergio Villar Senin [Fri, 19 Oct 2007 16:51:22 +0000 (16:51 +0000)]
    * Remove some invalid code from the D-Bus callback, the refresh of the current folder was automatically done by the ui acti
on
        * Do not refresh the current folder when send&receive unless we're viewing any window
        * Reverted a method to static

pmo-trunk-r3542

16 years ago * Added a dbus test that updates (Send&Receive) the default account
Sergio Villar Senin [Fri, 19 Oct 2007 16:37:27 +0000 (16:37 +0000)]
* Added a dbus test that updates (Send&Receive) the default account

pmo-trunk-r3541

16 years agoSimplified the mailto uri parser
Alberto Garcia [Fri, 19 Oct 2007 16:04:54 +0000 (16:04 +0000)]
Simplified the mailto uri parser

pmo-trunk-r3540

16 years ago* Removed unused struct SendMailIdleData
Alberto Garcia [Fri, 19 Oct 2007 14:58:43 +0000 (14:58 +0000)]
* Removed unused struct SendMailIdleData
* Reworked a bit the code of uri_parse_mailto()

pmo-trunk-r3539

16 years agoIn mailto: urls parameters after the first one are separated by '&',
Alberto Garcia [Fri, 19 Oct 2007 14:06:14 +0000 (14:06 +0000)]
In mailto: urls parameters after the first one are separated by '&',
not by '?'

pmo-trunk-r3538

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 19 Oct 2007 12:49:42 +0000 (12:49 +0000)]
* src/modest-ui-actions.c:
        * Now, for saving or sending messages, we use the from part of
          the message information in editor (fixes NB#65189).
        * We also don't ignore the from in the message in drafts folder
          when opening an editor from it.

pmo-trunk-r3537

16 years agoSimplified the code of the dbus 'mailto:' handler, to remove redundant
Alberto Garcia [Fri, 19 Oct 2007 12:42:25 +0000 (12:42 +0000)]
Simplified the code of the dbus 'mailto:' handler, to remove redundant
code and reuse the handler written for the "Compose" action.

Fixed usage of 'mailto:' parameters (they were not being actually
used).

pmo-trunk-r3536

16 years agoadded bugs fixed for week 43.
Vivek Sekar [Fri, 19 Oct 2007 12:19:09 +0000 (12:19 +0000)]
added bugs fixed for week 43.

pmo-trunk-r3534

16 years agoWork to make attachments be opened in a single instance (raise window
Jose Dapena Paz [Fri, 19 Oct 2007 09:10:40 +0000 (09:10 +0000)]
Work to make attachments be opened in a single instance (raise window
if they're already openened) (fixes NB#65279).
* src/widgets/modest-window-mgr.[ch]:
        * Now modest_window_mgr_register_header accepts an alt_uid
          parameter in case the header does not provide an uid.
* src/maemo/modest-msg-view-window.c:
        * Now we pass a hash base to the create_temp_stream method used
          to create a temporary file to view an attachment. This hash
          is used to open always the file in the same directory.
        * Now the attachment messages are opened passing a "attachment
          id" that works similar to a message id. This identifies the
          message in the window manager properly.
* src/modest-ui-actions.c, src/dbus_api/modest-dbus-callbacs.c:
        * Use new modest_window_mgr_register_header call.
* src/maemo/modest-maemo-utils.[ch]:
        * Now ..._create_temp_stream accepts an additional parameter
          hash_base. This hash_base is used to generate the "random"
          directory the temporary file is created. This is used to
          force files created from attachments get the same path.

pmo-trunk-r3529

16 years agoRemoved unused variable
Alberto Garcia [Thu, 18 Oct 2007 12:42:59 +0000 (12:42 +0000)]
Removed unused variable

pmo-trunk-r3528

16 years ago* src/dbus_api/modest-dbus-callbacks.c:
Jose Dapena Paz [Thu, 18 Oct 2007 10:20:25 +0000 (10:20 +0000)]
* src/dbus_api/modest-dbus-callbacks.c:
* Now get_folders method also obtains folders from mmc
  (fixes NB#65058).
* src/modest-tny-account-store.[ch]:
* Added new method to obtain the mmc account.

pmo-trunk-r3527

16 years agoAdded fixed bugs for week 42 release.
Vivek Sekar [Wed, 17 Oct 2007 11:54:27 +0000 (11:54 +0000)]
Added fixed bugs for week 42 release.

pmo-trunk-r3524

16 years agoCheck properly the contents of the clipboard before
Alberto Garcia [Wed, 17 Oct 2007 11:38:46 +0000 (11:38 +0000)]
Check properly the contents of the clipboard before
deciding whether to dim the "Paste" menu option
Fixes NB#73404

pmo-trunk-r3523

16 years agoThis commit includes a complete refactor of ModestMsgView. Now
Jose Dapena Paz [Wed, 17 Oct 2007 11:19:37 +0000 (11:19 +0000)]
This commit includes a complete refactor of ModestMsgView. Now
ModestMsgView is an interface, and we have ModestGtkhtmlMsgView and
ModestMozembedMsgView.
* src/modest-tny-platform-factory.c:
        * Get ModestMozembedMsgView from factory, if enabled.
* src/modest-msg-view.[ch]:
        * Now this is an interface. ModestGtkhtmlMsgView and
          ModestMozembedMsgView implement this interface. This
          way we make easier to use one or another implementation.
* Added src/widgets/modest-gtkhtml-msg-view.[ch]:
        * ModestGtkhtmlMsgView contains the old ModestMsgView widget
          (with all the gtkhtml related things). It implements the
          new ModestMsgView interface, and uses all available
          interfaces (zoomable, isearch view, etc).
        * Reorganized the code, to separate the internal code from
          interfaces implementation.
* Added src/widgets/modest-mozembed-mime-part-view.[ch]:
        * Inherits from TnyMozembedMimePartView, adding implementation
          for ModestZoomable, ModestMimePartView, and stub
          implementation of  ModestISearchView.
* Added src/widgets/modest-mozembed-msg-view.[ch]:
        * Implementation of ModestMsgView interface using mozembed
          backend. It's not finished nor really working, but it's
          a technology preview.
* src/widgets/Makefile.am, src/Makefile.am:
        * Added new widgets.
* src/maemo/modest-msg-view-window.c:
        * Removed dependency on gtkhtml code. Update access to
          ModestMsgView to use the proper interfaces.
        * Now construct does not use a msg parameter. Message is set
          after construction.
        * Update event names of ModestMsgView.
* configure.ac:
        * Add mozembed parameter, to be able to activate mozembed
          support.

pmo-trunk-r3521

16 years ago * Fixed a critical when drag&drop, we're not considering that we can hover an account
Sergio Villar Senin [Wed, 17 Oct 2007 10:47:15 +0000 (10:47 +0000)]
* Fixed a critical when drag&drop, we're not considering that we can hover an account

pmo-trunk-r3520

16 years agoMessages in the Outbox are opened with the viewer, not
Alberto Garcia [Wed, 17 Oct 2007 10:46:05 +0000 (10:46 +0000)]
Messages in the Outbox are opened with the viewer, not
with the editor
Fixes NB#65333

pmo-trunk-r3519

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 17 Oct 2007 09:44:50 +0000 (09:44 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now, on saving to drafts, we unregister the window (with the
  old header) and register it again (with the new header). If
  the window has been destroyed previously, we don't register
  (fixes NB#66687).

pmo-trunk-r3518

16 years agoHighlight the first message when selecting a new folder, but don't let
Alberto Garcia [Wed, 17 Oct 2007 08:25:33 +0000 (08:25 +0000)]
Highlight the first message when selecting a new folder, but don't let
it get the active focus.
Fixes NB#58917

pmo-trunk-r3517

16 years ago * Fixed a bug in the easysetup, the connection specific SMTP servers dialog was...
Sergio Villar Senin [Tue, 16 Oct 2007 17:27:24 +0000 (17:27 +0000)]
* Fixed a bug in the easysetup, the connection specific SMTP servers dialog was not modal

pmo-trunk-r3516

16 years ago* src/maemo/easysetup/modest-easysetup-wizard.c:
Jose Dapena Paz [Tue, 16 Oct 2007 16:58:42 +0000 (16:58 +0000)]
* src/maemo/easysetup/modest-easysetup-wizard.c:
        * Check if we've got presets to prevent a crash if not.
        * Set a size request of service provider combo on startup, as
          this will be loaded later.
        * Now we load the service providers from presets in an idle.
          This way, we show the wizard immediately, instead of showing
          it with the described delay (fixes NB#64324).
        * We catch delete event, to prevent strange behavior when the
          user closes the window with escape key.

pmo-trunk-r3515

16 years ago * The account dialog is now modal (registered as modal in the window manager) this...
Sergio Villar Senin [Tue, 16 Oct 2007 15:50:24 +0000 (15:50 +0000)]
* The account dialog is now modal (registered as modal in the window manager) this prevents the application "hang" when the dialog is shown bellow any other
* The accounts are now really disconnected when edited and reconnected before finishing the edition

pmo-trunk-r3514

16 years agoDim the "Insert Image" menu option when composing a message in plain
Alberto Garcia [Tue, 16 Oct 2007 14:00:15 +0000 (14:00 +0000)]
Dim the "Insert Image" menu option when composing a message in plain
text mode
Fixes NB#73392

pmo-trunk-r3513

16 years ago* fix warning
Dirk-Jan C. Binnema [Tue, 16 Oct 2007 09:40:34 +0000 (09:40 +0000)]
* fix warning

pmo-trunk-r3509

16 years agoAllow drag and drop only if the user begins tapping on a message that
Alberto Garcia [Tue, 16 Oct 2007 09:21:59 +0000 (09:21 +0000)]
Allow drag and drop only if the user begins tapping on a message that
is already selected. If not, just let him select items by dragging the
stylus.
Fixes NB#65145

pmo-trunk-r3508

16 years ago* revert to the in-place 'modest_text_utils_get_display_address',
Dirk-Jan C. Binnema [Tue, 16 Oct 2007 08:50:40 +0000 (08:50 +0000)]
* revert to the in-place 'modest_text_utils_get_display_address',
  and make it a bit faster.

pmo-trunk-r3507

16 years ago * Fixed modest_text_utils_get_display_address, now the original string is not modifi...
Sergio Villar Senin [Mon, 15 Oct 2007 11:48:03 +0000 (11:48 +0000)]
* Fixed modest_text_utils_get_display_address, now the original string is not modified and the function returns new memory
* Added notification removal support
* Added notification grouping support
* Replaced the old modest_platform_on_new_header_received by modest_platform_on_new_headers_received
* Fixed ModestConf's set_list method

pmo-trunk-r3505

16 years agoFix to pass lintian checks.
Vivek Sekar [Mon, 15 Oct 2007 10:50:47 +0000 (10:50 +0000)]
Fix to pass lintian checks.

pmo-trunk-r3502

16 years agoadded bug fixes
Vivek Sekar [Fri, 12 Oct 2007 09:06:18 +0000 (09:06 +0000)]
added bug fixes

pmo-trunk-r3499

16 years ago* add some notes on how to move from osso-email-interface to
Dirk-Jan C. Binnema [Thu, 11 Oct 2007 15:17:03 +0000 (15:17 +0000)]
* add some notes on how to move from osso-email-interface to
  libmodest-dbus-client

pmo-trunk-r3495

16 years ago* added documentation
Dirk-Jan C. Binnema [Thu, 11 Oct 2007 13:38:44 +0000 (13:38 +0000)]
* added documentation

pmo-trunk-r3494

16 years ago* don't implicitly depend on ossohelp (OSSO_HELP_SHOW_DIALOG)
Dirk-Jan C. Binnema [Thu, 11 Oct 2007 12:08:08 +0000 (12:08 +0000)]
* don't implicitly depend on ossohelp (OSSO_HELP_SHOW_DIALOG)
* clean up helplib usage in modest-platform

pmo-trunk-r3492

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Thu, 11 Oct 2007 09:40:54 +0000 (09:40 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Fix an usage of a local pointer outside its scope. Should
  prevent crashes in some cases (thanks Dirk!)

pmo-trunk-r3491

16 years ago* src/modest-main-window.c:
Jose Dapena Paz [Thu, 11 Oct 2007 06:01:58 +0000 (06:01 +0000)]
* src/modest-main-window.c:
* New fix to paned position. Now we set the paned position in a
  timeout handler, to try to set it properly when the window
  gets its original position.

pmo-trunk-r3488

16 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Thu, 11 Oct 2007 05:33:54 +0000 (05:33 +0000)]
* src/maemo/modest-main-window.c:
* Urg, fixed a nasty and stupid bug, that prevented enter
  keypress from opening a header in main window header view.

pmo-trunk-r3487

16 years ago* dbus_api/modest-dbus-callbacks.c:
Jose Dapena Paz [Wed, 10 Oct 2007 16:56:41 +0000 (16:56 +0000)]
* dbus_api/modest-dbus-callbacks.c:
* Now the prefix of inbox is MY: instead of MAND: to make it
  appear before drafts, sent and outbox folders (fixes
  NB#61810).

pmo-trunk-r3486

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 10 Oct 2007 16:32:33 +0000 (16:32 +0000)]
* src/modest-ui-actions.c:
        * Now we don't crash if we open a message from drafts without an
          account to edit (fixes NB#65064).

pmo-trunk-r3485

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 10 Oct 2007 15:39:32 +0000 (15:39 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * If we try to remove an attached message in editor, we
          show the subject in the remove confirmation dialog
          (fixes NB#66044).

pmo-trunk-r3484

16 years agoAdded new bug fixes and bumped version for diablo.
Vivek Sekar [Wed, 10 Oct 2007 12:51:16 +0000 (12:51 +0000)]
Added new bug fixes and bumped version for diablo.

pmo-trunk-r3482

16 years ago* src/modest-marshal.list:
Jose Dapena Paz [Wed, 10 Oct 2007 12:44:19 +0000 (12:44 +0000)]
* src/modest-marshal.list:
        * Added two marshallers.
* src/modest-tny-platform-factory.c:
        * Added a proper implementation of get_msg_view.
* src/modest-msg-view.[ch]:
        * Removed all references to gtkhtml library, as now we
          use the new ModestGtkhtmlMimePartView. This hides all
          gtkhtml inners in modest/tny api.
        * Implemented ModestZoomable interface, and removed old api so
          now you have to use ModestZoomable api always.
        * Adapted the signal handlers to use the ModestMimePartView
          signals instead of gtkhtml signals.
        * Now ModestMsgView implement TnyMsg and TnyMimePart interfaces.
          Removed old methods to get/set messages, as now we use
          Tny api.
        * Reestructured a bit the code, to separate the interfaces
          implementations from the implementation itself.
        * Now we properly find the embedded attachments, if they're
          stored in a multipart/related.
* Added src/modest-isearch-view.[ch]:
        * Incremental search view interface. This new interface exposes
          a view where incremental search is available (writing a string
          and beginning to search this string the times required to find
          it).
* Added src/modest-mime-part-view.[ch]:
        * New interface, child of TnyMimePartView. This interface adds
          method is_empty and signals "activate_uri", "link_hover" and
          "fetch_url" to TnyMimePartView. This is for implementing the
          specific backend for gtkhtml (included in this commit) and a
          future one using GtkMozembed.
* Added src/modest-zoomable.[ch]:
        * This new interface should be implemented by all widgets
          supporting any kind of zoom. In particular, this is
          implemented in the new ModestGtkhtmlMimePartView and in
          ModestMsgView. In the future ModestWindow children should
          implement this.
* Added src/modest-gtkhtml-mime-part-view.[ch]:
        * This is an implementation of ModestMimePartView interface,
          ModestISearchView interface, and ModestZoomable interface. It
          uses gtkhtml as backend, and is, in fact, the place where all
          the gtkhtml code that was present in ModestMsgView has gone.
* src/maemo/modest-msg-view-window.c:
        * Use TnyMsg and ModestZoomable api to access ModestMsgView.

pmo-trunk-r3481

16 years ago * Added a destroyer to the error handler of the mail operation for the user data
Sergio Villar Senin [Tue, 9 Oct 2007 15:59:46 +0000 (15:59 +0000)]
* Added a destroyer to the error handler of the mail operation for the user data
* Fixes NB#63115, show the proper message when opening a mail fails

pmo-trunk-r3479

16 years ago * Replaced GtkWindow by ModestWindow in some places
Sergio Villar Senin [Tue, 9 Oct 2007 09:41:01 +0000 (09:41 +0000)]
* Replaced GtkWindow by ModestWindow in some places
* the refresh operation now calls the user callback even if it fails
* fixed some errors in the open_msg action in the UI actions, it was not opening the cached messages when the account was offline
* Added the TnyAccount parametter to the connect_to_get_msg private func
* Removed some warnings in the code
* Fixed an unref
* Fixes NB#66769, now we wait for the account to be connected before trying to open a message. In order to do this I had to rewrite the modest_platform_connect_and_wait

pmo-trunk-r3477

16 years ago * Fixes NB#62423, the first INBOX folder is not selected when the MMC is removed...
Sergio Villar Senin [Thu, 4 Oct 2007 16:49:20 +0000 (16:49 +0000)]
* Fixes NB#62423, the first INBOX folder is not selected when the MMC is removed, so the header view no longer gets empty
* Partially fixes NB#63761, Modest does not try to connect to send a new message, we still need that tinymail does not try to send if the device is offline in order to avoid an error message
* Added some missing account registrations in the mail operations

pmo-trunk-r3472

16 years ago * Added a callback for the save_to_drafts operation
Sergio Villar Senin [Thu, 4 Oct 2007 13:39:59 +0000 (13:39 +0000)]
* Added a callback for the save_to_drafts operation
* Removed a call to edit window directly from mail operations
* Fixed a bug caused by the old implementation, now if the message was saved when the editor was closed it unregisters the header in the window mgr, so we are able to open it again

pmo-trunk-r3470

16 years ago * Added a missing g_object_unref that was causing leaks
Sergio Villar Senin [Thu, 4 Oct 2007 13:32:02 +0000 (13:32 +0000)]
* Added a missing g_object_unref that was causing leaks

pmo-trunk-r3469

16 years ago * Added a new signal "updating-msg-list" to the header view
Sergio Villar Senin [Thu, 4 Oct 2007 08:12:40 +0000 (08:12 +0000)]
* Added a new signal "updating-msg-list" to the header view
* Now the Main window shows an "updating banner" whenever the refresh of a folder takes more than 2 seconds

pmo-trunk-r3465

16 years ago* src/modest-platform.h, src/maemo/modest-platform.c:
Jose Dapena Paz [Wed, 3 Oct 2007 16:55:20 +0000 (16:55 +0000)]
* src/modest-platform.h, src/maemo/modest-platform.c:
        * Added method (modest_platform_set_dialog_help) and
          implementation for maemo using hildon/osso help. This method
          sets a topic for contextual help of a dialog.
* src/maemo/modest-account-view-window.c:
        * Attach help topic for accounts settings dialog. This fixes
          NB#64313 at modest side. We still need the topic help in
          help contents.

pmo-trunk-r3463

16 years ago * Fixes NB#65999 note that the translation is still not available
Sergio Villar Senin [Wed, 3 Oct 2007 15:31:19 +0000 (15:31 +0000)]
* Fixes NB#65999 note that the translation is still not available
* Fixes the problem present when creating a new account, the account view was showing the account id of the account instead of the display account
* Now, every account that is added is automatically refreshed

pmo-trunk-r3462

16 years agoThese changes add support for searching in outbox folder (fixes
Jose Dapena Paz [Wed, 3 Oct 2007 09:37:15 +0000 (09:37 +0000)]
These changes add support for searching in outbox folder (fixes
NB#57740).
* src/dbus_api/modest-dbus-callbacks.c:
        * (find_message_by_url): if the url prefix is merge we assume
          we're trying to retrieve a message in outbox.
        * (on_dbus_method_search): we remove the MAND: and USER: strings
          in the received folder name.
        * (add_single_folder_to_list): if folder is merge folder, and
          name is Outbox, we add it to the list of folders as
          MAND:outbox.
        * (add_single_folder_to_list): now we add MAND: prefix if the
          folder is a mandatory folder (inbox, sent, drafts, archive).
          If not, we add the USER: prefix.
* src/modest-search.c:
        * (modest_search_folder): if we search in a specific folder,
          make "outbox" folder name match any folder of type outbox.
* src/modest-tny-account-store.[ch]:
        * Added new method
(modest_tny_account_store_find_msg_in_outboxes)
          that finds a message uri (with the merge:// format) in outbox
          folders, to open it properly. This way, we can open a message
          in an outbox folder from global search emails list.

pmo-trunk-r3457

16 years ago * Moved the op_type to the mail operations, it should be definitely there and not...
Sergio Villar Senin [Tue, 2 Oct 2007 17:43:37 +0000 (17:43 +0000)]
* Moved the op_type to the mail operations, it should be definitely there and not set by external callers. The new operation-started/finished allow us to do this

pmo-trunk-r3456

16 years ago * Added operation-started and operation-finished to the mail operations
Sergio Villar Senin [Tue, 2 Oct 2007 17:06:57 +0000 (17:06 +0000)]
* Added operation-started and operation-finished to the mail operations
* Fixes NB#62764, the progressbar is not shown for local folders

pmo-trunk-r3455

16 years agoModified the changelog with the updated bug fixes and the component change.
Vivek Sekar [Tue, 2 Oct 2007 11:45:16 +0000 (11:45 +0000)]
Modified the changelog with the updated bug fixes and the component change.

pmo-trunk-r3450

16 years ago* src/modest-search.c:
Jose Dapena Paz [Tue, 2 Oct 2007 09:15:49 +0000 (09:15 +0000)]
* src/modest-search.c:
* (add_hit): now we get the minimum of the dates in a header,
  instead of the date received. This way the date is better
  obtained (fixes NB#61007).
* (search_mime_part_strcmp): minor improvemnt in the broken
 no-ogs backend for search.

pmo-trunk-r3449

16 years ago * Fixed NB#62792, the editor is closed if the account is removed
Sergio Villar Senin [Fri, 28 Sep 2007 17:22:09 +0000 (17:22 +0000)]
    * Fixed NB#62792, the editor is closed if the account is removed
        * Added modest_signal_mgr_disconnect, for disconnecting a single handler
        * Added the signal parametter to modest_signal_mgr_connect, this way we can add multiple connections for the same object
        * Renamed modest_window_mgr_(set/get)_modal_dialog to modest_window_mgt_(set/get)_modal because we can set a normal window as modal as well
        * Implemented a queue of modal dialogs in the window mgr, this way if the top one is removed the second one becomes the topmost

pmo-trunk-r3441

16 years agoThis commit implements a new handling of image attachments. We follow
Jose Dapena Paz [Fri, 28 Sep 2007 14:54:55 +0000 (14:54 +0000)]
This commit implements a new handling of image attachments. We follow
the standard of mime, adding the image attachment in a multipart/related
with the body. These together form the complete body of the message.
This fixes NB#64463.
* src/widgets/modest-msg-edit-window.h:
        * Add attribute images to the MsgData.
* src/widgets/modest-attachments-view.c:
        * We only add attachments from message if it's not a
          multipart/related (as they would be attached images and they
          shouldn't be represented in attachments view).
* src/modest-tny-msg.[ch]:
        * (modest_formatter_create_message): now it accepts a new
          parameter "has_images", to create the proper structure of
          image attachments (including the multipart/related).
        * /modest_tny_msg_new_html_plain): now it receives also a
          list of image mime parts. It adds them properly to the
          message using the new add_images() method.
        * (add_attachment). Now it allows adding attachments as children
          of an arbitrary part. This is required to add image
          attachments to multipart/related. It also accepts a new
          parameter "add_inline" to set the disposition as attachment or
          inline depending on the parameter used.
        * (add_images): this new method searches the multipart/related
          mime part, and adds a list of image mime parts to it.
* src/modest-ui-actions.c:
        * Add images parameter to save to drafts and send new mail
          actions.
* src/maemo/modest-msg-edit-window.c:
        * Now we maintain an internal list of images in body buffer,
          separated from the list of attachments.
        * (replace_with_attachments): renamed to replace_with_images
          as it's intended to replace image replacers with attached
          images in priv->images list.
        * New method (get_related_images): searches the
          multipart/related mime part, and obtains all the image
          children it has. Then it adds the images to the priv->images
          list.
        * Now last_cid is updated using the images and attachments list.
        * (modest_msg_edit_window_get_msg_data): now we also obtain the
          list of images attached (unless a image is in priv->image and
          not refernced in the buffer).
* src/modest-formatter.[ch]:
        * Added internal method find_body_parent (), to refactor the
          work to find the part where body should be attached to.
        * (modest_formatter_create_message): now it takes into account
          the new attribute has_images to create the proper mime part
          multipart/related.
* src/modest-mail-operation.[ch]:
        * (modest_mail_operation_create_message): now we pass the images
          list to the lower layers.

pmo-trunk-r3438

16 years ago * The main paned position follows now the 30/70 rule if it was not set previously
Sergio Villar Senin [Fri, 28 Sep 2007 09:45:33 +0000 (09:45 +0000)]
* The main paned position follows now the 30/70 rule if it was not set previously

pmo-trunk-r3436

16 years ago* src/widgets/modest-account-view.c:
Jose Dapena Paz [Thu, 27 Sep 2007 21:28:46 +0000 (21:28 +0000)]
* src/widgets/modest-account-view.c:
        * (on_default_account_changed): Now we check if there's an
          account name, as it was crashing when we removed the last
          available account.
* src/modest-widget-memory.c:
        * (restore_settings_paned, save_settings_paned): now we store
          in ModestConf the percent of the total the separator is
          set, instead of the pixel position. This way, we correctly
          recover the position (fixes NB#63405).

pmo-trunk-r3434

16 years ago * The "account-changed" signal is now properly managed in the ModestTnyAccountStore...
Sergio Villar Senin [Thu, 27 Sep 2007 18:00:57 +0000 (18:00 +0000)]
* The "account-changed" signal is now properly managed in the ModestTnyAccountStore and in ModestTnyAccount, there were some errors in the handler that were actually preventing the account update to happen
* Changed the signature of the method modest_tny_account_update_from_account
* Added display_name_changed signal to notify changes in the display name of the accounts
* ModestConf does not listen for key changes, all signal emissions related to changes in the configuration must be triggered by the account manager
* Removed the ModestConf delayed notification system, we do not need it since we're not listening for chey changes there anymore
* All the modest_account_mgr_(get/set)_(int/book/string/list) are now private methods and could not be used by third parties
* Added a lot of getters and setters to the modest-account-mgr-helpers. We did that to ensure that nobody changes the configuration keys directly (because maybe we want to notify key changes)
* Renamed old modest_server_account_get_xxx by modest_account_mgr_get_server_account_xxx
* Renamed old modest_server_account_set_xxx by modest_account_mgr_set_server_account_xxx
* FolderView now changes the display name of an account if it changes
* AccountView now changes the display name of an account if it changes
* Removed unused code here and there
* Several aesthetic changes here and there

* TODO: I realized that the account-settings dialog thinks that something has changed when you change it and then revert the change
* TODO: detect in the account-settings dialog which changes should issue an "account-changed" signals and which ones not, for example a change in the display name should not force an account reload

pmo-trunk-r3433

16 years agoWork to fix NB#66729: after moving selected messages to another folder,
Jose Dapena Paz [Thu, 27 Sep 2007 17:07:11 +0000 (17:07 +0000)]
Work to fix NB#66729: after moving selected messages to another folder,
selection should go to the next available message.
* src/modest-ui-actions.c:
        * Now we pass a MoveToHelper as argument for move_to_cb. This
          helper contains a row reference for the next row to be
          selected if move to is successful, and the information banner.
        * Added new method get_next_after_selected_headers, that
          obtains a row reference of the next row of the header view
          after the selected headers.
        * (move_to_cb). Now, if we get a row reference in move to
          helper, we select it after moving the messages.

pmo-trunk-r3432