Murray Cumming [Thu, 21 Jun 2007 12:42:31 +0000 (12:42 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.h:
* libmodest-dbus-client/libmodest-dbus-client.c:
(modest_dbus_message_iter_get_search_hit),
(libmodest_dbus_client_search):
Reorganised and commented this.
Removed modest_search_hit_free() from the public API because it
is not needed.
Added libmodest_dbus_client_get_folders() and
modest_folder_result_list_free().
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c:
(modest_dbus_req_filter): Commented. Moved most code to
on_dbus_method_search() and added on_dbus_method_get_folders().
* src/maemo/modest-platform.c: (modest_platform_init): Commented the use
of the extra D-Bus handler.
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_get_folders.c: New test for
libmodest_dbus_client_get_folders(). This seems to return an empty list
at the moment. That could be the same error that causes the message list
to be empty sometimes.
This should help with projects.maemo.org bug NB#57740.
pmo-trunk-r2358
Dirk-Jan C. Binnema [Thu, 21 Jun 2007 12:17:17 +0000 (12:17 +0000)]
* update
pmo-trunk-r2357
Armin Burgmeier [Thu, 21 Jun 2007 11:47:07 +0000 (11:47 +0000)]
2007-06-21 Armin Burgmeier <armin@openismus.com>
* src/modest-mail-operation.c: Do not call
modest_mail_operation_queue_cancel_all() in _cancel() but do instead
notify the operation's end after having set the status to CANCELED for
the operation queue to listen on. This fixes a deadlock when there
were mail operations in the queue during its finalization.
* src/modest-singletons.c: Reordered uninitialization of the account
manager to happen after the mail operation queue was uninitialized
because the mail operation's in the queue might still try to access
the account manager (see modest_mail_operation_notify_end()). This
fixes a potential crash when terminating the application.
pmo-trunk-r2354
Jose Dapena Paz [Thu, 21 Jun 2007 10:53:43 +0000 (10:53 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now "Select all" is dimmed when focus is on an area without anything
to select (for example, an empty body) (fixes NB#59393).
* Minor API fix on usage of priority flags.
pmo-trunk-r2353
Murray Cumming [Thu, 21 Jun 2007 10:14:44 +0000 (10:14 +0000)]
removed junk
pmo-trunk-r2352
Murray Cumming [Thu, 21 Jun 2007 10:13:42 +0000 (10:13 +0000)]
2007-06-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c:
(search_mime_part_and_child_parts): Moved some code here so we
can search recursively in child folders.
(modest_search_folder): Search in the message as a mime part, instead
of just its child mime parts.
(read_chunk), (search_mime_part_ogs):
Check how many bytes were read, to prevent an endless loop.
Searching in message bodies now works. This finishes the fix for
projects.maemo.org bug NB#61007.
pmo-trunk-r2351
Jose Dapena Paz [Thu, 21 Jun 2007 09:35:23 +0000 (09:35 +0000)]
* src/modest-platform.h:
* Added a new platform function for showing information banner. Should
remove a new dependency in common non specific maemo code.
* src/modest-dimming-rules-group.c:
* Now it does not use hildon information banner, but the new platform
equivalent.
* src/modest-ui-actions.c:
* Now it shows an information banner on copying the messages to outbox
(fixes NB#59332).
* src/maemo/modest-platform.c:
* Added implementation of the new information banner platform function,
that uses the hildon information banner.
pmo-trunk-r2350
Javier Fernandez Garcia-Boente [Thu, 21 Jun 2007 08:45:19 +0000 (08:45 +0000)]
* Add some utility funcitons to email clipboard to check
if changes made on any folder must force to clear clipboard
data.
* Add new dimming rules for paste messages operation.
* Fixes: NB#59395
pmo-trunk-r2349
Jose Dapena Paz [Thu, 21 Jun 2007 08:37:11 +0000 (08:37 +0000)]
* src/modest-init.c:
* Now sort values are initialized to useful default values
(fixes NB#59321).
pmo-trunk-r2348
Jose Dapena Paz [Wed, 20 Jun 2007 17:39:01 +0000 (17:39 +0000)]
* src/maemo/modest-msg-edit-window-ui.xml:
* Removed delete message action, as it's not in new UI specs
(fixes NB#59245).
pmo-trunk-r2347
Jose Dapena Paz [Wed, 20 Jun 2007 17:34:00 +0000 (17:34 +0000)]
* src/maemo/modest-msg-edit-window-ui.xml:
* Removed delete message action, as it's not in new UI specs
(fixes NB#59245).
pmo-trunk-r2346
Jose Dapena Paz [Wed, 20 Jun 2007 17:26:29 +0000 (17:26 +0000)]
* src/maemo/modest-main-window.c:
* Now "send & receive/all" is hidden when there's only one
account available (fixes NB#59238).
pmo-trunk-r2345
Jose Dapena Paz [Wed, 20 Jun 2007 16:49:04 +0000 (16:49 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now it dims remove attachments action when there's no
attachment selected, and when there are more than one.
Also added insensitive press messages for both
(fixes NB#59176).
pmo-trunk-r2344
Jose Dapena Paz [Wed, 20 Jun 2007 16:25:05 +0000 (16:25 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now it dims properly the Paste menu option (fixes NB#58809).
pmo-trunk-r2343
Murray Cumming [Wed, 20 Jun 2007 15:47:22 +0000 (15:47 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (modest_ui_actions_on_details):
Add a g_warning when the item is not a folder.
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
when selected item is not a folder (for instance, an account), because
the UI spec only talks about folders.
I am not sure what the UI spec wants, so this might not totally fix
projects.maemo.org bug NB#60794.
pmo-trunk-r2342
Jose Dapena Paz [Wed, 20 Jun 2007 15:42:31 +0000 (15:42 +0000)]
* src/widgets/modest-header-view.c:
* Fix sort by priority, as it wasn't comparing the
fields values properly.
* src/maemo/modest-platform.c:
* Fix recovering the sort status from header view to
create the sort dialog.
* Save the new widget status on finishing the sort
(fixes NB#58628).
* src/modest-widget-memory.c:
* Fix the recovering of sort status from header view.
pmo-trunk-r2341
Murray Cumming [Wed, 20 Jun 2007 15:03:06 +0000 (15:03 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
(load_from_file): Sort the list. The unsorted list would be more noticeable
in non-English locales.
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file): Initialize a variable to avoid a
warning and fix the build.
* src/maemo/modest-progress-bar-widget.c:
(modest_progress_bar_widget_set_progress): Avoid a division by zero, to
avoid a g_warning, and probably to avoid a crash.
pmo-trunk-r2340
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 14:40:02 +0000 (14:40 +0000)]
Add some notifications to dimmed rules.
pmo-trunk-r2339
Murray Cumming [Wed, 20 Jun 2007 14:25:17 +0000 (14:25 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
* src/modest-search.c: (modest_search_folder): Check for a GError
when calling tny_folder_get_headers(), to show that this is not the cause
of later failure.
pmo-trunk-r2338
Murray Cumming [Wed, 20 Jun 2007 14:11:31 +0000 (14:11 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
Actually set the body query instead of the subject query.
* src/modest-search.c: (search_mime_part_ogs),
(search_mime_part_strcmp): Remove extra space from the text/* regex,
which would probably cause it to fail if we got this far.
(modest_search_folder): Use simple #ifdefs instead of the function pointer,
to simplify the code.
Warn when tny_mime_part_get_parts() returns an empty list, which seems to
be causing search-in-body to fail.
pmo-trunk-r2337
Jose Dapena Paz [Wed, 20 Jun 2007 14:02:17 +0000 (14:02 +0000)]
* src/maemo/modest-address-book.c:
* Minor change to avoid problems with addressbook init.
* src/maemo/modest-msg-edit-window.c:
* Support attaching more than one file at a time
(fixes NB#58614).
* src/maemo/modest-msg-view-window.c:
* Add an information banner for trying to search an empty
string.
pmo-trunk-r2336
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 13:51:37 +0000 (13:51 +0000)]
* Increase performance of dimming rules manager, avoiding call
get_selected_headers to check if no headers were selected to
perform operation.
pmo-trunk-r2335
Sergio Villar Senin [Wed, 20 Jun 2007 13:36:05 +0000 (13:36 +0000)]
* Added ending notification to the send_mail operation
* Fixed a problem with armin's modest_tny_send_queue code, it was causing a crash due to a g_assert
pmo-trunk-r2334
Jose Dapena Paz [Wed, 20 Jun 2007 13:28:26 +0000 (13:28 +0000)]
* src/widget/modest-attachments-view.c:
* Crashed when there was an attached message with
a NULL subject. Fixed (fixes NB#61283).
pmo-trunk-r2333
Philip Van Hoof [Wed, 20 Jun 2007 13:19:54 +0000 (13:19 +0000)]
Added listening on an extra signal
pmo-trunk-r2332
Sergio Villar Senin [Wed, 20 Jun 2007 11:57:49 +0000 (11:57 +0000)]
* Added progress information to open single message operation
* Added byte information to the ModestMailOperationStatus struct
pmo-trunk-r2331
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 11:48:47 +0000 (11:48 +0000)]
* Fixed problem with focus and move_to operation.
pmo-trunk-r2330
Murray Cumming [Wed, 20 Jun 2007 10:10:19 +0000 (10:10 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
struct item.
* src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
Better debug message when the folder cannot be found.
This should help with fixing projects.maemo.org bug #61287.
* src/modest-search.c: (add_hit): Do not leak the furl string.
pmo-trunk-r2329
Sergio Villar Senin [Wed, 20 Jun 2007 09:45:50 +0000 (09:45 +0000)]
* Fixed a lot of reference leaks
* Fixed a problem when closing the main window
pmo-trunk-r2328
Dirk-Jan C. Binnema [Wed, 20 Jun 2007 09:12:19 +0000 (09:12 +0000)]
* don't make in the po/ directory
* add libogs1.2-dev as a dep for debian packaging (maemo1)
pmo-trunk-r2327
Murray Cumming [Wed, 20 Jun 2007 08:53:06 +0000 (08:53 +0000)]
2007-06-20 Murray Cumming <murrayc@murrayc-desktop>
* src/modest-ui-actions.c:
(modest_ui_actions_on_folder_selection_changed):
Do not special-case TNY_MERGE_FOLDER here, because
modest_tny_folder_get_account() already does that. This fixes
projects.maemo.org bug NB#60955 (The smtp connections dialog was not
shown when the Outbox was selected).
pmo-trunk-r2326
Dirk-Jan C. Binnema [Wed, 20 Jun 2007 08:50:22 +0000 (08:50 +0000)]
* set the folder name in instead of the folder-url for the search results
pmo-trunk-r2325
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 07:52:49 +0000 (07:52 +0000)]
Fixes: NB#61019
pmo-trunk-r2323
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 07:12:04 +0000 (07:12 +0000)]
* Fixes: NB#59203
pmo-trunk-r2322
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 06:47:03 +0000 (06:47 +0000)]
* Changes in the localization structure. GETTEXT package is
configure in configure.ac, checking version of application
in order to use trnaslation packages or .po files.
* Avoid using GTK_WIDGET_HAS_FOCUS to check if some widget has
the focus, because we need to check window local focus, rather
than global focus.
pmo-trunk-r2321
Murray Cumming [Tue, 19 Jun 2007 17:16:26 +0000 (17:16 +0000)]
2007-06-19 Murray Cumming,,, <murrayc@murrayc-desktop>
* libmodest-dbus-client/libmodest-dbus-client.c:
(_dbus_iter_get_string_or_null): Initialize the string variable in
case this helps with Dirk's crash.
2007-06-19 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
though it is not implemented yet (this function is maybe not even used),
to avoid breaking ABI in future.
* libmodest-dbus-client/libmodest-dbus-client.c:
(get_attachments_string): Moved some code into this generic function.
(libmodest_dbus_client_send_mail): Corrected the documentation. This really
sends email. It is maybe not used.
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
(on_send_mail): Use attachments.
* src/widgets/modest-msg-edit-window.h: Improve the documentation.
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
a filename before using it, to fix projects.maemo.org bug NB#58233.
pmo-trunk-r2319
Jose Dapena Paz [Tue, 19 Jun 2007 16:36:53 +0000 (16:36 +0000)]
Fix for some issues in translation of plural strings (fixes NB#61146).
* src/modest-ui-actions.c:
* src/modest-msg-edit-window.c:
* Changed translations of plurals to use ngettext.
pmo-trunk-r2318
Jose Dapena Paz [Tue, 19 Jun 2007 15:20:50 +0000 (15:20 +0000)]
* src/maemo/modest-platform.c:
* (modest_platform_show_uri_popup): now it uses the translation
domain of the actions (fixes NB#61049).
pmo-trunk-r2316
Dirk-Jan C. Binnema [Tue, 19 Jun 2007 15:20:13 +0000 (15:20 +0000)]
Updated the changelog with the fixes made on 2007.06.19.
pmo-trunk-r2314
Jose Dapena Paz [Tue, 19 Jun 2007 14:58:06 +0000 (14:58 +0000)]
Work to fix priority recovering from messages (fixes NB#58045).
* src/maemo/modest-msg-edit-window.c:
* Now it gets the priority flags from the message it's
constructed from.
* Updates the priority in menus with the initial values.
Other changes
* src/maemo/modest-msg-edit-window.c:
* Minor translation fix.
pmo-trunk-r2313
Sergio Villar Senin [Tue, 19 Jun 2007 14:13:09 +0000 (14:13 +0000)]
* Allow incremental filling of the headers view while refreshing the folder
pmo-trunk-r2312
Murray Cumming [Tue, 19 Jun 2007 13:53:16 +0000 (13:53 +0000)]
slightly improved debug messages
pmo-trunk-r2311
Murray Cumming [Tue, 19 Jun 2007 13:10:55 +0000 (13:10 +0000)]
Improved debug message
pmo-trunk-r2310
Sergio Villar Senin [Tue, 19 Jun 2007 11:50:54 +0000 (11:50 +0000)]
* Fixed a memory corruption problem while initializing threads
* Added a poke_status call whenever we update an account with the send&receive button
pmo-trunk-r2309
Philip Van Hoof [Tue, 19 Jun 2007 11:31:46 +0000 (11:31 +0000)]
First-time quickfix
pmo-trunk-r2308
Murray Cumming [Tue, 19 Jun 2007 11:06:41 +0000 (11:06 +0000)]
2007-06-19 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (modest_ui_actions_on_copy):
Initialize the continue_download variable to fix the build, and probably
to fix randome behaviour.
pmo-trunk-r2307
Sergio Villar Senin [Tue, 19 Jun 2007 09:52:35 +0000 (09:52 +0000)]
* Fixes NB#60735, ask for confirmation when copying mails from a POP account
pmo-trunk-r2306
Sergio Villar Senin [Tue, 19 Jun 2007 08:56:46 +0000 (08:56 +0000)]
* Fixes NB#57632, the delete option is dimmed for folders
pmo-trunk-r2305
Jose Dapena Paz [Tue, 19 Jun 2007 08:25:35 +0000 (08:25 +0000)]
Fix dimming rules for add to contacts action (fixes NB#59174).
* src/modest-ui-dimming-rules.[ch]:
* Added dimming rule for add to contacts.
* src/maemo/modest-msg-view-window.c:
* Added new dimming rule for add to contacts action.
pmo-trunk-r2304
Dirk-Jan C. Binnema [Tue, 19 Jun 2007 08:16:56 +0000 (08:16 +0000)]
* leak fixes; free both list and its elements when we call modest_account_mgr_account_names
* use the new function modest_account_mgr_free_account_names
* some other smaller leak fixes
pmo-trunk-r2303
Dirk-Jan C. Binnema [Tue, 19 Jun 2007 07:47:50 +0000 (07:47 +0000)]
* temporary crash fix for modest-tny-send-queue
pmo-trunk-r2302
Philip Van Hoof [Tue, 19 Jun 2007 07:44:42 +0000 (07:44 +0000)]
Small bugfix
pmo-trunk-r2301
Philip Van Hoof [Tue, 19 Jun 2007 07:43:02 +0000 (07:43 +0000)]
Question and small bugfix
pmo-trunk-r2300
Jose Dapena Paz [Tue, 19 Jun 2007 07:37:44 +0000 (07:37 +0000)]
* src/maemo/modest-msg-view-window.c:
* Modified to use the save objects dialog (fixes NB#59057).
pmo-trunk-r2299
Philip Van Hoof [Tue, 19 Jun 2007 07:34:18 +0000 (07:34 +0000)]
Error handling for the send queues
pmo-trunk-r2298
Sergio Villar Senin [Tue, 19 Jun 2007 06:47:22 +0000 (06:47 +0000)]
* Fixed several reference count leaks in the dimming rules
* Fixed several reference count leaks in the folder view
* Added a dispose method to the header view to prevent cycles when unrefs
* Commented some debug code
* Removed an initialization that could cause the blank right paned issue
pmo-trunk-r2297
Armin Burgmeier [Mon, 18 Jun 2007 20:52:22 +0000 (20:52 +0000)]
2007-06-18 Armin Burgmeier <armin@openismus.com>
* src/modest-tny-send-queue.h:
* src/modest-tny-send-queue.c: Keep track of the status of messages in
the queue so we can later show it in the UI. Replaced
modest_tny_send_queue_msg_is_being_sent() by
modest_tny_send_queue_get_msg_status().
* src/modest-ui-dimming-rules.c: Adjust for the replaced function.
* src/modest-tny-account.c: Changed a cast to gpointer* to one to
gpointer. This probably was not harmful, but just to be sure.
pmo-trunk-r2296
Jose Dapena Paz [Mon, 18 Jun 2007 16:13:14 +0000 (16:13 +0000)]
Work to fix recovering sort status in headers view (fixes NB#58250).
* src/maemo/modest-platform.c:
* Now it retrieves the current header view sort column,
sort type, and in case of sorting flags, the flag we sort.
This way, the dialog is prefilled with the current header
view status.
* src/modest-widget-memory-priv.h:
* Added the new kind of key "column-sort", that specified the
model column used to sort in header view.
* src/modest-widget-memory.c:
* Now save_settings_header_view and restore_settings_header_view
store a global sort value. This is required for recovering the
sort status in the compact view.
Other fixes:
* src/modest-ui-dimming-rules.c:
* Condition for one or more attachments was wrong.
pmo-trunk-r2292
Javier Fernandez Garcia-Boente [Mon, 18 Jun 2007 15:25:42 +0000 (15:25 +0000)]
* Fixed several logical id transations.
* Fixes: NB#60765, NB#60768, NB#60770, NB#60771, NB#60774, NB#60774
* Fixes: NB#60775, NB#60776, NB#60777, NB#60954, NB#60952, NB#60953
* Fixes: NB#60964, NB#60968
pmo-trunk-r2289
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 15:24:48 +0000 (15:24 +0000)]
* hopefully, this restores the bora-build
pmo-trunk-r2288
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 14:53:59 +0000 (14:53 +0000)]
updated the changelog, removed all the old bugs from the list
pmo-trunk-r2287
Murray Cumming [Mon, 18 Jun 2007 14:41:16 +0000 (14:41 +0000)]
2007-06-18 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c: (modest_platform_activate_uri):
Fix the build, but leave the function broken on Bora, because
hildon_uri_action_get_service() does not exist.
osso_uri_action_get_service() does not exist either, it seems.
pmo-trunk-r2286
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 13:53:28 +0000 (13:53 +0000)]
updated the changelog, removed some released bugs from the list
pmo-trunk-r2285
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 13:52:50 +0000 (13:52 +0000)]
updated the changelog, removed some released bugs from the list
pmo-trunk-r2284
Javier Fernandez Garcia-Boente [Mon, 18 Jun 2007 13:36:53 +0000 (13:36 +0000)]
Fixed som compilation errors.
pmo-trunk-r2283
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 13:21:47 +0000 (13:21 +0000)]
* fix logical id, NB#60950
pmo-trunk-r2282
Javier Fernandez Garcia-Boente [Mon, 18 Jun 2007 13:13:55 +0000 (13:13 +0000)]
* Add a new singleton to be used as headers clipboard
on copy, cut and paste operaitons.
* Implement copy, cut and paste operations for both, headers
and folders view.
* Fixes: NB##58174
pmo-trunk-r2280
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 12:32:32 +0000 (12:32 +0000)]
* fix the uri activation, bug NB#58220
pmo-trunk-r2278
Jose Dapena Paz [Mon, 18 Jun 2007 11:56:21 +0000 (11:56 +0000)]
* src/modest-msg-edit-window.c:
* Added autocap for subject field (fixes NB#57932).
pmo-trunk-r2277
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 11:50:42 +0000 (11:50 +0000)]
* some more crash-avoiding
pmo-trunk-r2276
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 11:41:40 +0000 (11:41 +0000)]
* check some parameters (give BUG: warnings instead of crashing)
pmo-trunk-r2275
Jose Dapena Paz [Mon, 18 Jun 2007 11:15:00 +0000 (11:15 +0000)]
* src/maemo/modest-msg-view-window.c:
* Added menu action for find in page (fixes NB#57201).
pmo-trunk-r2274
Jose Dapena Paz [Mon, 18 Jun 2007 10:44:32 +0000 (10:44 +0000)]
* src/widgets/modest-window-mgr.c:
* Now it does not crash if we cannot get an uid from one of the
windows (should happen at least with main window, but also
with editors) (fixes NB#60430).
pmo-trunk-r2273
Jose Dapena Paz [Mon, 18 Jun 2007 10:12:11 +0000 (10:12 +0000)]
Work to fix bugs getting the From: field in the editor for new messages
and messages opened in drafts folder (fixes NB#58214, NB#58219):
* src/modest-ui-actions.c:
* Now "New message" and "open message from drafts" fill the from
field in the editor with the default account instead of the
current folder active account.
* src/maemo/modest-msg-edit-window.c:
* Fills the From: field with the account name passed in the
constructor.
pmo-trunk-r2272
Murray Cumming [Mon, 18 Jun 2007 10:10:59 +0000 (10:10 +0000)]
2007-06-18 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
Uncommented the url debug output again, because it is useful for
debugging, as I said in the comment.
pmo-trunk-r2271
Murray Cumming [Mon, 18 Jun 2007 09:00:27 +0000 (09:00 +0000)]
2007-06-18 Murray Cumming <murrayc@murrayc.com>
* configure.ac: Do not require hildon-notify for Maemo Bora. It is not
available.
* src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
for Mameo Bora, to fix the build.
pmo-trunk-r2270
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 07:47:04 +0000 (07:47 +0000)]
* Updated the changelog with fixes made till 2007.06.18 10:45am
pmo-trunk-r2269
Johannes Schmid [Sun, 17 Jun 2007 21:15:36 +0000 (21:15 +0000)]
2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
* configure.ac:
Fixed build with hildon < 0.99
* src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
Check if the selected account is busy instead of checking all accounts
* src/modest-account-mgr-priv.h:
* src/modest-account-mgr.c: (modest_account_mgr_class_init),
(modest_account_mgr_init), (compare_account_name),
(modest_account_mgr_set_account_busy),
(modest_account_mgr_account_is_busy):
* src/modest-account-mgr.h:
Added busy information to the account manager. It possible to
set an account to busy or not busy now.
* src/modest-mail-operation.c: (modest_mail_operation_finalize),
(modest_mail_operation_update_account),
(modest_mail_operation_notify_end):
Set the account to busy/not busy depending on the operation state.
* src/widgets/modest-account-view.c:
(modest_account_view_finalize), (get_last_updated_string),
(update_account_view), (on_account_busy_changed), (init_view):
Show string \"Refreshing...\" if the account is currently busy.
All this fixes projects.maemo.org bug NB#59711
pmo-trunk-r2268
Dirk-Jan C. Binnema [Sat, 16 Jun 2007 14:45:49 +0000 (14:45 +0000)]
* make modest work on pre-OSSO 1.1 once more (don't require the notification stuff)
pmo-trunk-r2267
Jose Dapena Paz [Fri, 15 Jun 2007 17:19:26 +0000 (17:19 +0000)]
* src/maemo/modest-icon-names.h:
* Added macros for bold and italic toolbar icons.
* src/widgets/modest-msg-edit-window-ui.h:
* Use the maemo bold and italic icons (fixes NB#58612).
pmo-trunk-r2266
Jose Dapena Paz [Fri, 15 Jun 2007 17:03:42 +0000 (17:03 +0000)]
* src/widgets/modest-mail-header-view.c:
* If subject is empty string it shows "No subject" string
(fixes NB#58610).
pmo-trunk-r2265
Jose Dapena Paz [Fri, 15 Jun 2007 16:27:25 +0000 (16:27 +0000)]
* src/modest-text-utils.c:
* Fixed the signature inclusion in _cite. This way, the
signature adds an empty line before it in editor.
* Now forward uses the same code reply uses for
formatting messages, this fixes some issues
(fixes NB#58430).
pmo-trunk-r2264
Dirk-Jan C. Binnema [Fri, 15 Jun 2007 16:25:24 +0000 (16:25 +0000)]
* small improvements in the progress bar widget
pmo-trunk-r2263
Jose Dapena Paz [Fri, 15 Jun 2007 15:46:17 +0000 (15:46 +0000)]
* src/widgets/modest-attachment-view.c:
* Set better the event box initialisation.
* src/widgets/modest-attachments-view.c:
* Not it uses internally the absolute position of the events and
specific attachment views. This finally fixes a hard bug.
(fixes NB#58394).
* src/maemo/modest-addressbook.c:
* Uses the synchronous call to open the address book on
selecting addresses.
pmo-trunk-r2262
Dirk-Jan C. Binnema [Fri, 15 Jun 2007 14:59:01 +0000 (14:59 +0000)]
Updated the changelog with fixes made on 2007.06.15.
pmo-trunk-r2261
Dirk-Jan C. Binnema [Fri, 15 Jun 2007 14:26:03 +0000 (14:26 +0000)]
* temp fix to prevent crashing while doing wild folder changing / cancelling actions
pmo-trunk-r2260
Sergio Villar Senin [Fri, 15 Jun 2007 13:00:46 +0000 (13:00 +0000)]
* Fixes NB#59717 that was reopened
* Added modest_main_window_get_contents_style
* Fixed a problem with the empty view when moving messages to an empty folder
pmo-trunk-r2259
Philip Van Hoof [Fri, 15 Jun 2007 12:52:28 +0000 (12:52 +0000)]
Small compilation warning fix
pmo-trunk-r2258
Philip Van Hoof [Fri, 15 Jun 2007 12:50:10 +0000 (12:50 +0000)]
Small compilation warning fix
pmo-trunk-r2257
Philip Van Hoof [Fri, 15 Jun 2007 12:47:11 +0000 (12:47 +0000)]
Small compilation warning fix
pmo-trunk-r2256
Philip Van Hoof [Fri, 15 Jun 2007 12:44:43 +0000 (12:44 +0000)]
Small compilation warning fix
pmo-trunk-r2255
Dirk-Jan C. Binnema [Fri, 15 Jun 2007 12:35:17 +0000 (12:35 +0000)]
* add "Copy" to the CSM; might fix NB#58246, but needs discussion with the UI designer
pmo-trunk-r2254
Sergio Villar Senin [Fri, 15 Jun 2007 12:13:11 +0000 (12:13 +0000)]
* Fixed some wrong dimming rules names
* Fixes NB#60205 Modest no longer crashes when transfering the last msg of a folder from the view window
* Removed an invalid assertion
* Fixed some memory leaks
pmo-trunk-r2253
Jose Dapena Paz [Fri, 15 Jun 2007 10:23:28 +0000 (10:23 +0000)]
* src/modest-text-utils.[ch]:
* (modest_text_utils_get_subject_prefix_len): added some strings
to the subject filter.
* src/widgets/modest-header-view.c:
* Added (cmp_subject_rows), that compares the subjects filtering
the Re:, Fwd:, etc.
* Now it uses the new cmp_subject_rows function to sort the
headers with subject field.
pmo-trunk-r2252
Sergio Villar Senin [Fri, 15 Jun 2007 09:08:06 +0000 (09:08 +0000)]
* Expunge the draft messages when removed. Fixes NB#60398
pmo-trunk-r2251
Sergio Villar Senin [Fri, 15 Jun 2007 08:30:37 +0000 (08:30 +0000)]
* Fixes NB#59396, the OUTBOX folder icon is now shown properly
* Changed the folder type detection in the folder rules
pmo-trunk-r2249
Sergio Villar Senin [Fri, 15 Jun 2007 08:10:54 +0000 (08:10 +0000)]
* Fixes NB#59030, fixed the items of the Reply CSM
pmo-trunk-r2248
Sergio Villar Senin [Fri, 15 Jun 2007 07:57:31 +0000 (07:57 +0000)]
* Fixes NB#58331, INBOX must not be moveable
* Added an pvanhoof's speedup enhancenment when marking headers as read/unread
* Added folder rules for the inbox folder
* Unregistered a signal handler in the folder view when finalized
pmo-trunk-r2247
Sergio Villar Senin [Fri, 15 Jun 2007 06:43:11 +0000 (06:43 +0000)]
* Removed my own error handler that I use for debugging
pmo-trunk-r2244
Armin Burgmeier [Thu, 14 Jun 2007 21:39:11 +0000 (21:39 +0000)]
2007-06-14 Armin Burgmeier <armin@openismus.com>
* src/widgets/modest-attachments-view.h:
* src/widgets/modest-attachments-view.c: Added
modest_attachments_view_has_attachments() and fixed coordinate
transformation in get_att_view_at_coords(). This fixes attachment
selection.
* src/widgets/modest-msg-view.c: Make use of
modest_attachments_view_has_attachments() to decide whether to show
attachments in the header.
pmo-trunk-r2243
projects / modest / log