Sergio Villar Senin [Thu, 14 Feb 2008 20:32:02 +0000 (20:32 +0000)]
* Added some comments
pmo-trunk-r4178
Sergio Villar Senin [Thu, 14 Feb 2008 12:36:53 +0000 (12:36 +0000)]
* Replaced modest_msg_edit_window_reset_modified by modest_msg_edit_window_set_modified with a new boolean parametter
* Added a new parametter to modest_ui_actions_compose_msg that instructs the method to set the edit window as modified or not
* Opening a new editor from Contacts plugin and closing it without modifying it no longer shows the "Save message" dialog
* Fixes NB#78911, set the edit window as modified when a new email is created from an external application
pmo-trunk-r4177
Alberto Garcia [Thu, 14 Feb 2008 11:25:03 +0000 (11:25 +0000)]
* src/modest-mail-operation.c
(modest_mail_operation_cancel): All calls to this function
should be able to call tny_account_cancel()
Partially fixes NB#78460
pmo-trunk-r4176
Sergio Villar Senin [Thu, 14 Feb 2008 09:12:28 +0000 (09:12 +0000)]
* Fixes a terrible mistake by my side that could cause SIGSEV's in some situations, I was incorrectly unref'ing the outbox folder
* Replaced a tny_folder_sync by the async version
pmo-trunk-r4175
Dirk-Jan C. Binnema [Wed, 13 Feb 2008 23:52:21 +0000 (23:52 +0000)]
* updated NEWS for W08 (so far), made it org-mode compliant
pmo-trunk-r4174
Dirk-Jan C. Binnema [Wed, 13 Feb 2008 20:02:12 +0000 (20:02 +0000)]
* fix for a rare crash; fixes NB#80616.
it's debatable whether this bug was not already fixed by the send-queue fixes done before; but as this crash was seen with W06, there *might* still be a problem.
so, fixing the symptom here. not sure what led to the crash, but it should not happen anymore.
pmo-trunk-r4173
Alberto Garcia [Wed, 13 Feb 2008 18:30:10 +0000 (18:30 +0000)]
* src/modest-ui-actions.c:
(modest_ui_actions_get_msgs_full_error_handler)
* src/widgets/modest-header-view.c:
(refresh_folder_error_handler)
Don't show an error message if the mail operation has been
cancelled, because that's not an error.
pmo-trunk-r4172
Sergio Villar Senin [Wed, 13 Feb 2008 13:25:26 +0000 (13:25 +0000)]
* Fixes NB#80619, do not force the width of the accounts dialog in order not to truncate the column titles
pmo-trunk-r4171
Sergio Villar Senin [Wed, 13 Feb 2008 12:57:18 +0000 (12:57 +0000)]
* Dramatically refactored the message transfers, now the same code is used for a lot of cases (d&d is still pending)
* Fixes NB#78546, "connection canceled" is no longer shown after moving a message, now we consider all the cases that could take place in offline mode
pmo-trunk-r4170
Alberto Garcia [Wed, 13 Feb 2008 12:32:10 +0000 (12:32 +0000)]
Revert fix for modest_text_utils_convert_buffer_to_html_start()
in r4166 and apply a more optimal one instead
pmo-trunk-r4169
Sergio Villar Senin [Tue, 12 Feb 2008 19:37:31 +0000 (19:37 +0000)]
* Removed an unused method
* Do not try to connect when transferring messages if they're already downloaded
pmo-trunk-r4168
Sergio Villar Senin [Tue, 12 Feb 2008 17:33:09 +0000 (17:33 +0000)]
* Fixed a ARMEL compilation warning
* Fixes NB#79816, show the proper message when trying to save an attachment and there is no space left on device
pmo-trunk-r4167
Alberto Garcia [Tue, 12 Feb 2008 12:34:45 +0000 (12:34 +0000)]
Fix a problem in modest_text_utils_convert_buffer_to_html_start()
that might produce non-UTF8 output.
Partially fixes NB#80213
pmo-trunk-r4166
Sergio Villar Senin [Tue, 12 Feb 2008 10:25:09 +0000 (10:25 +0000)]
* Fixes NB#80554, show the proper error message when deleting a sending message even though we have a viewer opened with that message
pmo-trunk-r4165
Jose Dapena Paz [Tue, 12 Feb 2008 09:30:05 +0000 (09:30 +0000)]
* src/modest-ui-dimming-rules.c:
* Now we check the active account of the message view or
main window to dim purge if it's a pop account
(fixes NB#80377).
pmo-trunk-r4164
Jose Dapena Paz [Mon, 11 Feb 2008 18:26:50 +0000 (18:26 +0000)]
* src/modest-ui-actions.c:
* Added a forgotten return in on_delete_folder_cb, for the
case we cancelled the attempt to connect (fixes NB#79872).
pmo-trunk-r4163
Sergio Villar Senin [Mon, 11 Feb 2008 17:41:18 +0000 (17:41 +0000)]
* Do not run the alarm if the device is offline -> fix by earth saver djcb
pmo-trunk-r4162
Jose Dapena Paz [Mon, 11 Feb 2008 17:37:51 +0000 (17:37 +0000)]
* src/widgets/modest-gtkhtml-msg-view.c:
* Add support for vertical panning in maemo. This way, panning
vertically changes properly the vertical adjustment of the
msg view (fixes NB#80484).
pmo-trunk-r4161
Sergio Villar Senin [Mon, 11 Feb 2008 17:27:35 +0000 (17:27 +0000)]
* created a new method in modest-platform to make it easy to connect to two accounts
* Fixes NB#80155, IMAP folders could be moved again to the MMC account
pmo-trunk-r4160
Alberto Garcia [Mon, 11 Feb 2008 15:55:06 +0000 (15:55 +0000)]
Decode the mime part when copying it
Fixes NB#78802
pmo-trunk-r4159
Jose Dapena Paz [Mon, 11 Feb 2008 11:59:27 +0000 (11:59 +0000)]
* src/widgets/modest-progress-bar.c:
* Show "receiving" string also for send/receive mail operation
(fixes NB#79684).
pmo-trunk-r4158
Jose Dapena Paz [Mon, 11 Feb 2008 11:13:03 +0000 (11:13 +0000)]
* src/maemo/modest-connection-specific-smtp-edit-window.c:
* Now the dialog fields are inside a scrolled window, and then,
vkb does not spoil the dialog layout (fixes NB#80471).
pmo-trunk-r4157
Vivek Sekar [Mon, 11 Feb 2008 09:09:37 +0000 (09:09 +0000)]
Added bug fixes for week 07, 11th Feb.
pmo-trunk-r4156
Jose Dapena Paz [Mon, 11 Feb 2008 07:27:52 +0000 (07:27 +0000)]
Changes to disable cut/copy with images (fixes NB#80355).
* src/modest-text-utils.[ch], src/modest-ui-dimming-rules.c:
* Refactored a method to check if a GtkTextBuffer has a valid
cut/copy selection (currently it means it's not empty and does
not contain images inside).
* src/modest-ui-actions.c:
* Don't cut/copy if the selection is not valid.
* src/maemo/modest-msg-edit-window.c:
* Disable default cut/copy handlers if no selection is valid.
pmo-trunk-r4155
Dirk-Jan C. Binnema [Fri, 8 Feb 2008 20:41:15 +0000 (20:41 +0000)]
* add some extra error checking; fixes NB#80432
pmo-trunk-r4154
Vivek Sekar [Fri, 8 Feb 2008 13:39:04 +0000 (13:39 +0000)]
corrected a typo, and bug was added to w06 tag.
pmo-trunk-r4152
Vivek Sekar [Fri, 8 Feb 2008 13:34:59 +0000 (13:34 +0000)]
Added week 07 bug fixes, and updated the NEWS file.
pmo-trunk-r4150
Jose Dapena Paz [Fri, 8 Feb 2008 11:35:35 +0000 (11:35 +0000)]
* src/modest-ui-dimming-rules.c:
* Disable copying images (fixes NB#80355).
pmo-trunk-r4149
Jose Dapena Paz [Fri, 8 Feb 2008 10:53:51 +0000 (10:53 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now we properly scroll on find in page (fixes NB#80341).
* Also fixed the algorithm to recalculate the new scroll
position.
pmo-trunk-r4148
Jose Dapena Paz [Fri, 8 Feb 2008 10:26:56 +0000 (10:26 +0000)]
* src/modest-tny-mime-part.[ch]:
* New method to know if a TnyMsg instance is really a message
or in fact it's a direct attachment.
* src/widgets/modest-attachments-view.c:
* On setting a message, if it's an application
multipart/related, show its contents as attachments (should
help showing smil messages).
* On setting a message, if the top mime part is a file, then
show it as attachment.
* src/modest-tny-msg.c:
* Modify code to detect body, to take into account the
application multiparts (as smil) and direct attachments. These
shouldn't show a body.
* On creating forward messages, attach properly the direct
attachments (we don't show any body for them).
* src/maemo/modest-msg-view-window.c:
* Manage properly the application multiparts and top mime part
attachments.
* src/modest-formatter.c:
* Modify attach method to work if body is NULL.
pmo-trunk-r4147
Dirk-Jan C. Binnema [Thu, 7 Feb 2008 22:18:04 +0000 (22:18 +0000)]
* use the correct toolbar icon for "Send"; fixes NB#80382
pmo-trunk-r4146
Alberto Garcia [Thu, 7 Feb 2008 10:40:59 +0000 (10:40 +0000)]
Treat a message as modified if the From: field changes
Fixes NB#80271
pmo-trunk-r4145
Alberto Garcia [Wed, 6 Feb 2008 19:33:39 +0000 (19:33 +0000)]
When opening an e-mail from the Drafts folder, maintain the
same From: address
Partially fixes NB#80271
pmo-trunk-r4144
Alberto Garcia [Wed, 6 Feb 2008 16:41:14 +0000 (16:41 +0000)]
If, after moving or deleting a message from the message viewer, no
other message can be selected then close the viewer
Fixes NB#80276
pmo-trunk-r4143
Alberto Garcia [Wed, 6 Feb 2008 15:38:49 +0000 (15:38 +0000)]
Removed obsolete comments now that Modest works with maemo launcher
pmo-trunk-r4142
Vivek Sekar [Wed, 6 Feb 2008 15:30:41 +0000 (15:30 +0000)]
Added maemo-launcher-dev to the Build-Depends, since maemo-launcher has been enabled.
pmo-trunk-r4141
Jose Dapena Paz [Wed, 6 Feb 2008 13:29:10 +0000 (13:29 +0000)]
* src/maemo/modest-msg-view-window.c:
* Reviewed reference counting of tree row reference. There
were some cases we were leaking this (fixes NB#78857).
pmo-trunk-r4140
Dirk-Jan C. Binnema [Wed, 6 Feb 2008 07:44:43 +0000 (07:44 +0000)]
* include the domain name in the list of providers, so users can distinguish between "AOL (aol.com)" and "AOL (aol.fr)".
Fixes: NB#79501
pmo-trunk-r4139
Jose Dapena Paz [Tue, 5 Feb 2008 12:58:48 +0000 (12:58 +0000)]
* debian/rules:
* Reenable maemo launcher (fixes NB#79471).
* Also respect debug DEB_BUILD_OPTIONS parameter.
pmo-trunk-r4138
Jose Dapena Paz [Tue, 5 Feb 2008 12:57:03 +0000 (12:57 +0000)]
* src/modest-tny-account-store.c:
* Shutdown camel on finishing account store. This is done to
store the certdb on disk.
pmo-trunk-r4137
Dirk-Jan C. Binnema [Tue, 5 Feb 2008 08:20:42 +0000 (08:20 +0000)]
* if called at the wrong time, tny_send_queue_get_outbox may return NULL;
check for this, fixes a crash (NB#80225)
pmo-trunk-r4136
Dirk-Jan C. Binnema [Tue, 5 Feb 2008 07:50:41 +0000 (07:50 +0000)]
* fix some coverity warnings (bug NB#80246, the modest part)
pmo-trunk-r4135
Jose Dapena Paz [Mon, 4 Feb 2008 09:41:25 +0000 (09:41 +0000)]
* src/modest-text-utils.[ch]:
* Refactorized method to get the current selection of a label in
text utils. This will be now used in ui actions and dimming
rules.
* src/modest-ui-actions.c:
* (modest_ui_actions_on_copy): now copy gets the selection of
a focused label, instead of the full label (fixes NB#80195).
* (folder_move_to_cb): now we focus the new position of a folder
after a move to operation to avoid losing focus (fixes
NB#78939).
* src/modest-ui-dimming-rules.c:
* (..._on_add_to_contacts): now we use the text utils method
to retrieve current selection of a GtkLabel.
pmo-trunk-r4134
Philip Van Hoof [Sun, 3 Feb 2008 11:21:20 +0000 (11:21 +0000)]
Added tny_mime_part_set_transfer_encoding usage when forwarding
pmo-trunk-r4133
Philip Van Hoof [Sun, 3 Feb 2008 11:16:26 +0000 (11:16 +0000)]
Added tny_mime_part_set_transfer_encoding usage when forwarding
pmo-trunk-r4132
Dirk-Jan C. Binnema [Fri, 1 Feb 2008 20:16:56 +0000 (20:16 +0000)]
* in some weird cases, the msg-id and/or the 'item' might be NULL.
handle that case (fixes a crash, NB#80177)
pmo-trunk-r4131
Alberto Garcia [Fri, 1 Feb 2008 17:25:53 +0000 (17:25 +0000)]
Remove (harmless) GLIB CRITICAL
pmo-trunk-r4130
Vivek Sekar [Fri, 1 Feb 2008 13:03:35 +0000 (13:03 +0000)]
Added bugs fixed and functional requirements implemented for week 06 release.
pmo-trunk-r4128
Sergio Villar Senin [Fri, 1 Feb 2008 12:56:11 +0000 (12:56 +0000)]
* Fixes NB#79458, modest now properly connects when reading an uncached mail from the viewer while being offline
pmo-trunk-r4127
Vivek Sekar [Fri, 1 Feb 2008 12:46:35 +0000 (12:46 +0000)]
updated news
pmo-trunk-r4126
Alberto Garcia [Fri, 1 Feb 2008 11:50:28 +0000 (11:50 +0000)]
Dim "Reply to" commands when a message is in the outbox
Fixes NB#79904
pmo-trunk-r4125
Jose Dapena Paz [Fri, 1 Feb 2008 10:33:22 +0000 (10:33 +0000)]
* src/widgets/modest-folder-view.c:
* Now we properly set back the destination folder of a folder
move. It gets focused. Problem was an early memory free.
Partially fixes NB#78939.
pmo-trunk-r4124
Jose Dapena Paz [Fri, 1 Feb 2008 08:19:34 +0000 (08:19 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now we update properly the clipboard text on startup of edito
to catch previous state of selection clipboard (fixes
NB#79944).
pmo-trunk-r4123
Jose Dapena Paz [Thu, 31 Jan 2008 19:03:13 +0000 (19:03 +0000)]
This change will break temporally the wizard storage (was broken
anyway).
* src/modest-protocol-info.[ch]:
* Add method to retrieve the pair list of stores supported.
* src/gnome/modest-account-assistant.c:
* More work on HIG. Implemented new incoming server details.
pmo-trunk-r4122
Jose Dapena Paz [Thu, 31 Jan 2008 17:04:43 +0000 (17:04 +0000)]
* Added missing files in previous commit
pmo-trunk-r4121
Jose Dapena Paz [Thu, 31 Jan 2008 16:48:15 +0000 (16:48 +0000)]
* src/gnome/modest-account-view-window.c:
* Now it's a GtkDialog. Fits better with common and maemo code.
* Close button is now implemented as an action button of the
dialog.
* Added scrolled window to accounts tree view. It also provides
a border (better HIG compliance).
* Other layout changes to fit better HIG.
* Use translation strings from modest.po.
* src/gnome/modest-main-window-ui.h
* Add more maemo standard menu actions.
* src/gnome/modest-msg-edit-window.c:
* Some changes to improve HIG compliance.
* Scrolled window for message.
* Not it's gtkhtml based.
* It's a WIP, no menus working and a lot of issues not tested
yet. But it's a preliminar work for the future gnome editor.
* src/gnome/modest-platform.c:
* Now folder view does not get headers.
* src/gnome/modest-main-window.c:
* Added ui dimming rules support.
* Added menu option and shortcut for toggling folders view.
* Implemented style methods.
* Now default view for header view is compact view instead of
columns view.
* Set toolbar better to set important hint.
* Added translation domain for ui manager.
* src/gnome/modest-icon-names.h:
* Stock for split view.
* src/gnome/ui/modest-msg-view-window-ui.xml:
* More maemo menus also in modest.
* src/gnome/ui/modest-main-window-ui.xml:
* More maemo menus also in modest.
* src/gnome/modest-msg-view-window.c:
* Adaptation to common maemo actions.
* Changed layout to fit better with HIG.
* Support for ui dimming rules.
* Misc changes for fixing build.
* src/gnome/modest-account-assistant.c:
* WIP. Moving to HIG and adding missing functionality.
* Use maemo translation strings where it's ok.
* Fix some erros in GtkAssistant usage.
* src/modest-init.c:
* Now split view is common to gnome and maemo.
pmo-trunk-r4120
Sergio Villar Senin [Thu, 31 Jan 2008 13:03:13 +0000 (13:03 +0000)]
* Fixes NB#80090, fixed a crash when viewing messages with attachments
pmo-trunk-r4119
Jose Dapena Paz [Thu, 31 Jan 2008 09:52:01 +0000 (09:52 +0000)]
* src/modest-ui-dimming-rules.c:
* Fix the way we obtain the selection from a label in
..._add_to_contacts rule. This was causing crashes in some
utf8 strings (fixes NB#80084).
pmo-trunk-r4118
Jose Dapena Paz [Wed, 30 Jan 2008 19:36:27 +0000 (19:36 +0000)]
* src/modest-tny-local-folders-account.[ch]:
* New method to obtain the outboxes folder.
* src/dbus_api/modest-dbus-callbacks.c:
* Now find message shows an information banner as a feedback
for opening the message (fixes NB#78695).
* Now find message works again for messages in outbox.
pmo-trunk-r4117
Sergio Villar Senin [Wed, 30 Jan 2008 18:59:54 +0000 (18:59 +0000)]
* Fixed the empty header list view problem when removing the last message of a folder
pmo-trunk-r4116
Alberto Garcia [Wed, 30 Jan 2008 17:32:33 +0000 (17:32 +0000)]
Fixed several TnyIterator leaks
pmo-trunk-r4115
Vivek Sekar [Wed, 30 Jan 2008 15:08:20 +0000 (15:08 +0000)]
changed from user/extras to user/Communication, maemo bug NB#2790
pmo-trunk-r4114
Dirk-Jan C. Binnema [Wed, 30 Jan 2008 13:12:24 +0000 (13:12 +0000)]
* add initializer, to make coverity happy
pmo-trunk-r4113
Alberto Garcia [Wed, 30 Jan 2008 12:15:46 +0000 (12:15 +0000)]
Fix wrong usage of g_object_unref() in
modest_mail_operation_xfer_msgs() and transfer_msgs_cb()
pmo-trunk-r4112
Sergio Villar Senin [Wed, 30 Jan 2008 11:43:48 +0000 (11:43 +0000)]
* Fixes NB#80070 do not allow to move a message in the viewer that has been sent, fixes a crash as well
pmo-trunk-r4111
Alberto Garcia [Wed, 30 Jan 2008 11:18:23 +0000 (11:18 +0000)]
If transferring messages between different accounts, move them one by
one so that the operation can be cancelled by the user.
Partially fixes NB#78460
pmo-trunk-r4110
Vivek Sekar [Wed, 30 Jan 2008 11:02:39 +0000 (11:02 +0000)]
Added all the functional requirement IDs, that are shipped currently. ALL
pmo-trunk-r4109
Jose Dapena Paz [Wed, 30 Jan 2008 10:45:36 +0000 (10:45 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now we only correct scroll from scroll vadj signal if this is
really modified. This way we don't change scroll on clicking
the attachment and addressbook buttons. Fixes NB#79951.
pmo-trunk-r4108
Sergio Villar Senin [Wed, 30 Jan 2008 08:56:42 +0000 (08:56 +0000)]
* Added a missing error handling code
pmo-trunk-r4107
Sergio Villar Senin [Tue, 29 Jan 2008 19:16:04 +0000 (19:16 +0000)]
* Fixes NB#79620, error while saving multiple attachments
pmo-trunk-r4106
Alberto Garcia [Tue, 29 Jan 2008 17:40:49 +0000 (17:40 +0000)]
Don't pass the header_list in GetMsgInfo, it's not needed
anymore (with Tinymail r3313)
pmo-trunk-r4105
Alberto Garcia [Tue, 29 Jan 2008 17:31:55 +0000 (17:31 +0000)]
Fixed a leak in modest_mail_operation_get_msgs_full()
pmo-trunk-r4104
Sergio Villar Senin [Tue, 29 Jan 2008 17:03:10 +0000 (17:03 +0000)]
* Fixes NB60606, "Device memory full" information note is now shown when there is no space left on device. Requires tinymail >= 3314
pmo-trunk-r4103
Jose Dapena Paz [Tue, 29 Jan 2008 13:39:42 +0000 (13:39 +0000)]
* src/maemo/modest-address-book.c:
* (add_to_address_book): now it supports receiving a full
address (form User <email@address>). If it gets it, it
searches in contacts for only email@address. If it's not
found, then it stores a contact with full name User and
email address email@address. Fixes NB#79467.
pmo-trunk-r4102
Alberto Garcia [Tue, 29 Jan 2008 11:12:53 +0000 (11:12 +0000)]
In modest_mail_operation_get_msgs_full(), don't retrieve a new message
until the previous one has been retrieved. Also, finish the mail
operation immediately if the user cancels it during its retrieval.
pmo-trunk-r4101
Philip Van Hoof [Mon, 28 Jan 2008 22:23:16 +0000 (22:23 +0000)]
Adapted to API change for Tinymail rev 3304
pmo-trunk-r4100
Sergio Villar Senin [Mon, 28 Jan 2008 16:23:57 +0000 (16:23 +0000)]
* Fixes 79701, we're not forcing the connection after clicking on send&receive
pmo-trunk-r4099
Sergio Villar Senin [Mon, 28 Jan 2008 12:33:51 +0000 (12:33 +0000)]
* Prevents the Expunged messages from appear
pmo-trunk-r4098
Sergio Villar Senin [Mon, 28 Jan 2008 12:06:15 +0000 (12:06 +0000)]
* Do not try to select the first account if there is none
* Probably helps with NB#78684
pmo-trunk-r4097
Sergio Villar Senin [Mon, 28 Jan 2008 11:47:03 +0000 (11:47 +0000)]
* Fixes NB#79905, show the proper message when the msg is not available on server
pmo-trunk-r4096
Jose Dapena Paz [Mon, 28 Jan 2008 10:58:26 +0000 (10:58 +0000)]
* src/maemo/modest-msg-edit-window.c, src/modest-utils.c:
* Use properly GnomeVFSFileInfo (constructing and unreferencing
it).
pmo-trunk-r4095
Sergio Villar Senin [Mon, 28 Jan 2008 09:58:23 +0000 (09:58 +0000)]
* Replaced the "+" toolbar icon with the "New message" icon
* Replaced behaviour of "+" icon, now it only creates new messages
pmo-trunk-r4094
Sergio Villar Senin [Mon, 28 Jan 2008 08:56:02 +0000 (08:56 +0000)]
* Removed ModestGnomeInfoBar and ModestProgressBarWidget
* Replaced by a common ModestProgressBar
* Added progress information to GNOME client
* Fixed API change in tinymail
pmo-trunk-r4093
Dirk-Jan C. Binnema [Fri, 25 Jan 2008 16:56:05 +0000 (16:56 +0000)]
* fix small logic error
pmo-trunk-r4092
Vivek Sekar [Fri, 25 Jan 2008 08:59:34 +0000 (08:59 +0000)]
Added fixes for week 05 release.
pmo-trunk-r4089
Sergio Villar Senin [Thu, 24 Jan 2008 18:27:49 +0000 (18:27 +0000)]
* Fixed the Modest compilation in GNOME
* Added progress bar to Modest GNOME
pmo-trunk-r4088
Sergio Villar Senin [Thu, 24 Jan 2008 17:34:57 +0000 (17:34 +0000)]
* Removed duplicated entry
pmo-trunk-r4087
Dirk-Jan C. Binnema [Thu, 24 Jan 2008 16:38:13 +0000 (16:38 +0000)]
* updated NEWS
pmo-trunk-r4086
Jose Dapena Paz [Thu, 24 Jan 2008 13:17:09 +0000 (13:17 +0000)]
* src/widgets/modest-folder-view.c:
* Encapsulate the tny_folder_sync operation we do in finalize
in a mail operation. This way this can be async, but protected
by a mail operation.
* src/modest-mail-operation.[ch]:
* New mail operation that wraps a tny_folder_sync_async
operation.
pmo-trunk-r4085
Sergio Villar Senin [Thu, 24 Jan 2008 13:10:05 +0000 (13:10 +0000)]
* Fixes NB#79715, signature is not used if disabled in the Accounts dialog
* Replaced the "Saved to drafts" banner by "Saving" banner when saving drafts
pmo-trunk-r4084
Jose Dapena Paz [Thu, 24 Jan 2008 10:16:12 +0000 (10:16 +0000)]
These changes fix bug NB#78736.
* src/modest-mail-operation.[ch]:
* New mail operation run_queue. This mail operation runs when
the send queue is looping through messages. This is used to
warrant that we don't kill modest while we're sending
messages, in a safer way (we were trying to detect the mail
send attempt result, and it was not warranted to happen).
* Remove all the code to process sent and error signals in
send queue to finish send mail operations.
* Now both update_account and send_mail operations notify end
after setting up the send queue, not after knowing the send
queue has sent the message. This way we rely now on the
autoconfigured mail operation that lives with the send queue
runnings.
* src/modest-tny-send-queue.c:
* Now we hook on queue-start signal. This is for creating a mail
operation that lives while we're trying to send messages.
pmo-trunk-r4083
Alberto Garcia [Wed, 23 Jan 2008 15:31:44 +0000 (15:31 +0000)]
Don't refilter the model everytime the msg count changes,
or the UI will freeze completely in big folders
pmo-trunk-r4082
Sergio Villar Senin [Wed, 23 Jan 2008 12:41:52 +0000 (12:41 +0000)]
* Removed modest_tny_send_queue_add, replaced with tny_send_queue_add_async
* Fixed a crash when sending errors, NOTE: this is a workaround in Modest but must be fixed in tinymail
pmo-trunk-r4081
Sergio Villar Senin [Wed, 23 Jan 2008 08:48:14 +0000 (08:48 +0000)]
* Fixes some "Expunged" a strike-through message issues
pmo-trunk-r4080
Jose Dapena Paz [Wed, 23 Jan 2008 00:04:36 +0000 (00:04 +0000)]
* src/widgets/modest-msg-edit-window.h:
* Added methods for getting estimation of parts size in message.
* src/modest-window-mgr.c:
* If save to drafts fails because of disk being full, then
we don't close the editor window.
* src/widgets/modest-attachment-view.[ch]:
* Added methods to set the size externally, and be able to avoid
counting the size going through the full stream.
* src/widgets/modest-window.c:
* Close from escape shortcut only on view window, not only on
edit window. This was really not working properly, as press
was processed and release was processed after the dialog, if
more than one second was spent, then the press was considered
a force close.
* src/widgets/modest-attachments-view.[ch]:
* Added methods to get the size of attachments inside.
* src/modest-tny-msg.[ch]:
* Added method to estimate the storage size of a message, using
simply the size of the attachments and the body parts.
* src/modest-ui-actions.[ch]:
* On saving to drafts or sending new mails, we estimate the size
the message will have on device disk. If it's too big, we
cancel the save operation, and show a banner (fixes NB#77528).
* src/maemo/modest-msg-edit-window.c:
* Methods to estimate file size of attachments added (using vfs)
and the full message space (offering size of attachmetns and
images).
* src/modest-utils.c:
* New method to get the available space on device disk.
* src/modest-mail-operation.c:
* If there's an error in create msg, notify operation failed.
pmo-trunk-r4079
Alberto Garcia [Tue, 22 Jan 2008 19:11:39 +0000 (19:11 +0000)]
Refactored modest_platform_on_new_headers_received().
New function modest_platform_push_email_notification().
This removes a critical warning and makes notifications work
again from on_msg_count_changed()
pmo-trunk-r4078
Sergio Villar Senin [Tue, 22 Jan 2008 19:01:02 +0000 (19:01 +0000)]
* Fixes NB#79488, user folders are now always located under the special Archive folder
pmo-trunk-r4077
Sergio Villar Senin [Tue, 22 Jan 2008 17:51:30 +0000 (17:51 +0000)]
* Migrated Modest to the new send queue API
* Cancelling messages now sets the status of the messages to Suspended instead of Failed
* Fixes NB#75801, Modest properly cancels sends
* Fixes NB#79456, Modest no longer crashes when doing S&R in the background
* Modest restarts now the suspended messages in the Outbox when clicking s&r
* Modest restarts now the suspended messages when starting the program
* The dimming rules are properly updated when the status of a message in the Outbox changes
* The modest send queue now stores references to the sent and outbox folders
* Modest waits until all the messages have been sent (or fail) when doing s&r
pmo-trunk-r4076
Alberto Garcia [Tue, 22 Jan 2008 17:33:19 +0000 (17:33 +0000)]
When editing and sending an e-mail in failed state, use the original
transport account (before any modifications) to get the Outbox. This
is needed to remove the original e-mail correctly.
Fixed NB#79363
pmo-trunk-r4075
Alberto Garcia [Tue, 22 Jan 2008 11:49:17 +0000 (11:49 +0000)]
Allow creation of folders in the remote root (for non-POP3 accounts)
from the "Move to" dialog
Fixes NB#79562
pmo-trunk-r4074