modest
16 years ago* Changes in the localization structure. GETTEXT package is
Javier Fernandez Garcia-Boente [Wed, 20 Jun 2007 06:47:03 +0000 (06:47 +0000)]
* Changes in the localization structure. GETTEXT package is
configure in configure.ac, checking version of application
in order to use trnaslation packages or .po files.

* Avoid using GTK_WIDGET_HAS_FOCUS to check if some widget has
the focus, because we need to check window local focus, rather
than global focus.

pmo-trunk-r2321

16 years ago2007-06-19 Murray Cumming,,, <murrayc@murrayc-desktop>
Murray Cumming [Tue, 19 Jun 2007 17:16:26 +0000 (17:16 +0000)]
2007-06-19  Murray Cumming,,,  <murrayc@murrayc-desktop>

* libmodest-dbus-client/libmodest-dbus-client.c:
        (_dbus_iter_get_string_or_null): Initialize the string variable in
        case this helps with Dirk's crash.

2007-06-19  Murray Cumming  <murrayc@murrayc.com>

        * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
        though it is not implemented yet (this function is maybe not even used),
        to avoid breaking ABI in future.
        * libmodest-dbus-client/libmodest-dbus-client.c:
        (get_attachments_string): Moved some code into this generic function.
        (libmodest_dbus_client_send_mail): Corrected the documentation. This really
        sends email. It is maybe not used.
        * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
        (on_send_mail): Use attachments.

        * src/widgets/modest-msg-edit-window.h: Improve the documentation.
        * src/maemo/modest-msg-edit-window.c:
        (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
        a filename before using it, to fix projects.maemo.org bug NB#58233.

pmo-trunk-r2319

16 years agoFix for some issues in translation of plural strings (fixes NB#61146).
Jose Dapena Paz [Tue, 19 Jun 2007 16:36:53 +0000 (16:36 +0000)]
Fix for some issues in translation of plural strings (fixes NB#61146).
* src/modest-ui-actions.c:
* src/modest-msg-edit-window.c:
        * Changed translations of plurals to use ngettext.

pmo-trunk-r2318

16 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Tue, 19 Jun 2007 15:20:50 +0000 (15:20 +0000)]
* src/maemo/modest-platform.c:
        * (modest_platform_show_uri_popup): now it uses the translation
          domain of the actions (fixes NB#61049).

pmo-trunk-r2316

16 years agoUpdated the changelog with the fixes made on 2007.06.19.
Dirk-Jan C. Binnema [Tue, 19 Jun 2007 15:20:13 +0000 (15:20 +0000)]
Updated the changelog with the fixes made on 2007.06.19.

pmo-trunk-r2314

16 years agoWork to fix priority recovering from messages (fixes NB#58045).
Jose Dapena Paz [Tue, 19 Jun 2007 14:58:06 +0000 (14:58 +0000)]
Work to fix priority recovering from messages (fixes NB#58045).
* src/maemo/modest-msg-edit-window.c:
        * Now it gets the priority flags from the message it's
          constructed from.
        * Updates the priority in menus with the initial values.

Other changes
* src/maemo/modest-msg-edit-window.c:
        * Minor translation fix.

pmo-trunk-r2313

16 years ago * Allow incremental filling of the headers view while refreshing the folder
Sergio Villar Senin [Tue, 19 Jun 2007 14:13:09 +0000 (14:13 +0000)]
* Allow incremental filling of the headers view while refreshing the folder

pmo-trunk-r2312

16 years agoslightly improved debug messages
Murray Cumming [Tue, 19 Jun 2007 13:53:16 +0000 (13:53 +0000)]
slightly improved debug messages

pmo-trunk-r2311

16 years agoImproved debug message
Murray Cumming [Tue, 19 Jun 2007 13:10:55 +0000 (13:10 +0000)]
Improved debug message

pmo-trunk-r2310

16 years ago * Fixed a memory corruption problem while initializing threads
Sergio Villar Senin [Tue, 19 Jun 2007 11:50:54 +0000 (11:50 +0000)]
* Fixed a memory corruption problem while initializing threads
* Added a poke_status call whenever we update an account with the send&receive button

pmo-trunk-r2309

16 years agoFirst-time quickfix
Philip Van Hoof [Tue, 19 Jun 2007 11:31:46 +0000 (11:31 +0000)]
First-time quickfix

pmo-trunk-r2308

16 years ago2007-06-19 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 19 Jun 2007 11:06:41 +0000 (11:06 +0000)]
2007-06-19  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.c: (modest_ui_actions_on_copy):
        Initialize the continue_download variable to fix the build, and probably
        to fix randome behaviour.

pmo-trunk-r2307

16 years ago * Fixes NB#60735, ask for confirmation when copying mails from a POP account
Sergio Villar Senin [Tue, 19 Jun 2007 09:52:35 +0000 (09:52 +0000)]
* Fixes NB#60735, ask for confirmation when copying mails from a POP account

pmo-trunk-r2306

16 years ago * Fixes NB#57632, the delete option is dimmed for folders
Sergio Villar Senin [Tue, 19 Jun 2007 08:56:46 +0000 (08:56 +0000)]
* Fixes NB#57632, the delete option is dimmed for folders

pmo-trunk-r2305

16 years agoFix dimming rules for add to contacts action (fixes NB#59174).
Jose Dapena Paz [Tue, 19 Jun 2007 08:25:35 +0000 (08:25 +0000)]
Fix dimming rules for add to contacts action (fixes NB#59174).
* src/modest-ui-dimming-rules.[ch]:
        * Added dimming rule for add to contacts.
* src/maemo/modest-msg-view-window.c:
        * Added new dimming rule for add to contacts action.

pmo-trunk-r2304

16 years ago* leak fixes; free both list and its elements when we call modest_account_mgr_account...
Dirk-Jan C. Binnema [Tue, 19 Jun 2007 08:16:56 +0000 (08:16 +0000)]
* leak fixes; free both list and its elements when we call modest_account_mgr_account_names
* use the new function modest_account_mgr_free_account_names
* some other smaller leak fixes

pmo-trunk-r2303

16 years ago* temporary crash fix for modest-tny-send-queue
Dirk-Jan C. Binnema [Tue, 19 Jun 2007 07:47:50 +0000 (07:47 +0000)]
* temporary crash fix for modest-tny-send-queue

pmo-trunk-r2302

16 years agoSmall bugfix
Philip Van Hoof [Tue, 19 Jun 2007 07:44:42 +0000 (07:44 +0000)]
Small bugfix

pmo-trunk-r2301

16 years agoQuestion and small bugfix
Philip Van Hoof [Tue, 19 Jun 2007 07:43:02 +0000 (07:43 +0000)]
Question and small bugfix

pmo-trunk-r2300

16 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Tue, 19 Jun 2007 07:37:44 +0000 (07:37 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Modified to use the save objects dialog (fixes NB#59057).

pmo-trunk-r2299

16 years agoError handling for the send queues
Philip Van Hoof [Tue, 19 Jun 2007 07:34:18 +0000 (07:34 +0000)]
Error handling for the send queues

pmo-trunk-r2298

16 years ago * Fixed several reference count leaks in the dimming rules
Sergio Villar Senin [Tue, 19 Jun 2007 06:47:22 +0000 (06:47 +0000)]
* Fixed several reference count leaks in the dimming rules
* Fixed several reference count leaks in the folder view
* Added a dispose method to the header view to prevent cycles when unrefs
* Commented some debug code
* Removed an initialization that could cause the blank right paned issue

pmo-trunk-r2297

16 years ago2007-06-18 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 18 Jun 2007 20:52:22 +0000 (20:52 +0000)]
2007-06-18  Armin Burgmeier  <armin@openismus.com>

* src/modest-tny-send-queue.h:
* src/modest-tny-send-queue.c: Keep track of the status of messages in
the queue so we can later show it in the UI. Replaced
modest_tny_send_queue_msg_is_being_sent() by
modest_tny_send_queue_get_msg_status().

* src/modest-ui-dimming-rules.c: Adjust for the replaced function.

* src/modest-tny-account.c: Changed a cast to gpointer* to one to
gpointer. This probably was not harmful, but just to be sure.

pmo-trunk-r2296

16 years agoWork to fix recovering sort status in headers view (fixes NB#58250).
Jose Dapena Paz [Mon, 18 Jun 2007 16:13:14 +0000 (16:13 +0000)]
Work to fix recovering sort status in headers view (fixes NB#58250).
* src/maemo/modest-platform.c:
        * Now it retrieves the current header view sort column,
          sort type, and in case of sorting flags, the flag we sort.
          This way, the dialog is prefilled with the current header
          view status.
* src/modest-widget-memory-priv.h:
        * Added the new kind of key "column-sort", that specified the
          model column used to sort in header view.
* src/modest-widget-memory.c:
        * Now save_settings_header_view and restore_settings_header_view
          store a global sort value. This is required for recovering the
          sort status in the compact view.

Other fixes:
* src/modest-ui-dimming-rules.c:
        * Condition for one or more attachments was wrong.

pmo-trunk-r2292

16 years ago* Fixed several logical id transations.
Javier Fernandez Garcia-Boente [Mon, 18 Jun 2007 15:25:42 +0000 (15:25 +0000)]
* Fixed several logical id transations.
* Fixes: NB#60765, NB#60768, NB#60770, NB#60771, NB#60774, NB#60774
* Fixes: NB#60775, NB#60776, NB#60777, NB#60954, NB#60952, NB#60953
* Fixes: NB#60964, NB#60968

pmo-trunk-r2289

16 years ago* hopefully, this restores the bora-build
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 15:24:48 +0000 (15:24 +0000)]
* hopefully, this restores the bora-build

pmo-trunk-r2288

16 years agoupdated the changelog, removed all the old bugs from the list
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 14:53:59 +0000 (14:53 +0000)]
updated the changelog, removed all the old bugs from the list

pmo-trunk-r2287

16 years ago2007-06-18 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 18 Jun 2007 14:41:16 +0000 (14:41 +0000)]
2007-06-18  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-platform.c: (modest_platform_activate_uri):
        Fix the build, but leave the function broken on Bora, because
        hildon_uri_action_get_service() does not exist.
        osso_uri_action_get_service() does not exist either, it seems.

pmo-trunk-r2286

16 years agoupdated the changelog, removed some released bugs from the list
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 13:53:28 +0000 (13:53 +0000)]
updated the changelog, removed some released bugs from the list

pmo-trunk-r2285

16 years agoupdated the changelog, removed some released bugs from the list
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 13:52:50 +0000 (13:52 +0000)]
updated the changelog, removed some released bugs from the list

pmo-trunk-r2284

16 years agoFixed som compilation errors.
Javier Fernandez Garcia-Boente [Mon, 18 Jun 2007 13:36:53 +0000 (13:36 +0000)]
Fixed som compilation errors.

pmo-trunk-r2283

16 years ago* fix logical id, NB#60950
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 13:21:47 +0000 (13:21 +0000)]
* fix logical id, NB#60950

pmo-trunk-r2282

16 years ago* Add a new singleton to be used as headers clipboard
Javier Fernandez Garcia-Boente [Mon, 18 Jun 2007 13:13:55 +0000 (13:13 +0000)]
* Add a new singleton to be used as headers clipboard
on copy, cut and paste operaitons.

* Implement copy, cut and paste operations for both, headers
and folders view.

* Fixes: NB##58174

pmo-trunk-r2280

16 years ago* fix the uri activation, bug NB#58220
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 12:32:32 +0000 (12:32 +0000)]
* fix the uri activation, bug NB#58220

pmo-trunk-r2278

16 years ago* src/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 18 Jun 2007 11:56:21 +0000 (11:56 +0000)]
* src/modest-msg-edit-window.c:
        * Added autocap for subject field (fixes NB#57932).

pmo-trunk-r2277

16 years ago* some more crash-avoiding
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 11:50:42 +0000 (11:50 +0000)]
* some more crash-avoiding

pmo-trunk-r2276

16 years ago* check some parameters (give BUG: warnings instead of crashing)
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 11:41:40 +0000 (11:41 +0000)]
* check some parameters (give BUG: warnings instead of crashing)

pmo-trunk-r2275

16 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Mon, 18 Jun 2007 11:15:00 +0000 (11:15 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Added menu action for find in page (fixes NB#57201).

pmo-trunk-r2274

16 years ago* src/widgets/modest-window-mgr.c:
Jose Dapena Paz [Mon, 18 Jun 2007 10:44:32 +0000 (10:44 +0000)]
* src/widgets/modest-window-mgr.c:
        * Now it does not crash if we cannot get an uid from one of the
          windows (should happen at least with main window, but also
          with editors) (fixes NB#60430).

pmo-trunk-r2273

16 years agoWork to fix bugs getting the From: field in the editor for new messages
Jose Dapena Paz [Mon, 18 Jun 2007 10:12:11 +0000 (10:12 +0000)]
Work to fix bugs getting the From: field in the editor for new messages
and messages opened in drafts folder (fixes NB#58214, NB#58219):
* src/modest-ui-actions.c:
        * Now "New message" and "open message from drafts" fill the from
          field in the editor with the default account instead of the
          current folder active account.
* src/maemo/modest-msg-edit-window.c:
        * Fills the From: field with the account name passed in the
          constructor.

pmo-trunk-r2272

16 years ago2007-06-18 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 18 Jun 2007 10:10:59 +0000 (10:10 +0000)]
2007-06-18  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account.c:
        (modest_tny_account_new_from_server_account):
        Uncommented the url debug output again, because it is useful for
        debugging, as I said in the comment.

pmo-trunk-r2271

16 years ago2007-06-18 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 18 Jun 2007 09:00:27 +0000 (09:00 +0000)]
2007-06-18  Murray Cumming  <murrayc@murrayc.com>

* configure.ac: Do not require hildon-notify for Maemo Bora. It is not
        available.
        * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
        for Mameo Bora, to fix the build.

pmo-trunk-r2270

16 years ago * Updated the changelog with fixes made till 2007.06.18 10:45am
Dirk-Jan C. Binnema [Mon, 18 Jun 2007 07:47:04 +0000 (07:47 +0000)]
  * Updated the changelog with fixes made till 2007.06.18 10:45am

pmo-trunk-r2269

16 years ago2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Sun, 17 Jun 2007 21:15:36 +0000 (21:15 +0000)]
2007-06-17  Johannes Schmid <johannes.schmid@openismus.com>

* configure.ac:
Fixed build with hildon < 0.99

* src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
Check if the selected account is busy instead of checking all accounts

* src/modest-account-mgr-priv.h:
* src/modest-account-mgr.c: (modest_account_mgr_class_init),
(modest_account_mgr_init), (compare_account_name),
(modest_account_mgr_set_account_busy),
(modest_account_mgr_account_is_busy):
* src/modest-account-mgr.h:
Added busy information to the account manager. It possible to
set an account to busy or not busy now.

* src/modest-mail-operation.c: (modest_mail_operation_finalize),
(modest_mail_operation_update_account),
(modest_mail_operation_notify_end):
Set the account to busy/not busy depending on the operation state.

* src/widgets/modest-account-view.c:
(modest_account_view_finalize), (get_last_updated_string),
(update_account_view), (on_account_busy_changed), (init_view):
Show string \"Refreshing...\" if the account is currently busy.

All this fixes projects.maemo.org bug NB#59711

pmo-trunk-r2268

16 years ago* make modest work on pre-OSSO 1.1 once more (don't require the notification stuff)
Dirk-Jan C. Binnema [Sat, 16 Jun 2007 14:45:49 +0000 (14:45 +0000)]
* make modest work on pre-OSSO 1.1 once more (don't require the notification stuff)

pmo-trunk-r2267

16 years ago* src/maemo/modest-icon-names.h:
Jose Dapena Paz [Fri, 15 Jun 2007 17:19:26 +0000 (17:19 +0000)]
* src/maemo/modest-icon-names.h:
        * Added macros for bold and italic toolbar icons.
* src/widgets/modest-msg-edit-window-ui.h:
        * Use the maemo bold and italic icons (fixes NB#58612).

pmo-trunk-r2266

16 years ago* src/widgets/modest-mail-header-view.c:
Jose Dapena Paz [Fri, 15 Jun 2007 17:03:42 +0000 (17:03 +0000)]
* src/widgets/modest-mail-header-view.c:
        * If subject is empty string it shows "No subject" string
          (fixes NB#58610).

pmo-trunk-r2265

16 years ago* src/modest-text-utils.c:
Jose Dapena Paz [Fri, 15 Jun 2007 16:27:25 +0000 (16:27 +0000)]
* src/modest-text-utils.c:
        * Fixed the signature inclusion in _cite. This way, the
          signature adds an empty line before it in editor.
        * Now forward uses the same code reply uses for
          formatting messages, this fixes some issues
          (fixes NB#58430).

pmo-trunk-r2264

16 years ago* small improvements in the progress bar widget
Dirk-Jan C. Binnema [Fri, 15 Jun 2007 16:25:24 +0000 (16:25 +0000)]
* small improvements in the progress bar widget

pmo-trunk-r2263

16 years ago* src/widgets/modest-attachment-view.c:
Jose Dapena Paz [Fri, 15 Jun 2007 15:46:17 +0000 (15:46 +0000)]
* src/widgets/modest-attachment-view.c:
        * Set better the event box initialisation.
* src/widgets/modest-attachments-view.c:
        * Not it uses internally the absolute position of the events and
          specific attachment views. This finally fixes a hard bug.
          (fixes NB#58394).
* src/maemo/modest-addressbook.c:
        * Uses the synchronous call to open the address book on
          selecting addresses.

pmo-trunk-r2262

16 years agoUpdated the changelog with fixes made on 2007.06.15.
Dirk-Jan C. Binnema [Fri, 15 Jun 2007 14:59:01 +0000 (14:59 +0000)]
Updated the changelog with fixes made on 2007.06.15.

pmo-trunk-r2261

16 years ago* temp fix to prevent crashing while doing wild folder changing / cancelling actions
Dirk-Jan C. Binnema [Fri, 15 Jun 2007 14:26:03 +0000 (14:26 +0000)]
* temp fix to prevent crashing while doing wild folder changing / cancelling actions

pmo-trunk-r2260

16 years ago * Fixes NB#59717 that was reopened
Sergio Villar Senin [Fri, 15 Jun 2007 13:00:46 +0000 (13:00 +0000)]
* Fixes NB#59717 that was reopened
* Added modest_main_window_get_contents_style
* Fixed a problem with the empty view when moving messages to an empty folder

pmo-trunk-r2259

16 years agoSmall compilation warning fix
Philip Van Hoof [Fri, 15 Jun 2007 12:52:28 +0000 (12:52 +0000)]
Small compilation warning fix

pmo-trunk-r2258

16 years agoSmall compilation warning fix
Philip Van Hoof [Fri, 15 Jun 2007 12:50:10 +0000 (12:50 +0000)]
Small compilation warning fix

pmo-trunk-r2257

16 years agoSmall compilation warning fix
Philip Van Hoof [Fri, 15 Jun 2007 12:47:11 +0000 (12:47 +0000)]
Small compilation warning fix

pmo-trunk-r2256

16 years agoSmall compilation warning fix
Philip Van Hoof [Fri, 15 Jun 2007 12:44:43 +0000 (12:44 +0000)]
Small compilation warning fix

pmo-trunk-r2255

16 years ago* add "Copy" to the CSM; might fix NB#58246, but needs discussion with the UI designer
Dirk-Jan C. Binnema [Fri, 15 Jun 2007 12:35:17 +0000 (12:35 +0000)]
* add "Copy" to the CSM; might fix NB#58246, but needs discussion with the UI designer

pmo-trunk-r2254

16 years ago * Fixed some wrong dimming rules names
Sergio Villar Senin [Fri, 15 Jun 2007 12:13:11 +0000 (12:13 +0000)]
* Fixed some wrong dimming rules names
* Fixes NB#60205 Modest no longer crashes when transfering the last msg of a folder from the view window
* Removed an invalid assertion
* Fixed some memory leaks

pmo-trunk-r2253

16 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Fri, 15 Jun 2007 10:23:28 +0000 (10:23 +0000)]
* src/modest-text-utils.[ch]:
        * (modest_text_utils_get_subject_prefix_len): added some strings
          to the subject filter.
* src/widgets/modest-header-view.c:
        * Added (cmp_subject_rows), that compares the subjects filtering
          the Re:, Fwd:, etc.
        * Now it uses the new cmp_subject_rows function to sort the
          headers with subject field.

pmo-trunk-r2252

16 years ago * Expunge the draft messages when removed. Fixes NB#60398
Sergio Villar Senin [Fri, 15 Jun 2007 09:08:06 +0000 (09:08 +0000)]
* Expunge the draft messages when removed. Fixes NB#60398

pmo-trunk-r2251

16 years ago * Fixes NB#59396, the OUTBOX folder icon is now shown properly
Sergio Villar Senin [Fri, 15 Jun 2007 08:30:37 +0000 (08:30 +0000)]
* Fixes NB#59396, the OUTBOX folder icon is now shown properly
* Changed the folder type detection in the folder rules

pmo-trunk-r2249

16 years ago * Fixes NB#59030, fixed the items of the Reply CSM
Sergio Villar Senin [Fri, 15 Jun 2007 08:10:54 +0000 (08:10 +0000)]
* Fixes NB#59030, fixed the items of the Reply CSM

pmo-trunk-r2248

16 years ago * Fixes NB#58331, INBOX must not be moveable
Sergio Villar Senin [Fri, 15 Jun 2007 07:57:31 +0000 (07:57 +0000)]
* Fixes NB#58331, INBOX must not be moveable
* Added an pvanhoof's speedup enhancenment when marking headers as read/unread
* Added folder rules for the inbox folder
* Unregistered a signal handler in the folder view when finalized

pmo-trunk-r2247

16 years ago * Removed my own error handler that I use for debugging
Sergio Villar Senin [Fri, 15 Jun 2007 06:43:11 +0000 (06:43 +0000)]
* Removed my own error handler that I use for debugging

pmo-trunk-r2244

16 years ago2007-06-14 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 14 Jun 2007 21:39:11 +0000 (21:39 +0000)]
2007-06-14  Armin Burgmeier  <armin@openismus.com>

* src/widgets/modest-attachments-view.h:
* src/widgets/modest-attachments-view.c: Added
modest_attachments_view_has_attachments() and fixed coordinate
transformation in get_att_view_at_coords(). This fixes attachment
selection.

* src/widgets/modest-msg-view.c: Make use of
modest_attachments_view_has_attachments() to decide whether to show
attachments in the header.

pmo-trunk-r2243

16 years ago2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Thu, 14 Jun 2007 17:22:18 +0000 (17:22 +0000)]
2007-06-14  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/modest-connection-specific-smtp-edit-window.c:
(on_change), (on_combo_security_changed),
(modest_connection_specific_smtp_edit_window_init),
(modest_connection_specific_smtp_edit_window_set_connection),
(modest_connection_specific_smtp_edit_window_is_dirty):
* src/maemo/modest-connection-specific-smtp-edit-window.h:
* src/maemo/modest-connection-specific-smtp-window.c:
(on_button_edit):

Show an comfirmation dialog for the smpt-edit-window if there are
unsaved changes and the user hits cancel.
(projects.maemo.org but NB#60479

pmo-trunk-r2242

16 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Thu, 14 Jun 2007 16:44:47 +0000 (16:44 +0000)]
* src/modest-text-utils.[ch]:
        * Reworked the quote code to add attachmetns list.
          This should make attachments be shown on replying
          messages (fixes NB#58194).
        * Reworked the quote methods, to be more compliant
          to specs.
* src/modest-tny-msg.c, src/modest-formatter.[ch]:
        * Proper changes to pass the attachments list to the
          code that creates the quoted messages. It's used
          for showing the attachments names in replies including
          the original message.

pmo-trunk-r2241

16 years ago* add the time to the details; fixes NB#58620
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 16:07:35 +0000 (16:07 +0000)]
* add the time to the details; fixes NB#58620

pmo-trunk-r2240

16 years ago2007-06-14 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 14 Jun 2007 15:42:19 +0000 (15:42 +0000)]
2007-06-14  Armin Burgmeier  <armin@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c: Show "invalid email
address" info in banner instead of node, and select all the text as
per UI spec. This fixes projects.maemo.org bug NB#60550.

pmo-trunk-r2239

16 years ago* src/modest-text-utils.c:
Jose Dapena Paz [Thu, 14 Jun 2007 15:14:07 +0000 (15:14 +0000)]
* src/modest-text-utils.c:
        * (modest_text_utils_cite): cite shouldn't include
          replied message body, only signature (fixes NB#58185).

pmo-trunk-r2238

16 years ago* fix a refcounting issue if account_id is NULL when trying to get the local_folder_type
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 15:10:28 +0000 (15:10 +0000)]
* fix a refcounting issue if account_id is NULL when trying to get the local_folder_type
* changed the folder rules; drafts cannot receive from drag&drop

pmo-trunk-r2237

16 years ago* set FolderName(<all>) for Outbox, Drafts,FolderName (<unread>) for the others
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 15:08:35 +0000 (15:08 +0000)]
* set FolderName(<all>) for Outbox, Drafts,FolderName (<unread>) for the others
* get the type thing correctly
* depends on a tinymail fix too

pmo-trunk-r2236

16 years ago * Added modest_platform_create_folder_view
Sergio Villar Senin [Thu, 14 Jun 2007 14:52:59 +0000 (14:52 +0000)]
* Added modest_platform_create_folder_view
* Fixes NB#59468, the move to folder shows the folder view even if there is no main window

pmo-trunk-r2235

16 years ago * Updated the changelog with the fixes made on 14 june 2007.
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 14:49:44 +0000 (14:49 +0000)]
  * Updated the changelog with the fixes made on 14 june 2007.

pmo-trunk-r2234

16 years ago* modest_text_utils_get_display_date:
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 13:34:32 +0000 (13:34 +0000)]
* modest_text_utils_get_display_date:
  - use the localized (%X) display date
* _modest_header_view_compact_header_cell_data
  - don't try to display the date when it's zero

pmo-trunk-r2233

16 years agoAdded useful debug output to help us figure out the no-messages bug.
Murray Cumming [Thu, 14 Jun 2007 12:52:45 +0000 (12:52 +0000)]
Added useful debug output to help us figure out the no-messages bug.

pmo-trunk-r2232

16 years ago * Fixed a memory leak with mail operations that issued progress information
Sergio Villar Senin [Thu, 14 Jun 2007 12:42:44 +0000 (12:42 +0000)]
* Fixed a memory leak with mail operations that issued progress information
* Fixed a memory leak in the progress object
* Fixes NB#59461, now it's possible to navigate between messages in the viewer without any main window

pmo-trunk-r2231

16 years ago2007-06-14 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 14 Jun 2007 12:41:28 +0000 (12:41 +0000)]
2007-06-14  Murray Cumming  <murrayc@murrayc.com>

* src/widgets/modest-folder-view.c: (filter_row):
Explictly filter out the per-account outbox accounts. I don't know why
these only sometimes show up, but now they should never show up in the UI.
This should fix projects.maemo.org bug NB#60160.

pmo-trunk-r2230

16 years ago * Added libhildonnotify-dev and libnotify-dev the control-maemo1 file.
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 11:42:33 +0000 (11:42 +0000)]
  * Added libhildonnotify-dev and libnotify-dev the control-maemo1 file.

pmo-trunk-r2228

16 years agodo this properly.
Murray Cumming [Thu, 14 Jun 2007 10:40:20 +0000 (10:40 +0000)]
do this properly.

pmo-trunk-r2227

16 years ago2007-06-14 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 14 Jun 2007 10:38:15 +0000 (10:38 +0000)]
2007-06-14  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
        when the toolbar does not exist yet.
        * src/modest-widget-memory.c: (save_settings_header_view):
        Added g_warnings() to help us to discover when we are trying to set
        an empty columns list in gconf.

pmo-trunk-r2226

16 years ago* src/modest-text-utils.c:
Jose Dapena Paz [Thu, 14 Jun 2007 10:36:29 +0000 (10:36 +0000)]
* src/modest-text-utils.c:
        * Now _quote functions add signature to the end if
          available (fixes NB#58181).

pmo-trunk-r2225

16 years ago2007-06-14 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 14 Jun 2007 10:22:39 +0000 (10:22 +0000)]
2007-06-14  Murray Cumming  <murrayc@murrayc.com>

* src/modest-init.h:
        * src/modest-init.c:
        Added modest_init_get_default_header_view_column_ids().

        * src/modest-widget-memory.c: (restore_settings_header_view):
        Use the new function to get defaults, if the gconf key is empty,
        instead of not creating any columns. This seems to fix the
        empty right-hand pane problems.

        * src/widgets/modest-header-view.h: Improved documentation.

pmo-trunk-r2224

16 years agoWork for making select all work as expected in
Jose Dapena Paz [Thu, 14 Jun 2007 10:13:38 +0000 (10:13 +0000)]
Work for making select all work as expected in
message view (body). Fixes NB#58104.
* src/widgets/modest-msg-view.[ch]:
        * New method ..._grab_focus, that grabs the
          focus on the body.
* src/modest-msg-view-window.c:
        * Use new method modest_msg_view_grab_focus to
          put the default focus instead of just using
          gtk_widget_grab_focus. This should fix the
          default focus when the window is created (that
          should be in the message body).
* src/modest-ui-actions.c:
        * Add an implementation of select all for
          gtkhtml widgets.

pmo-trunk-r2223

16 years ago* src/modest-formatter.[ch]:
Jose Dapena Paz [Thu, 14 Jun 2007 09:50:42 +0000 (09:50 +0000)]
* src/modest-formatter.[ch]:
        * New API to create modest new messages. Method
          modest_formatter_create_message creates a message
          with the expected multiparts.
          modest_formatter_create_body_part obtains a new
          body part to add body contents.
        * The new API is used now in modest_formatter_do
          and modest_formatter_attach.
* src/modest-tny-msg.c:
        * (modest_tny_msg_new, modest_tny_msg_new_html_plain,
          add_body_part, add_html_body_part, add_attachments,
          create_reply_forward_mail) Uses the new ModestFormatter
          API to create specific modest formatted messages. This
          should make creation of messages with attachments and
          alternatives work far better.
        * (modest_tny_msg_create_forward_msg): silly bug creating
          the attachments list removed.
* src/modest-mail-operation.c:
        * Removes a warning on sending new mails without priority
          set.

pmo-trunk-r2222

16 years ago* always check accounts are set up before opening the editor; if none are
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 09:32:36 +0000 (09:32 +0000)]
* always check accounts are set up before opening the editor; if none are
  specified, open the account wizard
* make sure the editor cannot be opened with a NULL account
* Fixes: NB#55368

pmo-trunk-r2221

16 years ago * Do not select the INBOX until the widget is not already mapped, because it could...
Sergio Villar Senin [Thu, 14 Jun 2007 09:01:03 +0000 (09:01 +0000)]
* Do not select the INBOX until the widget is not already mapped, because it could cause some issues

pmo-trunk-r2220

16 years ago * Removed the code that checks the message count before refreshing, the message...
Sergio Villar Senin [Thu, 14 Jun 2007 06:52:13 +0000 (06:52 +0000)]
* Removed the code that checks the message count before refreshing, the message count at that point is not correct. It is located in the callback of the refresh function
* The first INBOX folder is now selected again when starting the application

pmo-trunk-r2219

16 years ago* set the default paned pos for the main window to something sane
Dirk-Jan C. Binnema [Wed, 13 Jun 2007 16:58:18 +0000 (16:58 +0000)]
* set the default paned pos for the main window to something sane

pmo-trunk-r2218

16 years ago2007-06-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 13 Jun 2007 16:54:11 +0000 (16:54 +0000)]
2007-06-13  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
        Revert the use of the display name as the account name, because this
        is generally wrong and would break the code that follows.

pmo-trunk-r2217

16 years ago* compile fix
Dirk-Jan C. Binnema [Wed, 13 Jun 2007 16:25:14 +0000 (16:25 +0000)]
* compile fix

pmo-trunk-r2216

16 years ago* some fixes towards fixing the right-hand-pane-empty problem
Dirk-Jan C. Binnema [Wed, 13 Jun 2007 16:18:22 +0000 (16:18 +0000)]
* some fixes towards fixing the right-hand-pane-empty problem
  - save/restore header before/after changing folder
  - special casing for guessing the local-folder-type; this makes outbox/sent now show the correct headers (ie. To:, Sent: instead of From:,Received:)
  - fix some weirdness in modest-widget-memory (reading -1 into a guint...)

pmo-trunk-r2215

16 years ago2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 13 Jun 2007 16:14:17 +0000 (16:14 +0000)]
2007-06-13  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c:
(check_for_supported_auth_methods), (on_before_next),
(create_account):

More correct fix for projects.maemo.org bug NB# 58991
Do not longer accept AUTH_PASSWORD as secure method and choose
correct method when creating the account.

pmo-trunk-r2214

16 years ago * Updated the changelog with the fixes done on 2007.06.13 18:00
Dirk-Jan C. Binnema [Wed, 13 Jun 2007 15:38:54 +0000 (15:38 +0000)]
  * Updated the changelog with the fixes done on 2007.06.13 18:00

pmo-trunk-r2212

16 years ago2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 13 Jun 2007 15:01:04 +0000 (15:01 +0000)]
2007-06-13  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
Fixed projects.maemo.org bug NB# 58991

pmo-trunk-r2211

16 years ago2007-06-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 13 Jun 2007 14:51:09 +0000 (14:51 +0000)]
2007-06-13  Murray Cumming  <murrayc@murrayc.com>

* src/modest-init.c: (modest_init_init_core),
(modest_init_local_folders): Fixed compilation errors.

pmo-trunk-r2210

16 years agoA few small fixes for the modest-search feature
Philip Van Hoof [Wed, 13 Jun 2007 14:49:12 +0000 (14:49 +0000)]
A few small fixes for the modest-search feature

pmo-trunk-r2209

16 years ago2007-06-13 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 13 Jun 2007 13:46:12 +0000 (13:46 +0000)]
2007-06-13  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
Remove unnecessary lib/include, though it is good in principle when needed.

* src/modest-init.c: (modest_init_one_local_folder),
(modest_init_local_folders):
* src/modest-init.h: Initialize the .modest library for memory cards,
instead of just doing nothing for them. This should allow us to create
folders there, fixing projects.maemo.org bug NB#59297.

pmo-trunk-r2208

16 years ago * Follow the 30/70 rule for the main paned separation position when there is no...
Sergio Villar Senin [Wed, 13 Jun 2007 13:35:31 +0000 (13:35 +0000)]
* Follow the 30/70 rule for the main paned separation position when there is no configuration set

pmo-trunk-r2207