Jose Dapena Paz [Wed, 2 May 2007 14:12:38 +0000 (14:12 +0000)]
* src/modest-ui-actions.[ch]:
* Run check names before sending email from editor.
* New check names action, used to validate and
search addresses in addressbook.
* src/modest-address-book.h:
* Added new check_names method.
* src/modest-text-utils.[ch]:
* Added ..._get_addresses_indexes. It finds the offset ranges
of the addresses in a string.
* ..._split_addresses_list now takes ";" into account, not only
",".
* ..._split_addresses_list fixed offset calculations. Now uses
utf8 characters.
* ..._validate_recipient: strips the string before processing.
* ..._validate_recipient: now counts utf8 characters. Also
accepts spaces in left part of the address, even when they're
not between quotes.
* src/maemo/modest-address-book.c:
* ..._add_address: now the dialog title uses the logical id.
* (ui_get_formatted_email_id): Now it adds quotes to address
strings with spaces.
* New ..._check_names method. It validates all addresses in
the recipient editor. If address is valid, ok, if not valid,
it checks if this is an email address attempt (shows error)
or a generic string (searches in addressbook and replaces
with matches).
* src/maemo/modest-msg-edit-window.c:
* New ..._check_names method. Checks all recipient fields using
new check names implementation in addressbook module.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added "Check names" menu option.
* src/gnome/modest-address-book.c:
* Added stubs for new functions.
* src/gnome/modest-msg-edit-window.c:
* Added stubs for new functions.
* src/widgets/modest-msg-edit-window.h:
* New _check_names method.
* src/widgets/modest-recpt-editor.[ch]:
* Now , and ; inside quotes do not insert a CR.
* New ..._replace_with_resolved_recipient method, to replace
a range of the editor with a resolved recipient. It's used
on _check_names implementation.
* src/widgets/modest-msg-edit-window-ui.h:
* Added action for check names.
pmo-trunk-r1730
Sergio Villar Senin [Wed, 2 May 2007 12:00:37 +0000 (12:00 +0000)]
* Replaced two confusing function names
* Replaced all the widget names used by the memory by their correspondent defines
pmo-trunk-r1729
Sergio Villar Senin [Wed, 2 May 2007 11:17:53 +0000 (11:17 +0000)]
* Fixes: #NB55377, #NB55441
* Added "visible_server_account_id" persistent configuration key to the folder view
* Removed the double treemodel creation in the header view when refreshing
pmo-trunk-r1728
Murray Cumming [Wed, 2 May 2007 11:13:37 +0000 (11:13 +0000)]
2007-05-02 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.h:
* src/modest-account-mgr.c:
(modest_account_mgr_account_names): Add a gboolean enabled_only
parameter, so we can get lists of onlt the enabled accounts.
(modest_account_mgr_add_account),,
(modest_account_mgr_account_with_display_name_exists):
* src/maemo/modest-msg-edit-window.c: (get_transports):
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_set_first_account_as_default):
* src/modest-init.c: (init_default_account_maybe):
* src/modest-tny-account-store.c: (get_accounts):
* src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
(do_send_receive_auto), (modest_ui_actions_on_send_receive):
* tests/check_account-mgr.c: (START_TEST):
Provide the extra parameter, as appropriate.
* src/widgets/modest-account-view.c: (update_account_view):
Do not show disabled accounts (meaning that there is no way to
enable/disable accounts in the UI (the feature is not in our UI
specification), so we can use this internally only to mark unfinished
or temporary account data.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_account): Add boolean enable parameter, so we can specify FALSE
to create the temporary account.
(on_button_edit_advanced_settings): Create the temporary account as disabled.
(on_before_next): When finishing, when there is a temporary account, just
set it as enabled.
Also, use a timeout to delay the showing of the dialog until gconf is likely
to return correct information, due to a maemo gconf bug that is fixed in
osso 1.1, but not yet in Bora.
However, the dialog stays on screen after it is destroyed.
* src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
for invalid data when cancelling. Use a hildon note instead of a dialog
to complain about invalid data. Do not show the account-saved note if the
account is disabled (a temporary account that will not really be saved for use
until later.)
pmo-trunk-r1727
Sergio Villar Senin [Wed, 2 May 2007 06:46:34 +0000 (06:46 +0000)]
* Modified the _get_display_size method to fit with the file management specs
* Replaced the old display size of the details dialog by the new call
pmo-trunk-r1726
Dirk-Jan C. Binnema [Tue, 1 May 2007 06:41:42 +0000 (06:41 +0000)]
* update
pmo-trunk-r1725
Murray Cumming [Mon, 30 Apr 2007 14:44:29 +0000 (14:44 +0000)]
2007-04-30 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_account_mgr_unset_default_account(),
Added modest_account_mgr_set_first_account_as_default().
* src/modest-account-mgr.c: (modest_account_mgr_remove_account):
If it was the default account, unset the default account name.
* src/maemo/modest-account-view-window.c:
(on_delete_button_clicked): If it was the default account,
set the first remaining account as the default instead.
* src/maemo/modest-main-window.c: (on_account_update): Do not try to use
a NULL account or a NULL default account, to prevent a crash. This should
not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
pmo-trunk-r1724
Jose Dapena Paz [Mon, 30 Apr 2007 14:19:27 +0000 (14:19 +0000)]
* src/modest-text-utils.[ch]:
* Added modest_text_utils_validate_recipient. This validates
addresses in a@b.c format, but also in "name" <a@b.c> and
name <a@b.c> formats.
* src/maemo/modest-msg-view-window.c:
* Now add to contacts menu option is dimmed if the clipboard
does not contain a valid recipient.
* src/widgets/modest-recpt-editor.c:
* Added an implementation of backspace valid for gtk < 2.10.
pmo-trunk-r1723
Murray Cumming [Mon, 30 Apr 2007 13:22:50 +0000 (13:22 +0000)]
2007-04-30 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-recpt-editor.c:
(modest_recpt_editor_on_key_press_event): Put an #ifdef around the
use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
TODO comment for this. This fixes the build.
* src/modest-ui-actions.c: Add do_send_receive(), though it might not
be the best place for it. This will in future update all auto-update accounts,
rather than just the current/default account, when that gconf key exists.
(modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
if there are no accounts, before calling do_send_receive().
* src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
* src/gnome/modest-main-window.c: (on_online_toggle_toggled):
* src/maemo/modest-main-window-ui.h:
* src/maemo/modest-main-window.c: (on_connection_changed),
(sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
directly, becaue the signal handler does more.
pmo-trunk-r1722
Murray Cumming [Mon, 30 Apr 2007 11:51:00 +0000 (11:51 +0000)]
2007-04-30 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
for the case that the account does not exist.
* src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
(equivalent to the modest account name) rather than the tinymail account name
(equivalent to the modest account title - human readable) to get the account data.
Check for null account data to prevent the crash, and add a TODO comment saying that
this needs fixing because it is using the server account name instead of the account name.
pmo-trunk-r1721
Jose Dapena Paz [Mon, 30 Apr 2007 11:48:32 +0000 (11:48 +0000)]
* src/modest-ui-actions.[ch]:
* (..._on_delete) action simply closes the edit window, emitting
a delete-event signal.
* (..._on_close_window) also sends a delete-event.
* (..._on_new_msg) adds the signature if there's one configured
in the account. Also removed the "save to drafts" part just on
creating the new message (fixes #NB55341, #NB55391).
* (reply_forward_func) now gets the signature of the account.
* (..._on_save_to_drafts). New action that saves an edited
message as a draft.
* src/modest-text-utils.[ch]:
* (..._quote, ..._cite and ..._inline) now put the signature.
* Added ..._convert_buffer_to_html. This way we can convert to
html tags a subpart of a document (it does not add html
headers). Also modified ..._convert_to_html to use this
function.
* Added ..._convert_to_html_body. It converts a string to
an html that can be included inside a formatted html document.
* src/maemo/modest-address-book.c:
* (..._select_addresses): after selecting an address of a
recipient editor through the select contacts dialog, focus is
asigned to the ModestRecptEditor.
* (select_email_addrs_for_contact): when the dialog is loaded,
first address is selected by default.
* src/maemo/modest-msg-edit-window.c:
* Implemented dim rule: if focus is not in body or message
format is plain text, font actions are dimmed. Also configured
proper insensitive_press messages.
* Implemented dim rule: if To: recipient field is empty, send
action is dimmed. Also configured proper insensitive_press
message.
* Delete event handler. It shows a dialog for saving the mail
as a draft if message is modified.
* Fixed the html document parsing procedure, as it wasn't
previously really parsed because the buffer length was not
provided.
* If the account setup specified that it should by default
create plain text mails, it's used. Also radio menu option is
updated properly.
* Now we get correctly the focused widget. If "Select contacts"
is selected, it adds contacts to the focused recipient list,
or to To: field if no recipient list is focused.
* If the To: field is empty on opening editor, focus goes to it.
* Now the message stores a reference to the draft message used
to create the mail.
* Refactored the ..._select_contacts function to use the
general "open_addressbook" function.
* Added ..._is_modified and ..._reset_modified. It tells if the
message was modified by the user.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added email menu options Send, Save to drafts, new message,
delete.
* Added close window and close all windows menu actions.
* src/modest-formatter.[ch]:
* Now the formatter adds the signature properly.
* src/modest-mail-operation.[ch]:
* Added ..._save_to_drafts operation. It creates a mail from
editor and saves it to the active account drafts folder.
* src/modest-defs.h:
* Added configuration option for preferring formatted of plain
text.
* src/widgets/modest-recpt-view.[ch]:
* Now button release event is processed after the default
handler.
* src/widgets/modest-recpt-editor.[ch]:
* Completely new behavior for keyboard and mouse edition. Now
only one address per line. Keyboard and mouse selection treat
resolved addresses as a whole (you shouldn't be able to
manipulate a part of resolved address).
* Keyboard shortcut for adding addresses with the addressbook.
* Better focus and cursor handling.
* Now the widget does not use GTK_CAN_FOCUS.
* (..._get_buffer): new API function to export the internal
buffer.
* (..._grab_focus): new function to make the textview grab the
focus.
* src/widgets/modest-scroll-text.[ch]:
* Small fixes to calculation of the number of lines. Now it also
makes the cursor visible.
* src/widgets/modest-msg-edit-window-ui.h:
* Added actions for "window close", "new message", "delete",
"save to drafts", "all windows close"
* src/modest-tny-msg.[ch]:
* Support plain text quoted texts as input of msg editor.
* Now (create_reply_forward_mail) takes the "prefer formatted"
option.
* Now it uses the logical id's for "Re:" and "Fwd:" strings.
* Added signature support.
* src/maemo/modest-main-window-ui.h:
* Added a new action for new messages. It's used for showing a
simple "New" menu option for creating new messages from the
view (fixes #NB55368).
pmo-trunk-r1720
Sergio Villar Senin [Mon, 30 Apr 2007 10:01:15 +0000 (10:01 +0000)]
* Now the ModestFolderView shows only the remote account that is declared as the default one
pmo-trunk-r1719
Javier Fernandez Garcia-Boente [Mon, 30 Apr 2007 08:14:19 +0000 (08:14 +0000)]
* Changes in the mail_operation API
* new object instances require the operation id
pmo-trunk-r1718
Dirk-Jan C. Binnema [Mon, 30 Apr 2007 06:32:56 +0000 (06:32 +0000)]
* add modest-hildon-includes.h also for 1.1 build (fixes build there)
pmo-trunk-r1717
Dirk-Jan C. Binnema [Sun, 29 Apr 2007 15:04:23 +0000 (15:04 +0000)]
* update debian package building scripts
pmo-trunk-r1716
Murray Cumming [Sun, 29 Apr 2007 11:30:19 +0000 (11:30 +0000)]
2007-04-29 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
* src/maemo/modest-account-settings-dialog.c: (show_error),
(show_ok):
Use hildon_note_new_information() for informative and error messages,
which seems to be expected for Maemo applications (no documentation that I know of
says this). I am surprised that there is no distinction between info and error
dialogs.
pmo-trunk-r1715
Murray Cumming [Sun, 29 Apr 2007 11:17:58 +0000 (11:17 +0000)]
2007-04-29 rray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
it is easy to find where this is used.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_welcome), (create_page_account_details),
(create_page_user_details), (create_page_complete_easysetup),
(create_page_custom_incoming), (create_page_custom_outgoing),
(create_page_complete_custom):
* src/maemo/modest-account-settings-dialog.c:
(create_page_account_details), (create_page_user_details),
(create_page_incoming), (create_page_outgoing):
* src/maemo/modest-account-view-window.c: (window_vbox_new):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_init):
* src/maemo/modest-signature-editor-dialog.c:
(modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
and scrolling policy as per the Email Application Layout Guide, if I have
understood it.
pmo-trunk-r1714
Murray Cumming [Sun, 29 Apr 2007 10:13:13 +0000 (10:13 +0000)]
2007-04-27 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_init):
Remove the add_transport_account_func and add_store_account_func vfunc implementations,
which were empty, because these vfuncs have been removed from TnyAccountStore.
This fixes the build.
pmo-trunk-r1713
Javier Fernandez Garcia-Boente [Sat, 28 Apr 2007 17:50:05 +0000 (17:50 +0000)]
* Change mail_operation_new calls tu use the new field 'id'.
* Implementation of updating refresh call for updating progress
values and emiting signal 'progress_changed'.
* Review ProgressBar widget layout.
* Adding alignment and adjustment objects
pmo-trunk-r1712
Javier Fernandez Garcia-Boente [Sat, 28 Apr 2007 17:47:21 +0000 (17:47 +0000)]
* Add a new dialog, Sort Dialog (WID-DIA021).
* Connect iUIManager actions to sort dialog.
* Store sort settings into gconf configuration parameters.
pmo-trunk-r1711
Dirk-Jan C. Binnema [Sat, 28 Apr 2007 11:01:25 +0000 (11:01 +0000)]
* make two control files: one for "old" (N800) packaging, and one for
post-N800 packaging.
Difference is only in hildon-libs-dev ==> libhildon1-dev right now
pmo-trunk-r1709
Dirk-Jan C. Binnema [Sat, 28 Apr 2007 10:53:20 +0000 (10:53 +0000)]
* updated
pmo-trunk-r1708
Sergio Villar Senin [Fri, 27 Apr 2007 17:24:35 +0000 (17:24 +0000)]
* Added some missing includes
* Added a "," that was causing a build problem
* Added MSG-NOT404 confirmation note when moving messages
pmo-trunk-r1707
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 16:05:52 +0000 (16:05 +0000)]
* use the newest hildon iff available
pmo-trunk-r1706
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 16:05:00 +0000 (16:05 +0000)]
* fix for latest hildon version
pmo-trunk-r1705
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 16:04:27 +0000 (16:04 +0000)]
* fixes for latest hildon version
pmo-trunk-r1704
Murray Cumming [Fri, 27 Apr 2007 15:49:19 +0000 (15:49 +0000)]
2007-04-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c:
(modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
showing/hiding it. Added TODO because it probably should not be NULL.
* src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
because unnecessary g_warnings() make degugging difficult.
pmo-trunk-r1703
Murray Cumming [Fri, 27 Apr 2007 15:37:29 +0000 (15:37 +0000)]
2007-04-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_select_color),
(modest_msg_edit_window_select_background_color): 2 const corrections and
moving 2 #endifs before closing brackets, to fix the build.
pmo-trunk-r1702
Murray Cumming [Fri, 27 Apr 2007 15:31:08 +0000 (15:31 +0000)]
https://projects.maemo.org
pmo-trunk-r1701
Javier Fernandez Garcia-Boente [Fri, 27 Apr 2007 15:29:41 +0000 (15:29 +0000)]
* Sets ASCENDING sort byt sent/received date as default.
* Remove unused code
pmo-trunk-r1700
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 15:23:09 +0000 (15:23 +0000)]
* make maemo work even with the new libhildon (1.1)
pmo-trunk-r1699
Philip Van Hoof [Fri, 27 Apr 2007 15:15:26 +0000 (15:15 +0000)]
Fixed function prototype
pmo-trunk-r1698
Sergio Villar Senin [Fri, 27 Apr 2007 14:39:31 +0000 (14:39 +0000)]
* Refactored "Move to" code in order to allow this call from the ModestMsgViewWindow
pmo-trunk-r1697
Murray Cumming [Fri, 27 Apr 2007 14:34:10 +0000 (14:34 +0000)]
2007-04-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
when opening a message window.
pmo-trunk-r1696
Murray Cumming [Fri, 27 Apr 2007 13:17:31 +0000 (13:17 +0000)]
2007-04-27 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_custom_outgoing): Correct the position of the horizontal separator to
match the UI spec.
* src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
before showing/hiding them, to avoid a crash when clicking on folders when there are no
gconf settings. I probably added more checks than necessary, but that is safer.
* src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
variable to fix the build, but this seems to be used when it is still NULL.
pmo-trunk-r1695
Sergio Villar Senin [Fri, 27 Apr 2007 12:43:24 +0000 (12:43 +0000)]
* Modified the xfer_msg API
* Modified the run_confirmation_dialog API
* Added some more code to the "move to" dialog
pmo-trunk-r1694
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 12:30:16 +0000 (12:30 +0000)]
* don't use gobjects that might be dead
pmo-trunk-r1693
Murray Cumming [Fri, 27 Apr 2007 11:35:53 +0000 (11:35 +0000)]
2007-04-27 Murray Cumming <murrayc@murrayc.com>
* src/modest-platform.h:
* src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
* src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
* src/modest-main.c: Implement this function so we can avoid using
maemo-specific API from cross-platform code.
(main):
* src/modest-tny-account-store.c:
(get_smtp_specific_transport_account_for_open_connection):
* src/modest-ui-actions.c: (check_for_connection),
(modest_ui_actions_on_item_not_found):
Use modest_platform_connect_and_wait() and put #idefs around other
maemo-specific code, because only maemo currently has a way to
identify connection names.
pmo-trunk-r1692
Murray Cumming [Fri, 27 Apr 2007 11:12:36 +0000 (11:12 +0000)]
2007-04-27 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.h:
* src/modest-tny-account-store.c:
Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
the connection-specific SMTP server settings in the configuration.
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
(on_idle_mail_to):
* src/maemo/modest-main-window.c: (on_connection_changed),
(connect_signals):
* src/modest-main.c: (main), (start_ui), (send_mail):
Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
that is what is intended.
* src/modest-ui-actions.c: (action_send), (action_receive),
(modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
SMTP server is used when it is specified.
(modest_ui_actions_on_send_receive):
Check that a connection is open before proceeding.
Receive and then send, instead of vice-versa, as per the specification
pmo-trunk-r1691
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 11:12:10 +0000 (11:12 +0000)]
* remove the modest-debug stuff; it belong in modest-runtime
pmo-trunk-r1690
Sergio Villar Senin [Fri, 27 Apr 2007 10:20:35 +0000 (10:20 +0000)]
* Added "Move to" dialog
* "Move to" dialog can transfer folders right now
* Added some documentaion
* Replaced wrong ORs by ANDs when checking folder rules
pmo-trunk-r1689
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 10:04:47 +0000 (10:04 +0000)]
* add modest-providers-data to build deps
pmo-trunk-r1688
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 07:34:32 +0000 (07:34 +0000)]
* more fixes for the debian build
pmo-trunk-r1687
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 07:10:34 +0000 (07:10 +0000)]
* unbreak configure.ac
pmo-trunk-r1686
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:42:19 +0000 (06:42 +0000)]
update control to depend on libconic
pmo-trunk-r1685
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:28:43 +0000 (06:28 +0000)]
remove subcontractor name because integration won't work otherwise
pmo-trunk-r1684
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:26:53 +0000 (06:26 +0000)]
cleanup control file for debian build
pmo-trunk-r1683
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:18:51 +0000 (06:18 +0000)]
* small cleanups for debian build
pmo-trunk-r1682
Dirk-Jan C. Binnema [Fri, 27 Apr 2007 06:18:09 +0000 (06:18 +0000)]
* cleanup the translations
pmo-trunk-r1681
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 19:15:21 +0000 (19:15 +0000)]
* Implement Observer pattern using ModestProgressBarWidget.
* Adds an observer to mail operation queue into main window
to establish toolbar operation mode.
pmo-trunk-r1680
Murray Cumming [Thu, 26 Apr 2007 13:45:08 +0000 (13:45 +0000)]
2007-04-26 Murray Cumming <murrayc@murrayc.com>
* src/modest-mail-operation.c:
(modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
though I guess it should be something other than NULL.
pmo-trunk-r1679
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 12:43:14 +0000 (12:43 +0000)]
* Fix bug on sorting headers list. The gtk_tree_model_sort
was created on each folder refresh, and sorting column id
was not set again correctly.
pmo-trunk-r1678
Sergio Villar Senin [Thu, 26 Apr 2007 11:18:28 +0000 (11:18 +0000)]
* Removed some unused errors
* Removed error handling code froms Queues
* Added ModestFolderRules to mail operations
pmo-trunk-r1677
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 10:20:58 +0000 (10:20 +0000)]
* Add a GSlist to store observers, allowing connect more
than one progress widgets.
* Change set_toolbar_function visibility; now it's a private function.
pmo-trunk-r1676
Murray Cumming [Thu, 26 Apr 2007 09:47:08 +0000 (09:47 +0000)]
2007-04-26 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_custom_incoming): Add the checkbox to the caption instead of adding the
combo twice, to avoid an g_warning and to make it visible again.
* src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
attached before detaching it, to avoid a g_warning, and add comment about the implicit
(already intended) dereference when detaching, because we then recreate the menu.
But I am not sure why the warning was happening, and it is possible that this is a memory
leak.
pmo-trunk-r1675
Sergio Villar Senin [Thu, 26 Apr 2007 09:31:28 +0000 (09:31 +0000)]
* Added some missing "== 0" comparisons
pmo-trunk-r1674
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 08:54:09 +0000 (08:54 +0000)]
* Add new header settings parameter (sort) to select
columns which can be used to sort headers list.
* Review restore_settings_header to set TreeSortable
sort column id.
pmo-trunk-r1673
Javier Fernandez Garcia-Boente [Thu, 26 Apr 2007 08:45:49 +0000 (08:45 +0000)]
* Add a new widget ModestProgressBarWidget to work as observer
of ModestMainWindow object.
* Add ui manager toolitems for this new widget and Cancel button.
* Sinchronize toolbar items dimming based on toolbar operation
mode (Normal/Transfer).
pmo-trunk-r1672
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 20:08:28 +0000 (20:08 +0000)]
* lintian update (Section:)
pmo-trunk-r1670
Sergio Villar Senin [Wed, 25 Apr 2007 20:05:35 +0000 (20:05 +0000)]
* Added ModestFolderViewStyle
* Added "show one remote account at a time" feature
* Modest version shows only one remote account by default
pmo-trunk-r1669
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 19:56:34 +0000 (19:56 +0000)]
* lintian fixes
pmo-trunk-r1668
Sergio Villar Senin [Wed, 25 Apr 2007 17:20:41 +0000 (17:20 +0000)]
* Deleted debug code
pmo-trunk-r1667
Sergio Villar Senin [Wed, 25 Apr 2007 17:20:04 +0000 (17:20 +0000)]
* Fixed accounts order in the folder view
pmo-trunk-r1666
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 10:11:53 +0000 (10:11 +0000)]
better rules
pmo-trunk-r1664
Murray Cumming [Wed, 25 Apr 2007 09:54:58 +0000 (09:54 +0000)]
2007-04-25 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
and uri_parse_mailto() utility functions.
(on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
the mailto URI.
* tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
pmo-trunk-r1663
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 08:21:32 +0000 (08:21 +0000)]
* put Packages.gz in $PACKAGE_PATH
pmo-trunk-r1662
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 08:16:34 +0000 (08:16 +0000)]
* small update, to be smarter about already built packages
pmo-trunk-r1661
Dirk-Jan C. Binnema [Wed, 25 Apr 2007 08:06:04 +0000 (08:06 +0000)]
* added script to build debian packages for tinymail, modest-providers-data and modest
pmo-trunk-r1660
Sergio Villar Senin [Tue, 24 Apr 2007 19:07:49 +0000 (19:07 +0000)]
* Added an #ifdef that makes dnd work properly in Modest
pmo-trunk-r1659
Sergio Villar Senin [Tue, 24 Apr 2007 18:32:05 +0000 (18:32 +0000)]
* Removed unused code
pmo-trunk-r1658
Sergio Villar Senin [Tue, 24 Apr 2007 18:30:34 +0000 (18:30 +0000)]
* Added information dialog for folder creation
* Added information dialog for folder removal
pmo-trunk-r1657
Sergio Villar Senin [Tue, 24 Apr 2007 17:44:01 +0000 (17:44 +0000)]
* Added code to manage folder creation
* Added confirmation dialog of delete folder
pmo-trunk-r1656
Murray Cumming [Tue, 24 Apr 2007 17:31:56 +0000 (17:31 +0000)]
2007-04-24 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c:
Use an idle callback to execute the modest code in the application's own thread.
Remove the helloworld example method.
Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
parsed, and the open-message method is not implemented because this is not yet implemented in
modest itself.
* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
(libmodest_dbus_client_open_message):
* libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
* src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
body without crashing.
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_mail_to.c:
* tests/dbus_api/test_open_message.c: New tests for the new methods.
pmo-trunk-r1655
Dirk-Jan C. Binnema [Tue, 24 Apr 2007 14:35:58 +0000 (14:35 +0000)]
* fix for debian/rules
pmo-trunk-r1654
Dirk-Jan C. Binnema [Tue, 24 Apr 2007 14:15:54 +0000 (14:15 +0000)]
* some updates to the debian files - added Builddeps, removed generated files
pmo-trunk-r1653
Murray Cumming [Tue, 24 Apr 2007 13:49:14 +0000 (13:49 +0000)]
2007-04-24 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
Added file to fix the build. Sorry.
* src/dbus_api/Makefile.am:
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.h:
* src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
(modest_dbus_req_handler):
Put constants in a separate header so it can be reused by the
client library, without duplication
* libmodest-dbus-client/Makefile.am:
* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_call_helloworld),
(libmodfest_dbus_client_send_mail),
(libmodfest_dbus_client_mailto),
(libmodfest_dbus_client_open_message):
* libmodest-dbus-client/libmodest-dbus-client.h:
(Partly) Implement a send_mail D-Bus method.
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_send_mail.c: (main): Added a test for
the send_email D-Bus method.
pmo-trunk-r1652
Sergio Villar Senin [Tue, 24 Apr 2007 13:24:03 +0000 (13:24 +0000)]
* Added new folder dialog
* Added WID-INF036
* Added code to manage the new folder dialog
pmo-trunk-r1651
Dirk-Jan C. Binnema [Tue, 24 Apr 2007 13:13:47 +0000 (13:13 +0000)]
* let the app have the official name
* fix for API-change in osso-addressbook
pmo-trunk-r1650
Murray Cumming [Tue, 24 Apr 2007 11:47:23 +0000 (11:47 +0000)]
2007-04-24 Murray Cumming <murrayc@murrayc.com>
* Makefile.am:
* configure.ac:
* libmodest-dbus-client/Makefile.am:
* libmodest-dbus-client/libmodest-dbus-client.c:
* libmodest-dbus-client/libmodest-dbus-client.h:
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
pmo-trunk-r1649
Murray Cumming [Tue, 24 Apr 2007 10:37:03 +0000 (10:37 +0000)]
2007-04-24 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_account_details):
* src/maemo/modest-account-settings-dialog.c:
(create_page_account_details): Explicitly set auto-capitalization mode for the title
widgets, because this might not be the default in future versions of the Maemo GTK+.
However, I can not not get capitalization to work even in a simple test case.
pmo-trunk-r1648
Sergio Villar Senin [Tue, 24 Apr 2007 09:20:03 +0000 (09:20 +0000)]
* Refactored the msg view details dialog
* Added folder details code
* Added msg details support for the main view (with multiple selection)
pmo-trunk-r1647
Sergio Villar Senin [Tue, 24 Apr 2007 09:18:54 +0000 (09:18 +0000)]
* Removed invalid files
* Added details dialog
pmo-trunk-r1646
Murray Cumming [Tue, 24 Apr 2007 08:34:47 +0000 (08:34 +0000)]
2007-04-24 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_custom_incoming), (create_page_custom_outgoing):
* src/maemo/modest-account-settings-dialog.c:
(create_page_account_details), (create_page_incoming),
(create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
instead of using gtk_check_button_with_label(), so they are aligned like the other
widgets, as per the UI spec.
pmo-trunk-r1645
Murray Cumming [Tue, 24 Apr 2007 07:55:37 +0000 (07:55 +0000)]
2007-04-24 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-connection-specific-smtp-edit-window.c:
* src/widgets/modest-validating-entry.c:
* src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
Modest prefix instead of an EasySetup prefix.
pmo-trunk-r1644
Murray Cumming [Mon, 23 Apr 2007 20:15:02 +0000 (20:15 +0000)]
2007-04-23 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-validating-entry.h:
* src/widgets/modest-validating-entry.c: (on_insert_text),
Added easysetup_validating_entry_set_max_func(), used to set a callback
to call when the max number of characters is reached. GtkEntry has a max-length
already but is silent about it.
* src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
(create_page_account_details), (create_page_user_details),
(create_account):
* src/maemo/modest-account-settings-dialog.c: (on_entry_max),
(create_page_account_details), (create_page_user_details),
(create_page_outgoing):
* src/modest-ui-actions.c: (modest_ui_actions_on_details):
Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
the UI spec, when the user tries to enter more than the max number of characters.
pmo-trunk-r1643
Dirk-Jan C. Binnema [Mon, 23 Apr 2007 19:11:40 +0000 (19:11 +0000)]
* revert jfernandez patch
pmo-trunk-r1642
Murray Cumming [Mon, 23 Apr 2007 19:06:06 +0000 (19:06 +0000)]
2007-04-23 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_user_details), (create_page_custom_incoming),
(create_page_custom_outgoing):
* src/maemo/modest-account-settings-dialog.c:
(create_page_user_details), (create_page_incoming),
(create_page_outgoing):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
not appropriate. Bad Maemo-specific defaults./autogen.sh --prefix=/usr;make all install
pmo-trunk-r1641
Sergio Villar Senin [Mon, 23 Apr 2007 17:37:22 +0000 (17:37 +0000)]
* Added folder view CSM
* Refactored the show details code
* Added support to show the msg details from Main view
* Added a missing license information to a file
* Implemented the folder count method in ModestTnyAccount
pmo-trunk-r1640
Murray Cumming [Mon, 23 Apr 2007 15:56:14 +0000 (15:56 +0000)]
2007-04-23 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
(on_toggle_button_changed), (modest_signature_editor_dialog_init),
(modest_signature_editor_dialog_set_settings):
Disable the label and textview when the checkbox is disabled, and use the
specified (UI spec) default signature text.
pmo-trunk-r1639
Murray Cumming [Mon, 23 Apr 2007 15:23:12 +0000 (15:23 +0000)]
2007-04-23 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init): Use spacing constants.
* src/modest-defs.h:
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_account_mgr_get/set_signature(), using new gconf keys.
* src/maemo/Makefile.am:
* src/maemo/modest-signature-editor-dialog.c:
* src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
as per the UI spec.
* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_finalize), (on_button_signature),
(save_configuration): Use the new dialog when the Edit button is pressed, and
save the changes if necessary, as per the UI spec.
pmo-trunk-r1638
Murray Cumming [Mon, 23 Apr 2007 13:58:56 +0000 (13:58 +0000)]
2007-04-23 Murray Cumming <murrayc@murrayc.com>
* src/maemo/Makefile.am:
* src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
based on maemo-develoers email from Dirk.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_welcome), (create_page_account_details),
(create_page_user_details), (create_page_complete_easysetup),
(create_page_custom_incoming), (create_page_custom_outgoing),
(create_page_complete_custom),
(modest_easysetup_wizard_dialog_init):
* src/maemo/modest-account-settings-dialog.c:
(create_page_account_details), (create_page_user_details),
(create_page_incoming), (create_page_outgoing),
(modest_account_settings_dialog_init):
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
pmo-trunk-r1637
Murray Cumming [Mon, 23 Apr 2007 13:24:18 +0000 (13:24 +0000)]
2007-04-23 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_account_details), (create_page_custom_outgoing),
(create_page_complete_custom):
* src/maemo/modest-account-settings-dialog.c:
(create_page_user_details), (create_page_incoming),
(create_page_outgoing):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
Use the correct (UI spec) port min/max, and use horizontal separators,
as per the UI spec.
pmo-trunk-r1636
Murray Cumming [Mon, 23 Apr 2007 12:53:22 +0000 (12:53 +0000)]
2007-04-23 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(set_default_custom_servernames):
* src/maemo/modest-account-settings-dialog.c:
(create_page_incoming), (on_combo_outgoing_security_changed),
(on_combo_incoming_security_changed), (create_page_outgoing),
(modest_account_settings_dialog_set_account_name),
(save_configuration):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(on_combo_security_changed),
(modest_connection_specific_smtp_edit_window_init),
(modest_connection_specific_smtp_edit_window_set_connection),
(modest_connection_specific_smtp_edit_window_get_settings):
Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
as per the UI spec.
pmo-trunk-r1635
Javier Fernandez Garcia-Boente [Mon, 23 Apr 2007 12:07:42 +0000 (12:07 +0000)]
* Add sort callback function to the UI action ViewSort
- this function is not yet implemented.
pmo-trunk-r1634
Javier Fernandez Garcia-Boente [Mon, 23 Apr 2007 11:32:45 +0000 (11:32 +0000)]
* Set DATE column as sort column id.
- This value must be stored in configuration
pmo-trunk-r1633
Javier Fernandez Garcia-Boente [Mon, 23 Apr 2007 09:46:31 +0000 (09:46 +0000)]
* Fix bug on headers view sorting
- new compact dates are not included on sonrt function.
pmo-trunk-r1632
Javier Fernandez Garcia-Boente [Mon, 23 Apr 2007 09:36:05 +0000 (09:36 +0000)]
* Fix bug on icons path.
pmo-trunk-r1631
Sergio Villar Senin [Mon, 23 Apr 2007 07:50:51 +0000 (07:50 +0000)]
* Major API change in tinymail
pmo-trunk-r1630
Dirk-Jan C. Binnema [Sun, 22 Apr 2007 07:34:47 +0000 (07:34 +0000)]
* fix for crash when no accounts are specified
pmo-trunk-r1629
Dirk-Jan C. Binnema [Sat, 21 Apr 2007 18:27:59 +0000 (18:27 +0000)]
* remove modest_text_utils_convert_to_pango, we have the
g_markup_... functions in glib instead
pmo-trunk-r1628