Alberto Garcia [Tue, 21 Aug 2007 12:00:58 +0000 (12:00 +0000)]
* src/modest-ui-actions.c
(modest_ui_actions_on_send):
Don't ask confirmation if the subject is empty as it can't be empty
anymore
* src/maemo/modest-msg-edit-window.c
(update_send_dimming):
New function to update the dimming of the send button and menu
entry, based on the old recpt_field_changed()
(recpt_field_changed):
(subject_field_changed):
Call update_send_dimming()
(send_insensitive_press):
Check whether the subject is empty or not in order to show the proper
notification
Fixes: NB#66112
pmo-trunk-r3031
Alberto Garcia [Tue, 21 Aug 2007 10:44:54 +0000 (10:44 +0000)]
* src/modest-ui-actions.c
(download_uncached_messages):
Removed reply_fwd parameter (not needed anymore).
When retrieving an e-mail, only ask for confirmation when the
device is offline.
(reply_forward):
(modest_ui_actions_on_copy):
Removed obsolete argument in call to download_uncached_messages()
Fixes NB#66066
pmo-trunk-r3030
Alberto Garcia [Tue, 21 Aug 2007 09:06:13 +0000 (09:06 +0000)]
* src/widgets/modest-global-settings-dialog-priv.h
* src/maemo/modest-maemo-global-settings-dialog.c
Removed include_reply variable and checkbox
* src/widgets/modest-global-settings-dialog.c
(_modest_global_settings_dialog_load_conf):
(get_current_settings):
(_modest_global_settings_dialog_save_conf):
(settings_changed):
Removed include_reply from the settings dialog.
Fixes NB#66193
pmo-trunk-r3029
Vivek Sekar [Tue, 21 Aug 2007 07:59:07 +0000 (07:59 +0000)]
Added bug fixes to changelog, week 34 aug 21st.
pmo-trunk-r3028
Alberto Garcia [Tue, 21 Aug 2007 07:47:35 +0000 (07:47 +0000)]
Removed backup file
pmo-trunk-r3027
Alberto Garcia [Mon, 20 Aug 2007 14:40:34 +0000 (14:40 +0000)]
* src/maemo/modest-progress-bar-widget.c
(modest_progress_bar_cancel_current_operation):
(modest_progress_bar_cancel_all_operations):
Don't show the "Session cancelled" info banner as it's deprecated.
Fixes NB#66135
pmo-trunk-r3018
Alberto Garcia [Fri, 17 Aug 2007 17:09:05 +0000 (17:09 +0000)]
* src/modest-tny-account-store.c
(get_smtp_specific_transport_account_for_open_connection):
Don't try to use a connection-specific SMTP server if the option
is disabled for that account
pmo-trunk-r3014
Murray Cumming [Fri, 17 Aug 2007 16:15:39 +0000 (16:15 +0000)]
2007-08-17 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c:
(on_dbus_method_get_folders): Avoid trying to get the account name
when there are no accounts, to avoid critical g_warnings, fixing
projects.maemo.org bug NB#65574.
pmo-trunk-r3013
Murray Cumming [Fri, 17 Aug 2007 15:20:59 +0000 (15:20 +0000)]
2007-08-17 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-send-queue.c: (modest_tny_send_queue_get_msg_id):
Check for NULLs to prevent a crash when opening an email that is
an attachment in another email, fixing projects.maemo.org bug
NB#66012.
pmo-trunk-r3012
Murray Cumming [Fri, 17 Aug 2007 14:26:36 +0000 (14:26 +0000)]
2007-08-17 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_view_window_move_to):
Enable the Move To toolbar button for search results, fixing the
last part of projects.maemo.org bug NB#63807.
pmo-trunk-r3011
Peter Csaszar [Fri, 17 Aug 2007 14:14:19 +0000 (14:14 +0000)]
There was a bug 60714 which was partially fixed by me in revision
2959. However the real problem was that once there was an update (by
folder selection or msg retrieval) in header-view for a folder whose
msg was shown in msg-view, the model referenced by msg-view was not
the same with the model in header-view. Because of this the dimming
for prev/next buttons could had not be synchronous with header-view.
There is an observer now. The observed is the meader-view and the
observer is the msg-view-window. The target is to detect if the
model of header-view is replaced. Another essential part is the
callback for row-insertions on the model. This can be found in
modest-msg-view-window.c file.
pmo-trunk-r3010
Alberto Garcia [Fri, 17 Aug 2007 12:51:13 +0000 (12:51 +0000)]
* src/modest-defs.h:
New gconf key: "use_specific_smtp"
* src/modest-account-mgr-helpers.h
* src/modest-account-mgr-helpers.c
(modest_account_mgr_get_has_connection_specific_smtp): removed
(modest_account_mgr_get_use_connection_specific_smtp):
(modest_account_mgr_set_use_connection_specific_smtp): New
functions to set and get the state of the use_specific_smtp
gconf key
* src/maemo/easysetup/modest-easysetup-wizard.c
(create_account):
Save the actual state of the "Use connection-specific SMTP
servers" checkbox in gconf
* src/maemo/modest-account-settings-dialog.c
(modest_account_settings_dialog_set_account_name):
(save_configuration):
Save and restore the actual state of the "Use
connection-specific SMTP server" checkbox in gconf
Fixes NB#65993
pmo-trunk-r3009
Dirk-Jan C. Binnema [Fri, 17 Aug 2007 12:09:00 +0000 (12:09 +0000)]
Added fixes for week 33 post release, 17th august.
pmo-trunk-r3008
Murray Cumming [Fri, 17 Aug 2007 10:24:08 +0000 (10:24 +0000)]
2007-08-17 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c:
(check_and_offer_account_creation): Use gdk_thread_enter/leave(),
because this is called from idle handlers, to fix hangs afte the
wizard closes.
(find_message_by_url): Added a TODO comment about a crash that
happens when tinymail was built with DBC checks.
pmo-trunk-r3007
Murray Cumming [Thu, 16 Aug 2007 16:23:10 +0000 (16:23 +0000)]
2007-08-16 Murray Cumming <murrayc@murrayc.com>
* src/modest-search.c: (modest_search_folder):
* src/modest-search.h: Rename ModestSearch::before to start_date
and after to end_date, using the same names as the libogs struct
fields.
* src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
The start_date and end_date were swapped in the check. This
fixes date range searches, fixing projects.maemo.org bug NB#63407.
pmo-trunk-r3006
Murray Cumming [Thu, 16 Aug 2007 14:55:08 +0000 (14:55 +0000)]
2007-08-16 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-msg-view-window.h:
* src/gnome/modest-msg-view-window.c:
* src/maemo/modest-msg-view-window.c:
Added modest_msg_view_window_construct().
(modest_msg_view_window_new_with_header_model),
Added modest_msg_view_window_new_for_search_result),
Renamed modest_msg_view_window_new() to
modest_msg_view_window_new_for_attachment(),
and modest_msg_view_window_is_search_result(),
so we can explicitly know that the window is for an
attachment or a search result or a message from the list.
(modest_msg_view_window_view_attachment):
* src/modest-ui-actions.c: (open_msg_cb): Use the renamed function.
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
Use modest_msg_view_window_new_for_search_result().
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_delete_msg): Dim the delete button
for search results, fixing projects.maemo.org bug NB#63811.
pmo-trunk-r3005
Armin Burgmeier [Thu, 16 Aug 2007 14:26:12 +0000 (14:26 +0000)]
2007-08-16 Armin Burgmeier <armin@openismus.com>
* src/modest-ui-actions.c: Show a banner instead of a dialog when
renaming a folder fails, to stay consistent with what happens when
creating a folder fails.
* src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
slightly country loading from the mmc_mappings file, fixed a memory
leak.
pmo-trunk-r3004
Murray Cumming [Thu, 16 Aug 2007 11:45:58 +0000 (11:45 +0000)]
2007-08-16 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (volume_path_is_mounted):
Check the GnomeVFSVolume activation path instead of the device path,
so that the memory card is really really shown in the UI.
pmo-trunk-r3001
Murray Cumming [Thu, 16 Aug 2007 10:20:56 +0000 (10:20 +0000)]
2007-08-16 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(get_entered_account_title), (on_before_next), (entry_is_empty),
(create_account):
* src/maemo/modest-account-settings-dialog.c:
(get_entered_account_title), (on_button_signature), (check_data),
(save_configuration), (entry_is_empty):
Strip the account title of whitespace at the start and end before
using it or checking it. This means that an all-whitespace title
is not allowed, fixing projects.maemo.org bug NB#64977.
pmo-trunk-r3000
Dirk-Jan C. Binnema [Thu, 16 Aug 2007 08:16:31 +0000 (08:16 +0000)]
Added known issues and fixed bugs, week 33 pre release - 16th Aug.
pmo-trunk-r2999
Murray Cumming [Wed, 15 Aug 2007 16:15:13 +0000 (16:15 +0000)]
2007-08-15 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.h:
* src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
to modest_run_account_setup_wizard() and made it public.
* src/dbus_api/modest-dbus-callbacks.c:
(check_and_offer_account_creation), (on_idle_mail_to),
(on_idle_compose_mail), (on_idle_open_default_inbox):
Offer account creation if necessary, fixing projects.maemo.org
bug NB#63713.
pmo-trunk-r2998
Murray Cumming [Wed, 15 Aug 2007 15:06:41 +0000 (15:06 +0000)]
2007-08-15 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-recpt-editor.c:
(modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
to fix projects.maemo.org bug NB#63789.
pmo-trunk-r2997
Murray Cumming [Wed, 15 Aug 2007 13:55:01 +0000 (13:55 +0000)]
2007-08-15 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: Added volume_path_is_mounted().
(modest_tny_account_store_new): Properly detect the memory card at
startup, and add an account for it.
pmo-trunk-r2996
Dirk-Jan C. Binnema [Wed, 15 Aug 2007 12:52:04 +0000 (12:52 +0000)]
Added known issues and fixed bugs, week 33 pre release - 15th Aug.
pmo-trunk-r2995
Javier Fernandez Garcia-Boente [Tue, 14 Aug 2007 17:49:07 +0000 (17:49 +0000)]
* Close sort dialog after select sorting keys.
* Fixes NB#64682
pmo-trunk-r2994
Murray Cumming [Tue, 14 Aug 2007 13:50:27 +0000 (13:50 +0000)]
2007-08-14 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_new):
Commented out the MMC code again because it mistakenly detects
the card even when it isn't inserted.
pmo-trunk-r2992
Dirk-Jan C. Binnema [Tue, 14 Aug 2007 13:12:56 +0000 (13:12 +0000)]
Added known issues and fixed bugs, week 33 pre release - 14th Aug.
pmo-trunk-r2990
Murray Cumming [Tue, 14 Aug 2007 12:23:17 +0000 (12:23 +0000)]
2007-08-14 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_new):
Renabled the call to add_mmc_account() because I do not believe
it could be the cause of the mentioned hang (in scratchbox, where
there is no memory card), and because I have tested that it works
on the device.
pmo-trunk-r2989
Murray Cumming [Tue, 14 Aug 2007 10:59:57 +0000 (10:59 +0000)]
2007-08-14 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_new):
Comment out part of the last commit because it apparently causes
a hang.
pmo-trunk-r2983
Philip Van Hoof [Tue, 14 Aug 2007 10:59:28 +0000 (10:59 +0000)]
Bugfix for 63283
pmo-trunk-r2982
Javier Fernandez Garcia-Boente [Tue, 14 Aug 2007 10:22:33 +0000 (10:22 +0000)]
* Fixed a bug related with filter_row function and
recent new boolean field 'empty' added to header-view
priv structure.
pmo-trunk-r2981
Javier Fernandez Garcia-Boente [Tue, 14 Aug 2007 09:57:49 +0000 (09:57 +0000)]
* Emission of progress-changed signal is not alowed, because hang on
folder_copy_asunc was fixed.
* Set the correct path for mcc_mapping file (Fixes NB#61072)
* Fixed some bugs on dimming rules, to allow copy/cut/paste
of folders.
pmo-trunk-r2980
Murray Cumming [Tue, 14 Aug 2007 09:53:22 +0000 (09:53 +0000)]
2007-08-14 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: Added the add_mmc_account()
function to save some copy/pasting.
(modest_tny_account_store_new): If the memory card is mounted,
create an account for it at the start, instead of waiting for the
user to unmount it and mount it.
pmo-trunk-r2979
Javier Fernandez Garcia-Boente [Mon, 13 Aug 2007 18:14:01 +0000 (18:14 +0000)]
* Fixed some Gtk warnings at start.
pmo-trunk-r2974
Javier Fernandez Garcia-Boente [Mon, 13 Aug 2007 17:18:59 +0000 (17:18 +0000)]
* Fixed some bugs on dimming rules about copy/cur/paste folders.
* Check if folder is empty on POP accounts refreshing, due to
POP refresh operation does not emit notifications.
* Use filter_row function, called to hide marked as deleted
rows on header-view, to determine if folder is empty.
pmo-trunk-r2973
Philip Van Hoof [Mon, 13 Aug 2007 14:48:43 +0000 (14:48 +0000)]
Javier: if I remove this one, tny_folder_copy_async does not hang anymore
g_signal_emit (G_OBJECT (self), signals[PROGRESS_CHANGED_SIGNAL], 0, state, NULL);
https://projects.maemo.org/bugzilla/show_bug.cgi?id=63060
pmo-trunk-r2972
Murray Cumming [Mon, 13 Aug 2007 14:36:41 +0000 (14:36 +0000)]
2007-08-13 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-account-view.c: (on_account_changed):
Do not try to use the human-readable TnyAccount name instead of the
ID of the modest account to get the transport account. And unref
the transport account. This prevents a g_warning(), and a possible
ref leak.
pmo-trunk-r2971
Murray Cumming [Mon, 13 Aug 2007 14:14:09 +0000 (14:14 +0000)]
removed a g_debug
pmo-trunk-r2970
Murray Cumming [Mon, 13 Aug 2007 14:11:31 +0000 (14:11 +0000)]
2007-08-13 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c:
(modest_platform_set_update_interval): Handle the new
alarmd error to warn when alarmd is not running, as is the case in
scratchbox for me now because
Module /usr/lib/alarmd/libretu.so initialization failed
pmo-trunk-r2969
Murray Cumming [Mon, 13 Aug 2007 13:46:55 +0000 (13:46 +0000)]
2007-08-13 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-header-view-render.c:
(_modest_header_view_compact_header_cell_data):
NULL some strings after freeing them, trying to deal with
the double deletion found in projects.maemo.org bug 64183,
probably having no effect.
pmo-trunk-r2968
Murray Cumming [Mon, 13 Aug 2007 13:23:18 +0000 (13:23 +0000)]
2007-08-13 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
(create_page_incoming), (create_page_outgoing): Use a define
for the min and max port numbers.
(check_hildon_number_editor_and_warn_value_not_in_range),
(check_data): Do an extra check for an invalid port number, as needed
in projects.maemo.org bug #64275, when the number is cleared, but this
does not work due to bugs.maemo.org bug #1806.
pmo-trunk-r2967
Dirk-Jan C. Binnema [Mon, 13 Aug 2007 12:29:29 +0000 (12:29 +0000)]
Added known issues and fixed bugs, week 33 pre release - 13th Aug.
pmo-trunk-r2966
Murray Cumming [Mon, 13 Aug 2007 12:17:16 +0000 (12:17 +0000)]
2007-08-13 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
Comment out the debug warning about the unexpected D-Bus methods.
They are just annoying now.
* src/maemo/modest-platform.c:
(modest_platform_set_update_interval): Correct the D-Bus path, instead
of using a file path, though it did not seem to break things before.
It might be needed now:
Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
modest is not already running. This is the behaviour of the old client, and
Mox says it is what we should do for modest.
This closes projects.maemo.org bug NB#64327.
pmo-trunk-r2965
Dirk-Jan C. Binnema [Mon, 13 Aug 2007 12:17:09 +0000 (12:17 +0000)]
Added known issues and fixed bugs, week 33 pre release - 13th Aug.
pmo-trunk-r2964
Javier Fernandez Garcia-Boente [Mon, 13 Aug 2007 11:35:43 +0000 (11:35 +0000)]
* modest-header-view.c: Remove some commented and unsed code.
* modest-ui-actios.c: implemented some changes on
new_messages_arrieved callback, executed afte send&receive has
been completed, to check if folder is empty and new message
have arrived; this imlpies a change in main-view window style.
* Fixes: NB#57458
pmo-trunk-r2963
Dirk-Jan C. Binnema [Fri, 10 Aug 2007 13:33:53 +0000 (13:33 +0000)]
Changed the changelog to resolve some bugs issues, week 32 post release - 10th Aug.
pmo-trunk-r2962
Dirk-Jan C. Binnema [Fri, 10 Aug 2007 13:18:52 +0000 (13:18 +0000)]
Changed the changelog to resolve some bugs issues, week 32 post release - 10th Aug.
pmo-trunk-r2961
Dirk-Jan C. Binnema [Fri, 10 Aug 2007 12:13:22 +0000 (12:13 +0000)]
Added a few fixed bugs and release notes to the changelog, week 32 post release - 10th Aug.
pmo-trunk-r2960
Peter Csaszar [Thu, 9 Aug 2007 14:11:15 +0000 (14:11 +0000)]
modest-ui-actions.c: some alignment in the code
modest-ui-dimming-rules.c: some cleanup of unnecessary codes
modest-msg-view-window.c: partially fixes bug 60714, and have further
modifications. The concept is using signals of tree_model for any
change. If there is a change, dimming rules should be applied on
msg-view-window.
Not: There remains some bugs, which I do not know if registered on
bugzilla or not, but are near the same problems like 60714.
The tree_view (header_view) in main window might have new tree_model
due to some user actions and so 60714 bug become current again.
pmo-trunk-r2959
Javier Fernandez Garcia-Boente [Thu, 9 Aug 2007 11:31:33 +0000 (11:31 +0000)]
* Review fucntion 'has_retrieved_msgs' implementation
in order to use CACHED flag to determine wether one message
has been downloaded or not.
* Fixes: NB#62450
pmo-trunk-r2958
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 15:28:27 +0000 (15:28 +0000)]
* Add a confirmation dialog to Paste operation.
* Fixes: NB#63124
pmo-trunk-r2955
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 15:07:27 +0000 (15:07 +0000)]
* Fixed some warnings
pmo-trunk-r2954
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 15:04:19 +0000 (15:04 +0000)]
* Fixed some warnings.
pmo-trunk-r2953
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 14:30:35 +0000 (14:30 +0000)]
* Fixed some bug in new dimming rules approach.
pmo-trunk-r2950
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 14:11:07 +0000 (14:11 +0000)]
* Set focus on folder-view at startup to show correctly
the main window title.
* Fixes: NB#61815
pmo-trunk-r2949
Dirk-Jan C. Binnema [Wed, 8 Aug 2007 12:11:35 +0000 (12:11 +0000)]
Added a few fixed bugs and release notes to the changelog, week 32 pre release - 8th Aug.
pmo-trunk-r2948
Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 09:37:32 +0000 (09:37 +0000)]
* Implement optimizations on DimmingRules management.
* Copy/Cut/Paste dimming rules of Editor are not working fine;
it does not take into account if something was selected or not.
These changes on src/maemo/modest-msg-edit-window.c try to
solve these problems, with no success at this moment.
* Fixes: NB#64553
pmo-trunk-r2947
Dirk-Jan C. Binnema [Wed, 8 Aug 2007 07:29:48 +0000 (07:29 +0000)]
Added fixed bugs and release notes to the changelog, week 32 pre release - 8th Aug.
pmo-trunk-r2946
Javier Fernandez Garcia-Boente [Tue, 7 Aug 2007 19:24:47 +0000 (19:24 +0000)]
* Check folder type in folder comparison.
* Fixes: NB#63055
pmo-trunk-r2945
Javier Fernandez Garcia-Boente [Tue, 7 Aug 2007 18:05:24 +0000 (18:05 +0000)]
* Call send-queue-flush when account is edited and changed,
and also at startup.
pmo-trunk-r2944
Philip Van Hoof [Tue, 7 Aug 2007 10:13:53 +0000 (10:13 +0000)]
Fixing API changes
pmo-trunk-r2941
Javier Fernandez Garcia-Boente [Mon, 6 Aug 2007 18:34:14 +0000 (18:34 +0000)]
* fix some issues on progress-bar to show more pulses on
undetermined progress data.
* Define again a OPEN type mail-operation for cached messages.
* Fixes bug: NB#56201
pmo-trunk-r2940
Javier Fernandez Garcia-Boente [Mon, 6 Aug 2007 15:20:14 +0000 (15:20 +0000)]
* Set some g_return_if_fail because i notice some random
chrashed trying to add one account, when it gets the private
structure of ModestaccountView widget.
pmo-trunk-r2939
Javier Fernandez Garcia-Boente [Mon, 6 Aug 2007 14:57:51 +0000 (14:57 +0000)]
* Removed a g_return_if_fail because this function
is called from show_tollbar method with NULL in account
parameter.
pmo-trunk-r2938
Javier Fernandez Garcia-Boente [Mon, 6 Aug 2007 14:05:52 +0000 (14:05 +0000)]
* Fixed some bug on account_number_changed signal handler.
The fisrt parameter, account_name, was declared as string,
but account-remove, account-inserted, and account-changed
emmits a signal with a TnyAccount type parameter.
pmo-trunk-r2937
Dirk-Jan C. Binnema [Mon, 6 Aug 2007 13:59:37 +0000 (13:59 +0000)]
Added fixed bugs to the changelog, week 32 pre release - 6th Aug.
pmo-trunk-r2936
Philip Van Hoof [Mon, 6 Aug 2007 08:17:15 +0000 (08:17 +0000)]
2007-08-06 Philip Van Hoof <pvanhoof@gnome.org>
* GDK lock awareness
pmo-trunk-r2935
Johannes Schmid [Sat, 4 Aug 2007 14:15:36 +0000 (14:15 +0000)]
2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
* src/modest-text-utils.c:
Fixed invalid jump due to incorrect string/pointer
operation.
(See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
for details)
pmo-trunk-r2934
Jose Dapena Paz [Fri, 3 Aug 2007 22:20:13 +0000 (22:20 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_create_folder): now, if we push create
folder in a pop folder, unable to create folder information
banner is shown (fixes NB#64001).
pmo-trunk-r2933
Jose Dapena Paz [Fri, 3 Aug 2007 22:00:40 +0000 (22:00 +0000)]
* src/maemo/modest-account-settings-dialog.c:
* Now we show the "settings saved" or "settings" failed
information banners again (we were parenting it with the
dialog we were closing, so the dialog was not saved)
(fixes NB#63748).
pmo-trunk-r2932
Jose Dapena Paz [Fri, 3 Aug 2007 21:45:58 +0000 (21:45 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now the removing attachments banner is shown after 2 seconds
of progress of the operation, and not at the end of the
operation (fixes NB#63026).
pmo-trunk-r2931
Jose Dapena Paz [Fri, 3 Aug 2007 19:41:34 +0000 (19:41 +0000)]
* src/modest-text-utils.c:
* Now derived subject composes a string with no subject
also for a "" subject.
* src/widgets/modest-attachment-view.c:
* If subject is "", we also show no subject string
* src/modest-tny-msg.c:
* If we are forwarding, and the mail is formatted in html,
we forward the message as attachment (fixes NB#62261).
* src/modest-formatter.[ch]:
* Fixed modest_formatter_attach, to attach the TnyMsg instead
of a mime part.
pmo-trunk-r2930
Jose Dapena Paz [Fri, 3 Aug 2007 18:43:54 +0000 (18:43 +0000)]
Improvements in focus management of Check names operation
(fixes NB#59427).
* src/widgets/modest-recpt-editor.[ch]:
* New method (modest_recpt_editor_has_focus). This is used
to be able to know if a recipient editor text view is
focused.
* src/maemo/modest-address-book.c:
* Removed all recipient editor focus management. Now we rely
on the window implementation.
* src/maemo/modest-msg-edit-window.c:
* Now we set focus of the failing recipient editor in check
names if it fails.
* If check names does not fail, and focus is in a recipient
field, it does not change the focus from them to to: field.
pmo-trunk-r2929
Jose Dapena Paz [Fri, 3 Aug 2007 18:14:23 +0000 (18:14 +0000)]
* src/widgets/modest-msg-view.c:
* (idle_readjust_scroll): hackish solution to force a
scroll readjustment (setting 1.0 and 0.0 in the same handler
and after showing the widget for the first time). This way
we don't get a broken scroll with stylus (fixes NB#62820).
pmo-trunk-r2928
Javier Fernandez Garcia-Boente [Fri, 3 Aug 2007 15:26:09 +0000 (15:26 +0000)]
* Added some coments/mark in all gdk_threads_enter
to document what is their purpose on each funciton.
pmo-trunk-r2927
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 14:17:06 +0000 (14:17 +0000)]
* fix NB#64931, cleaning up the details fields a bit.
pmo-trunk-r2926
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 12:24:40 +0000 (12:24 +0000)]
removed a released bug from the changelog, week 31 post release - 3rd Aug.
pmo-trunk-r2925
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 12:01:21 +0000 (12:01 +0000)]
Added new fixes to changelog, week 31 post release - 3rd Aug.
pmo-trunk-r2924
Peter Csaszar [Fri, 3 Aug 2007 10:22:59 +0000 (10:22 +0000)]
Remove of an false warning.
pmo-trunk-r2922
Peter Csaszar [Fri, 3 Aug 2007 10:09:40 +0000 (10:09 +0000)]
An ref/unref problem resolved, but there might be another one.
pmo-trunk-r2921
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 09:52:31 +0000 (09:52 +0000)]
* check for a valid foldername
Fixes: NB#58923
pmo-trunk-r2920
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 09:47:02 +0000 (09:47 +0000)]
* add a function to check for valid folder name;
we do a comprehensive test, also disallowing names which are not
valid on Windows filesystems (like AUX, or ':'); thus, it
should also work on MMC, and also make sure that user-created local folders
can be moved there.
pmo-trunk-r2919
Peter Csaszar [Fri, 3 Aug 2007 08:00:02 +0000 (08:00 +0000)]
fixed crash:modest-mail-operation.c:on_refresh_folder:priv==NULL
pmo-trunk-r2917
Jose Dapena Paz [Thu, 2 Aug 2007 20:52:41 +0000 (20:52 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now we don't show an information banner on trying to view
a purged attachment (fixes NB#63498).
pmo-trunk-r2916
Javier Fernandez Garcia-Boente [Thu, 2 Aug 2007 20:21:44 +0000 (20:21 +0000)]
* Move tny_folder_sync after remove operation and define it
on modest-ui-actions, when all messages have been removed.
* Review progress-bar widget to get more information when
undetermined data is come back from camel-operation.
* Move header_view_refilter operation, defined in
folder_monitor_update to main_window, which is an observer
of headers view. Sometimes, refilter operation was done before
model was updated, causing several crashes.
pmo-trunk-r2915
Jose Dapena Paz [Thu, 2 Aug 2007 20:06:31 +0000 (20:06 +0000)]
* src/widgets/modest-attachment-view.c:
* Now get size thread worker is not anymore a mail operation,
so the implementation is moved here. This should prevent
some bad issues with getting uncancellable operations in
mail operation queue, and then, causing hanges.
* src/modest-mail-operation.[ch]:
* Now get mime part size is not anymore a mail operation, so
this has been removed from here.
pmo-trunk-r2914
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 16:57:15 +0000 (16:57 +0000)]
* optimize _modest_account_mgr_get_account_keyname, which was showing
at the top of the startup profiles. now, no longer escape/allocate strings
if that's not needed
pmo-trunk-r2913
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 16:40:07 +0000 (16:40 +0000)]
* fix the checks a bit; don't try to top the window before checking it has been created
pmo-trunk-r2912
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 16:38:57 +0000 (16:38 +0000)]
* let the window manager close only after the mail-operations-queue is empty,
recheck every 3 secs, and close anyway after a given timeout (30 sec. now).
this should help with the bugs were mail was corrupted when sending it.
pmo-trunk-r2911
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 13:39:00 +0000 (13:39 +0000)]
* when the window-manager is asked for the main_window, and none such
exists, create one in place. the fix in modest_window_mgr is trivial,
but it would crash immediately because of old signal handlers still
be invoked; now, we clear all signal handlers when destroy a main_window
Fixes: NB#59752
pmo-trunk-r2910
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 13:35:22 +0000 (13:35 +0000)]
* add modest-signal-mgr, some small utility functions for gobject to
remember what g_signal_connects they did, and make sure they are all
disconnected when you finalize the object; this was needed for a bugfix
pmo-trunk-r2909
Jose Dapena Paz [Thu, 2 Aug 2007 10:55:54 +0000 (10:55 +0000)]
* src/modest-tny-send-queue.c:
* Now it shows a "message sent" information banner on successing
to send a message (fixes NB#63356).
pmo-trunk-r2908
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 10:48:55 +0000 (10:48 +0000)]
Added new fixes to changelog, will be part of week 32 release- week 31 - 2nd Aug.
pmo-trunk-r2907
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 07:20:58 +0000 (07:20 +0000)]
* with the latest tinymail, there is no need to force a refresh
of the folder model anymore, when the account name changes.
pmo-trunk-r2905
Jose Dapena Paz [Thu, 2 Aug 2007 06:41:08 +0000 (06:41 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_xfer_messages_from_move_to): now we
show an information banner on trying to move messages to a pop
folder as this is not allowed (fixes NB#63285).
pmo-trunk-r2904
Jose Dapena Paz [Thu, 2 Aug 2007 06:04:26 +0000 (06:04 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_on_delete_folder): now we focus inbox
folder on finishing the delete folder operation (fixes
NB#63239).
pmo-trunk-r2903
Javier Fernandez Garcia-Boente [Wed, 1 Aug 2007 21:36:50 +0000 (21:36 +0000)]
* Review Move_to dimming rules to check for ROOT folders,
or INBOX or SENT, DRAFT and OUTBOX special folder.
* Fixes: NB#62939
pmo-trunk-r2902
Jose Dapena Paz [Wed, 1 Aug 2007 18:30:06 +0000 (18:30 +0000)]
* src/widgets/modest-recpt-editor.c:
* Modified the maximum number of lines, to 1024. Practically,
it means the field has an "unlimited" number of lines
(fixes NB#63209).
pmo-trunk-r2901
Murray Cumming [Wed, 1 Aug 2007 18:29:35 +0000 (18:29 +0000)]
2007-08-01 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_account_mgr_get_first_account_name(),
using code from modest_account_mgr_set_first_account_as_default().
* src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
(account_number_changed): Call set_at_least_one_account_visible() so that
the first account is visible when first added, without the user having to
use the View menu.
I do wonder how this worked before.
pmo-trunk-r2900
Jose Dapena Paz [Wed, 1 Aug 2007 18:01:10 +0000 (18:01 +0000)]
* src/modest-text-utils.c:
* (modest_text_utils_validate_email_address): a domain part
that finishes with a dot (for example "a@b.") is not valid
(fixes NB#63204).
pmo-trunk-r2899
projects / modest / log