Murray Cumming [Wed, 13 Jun 2007 13:46:12 +0000 (13:46 +0000)]
2007-06-13 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
Remove unnecessary lib/include, though it is good in principle when needed.
* src/modest-init.c: (modest_init_one_local_folder),
(modest_init_local_folders):
* src/modest-init.h: Initialize the .modest library for memory cards,
instead of just doing nothing for them. This should allow us to create
folders there, fixing projects.maemo.org bug NB#59297.
pmo-trunk-r2208
Sergio Villar Senin [Wed, 13 Jun 2007 13:35:31 +0000 (13:35 +0000)]
* Follow the 30/70 rule for the main paned separation position when there is no configuration set
pmo-trunk-r2207
Sergio Villar Senin [Wed, 13 Jun 2007 13:19:19 +0000 (13:19 +0000)]
* Moved back the contents style code to the UI actions
pmo-trunk-r2205
Murray Cumming [Wed, 13 Jun 2007 12:50:33 +0000 (12:50 +0000)]
2007-06-13 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
(libmodest_dbus_client_compose_mail),
(libmodest_dbus_client_open_message),
(libmodest_dbus_client_send_and_receive),
(libmodest_dbus_client_open_default_inbox): Improved debug messages.
* src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
(on_idle_open_message), (modest_dbus_req_handler),
(search_result_to_message), (modest_dbus_req_filter):
* src/modest-search.c: (add_hit), (modest_search_folder),
(modest_search_all_accounts): Improved debug messages.
* tests/dbus_api/test_open_message.c: (main): Improved comments.
* src/modest-tny-account-store.c:
(modest_tny_account_store_get_tny_account_by): Initialize a variable to
fix the build.
pmo-trunk-r2202
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 11:15:49 +0000 (11:15 +0000)]
Comment 'msg-sending' signal handler, waiting for patch approval
on tinymail camel send queues.
pmo-trunk-r2200
Sergio Villar Senin [Wed, 13 Jun 2007 11:03:46 +0000 (11:03 +0000)]
* Fixes NB#59753, the account that is created is now visible if it's the unique account
* The visible account key is removed if the currently visible account is deleted
* the View->AccountX option to view a particular account works again
* Fixed a bug when opening messages that are already opened
* The folder view now listens to account-remove signal
* refactored modest_tny_account_store_get_tny_account_by_* in a single function
* Fixed a bug when removing the visible account, now the default one is selected as the new visible account
pmo-trunk-r2198
Philip Van Hoof [Wed, 13 Jun 2007 10:50:40 +0000 (10:50 +0000)]
Initialization improvements
pmo-trunk-r2197
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 09:15:01 +0000 (09:15 +0000)]
* Fixed bug in _selected_msg_sent_in_progress function,
cause an invalid g_free over an TnyIterator object.
pmo-trunk-r2196
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 09:02:33 +0000 (09:02 +0000)]
* Remove a g_return_if_fail in _selected_msg_sent_in_progress because
this function is allowed now for both, main and msg view window.
pmo-trunk-r2195
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 08:48:42 +0000 (08:48 +0000)]
* Added two new signal handlers to detect when messages are bieng processed to be sent
and when they have been finnaly sent.
* Add new dimming rules to detect sending operation in progress.
* Fixes: NB#60176
pmo-trunk-r2194
Philip Van Hoof [Wed, 13 Jun 2007 08:32:41 +0000 (08:32 +0000)]
Initialization speedup
pmo-trunk-r2193
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 06:59:20 +0000 (06:59 +0000)]
* Added a new function to check selected folder is an MMC or POP root.
* Fixes: NB#59433
pmo-trunk-r2191
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 16:33:43 +0000 (16:33 +0000)]
* updated the changelog
pmo-trunk-r2189
Murray Cumming [Tue, 12 Jun 2007 16:19:29 +0000 (16:19 +0000)]
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_server_accounts):
Call modest_tny_local_folders_account_add_merged_outbox_folders()
even when there are no accounts, so that the Outbox folder is always
visible. This fixes projects.maemo.org bug NB#60158.
pmo-trunk-r2188
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 16:15:22 +0000 (16:15 +0000)]
* Updated the changelog with the lates fixes and know issues.
pmo-trunk-r2187
Javier Fernandez Garcia-Boente [Tue, 12 Jun 2007 15:33:47 +0000 (15:33 +0000)]
* Fixes: NB#60332
pmo-trunk-r2186
Javier Fernandez Garcia-Boente [Tue, 12 Jun 2007 15:17:11 +0000 (15:17 +0000)]
Fixes: NB#60186
pmo-trunk-r2185
Javier Fernandez Garcia-Boente [Tue, 12 Jun 2007 14:32:29 +0000 (14:32 +0000)]
I forgot to upload this file.
pmo-trunk-r2184
Javier Fernandez Garcia-Boente [Tue, 12 Jun 2007 14:29:46 +0000 (14:29 +0000)]
* Fixed bug in empty_view of headers treeview when selected folder is empty.
* Fixes: NB#60141, NB#60144
pmo-trunk-r2183
Philip Van Hoof [Tue, 12 Jun 2007 14:16:46 +0000 (14:16 +0000)]
Initialization speedups
pmo-trunk-r2182
Sergio Villar Senin [Tue, 12 Jun 2007 14:14:54 +0000 (14:14 +0000)]
* Fixed a bug when trying to launch modest without accounts
pmo-trunk-r2181
Murray Cumming [Tue, 12 Jun 2007 13:58:34 +0000 (13:58 +0000)]
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c: (create_details_widget):
Use the mcen_va_never logical ID.
pmo-trunk-r2180
Murray Cumming [Tue, 12 Jun 2007 11:25:18 +0000 (11:25 +0000)]
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_open_default_inbox), (on_open_default_inbox),
(modest_dbus_req_handler):
Added a new OpenDefaultInbox method.
* libmodest-dbus-client/libmodest-dbus-client.h:
* libmodest-dbus-client/libmodest-dbus-client.c:
Added libmodest_dbus_client_open_default_inbox() to call the new
dbus method. This should be useful to projects.maemo.org bug NB#57214,
though it should maybe be used by a new osso-email-interface function.
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_open_default_inbox.c: Added a test for the new
function.
pmo-trunk-r2179
Murray Cumming [Tue, 12 Jun 2007 10:46:25 +0000 (10:46 +0000)]
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c: (on_key_change): Append to the list, not to
NULL, so that the signals get all the keys. This should not actually
change any behaviour because we currently update everything when anything
changes.
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-folder-view.c: (text_cell_data),
(icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
(find_inbox_iter): If tinymail tells us that the folder is
a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
This causes the inbox to be selected at startup, fixing part of
projects.maemo.org bug NB#56305.
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_tools_smtp_servers):
* src/modest-ui-dimming-rules.h: Added a callback function to dim
the SMTP servers menu item.
* src/maemo/modest-main-window-ui-dimming.h: Used the function, so
that the SMTP Servers menu item is dimmed when there are no accounts,
as a future version of the UI spec will require. This fixes
projects.maemo.org bug NB#56305.
pmo-trunk-r2178
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:37:55 +0000 (10:37 +0000)]
* remove my debug g_warnings from modest_tny_account_store
pmo-trunk-r2177
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:36:32 +0000 (10:36 +0000)]
* small cosmetic cleanups, leak fix for modest_account_mgr_set_first_account_as_default
pmo-trunk-r2176
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:34:12 +0000 (10:34 +0000)]
* use modest_account_mgr_set_first_account_as default; remove dupl code
pmo-trunk-r2175
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:32:57 +0000 (10:32 +0000)]
* no need to set a new default account explicitely anymore
pmo-trunk-r2174
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:31:24 +0000 (10:31 +0000)]
* set a new default account when removing the current one
pmo-trunk-r2173
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:29:19 +0000 (10:29 +0000)]
* add libnotify dep
pmo-trunk-r2172
Jose Dapena Paz [Tue, 12 Jun 2007 09:31:02 +0000 (09:31 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now it updates the window title with the subject (fixes NB#58040).
pmo-trunk-r2171
Jose Dapena Paz [Tue, 12 Jun 2007 08:31:31 +0000 (08:31 +0000)]
* src/maemo/modest-msg-view-window.c:
* Added insensitive press handlers for view attachment and save attachment
* Now Find Toolbar sets focus on itself on being shown.
pmo-trunk-r2170
Sergio Villar Senin [Tue, 12 Jun 2007 08:09:04 +0000 (08:09 +0000)]
* Fixed a reference leak in the main window
* The update_model function of the folder view is now public
* The main window now unregisters some signals that was causing a lot of problems
* The Move to dialog now shows contents even if the main window do not exists. Fixes NB#59468
pmo-trunk-r2169
Sergio Villar Senin [Tue, 12 Jun 2007 07:10:41 +0000 (07:10 +0000)]
* The open menu item of the header view CSM now opens a message. Fixes NB#60246
pmo-trunk-r2168
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 07:00:21 +0000 (07:00 +0000)]
* Updated the changelog with fixes made on Week 24 day 2
pmo-trunk-r2167
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 06:49:36 +0000 (06:49 +0000)]
* add a forgotten g_object_uref(iter) to _modest_ui_actions_open
pmo-trunk-r2166
Johannes Schmid [Mon, 11 Jun 2007 21:21:33 +0000 (21:21 +0000)]
2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/modest-maemo-utils.c:
(modest_maemo_utils_get_supported_secure_authentication_methods):
Added label to dialog instead of unreadable title
* src/maemo/modest-main-window.c: (sync_accounts_cb),
(modest_main_window_new):
Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
dead code.
* src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
* src/modest-account-mgr.h:
Added method to avoid code duplication
* src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
(modest_ui_actions_on_send_receive):
Use modest_account_mgr_has_accounts
pmo-trunk-r2165
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 17:08:21 +0000 (17:08 +0000)]
* fix crasher when cancelling all operations ('operations_to_cancel' needs to be initialized)
pmo-trunk-r2164
Murray Cumming [Mon, 11 Jun 2007 16:50:17 +0000 (16:50 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-presets.c:
(modest_presets_get_info_server_security): Do not report secure auth
if there is none.
* src/modest-protocol-info.c: Use the defines for the gconf key names
for secure authentication. This was not working because we were writing
Password and reading password, and the check was case sensitive.
With this, gmail now works for receiving and sending when created via
easysetup.
pmo-trunk-r2163
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 16:28:08 +0000 (16:28 +0000)]
* do a disconnect/reconnect with pop-servers upon send-receive, as they may not report new messages otherwise. needs the latest tinymail
pmo-trunk-r2162
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 16:26:20 +0000 (16:26 +0000)]
* do some extra checking to prevent a random segfault sometimes; small cleanup
pmo-trunk-r2161
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 16:25:03 +0000 (16:25 +0000)]
* in some cases, cancel_all would core, apparently because cur->data was invalid.
now, we don't crash, but give an error on stderr instead
pmo-trunk-r2160
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 16:23:20 +0000 (16:23 +0000)]
* some crash fixes - in some cases, modest core'd because of errors when copying/moving
pmo-trunk-r2159
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 15:48:29 +0000 (15:48 +0000)]
* Updated the changelog with fixes made on Week 24 day 01.
pmo-trunk-r2158
Murray Cumming [Mon, 11 Jun 2007 15:43:20 +0000 (15:43 +0000)]
Murray Cumming <murrayc@murrayc.com>
pmo-trunk-r2157
Sergio Villar Senin [Mon, 11 Jun 2007 14:32:05 +0000 (14:32 +0000)]
* Changed the order of some CSM menu entries. This Fixes NB#60247
pmo-trunk-r2154
Murray Cumming [Mon, 11 Jun 2007 13:30:29 +0000 (13:30 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c: (modest_platform_on_new_msg):
Prevent use of the new notification feature for now, because it currently
shows one dialog for each new email, which is annoying.
pmo-trunk-r2153
Murray Cumming [Mon, 11 Jun 2007 12:29:24 +0000 (12:29 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
(easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
when no country was selected, so that we show the global ones.
* src/maemo/easysetup/modest-presets.c:
(modest_presets_get_providers): Return only the global providers, not
all providers when mmc=0 was requested.
pmo-trunk-r2152
Jose Dapena Paz [Mon, 11 Jun 2007 12:17:29 +0000 (12:17 +0000)]
* src/modest-attachments-view.c:
* Fixed the calculation of the attachment clicked, that broke
all the widget clicking code (fixes NB#59462).
pmo-trunk-r2151
Murray Cumming [Mon, 11 Jun 2007 11:42:14 +0000 (11:42 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
(easysetup_provider_combo_box_fill): Remove debug code that showed the
provider ID in the combo.
* src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
Do not show the page numbers, because it would be confusing when we add
the 2 extra pages for the custom setup, when the user chooses the Other
provider. This fixes projects.maemo.org bug NB#59028
* src/modest-init.c: (modest_init_init_core),
(modest_init_local_folders):
* src/modest-init.h:
* src/modest-tny-account.c:
(modest_tny_account_new_for_local_folders): Do not create default folders
for the memory card. This should fix projects.maemo.org bug NB#59328.
pmo-trunk-r2150
Jose Dapena Paz [Mon, 11 Jun 2007 11:32:13 +0000 (11:32 +0000)]
Fix for NB#58037. Not reply to all removes the user's address. To do it
first it gets the address itself (the a@b.c part), and then it removes
all the Cc: addresses that match with this part:
* src/modest-text-utils.c:
* Now remove_address takes into account the email address
instead of the full address string.
pmo-trunk-r2149
Sergio Villar Senin [Mon, 11 Jun 2007 11:08:36 +0000 (11:08 +0000)]
* Added a first implementation for new messages notifications
pmo-trunk-r2148
Jose Dapena Paz [Mon, 11 Jun 2007 11:01:23 +0000 (11:01 +0000)]
Fix for NB#59458 (should dim sort button when the selected folder
is a root folder).
* src/maemo/modest-main-window-ui-dimming.h:
* Added dimming handler for sort dialog actions.
* src/modest-ui-dimming-rules.[ch]:
* Added dimming handler for sort dialog actions. Should
be dimmed when the folder is a root folder.
Restored the UI menu actions available in viewer.
* src/maemo/ui/modest-msg-view-window-ui.xml:
* Readded show toolbar actions.
* Readded find in page actions.
pmo-trunk-r2147
Murray Cumming [Mon, 11 Jun 2007 08:19:49 +0000 (08:19 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c: (modest_account_mgr_finalize):
Free the changed_conf_keys string items. They are already freed in the
idle handler if that runs first.
pmo-trunk-r2145
Sergio Villar Senin [Mon, 11 Jun 2007 08:11:07 +0000 (08:11 +0000)]
* Removed a TODO
* Fixed the account manager new batch notification system, it was not working
* Do not reload the accounts if only the last-updated key has changed, it was working but it seems that somebody commented it
pmo-trunk-r2144
Murray Cumming [Mon, 11 Jun 2007 07:43:23 +0000 (07:43 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested): Check that the server name
is not NULL, because I just saw a password dialog with (null) as the
server name.
* src/modest-tny-folder.[h|c]: Added
modest_tny_folder_is_memory_card_folder().
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
menu item for memory cards, as per the UI spec (section 7.4). This should
fix projects.maemo.org bug NB#59297.
pmo-trunk-r2143
Murray Cumming [Mon, 11 Jun 2007 06:45:10 +0000 (06:45 +0000)]
fixed a typo.
pmo-trunk-r2142
Johannes Schmid [Sun, 10 Jun 2007 18:25:17 +0000 (18:25 +0000)]
2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/modest-main-window.c: (sync_accounts_cb):
Fixed projects.maemo.org bug NB#58576 (not yet activated as there
is another problem with the code, see Murray\'s comment at line 772)
pmo-trunk-r2141
Dirk-Jan C. Binnema [Sun, 10 Jun 2007 18:06:21 +0000 (18:06 +0000)]
* add (c)-headers, forgotten g_object_unref
pmo-trunk-r2140
Johannes Schmid [Sun, 10 Jun 2007 17:44:43 +0000 (17:44 +0000)]
2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/modest-main-window.c: (sync_accounts_cb):
Fixed projects.maemo.org bug NB#56472 (not yet activated as there
is another problem with the code, see Murray\'s comment at line 772)
pmo-trunk-r2139
Dirk-Jan C. Binnema [Fri, 8 Jun 2007 16:17:28 +0000 (16:17 +0000)]
* partial fix for NB#58220, waiting for desktop now
pmo-trunk-r2138
Murray Cumming [Fri, 8 Jun 2007 16:09:26 +0000 (16:09 +0000)]
2007-06-08 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-country-combo-box.h:
* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
(on_model_foreach_release), (easysetup_country_combo_box_finalize),
(load_from_file), (easysetup_country_combo_box_init),
(easysetup_country_combo_box_get_active_country_ids),
(on_model_foreach_select_id): Store a GSList* of IDs in the model row,
instead of just one ID, to avoid duplicate country names in the UI.
* src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
(easysetup_provider_combo_box_fill): Adapt to use a list rather than
a single ID, avoiding duplicate providers.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_combo_account_country): Adapt to use a list.
pmo-trunk-r2137
Dirk-Jan C. Binnema [Fri, 8 Jun 2007 14:48:05 +0000 (14:48 +0000)]
* updated the changelog with six new bug fixes.
pmo-trunk-r2135
Sergio Villar Senin [Fri, 8 Jun 2007 14:08:05 +0000 (14:08 +0000)]
* Fixed a mistake in the last commit thanks to Murray's good sight
pmo-trunk-r2134
Sergio Villar Senin [Fri, 8 Jun 2007 13:49:22 +0000 (13:49 +0000)]
* Deleted a priv .c file, it's enough with the .h file to make their methods protected
* Fixed a crasher related to DBUS when setting the last update value
* Added an emission of the account_removed signal
* Fixes NB#56420, the account cache is now cleared when an account is removed
pmo-trunk-r2132
Murray Cumming [Fri, 8 Jun 2007 12:45:59 +0000 (12:45 +0000)]
2007-06-08 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
keys changed in the last X seconds.
* src/modest-account-mgr.h:
* src/modest-account-mgr.c: (on_timeout_notify_changes),
(on_key_change), (modest_account_mgr_class_init),
(modest_account_mgr_init), (modest_account_mgr_finalize):
As the keys are changed, save them in a GSList* and signal that GSList*
further every X seconds, to batch changes, to allow us to do just one
update per batch. This should fix bug projects.maemo.org bug NB#56472 and
bug NB#56941 and other (UI-blocking) delays when changing account settings.
* src/modest-tny-account-store.c: (on_account_changed): Adapted to
changed signal signature.
* src/modest-conf.c: (modest_conf_set_list),
(modest_conf_on_change): Reenable notification.
(modest_conf_maemo_fake_on_change): Comment out the hack that
notified immediately instead of asynchronously.
* src/widgets/modest-account-view.h:
* src/widgets/modest-account-view.c:
(update_account_view): Select the previously-selected account ID,
if possible. This fixes projects.maemo.org bug NB#56933.
(on_account_changed), (on_account_removed),
(modest_account_view_select_account):
Remove the block/unblock functions
because they were not useful.
* src/maemo/modest-account-view-window.c:
(on_delete_button_clicked), (on_edit_button_clicked),
(on_new_button_clicked): Remove the use of the non-working block/unblock.
pmo-trunk-r2130
Javier Fernandez Garcia-Boente [Fri, 8 Jun 2007 09:59:04 +0000 (09:59 +0000)]
* Fixes: NB#59378, NB#59389
* Implemented some pending dimming rules
pmo-trunk-r2129
Philip Van Hoof [Fri, 8 Jun 2007 09:45:33 +0000 (09:45 +0000)]
Added some comments
pmo-trunk-r2128
Murray Cumming [Fri, 8 Jun 2007 09:39:31 +0000 (09:39 +0000)]
2007-06-08 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Improve the error dialog to show Incorrect Account Settings, which seems
clearer, and say that the internal error message (to be removed from the
dialog later) is often misleading.
I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account): Uncomment the printf of the
URL because this is so useful for debugging on the device.
* src/widgets/modest-serversecurity-combo-box.c:
(modest_serversecurity_combo_box_fill): Correct a logical ID
pmo-trunk-r2127
Philip Van Hoof [Fri, 8 Jun 2007 09:19:28 +0000 (09:19 +0000)]
In stead of using tny_folder_refresh, use tny_folder_poke_status in case folders don't have to be fully downloaded
pmo-trunk-r2126
Jose Dapena Paz [Fri, 8 Jun 2007 09:16:49 +0000 (09:16 +0000)]
* src/maemo/modest-main-window.c:
* Added search messages ui action handler to "Search..." folder
CSM (fixes NB#59191).
pmo-trunk-r2125
Sergio Villar Senin [Fri, 8 Jun 2007 08:37:55 +0000 (08:37 +0000)]
* Fixes NB#55338
pmo-trunk-r2123
Murray Cumming [Fri, 8 Jun 2007 08:10:00 +0000 (08:10 +0000)]
2007-06-08 Murray Cumming <murrayc@murrayc.com>
* src/modest-mail-operation.c:
(modest_mail_operation_send_new_mail):
Added a comment about a nasty but apparently harmless message. Details
added to the wiki g_warnings() page.
pmo-trunk-r2122
Jose Dapena Paz [Fri, 8 Jun 2007 08:08:47 +0000 (08:08 +0000)]
* src/modest-mail-operation.c:
* ..._send_new_mail: added support to store the priority
flags in mails sent. This is done adding the flags to
the TnyHeader used to send the mail.
* ..._save_to_drafts: same as in send_new_mail. Added support
to set the priority flags (fixes NB#59253).
pmo-trunk-r2121
Murray Cumming [Fri, 8 Jun 2007 07:38:25 +0000 (07:38 +0000)]
2007-06-08 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
(modest_tny_send_queue_class_init):
Do not use the priv struct because it is empty, to avoid g_warnings
about a non-existant priv struct.
* src/modest-tny-account-store.c:
(modest_tny_account_store_get_server_account),
(modest_tny_account_store_get_transport_account_for_open_connection
): Do not try to get transport server accounts for local folders,
because they don't have any. This avoids a g_warning().
* src/maemo/modest-main-window.c:
(modest_main_window_notify_send_receive_initied),
(on_configuration_key_changed):
* src/maemo/modest-msg-edit-window.c: (on_delete_event):
* src/modest-defs.h:
* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
* src/modest-tny-account-store.h:
* src/modest-tny-account.c:
(modest_tny_account_get_special_folder),
(modest_tny_account_new_for_local_folders),
(modest_tny_account_new_for_per_account_local_outbox_folder):
* src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
* src/modest-tny-local-folders-account.c:
(add_account_folders_to_merged_folder):
* src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
(reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
(modest_ui_actions_on_send):
* src/widgets/modest-folder-view.c: (update_model):
Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
modest_tny_account_store_get_tny_account_by_account() to
modest_tny_account_store_get_server_account() to make the code clearer.
pmo-trunk-r2120
Sergio Villar Senin [Fri, 8 Jun 2007 07:07:54 +0000 (07:07 +0000)]
* Fixes NB#59451
pmo-trunk-r2116
Dirk-Jan C. Binnema [Fri, 8 Jun 2007 06:39:19 +0000 (06:39 +0000)]
* Updated changelog with the lastest fixes in bugzilla
pmo-trunk-r2114
Jose Dapena Paz [Thu, 7 Jun 2007 19:54:25 +0000 (19:54 +0000)]
Added support for opening the addressbook from the main window
through menu (fixes bug NB#57590):
* src/modest-platform.h:
* Added method to show the addressbook UI.
* src/modest-ui-actions.[ch]:
* Add action handler to open the addressbook UI.
* src/maemo/modest-main-window-ui.h:
* Add callback handler to show addressbook from main
window menu.
* src/maemo/modest-platform.c:
* Added implementation to show the addressbook
from modest using osso rpc.
pmo-trunk-r2113
Jose Dapena Paz [Thu, 7 Jun 2007 17:26:27 +0000 (17:26 +0000)]
Added implementation of "Find in page" in editor. This, with other
previous fixes, fixes NB#56983.
* src/widgets/modest-msg-edit-window.h:
* New function ..._toggle_find_toolbar, to show/hide the
toolbar.
* src/widgets/modest-msg-edit-window-ui.h:
* Added default callback for changing find toolbar
visibility.
* src/modest-ui-actions.[ch]:
* Added action ..._on_toggle_find_in_page, for responding
to find in page toggle, and showing or hiding the find
toolbar in the editor.
* src/maemo/modest-msg-edit-window.c:
* Added find toolbar support with its callbacks. This
enables the user to search strings in the text. Also
made the scroll update properly when the found selection
changes.
* src/maemo/modest-msg-edit-window-ui.xml:
* Added separator between "remove attachments" action and
the attachment insertion actions.
pmo-trunk-r2112
Dirk-Jan C. Binnema [Thu, 7 Jun 2007 15:59:43 +0000 (15:59 +0000)]
* don't do autocaps in to/cc/bcc after tall...
pmo-trunk-r2111
Marcus Bauer [Thu, 7 Jun 2007 15:46:41 +0000 (15:46 +0000)]
2007-06-07 Marcus Bauer <marcusb@openismus.com>
* src/dbus_api/modest-dbus-api.h:
changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive):
added g_warning in case the file to be attached does not exist
* tests/dbus_api/test_compose_mail.c: (main):
removed obsolete comment, added generic files as test case
pmo-trunk-r2110
Murray Cumming [Thu, 7 Jun 2007 15:27:18 +0000 (15:27 +0000)]
2007-06-07 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_server_accounts):
Create the local folders account only once, not once for each outbox, and
not only when there are some outboxes.
pmo-trunk-r2109
Dirk-Jan C. Binnema [Thu, 7 Jun 2007 15:24:30 +0000 (15:24 +0000)]
* turn on autocapitalization for the address widgets; this fix the bug once autocapitalization works
in general...
pmo-trunk-r2108
Javier Fernandez Garcia-Boente [Thu, 7 Jun 2007 15:23:38 +0000 (15:23 +0000)]
* Fixes: NB#59805
* Implement dimmig rules for Header View context sensitive menus.
pmo-trunk-r2107
Murray Cumming [Thu, 7 Jun 2007 14:56:23 +0000 (14:56 +0000)]
2007-06-07 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-folder-view.c: (update_model): Comment out some
code that is causing a crash at startup. Sergio says that he is fixing this.
pmo-trunk-r2106
Dirk-Jan C. Binnema [Thu, 7 Jun 2007 14:22:03 +0000 (14:22 +0000)]
* set the focus correctly on the global settings tabs; this fixes *major* bug NB#58756
pmo-trunk-r2105
Javier Fernandez Garcia-Boente [Thu, 7 Jun 2007 14:08:32 +0000 (14:08 +0000)]
* Fixes: NB#56474
* New dimmig rule for tools menu options
pmo-trunk-r2102
Johannes Schmid [Thu, 7 Jun 2007 13:45:24 +0000 (13:45 +0000)]
2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
* src/maemo/modest-account-settings-dialog.c:
(create_page_outgoing),
(modest_account_settings_dialog_set_account_name),
(save_configuration):
- Fixed handling of the \"Use secure authentication\" toggle to comply with
the ui specification. See also projects.maemo.org bug NB#58400
- Restore the Secure connection setting combo correctly when loading
the settings dialog
* src/maemo/modest-maemo-utils.c:
(on_camel_account_get_supported_secure_authentication),
(modest_maemo_utils_get_supported_secure_authentication_methods):
Fixed a crasher if operation is canceled
* src/modest-protocol-info.c: (modest_protocol_info_is_secure),
(modest_protocol_info_auth_is_secure):
* src/modest-protocol-info.h:
Added two new methods to determine if a protocol/auth method is secure/encrypted in
the sense of the \"Use secure authentication\" toggle.
pmo-trunk-r2099
Dirk-Jan C. Binnema [Thu, 7 Jun 2007 13:39:11 +0000 (13:39 +0000)]
* Updated the changelog with the new bugs fixed.
pmo-trunk-r2098
Murray Cumming [Thu, 7 Jun 2007 12:19:30 +0000 (12:19 +0000)]
2007-06-07 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.h:
* src/modest-tny-account-store.c:
Added modest_tny_account_store_get_local_folders_account().
* src/modest-tny-folder.h:
* src/modest-tny-folder.c:
(modest_tny_folder_get_account):
Added this replacement for tny_folder_get_account() which returns
the local-folders account for TnyMergeFolders, to avoid the
warning about the unimplemented get_account_func() vfunc().
(modest_tny_folder_get_rules),
* src/modest-ui-actions.c:
(modest_ui_actions_on_folder_selection_changed):
* src/modest-mail-operation.c:
(modest_mail_operation_remove_folder),
(modest_mail_operation_xfer_folder),
(modest_mail_operation_rename_folder),
(modest_mail_operation_get_msg),
(modest_mail_operation_get_msgs_full),
(modest_mail_operation_remove_msg),
(modest_mail_operation_xfer_msgs),
(modest_mail_operation_refresh_folder):
Use modest_tny_folder_get_account() instead of tny_folder_get_account().
pmo-trunk-r2097
Philip Van Hoof [Thu, 7 Jun 2007 11:24:13 +0000 (11:24 +0000)]
Cancelling the entire update_account_thread
pmo-trunk-r2096
Jose Dapena Paz [Thu, 7 Jun 2007 10:39:55 +0000 (10:39 +0000)]
Fixed some problems with synchronization between the attachments in
the attachments view of the editor, and the internal attachments list
the editor contains (fixes NB#57756):
* src/widgets/modest-attachments-view.[ch]:
* Added the method modest_attachments_view_get_attachments, that
obtains the mime parts of all the attachments shown.
* src/maemo/modest-msg-edit-window.c:
* Now, set_msg updates the list of attachments from the
attachments view.
* Fixed the code to hide and show the attachments caption.
pmo-trunk-r2095
Dirk-Jan C. Binnema [Thu, 7 Jun 2007 09:47:21 +0000 (09:47 +0000)]
* use wpeditor, not libwpeditor-plus for osso 1.1
pmo-trunk-r2094
Sergio Villar Senin [Thu, 7 Jun 2007 09:46:15 +0000 (09:46 +0000)]
* Fixes NB#55338
pmo-trunk-r2093
Murray Cumming [Thu, 7 Jun 2007 08:11:07 +0000 (08:11 +0000)]
2007-06-07 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
(modest_server_account_set_security):
* src/modest-defs.h: Add comments explaining that our
UI spec means TLS when it says Normal, so these do not look like errors.
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account): Use the new tinymail
'wrapped' option for regular SSL, and use the new tinymail 'tls' option
for TLS. This should fix projects.maemo.org bug NB#58460.
pmo-trunk-r2092
Dirk-Jan C. Binnema [Thu, 7 Jun 2007 07:03:14 +0000 (07:03 +0000)]
modified changelog for week23
pmo-trunk-r2091
Dirk-Jan C. Binnema [Thu, 7 Jun 2007 06:32:35 +0000 (06:32 +0000)]
* updated changelog
pmo-trunk-r2090
Dirk-Jan C. Binnema [Thu, 7 Jun 2007 06:13:12 +0000 (06:13 +0000)]
* really turn off the launcher for now (integration still seemed to activate it through DEB_BUILD_OPTIONS), because the launcher seems to impact network connectivity in some way.
* add libhildonhelp-dev as a build dep
pmo-trunk-r2089
Jose Dapena Paz [Wed, 6 Jun 2007 16:43:11 +0000 (16:43 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Before this change, only To: field was used to dim/undim
the send button. Now also Cc: and Bcc: fields are used.
Only when the three are empty, send button is dimmed
(fixes NB#59387).
pmo-trunk-r2088
Jose Dapena Paz [Wed, 6 Jun 2007 15:06:50 +0000 (15:06 +0000)]
* src/maemo/modest-msg-edit-window.c:
* When you request to remove attachments, and you
cancel in the confirmation dialog, the attachments
were removed anyway. Now it respects the dialog
response (fixes NB#57929).
pmo-trunk-r2087