modest
16 years agoWork to complete implementation of purge attachments operation
Jose Dapena Paz [Thu, 28 Jun 2007 17:06:34 +0000 (17:06 +0000)]
Work to complete implementation of purge attachments operation
(fixes NB#61240).
* src/widget/modest-msg-view.[ch]:
        * Added API function to get all the attachments in
          the view, and not only the selected ones.
* src/widgets/modest-attachment-view.c:
        * Support for showing purged files improved (still pending
          a proper logical id).
* src/widgets/modest-msg-view-window.[ch]:
* src/modest-ui-actions.[ch]:
        * Added support for purging attachments of a message from the
          main window, with lots of exception conditions (trying to
          remove messages with all attachments already purged, etc).
        * Added confirmation dialog for removing attachments from
          main window.
* src/maemo/modest-main-window-ui.h:
        * Attach remove attachments action in main window.
* src/widgets/modest-msg-view-window.[ch]:
        * Now you cannot save or view a purged attachment.
        * Now you can choose in ..._remove_attachments to remove
          only selected attachments or all the available attachments.
        * Skip already removed attachments
        * More informationbanners for purge operation.
        * Now the message is correctly reloaded after being purged.
* src/widgets/modest-ui-dimming-rules.[ch]:
        * Added a lot of dimming rules for removing attachments both
          from main window and msg view window.

pmo-trunk-r2478

16 years agoupdated the changelog with fixes.
Dirk-Jan C. Binnema [Thu, 28 Jun 2007 15:50:00 +0000 (15:50 +0000)]
updated the changelog with fixes.

pmo-trunk-r2477

16 years agoFix for the bug 59012, changed appedn to prepend.
Dirk-Jan C. Binnema [Thu, 28 Jun 2007 15:38:58 +0000 (15:38 +0000)]
Fix for the bug 59012, changed appedn to prepend.

pmo-trunk-r2476

16 years ago* Fixed some diomming rules.
Javier Fernandez Garcia-Boente [Thu, 28 Jun 2007 15:17:25 +0000 (15:17 +0000)]
* Fixed some diomming rules.
* Set flags DELETED just after tny_folder_remove_msg
* Add a filter in heder view to hide deleted rows

pmo-trunk-r2475

16 years ago2007-06-28 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Thu, 28 Jun 2007 12:57:41 +0000 (12:57 +0000)]
2007-06-28  Murray Cumming  <murrayc@murrayc.com

pmo-trunk-r2474

16 years agoSome debug output to help me with testing.
Murray Cumming [Thu, 28 Jun 2007 10:31:04 +0000 (10:31 +0000)]
Some debug output to help me with testing.

pmo-trunk-r2473

16 years ago * Commented some code that causes a hang. It reopens a bug, but it's a normal one...
Sergio Villar Senin [Thu, 28 Jun 2007 09:25:19 +0000 (09:25 +0000)]
* Commented some code that causes a hang. It reopens a bug, but it's a normal one and Modest won't hang

pmo-trunk-r2472

16 years ago* set all accounts offline when finalizing the modest-tny-account-store;
Dirk-Jan C. Binnema [Thu, 28 Jun 2007 09:18:00 +0000 (09:18 +0000)]
* set all accounts offline when finalizing the modest-tny-account-store;
  this should help with the problem where the modest window is closed,
  but it's still running, which make restarting modest impossible.

pmo-trunk-r2471

16 years ago * Wrap the gtk_main between gdk_threads_enter/leave code as documentation says
Sergio Villar Senin [Thu, 28 Jun 2007 08:30:19 +0000 (08:30 +0000)]
* Wrap the gtk_main between gdk_threads_enter/leave code as documentation says

pmo-trunk-r2470

16 years ago * Fixed an issue whith signal handlers when unregistering windows
Sergio Villar Senin [Thu, 28 Jun 2007 07:21:17 +0000 (07:21 +0000)]
* Fixed an issue whith signal handlers when unregistering windows
* Make a more fine-grained gdk threads locking
* Added msg view window registration in the dbus callbacks
* Removed an uneeded gdk_threads_enter/leave

pmo-trunk-r2469

16 years ago * Signal handlers are executed in the main lock, so no need to lock it again
Sergio Villar Senin [Thu, 28 Jun 2007 06:41:06 +0000 (06:41 +0000)]
* Signal handlers are executed in the main lock, so no need to lock it again

pmo-trunk-r2468

16 years ago2007-06-27 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 27 Jun 2007 18:25:44 +0000 (18:25 +0000)]
2007-06-27  Armin Burgmeier  <armin@openismus.com>

* src/modest-mail-operation.c: Fixed a crash when canceling a mail
receive operation.

pmo-trunk-r2467

16 years ago* fixed some bugs on dimming rules.
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 17:10:36 +0000 (17:10 +0000)]
* fixed some bugs on dimming rules.

pmo-trunk-r2466

16 years ago* Review dimming rules of paste operation.
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 16:45:25 +0000 (16:45 +0000)]
* Review dimming rules of paste operation.
* Review dimming rules of viewer window toolbar.
* Fixes: NB#60441, NB#61044

pmo-trunk-r2465

16 years ago2007-06-27 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Wed, 27 Jun 2007 15:28:30 +0000 (15:28 +0000)]
2007-06-27  Murray Cumming  <murrayc@murrayc.com

* src/modest-tny-account.h:
* src/modest-tny-account.c:
Added modest_tny_account_get_mmc_account_name(), to set the memory
card name asynchronously for the given account and then notify.
(modest_tny_account_new_for_local_folders): Use this new function instead
of using hildon_file_system_info_async_new() directly.

* src/widgets/modest-folder-view.c: (text_cell_data):
Use modest_tny_account_get_mmc_account_name() to get the real name, calling
gtk_tree_model_row_changed() when it is available.

This should fix projects.maemo.org bug NB#59301.

pmo-trunk-r2464

16 years ago* Connect an insensitive-press signal handler to
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 14:49:37 +0000 (14:49 +0000)]
* Connect an insensitive-press signal handler to
OK button of new folder dialog.
* Add a new dimming rules to check folder depth, only
for Context Sensitive Menu of folder view.
* Fixes NB#60458, NB#61835

pmo-trunk-r2463

16 years agoCommented out bugfix for setting new accounts online - regression problem
Philip Van Hoof [Wed, 27 Jun 2007 14:29:52 +0000 (14:29 +0000)]
Commented out bugfix for setting new accounts online - regression problem

pmo-trunk-r2462

16 years agoupdated the changelog with the fixes on 27.june
Dirk-Jan C. Binnema [Wed, 27 Jun 2007 14:14:49 +0000 (14:14 +0000)]
updated the changelog with the fixes on 27.june

pmo-trunk-r2461

16 years agoReverted again the gdk_threads_enter/leave sentences:
Jose Dapena Paz [Wed, 27 Jun 2007 14:13:18 +0000 (14:13 +0000)]
Reverted again the gdk_threads_enter/leave sentences:
* src/widgets/modest-attachment-view.c
* src/widgets/modest-header-view.c
* src/maemo/modest-maemo-global-settings-dialog.c
* src/modest-mail-operation.c

Misc changes (mainly work to implement attachment purging):
* src/widgets/modest-msg-view.c:
        * Added find toolbar scroll fix, disabled as we're waiting
          for the new gtkhtml gtk_html_get_selection_area API.
        * Now we don't remove the attached part on removing attachments
          from view.
* src/widgets/modest-attachment-view.c:
        * Added support for showing purged files as purged. The icon is
          the default document one, and the text is a currently non
          translated string.
        * Now size is only shown for file attachments (if they're not
          purged).
* src/maemo/modest-msg-view-window.c:
        * Use the new Tinymail mime part purge API. It purges really the
          attachments. The UI is a work in progress still, but the
          cache seems to get updated as expected. This implementation
          replaces the old delete_attachments tinymail API based
          implementation.
* src/ui/modest-ui-dimming-rules.c:
        * Added some dimming rules for remove attachments in message view.
          It's not complete yet.
        * Now "move to" operation does not check if the source folder is
          writeable (fixes NB#61860).

pmo-trunk-r2460

16 years agoFixes: NB#61843
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 13:08:11 +0000 (13:08 +0000)]
Fixes: NB#61843

pmo-trunk-r2458

16 years ago2007-06-27 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Wed, 27 Jun 2007 12:26:50 +0000 (12:26 +0000)]
2007-06-27  Murray Cumming  <murrayc@murrayc.com

* src/modest-mail-operation.c: (update_account_thread),
(get_msgs_full_thread): Fix typo failures in the revert
to fix the build.

pmo-trunk-r2457

16 years ago2007-06-27 Murray Cumming <murrayc@murrayc.com
Murray Cumming [Wed, 27 Jun 2007 12:16:09 +0000 (12:16 +0000)]
2007-06-27  Murray Cumming  <murrayc@murrayc.com

* src/maemo/modest-maemo-global-settings-dialog.c:
(idle_select_default_focus):
* src/modest-mail-operation.c: (idle_notify_progress),
(idle_notify_progress_once), (set_last_updated_idle),
(update_account_thread), (get_msgs_full_thread):
* src/widgets/modest-attachment-view.c: (get_size_idle_func):
* src/widgets/modest-header-view.c:
(idle_notify_headers_count_changed_destroy),
(idle_notify_headers_count_changed):
Reverted the additions of gdk_threads_enter/leave(), in case this
helps with a startup hang on the device.

pmo-trunk-r2456

16 years ago* Check main window toolbar dimming rules after
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 10:34:33 +0000 (10:34 +0000)]
* Check main window toolbar dimming rules after
open some message (delete toolbar must dimmed).

pmo-trunk-r2455

16 years ago* Fixes: NB#61846
Javier Fernandez Garcia-Boente [Wed, 27 Jun 2007 10:18:23 +0000 (10:18 +0000)]
* Fixes: NB#61846

pmo-trunk-r2454

16 years ago * Deleted some invalid unreferences, tinymail does take care about the objects passe...
Sergio Villar Senin [Wed, 27 Jun 2007 10:11:08 +0000 (10:11 +0000)]
* Deleted some invalid unreferences, tinymail does take care about the objects passed to callbacks

pmo-trunk-r2453

16 years ago * Fixes NB#61225 the application no longer hangs due to threading locks
Sergio Villar Senin [Wed, 27 Jun 2007 08:58:07 +0000 (08:58 +0000)]
* Fixes NB#61225 the application no longer hangs due to threading locks
* Modified modest_mail_operation_notify_end, now it receives a second argument that specifies if the signal emission should be blocked or NOT, we need to do this if we're calling it from a different thread
* Removed an invalid double-lock in the mail operations
* Added an empty error handler for the rename operation, no specs for the error message?

pmo-trunk-r2452

16 years ago* leak fix
Dirk-Jan C. Binnema [Wed, 27 Jun 2007 07:54:28 +0000 (07:54 +0000)]
* leak fix

pmo-trunk-r2451

16 years ago * Fixed a memory leak in modest folder view
Sergio Villar Senin [Wed, 27 Jun 2007 07:42:11 +0000 (07:42 +0000)]
* Fixed a memory leak in modest folder view
* Fixes NB#61607, the renaming was not working because we're getting the wrong response from the dialog

pmo-trunk-r2450

16 years ago* leak fix
Dirk-Jan C. Binnema [Wed, 27 Jun 2007 07:15:01 +0000 (07:15 +0000)]
* leak fix

pmo-trunk-r2449

16 years ago2007-06-26 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Tue, 26 Jun 2007 19:49:24 +0000 (19:49 +0000)]
2007-06-26  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
for supported secure authentication methods from server by
gtk_dialog_run(), saving CPU time and a potential race condition.

pmo-trunk-r2448

16 years ago2007-06-26 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Tue, 26 Jun 2007 19:11:48 +0000 (19:11 +0000)]
2007-06-26  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added a
ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
only error code to tell the calling code when the user canceled the
operation.

* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-account-settings-dialog.c:
* src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
message if the retrieval of secure authentication methods was canceled
by the user. Perform the check before saving anything to configuration
to not end up with half-committed configuration changes, do not show
a "Saving to configuration failed" note when authentication methods
could not be retrieved.

* src/maemo/modest-main-window.c: Fixed a crash on startup when built
with old hildon.

pmo-trunk-r2447

16 years ago* Add some notifications on dimming rules.
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 18:54:57 +0000 (18:54 +0000)]
* Add some notifications on dimming rules.

pmo-trunk-r2446

16 years ago* libmodest-dbus-client depends on modest
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:28:30 +0000 (18:28 +0000)]
* libmodest-dbus-client depends on modest

pmo-trunk-r2445

16 years ago* fix leak (gtk_tree_row_reference_get_path needs a free)
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:27:42 +0000 (18:27 +0000)]
* fix leak (gtk_tree_row_reference_get_path needs a free)

pmo-trunk-r2444

16 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 18:20:26 +0000 (18:20 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
Only return the first level of folders under accounts, because the
osso-global-search UI spec doesn't want the rest.
This fixed projects.maemo.org bug NB#61811.

pmo-trunk-r2443

16 years ago* Add new dimming rules for copy,cut and paste operations.
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 18:17:25 +0000 (18:17 +0000)]
* Add new dimming rules for copy,cut and paste operations.
* Add dimming rules for undo operations.
* Implement undo operation for copy and cut operations.
* Fixes: NB#59325

pmo-trunk-r2442

16 years ago* some other apps (sketch) send attachment list that start with ','.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:06:07 +0000 (18:06 +0000)]
* some other apps (sketch) send attachment list that start with ','.
  strip that one, to prevent a warnings later.

pmo-trunk-r2441

16 years ago* leak fix (modest-init)
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 18:03:58 +0000 (18:03 +0000)]
* leak fix (modest-init)
* modest-main: sometimes, 'ui' was a not a valid gobject, which caused glib warnings

pmo-trunk-r2440

16 years agoBugfix when creating an account
Philip Van Hoof [Tue, 26 Jun 2007 16:41:14 +0000 (16:41 +0000)]
Bugfix when creating an account

pmo-trunk-r2438

16 years ago* replace the unnecessary fill_server_account_cache_if_need with
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 16:26:39 +0000 (16:26 +0000)]
* replace the unnecessary fill_server_account_cache_if_need with
  direct calls to modest_tny_account_store_get_accounts. No need
  to make modest-tny-account-store even uglier.

(as always, murray is right)

pmo-trunk-r2437

16 years ago* Added a new reference to priv->draft_msg of edit window
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 16:25:38 +0000 (16:25 +0000)]
* Added a new reference to priv->draft_msg of edit window
to manages its own reference, becasue sometines, this object
was unreference and application crashed when get_msg method of
this window was called.

pmo-trunk-r2436

16 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 16:25:34 +0000 (16:25 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c:
* src/modest-tny-account-store.h:
Added modest_tny_account_is_memory_card_account().
* src/maemo/modest-main-window.c: (create_details_widget):
Show the same information items for the memory card as we show for the
local-folders, to fix projects.maemo.org bug NB#59307.

pmo-trunk-r2435

16 years ago* do lazy initialization of the server accounts; this avoids
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 16:06:35 +0000 (16:06 +0000)]
* do lazy initialization of the server accounts; this avoids
  a chicken-egg problem at startup where modest_runtime_get_account_store would
  be needed before initialized

pmo-trunk-r2434

16 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 15:57:57 +0000 (15:57 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
Added some checks for NULL to maybe prevent crashes, though I think
it was Philip's last commit that actually prevented the crash here
when creating a first new account.
But the new account is still not usable (no messages are shown)
until a restart of the application.

pmo-trunk-r2433

16 years agoBugfix when setting the account to online
Philip Van Hoof [Tue, 26 Jun 2007 15:51:46 +0000 (15:51 +0000)]
Bugfix when setting the account to online

pmo-trunk-r2432

16 years ago* Check headers flags (CACHED) to determine if some message
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 14:27:50 +0000 (14:27 +0000)]
* Check headers flags (CACHED) to determine if some message
was already retreived, and sets a different id in get_message
mail operation (OPEN). This new id will be used by progress
bar widget to show a different message.
* Fixes: NB#56201

pmo-trunk-r2431

16 years ago* expunge deleted messages when switching folders or closing;
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 14:05:47 +0000 (14:05 +0000)]
* expunge deleted messages when switching folders or closing;
  otherwise it's not possible to delete at all...

this should fix NB#61769, NB#61764

pmo-trunk-r2430

16 years agoUpdated the changelog with the fixes, june, 26th, 16:50.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 13:51:42 +0000 (13:51 +0000)]
Updated the changelog with the fixes, june, 26th, 16:50.

pmo-trunk-r2429

16 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 12:48:36 +0000 (12:48 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-global-settings-dialog.c:
(idle_select_default_focus):
* src/modest-mail-operation.c: (idle_notify_progress),
(idle_notify_progress_once), (idle_notify_update_account_queue),
(set_last_updated_idle), (update_account_thread),
(notify_get_msgs_full), (get_msgs_full_destroyer),
(get_msgs_full_thread):
* src/widgets/modest-attachment-view.c: (get_size_idle_func):
* src/widgets/modest-header-view.c:
(idle_notify_headers_count_changed_destroy),
(idle_notify_headers_count_changed):
Use gdk_threads_enter() and gdk_threads_enter_leave() in
all idle handlers, because some other thread could be blocking
the GDK lock, so that it can do GUI stuff.

pmo-trunk-r2428

16 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 12:31:38 +0000 (12:31 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
(on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
(on_idle_send_receive), (on_idle_open_default_inbox):
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive):
Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
to prevent a hang. I don't quite understand why these are necessary,
beause we should already be in the main loop. I guess something outside
of the main loop is taking the lock.

* tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
we are really using URIs, and use files that are more likely to exist.

pmo-trunk-r2427

16 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 12:05:41 +0000 (12:05 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* tests/dbus_api/Makefile.am: Fix the build of the tests. This was
        necessary because configure.ac now defines different variables.

pmo-trunk-r2426

16 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 11:39:46 +0000 (11:39 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
        * libmodest-dbus-client/libmodest-dbus-client.h:
        Removed libmodest_dbus_client_send_mail() because it is not used by anything.
        libmodest_dbus_client_compose_mail() is what things actually use.

        * src/dbus_api/modest-dbus-api.h:
        * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
        * tests/dbus_api/Makefile.am:
        * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
        D-Bus method.

pmo-trunk-r2424

16 years ago * Added an extra check that was causing a crash when the folder returns no stats
Sergio Villar Senin [Tue, 26 Jun 2007 11:00:32 +0000 (11:00 +0000)]
* Added an extra check that was causing a crash when the folder returns no stats

pmo-trunk-r2423

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 26 Jun 2007 10:33:24 +0000 (10:33 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Added gtk_text_iter_forward_search_insensitive to implement
          case insensitive search of strings using the find toolbar.
        * Added proper information banners for no matches, search
          complete and empty find.
        * Rework the find in page, to work similar to the upcoming
          find in page new implementation of viewer.

pmo-trunk-r2422

16 years agoChanged the configure.ac file. corrected the helplib variable used instead of mimelib.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 09:39:29 +0000 (09:39 +0000)]
Changed the configure.ac file. corrected the helplib variable used instead of mimelib.

pmo-trunk-r2421

16 years ago2007-06-26 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 26 Jun 2007 09:10:53 +0000 (09:10 +0000)]
2007-06-26  Murray Cumming  <murrayc@murrayc.com>

* src/modest-init.c: (modest_init_local_folders):
        For memory-card (or other non local-folders) maildir accounts,
        always create an Archive folder, so that there is somewhere to put
        messages. This should be less confusing, because the user does not need
        to guess that the need to create a folder.

pmo-trunk-r2420

16 years ago* Add a new check of new folder name string length in
Javier Fernandez Garcia-Boente [Tue, 26 Jun 2007 09:05:20 +0000 (09:05 +0000)]
* Add a new check of new folder name string length in
'entry-changed' signal handler.
* Fixes: NB#61576

pmo-trunk-r2419

16 years agoCompilation error
Philip Van Hoof [Tue, 26 Jun 2007 08:25:56 +0000 (08:25 +0000)]
Compilation error

pmo-trunk-r2418

16 years ago* call osso_abook_init before doing anything with the addressbook.
Dirk-Jan C. Binnema [Tue, 26 Jun 2007 08:03:16 +0000 (08:03 +0000)]
* call osso_abook_init before doing anything with the addressbook.
  this fixes NB#57415

pmo-trunk-r2417

16 years agoBugfix for 61408
Philip Van Hoof [Mon, 25 Jun 2007 20:07:50 +0000 (20:07 +0000)]
Bugfix for 61408

pmo-trunk-r2416

16 years ago * Added an attribute sent to the msg edit window that specifies that the mail has...
Sergio Villar Senin [Mon, 25 Jun 2007 18:56:49 +0000 (18:56 +0000)]
* Added an attribute sent to the msg edit window that specifies that the mail has scheduled to be sent
* Modified the window destruction code in the window manager. Now checks that the message has not been sent before trying to save it to drafsts
* Some code reorganization in the window manager

pmo-trunk-r2415

16 years ago* Added new dimming rules for Attachment menu option in
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 18:00:05 +0000 (18:00 +0000)]
* Added new dimming rules for Attachment menu option in
viewer window.
* Fixes: NB#61148

pmo-trunk-r2414

16 years ago2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Mon, 25 Jun 2007 17:46:07 +0000 (17:46 +0000)]
2007-06-25  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/easysetup/modest-wizard-dialog.c: (init):
Fixed icon size by using (50, 50) which is the same as defined by
newer hildon-libs

pmo-trunk-r2413

16 years ago* sync the folders when when we're moving to another one.
Dirk-Jan C. Binnema [Mon, 25 Jun 2007 17:28:16 +0000 (17:28 +0000)]
* sync the folders when when we're moving to another one.
  this fixes NB#57773

pmo-trunk-r2412

16 years ago * Fixes NB#61266, now the user can navigate between the tabs of global settings...
Sergio Villar Senin [Mon, 25 Jun 2007 16:37:02 +0000 (16:37 +0000)]
 * Fixes NB#61266, now the user can navigate between the tabs of global settings dialog using the hardware keys

pmo-trunk-r2411

16 years ago * Partially reverted last commit, sometimes the gdk_threads_enter blocks, still...
Sergio Villar Senin [Mon, 25 Jun 2007 16:00:42 +0000 (16:00 +0000)]
* Partially reverted last commit, sometimes the gdk_threads_enter blocks, still need to review it

pmo-trunk-r2410

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Mon, 25 Jun 2007 15:48:18 +0000 (15:48 +0000)]
* src/modest-ui-actions.c:
        * Fixed translation of message retrieval information note
          (fixes NB#61620).

pmo-trunk-r2409

16 years ago * Added two missing gdk_threads_enter/leave statements
Sergio Villar Senin [Mon, 25 Jun 2007 15:48:08 +0000 (15:48 +0000)]
* Added two missing gdk_threads_enter/leave statements

pmo-trunk-r2408

16 years ago * Removed an invalid g_object_unref
Sergio Villar Senin [Mon, 25 Jun 2007 15:44:03 +0000 (15:44 +0000)]
* Removed an invalid g_object_unref
* Added some gdk_threads_enter/leave in the mail operations

pmo-trunk-r2407

16 years agoUpdated yje
Dirk-Jan C. Binnema [Mon, 25 Jun 2007 15:36:12 +0000 (15:36 +0000)]
Updated yje

pmo-trunk-r2406

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:47:55 +0000 (14:47 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now Paste is dimmed when focus is in attachments view
          (fixes NB#60552).
        * Added proper information banners for insensitive press
          of Paste.

pmo-trunk-r2405

16 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:26:47 +0000 (14:26 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Added information banner for search complete and no matches.
        * Fixed translation of confirm overwrite dialog (fixes
          NB#60401).

pmo-trunk-r2404

16 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:11:52 +0000 (14:11 +0000)]
* src/maemo/modest-main-window.c:
        * Now "No messages to show" message is aligned to top
          instead of center (fixes NB#60298).

pmo-trunk-r2403

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 25 Jun 2007 14:02:59 +0000 (14:02 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now CC and BCC fields are shown even when show_cc and s
          show_bcc are FALSE in settings, if these fields have any
          values (for example replying to all in a message with Cc)
          (fixes NB#60253).

pmo-trunk-r2402

16 years ago2007-06-25 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Mon, 25 Jun 2007 13:18:44 +0000 (13:18 +0000)]
2007-06-25  Armin Burgmeier  <armin@openismus.com>

* src/widgets/modest-window-mgr.c:
* src/modest-init.c:
* configure.ac: Correctly recognize hildon-notify presence and fixed
the build without it being installed.

pmo-trunk-r2401

16 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Mon, 25 Jun 2007 13:12:39 +0000 (13:12 +0000)]
* src/modest-ui-dimming-rules.c:
        * Added dimming rule for trying to remove attachments from a
          POP message (fixes NB#59869).

pmo-trunk-r2400

16 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 12:26:37 +0000 (12:26 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_search): Fix the build. Sorry.
* src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
(reply_forward_cb): Initialize variables to fix the build.

* src/modest-tny-account-store.c:
(modest_tny_account_store_get_tny_account_by): Fix the account URI
comparison (a silly typo) so that email search results can be opened
when there are more than one account.

pmo-trunk-r2398

16 years ago * Fixes NB#59138, message is saved to drafts when main window is closed
Sergio Villar Senin [Mon, 25 Jun 2007 11:36:41 +0000 (11:36 +0000)]
* Fixes NB#59138, message is saved to drafts when main window is closed
* modest_msg_edit_window_is_modified is now public
* modest_window_mgr.c: added a hash table to store the "window-destroy" signal handlers
* modest_window_mgr.c: replaced a g_object_unref by gtk_widget_destroy
* moved the save_to_drafts call from the edit window to the window manager
* added some missing unrefs to the UI actions
* fixed save_to_drafts mail operation, it was not reporting the mail operation status

pmo-trunk-r2397

16 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 10:46:33 +0000 (10:46 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_search),
(libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
instead of 1 second, because the search gets folders and messages from
the server, which can take a long time. When it times out,
osso-global-search will report no results.

We need to specify whether we should search only cached information
(maybe with a user preference), and the osso-email-search-plugin
API should really be improved to allow that option, and to allow results
to be delivered asynchronously in batches.|

pmo-trunk-r2395

16 years ago* Review dimming rules of attachment menu option.
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 10:45:12 +0000 (10:45 +0000)]
* Review dimming rules of attachment menu option.
* Fixes: NB#61295

pmo-trunk-r2394

16 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 09:06:51 +0000 (09:06 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-wizard-dialog.c: (init):
        Fix a typo to fix the osso 1.1. build. See the TODO comment though -
        GTK_ICON_SIZE_DIALOG is probably the wrong size.

pmo-trunk-r2393

16 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 08:58:55 +0000 (08:58 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* src/modest-search.c: (modest_search_folder): Ignore a seach folder
        that is an empty string. D-Bus seems to give us these instead of NULL.

pmo-trunk-r2392

16 years ago2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Mon, 25 Jun 2007 08:50:55 +0000 (08:50 +0000)]
2007-06-25  Johannes Schmid <johannes.schmid@openismus.com>

* src/dbus_api/modest-dbus-callbacks.c:
* src/maemo/easysetup/modest-easysetup-wizard.h:
* src/maemo/easysetup/modest-wizard-dialog.c: (init):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
* src/maemo/modest-maemo-global-settings-dialog.c:
(on_range_error):
* src/maemo/modest-maemo-utils.c:
(modest_maemo_utils_setup_images_filechooser):
* src/maemo/modest-main-window.c: (create_details_widget):
* src/maemo/modest-msg-edit-window.c:
(modest_msg_edit_window_attach_file_noninteractive),
(modest_msg_edit_window_color_button_change),
(modest_msg_edit_window_set_zoom):
* src/modest-mail-operation.c: (update_account_thread):
* src/modest-tny-account-store.c:
* src/modest-tny-account.c:
* src/widgets/modest-global-settings-dialog.c:
* src/widgets/modest-window.h:

Fixed build on bora!

pmo-trunk-r2391

16 years ago* src/widgets/modest-attachments-view.c:
Jose Dapena Paz [Mon, 25 Jun 2007 08:38:45 +0000 (08:38 +0000)]
* src/widgets/modest-attachments-view.c:
        * Now it updates properly the selected attachments list when
          an attachment is removed. It also updates properly the
          primary clipboard (fixes NB#61453).

pmo-trunk-r2390

16 years ago2007-06-25 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 25 Jun 2007 08:37:19 +0000 (08:37 +0000)]
2007-06-25  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
* src/modest-search.c: (modest_search_folder),
(modest_search_all_accounts): Actually search only in the specified folder,
doing a simple match on the folder ID.
* src/modest-search.h: Added a folder field to the ModestSearch struct,
and added some documentation.

pmo-trunk-r2389

16 years ago* Add a new gettext macro to use holdon-common-strings
Javier Fernandez Garcia-Boente [Mon, 25 Jun 2007 07:42:57 +0000 (07:42 +0000)]
* Add a new gettext macro to use holdon-common-strings
translate domain.
* Add a new notification banner to edit/copy operation.

pmo-trunk-r2388

16 years ago- fix order of header fields in viewer; fixes NB#61497
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 16:50:03 +0000 (16:50 +0000)]
- fix order of header fields in viewer; fixes NB#61497

pmo-trunk-r2387

16 years ago* gnome is currently broken; tell our users
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 11:02:40 +0000 (11:02 +0000)]
* gnome is currently broken; tell our users

pmo-trunk-r2386

16 years ago* fix the fallout of the configuration changes - builds again now
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:48:17 +0000 (10:48 +0000)]
* fix the fallout of the configuration changes - builds again now

pmo-trunk-r2385

16 years ago* remove some unintended changes in the last checkin
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:17:13 +0000 (10:17 +0000)]
* remove some unintended changes in the last checkin

pmo-trunk-r2384

16 years ago* cleanup the configuration system a bit:
Dirk-Jan C. Binnema [Sun, 24 Jun 2007 10:09:45 +0000 (10:09 +0000)]
* cleanup the configuration system a bit:
- don't have an overall 'hildon0' or 'hildon1' check, because this causes problems with sardine
- check for ogs, hildon-help, hildon-notify etc. separately
- turn on -Werr for *all* maemo builds

pmo-trunk-r2383

16 years ago* fix bora build (there's no hildonnotification there)
Dirk-Jan C. Binnema [Sat, 23 Jun 2007 09:02:13 +0000 (09:02 +0000)]
* fix bora build (there's no hildonnotification there)

pmo-trunk-r2382

16 years ago2007-06-22 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Fri, 22 Jun 2007 20:03:30 +0000 (20:03 +0000)]
2007-06-22  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c: Added a GError parameter to
modest_maemo_utils_get_supported_secure_authentication_methods.

* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c: Show correct error if
one occured, not just "Server does not support secure authentication".

pmo-trunk-r2381

16 years ago2007-06-22 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 22 Jun 2007 16:13:17 +0000 (16:13 +0000)]
2007-06-22  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
        Restored the call to tny_account_set_user() because Philip seems to have
        stopped this from crashing (by not using the freed string). It still does
        not work, but now we can test it.

pmo-trunk-r2380

16 years ago* src/widgets/modest-msg-view.[ch]:
Jose Dapena Paz [Fri, 22 Jun 2007 15:11:11 +0000 (15:11 +0000)]
* src/widgets/modest-msg-view.[ch]:
        * Remove an attachment mime part from view.
* src/widgets/modest-msg-view-window.[ch]:
        * Implemented dialog for removing attachments, but dropped
          any remove attachment implementation until we know how to
          remove attachments only from cache.

pmo-trunk-r2379

16 years ago2007-06-22 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 22 Jun 2007 14:09:23 +0000 (14:09 +0000)]
2007-06-22  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-msg-edit-window.c: (init_window):
        Comment out use of an uninitialzed GtkScrolledWindow variable,
        to fix the build and stop a crash. Yet again.

pmo-trunk-r2378

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 22 Jun 2007 12:15:57 +0000 (12:15 +0000)]
* src/modest-ui-actions.c:
        * Now saving to drafts shows a proper information
          banner (fixes NB#59333).

pmo-trunk-r2377

16 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Fri, 22 Jun 2007 12:07:28 +0000 (12:07 +0000)]
* src/widgets/modest-folder-view.c:
        * Now local folder is bolded too (fixes NB#59314).

pmo-trunk-r2376

16 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Fri, 22 Jun 2007 11:53:46 +0000 (11:53 +0000)]
* src/modest-text-utils.[ch]:
        * Added new method modest_text_utils_get_color_string, that
          obtains a color string proper for inserting in pango markup
          or html from a GdkColor.
* src/maemo/modest-main-window.c:
        * Now the folder details view puts secondary text color on field
          names (fixes NB#59310).

pmo-trunk-r2375

16 years ago2007-06-22 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Fri, 22 Jun 2007 11:20:51 +0000 (11:20 +0000)]
2007-06-22  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
        Remove the call to tny_account_set_user() because this actually crashes.
        As mentioned in the last commit, it is known to not work anyway.

pmo-trunk-r2374