modest
16 years ago * Wrap all the signal emissions with gdk_threads_* stuff, we need to ensure that...
Sergio Villar Senin [Fri, 13 Jul 2007 07:39:54 +0000 (07:39 +0000)]
* Wrap all the signal emissions with gdk_threads_* stuff, we need to ensure that only one thread enter Gtk+ at the same time

pmo-trunk-r2732

16 years ago2007-07-12 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 12 Jul 2007 17:03:45 +0000 (17:03 +0000)]
2007-07-12  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-main-window.c: Make default account appear bold
in view, tools/send & receive and toolbar/send & receive SCM menus.
This fixes projects.maemo.org bug NB#59010.

pmo-trunk-r2731

16 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 15:00:58 +0000 (15:00 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
Add a short-cut, by checking if the folder store is an account.
This ensures that the Sort menu item and toolbar is dimmed for
the local-folders account root item, fixing
projects.maemo.org bug NB#62545.

pmo-trunk-r2730

16 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 14:25:33 +0000 (14:25 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (get_password):
Show the password dialog (via the signal) only in the mainloop, via
an idle handler that we wait for. This could theoretically prevent
hangs, though I worry that it could introduce some too.

pmo-trunk-r2729

16 years ago * Added support to get_folders call in the local folder account to filter by query
Sergio Villar Senin [Thu, 12 Jul 2007 14:22:11 +0000 (14:22 +0000)]
* Added support to get_folders call in the local folder account to filter by query
* Removed get_folders_async from the local folder account because it makes no sense to redefine it to just call the parent
* Redefined the create_folder method in the local folder account in order not to allow to create folders with the same name than the extra folders
* Removed some invalid string comparisons in the guess_folder_type_from_name
* Now Modest do not allow to create a folder called outbox, nor to move another one with that name to the local folders account

pmo-trunk-r2728

16 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 14:00:57 +0000 (14:00 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
* src/maemo/modest-platform.c:
(modest_platform_connect_and_wait):
Take a TnyAccount* parameter and try to set it to online
(a TnyCamel-only API), because tinymail sets accounts to offline
when the user cancels a password dialog, and doesn't ask again until
it has been set to online.
However, this is commented out because it causes a hang now.

(modest_platform_connect_and_wait_if_network_account):
* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
* src/modest-platform.h:
* src/modest-ui-actions.c: (_modest_ui_actions_open),
(download_uncached_messages), (modest_ui_actions_on_send): Adapted.

pmo-trunk-r2727

16 years ago2007-07-12 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Thu, 12 Jul 2007 13:20:03 +0000 (13:20 +0000)]
2007-07-12  Armin Burgmeier  <armin@openismus.com>

* src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.

* src/modest-mail-operation.c:
* src/modest-ui-actions.c: Check for already existing folder before
querying the server, show error message from camel if the request
still fails. This fixes projects.maemo.org bug NB#58701.

pmo-trunk-r2726

16 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 13:02:57 +0000 (13:02 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.h:
* src/modest-tny-account-store.c:
Added modest_tny_account_store_forget_password_in_memory(),
(get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
when creating a new account, so that new passwords will be used, instead of
us thinking that it's a second request as a result of a failed password again.

pmo-trunk-r2725

16 years agoUnselecting when a rename or a delete should happen
Philip Van Hoof [Thu, 12 Jul 2007 12:15:10 +0000 (12:15 +0000)]
Unselecting when a rename or a delete should happen

pmo-trunk-r2724

16 years ago * Removed some comments
Sergio Villar Senin [Thu, 12 Jul 2007 11:16:36 +0000 (11:16 +0000)]
* Removed some comments
* Fixes NB#63055
* Added query capabilities to the get_folders method of our local account store
* Added the name Outbox for the local merged folder with the same name

pmo-trunk-r2723

16 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 09:36:00 +0000 (09:36 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_open_message): If the message is in drafts then open it
in an edit window instead of a view window. This fixes
projects.maemo.org bug NB#63005.

pmo-trunk-r2722

16 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 08:14:42 +0000 (08:14 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
Avoided a harmless g_warning().

pmo-trunk-r2721

16 years agoRemoved a debug printf.
Murray Cumming [Thu, 12 Jul 2007 08:01:11 +0000 (08:01 +0000)]
Removed a debug printf.

pmo-trunk-r2720

16 years ago2007-07-12 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Thu, 12 Jul 2007 07:59:04 +0000 (07:59 +0000)]
2007-07-12  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
Pass the modest account name, not the TnyAccount display name to
modest_msg_view_window_new() so that the reply feature works,
fixing projects.maemo.org bug NB#62892.

* src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
(modest_msg_view_window_new_with_header_model):
* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_new_with_header_model),
(modest_msg_view_window_new):
* src/modest-ui-actions.c: (reply_forward):
* src/widgets/modest-msg-view-window.h:
* src/widgets/modest-window.c: (modest_window_set_active_account):
Rename an account parameter to modest_account_name to make this clearer.

2007-07-11  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.h:
* src/modest-ui-actions.c: (headers_action_delete): Moved some code into
modest_do_message_delete().
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
Call modest_do_message_delete(), hoping that this would cause messages
to be really deleted from search instead of just marked with strike through.
Does not seem to help.

pmo-trunk-r2719

16 years agoAdded the fixes made till july 12th.
Dirk-Jan C. Binnema [Thu, 12 Jul 2007 07:58:58 +0000 (07:58 +0000)]
Added the fixes made till july 12th.

pmo-trunk-r2718

16 years ago2007-07-11 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 11 Jul 2007 18:25:49 +0000 (18:25 +0000)]
2007-07-11  Armin Burgmeier  <armin@openismus.com>

* src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
priv->reselect to FALSE prior to calling
modest_folder_view_select_first_inbox_or_local() to prevent endless
recursion and thus a crash on startup.

pmo-trunk-r2717

16 years ago2007-07-11 Armin Burgmeier <armin@openismus.com>
Armin Burgmeier [Wed, 11 Jul 2007 17:31:02 +0000 (17:31 +0000)]
2007-07-11  Armin Burgmeier  <armin@openismus.com>

* src/maemo/modest-account-settings-dialog.h: Include
<gtk/gtknotebook.h> to fix the build (at least for me).

* src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
Use "New FolderN" as default suggested name if "New folder" already
exists, with N being the first free number, though never exceed "New
folder99" in which case we just fall back to "New Folder" even though
it already exists. This fixes projects.maemo.org bug NB#58663.

pmo-trunk-r2716

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 11 Jul 2007 16:52:45 +0000 (16:52 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Reactivate the focus vadjustment
* src/widgets/modest-window.c:
        * Now escape sends a delete event to msg view and editor if
          they're not fullscreen (fixes NB#58618).

pmo-trunk-r2715

16 years ago2007-07-11 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 11 Jul 2007 16:43:54 +0000 (16:43 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-view-window.c: (on_new_button_clicked):
Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
projects.maemo.org bug NB#62778.

pmo-trunk-r2714

16 years ago* auto expand the folder list again; we need to check if this works now.
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 16:15:05 +0000 (16:15 +0000)]
* auto expand the folder list again; we need to check if this works now.
  Fixes: NB#62355

pmo-trunk-r2713

16 years ago2007-07-11 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 11 Jul 2007 15:58:08 +0000 (15:58 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
Ignore the wrong (for now) secure-smtp setting in the presets -
just default to requiring secure authentication for SMTP, because
that is most common.

pmo-trunk-r2712

16 years ago* src/modest-init.c:
Jose Dapena Paz [Wed, 11 Jul 2007 15:52:47 +0000 (15:52 +0000)]
* src/modest-init.c:
        * Now we set properly the default settings of the columns
          and we don't set random values due to random array values
          (fixes NB#62593).

pmo-trunk-r2711

16 years agoAdded a TODO.
Murray Cumming [Wed, 11 Jul 2007 15:33:49 +0000 (15:33 +0000)]
Added a TODO.

pmo-trunk-r2710

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 11 Jul 2007 15:30:34 +0000 (15:30 +0000)]
* src/modest-ui-actions.c:
        * Unregister header after finishing attachment purge
          (fixes NB#63007).

pmo-trunk-r2709

16 years ago * Fixed some reference leaks
Sergio Villar Senin [Wed, 11 Jul 2007 15:29:19 +0000 (15:29 +0000)]
* Fixed some reference leaks
* Removed an unneeded ref/unref pair

pmo-trunk-r2708

16 years ago2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
Murray Cumming [Wed, 11 Jul 2007 15:22:41 +0000 (15:22 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc-desktop>

* src/modest-ui-actions.h:
* src/modest-ui-actions.c:
(modest_ui_actions_on_delete_message):
Move some code into a new
modest_ui_actions_refresh_message_window_after_delete()
function so we can use it from elsewhere.

* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_delete_message), (on_delete_message): Used an idle
handler, as we do for the other D-Bus method handlers.
Call modest_ui_actions_refresh_message_window_after_delete()
if the deleted message was open in a window. This fixed
projects.maemo.org bug NB#62862.

pmo-trunk-r2707

16 years ago* logical-id fix, fixes: NB #63117
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 15:20:17 +0000 (15:20 +0000)]
* logical-id fix, fixes: NB #63117

pmo-trunk-r2706

16 years ago2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 11 Jul 2007 15:17:45 +0000 (15:17 +0000)]
2007-07-11  Johannes Schmid <johannes.schmid@openismus.com>

* src/widgets/modest-folder-view.c: (filter_row)
Do not show drafts folder (see UI specs)

pmo-trunk-r2705

16 years ago2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Wed, 11 Jul 2007 15:13:16 +0000 (15:13 +0000)]
2007-07-11  Johannes Schmid <johannes.schmid@openismus.com>

* src/modest-ui-actions.c:
Remove call to show_non_move_folders(TRUE) which was moved to a wrong
place and also not necessary.

* src/widgets/modest-folder-view.c: (filter_row)
Guess folder type and hide Sent & Outbox if necessary.
Fixed project.maemo.org NB#57328

pmo-trunk-r2704

16 years agoMoving some code
Philip Van Hoof [Wed, 11 Jul 2007 14:53:03 +0000 (14:53 +0000)]
Moving some code

pmo-trunk-r2703

16 years agoAdded all the bugs in resolved fixed status for w28.
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 14:47:15 +0000 (14:47 +0000)]
Added all the bugs in resolved fixed status for w28.

pmo-trunk-r2702

16 years agoAdded all the bugs in resolved fixed status for w28.
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 14:44:02 +0000 (14:44 +0000)]
Added all the bugs in resolved fixed status for w28.

pmo-trunk-r2701

16 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Wed, 11 Jul 2007 14:23:05 +0000 (14:23 +0000)]
* src/widgets/modest-folder-view.c:
        * Removed a posible leak of a reference to folders if
          folders retrieval failed.
* src/widgets/modest-header-view.c:
        * Put null to some headers initial values to prevent using it
          without values.
* src/modest-tny-msg.c:
        * Add a reference owned by the attachments list
* src/maemo/modest-msg-view-window.c:
        * We don't run the clipboard owner change handler if the
          window is not visible.

pmo-trunk-r2700

16 years agoClearing the folder before rename
Philip Van Hoof [Wed, 11 Jul 2007 14:15:11 +0000 (14:15 +0000)]
Clearing the folder before rename

pmo-trunk-r2699

16 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Wed, 11 Jul 2007 14:04:08 +0000 (14:04 +0000)]
* src/widgets/modest-header-view-render.c:
* Now we unref the header instance for outgoing folders
  after using it.

pmo-trunk-r2698

16 years ago2007-07-11 Murray Cumming <murrayc@murrayc-desktop>
Murray Cumming [Wed, 11 Jul 2007 13:34:57 +0000 (13:34 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc-desktop>

* src/modest-main.c: (main): Only show the UI at the start if
the showui command line option was given. For instance,
run-standalone src/modest showui
Otherwise, we wait for the top_application D-Bus method to
be sent by hildon-desktop when the application is selected
from the menu.
This allows us to run without a UI when osso-global-search
uses our D-Bus methods.

pmo-trunk-r2697

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 11 Jul 2007 12:43:35 +0000 (12:43 +0000)]
* src/modest-ui-actions.c:
        * Removed annoying warning for check retrieval in message open
          handler. THis was appearing everytime we cancelled a
          message retrieval.
* src/modest-mail-operation.c:
        * Now we notify the end of the mail operation before
          unreferencing. This prevents a crash.
        * Now we do a tny_account_cancel in status handler when we
          get a cancel status. This way we properly cancel the
          message download (and then we can try again to open the
          message as expected (fixes NB#62444).

pmo-trunk-r2696

16 years ago* improve modest_folder_view_select_folder:
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 12:08:59 +0000 (12:08 +0000)]
* improve modest_folder_view_select_folder:
  - move the cursor as well (this fixes the seemingly double selection prob
  - expand the the treeview if we created an invisible subfolder

pmo-trunk-r2695

16 years ago2007-07-11 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Wed, 11 Jul 2007 11:50:59 +0000 (11:50 +0000)]
2007-07-11  Murray Cumming  <murrayc@murrayc.com>

* src/dbus_api/modest-dbus-api.h: Added a define for a
top-application D-Bus method.
* src/dbus_api/modest-dbus-callbacks.c:
(on_top_application),
(modest_dbus_req_handler): Handle the top-application D-Bus
method, which might be an undocumented D-Bus signal sent by
hildon-desktop when it starts the application from the menu.
But I am not sure and I need to test it on the device, because
my scratchbox does not have the application in the menu now.
This method shows the main window, so that it can be invisible
when started, for instance, just for email searching from
osso-global-search.

* src/maemo/modest-main-window.c: (restore_settings),
(modest_main_window_new): Do not show the window immediately
upon creation. We show it later.
* src/modest-widget-memory.c: (save_settings_paned):
Try (unsuccessfully) to avoid saving the paned position when
it is not even visible.
(restore_settings_paned): Do not allow a silly paned position.
This seems necessary when not showing the window at first.

* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_top_application.c: (main): Test for the
new D-Bus method.

pmo-trunk-r2694

16 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 11 Jul 2007 09:35:02 +0000 (09:35 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Refactored the save_attachments dialog construction to share
          more code for checkings and file chooser management.
        * Now saving attachments is asynchronous, and then we can show a
          proper information banner while saving (fixes NB#62823).
        * Added information banner for "saved".
        * Removed some leaks.

pmo-trunk-r2693

16 years ago* Fixed some bugs about last revision of dimming rules.
Javier Fernandez Garcia-Boente [Wed, 11 Jul 2007 09:16:50 +0000 (09:16 +0000)]
* Fixed some bugs about last revision of dimming rules.

pmo-trunk-r2692

16 years ago* Review dimming rules, according new specs about
Javier Fernandez Garcia-Boente [Wed, 11 Jul 2007 09:09:10 +0000 (09:09 +0000)]
* Review dimming rules, according new specs about
main view and viewer windows toolbar and menu items.

pmo-trunk-r2691

16 years ago * Updated the help ids to the new specs
Sergio Villar Senin [Wed, 11 Jul 2007 08:43:54 +0000 (08:43 +0000)]
* Updated the help ids to the new specs
* Fixed an issue when detecting the type of the folder when showing the help

pmo-trunk-r2690

16 years ago * Refactored the "Move to" stuff in the ui actions
Sergio Villar Senin [Wed, 11 Jul 2007 08:10:51 +0000 (08:10 +0000)]
* Refactored the "Move to" stuff in the ui actions
* Added a next_row_reference field to help the viewer when the current message is transfered
* Fixes NB#61931 consecutive move operations from the viewer are working now
* Fixes NB#62925 trying to move to root folders shows an error dialog and no longer crashes

pmo-trunk-r2689

16 years agoAdded all the bugs in resolved fixed status for w28.
Dirk-Jan C. Binnema [Wed, 11 Jul 2007 07:39:12 +0000 (07:39 +0000)]
Added all the bugs in resolved fixed status for w28.

pmo-trunk-r2688

16 years ago* switch the focus to the renamed folder... fixes NB#63002
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 23:59:26 +0000 (23:59 +0000)]
* switch the focus to the renamed folder... fixes NB#63002

pmo-trunk-r2687

16 years ago* compilation fix
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 23:58:41 +0000 (23:58 +0000)]
* compilation fix

pmo-trunk-r2686

16 years ago* let the dbus-invoked msgs use the same uids as other messages,
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 23:13:08 +0000 (23:13 +0000)]
* let the dbus-invoked msgs use the same uids as other messages,
  so, modest-window-mgr will do the right thing.

also fixed up modest-window-mgr a bit.

  fixes: NB#62897

pmo-trunk-r2685

16 years ago* select the newly created folder.
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 19:04:52 +0000 (19:04 +0000)]
* select the newly created folder.
  when creating a new folder, we do a
modest_folder_view_select_folder (view, folder, TRUE)
   the TRUE means that we will register the changed
   folder in the folder view, and it will be selected
   as soon as the folder view is updated

pmo-trunk-r2684

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 10 Jul 2007 19:03:29 +0000 (19:03 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Changed max width of images as using the thumbable scrollbar
  we have less space for the editor (fixes NB#62804).

pmo-trunk-r2683

16 years ago* select the inbox of the newly selected account; fixes NB#58667
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 18:46:40 +0000 (18:46 +0000)]
* select the inbox of the newly selected account; fixes NB#58667

pmo-trunk-r2682

16 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 18:24:30 +0000 (18:24 +0000)]
2007-07-10  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_new_msg),
(modest_ui_dimming_rules_on_reply_msg),
(modest_ui_dimming_rules_on_delete_msg),
(modest_ui_dimming_rules_on_details),
(modest_ui_dimming_rules_on_view_window_move_to),
(modest_ui_dimming_rules_on_view_previous),
(modest_ui_dimming_rules_on_view_next),
(_invalid_folder_for_purge): Added checks before
casting the window. This looks like an actual
logic error in _invalid_folder_for_purge(), because it
tries to use a ModestMainWindow as a message window.

pmo-trunk-r2681

16 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 17:13:46 +0000 (17:13 +0000)]
2007-07-10  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(show_error): Use the same implementation as in
modest-easysetup-wizard.c:
(on_entry_invalid_character): The logical ID contains a %s.
Guessed what it should be.
(on_entry_max), (check_data), (on_response): Adapt to
changed show_error().
(create_page_account_details): Really call
modest_validating_entry_set_func() on the correct widgets.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_entry_invalid_character): Fix the logical ID here too.
 (create_page_account_details),
(create_page_user_details):
Really call
modest_validating_entry_set_func() on the correct widgets.

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Do not try to use the account if it is NULL.

pmo-trunk-r2680

16 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 17:13:37 +0000 (17:13 +0000)]
2007-07-10  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-account-settings-dialog.c:
(show_error): Use the same implementation as in
modest-easysetup-wizard.c:
(on_entry_invalid_character): The logical ID contains a %s.
Guessed what it should be.
(on_entry_max), (check_data), (on_response): Adapt to
changed show_error().
(create_page_account_details): Really call
modest_validating_entry_set_func() on the correct widgets.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_entry_invalid_character): Fix the logical ID here too.
 (create_page_account_details),
(create_page_user_details):
Really call
modest_validating_entry_set_func() on the correct widgets.

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Do not try to use the account if it is NULL.

pmo-trunk-r2679

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 10 Jul 2007 16:42:33 +0000 (16:42 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we load the pixbuf that goes to the buffer before adding
          the attachment, as this causes reads to the vfs stream, and
          then, corruption of data.

pmo-trunk-r2678

16 years ago* Call refilter function on header view only when header delete
Javier Fernandez Garcia-Boente [Tue, 10 Jul 2007 16:25:36 +0000 (16:25 +0000)]
* Call refilter function on header view only when header delete
change is notified.
* Fixes: NB#60389

pmo-trunk-r2677

16 years ago* src/modest-mail-operation.[ch]:
Jose Dapena Paz [Tue, 10 Jul 2007 16:13:57 +0000 (16:13 +0000)]
* src/modest-mail-operation.[ch]:
        * New mail operation "get_mime_part_size", asynchronous. This
          is used to show the mime part size in attachment view without
          blocking the UI when the size is big enough.
        * New mail operation "create_msg", asynchronous, that contains
          the old work done in save to drafts and send new mail for
          creating a valid TnyMsg instance to send. This is required
          because the operation can take long when the attachments are
          big enough. This operation is private.
        * Now send_new_mail and save_to_drafts use the new "create_msg"
          mail operation to avoid stalling the UI.
* src/widgets/modest-attachment-view.c:
        * Now we use the new mail operation for getting the attachment
          size. This way we don't block on attaching big files or
          from slow folders (as shared folders). We also remove the
          old synchronous implementation.
* src/modest-tny-msg.[ch]:
        * Now the constructors get a GList of attachments, not a (really
          fake) GSList.
* src/modest-ui-actions.c:
        * Now the save to drafts action does not remove the old draft
          itself, as it's now done internally in the mail operation. We
          also provide the edit window.
* src/maemo/modest-msg-edit-window.c:
        * We don't hang looping when there's an error in mime parts.
        * Now we check if the widget is visible on clipboard owner
          handler to prevent crashes on calling the handler after
          destroiying and before finalizing.

pmo-trunk-r2676

16 years ago2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Tue, 10 Jul 2007 16:00:52 +0000 (16:00 +0000)]
2007-07-10  Johannes Schmid <johannes.schmid@openismus.com>

* src/modest-ui-actions.c: (create_move_to_dialog),
(modest_ui_actions_on_main_window_move_to),
(modest_ui_actions_on_msg_view_window_move_to):
* src/widgets/modest-folder-view.c: (modest_folder_view_init),
(filter_row), (modest_folder_view_show_non_move_folders):
* src/widgets/modest-folder-view.h:

Hide Sent & Outbox folder in \"move to\"-dialog. Does not work for
the Sent folder yet as it does not report the correct folder type.

pmo-trunk-r2675

16 years ago* Review status management of OUTBOX messages while
Javier Fernandez Garcia-Boente [Tue, 10 Jul 2007 14:59:21 +0000 (14:59 +0000)]
* Review status management of OUTBOX messages while
are being processed by TnySendQueue.
* Connect handlers to 'msg-sending' and 'msg-sent'
signals emmited by TnyCamelSendQueue.

pmo-trunk-r2674

16 years ago* fixes NB#62982 (wrong logical id)
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 14:33:15 +0000 (14:33 +0000)]
* fixes NB#62982 (wrong logical id)
* add NULL check to modest_maemo_utils_folder_writable as it *always* seemed
  to crash in my sbox

pmo-trunk-r2673

16 years agoUpdated to the new tny_session_camel_set_initialized API
Philip Van Hoof [Tue, 10 Jul 2007 14:32:16 +0000 (14:32 +0000)]
Updated to the new tny_session_camel_set_initialized API

pmo-trunk-r2672

16 years ago2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
Johannes Schmid [Tue, 10 Jul 2007 14:29:21 +0000 (14:29 +0000)]
2007-07-10  Johannes Schmid <johannes.schmid@openismus.com>

* src/maemo/modest-msg-edit-window.c: (init_window):
Fixed bora build

pmo-trunk-r2671

16 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 13:02:22 +0000 (13:02 +0000)]
2007-07-10   Murray Cumming  <murrayc@murrayc.com>

* src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
Take a parent widget instead of a parent window, and
implement this with hildon_banner_show_information() instead.
Non-Maemo builds can just ifdef that there.
This fixed projects.maemo.org bug NB#62766.

(on_entry_invalid_character): Use show_error() again instead
of using hildon directly, and use the _CS() macro to use the correct
translation domain.
(create_account), (check_for_supported_auth_methods), (on_entry_max):
Pass a widget instead od a window to show_error().

pmo-trunk-r2670

16 years ago* trivial fix to show the right banner, fixes NB#60521
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 11:58:12 +0000 (11:58 +0000)]
* trivial fix to show the right banner, fixes NB#60521

pmo-trunk-r2669

16 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 11:54:11 +0000 (11:54 +0000)]
2007-07-10  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Adapt to the changed tinymail API, using the new TnyAccount* parameter.
This allows us to show the server name in the error message, fixing
projects.maemo.org bug NB#62904.
Also, use the appropriate logical ID message for the account protocol.

pmo-trunk-r2668

16 years ago * Added gdk_threads_enter/leave stuff to the idle that shows the password dialog
Sergio Villar Senin [Tue, 10 Jul 2007 10:19:01 +0000 (10:19 +0000)]
* Added gdk_threads_enter/leave stuff to the idle that shows the password dialog
* Replaced the tny_folder_sync by the async version
* The toggle button of the toolbar and the View->Folders menu share now the same GtkAction. Fixes the problem of the toolbar button not pressed when starting

pmo-trunk-r2667

16 years agoPatch for bug 60551.
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 09:25:38 +0000 (09:25 +0000)]
Patch for bug 60551.

pmo-trunk-r2666

16 years ago* show Ok/Cancel instead of Yes/No, fixes NB#59428
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 09:20:16 +0000 (09:20 +0000)]
* show Ok/Cancel instead of Yes/No, fixes NB#59428

pmo-trunk-r2665

16 years ago* Set focus on next row after delete selected headers
Javier Fernandez Garcia-Boente [Tue, 10 Jul 2007 08:51:20 +0000 (08:51 +0000)]
* Set focus on next row after delete selected headers
on main window.
* Add a check for msg_id after get it from header just
after moved it to OUTBOX folder.
* Fixes: NB#61937

pmo-trunk-r2664

16 years ago2007-07-10 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Tue, 10 Jul 2007 08:13:22 +0000 (08:13 +0000)]
2007-07-10  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c: (on_idle_wrong_password):
A compilation fix, though the build wasn't broken for me.

pmo-trunk-r2663

16 years agoPerformance improvement and bugfix for 62489
Philip Van Hoof [Tue, 10 Jul 2007 08:03:48 +0000 (08:03 +0000)]
Performance improvement and bugfix for 62489

pmo-trunk-r2662

16 years ago* src/maemo/modest-platform.c:
Jose Dapena Paz [Tue, 10 Jul 2007 07:06:00 +0000 (07:06 +0000)]
* src/maemo/modest-platform.c:
        * Fixed a crash that happened on moving messages to outbox.
          The code to connect and wait, didn't consider the case of
          a message from a folder without an account (fixes NB#62872).

pmo-trunk-r2661

16 years ago* fix for the logical string part of NB#62872
Dirk-Jan C. Binnema [Tue, 10 Jul 2007 06:11:53 +0000 (06:11 +0000)]
* fix for the logical string part of NB#62872

pmo-trunk-r2660

16 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 21:26:20 +0000 (21:26 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
Do not try to unref a NULL folder store, to avoid a runtime warning.
This seems to happen sometimes when changing accounts settings.

pmo-trunk-r2659

16 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 20:25:32 +0000 (20:25 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/modest-tny-account-store.c:
(modest_tny_account_store_instance_init),
(modest_tny_account_store_finalize),
(on_account_settings_hide), (on_idle_wrong_password):
Use a GHashTable to ensure that we only show one account settings
dialog per modest account. This avoids us having a dialog open for
both the store and transport accounts, or due to repeated get_password()
calls that shouldn't happen anyway.

pmo-trunk-r2658

16 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 19:29:53 +0000 (19:29 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-utils.c: (on_hide),
(modest_maemo_show_dialog_and_forget): Handle the response, because
the window is not even hidden by default.

* src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
* src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
which seems to prevent some modality problems.

* src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
Ignore user cancellation errors.

* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_server_account_get_password() and
modest_server_account_get_has_password() to avoid direct use of
conf enums.

* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_init): Store the notebook so we can
use it later.
Added modest_account_settings_dialog_switch_to_user_info().

* src/modest-tny-account-store.c:
(get_password): When the password in the account settings is wrong (we think),
show the relevant page of the account settings dialog, in the mainloop.
However, we currently get many of these at once because cancel does not
seem to cancel.
(forget_password): Do not forget the password
from the account settings, because this causes side-effects when
tinymail seems to call it at strange time, maybe because of how we
are cancelling get_password().
(modest_tny_account_store_alert): Ignore user cancellations.

pmo-trunk-r2657

16 years ago * The set_first_account_as_default does no longer select the same account than the...
Sergio Villar Senin [Mon, 9 Jul 2007 17:18:32 +0000 (17:18 +0000)]
* The set_first_account_as_default does no longer select the same account than the one it currently has

pmo-trunk-r2656

16 years ago* set the uber-ugly thumbable scrollbar as required by the spec. for main, viewer...
Dirk-Jan C. Binnema [Mon, 9 Jul 2007 16:19:53 +0000 (16:19 +0000)]
* set the uber-ugly thumbable scrollbar as required by the spec. for main, viewer and editor
  fixes: NB#62858

pmo-trunk-r2655

16 years ago * Removed some comments
Sergio Villar Senin [Mon, 9 Jul 2007 15:59:12 +0000 (15:59 +0000)]
* Removed some comments
* Fixed the removal of accounts, now the cache is deleted again
* Fixed a bug when retrieving server accouns, that could cause crashes when refreshing the accounts

pmo-trunk-r2654

16 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Mon, 9 Jul 2007 14:59:28 +0000 (14:59 +0000)]
* src/modest-ui-dimming-rules.c:
        * We also dim if there's no folder nor message selected
          (fixes NB#60595).

pmo-trunk-r2653

16 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Mon, 9 Jul 2007 14:47:45 +0000 (14:47 +0000)]
* src/modest-ui-dimming-rules.c:
        * Dim delete action for archive folder.

pmo-trunk-r2652

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 9 Jul 2007 14:26:18 +0000 (14:26 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we truncate multiline pastes to first line in
          subject (fixes NB#62320).

pmo-trunk-r2651

16 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Mon, 9 Jul 2007 14:12:42 +0000 (14:12 +0000)]
* src/widgets/modest-header-view-render.c:
        * Change the way we set the grey color in the field that
          require this. This way when we select a header, it does not
          get black color.
* src/widgets/modest-header-view.c:
        * Added alignments to fields of the header, to make the message
          appear clearly separated (fixes NB#62262).

pmo-trunk-r2650

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Mon, 9 Jul 2007 13:25:42 +0000 (13:25 +0000)]
* src/modest-ui-actions.c:
        * Now we really copy from GtkHTML widgets (this widget was
          not considered in _on_copy) (fixes NB#61491).
* src/modest-msg-edit-window.c:
        * Now we update the dimming status of "paste" only on showing
          edit menu.

pmo-trunk-r2649

16 years ago* src/maemo/modest-icon-names.h:
Jose Dapena Paz [Mon, 9 Jul 2007 12:59:07 +0000 (12:59 +0000)]
* src/maemo/modest-icon-names.h:
        * Add maemo icons for next, previous and find in page.
* src/maemo/modest-main-window-ui.h, src/maemo/modest-msg-view-window.c:
        * Use the maemo theme icons for next, previous and find in page
          toolbar buttons (fixes NB#61158).

pmo-trunk-r2648

16 years agoThe set_pass_func is not always the last to set
Philip Van Hoof [Mon, 9 Jul 2007 11:44:11 +0000 (11:44 +0000)]
The set_pass_func is not always the last to set

pmo-trunk-r2647

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 9 Jul 2007 11:23:24 +0000 (11:23 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Improved the way we get the files to attach. Now we get
          correctly the filenames if they come from a remote uri. Now
          the filenames get the escapes removed too. And we get the
          mime types better.

pmo-trunk-r2646

16 years agoUpdate ChangeLog2: This fixes projects.maemo.org bug NB#62646
Murray Cumming [Mon, 9 Jul 2007 11:15:51 +0000 (11:15 +0000)]
Update ChangeLog2: This fixes projects.maemo.org bug NB#62646

pmo-trunk-r2645

16 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 11:14:59 +0000 (11:14 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/maemo/modest-maemo-utils.h:
* src/maemo/modest-maemo-utils.c:
Added modest_maemo_show_information_note_and_forget() for use instead of
gtk_dialog_run() when the response is not needed, to avoid an extra
mainloop which could cause a hang.

* src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
Use the logical IDs for the error message, though they are not
specific enough. Note that I used modest_maemo_show_information_note_and_forget()
because gtk_dialog_run() caused a hang here (the window did not close).

pmo-trunk-r2644

16 years agoAdded the fixes made.
Dirk-Jan C. Binnema [Mon, 9 Jul 2007 10:39:06 +0000 (10:39 +0000)]
Added the fixes made.

pmo-trunk-r2643

16 years ago* Some changes to cancel sending operation
Javier Fernandez Garcia-Boente [Mon, 9 Jul 2007 10:37:14 +0000 (10:37 +0000)]
* Some changes to cancel sending operation
using ModestTnySendQueue.

pmo-trunk-r2642

16 years ago* add some argument checking to
Dirk-Jan C. Binnema [Mon, 9 Jul 2007 09:14:29 +0000 (09:14 +0000)]
* add some argument checking to
  modest_tny_account_store_get_transport_account_for_open_connection
  that might help with #62210

pmo-trunk-r2641

16 years ago * Fixes NB#60725 which affects systest, now an information note is shown instead...
Sergio Villar Senin [Mon, 9 Jul 2007 08:50:13 +0000 (08:50 +0000)]
* Fixes NB#60725 which affects systest, now an information note is shown instead of a information banner when notifying the user that an attachments has no registered viewer

pmo-trunk-r2640

16 years agoSetting the headers to SEEN after deleting them
Philip Van Hoof [Mon, 9 Jul 2007 08:32:44 +0000 (08:32 +0000)]
Setting the headers to SEEN after deleting them

pmo-trunk-r2639

16 years ago* Enable modest-tny-send-queue to store information about
Javier Fernandez Garcia-Boente [Mon, 9 Jul 2007 08:30:17 +0000 (08:30 +0000)]
* Enable modest-tny-send-queue to store information about
mails to be sent.
* Sending operation wont show progress information.
* Implement cancel sending operation by setting SUSPENDED priority
flags on all outbox headers.
* Fixes: NB#58571, NB#60517, NB#60916, NB#62448

pmo-trunk-r2638

16 years ago2007-07-09 Murray Cumming <murrayc@murrayc.com>
Murray Cumming [Mon, 9 Jul 2007 08:28:11 +0000 (08:28 +0000)]
2007-07-09  Murray Cumming  <murrayc@murrayc.com>

* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_account_mgr_get_store_protocol().

* src/maemo/modest-account-view-window.c:
(on_delete_button_clicked): Show different warning text depending on
the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
NB#59037.

pmo-trunk-r2637

16 years ago * Fixes NB#62776 which affects systest, now the root folders shows the main view...
Sergio Villar Senin [Mon, 9 Jul 2007 08:20:08 +0000 (08:20 +0000)]
* Fixes NB#62776 which affects systest, now the root folders shows the main view help when help is clicked in their CSM

pmo-trunk-r2636

16 years ago* src/widgets/modest-details-dialog.c:
Jose Dapena Paz [Mon, 9 Jul 2007 07:45:10 +0000 (07:45 +0000)]
* src/widgets/modest-details-dialog.c:
        * Now we show the "created" field for all types. In particular
          it shows proper date information for outbox and drafts folder
          (fixes NB#58615).

pmo-trunk-r2635

16 years ago * Modest was not replying to messages in the msg view window due to the lack of...
Sergio Villar Senin [Mon, 9 Jul 2007 07:13:14 +0000 (07:13 +0000)]
* Modest was not replying to messages in the msg view window due to the lack of this check

pmo-trunk-r2634

16 years ago* restore the window-icons
Dirk-Jan C. Binnema [Mon, 9 Jul 2007 05:47:10 +0000 (05:47 +0000)]
* restore the window-icons

pmo-trunk-r2633