Javier Fernandez Garcia-Boente [Wed, 8 Aug 2007 09:37:32 +0000 (09:37 +0000)]
* Implement optimizations on DimmingRules management.
* Copy/Cut/Paste dimming rules of Editor are not working fine;
it does not take into account if something was selected or not.
These changes on src/maemo/modest-msg-edit-window.c try to
solve these problems, with no success at this moment.
* Fixes: NB#64553
pmo-trunk-r2947
Dirk-Jan C. Binnema [Wed, 8 Aug 2007 07:29:48 +0000 (07:29 +0000)]
Added fixed bugs and release notes to the changelog, week 32 pre release - 8th Aug.
pmo-trunk-r2946
Javier Fernandez Garcia-Boente [Tue, 7 Aug 2007 19:24:47 +0000 (19:24 +0000)]
* Check folder type in folder comparison.
* Fixes: NB#63055
pmo-trunk-r2945
Javier Fernandez Garcia-Boente [Tue, 7 Aug 2007 18:05:24 +0000 (18:05 +0000)]
* Call send-queue-flush when account is edited and changed,
and also at startup.
pmo-trunk-r2944
Philip Van Hoof [Tue, 7 Aug 2007 10:13:53 +0000 (10:13 +0000)]
Fixing API changes
pmo-trunk-r2941
Javier Fernandez Garcia-Boente [Mon, 6 Aug 2007 18:34:14 +0000 (18:34 +0000)]
* fix some issues on progress-bar to show more pulses on
undetermined progress data.
* Define again a OPEN type mail-operation for cached messages.
* Fixes bug: NB#56201
pmo-trunk-r2940
Javier Fernandez Garcia-Boente [Mon, 6 Aug 2007 15:20:14 +0000 (15:20 +0000)]
* Set some g_return_if_fail because i notice some random
chrashed trying to add one account, when it gets the private
structure of ModestaccountView widget.
pmo-trunk-r2939
Javier Fernandez Garcia-Boente [Mon, 6 Aug 2007 14:57:51 +0000 (14:57 +0000)]
* Removed a g_return_if_fail because this function
is called from show_tollbar method with NULL in account
parameter.
pmo-trunk-r2938
Javier Fernandez Garcia-Boente [Mon, 6 Aug 2007 14:05:52 +0000 (14:05 +0000)]
* Fixed some bug on account_number_changed signal handler.
The fisrt parameter, account_name, was declared as string,
but account-remove, account-inserted, and account-changed
emmits a signal with a TnyAccount type parameter.
pmo-trunk-r2937
Dirk-Jan C. Binnema [Mon, 6 Aug 2007 13:59:37 +0000 (13:59 +0000)]
Added fixed bugs to the changelog, week 32 pre release - 6th Aug.
pmo-trunk-r2936
Philip Van Hoof [Mon, 6 Aug 2007 08:17:15 +0000 (08:17 +0000)]
2007-08-06 Philip Van Hoof <pvanhoof@gnome.org>
* GDK lock awareness
pmo-trunk-r2935
Johannes Schmid [Sat, 4 Aug 2007 14:15:36 +0000 (14:15 +0000)]
2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
* src/modest-text-utils.c:
Fixed invalid jump due to incorrect string/pointer
operation.
(See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
for details)
pmo-trunk-r2934
Jose Dapena Paz [Fri, 3 Aug 2007 22:20:13 +0000 (22:20 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_create_folder): now, if we push create
folder in a pop folder, unable to create folder information
banner is shown (fixes NB#64001).
pmo-trunk-r2933
Jose Dapena Paz [Fri, 3 Aug 2007 22:00:40 +0000 (22:00 +0000)]
* src/maemo/modest-account-settings-dialog.c:
* Now we show the "settings saved" or "settings" failed
information banners again (we were parenting it with the
dialog we were closing, so the dialog was not saved)
(fixes NB#63748).
pmo-trunk-r2932
Jose Dapena Paz [Fri, 3 Aug 2007 21:45:58 +0000 (21:45 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now the removing attachments banner is shown after 2 seconds
of progress of the operation, and not at the end of the
operation (fixes NB#63026).
pmo-trunk-r2931
Jose Dapena Paz [Fri, 3 Aug 2007 19:41:34 +0000 (19:41 +0000)]
* src/modest-text-utils.c:
* Now derived subject composes a string with no subject
also for a "" subject.
* src/widgets/modest-attachment-view.c:
* If subject is "", we also show no subject string
* src/modest-tny-msg.c:
* If we are forwarding, and the mail is formatted in html,
we forward the message as attachment (fixes NB#62261).
* src/modest-formatter.[ch]:
* Fixed modest_formatter_attach, to attach the TnyMsg instead
of a mime part.
pmo-trunk-r2930
Jose Dapena Paz [Fri, 3 Aug 2007 18:43:54 +0000 (18:43 +0000)]
Improvements in focus management of Check names operation
(fixes NB#59427).
* src/widgets/modest-recpt-editor.[ch]:
* New method (modest_recpt_editor_has_focus). This is used
to be able to know if a recipient editor text view is
focused.
* src/maemo/modest-address-book.c:
* Removed all recipient editor focus management. Now we rely
on the window implementation.
* src/maemo/modest-msg-edit-window.c:
* Now we set focus of the failing recipient editor in check
names if it fails.
* If check names does not fail, and focus is in a recipient
field, it does not change the focus from them to to: field.
pmo-trunk-r2929
Jose Dapena Paz [Fri, 3 Aug 2007 18:14:23 +0000 (18:14 +0000)]
* src/widgets/modest-msg-view.c:
* (idle_readjust_scroll): hackish solution to force a
scroll readjustment (setting 1.0 and 0.0 in the same handler
and after showing the widget for the first time). This way
we don't get a broken scroll with stylus (fixes NB#62820).
pmo-trunk-r2928
Javier Fernandez Garcia-Boente [Fri, 3 Aug 2007 15:26:09 +0000 (15:26 +0000)]
* Added some coments/mark in all gdk_threads_enter
to document what is their purpose on each funciton.
pmo-trunk-r2927
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 14:17:06 +0000 (14:17 +0000)]
* fix NB#64931, cleaning up the details fields a bit.
pmo-trunk-r2926
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 12:24:40 +0000 (12:24 +0000)]
removed a released bug from the changelog, week 31 post release - 3rd Aug.
pmo-trunk-r2925
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 12:01:21 +0000 (12:01 +0000)]
Added new fixes to changelog, week 31 post release - 3rd Aug.
pmo-trunk-r2924
Peter Csaszar [Fri, 3 Aug 2007 10:22:59 +0000 (10:22 +0000)]
Remove of an false warning.
pmo-trunk-r2922
Peter Csaszar [Fri, 3 Aug 2007 10:09:40 +0000 (10:09 +0000)]
An ref/unref problem resolved, but there might be another one.
pmo-trunk-r2921
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 09:52:31 +0000 (09:52 +0000)]
* check for a valid foldername
Fixes: NB#58923
pmo-trunk-r2920
Dirk-Jan C. Binnema [Fri, 3 Aug 2007 09:47:02 +0000 (09:47 +0000)]
* add a function to check for valid folder name;
we do a comprehensive test, also disallowing names which are not
valid on Windows filesystems (like AUX, or ':'); thus, it
should also work on MMC, and also make sure that user-created local folders
can be moved there.
pmo-trunk-r2919
Peter Csaszar [Fri, 3 Aug 2007 08:00:02 +0000 (08:00 +0000)]
fixed crash:modest-mail-operation.c:on_refresh_folder:priv==NULL
pmo-trunk-r2917
Jose Dapena Paz [Thu, 2 Aug 2007 20:52:41 +0000 (20:52 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now we don't show an information banner on trying to view
a purged attachment (fixes NB#63498).
pmo-trunk-r2916
Javier Fernandez Garcia-Boente [Thu, 2 Aug 2007 20:21:44 +0000 (20:21 +0000)]
* Move tny_folder_sync after remove operation and define it
on modest-ui-actions, when all messages have been removed.
* Review progress-bar widget to get more information when
undetermined data is come back from camel-operation.
* Move header_view_refilter operation, defined in
folder_monitor_update to main_window, which is an observer
of headers view. Sometimes, refilter operation was done before
model was updated, causing several crashes.
pmo-trunk-r2915
Jose Dapena Paz [Thu, 2 Aug 2007 20:06:31 +0000 (20:06 +0000)]
* src/widgets/modest-attachment-view.c:
* Now get size thread worker is not anymore a mail operation,
so the implementation is moved here. This should prevent
some bad issues with getting uncancellable operations in
mail operation queue, and then, causing hanges.
* src/modest-mail-operation.[ch]:
* Now get mime part size is not anymore a mail operation, so
this has been removed from here.
pmo-trunk-r2914
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 16:57:15 +0000 (16:57 +0000)]
* optimize _modest_account_mgr_get_account_keyname, which was showing
at the top of the startup profiles. now, no longer escape/allocate strings
if that's not needed
pmo-trunk-r2913
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 16:40:07 +0000 (16:40 +0000)]
* fix the checks a bit; don't try to top the window before checking it has been created
pmo-trunk-r2912
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 16:38:57 +0000 (16:38 +0000)]
* let the window manager close only after the mail-operations-queue is empty,
recheck every 3 secs, and close anyway after a given timeout (30 sec. now).
this should help with the bugs were mail was corrupted when sending it.
pmo-trunk-r2911
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 13:39:00 +0000 (13:39 +0000)]
* when the window-manager is asked for the main_window, and none such
exists, create one in place. the fix in modest_window_mgr is trivial,
but it would crash immediately because of old signal handlers still
be invoked; now, we clear all signal handlers when destroy a main_window
Fixes: NB#59752
pmo-trunk-r2910
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 13:35:22 +0000 (13:35 +0000)]
* add modest-signal-mgr, some small utility functions for gobject to
remember what g_signal_connects they did, and make sure they are all
disconnected when you finalize the object; this was needed for a bugfix
pmo-trunk-r2909
Jose Dapena Paz [Thu, 2 Aug 2007 10:55:54 +0000 (10:55 +0000)]
* src/modest-tny-send-queue.c:
* Now it shows a "message sent" information banner on successing
to send a message (fixes NB#63356).
pmo-trunk-r2908
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 10:48:55 +0000 (10:48 +0000)]
Added new fixes to changelog, will be part of week 32 release- week 31 - 2nd Aug.
pmo-trunk-r2907
Dirk-Jan C. Binnema [Thu, 2 Aug 2007 07:20:58 +0000 (07:20 +0000)]
* with the latest tinymail, there is no need to force a refresh
of the folder model anymore, when the account name changes.
pmo-trunk-r2905
Jose Dapena Paz [Thu, 2 Aug 2007 06:41:08 +0000 (06:41 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_xfer_messages_from_move_to): now we
show an information banner on trying to move messages to a pop
folder as this is not allowed (fixes NB#63285).
pmo-trunk-r2904
Jose Dapena Paz [Thu, 2 Aug 2007 06:04:26 +0000 (06:04 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_on_delete_folder): now we focus inbox
folder on finishing the delete folder operation (fixes
NB#63239).
pmo-trunk-r2903
Javier Fernandez Garcia-Boente [Wed, 1 Aug 2007 21:36:50 +0000 (21:36 +0000)]
* Review Move_to dimming rules to check for ROOT folders,
or INBOX or SENT, DRAFT and OUTBOX special folder.
* Fixes: NB#62939
pmo-trunk-r2902
Jose Dapena Paz [Wed, 1 Aug 2007 18:30:06 +0000 (18:30 +0000)]
* src/widgets/modest-recpt-editor.c:
* Modified the maximum number of lines, to 1024. Practically,
it means the field has an "unlimited" number of lines
(fixes NB#63209).
pmo-trunk-r2901
Murray Cumming [Wed, 1 Aug 2007 18:29:35 +0000 (18:29 +0000)]
2007-08-01 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_account_mgr_get_first_account_name(),
using code from modest_account_mgr_set_first_account_as_default().
* src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
(account_number_changed): Call set_at_least_one_account_visible() so that
the first account is visible when first added, without the user having to
use the View menu.
I do wonder how this worked before.
pmo-trunk-r2900
Jose Dapena Paz [Wed, 1 Aug 2007 18:01:10 +0000 (18:01 +0000)]
* src/modest-text-utils.c:
* (modest_text_utils_validate_email_address): a domain part
that finishes with a dot (for example "a@b.") is not valid
(fixes NB#63204).
pmo-trunk-r2899
Jose Dapena Paz [Wed, 1 Aug 2007 17:21:39 +0000 (17:21 +0000)]
* src/maemo/modest-msg-edit-window.c:
* A missing else was breaking save to drafts deletion of
old draft.
* src/modest-mail-operation.c:
* Now save to drafts first adds the new message, and then
removes the old one.
* Now save to drafts folder sync is asynchronous.
pmo-trunk-r2898
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 16:35:15 +0000 (16:35 +0000)]
* fix some of the tedious value checking, as specified in
NB#59361 (which is fixed now)
pmo-trunk-r2896
Jose Dapena Paz [Wed, 1 Aug 2007 16:28:24 +0000 (16:28 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Added entry verification in subject field. In particular we
discard the bullet special unicode character (fixes NB#62721).
pmo-trunk-r2895
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 16:07:37 +0000 (16:07 +0000)]
* the real fix for NB#64809, the previous accidentaly
fixed the same issue in the normal account setup, now we're
fixing it for the connection-specific smtp servers as well.
also fixed the label for the Port number
pmo-trunk-r2894
Murray Cumming [Wed, 1 Aug 2007 16:07:11 +0000 (16:07 +0000)]
2007-08-01 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (show_password_warning_only),
(show_wrong_password), (request_password_and_wait), (get_password),
(modest_tny_account_store_alert): Remove the (incomplete anyway)
attempts to show UI only in the main context, which used g_idle_add()
and mainloops, because tinymail now guarantees that it only calls these
callbacks in the mainloop with the gdk lock. This makes everything much
simpler.
pmo-trunk-r2893
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 15:45:03 +0000 (15:45 +0000)]
* validate the domain names
Fixes: NB#64809
pmo-trunk-r2892
Murray Cumming [Wed, 1 Aug 2007 15:16:04 +0000 (15:16 +0000)]
2007-08-01 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
error dialog, instead of ignoring it.
pmo-trunk-r2891
Alberto Garcia [Wed, 1 Aug 2007 14:26:43 +0000 (14:26 +0000)]
* Use the correct translation string instead of a fixed one when
trying to save several attachments (Fixes: NB#63764)
pmo-trunk-r2890
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 14:24:55 +0000 (14:24 +0000)]
* port numbers should be in the range [1,65535], 0 is not valid.
Fixes: #NB64831
pmo-trunk-r2889
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 13:27:11 +0000 (13:27 +0000)]
* more changes to the account management; now the following should work again:
- changing account names (updates modest-account-view, and modest-folder-view)
- expand root folders
- change modest-account-mgr to only emit change signals once per 500ms
- modest-account-mgr changes notification now only give the "parent account",
not the server account, and not for every single key
- accounts are changed, not recreated
pmo-trunk-r2888
Jose Dapena Paz [Wed, 1 Aug 2007 12:41:30 +0000 (12:41 +0000)]
* src/maemo/modest-progress-bar-widget.c:
* Now we show the undetermined string for receiving and sending
when we're getting only one message. This should fit the
optional ammendment in UI specs (fixes NB#56182).
pmo-trunk-r2887
Murray Cumming [Wed, 1 Aug 2007 11:54:01 +0000 (11:54 +0000)]
2007-08-01 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-msg-view-window.c:
(modest_msg_view_window_get_header),
(modest_msg_view_window_last_message_selected):
Added comments to explain the use of priv->header_model.
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_open_msg),
(modest_ui_dimming_rules_on_mark_as_read_msg),
(modest_ui_dimming_rules_on_mark_as_unread_msg),
(modest_ui_dimming_rules_on_remove_attachments),
(_invalid_attach_selected), (_selected_msg_marked_as):
Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
and changed the parameter to a ModestMainWindow to make it clearer that
it never uses any other kind of window.
Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
instead of the selected message.
I notice that much of the dimming code and the ModestMsgViewWindow code
hard-codes the assumption that the viewed message is always selected in
the header view. This does not seem wise or simple.
(modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
examine the actual message instead of whatever might be selected
in the header view. This stops the delete toolbar button and menu item
from being dimmed when opening a message view the search UI,
partially fixing projects.maemo.org bug NB#63811.
However, when actually deleting, I now get this warning:
tny_header_set_flags: This is a header instance for a new message.
Only priority and attachment flags are supported
pmo-trunk-r2886
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 10:41:49 +0000 (10:41 +0000)]
* forgot to commit this
pmo-trunk-r2885
Jose Dapena Paz [Wed, 1 Aug 2007 09:16:47 +0000 (09:16 +0000)]
* src/widgets/modest-msg-view.c:
* Modified the html adjustment change handler to prevent some
infinite recursions. In particular one happening on removing
attachments.
* src/widgets/modest-attachment-view.c:
* Add support for showing purged attached messages.
* src/modest-ui-dimming-rules.c:
* Now we don't dim remove attachments for message attachments in
view, as we now support this (fixes NB#64068).
pmo-trunk-r2884
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 08:44:29 +0000 (08:44 +0000)]
* step 2 of the account fixes; for now, account changes
are turned-off, as we get hangs when we get alert-popups
pmo-trunk-r2883
Jose Dapena Paz [Wed, 1 Aug 2007 07:26:51 +0000 (07:26 +0000)]
* src/widgets/modest-msg-edit-window.h,
src/maemo/modest-msg-edit-window.c:
* New method (modest_msg_edit_window_get_message_uid), that
gets the message uid of the current draft or outbox message
the mail was openend from.
* src/widgets/modest-window-mgr.c:
* Modify all the message register methods, to add support for
also registering edit windows (fixes NB#64714).
pmo-trunk-r2882
Jose Dapena Paz [Wed, 1 Aug 2007 06:50:59 +0000 (06:50 +0000)]
* src/modest-text-utils.[ch]:
* New (modest_text_utils_get_email_address) function, that
obtains the email address email@address from a full
address Full Address <email@address>.
* src/maemo/modest-address-book.c:
* (modest_address_book_add_address): now we add the email part
of an address to the addressbook, instead of the full address
(fixes NB#64733).
pmo-trunk-r2881
Dirk-Jan C. Binnema [Wed, 1 Aug 2007 06:19:46 +0000 (06:19 +0000)]
* added modest_tny_account_update_from_server_account_name, we need
this function for the new account management. this is done by refactoring
some code -- the functions here are much too long anyway, which makes
maintenance / refactoring / fixing hard.
no functional changes yet.
pmo-trunk-r2880
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 20:53:05 +0000 (20:53 +0000)]
* don't try to load some icons which are not present,
and we're not using anyway. saves some runtime warnings
pmo-trunk-r2879
Javier Fernandez Garcia-Boente [Tue, 31 Jul 2007 18:37:05 +0000 (18:37 +0000)]
* Review dimming rules about mark as read/unread headers.
Now, rules considerd that all headers must be equal to dim
or not menu options.
* Fixes: NB#60676
pmo-trunk-r2878
Javier Fernandez Garcia-Boente [Tue, 31 Jul 2007 17:37:15 +0000 (17:37 +0000)]
* Show progress data of the first queued mail operation.
* Show a initial message avoiding show empty progress bar
while async operation does not send back progress information.
* Fixes: NB#60517
pmo-trunk-r2877
Jose Dapena Paz [Tue, 31 Jul 2007 17:16:52 +0000 (17:16 +0000)]
* src/maemo/modest-msg-edit-window.c:
* We make the max image with even smaller, to avoid confusion
having in one line a full image and a small character.
* Now we correct the scroll position to show the cursor if
the text view is focused and the cursor is not really visible.
Calculation of cursor visibility is done manually, and after
last text view size update. This way we finally get the cursor
at its proper position on inserting big images (fixes
NB#62829).
pmo-trunk-r2876
Jose Dapena Paz [Tue, 31 Jul 2007 15:44:38 +0000 (15:44 +0000)]
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
* Set "Other..." option as the first in providers combobox.
* Use the logical id (fixes NB#64683).
pmo-trunk-r2875
Jose Dapena Paz [Tue, 31 Jul 2007 15:32:04 +0000 (15:32 +0000)]
* src/widgets/modest-recpt-editor.c:
* Fix some recursion errors in validation methods
(fixes NB#64721).
pmo-trunk-r2873
Jose Dapena Paz [Tue, 31 Jul 2007 14:09:30 +0000 (14:09 +0000)]
* src/modest-ui-actions.c:
* On deleting messages from viewer, if there's no next message
or user cancels retrieving next message, we close the window
(fixes NB#64684).
* src/modest-mail-operation.c:
* Get the TnyCamelMemStream type before opening threads so that
we don't get the initial type in parallel from two threads
(due to a possible thread problem in gtype system).
pmo-trunk-r2872
Javier Fernandez Garcia-Boente [Tue, 31 Jul 2007 13:37:55 +0000 (13:37 +0000)]
* Review dimming rules _selected_msg_sent_in_progress
utility function, searching into all send-queues,
rather than current active account send-queue.
* Fixes: NB#62702
pmo-trunk-r2871
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 13:13:23 +0000 (13:13 +0000)]
Added new fixes and merges added into changelog - week 31 - 31th july.
pmo-trunk-r2870
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 12:37:47 +0000 (12:37 +0000)]
* this one too, belongs to the prev. commit
pmo-trunk-r2869
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 12:36:22 +0000 (12:36 +0000)]
* restore some functionality after the changes, by reenabling the key-changed
signal in modest-account-mgr, and change it's listeners.
Note: updating account name in the Accounts dialog works now; but it's not
propagated correctly to the account in the folder view yet.
pmo-trunk-r2868
Philip Van Hoof [Tue, 31 Jul 2007 08:35:45 +0000 (08:35 +0000)]
Compilation fix
pmo-trunk-r2867
Philip Van Hoof [Tue, 31 Jul 2007 08:24:20 +0000 (08:24 +0000)]
2007-07-31 Philip Van Hoof <pvanhoof@gnome.org>
* Merging back devel/sessionwork to trunk/
pmo-trunk-r2866
Jose Dapena Paz [Tue, 31 Jul 2007 08:19:43 +0000 (08:19 +0000)]
* src/modest-text-utils.[ch]:
* New method (modest_text_utils_text_buffer_get_text): wrapper
around gtk_text_buffer_get_slice, that replaces the image
pixbuf special character 0xFFFC with a blank space.
* src/modest-msg-edit-window.c:
* Use the new modest_text_utils_text_buffer_get_text to get the
plain body representation of a formatted html mail. This
makes a mail with only images return a length greater than 0
(fixes NB#64627).
pmo-trunk-r2865
Johannes Schmid [Tue, 31 Jul 2007 08:05:46 +0000 (08:05 +0000)]
2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
* src/modest-ui-actions.c: (modest_ui_actions_on_send):
Show account wizard if no accounts are defined while sending
(automatic sending after the account wizard finished does not
work because it takes some time until the accoun
pmo-trunk-r2862
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 07:42:45 +0000 (07:42 +0000)]
Added new fixes to changelog - week 31 - 31th july.
pmo-trunk-r2861
Dirk-Jan C. Binnema [Tue, 31 Jul 2007 07:07:05 +0000 (07:07 +0000)]
* explicitely undim the Ok-button after an entry_changed, so Ok is enabled
again after the some condition that made it disabled before, disappears.
Fixes: NB#64621
pmo-trunk-r2860
Jose Dapena Paz [Mon, 30 Jul 2007 17:09:29 +0000 (17:09 +0000)]
* src/modest-ui-actions.c:
* If we get a folder empty selection, and focus is in
headers view, move focus to folder view.
* src/maemo/modest-main-window.c:
* If the message count of the folder is 0 then move the focus to
the folder view (fixes NB#63198).
pmo-trunk-r2859
Jose Dapena Paz [Mon, 30 Jul 2007 16:13:11 +0000 (16:13 +0000)]
* src/maemo/modest-address-book.c:
* Now check names information banner can only be shown if the
operation lasts for more than 2 seconds (fixes NB#63057).
pmo-trunk-r2858
Jose Dapena Paz [Mon, 30 Jul 2007 15:46:53 +0000 (15:46 +0000)]
* src/widgets/modest-recpt-editor.c:
* WOps, forgot to take into account quoted address names.
With this we really fix NB#62993.
pmo-trunk-r2857
Jose Dapena Paz [Mon, 30 Jul 2007 15:35:44 +0000 (15:35 +0000)]
* src/widgets/modest-recpt-editor.c:
* Now validation functions remove \n and \t characters
* Now validation functions add a \n after each , or ; if they're
not at the end, and no \n has been inserted before
* Now we validate the string on set_recipients. This way, the
characters get proper layout on setting fields in editor
(fixes NB#62993).
pmo-trunk-r2856
Murray Cumming [Mon, 30 Jul 2007 14:55:58 +0000 (14:55 +0000)]
2007-07-30 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (on_account_removed),
(on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
account is removed from the View menu. We have TnyAccountStore
and ModestTnyAccountStore signals that seem very similar, but this
seems to work for now.
* src/maemo/modest-main-window.c:
(on_show_account_action_activated): Prevent dereference
of a NULL if the accoutn does not really exist, though that
should not happen anymore.
This fixes projects.maemo.org bug NB#64606.
pmo-trunk-r2855
Dirk-Jan C. Binnema [Mon, 30 Jul 2007 14:52:04 +0000 (14:52 +0000)]
Added new fixes to changelog - week 31 - 30th july.
pmo-trunk-r2854
Jose Dapena Paz [Mon, 30 Jul 2007 14:05:07 +0000 (14:05 +0000)]
* src/maemo/modest-account-settings-dialog.c:
* (create_page_user_details): use a scrolled window for options
so that showing vkb does not hide the ok/cancel buttons. We
also add proper focus adjustment (fixes NB#64537).
* (create_page_outgoing): add proper focus adjustment.
pmo-trunk-r2852
Jose Dapena Paz [Mon, 30 Jul 2007 13:44:54 +0000 (13:44 +0000)]
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added 80% and 120% to editor so that we use the zoom levels
specified in Email UI specs 2.2 document wiki. Fixes NB#61337.
pmo-trunk-r2851
Jose Dapena Paz [Mon, 30 Jul 2007 13:35:02 +0000 (13:35 +0000)]
* src/maemo/modest-main-window.c:
* Show only "Send&Receive/All" option when there are 2 or more
accounts. The older condition was "there are 1 or more"
(fixes NB#59238).
pmo-trunk-r2850
Jose Dapena Paz [Mon, 30 Jul 2007 13:07:41 +0000 (13:07 +0000)]
* src/modest-tny-msg.[ch]:
* (create_reply_forward_mail): now get a TnyHeader attribute
for the case we don't have a full TnyMsg available.
* (modest_tny_msg_create_forward_msg): use the new
create_reply_forward_mail api.
* (modest_tny_msg_create_reply_msg): now it gets a TnyHeader
parameter for the case there's no TnyMsg available (it should
happen at least on replying without original message in main
window.
* src/modest-ui-actions.c:
* (reply_forward_cb): uses the new
modest_tny_msg_create_reply_msg api.
* (reply_forward_cb): now we don't free the header parameter
in this callback, as this should be done by callers.
* (reply_forward): now we don't show the retrieve confirmation
dialog on replying without original message in reply. We don't
retrieve the original message too (fixes NB#63674).
pmo-trunk-r2849
Jose Dapena Paz [Mon, 30 Jul 2007 11:23:39 +0000 (11:23 +0000)]
* src/maemo/modest-platform.c:
* (modest_platform_run_folder_name_dialog): we don't show
insensitive information banner for ok button (fixes NB#64174).
pmo-trunk-r2847
Jose Dapena Paz [Mon, 30 Jul 2007 11:15:49 +0000 (11:15 +0000)]
* src/modest-tny-msg.[ch]:
* Now modest_tny_msg_get_body tells if the original body was
plain text or html.
* src/widgets/modest-msg-edit-window.h:
* Now modest_msg_edit_window_new gets a new parameter
preserve_is_rich, that sets the format to the one in the
original message in case it's set.
* src/maemo/modest-msg-edit-window.c:
* Preserves the plain text format in case it's requested
(fixes NB#64170).
* Now we reset modified status on constructor to prevent getting
modifications from construction process.
* src/modest-ui-actions.c:
* Use the new modest_msg_edit_window_new api. For messages
opened from drafts, it preserves the format (plain or html).
For other messages, it respects the configuration preference.
* src/gnome/modest-msg-edit-window.c:
* Fill the new is_html parameter in modest_tny_msg_new method.
pmo-trunk-r2846
Javier Fernandez Garcia-Boente [Mon, 30 Jul 2007 10:38:58 +0000 (10:38 +0000)]
* Outbox messsages are opened in edit window.
* If they are modifed, they are saved to draf if ther was not send.
* Otherwise, they are saved again into outbox
* Messages which are being edited are excluded from sent-queue.
* Fixes: NB#57915
pmo-trunk-r2843
Jose Dapena Paz [Mon, 30 Jul 2007 09:46:26 +0000 (09:46 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Fixed an error in the condition to change colors in
modest_msg_edit_window_set_format_state. The condition to
declare a changeset was reversed.
* (modest_msg_edit_window_set_format_state): now we set
the bullet attribute out of the freeze/thaw region, as
bullet format is applied only if not frozen (fixes NB#63500).
pmo-trunk-r2842
Murray Cumming [Mon, 30 Jul 2007 08:22:37 +0000 (08:22 +0000)]
2007-07-30 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (run_account_setup_wizard),
(modest_ui_actions_on_accounts): Revert a change that set these
to modal dialogs, freezing the UI when they show secondary dialogs.
This fixed projects.maemo.org bug NB#64519.
pmo-trunk-r2839
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 18:40:30 +0000 (18:40 +0000)]
* small optimization; we don't need to retrieve name, message count for the
icon-cell rendering.
pmo-trunk-r2836
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 16:51:36 +0000 (16:51 +0000)]
* refresh header view after deleting a message from outbox.
fixes: NB#63428, and maybe some others (will check)
pmo-trunk-r2834
Jose Dapena Paz [Fri, 27 Jul 2007 16:37:36 +0000 (16:37 +0000)]
* src/modest-ui-actions.c:
* Added modality and transiency for settings, accounts,
header and folder details (fixes NB#64326).
pmo-trunk-r2833
Jose Dapena Paz [Fri, 27 Jul 2007 16:19:11 +0000 (16:19 +0000)]
* src/modest-ui-dimming-rules.c:
* Now rename is disabled also for "Archive" folder
(fixes NB#64259).
pmo-trunk-r2832
Dirk-Jan C. Binnema [Fri, 27 Jul 2007 16:07:03 +0000 (16:07 +0000)]
* don't accept folder names starting with ' ', take copy-paste into account
this should fix NB#58923
pmo-trunk-r2831
Jose Dapena Paz [Fri, 27 Jul 2007 16:05:36 +0000 (16:05 +0000)]
* src/modest-ui-actions.c:
* (modest_ui_actions_on_cut, modest_ui_actions_on_copy):
now we store the clipboard on copy operation for gtkhtml. We
add storing for all the text clipboard operations
(fixes NB#64206).
pmo-trunk-r2830