modest
15 years ago * Fixes NB#85502, show an error when the mail applications reports error sendings...
Sergio Villar Senin [Wed, 14 May 2008 17:11:45 +0000 (17:11 +0000)]
* Fixes NB#85502, show an error when the mail applications reports error sendings due to connection failures

pmo-trunk-r4528

15 years ago * Fixes NB#85519, ellipsize the account name in signature editor
Sergio Villar Senin [Wed, 14 May 2008 14:57:17 +0000 (14:57 +0000)]
* Fixes NB#85519, ellipsize the account name in signature editor

pmo-trunk-r4527

15 years ago * Added a new parameter to modest_platform_check_memory_low in order to show or...
Sergio Villar Senin [Wed, 14 May 2008 11:11:29 +0000 (11:11 +0000)]
* Added a new parameter to modest_platform_check_memory_low in order to show or not a visual notification
* Fixes NB#85299, do not crash in memory low conditions, added memory low checks to the mail operations

pmo-trunk-r4526

15 years ago * Fixes NB#85454, do not undo the disable rich text in the editor
Sergio Villar Senin [Wed, 14 May 2008 07:43:43 +0000 (07:43 +0000)]
* Fixes NB#85454, do not undo the disable rich text in the editor

pmo-trunk-r4525

15 years ago * Fixes NB#85455, close the dialogs with their parent, this avoids some possible...
Sergio Villar Senin [Tue, 13 May 2008 16:02:00 +0000 (16:02 +0000)]
* Fixes NB#85455, close the dialogs with their parent, this avoids some possible crashes when closing the windows before the dialogs

pmo-trunk-r4524

15 years ago * Fix for the new error domain in tinymail's trunk
Sergio Villar Senin [Tue, 13 May 2008 10:43:55 +0000 (10:43 +0000)]
* Fix for the new error domain in tinymail's trunk

pmo-trunk-r4520

15 years ago * Fixes NB#85428, do not use connect_and_wait when replying to messages
Sergio Villar Senin [Tue, 13 May 2008 10:34:14 +0000 (10:34 +0000)]
* Fixes NB#85428, do not use connect_and_wait when replying to messages
* Fixed a memory leak in mail_operation_get_msg

pmo-trunk-r4519

15 years ago * Fixes a warning, the selected item in folder view could be a folder store
Sergio Villar Senin [Mon, 12 May 2008 18:45:37 +0000 (18:45 +0000)]
* Fixes a warning, the selected item in folder view could be a folder store

pmo-trunk-r4518

15 years ago * removed the Fixes keyword for non accepted build packages.
Vivek Sekar [Mon, 12 May 2008 17:41:36 +0000 (17:41 +0000)]
  * removed the Fixes keyword for non accepted build packages.

pmo-trunk-r4517

15 years ago * Fixes NB#85397 show localized Archive in folder details
Sergio Villar Senin [Mon, 12 May 2008 17:29:16 +0000 (17:29 +0000)]
* Fixes NB#85397 show localized Archive in folder details
* Fixes NB#85399 show localized Inbox in folder details

pmo-trunk-r4516

15 years ago * Fixes NB#85378, show the connection specific SMTP and not the account settings...
Sergio Villar Senin [Mon, 12 May 2008 16:47:19 +0000 (16:47 +0000)]
* Fixes NB#85378, show the connection specific SMTP and not the account settings dialog when there is an error sending a message through a connection specific SMTP account
* Track the "destroy" signal for modal dialogs, it could cause the "response" not to be issued
* Fixed the connection specific SMTP dialog modality (uses the window mgr)
* Add the buttons to the connection specific SMTP dialog with gtk_dialog_add_button as it should be
* Removed an invalid while

pmo-trunk-r4515

15 years ago * Merged PE1 fixes into the pe1 branch from the trunk.
Vivek Sekar [Mon, 12 May 2008 16:14:49 +0000 (16:14 +0000)]
  * Merged PE1 fixes into the pe1 branch from the trunk.
  * added bug fixes for week 20 and updated the NEWS file

pmo-trunk-r4514

15 years ago * Set the edit and delete buttons as insensitive only if there is no account selected
Sergio Villar Senin [Mon, 12 May 2008 10:03:55 +0000 (10:03 +0000)]
* Set the edit and delete buttons as insensitive only if there is no account selected

pmo-trunk-r4513

15 years ago * Removed unused ChangeLog2
Sergio Villar Senin [Mon, 12 May 2008 09:35:05 +0000 (09:35 +0000)]
* Removed unused ChangeLog2

pmo-trunk-r4512

15 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Fri, 9 May 2008 11:20:27 +0000 (11:20 +0000)]
* src/maemo/modest-msg-view-window.c:
        * Make sure now row references are not lost or overwritten wrongly,
          to avoid getting incorrect header/camel folder references. With
          this change and tinymail change to reason around the get_headers
          operation we fix bug NB#84005.

pmo-trunk-r4511

15 years ago * Fixes NB#85344, do not leave the active focus in the "new" button when adding...
Sergio Villar Senin [Fri, 9 May 2008 10:37:21 +0000 (10:37 +0000)]
* Fixes NB#85344, do not leave the active focus in the "new" button when adding accounts

pmo-trunk-r4509

15 years ago * Fixes NB#85343, close the accounts view window if there is no account left
Sergio Villar Senin [Fri, 9 May 2008 08:35:05 +0000 (08:35 +0000)]
* Fixes NB#85343, close the accounts view window if there is no account left

pmo-trunk-r4508

15 years agoUpdated for the public release.
Vivek Sekar [Wed, 7 May 2008 09:02:02 +0000 (09:02 +0000)]
Updated for the public release.

pmo-trunk-r4506

15 years ago Added bug fix 83343 for week 19
Vivek Sekar [Wed, 7 May 2008 08:41:33 +0000 (08:41 +0000)]
  Added bug fix 83343 for week 19

pmo-trunk-r4505

15 years agoreplaced bug number 84552 with 84551 - correction
Vivek Sekar [Tue, 6 May 2008 13:26:07 +0000 (13:26 +0000)]
replaced bug number 84552 with 84551 - correction

pmo-trunk-r4504

15 years ago * Fixes NB#81913, do not resize the new folder dialog entry when the text is too...
Sergio Villar Senin [Mon, 5 May 2008 11:56:00 +0000 (11:56 +0000)]
* Fixes NB#81913, do not resize the new folder dialog entry when the text is too large
* Fixes a modality issue of the former dialog

pmo-trunk-r4500

15 years ago removed bugs not part of the week 18 build, and added new bugfixes for week 19.
Vivek Sekar [Mon, 5 May 2008 11:32:34 +0000 (11:32 +0000)]
  removed bugs not part of the week 18 build, and added new bugfixes for week 19.

pmo-trunk-r4498

15 years ago * Removed some unused code
Sergio Villar Senin [Mon, 5 May 2008 09:03:31 +0000 (09:03 +0000)]
* Removed some unused code
* Fixes NB#85201, update the last updated string even though the Inbox refresh fails

pmo-trunk-r4497

15 years agoFixed two small leaks added in the previous commit
Sergio Villar Senin [Wed, 30 Apr 2008 17:31:16 +0000 (17:31 +0000)]
Fixed two small leaks added in the previous commit

pmo-trunk-r4496

15 years ago * Fixes NB#85131, show the proper account when opening draft messages
Sergio Villar Senin [Wed, 30 Apr 2008 17:24:40 +0000 (17:24 +0000)]
* Fixes NB#85131, show the proper account when opening draft messages

pmo-trunk-r4495

15 years ago* src/dbus_api/modest-dbus-callback.c:
Jose Dapena Paz [Wed, 30 Apr 2008 17:18:53 +0000 (17:18 +0000)]
* src/dbus_api/modest-dbus-callback.c:
        * Now the opening message information banner is scheduled after
          connection is obtained.

pmo-trunk-r4494

15 years ago * Removed an invalid g_source_remove
Sergio Villar Senin [Wed, 30 Apr 2008 16:13:47 +0000 (16:13 +0000)]
* Removed an invalid g_source_remove
* Fixed some calls to modest_platform_animation_banner that were not taking into account that it could return NULL

pmo-trunk-r4493

15 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 30 Apr 2008 15:47:22 +0000 (15:47 +0000)]
* src/modest-ui-actions.c:
        * Focus folder view on finishing rename operation (fixes NB#85034).
* src/widgets/modest-folder-view.c:
        * Fix focus issue on finishing move to operation with DnD.

pmo-trunk-r4492

15 years ago * Fixes NB#85108, wait until messages sent from external tools are added to the...
Sergio Villar Senin [Wed, 30 Apr 2008 11:29:23 +0000 (11:29 +0000)]
* Fixes NB#85108, wait until messages sent from external tools are added to the outbox

pmo-trunk-r4491

15 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 29 Apr 2008 14:39:02 +0000 (14:39 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Keep a reference on font dialog while it's running to close it
  in case we are destroying the message editor (fixes NB#85055).

pmo-trunk-r4490

15 years ago * Partially fixes NB#85031. At least it fixes comment #1
Sergio Villar Senin [Tue, 29 Apr 2008 11:07:33 +0000 (11:07 +0000)]
* Partially fixes NB#85031. At least it fixes comment #1

pmo-trunk-r4489

15 years agoWork to fix bug NB#84054.
Jose Dapena Paz [Mon, 28 Apr 2008 17:21:42 +0000 (17:21 +0000)]
Work to fix bug NB#84054.
* src/dbus_api/modest-dbus-callbacks.c:
        * Now fetching messages uses find_msg_async, and avoids locking
          UI while message is retrieved. It also returns dbus call
          immediately instead of waiting for the message to be opened.

pmo-trunk-r4488

15 years agoRemoved the 84823 bug, will be added later.
Vivek Sekar [Mon, 28 Apr 2008 11:30:33 +0000 (11:30 +0000)]
Removed the 84823 bug, will be added later.

pmo-trunk-r4487

15 years ago * Refactored the get_icon methods of folder view
Sergio Villar Senin [Mon, 28 Apr 2008 09:31:22 +0000 (09:31 +0000)]
* Refactored the get_icon methods of folder view

pmo-trunk-r4486

15 years ago* src/modest-mail-operation.[ch]:
Jose Dapena Paz [Mon, 28 Apr 2008 08:41:57 +0000 (08:41 +0000)]
* src/modest-mail-operation.[ch]:
        * Now modest_mail_operation_get_msg gets a boolean parameter to
          enable/disable progress bar status feedback.
* src/modest-ui-actions.c:
        * On opening a message for removing attachments, don't show
  progress bar (fixes NB#83892).
        * Adapt to modest_mail_operation_get_msg to new API.
* src/maemo/modest-msg-view-window.c:
        * Adapt to modest_mail_operation_get_msg to new API.

pmo-trunk-r4485

15 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Fri, 25 Apr 2008 18:03:52 +0000 (18:03 +0000)]
* src/modest-tny-msg.c:
* (add_attachments): preserve attachment filename on copying
  attachments (fixes NB#83920).

pmo-trunk-r4484

15 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Fri, 25 Apr 2008 15:33:32 +0000 (15:33 +0000)]
* src/maemo/modest-main-window.c:
        * Fix the cursor position on activating from header view, if
          the cursor was in a deleted row (fixes NB#81429).

pmo-trunk-r4483

15 years agoUpdate NEWS for W18
Dirk-Jan C. Binnema [Fri, 25 Apr 2008 13:15:54 +0000 (13:15 +0000)]
Update NEWS for W18

pmo-trunk-r4480

15 years ago added bug fixes for week 18.
Vivek Sekar [Fri, 25 Apr 2008 13:12:03 +0000 (13:12 +0000)]
 added bug fixes for week 18.

pmo-trunk-r4478

15 years ago* we force the loading of ke-recv at startup, so we have
Dirk-Jan C. Binnema [Fri, 25 Apr 2008 11:43:07 +0000 (11:43 +0000)]
* we force the loading of ke-recv at startup, so we have
cerm_device_memory_full
  already in memory, and we give a g_warning if this fails.

This (hopefully) fixes NB#84922

pmo-trunk-r4476

15 years ago* src/modest-tny-send-queue.c:
Jose Dapena Paz [Fri, 25 Apr 2008 10:47:09 +0000 (10:47 +0000)]
* src/modest-tny-send-queue.c:
* Make sentbox be synced after getting the msg sent flag and
  setting the message to be already seen (fixes partially
  NB#84832).

pmo-trunk-r4475

15 years agoDo not lose focus when rename fails (fixes NB#84791).
Jose Dapena Paz [Thu, 24 Apr 2008 18:20:29 +0000 (18:20 +0000)]
Do not lose focus when rename fails (fixes NB#84791).

pmo-trunk-r4474

15 years agoShow the "Discard changes" confirmation note whenever the user
Jose Dapena Paz [Thu, 24 Apr 2008 18:17:10 +0000 (18:17 +0000)]
Show the "Discard changes" confirmation note whenever the user
presses the cancel button after changing some configurations in that
dialog (fixes NB#84260).

pmo-trunk-r4473

15 years ago* src/dbus_api/modest-dbus-callbacks.c:
Jose Dapena Paz [Thu, 24 Apr 2008 18:13:57 +0000 (18:13 +0000)]
* src/dbus_api/modest-dbus-callbacks.c:
* Set properly as seen messages opened from search (fixes
  NB#83135).

pmo-trunk-r4472

15 years agoDisable drag&n&drop while a message is being sent (fixes NB#83128).
Jose Dapena Paz [Thu, 24 Apr 2008 17:59:25 +0000 (17:59 +0000)]
Disable drag&n&drop while a message is being sent (fixes NB#83128).

pmo-trunk-r4471

15 years agoFix for bug NB#79005. Improves duplicates detection for cases of saving
Jose Dapena Paz [Thu, 24 Apr 2008 17:56:04 +0000 (17:56 +0000)]
Fix for bug NB#79005. Improves duplicates detection for cases of saving
new versions of big files.

pmo-trunk-r4470

15 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Thu, 24 Apr 2008 17:40:32 +0000 (17:40 +0000)]
* src/modest-mail-operation.c:
* Keep messages on serving with DnD operations from pop accounts
  (fixes NB#84731).

pmo-trunk-r4469

15 years agoAvoid a blank message list pane when an account os defined/removed
Jose Dapena Paz [Thu, 24 Apr 2008 17:31:14 +0000 (17:31 +0000)]
Avoid a blank message list pane when an account os defined/removed
(fixes NB#84714).

pmo-trunk-r4468

15 years ago* src/dbus_api/modest-dbus-callbacks.c:
Jose Dapena Paz [Thu, 24 Apr 2008 16:18:36 +0000 (16:18 +0000)]
* src/dbus_api/modest-dbus-callbacks.c:
* (on_open_message_performer): if we're opening a draft, then we
  retrieve the account name from the from header, and take into
  accountif there's any account available, to show the account
  wizard (fixes NB#84808).

pmo-trunk-r4467

15 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Thu, 24 Apr 2008 16:16:13 +0000 (16:16 +0000)]
* src/maemo/modest-msg-view-window.c:
        * (modest_msg_view_window_find_toolbar_close): focus msg view when
          we close the find toolbar so that selection actions work
          (fixes NB#84757).

pmo-trunk-r4466

15 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Thu, 24 Apr 2008 16:13:46 +0000 (16:13 +0000)]
* src/modest-ui-dimming-rules.c:
* Dim move to in view if message is expunged (fixes NB#84538).

pmo-trunk-r4465

15 years ago* src/maemo/modest-address-book.c:
Jose Dapena Paz [Thu, 24 Apr 2008 16:11:25 +0000 (16:11 +0000)]
* src/maemo/modest-address-book.c:
* Now we show the checking names banner when we're really
  accessing the contacts database (Ffixes NB#84348).

pmo-trunk-r4464

15 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Thu, 24 Apr 2008 16:04:29 +0000 (16:04 +0000)]
* src/modest-mail-operation.c:
* Add progress bar reporting to update account operation, making
  therefresh async operation done on inbox include a status handler
  (fixes NB#81798).

pmo-trunk-r4463

15 years ago* src/modest-search.c:
Jose Dapena Paz [Thu, 24 Apr 2008 15:53:56 +0000 (15:53 +0000)]
* src/modest-search.c:
        * (search_mime_part_and_child_parts): fix this to filter only
  attachments and not nearly any body part (fixes NB#84821).

pmo-trunk-r4462

15 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Thu, 24 Apr 2008 15:49:46 +0000 (15:49 +0000)]
* src/modest-tny-msg.c:
* (modest_tny_msg_find_body_part_from_mime_part): if body is in
  the top mime part, lowcase before matching the content type so
  that content types like "TEXT/plain" match properly
  (fixes NB#84604).

pmo-trunk-r4461

15 years agoWork to fix NB#84828.
Jose Dapena Paz [Thu, 24 Apr 2008 15:47:03 +0000 (15:47 +0000)]
Work to fix NB#84828.
* src/modest-ui-actions.c:
        * Dim the username in get password dialog _always_. We don't want to
          allow to change the username from here, as we can cause hangs
          because tny_account_set_user here is inside a lock.
* src/modest-tny-account-store.c:
        * Remove the call to set user as we never change the password from the
          get_password dialog.
* src/maemo/modest-account-settings-dialog.c:
        * Allow to change the smtp username in account settings dialog.
* src/modest-window-mgr.c:
        * A minor issue with modality. If the window we're destroying is
          on top, we remove the current_top reference, to prevent one warning.

pmo-trunk-r4460

15 years agoRemoved a warningw
Sergio Villar Senin [Thu, 24 Apr 2008 14:14:08 +0000 (14:14 +0000)]
Removed a warningw

pmo-trunk-r4458

15 years ago* Several fixes for the GNOME version
Sergio Villar Senin [Thu, 24 Apr 2008 12:52:59 +0000 (12:52 +0000)]
* Several fixes for the GNOME version

pmo-trunk-r4457

15 years ago* trunk: together with the update modest-providers-data (r4454), fixes NB#84852
Dirk-Jan C. Binnema [Thu, 24 Apr 2008 12:16:19 +0000 (12:16 +0000)]
* trunk: together with the update modest-providers-data (r4454), fixes NB#84852

pmo-trunk-r4455

16 years ago * Fixes NB#84551, allow changes in the outbox server authentication methods while...
Sergio Villar Senin [Tue, 22 Apr 2008 11:33:33 +0000 (11:33 +0000)]
* Fixes NB#84551, allow changes in the outbox server authentication methods while modest is running

pmo-trunk-r4451

16 years agoAdded the week 17-2 bug fixes
Vivek Sekar [Tue, 22 Apr 2008 09:06:38 +0000 (09:06 +0000)]
Added the week 17-2 bug fixes

pmo-trunk-r4449

16 years ago * Use the get_folders_async to retrieve the per account outbox (dape's patch)
Sergio Villar Senin [Tue, 22 Apr 2008 09:02:10 +0000 (09:02 +0000)]
* Use the get_folders_async to retrieve the per account outbox (dape's patch)
* Added a slight modification to the original patch to properly notify the folder view about the new outboxes

pmo-trunk-r4448

16 years agoRemoved w17 tag, and commited new bug fixes for newer w17 release.
Vivek Sekar [Tue, 22 Apr 2008 08:07:38 +0000 (08:07 +0000)]
Removed w17 tag, and commited new bug fixes for newer w17 release.

pmo-trunk-r4446

16 years ago * Properly synchronizes the selected folder when closing the main window
Sergio Villar Senin [Tue, 22 Apr 2008 07:59:21 +0000 (07:59 +0000)]
* Properly synchronizes the selected folder when closing the main window

pmo-trunk-r4445

16 years ago* use the incoming server in the providers combo box; thus, users can see the differe...
Dirk-Jan C. Binnema [Mon, 21 Apr 2008 14:41:37 +0000 (14:41 +0000)]
* use the incoming server in the providers combo box; thus, users can see the difference between imap.gmail.com and pop.gmail.com; same thing for e.g saunalahti in Finland.

Fixes: a not yet filed bug.

pmo-trunk-r4443

16 years agoRemoved incorrect tag of week 17 release and commited new bug fix 84535
Vivek Sekar [Mon, 21 Apr 2008 12:07:49 +0000 (12:07 +0000)]
Removed incorrect tag of week 17 release and commited new bug fix 84535

pmo-trunk-r4441

16 years ago* updated NEWS for the W17 release
Dirk-Jan C. Binnema [Mon, 21 Apr 2008 12:01:51 +0000 (12:01 +0000)]
* updated NEWS for the W17 release

pmo-trunk-r4440

16 years ago * Fixes NB#84535, server errors are now shown over the contacts dialog
Sergio Villar Senin [Mon, 21 Apr 2008 11:56:39 +0000 (11:56 +0000)]
* Fixes NB#84535, server errors are now shown over the contacts dialog

pmo-trunk-r4439

16 years agoAdded the week 17 bug fixes.
Vivek Sekar [Mon, 21 Apr 2008 11:46:20 +0000 (11:46 +0000)]
Added the week 17 bug fixes.

pmo-trunk-r4436

16 years ago * Partially fixes NB#84505, do not call tny_folder_get_account over a merge folder
Sergio Villar Senin [Mon, 21 Apr 2008 10:16:47 +0000 (10:16 +0000)]
* Partially fixes NB#84505, do not call tny_folder_get_account over a merge folder

pmo-trunk-r4435

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 18 Apr 2008 16:49:59 +0000 (16:49 +0000)]
* src/modest-ui-actions.c:
* Disallow opening messages (with header activate) when they're
  being sent (fixes NB#83721).

pmo-trunk-r4434

16 years ago * Fixes NB#83303, show the default account's FROM address when opening a new editor
Sergio Villar Senin [Fri, 18 Apr 2008 16:48:55 +0000 (16:48 +0000)]
* Fixes NB#83303, show the default account's FROM address when opening a new editor

pmo-trunk-r4433

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Fri, 18 Apr 2008 15:53:35 +0000 (15:53 +0000)]
* src/modest-ui-actions.c:
* Now we don't allow in password requested dialog to press ok
  if password or username is empty (fixes NB#83944).

pmo-trunk-r4432

16 years ago * Fixes a crash when removing accounts. Added by a code I commited today
Sergio Villar Senin [Fri, 18 Apr 2008 12:23:57 +0000 (12:23 +0000)]
* Fixes a crash when removing accounts. Added by a code I commited today
* Adds a new parameter to get_send_queue that tells the runtime to create it or not if it does not exist

pmo-trunk-r4431

16 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Fri, 18 Apr 2008 11:17:45 +0000 (11:17 +0000)]
* src/widgets/modest-folder-view.c:
* Now we call to select first inbox on setting an account store
  to the folder view. This way we don't get blank startup header
  view in case there's no account available (or the case inbox
  is still not loaded (fixes NB#81375).

pmo-trunk-r4430

16 years ago * Fixes NB#84492, remove the messages in the outbox that belongs to a removed account
Sergio Villar Senin [Fri, 18 Apr 2008 10:09:38 +0000 (10:09 +0000)]
* Fixes NB#84492, remove the messages in the outbox that belongs to a removed account
* Added a new method to remove send_queues
* Fixed and invalid error report when a mail operation is never executed

pmo-trunk-r4429

16 years ago* src/widgets/modest-widget-memory.c:
Jose Dapena Paz [Thu, 17 Apr 2008 10:09:54 +0000 (10:09 +0000)]
* src/widgets/modest-widget-memory.c:
* Fix restore of main window paned position. Problem was that
  we didn't save the position of the paned when the widget was
  not visible (then we never saved the position on closing
  modest) (fixes NB#82173).

pmo-trunk-r4428

16 years ago * Reverted a very bad change
Sergio Villar Senin [Thu, 17 Apr 2008 09:41:51 +0000 (09:41 +0000)]
* Reverted a very bad change

pmo-trunk-r4427

16 years ago * Fixed two callbacks in the main window that were taking wrong arguments
Sergio Villar Senin [Thu, 17 Apr 2008 08:34:18 +0000 (08:34 +0000)]
* Fixed two callbacks in the main window that were taking wrong arguments
* Fixed a reference leak when unregistering windows
* Removed window handling code from modest-main
* Fixed a couple memory issues found by valgrind when unregistering windows

pmo-trunk-r4426

16 years ago* src/widgets/modest-attachments-view.c:
Jose Dapena Paz [Wed, 16 Apr 2008 19:43:57 +0000 (19:43 +0000)]
* src/widgets/modest-attachments-view.c:
        * Fixed some reference leaks (fixes NB#83929).

pmo-trunk-r4425

16 years agoWork to fix bug NB#80656.
Jose Dapena Paz [Wed, 16 Apr 2008 19:41:22 +0000 (19:41 +0000)]
Work to fix bug NB#80656.
* src/modest-tny-msg.[ch]:
        * Added support for fetching errors in tinymail when we add
  attachments. In particular, now we set an error in
  copy_mime_stream if it was not successful.
* src/modest-ui-actions.c:
        * If creating message has errors because of stream read failures
  (i.e. after removing a media or switching down a server in a vfs
  stream) we go on but avoid adding the message. We also show an
  information banner.
* src/modest-mail-operation.c:
        * Manage on message creation the case of an error reading
  attachments so that we don't stop processing and show proper
  error at the end.
* src/modest-error.h:
        * Added new error for file io (it'll happen when we fail to
  retrieve an attachment).

pmo-trunk-r4424

16 years ago * Removed the window management added to modest-main. Moved back to the window mgr
Sergio Villar Senin [Wed, 16 Apr 2008 19:12:54 +0000 (19:12 +0000)]
* Removed the window management added to modest-main. Moved back to the window mgr

pmo-trunk-r4423

16 years ago * Fixed a corner case when finalizing modest
Sergio Villar Senin [Wed, 16 Apr 2008 18:42:08 +0000 (18:42 +0000)]
* Fixed a corner case when finalizing modest

pmo-trunk-r4422

16 years ago * Fixes NB#84117, fixes "hangs" when reopening Modest while there are ongoing operations
Sergio Villar Senin [Wed, 16 Apr 2008 15:36:52 +0000 (15:36 +0000)]
* Fixes NB#84117, fixes "hangs" when reopening Modest while there are ongoing operations
* Close banners when the window is not visible

pmo-trunk-r4421

16 years ago * Fixes #84315, do not enable the user to change some parametters if there was a...
Sergio Villar Senin [Wed, 16 Apr 2008 10:45:35 +0000 (10:45 +0000)]
* Fixes #84315, do not enable the user to change some parametters if there was a successful connection before

pmo-trunk-r4420

16 years ago * Partially fixes NB#84315, clear the list of old headers when updating an account
Sergio Villar Senin [Wed, 16 Apr 2008 08:39:26 +0000 (08:39 +0000)]
* Partially fixes NB#84315, clear the list of old headers when updating an account
* Added a missing initialization
* Added an extra check

pmo-trunk-r4419

16 years ago* prevent some problems seen ; make sure we're having a valid account before feeding...
Dirk-Jan C. Binnema [Tue, 15 Apr 2008 13:52:28 +0000 (13:52 +0000)]
* prevent some problems seen ; make sure we're having a valid account before feeding it to tny_account_cancel

pmo-trunk-r4418

16 years ago* fix small leak
Dirk-Jan C. Binnema [Tue, 15 Apr 2008 11:01:01 +0000 (11:01 +0000)]
* fix small leak

pmo-trunk-r4417

16 years ago* add some debugging statements when unitializing the runtime
Dirk-Jan C. Binnema [Tue, 15 Apr 2008 09:51:43 +0000 (09:51 +0000)]
* add some debugging statements when unitializing the runtime

pmo-trunk-r4416

16 years ago* close some holes in our low-memory / big attachments handling; now we also check...
Dirk-Jan C. Binnema [Tue, 15 Apr 2008 09:38:21 +0000 (09:38 +0000)]
* close some holes in our low-memory / big attachments handling; now we also check when sending or saving to drafts (before, one could evade the checks by trying to forward a msg with big attachments)

pmo-trunk-r4415

16 years ago* unref various singletons in the exact reverse order of their initialization
Dirk-Jan C. Binnema [Tue, 15 Apr 2008 08:48:07 +0000 (08:48 +0000)]
* unref various singletons in the exact reverse order of their initialization

pmo-trunk-r4414

16 years ago * Replaced a useless == by a =
Sergio Villar Senin [Mon, 14 Apr 2008 17:21:09 +0000 (17:21 +0000)]
* Replaced a useless == by a =

pmo-trunk-r4413

16 years ago * Set the proper status of the mail operation
Sergio Villar Senin [Mon, 14 Apr 2008 17:16:39 +0000 (17:16 +0000)]
* Set the proper status of the mail operation

pmo-trunk-r4412

16 years ago * Fixes NB#83317, problems with specific folder searches
Sergio Villar Senin [Mon, 14 Apr 2008 16:10:03 +0000 (16:10 +0000)]
* Fixes NB#83317, problems with specific folder searches

pmo-trunk-r4411

16 years ago* allow the account parameter in modest_tny_account_store_alert to be NULL; some...
Dirk-Jan C. Binnema [Mon, 14 Apr 2008 14:35:29 +0000 (14:35 +0000)]
* allow the account parameter in modest_tny_account_store_alert to be NULL; some of the certificate alert come with a NULL account (that's a bug in Tinymail), and modest will otherwise show a note that 'message is not available'.

pmo-trunk-r4410

16 years ago* fix small copy-paste bug: forget the password for the transport account
Dirk-Jan C. Binnema [Mon, 14 Apr 2008 11:57:32 +0000 (11:57 +0000)]
* fix small copy-paste bug: forget the password for the transport account

pmo-trunk-r4409

16 years ago * Refactored the drag&drop message transfers, now it uses the same code as the ...
Sergio Villar Senin [Mon, 14 Apr 2008 10:02:00 +0000 (10:02 +0000)]
* Refactored the drag&drop message transfers, now it uses the same code as the "move to" dialog
* Fixed a hang when transferring messages in offline mode using drag&drop
* Cleaned drag and drop code, now it properly finish in some missing cases

pmo-trunk-r4408

16 years ago* added extra checking to on_account_inserted, on_account_changed.
Dirk-Jan C. Binnema [Mon, 14 Apr 2008 07:09:08 +0000 (07:09 +0000)]
* added extra checking to on_account_inserted, on_account_changed.
Fixes: NB#83555

pmo-trunk-r4407

16 years ago* set max attachment size to 15Mb, which should be Enough For Everyone (tm)
Dirk-Jan C. Binnema [Mon, 14 Apr 2008 06:59:41 +0000 (06:59 +0000)]
* set max attachment size to 15Mb, which should be Enough For Everyone (tm)

pmo-trunk-r4406

16 years ago* for NB#83601:
Dirk-Jan C. Binnema [Fri, 11 Apr 2008 16:51:42 +0000 (16:51 +0000)]
* for NB#83601:

with this patch, when we're in low-memory state, we disallow:
- addressbook
- attachments (attaching, opening, saving)
- searching (also over dbus ==> it returns an empty list in that case)
- viewing messages, replying/forwarding

we still do allow:
- composing messages (without attachments)
- saving to drafts (< 25Kb)
- sending (< 25Kb)

also, when sending attachements, make sure the sum of their sizes does
not exceed, if they do, raise an error.

#define MODEST_MAX_LOW_MEMORY_MESSAGE_SIZE (25*1024)
#define MODEST_MAX_ATTACHMENT_SIZE (12*1024*1024)

still TODO is to make sure that the attachment size limitation also applies to
weird filesystems, such as obex and upnp

pmo-trunk-r4405