Javier Fernandez Garcia-Boente [Wed, 16 May 2007 16:20:08 +0000 (16:20 +0000)]
* maemo/modest-main-window-ui.h
- add handler for move_to toolbar button
* maemo/modest-progress-bar-widget.c
- avoid to show done=1 and total=100 progress,
because these values are inital values for all
mail operations.
* modest-ui-actions.c
- show confirmation dialog on delete message events
from headers view
- Add a user_callback function to xfer_msgs method in order
to restore row_reference attribute on viewer window and
set current message to first message of recenlty update
treemodel.
* modest-folder-view.c
- fix bug about an incorrect unref over header object after
added it to a tiny list. this header object will be unreferenced
when tiny list was destroyed.
* modest-mail-operation.c
- call to recently created copy_folder_async tinymail operation.
- define an user_callback for message transfer operations
- fix bug on xfer_msgs operation, due an incorrect references management.
pmo-trunk-r1892
Sergio Villar Senin [Wed, 16 May 2007 14:34:31 +0000 (14:34 +0000)]
* Some fixes
pmo-trunk-r1891
Dirk-Jan C. Binnema [Wed, 16 May 2007 13:42:50 +0000 (13:42 +0000)]
* fix for compile breakage
pmo-trunk-r1890
Dirk-Jan C. Binnema [Wed, 16 May 2007 13:09:09 +0000 (13:09 +0000)]
* fix broken debian/changelog, as integration barfs on this
pmo-trunk-r1889
Sergio Villar Senin [Wed, 16 May 2007 12:58:58 +0000 (12:58 +0000)]
* Added support to send&receive async in that particular order
pmo-trunk-r1888
Murray Cumming [Wed, 16 May 2007 12:30:07 +0000 (12:30 +0000)]
2007-05-16 Murray Cumming <murrayc@murrayc.com>
* src/modest-pair.h: Improve the documentation for modest_combo_box_new()
to explain the memory management issue with the ID in the ModestPair.
* src/gnome/modest-account-assistant.c: (add_receiving_page),
(add_sending_page), (modest_account_assistant_finalize):
* src/gnome/modest-gnome-global-settings-dialog.c:
(create_updating_page), (create_composing_page):
* src/gnome/modest-msg-edit-window.c: (get_transports),
(init_window), (modest_msg_edit_window_finalize),
(modest_msg_edit_window_get_msg_data):
* src/gnome/modest-store-widget.c: (imap_pop_configuration):
* src/gnome/modest-transport-widget.c:
(modest_transport_widget_finalize), (smtp_configuration):
* src/maemo/modest-maemo-global-settings-dialog.c:
(create_updating_page), (create_composing_page):
* src/maemo/modest-msg-edit-window.c: (get_transports),
(init_window), (modest_msg_edit_window_finalize),
(modest_msg_edit_window_get_msg_data),
(modest_msg_edit_window_free_msg_data):
* src/maemo/modest-store-widget.c: (imap_pop_configuration),
(modest_store_widget_finalize):
* src/maemo/modest-transport-widget.c:
(modest_transport_widget_finalize), (smtp_configuration):
* src/modest-main.c: (send_mail):
* src/widgets/modest-combo-box.h:
* src/widgets/modest-global-settings-dialog-priv.h:
* src/widgets/modest-global-settings-dialog.c:
(modest_global_settings_dialog_finalize):
* src/widgets/modest-msg-edit-window.h:
Whenever using modest_combo_box_new(), keep the ModestPairList alive
as long as the combo box, to prevent use of freed memory for the ID.
pmo-trunk-r1887
Sergio Villar Senin [Wed, 16 May 2007 10:38:31 +0000 (10:38 +0000)]
* Better status information notification for account updates
pmo-trunk-r1886
Dirk-Jan C. Binnema [Wed, 16 May 2007 09:02:27 +0000 (09:02 +0000)]
* added the prepare-integration script, which does the building work for integrating packages; only useful for pre-integrators
pmo-trunk-r1885
Dirk-Jan C. Binnema [Wed, 16 May 2007 08:58:47 +0000 (08:58 +0000)]
* fix the changelog syntax
pmo-trunk-r1884
Sergio Villar Senin [Wed, 16 May 2007 07:38:54 +0000 (07:38 +0000)]
* Fixed a build error
pmo-trunk-r1883
Murray Cumming [Tue, 15 May 2007 18:06:30 +0000 (18:06 +0000)]
Pedantic grammar stuff in a comment.
pmo-trunk-r1882
Dirk-Jan C. Binnema [Tue, 15 May 2007 17:57:48 +0000 (17:57 +0000)]
* prepare for new prerelease
pmo-trunk-r1881
Murray Cumming [Tue, 15 May 2007 15:36:57 +0000 (15:36 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_server_accounts): Renamed from
get_accounts(), to make this clearer. Do not check for the enabled gconf
key, because we do not use this for server accounts (at least, not yet).
This allows us to send email again.
pmo-trunk-r1880
Dirk-Jan C. Binnema [Tue, 15 May 2007 15:04:28 +0000 (15:04 +0000)]
* number the columns (MODEST_HEADER_VIEW_COLUMN_*) explicitely, to make changes that screw up our config settings less likely
pmo-trunk-r1879
Dirk-Jan C. Binnema [Tue, 15 May 2007 14:54:25 +0000 (14:54 +0000)]
* added missing backup settings file
pmo-trunk-r1878
Murray Cumming [Tue, 15 May 2007 14:39:42 +0000 (14:39 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c:
(on_modest_conf_update_interval_changed), (modest_platform_init):
Only respond to this particular key change. All these strcmp()s cannot be
efficient.
pmo-trunk-r1877
Murray Cumming [Tue, 15 May 2007 14:28:00 +0000 (14:28 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-global-settings-dialog.c:
(current_connection): Prevent a crash in scratchbox when
ny_maemo_conic_device_get_current_iap_id() returns NULL.
* src/maemo/modest-platform.c:
(on_modest_conf_update_interval_changed), (modest_platform_init):
Get the update interval from gconf and reset it when the gconf key changes.
pmo-trunk-r1876
Dirk-Jan C. Binnema [Tue, 15 May 2007 14:08:16 +0000 (14:08 +0000)]
* add the rather trivial backup support; this implements the "Backup" workitem.
* needs testing though, and possibly a conversion script for pre-modest email import
pmo-trunk-r1875
Murray Cumming [Tue, 15 May 2007 13:55:43 +0000 (13:55 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/modest-protocol-info.c:
* src/modest-protocol-info.h: Adde enum-specific get functions,
instead of using a ModestProtocolType enum parameter.
* src/gnome/modest-account-assistant.c:
* src/gnome/modest-store-widget.c:
* src/gnome/modest-store-widget.h:
* src/gnome/modest-transport-widget.c:
* src/gnome/modest-transport-widget.h:
* src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
* src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c:
* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-store-widget.c:
* src/maemo/modest-store-widget.h:
* src/maemo/modest-transport-widget.c:
* src/maemo/modest-transport-widget.h:
* src/modest-account-mgr-helpers.c:
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr.c:
* src/modest-account-mgr.h:
* src/modest-tny-account.c:
* src/modest-tny-folder.c:
* src/widgets/modest-account-view.c:
* src/widgets/modest-retrieve-combo-box.c:
* src/widgets/modest-retrieve-combo-box.h:
* src/widgets/modest-secureauth-combo-box.c:
* src/widgets/modest-serversecurity-combo-box.c:
* src/widgets/modest-serversecurity-combo-box.h:
* tests/check_account-mgr.c:
Use the specific functions, and use the re-renamed enum values for GNOME too.
pmo-trunk-r1874
Sergio Villar Senin [Tue, 15 May 2007 12:28:19 +0000 (12:28 +0000)]
* Modified the update_account signature to ensure that the account is a ModestTnyAccount
* Added last_update feature
pmo-trunk-r1873
Murray Cumming [Tue, 15 May 2007 11:53:41 +0000 (11:53 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/modest-pair.h:
* src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
so we can get the second based on the first.
* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-account-settings-dialog.c:
Added get_supported_secure_authentication_methods(), though it is mostly
commented-out for now until the necessary API is committed to tinymail.
(modest_account_settings_dialog_set_account_name),
(save_configuration): Request the supported authentication methods from the
server, so we can choose a working method.
* src/modest-tny-account-store.h:
* src/modest-tny-account-store.c:
(modest_tny_account_store_get_session): Rename from
tny_account_store_get_session().
pmo-trunk-r1872
Javier Fernandez Garcia-Boente [Tue, 15 May 2007 11:22:24 +0000 (11:22 +0000)]
* Dont use timeouts to change toolbar operation
mode.
pmo-trunk-r1871
Dirk-Jan C. Binnema [Tue, 15 May 2007 11:22:08 +0000 (11:22 +0000)]
* update for the modest-protocol-info changes
pmo-trunk-r1870
Dirk-Jan C. Binnema [Tue, 15 May 2007 11:21:35 +0000 (11:21 +0000)]
* update for the modest-protocol-info changes
pmo-trunk-r1869
Dirk-Jan C. Binnema [Tue, 15 May 2007 11:20:51 +0000 (11:20 +0000)]
* update for the modest-protocol-info changes
pmo-trunk-r1868
Dirk-Jan C. Binnema [Tue, 15 May 2007 11:20:18 +0000 (11:20 +0000)]
* fix the modest-protocol-info for the split enums; note: a couple more commits will follow
pmo-trunk-r1867
Dirk-Jan C. Binnema [Tue, 15 May 2007 09:14:25 +0000 (09:14 +0000)]
* at least on bora, gconf crashes if you try to set a NULL string,
the NULL is a symptom of another bug (it causes the crash in bug
#57045), but at least we should be safe against NULLs.
pmo-trunk-r1866
Sergio Villar Senin [Tue, 15 May 2007 08:22:11 +0000 (08:22 +0000)]
* Added new msg received notification support
* Fixed some translations
pmo-trunk-r1865
Dirk-Jan C. Binnema [Tue, 15 May 2007 08:13:27 +0000 (08:13 +0000)]
* use guint for done/total
* add parameter checks
pmo-trunk-r1864
Javier Fernandez Garcia-Boente [Tue, 15 May 2007 08:02:50 +0000 (08:02 +0000)]
* Move mark_as_read call from on_header_activated
function to open_msg_cb callback method, in order
to manange headers only after message have been
downloaded.
pmo-trunk-r1863
Dirk-Jan C. Binnema [Tue, 15 May 2007 07:27:07 +0000 (07:27 +0000)]
* small cosmetic cleanup of modest-conf.c
pmo-trunk-r1862
Dirk-Jan C. Binnema [Tue, 15 May 2007 07:23:02 +0000 (07:23 +0000)]
* implement the "maemo-laucher" feature, which makes modest startup faster.
this completes workitem "Launcher"
for more information:
https://stage.maemo.org/svn/maemo/projects/haf/trunk/maemo-launcher/README
pmo-trunk-r1861
Dirk-Jan C. Binnema [Mon, 14 May 2007 17:30:46 +0000 (17:30 +0000)]
* turn off launcher stuff for now
pmo-trunk-r1860
Sergio Villar Senin [Mon, 14 May 2007 16:47:41 +0000 (16:47 +0000)]
* Added asynchronous account update
* Replaced GtkTreeIter's by row references when the header is activated
pmo-trunk-r1859
Dirk-Jan C. Binnema [Mon, 14 May 2007 16:37:30 +0000 (16:37 +0000)]
* fix debian/rules (launcher stuff)
* add libtinymail-gnomevfs build dep to control-maemo(0|1)
pmo-trunk-r1858
Murray Cumming [Mon, 14 May 2007 15:03:42 +0000 (15:03 +0000)]
2007-05-14 Murray Cumming <murrayc@murrayc.com>
* src/modest-protocol-info.h: Split the ModestProtocol enum
into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
There was no need to have these unrelated values in one enum.
* src/: many files: Adapted to changed enum. This makes the code a bit
clearer, and the compiler could catch some errors.
pmo-trunk-r1857
Javier Fernandez Garcia-Boente [Mon, 14 May 2007 15:00:57 +0000 (15:00 +0000)]
* Fix bug on progressbar timeout management.
I added 2 seconds of interval to show transfer_mode
toolbar. After interval, remove source and sets
timeout to 0, in order to enable normal mode again.
pmo-trunk-r1856
Dirk-Jan C. Binnema [Mon, 14 May 2007 14:28:05 +0000 (14:28 +0000)]
* fix build bug due to faulty Makefile.am CFLAGS/LDFLAGS
pmo-trunk-r1855
Dirk-Jan C. Binnema [Mon, 14 May 2007 14:26:21 +0000 (14:26 +0000)]
* fix build bug due to faulty Makefile.am CFLAGS/LDFLAGSwq setting
pmo-trunk-r1854
Javier Fernandez Garcia-Boente [Mon, 14 May 2007 13:40:59 +0000 (13:40 +0000)]
* Add new reference on dest_folder and header_list
objects passed to asyn callback function.
pmo-trunk-r1853
Dirk-Jan C. Binnema [Mon, 14 May 2007 12:55:06 +0000 (12:55 +0000)]
* debian/changelog update for packaging
* support for the maemo-launcher (turned-off for now)
pmo-trunk-r1852
Murray Cumming [Mon, 14 May 2007 12:35:29 +0000 (12:35 +0000)]
2007-05-14 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Show the detailed internal camel error message when an error happens
during the configuration, so that our testers can give us more clues.
For instance, in projects.maemo.org bug NB#56910 .
pmo-trunk-r1851
Murray Cumming [Mon, 14 May 2007 12:13:40 +0000 (12:13 +0000)]
2007-05-14 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
change tny_account_set_mech() to tny_account_set_secure_auth_mech().
pmo-trunk-r1850
Dirk-Jan C. Binnema [Mon, 14 May 2007 11:48:56 +0000 (11:48 +0000)]
* updated changelog
pmo-trunk-r1848
Dirk-Jan C. Binnema [Mon, 14 May 2007 09:49:33 +0000 (09:49 +0000)]
* updated debian/changelog
pmo-trunk-r1846
Dirk-Jan C. Binnema [Mon, 14 May 2007 09:32:24 +0000 (09:32 +0000)]
* updated
pmo-trunk-r1845
Murray Cumming [Mon, 14 May 2007 09:01:31 +0000 (09:01 +0000)]
2007-05-14 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name),
(save_configuration): For the incoming secure authentication checkbox,
use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
the UI specification. PLAIN does not seem to be supported for most IMAP
servers anyway, and I am not sure what it would mean.
However, we probably need to discover which of the secure-authentication
mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_get_server_account_data):
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
Use tny_account_set_mech() to set secure-authentication methods,
with some special-casing for IMAP, based on my observations of how
evolution behaves.
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr.c:
* src/modest-defs.h: Comment that the URI is only used for local folders.
pmo-trunk-r1844
Javier Fernandez Garcia-Boente [Mon, 14 May 2007 08:55:14 +0000 (08:55 +0000)]
* Fixed bug in xfer_msgs mail operation, due to an incorrect
unref over a header object.
pmo-trunk-r1843
Sergio Villar Senin [Mon, 14 May 2007 07:59:56 +0000 (07:59 +0000)]
* Some DnD fixes, msg xfer still crashes due to a tinymail error in xfer async
pmo-trunk-r1842
Sergio Villar Senin [Fri, 11 May 2007 17:39:58 +0000 (17:39 +0000)]
* Fixed two GNOME compilation errors
pmo-trunk-r1841
Murray Cumming [Fri, 11 May 2007 17:29:00 +0000 (17:29 +0000)]
2007-05-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
parameter const, just to be neat.
* src/modest-text-utils.c: (modest_text_utils_inline):
End g_strconcat() with NULL, as its documentation says. This is almost
certainly the cause of my crash at startup on the device. Interestingly,
valgrind doesn't tell us about these errors.
pmo-trunk-r1840
Sergio Villar Senin [Fri, 11 May 2007 16:35:06 +0000 (16:35 +0000)]
* Added preferred edit format global setting
* Added include in reply global setting
* Fixes: NB#56713
pmo-trunk-r1839
Sergio Villar Senin [Fri, 11 May 2007 13:32:25 +0000 (13:32 +0000)]
* Implemented Autoupdate Global setting
* Fixed a compilation error in OSSO1.1 due to a change in an enum value since Bora
pmo-trunk-r1838
Sergio Villar Senin [Fri, 11 May 2007 10:25:36 +0000 (10:25 +0000)]
* Full implementation of the Global settings dialogs UI with all the notifications and error cases
pmo-trunk-r1837
Murray Cumming [Fri, 11 May 2007 10:25:37 +0000 (10:25 +0000)]
2007-05-11 Murray Cumming <murrayc@murrayc.com>
* scripts/build-packages: Added more precise comments about how to use
this script, though I still get this error:
dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
error building tinymail
pmo-trunk-r1836
Murray Cumming [Fri, 11 May 2007 09:07:17 +0000 (09:07 +0000)]
2007-05-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c: (on_account_update):
Very slight cleanup, hoping to make it simpler to discover what causes
a crash here sometimes.
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account): Set the port. Added
comments about the options and a TODO comment because I need to find out
how to specify the secure authentication method.
pmo-trunk-r1834
Sergio Villar Senin [Fri, 11 May 2007 08:27:43 +0000 (08:27 +0000)]
* Added global settings persistence
* Added some UI notifications when errors
* Fixed a bug in the Modest Combo box
pmo-trunk-r1833
Marcus Bauer [Fri, 11 May 2007 06:27:07 +0000 (06:27 +0000)]
2007-05-11 Marcus Bauer <marcusb@openismus.com>
* libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
changed CFlags paths form modest to libmodest
pmo-trunk-r1830
Javier Fernandez Garcia-Boente [Thu, 10 May 2007 16:32:52 +0000 (16:32 +0000)]
* Add a timeout to show progress bar only
with operations more than 2 second long.
pmo-trunk-r1829
Murray Cumming [Thu, 10 May 2007 16:08:53 +0000 (16:08 +0000)]
2007-05-10 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_get_server_account_data),
(modest_account_mgr_free_server_account_data):
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr.c:
(modest_account_mgr_add_server_account):
* src/modest-defs.h:
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
Determine the options for tny_camel_account_add_option() here,
based on the settings, rather than storing them directly in gconf.
pmo-trunk-r1828
Jose Dapena Paz [Thu, 10 May 2007 15:44:45 +0000 (15:44 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Added dimming of cut and paste at widget initialisation.
* src/maemo/modest-msg-view-window.c:
* Added dimming of cut and paste at widget initalisation.
* Free selection after using it, not before.
pmo-trunk-r1827
Javier Fernandez Garcia-Boente [Thu, 10 May 2007 15:30:01 +0000 (15:30 +0000)]
* modest-mail-operation.c:
- Aded new operation folder_copy_async and their callbacks
- Fix bug on get_msg_status_cb function (Fixes: NB#56182)
- Messages transfer use now async operations.
* maemo/modest-main-window.c:
- Fix bug on Edit menu, options mark as read/unred work now.
- Headers will be marked as seen when a they are opened.
* modest-ui-actions.c:
- Review action handlers of mark as read/unread menu options.
* maemo/modest-msg-view-window.c:
- Messages will marked as seen when next/prev buttons are clicked.
pmo-trunk-r1826
Murray Cumming [Thu, 10 May 2007 15:21:47 +0000 (15:21 +0000)]
2007-05-10 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Show a more friendly error dialog now that we expect (from the tinymail
documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
pmo-trunk-r1825
Murray Cumming [Thu, 10 May 2007 15:08:38 +0000 (15:08 +0000)]
2007-05-10 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c: (on_account_update): Check that
account_name is not NULL, to prevent a crash at startup that I am
seeing on the N800. I do wonder why it is NULL.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_user_details):
* src/maemo/modest-account-settings-dialog.c:
(create_page_user_details), (create_page_outgoing):
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested):
Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
might do something useful with the on-screen keyboard.
pmo-trunk-r1824
Murray Cumming [Thu, 10 May 2007 12:45:35 +0000 (12:45 +0000)]
2007-05-10 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c: (on_account_update):
Avoid adding a menu item to priv->accounts_popup if accounts_popup is
NULL, to avoid lots of warnings. However, it probably should not be NULL.
pmo-trunk-r1823
Sergio Villar Senin [Thu, 10 May 2007 12:33:50 +0000 (12:33 +0000)]
* Added global settings keys
pmo-trunk-r1822
Sergio Villar Senin [Thu, 10 May 2007 12:03:06 +0000 (12:03 +0000)]
* Fixed build error in the GNOME UI
pmo-trunk-r1821
Sergio Villar Senin [Thu, 10 May 2007 11:54:50 +0000 (11:54 +0000)]
* Added global settings dialog specific implementations
* Added the get_global_settings method to ModestPlatform
pmo-trunk-r1820
Jose Dapena Paz [Thu, 10 May 2007 08:26:18 +0000 (08:26 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Implemented cut/copy dimming in message editor (not working completely yet
as it needs to update the status at startup).
* src/widgets/modest-attachment-view.[ch]:
* Removed commented code and any other reminiscence of activate signal
in attachment view (now it's implemented in ModestAttachmentsView).
* src/widgets/modest-attachments-view.c:
* Removed "activate" signal assignment to ModestAttachmentView as it's
not used now.
pmo-trunk-r1819
Jose Dapena Paz [Thu, 10 May 2007 07:29:12 +0000 (07:29 +0000)]
* src/modest-ui-actions.c:
* Fixed minor memory leak in password dialog sizegroup.
* src/maemo/modest-msg-edit-window.c:
* Now font selection dialog has parent window set to the
editor window.
* I was doing gdk_color_free of a color that's internally
referenced by the font selection dialog. This caused a
double free that lead to a crash on finishing the font
selection dialog. I removed it (fixes NB#56477).
* src/widgets/modest-folder-view.c:
* Now the cell_data_func unreferences the pixbuf after
adding it to the cell renderer, as it's getting its own
reference. This removes a leak of all the pixbufs in
the folder view.
pmo-trunk-r1817
Dirk-Jan C. Binnema [Thu, 10 May 2007 06:08:40 +0000 (06:08 +0000)]
* make our hacked icons the right size, and less blurry
pmo-trunk-r1816
Jose Dapena Paz [Wed, 9 May 2007 23:18:03 +0000 (23:18 +0000)]
* src/maemo/modest-msg-edit-window.c:
* The color toolbar item is not focusable
* src/maemo/modest-msg-view-window.c:
* Fixed an issue with clipboard management that prevented asynchronous
message retrieving from working.
* If we select an attachment with nested attahcments, it cannot be saved.
* Dim delete and move to... actions if the message we're viewing is
attached to a mail.
* Dim copy and cut when there's no selection, or when focus is in attachments
view.
* src/widgets/modest-attachment-view.c:
* Fixed a warning, as we were passing homogeneous and spacing to the constructor
and it's not a box now.
pmo-trunk-r1815
Dirk-Jan C. Binnema [Wed, 9 May 2007 22:23:48 +0000 (22:23 +0000)]
* show "no subject" also if the subject is not NULL, but just ""
pmo-trunk-r1814
Dirk-Jan C. Binnema [Wed, 9 May 2007 22:22:35 +0000 (22:22 +0000)]
* re-enable the dummy icons we use in the header view until
the custom cell renderer is in.
pmo-trunk-r1813
Dirk-Jan C. Binnema [Wed, 9 May 2007 21:58:49 +0000 (21:58 +0000)]
* use the 'display address' in the header view, ie., for
"Donald Duck <donald@duck.org>" just display
"Donald Duck"
pmo-trunk-r1812
Dirk-Jan C. Binnema [Wed, 9 May 2007 20:08:33 +0000 (20:08 +0000)]
* package the english .mo file so the bora version is somewhat translated again
pmo-trunk-r1811
Murray Cumming [Wed, 9 May 2007 17:34:15 +0000 (17:34 +0000)]
2007-05-09 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (on_account_changed):
Correct the signature of this signal handler.
pmo-trunk-r1810
Sergio Villar Senin [Wed, 9 May 2007 17:33:18 +0000 (17:33 +0000)]
* Fixed a compilation warning in Maemo
* Added global settings pending UI
pmo-trunk-r1809
Murray Cumming [Wed, 9 May 2007 16:28:18 +0000 (16:28 +0000)]
2007-05-09 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Show a HildonNote instead of a GtkDialog for Maemo.
pmo-trunk-r1808
Dirk-Jan C. Binnema [Wed, 9 May 2007 16:27:45 +0000 (16:27 +0000)]
* make the startup banner / dbus invocation work. this fixes NB#55355
pmo-trunk-r1807
Murray Cumming [Wed, 9 May 2007 15:59:30 +0000 (15:59 +0000)]
2007-05-09 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-account-view.h:
* src/widgets/modest-account-view.c: (on_account_changed),
(on_account_removed). Added a boolean flag, set/unset by
modest_account_view_block_conf_updates(),
modest_account_view_unblock_conf_updates() to prevent unnecessary
updates, but this is not very useful because the gconf notifications are
so delays (maybe only on Maemo Bora).
So auto-updating is turned off, and these functions do an explicit
update when necessary.
However, something else is still doing too much work when adding/removing
accounts, probably in another part of the application.
* src/maemo/modest-account-view-window.c:
(on_delete_button_clicked), (on_edit_button_clicked),
(on_new_button_clicked): Use the new functions.
pmo-trunk-r1806
Dirk-Jan C. Binnema [Wed, 9 May 2007 14:31:07 +0000 (14:31 +0000)]
* remove checkbox-related properties for 1.1, as they are no longer available/needed.
this gets rid of 2 runtime warnings
pmo-trunk-r1805
Dirk-Jan C. Binnema [Wed, 9 May 2007 14:00:39 +0000 (14:00 +0000)]
* updates for osso 1.1:
- use mcc_mapping from the operator-wizard-settings package
- use the countryname translations from the osso-countries translation domain
(the osso-countries-l10n-mr0 package)
pmo-trunk-r1804
Sergio Villar Senin [Wed, 9 May 2007 13:30:10 +0000 (13:30 +0000)]
* Removed invalid const
* Added some more ui code to the settings dialog
pmo-trunk-r1803
Murray Cumming [Wed, 9 May 2007 13:26:48 +0000 (13:26 +0000)]
2007-05-09 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_set_first_account_as_default):
Sort the list of names alphabetically-by-title, so we choose the first one
based on that.
* src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
alphabetically by the title.
This fixes projects.maemo.org bug NB#56418 .
* src/modest-account-mgr-priv.c:
(_modest_account_mgr_account_from_key):
* src/modest-account-mgr.c: (on_key_change): Initialize variables to
avoid a valgrind error, and possible random behaviour.
pmo-trunk-r1802
Murray Cumming [Wed, 9 May 2007 12:18:51 +0000 (12:18 +0000)]
Show a useful g_warning
pmo-trunk-r1801
Murray Cumming [Wed, 9 May 2007 12:04:09 +0000 (12:04 +0000)]
2007-05-09 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
tinymail documentation to say that this can be expected.
Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
pretty, and should not happen, but I would prefer to know when it does.
pmo-trunk-r1800
Sergio Villar Senin [Wed, 9 May 2007 10:53:08 +0000 (10:53 +0000)]
* Removed maemo ui constants
* Added modest ui constants
* Added Tools->Settings handler
* Added very first implementation of global settings dialog
* Fixed a compilation error in Sardine. Added -DMAEMO_CHANGES
pmo-trunk-r1799
Murray Cumming [Wed, 9 May 2007 10:02:16 +0000 (10:02 +0000)]
2007-05-09 Murray Cumming <murrayc@murrayc.com>
* configure.ac: When using the older hildon version, probably on Bora,
require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
to fix the build.
* src/widgets/modest-attachment-view.c:
(modest_attachment_view_set_part_default): Initialize variables, to fix the
build.
pmo-trunk-r1798
Jose Dapena Paz [Wed, 9 May 2007 10:01:02 +0000 (10:01 +0000)]
* src/modest-init.c:
* Default value for "prefer formatted text" conf property is
TRUE (fixes NB#56183).
pmo-trunk-r1797
Jose Dapena Paz [Wed, 9 May 2007 09:30:06 +0000 (09:30 +0000)]
* src/maemo/modest-address-book.c:
* Removed debug messages.
* Removed a wrong g_object_unref, which was leading to a crash of
the addressbook button in recipient editor when we opened the
dialog several times (fixes NB#56212).
* src/maemo/modest-msg-edit-window.c:
* Attach signal handlers for size change and font change after
creating all the menu items. Removes some warnings in valgrind.
* Now we get the offset correctly in the code to remove images in
body.
* src/widgets/modest-recpt-editor.c:
* Removed debug messages.
pmo-trunk-r1796
Jose Dapena Paz [Wed, 9 May 2007 08:13:23 +0000 (08:13 +0000)]
* src/modest-ui-actions.[ch]:
* Implemented ..._on_attachment_clicked, calling view attachment in view.
* Added actions ..._on_attach_file, ..._on_remove_attachments.
* Added support for "select all" action when attachment is focused.
* Added actions ..._view_attachment, ..._save_attachments,
..._remove_attachments.
* src/modest-text-utils.c:
* Now the ..._get_display_size should show correctly a 0 bytes size.
* src/maemo/modest-main-window-ui.h:
* Added view, save and remove attachment actions.
* src/maemo/modest-msg-edit-window.c:
* Added text_buffer_delete_range handler, to remove image attachments when
they're removed in the body editor.
* ..._add_attachment_clicked handler, to show the add attachment dialog
when user clicks the attachment button. (fixes NB#56314).
* Added ..._attach_file method, to show the dialog to attach one or more
files, and attach them to the message.
* Added ..._remove_attachments method, to remove the selected attachments.
* src/maemo/modest-platform.c:
* Now osso_context is a module static pointer, to let platform function use
this.
* Added implementation of modest_platform_activate_file using hildon/osso
mime libraries.
* src/maemo/modest-msg-view-window.c:
* ..._update_dimmed now also updates the attachment actions depending on the
current selection.
* Removed some debugging messages.
* Added ..._view_attachment method, to view the currently selected attachment.
If it's a message, it opens a new message view. If it's an attachment, it
calls the default handler.
* Added ..._save_attachments method. This method shows a dialog to select
the folder location to save (or the full path if only one attachment will be
saved).
* Added ..._remove_attachments method (with no implementation currently).
* src/maemo/modest-maemo-utils.[ch]:
* Added ..._folder_writable method, that checks if a folder is writable.
* Added ..._file_exists, that checks if a file path corresponds to an existing
file.
* Added ..._create_temp_stream, that creates a temporary file and a corresponding
TnyFsStream.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added attach file and remove attachment menu actions.
* src/maemo/ui/modest-msg-view-window-ui.xml:
* Added attach file, save attachments and remove attachments menu actions.
* src/modest-platform.h:
* New activate file method.
* src/gnome/modest-msg-edit-window.c:
* Added new stub functions.
* src/gnome/modest-platform.c:
* Added new stub functions.
* src/gnome/modest-msg-view-window.c:
* Added new stub functions.
* src/widgets/modest-msg-edit-window.h:
* Added methods to attach file and remove attachments.
* src/widgets/modest-msg-view.[ch]:
* Remove debugging messages.
* New ..._get_selected_attachments method, that obtains the TnyMimePart's of
current selection in attachments view.
* src/widgets/modest-attachment-view.[ch]:
* Removed activated signal. Now activation is completely managed in
ModestAttachmentsView.
* Added support for showing attached messages.
* Removed the button press and button release
* Now labels are not selectable (selection is managed in ModestAttachmentsView).
* Now it inherits from GtkEventBox.
* src/widgets/modest-msg-view-window.h:
* Added attachment methods.
* src/widgets/modest-attachments-view.[ch]:
* Now it inherits from an event box.
* Minor style fixes.
* Added support for attaching messages.
* New ..._remove_attachment method, to remove attachments corresponding to a
specific TnyMimePart.
* New ..._remove_attachment_by_id, to remove attachments corresponding to a
specific content id.
* Button events handling for rubber banding, selection, and activation.
* Keyboard events handling for selection and activation.
* Internal methods to handle selections: unselect_all, get_att_view_att_coords,
set_selected, select_range.
* Internal methods to handle clipboard selection.
* New ..._get_selection method, that obtains the mime parts of the selected
items.
* New ..._select_all method, that selects all the attachments.
* src/widgets/modest-msg-edit-window-ui.h:
* Added actions for attachments.
* configure.ac:
* Now maemo target depends on libtinymail-gnomevfs.
pmo-trunk-r1795
Marcus Bauer [Wed, 9 May 2007 06:41:59 +0000 (06:41 +0000)]
ChangeLog2 for r1793 - forgot to commit
pmo-trunk-r1794
Marcus Bauer [Wed, 9 May 2007 06:38:04 +0000 (06:38 +0000)]
Implemented the prototype on_idle_open_message()
pmo-trunk-r1793
Javier Fernandez Garcia-Boente [Tue, 8 May 2007 19:31:27 +0000 (19:31 +0000)]
* modest-mail-operation.c:
Implementation of update_progress callback for
transfer_msgs_async function.
* modest-ui-actions.c:
Delete some commented and unused code.
pmo-trunk-r1792
Sergio Villar Senin [Tue, 8 May 2007 17:06:47 +0000 (17:06 +0000)]
* Refactored s&r actions
* Added some documentation
* Added s&r CSM handlers
pmo-trunk-r1791
Murray Cumming [Tue, 8 May 2007 15:26:35 +0000 (15:26 +0000)]
2007-05-08 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c:
(modest_tny_account_store_instance_init), (get_password):
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested):
Do not store the password in gconf, because this function is called
for non-remembered passwords. Actually use the cached (in the hash map)
password instead of releasing it.
The password will now not be remembered if it is asked via the protected
password dialog, as per the UI spec.
pmo-trunk-r1789
Murray Cumming [Tue, 8 May 2007 15:13:17 +0000 (15:13 +0000)]
2007-05-08 Murray Cumming <murrayc@murrayc.com>
* src/modest-defs.h:
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_server_account_get_username_has_succeeded(),
modest_server_account_set_username_has_succeeded().
(modest_server_account_set_username),
Reset the has-succeeded flag if the username changes.
* src/maemo/modest-account-settings-dialog.c: (save_configuration):
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_save_server_accounts):
Use modest_server_account_set_username() instead of using
modest_conf_set_string() directly, so that the has-succeeded flag is always
reset.
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested): Dim the username entry if
the username has ever worked, as per the UI spec.
pmo-trunk-r1788
Murray Cumming [Tue, 8 May 2007 14:21:32 +0000 (14:21 +0000)]
2007-05-08 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_password):
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested):
Allow the username to be changed too, though there is more work to
be done on exactly how this behaves.
pmo-trunk-r1787
Murray Cumming [Tue, 8 May 2007 13:05:36 +0000 (13:05 +0000)]
2007-05-08 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c:
Added modest_account_mgr_get_display_name(),
modest_server_account_get_username(),
modest_server_account_set_username(),
modest_server_account_set_password(),
modest_server_account_get_hostname() functions so we do not need to
use the conf API directly.
* src/maemo/modest-main-window.c: (connect_signals):
Actually connect ot the ModestAccountStore::request-password signal,
so that we show the dialog when the password is requested by Tinymail,
for isntance if it is empty.
* src/modest-marshal.list:
* src/modest-tny-account-store.c:
(modest_tny_account_store_class_init), (get_password),
(modest_tny_account_store_alert):
* src/modest-tny-account-store.h:
* src/modest-ui-actions.h:
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested):
Change the signal parameters, so it is obvious that we are providing
the non human-readable server name, and receiving both the username
and password, though changing of the username is not yet implemented.
Change the dialog UI to match the Maemo UI specifications, with #idfefing
for the GNOME version.
This should fix the projects.maemo.org bug NB#56209, though it does not
work on Bora, because the gconf_client_get() for the password fails
immediately after we save it with gconf_client_set().
pmo-trunk-r1786