Javier Fernandez Garcia-Boente [Sat, 2 Jun 2007 11:00:31 +0000 (11:00 +0000)]
* Implement remain dimming rules (toolbar and context sensitive menus)
* Fixes: #NB57265, #NB57627, #NB57628, #NB57629, #NB57514, #NB58549, #NB58608, #NB59186, #NB59236
pmo-trunk-r2043
Murray Cumming [Fri, 1 Jun 2007 18:10:45 +0000 (18:10 +0000)]
2007-06-01 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
Check for running mail operations, and offer to cancel them, as per the UI
spec. This fixes projects.maemo.org bug NB#59041 .
However, I suspect that tinymail may still use the network connection
in ways that we cannot detect or cancel. But it should at least adapt to
changes fairly well.
pmo-trunk-r2042
Murray Cumming [Fri, 1 Jun 2007 17:49:48 +0000 (17:49 +0000)]
2007-06-01 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (recreate_all_accounts),
(get_cached_accounts), (get_server_accounts): Do more sensible
ref-counting of the temporarily-cached outbox accounts list. This seems
to fix a crash when entering the password when the password was wrong.
pmo-trunk-r2041
Jose Dapena Paz [Fri, 1 Jun 2007 16:46:11 +0000 (16:46 +0000)]
* src/modest-ui-actions.c:
* Fixed the cut/copy/paste clipboard actions. It was storing
the information in GDK_SELECTION_PRIMARY for widgets that let
you choose the clipboard to use. Now it uses
GDK_SELECTION_CLIPBOARD, the expected one (fixes NB#56935).
pmo-trunk-r2040
Jose Dapena Paz [Fri, 1 Jun 2007 16:31:30 +0000 (16:31 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Now the window title is updated on subject change and on
message edition startup (fixes NB#56901).
pmo-trunk-r2039
Jose Dapena Paz [Fri, 1 Jun 2007 15:21:00 +0000 (15:21 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Fixed a tricky bug. As I runned update-dimmed on focus out,
and focus out event was happening on clicking the color
toolbar button, and the update_dimmed dimmed the button
itself, it was never running the click action. After
preventing the color toolbar button from getting focus, it
works as expected (fixes NB#55874).
pmo-trunk-r2038
Sergio Villar Senin [Fri, 1 Jun 2007 15:05:50 +0000 (15:05 +0000)]
* Added a unique identifier per header
* Fixes NB#58780
pmo-trunk-r2037
Murray Cumming [Fri, 1 Jun 2007 15:05:50 +0000 (15:05 +0000)]
2007-06-01 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-retrieve-combo-box.c:
(modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
This fixes projects.maemo.org bug NB#58472 .
pmo-trunk-r2036
Jose Dapena Paz [Fri, 1 Jun 2007 13:54:25 +0000 (13:54 +0000)]
* src/modest-ui-actions.c:
* If subject or body are empty on sending message, show
dialogs to request confirmation (fixes NB#56696).
pmo-trunk-r2035
Murray Cumming [Fri, 1 Jun 2007 10:37:34 +0000 (10:37 +0000)]
Aargh, really fix it.
pmo-trunk-r2033
Murray Cumming [Fri, 1 Jun 2007 10:36:52 +0000 (10:36 +0000)]
2007-06-01 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_complete_easysetup):
(create_page_complete_custom): Correct the last commit,
putting the correct sentences in the correct pages.
pmo-trunk-r2032
Murray Cumming [Fri, 1 Jun 2007 10:34:18 +0000 (10:34 +0000)]
2007-06-01 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_page_complete_custom): Show the second sentence of text
(mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
NB#59023 .
pmo-trunk-r2031
Murray Cumming [Fri, 1 Jun 2007 10:22:54 +0000 (10:22 +0000)]
2007-06-01 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c: (modest_account_mgr_add_account):
Set the leave-on-server conf key by default. This fixes
projects.maemo.org bug NB#59258 .
pmo-trunk-r2030
Murray Cumming [Fri, 1 Jun 2007 10:11:19 +0000 (10:11 +0000)]
sbox-SDK_X86: ~/svn/modest-private/modest-email/modest/trunk] > more ChangeLog2
2007-06-01 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-view-window.c:
(on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
logical ID for the confirmation messages. Fixed projects.maemo.org bug
NB#59037 .
pmo-trunk-r2029
Murray Cumming [Fri, 1 Jun 2007 10:05:14 +0000 (10:05 +0000)]
Removed debug printf.
pmo-trunk-r2028
Murray Cumming [Fri, 1 Jun 2007 09:57:26 +0000 (09:57 +0000)]
2007-06-01 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(create_caption_new_with_asterisk):
* src/maemo/modest-account-settings-dialog.c:
(create_caption_new_with_asterisk):
Uncomment the code to add the asterisk, because they are no longer in the
translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
(update_incoming_server_title): Add an asterisk here too.
pmo-trunk-r2027
Jose Dapena Paz [Fri, 1 Jun 2007 09:38:39 +0000 (09:38 +0000)]
* src/maemo/modest-msg-edit-window-ui.h:
* Added escape accel ui action.
* src/maemo/ui/modest-msg-edit-window-ui.xml:
* Added escape accel.
pmo-trunk-r2026
Murray Cumming [Fri, 1 Jun 2007 09:10:15 +0000 (09:10 +0000)]
2007-06-01 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-global-settings-dialog.c:
(current_connection): Check that we are even connected before trying to
get the current connection name, to prevent a warning.
* src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
Change the comments because tny_maemo_conic_device_connect() is now meant to
block.
* src/modest-mail-operation.c:
(modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
make sure we have a connection and fail if we can't connect.
pmo-trunk-r2025
Dirk-Jan C. Binnema [Fri, 1 Jun 2007 07:24:04 +0000 (07:24 +0000)]
* made release
pmo-trunk-r2024
Jose Dapena Paz [Thu, 31 May 2007 21:24:59 +0000 (21:24 +0000)]
* src/maemo/modest-connection-specific-smtp-window.c:
* Add a default string "Not defined" for connections without an smtp
server configured (fixes NB#59217).
pmo-trunk-r2023
Sergio Villar Senin [Thu, 31 May 2007 18:42:39 +0000 (18:42 +0000)]
* Fixed a funny typo
pmo-trunk-r2022
Murray Cumming [Thu, 31 May 2007 17:58:57 +0000 (17:58 +0000)]
2007-05-31 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c:
(on_account_store_connecting_finished): Do not try to get the
connection ID if we are not really connected. I am surprised that
this signal handler is called when we are not connected.
pmo-trunk-r2021
Sergio Villar Senin [Thu, 31 May 2007 17:52:47 +0000 (17:52 +0000)]
* Fixes NB#57580
* Fixed some issues in a text conversion function
* Do not dimm Email->Details if the folder view has the focus
pmo-trunk-r2020
Murray Cumming [Thu, 31 May 2007 17:44:48 +0000 (17:44 +0000)]
2007-05-31 Murray Cumming <murrayc@murrayc.com>
* src/modest-error.h:
* src/modest-ui-actions.c:
(modest_ui_actions_get_msgs_full_error_handler):
Renamed an enum, added comments, added an enum
for retrieve-limit errors.
* src/modest-mail-operation.c: (foreach_add_item),
(internal_folder_observer_update), (update_account_thread),
(modest_mail_operation_get_msgs_full):
(modest_mail_operation_update_account),
Added comments about how this works, and some code that should
(but does not) check the retrieve-limit. See the TODO comment.
pmo-trunk-r2019
Jose Dapena Paz [Thu, 31 May 2007 16:48:55 +0000 (16:48 +0000)]
* src/widgets/modest-attachments-view.c:
* Now set_message cleans the selected messages list. This way, setting
a new message when there was a selection does not crash (fixes
NB#58227).
pmo-trunk-r2018
Sergio Villar Senin [Thu, 31 May 2007 16:41:35 +0000 (16:41 +0000)]
* Fixes NB#59208
pmo-trunk-r2017
Sergio Villar Senin [Thu, 31 May 2007 16:29:30 +0000 (16:29 +0000)]
* Fixes NB#57490
pmo-trunk-r2016
Dirk-Jan C. Binnema [Thu, 31 May 2007 15:53:34 +0000 (15:53 +0000)]
* new release
pmo-trunk-r2014
Jose Dapena Paz [Thu, 31 May 2007 15:10:54 +0000 (15:10 +0000)]
* src/widgets/modest-header-view-render.c:
* When we want to fill the attach and priority icons with an empty value
(and show them in blank) we don't need to retrieve a non existing icon,
setting a NULL to the pixbuf cell renderer works. This fix removes
a warning on runtime.
* src/maemo/modest-icon-names.h:
* Updated the trash and junk icon names. This removes also warnings trying
to get non existing icons in theme.
pmo-trunk-r2013
Murray Cumming [Thu, 31 May 2007 15:00:42 +0000 (15:00 +0000)]
2007-05-31 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (modest_ui_actions_on_help):
Initialize help_id to fix the build. Warnings are good.
pmo-trunk-r2012
Jose Dapena Paz [Thu, 31 May 2007 14:51:37 +0000 (14:51 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Select font dialog was not destroyed on cancel. This made the app unusable after
cancelling the dialog. I moved the widget destroy code to make the dialog work
on Ok and Cancel actions.
pmo-trunk-r2011
Jose Dapena Paz [Thu, 31 May 2007 14:09:48 +0000 (14:09 +0000)]
* src/maemo/modest-msg-view-window.c:
* Dims "Add to contacts" at startup of the widget, as clipboard
should be empty. This prevents trying to add a non valid contact
(fixes NB#57415).
pmo-trunk-r2010
Philip Van Hoof [Thu, 31 May 2007 13:51:32 +0000 (13:51 +0000)]
Partial bugfix for 57415
pmo-trunk-r2009
Sergio Villar Senin [Thu, 31 May 2007 12:03:42 +0000 (12:03 +0000)]
* Fixes NB#57592
* Adds Help support to the windows, and folder and header CSMs
pmo-trunk-r2008
Sergio Villar Senin [Thu, 31 May 2007 11:51:15 +0000 (11:51 +0000)]
* Fixed a compilation issue in OSSO1.1
pmo-trunk-r2007
Jose Dapena Paz [Thu, 31 May 2007 10:54:28 +0000 (10:54 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Removed the old text_buffer_mark_set handler as it's not required
now to make cursor scroll update work, and it was causing a
crash (fixes NB#56975).
pmo-trunk-r2006
Murray Cumming [Thu, 31 May 2007 08:44:58 +0000 (08:44 +0000)]
2007-05-31 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-hbox-cell-renderer.c:
(modest_hbox_cell_renderer_append):
* src/widgets/modest-vbox-cell-renderer.c:
(modest_vbox_cell_renderer_append):
Fix the last commit by doing an extra ref.
pmo-trunk-r2005
Murray Cumming [Thu, 31 May 2007 07:49:28 +0000 (07:49 +0000)]
2007-05-31 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-hbox-cell-renderer.c:
(modest_hbox_cell_renderer_append):
* src/widgets/modest-vbox-cell-renderer.c:
(modest_vbox_cell_renderer_append):
For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
to fix the build with Maemo Bora.
However, there seems to be a remaining crash, probably due to reference
counting errors.
pmo-trunk-r2004
Sergio Villar Senin [Thu, 31 May 2007 07:38:05 +0000 (07:38 +0000)]
* Fixes NB#56485
* Now the paned separator is drawn in its correct place
pmo-trunk-r2003
Dirk-Jan C. Binnema [Thu, 31 May 2007 05:58:13 +0000 (05:58 +0000)]
* update debian changelog
pmo-trunk-r2002
Jose Dapena Paz [Wed, 30 May 2007 16:55:50 +0000 (16:55 +0000)]
* src/widgets/modest-header-view-render.c:
* (get_pixbuf_for_flag): now it also supports getting specific
icons for high and low priorities.
* Removed get_pixbuf_for_compact_flag,
_modest_header_view_header_cell_data,
_modest_header_view_compact_date_cell_data, as it's not
required in the new header view.
* Modified the compact view for header view. Now it uses the
new hbox and vbox cell renderers. Modified also to have
specific cell renderers for the attachment and priority
icons. Here we fill the new cell renderers using the model.
* Added src/widgets/modest-hbox-cell-renderer.c:
* New cell renderer that let's developer embed cell renderers
in an horizontal layout. Supports specific expanded cell
renderers.
* Added src/widgets/modest-vbox-cell-renderer.c:
* New cell renderer that let's developer embed cell renderers
in an vertical layout. Supports specific expanded cell
renderers.
* src/widgets/modest-header-view.c:
* Now cmp_rows is only used for comparing flag columns.
* Reworked all the sorting code, to use tree model column id's.
* Modified the compact view for header view. Now it uses the
new hbox and vbox cell renderers. Modified also to have
specific cell renderers for the attachment and priority
icons. Here we construct the cell renderers.
* src/modest-init.c:
* Removed the old layout cells for compact view.
* src/maemo/modest-platform.c:
* Reworked the sort dialog to fit with the new sort code
in header view.
pmo-trunk-r2001
Murray Cumming [Wed, 30 May 2007 16:35:53 +0000 (16:35 +0000)]
2007-05-30 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_for_local_folders):
Use hildon_file_system_info_async_new() to get a better name for
the memory card account, setting it as the account name.
The timing seems to work, but this is probably
not the best place to do this. See the TODO comment.
* src/maemo/modest-main-window.c: (create_details_widget):
* src/widgets/modest-folder-view.c: (text_cell_data):
Use the tny account name instead of hardcoding a name.
pmo-trunk-r2000
Christian Kellner [Wed, 30 May 2007 13:31:45 +0000 (13:31 +0000)]
2007-05-30 Christian Kellner <ckellner@openismus.com>
* src/modest-search.c: (modest_search):
Correctly set part_search_func even if we have already parsed
the query and thus a valid OgsTextSearcher object.
pmo-trunk-r1999
Christian Kellner [Wed, 30 May 2007 13:27:07 +0000 (13:27 +0000)]
2007-05-30 Christian Kellner <ckellner@openismus.com>
* configure.ac:
Search and check for libogs.
* src/Makefile.am:
Incooparte the ogs build env.
* src/modest-mime-part-search-stream.c:
* src/modest-mime-part-search-stream.h:
Removed since we do the real searching now in modest-search.c.
* src/modest-search.c:
* src/modest-search.h:
Implement support for ogs. We use that if available and requested
and fall back to modest_text_utils_utf8_strcmp (). The search logic
should now handle the corner case when the search term is spread
across multiple reads.
Also the logic in modest_search () was corrected to search all
requested fields until one is found.
pmo-trunk-r1998
Sergio Villar Senin [Wed, 30 May 2007 12:50:39 +0000 (12:50 +0000)]
* Removed an invalid g_object_unref in a mail operation
* Rewritten the dimming rules for the "new folder" action
* Removed some invalid comments
* Fixed some errors in mail_operation_create_folder
pmo-trunk-r1997
Javier Fernandez Garcia-Boente [Wed, 30 May 2007 12:29:41 +0000 (12:29 +0000)]
* Add the MsgView Window dimming rules file.
* Fix bug on mail-operation, cancel operation was commented.
* Fix bug on mail_operation_queue_remove, it did not take
into account mail op status may be CANCELED.
* Implemented some main and msg view windows dimming rules.
pmo-trunk-r1996
Murray Cumming [Wed, 30 May 2007 12:27:26 +0000 (12:27 +0000)]
2007-05-30 Murray Cumming <murrayc@murrayc.com>
* src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
* src/modest-init.h:
* src/modest-init.c: Made modest_init_local_folders() take a
path and be public so we can iniitialize maildir folders on
arbitrary volumes.
* src/modest-local-folder-info.h:
* src/modest-local-folder-info.c:
(modest_local_folder_info_get_maildir_path): Add a path parameter.
* src/modest-tny-account.c:
(modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
still means the standard local-folders path on the local volume.
* src/modest-tny-account-store.c:
(modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
signal so we can detect mount/unmount of the MMC1 card, and do an update of
all accounts when that happens.
(get_server_accounts): If the MMC1 card is mounted, create a store account for
this too, so it shows up in the treeview.
pmo-trunk-r1995
Sergio Villar Senin [Wed, 30 May 2007 09:24:32 +0000 (09:24 +0000)]
* Preppended a FIXME to the MMC provisional name until there is now way to get it
* The local account has its name properly set again
pmo-trunk-r1994
Sergio Villar Senin [Wed, 30 May 2007 07:55:24 +0000 (07:55 +0000)]
* Just an aesthetic change to add two bugfixes commit comments
* Fixes NB#56137, NB#56140
pmo-trunk-r1993
Sergio Villar Senin [Wed, 30 May 2007 07:27:00 +0000 (07:27 +0000)]
* Added a sanity check in error handling code
* Added status information to get_msgs_full mail operation
* Replaced some GError variables by priv->error of mail operations
* Added a new error code
pmo-trunk-r1992
Javier Fernandez Garcia-Boente [Tue, 29 May 2007 20:39:49 +0000 (20:39 +0000)]
* Implementation of 'email menu' dimming rules of main window.
* Implementation of 'edit menu' dimming rules of main window.
* Implementation of 'folder view CSM' dimming rules of main window.
pmo-trunk-r1991
Sergio Villar Senin [Tue, 29 May 2007 17:40:01 +0000 (17:40 +0000)]
* Fixed NB#57522
* Added delete_folder and move_folder error handling code
* Deleted some invalid error handling code
pmo-trunk-r1990
Sergio Villar Senin [Tue, 29 May 2007 17:12:03 +0000 (17:12 +0000)]
* Fixes NB#57522
* Slightly modified the mail operations error handler signature
* Added the code that launches the mail operation error handlers
* Added information note that is shown when the message size limit is exceeded
pmo-trunk-r1989
Javier Fernandez Garcia-Boente [Tue, 29 May 2007 15:39:23 +0000 (15:39 +0000)]
* widgets/modest-window.c: Add a method to get action from its private
ui_manager instance. A new UI Dimming Manager was added too, and methods
for calling this dimming manager to check dimming rules.
* modest-mail-operation.c: Add a new private field into mail operation
to set an user defined callback to perform actions when some error
is detected during mail operation execution.
Add support to cancel tinymail operations, aborting camel operaiton
in progress. To identify operaiton to cancel, a new private field was
added to private section of mail_operation: account.
* modest-ui-dimming-manager.c: A new dimming rules design apporach.
very similar to UI Manager pattern.
pmo-trunk-r1988
Sergio Villar Senin [Tue, 29 May 2007 15:15:06 +0000 (15:15 +0000)]
* Fixes #NB57458
* Fixes a bug when applying message count limits, we're trying to retrieve more msgs than the new available ones
* Removed an invalid comment
pmo-trunk-r1987
Sergio Villar Senin [Tue, 29 May 2007 13:27:05 +0000 (13:27 +0000)]
* Fixes NB#56966, NB#57493
* Now the folder view remembers its last selected folder and shows it when the application is launched
* Commented some debug code
* Removed an unneeded call to update_model
pmo-trunk-r1986
Sergio Villar Senin [Tue, 29 May 2007 10:38:22 +0000 (10:38 +0000)]
* Do not emit account_changed when the value that has changed is last_updated. This saves us a call to update_model in the folder view
pmo-trunk-r1985
Javier Fernandez Garcia-Boente [Tue, 29 May 2007 10:04:41 +0000 (10:04 +0000)]
* Fix bug on create_account wizard.
retrieve_type was not set when a new account
is created. I set 'Headers only' type as
default value.
pmo-trunk-r1984
Sergio Villar Senin [Tue, 29 May 2007 06:51:16 +0000 (06:51 +0000)]
* Added some comments
* Deleted unneccessary async helper structure
pmo-trunk-r1983
Murray Cumming [Mon, 28 May 2007 16:52:15 +0000 (16:52 +0000)]
2007-05-28 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-global-settings-dialog.c:
(current_connection):
* src/widgets/modest-global-settings-dialog.c:
(current_connection_default):
Use the enum values instead of 0, 1 and -1,
to make the code clearer.
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_get_connection_specific_smtp): Make this code
more robust.
* src/modest-runtime.h:
* src/modest-runtime.c:
Added modest_runtime_remove_all_send_queues().
* src/maemo/modest-main-window.c:
(on_account_store_connecting_finished): Recreate the send queues,
using the appropriate transport accounts for this new connection.
Some futher adapting might be needed if the old send queues are not
automatically stopped at this point.
* src/modest-tny-account-store.c: (get_server_accounts):
Create the connection-specific transport accounts, so that they can
be found later by their ID.
* src/modest-tny-account.h:
* src/modest-tny-account.c:
Added modest_tny_account_new_from_server_account_name().
modest_tny_account_new_from_server_account(): Do not create the
send queues here, because they will be
recreated anyway when the connection changes for the first time.
pmo-trunk-r1982
Sergio Villar Senin [Mon, 28 May 2007 16:38:11 +0000 (16:38 +0000)]
* Fixes NB#57398
pmo-trunk-r1981
Sergio Villar Senin [Mon, 28 May 2007 10:27:19 +0000 (10:27 +0000)]
* Sort messages by date, before retrieving the last N ones
pmo-trunk-r1980
Murray Cumming [Mon, 28 May 2007 09:48:34 +0000 (09:48 +0000)]
2007-05-28 Murray Cumming <murrayc@murrayc.com>
* src/modest-local-folder-info.h:
* src/modest-local-folder-info.c:
(modest_per_account_local_outbox_folder_info_get_maildir_path),
(modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
tbox_folder): Take a modest account name instead of a server TnyAccount,
so we can have per-modest-account rather than per-transport-account
outboxes.
We must make sure that we change or recreate the exisitng send queues
when the connection changes for connection-specific transport accounts.
* src/modest-tny-account-store.c:
(create_per_account_local_outbox_folders): Create outboxed per modest
account, not per transport account.
* src/modest-tny-account.h:
* src/modest-tny-account.c:
(modest_tny_account_get_special_folder): For outboxes, get the
parent modest account name. The account is ignored for other folders.
(modest_tny_account_new_for_per_account_local_outbox_folder): Take a
modest account name rather than a server TnyAccount.
pmo-trunk-r1979
Sergio Villar Senin [Mon, 28 May 2007 08:18:45 +0000 (08:18 +0000)]
* Only return the local account if we're asking for store accounts
pmo-trunk-r1978
Murray Cumming [Mon, 28 May 2007 08:16:02 +0000 (08:16 +0000)]
Added a TODO comment
pmo-trunk-r1977
Murray Cumming [Fri, 25 May 2007 11:07:29 +0000 (11:07 +0000)]
2007-05-25 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
Call modest_runtime_get_send_queue() immediately after creating transport
accounts, so that they start trying to send email from the outbox as soon
as possible at startup. This is probably what we want.
* src/modest-mail-operation.c: (update_account_thread):
* src/modest-runtime.c: (modest_runtime_get_send_queue):
* src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
* src/modest-tny-send-queue.h:
* src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
(modest_ui_actions_on_send):
Added comments about how sending works, though it needs some more work.
pmo-trunk-r1976
Murray Cumming [Fri, 25 May 2007 09:19:25 +0000 (09:19 +0000)]
Make the debug messages slightly more attractive.
pmo-trunk-r1975
Murray Cumming [Fri, 25 May 2007 09:08:15 +0000 (09:08 +0000)]
2007-05-25 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_get_special_folder): Add TODO because this fails when
the network is busy.
(modest_tny_folder_store_get_local_size): Fix an incorrect type check.
* src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
Do not try to show this window when there is no active account. The UI
specs does not tell us what to do in this case.
pmo-trunk-r1974
Sergio Villar Senin [Thu, 24 May 2007 16:48:44 +0000 (16:48 +0000)]
* Added mcen_nc_get_multi_msg_txt confirmation dialog when replying/forwarding a mail
pmo-trunk-r1973
Sergio Villar Senin [Thu, 24 May 2007 15:25:31 +0000 (15:25 +0000)]
* Added per-message size limit to send&receive
* Added per-account amount limit to s&r
* Added per-account retrieve last N feature
* Added an unique id to each mail operation
* Renamed id field of mail operation by operation type
* Added ModestMailOperationState to provide progress information
* Added a new parameter of type ModestMailOperationState to progress-changed signal
* Added an internal object to mail operation to get the new messages after a refresh
pmo-trunk-r1972
Murray Cumming [Thu, 24 May 2007 14:40:48 +0000 (14:40 +0000)]
2007-05-24 Murray Cumming <murrayc@murrayc.com>
* Makefile.am:
* po/POTFILES.in:
* src/maemo/Makefile.am:
* src/widgets/Makefile.am: Some dist fixes.
pmo-trunk-r1971
Murray Cumming [Thu, 24 May 2007 12:31:42 +0000 (12:31 +0000)]
2007-05-24 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-connection-specific-smtp-window.c:
(on_button_edit): Make the code clearer, to prevent a double free.
pmo-trunk-r1970
Murray Cumming [Thu, 24 May 2007 11:56:19 +0000 (11:56 +0000)]
2007-05-24 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name),
Check the connection-specific smtp servers checkbox if there are any.
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
Start with a suitable port number.
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c: Added
modest_account_mgr_get_has_connection_specific_smtp().
(modest_account_mgr_set_connection_specific_smtp),
(modest_account_mgr_remove_connection_specific_smtp),
(modest_account_mgr_get_has_connection_specific_smtp),
(modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
connection-specific smtp server accounts in the account, rather than
the server account conf dir.
This fixes bug projects.maemo.org bug NB#58263 .
* src/modest-tny-account-store.c:
(create_per_account_local_outbox_folders): Do not call get_server_accounts()
if there are no server accounts yet, to prevent an infinite loop when there
are no accounts. Document that one must be called before the other.
pmo-trunk-r1969
Murray Cumming [Thu, 24 May 2007 10:40:39 +0000 (10:40 +0000)]
2007-05-24 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_get_default_account): Make sure that at least
one account is always the default, if there are any enabled accounts.
This is just a sanity check that shouldn't be necessary.
* src/modest-account-mgr-priv.c:
(_modest_account_mgr_account_from_key): Unescape the conf key to
get the real account name. For instance, this is an issue if a space
was in the account name, which can happen because the account name
is generated from the display name.
(_modest_account_mgr_get_account_keyname): Always escape the
account name.
* src/modest-account-mgr.c: (modest_account_mgr_account_names):
Unescape the conf keys to get the real account names.
For instance, previously the is-default radio button in the accounts
list was not checked for any accounts at first. This fixes that,
and might fix several similar bugs.
pmo-trunk-r1968
Murray Cumming [Thu, 24 May 2007 08:26:03 +0000 (08:26 +0000)]
Remove unnecessary check and add a comment.
pmo-trunk-r1967
Sergio Villar Senin [Thu, 24 May 2007 08:20:35 +0000 (08:20 +0000)]
* Removed an invalid comment
pmo-trunk-r1966
Murray Cumming [Wed, 23 May 2007 16:47:32 +0000 (16:47 +0000)]
2007-05-23 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (set_active_account_from_tny_account):
Removed some debug printfs.
pmo-trunk-r1965
Murray Cumming [Wed, 23 May 2007 16:45:57 +0000 (16:45 +0000)]
2007-05-23 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (set_active_account_from_tny_account):
Removed some debug printfs.
pmo-trunk-r1964
Murray Cumming [Wed, 23 May 2007 14:05:45 +0000 (14:05 +0000)]
2007-05-23 Murray Cumming <murrayc@murrayc.com>
Modest on-disk outbox directories are now here, for instance:
/home/murrayc/.modest/outboxes/<account-id-1>/outbox
/home/murrayc/.modest/outboxes/<account-id-2>/outbox
instead of here:
/home/murrayc/.modest/local-folders/outbox
so we can have a separate outbox for each account.
But they are shown as one outbox in the GtkTreeView, by using a
TnyMergeFolder in a ModestTnySimpleFolderStore.
* src/Makefile.am:
* src/modest-tny-simple-folder-store.c:
* src/modest-tny-simple-folder-store.h:
Added ModestTnySimpleFolderStore, used to contain folders from
other folder stores, such as other accounts.
* src/modest-tny-outbox-account.h:
* src/modest-tny-outbox-account.c:
Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
used for the per-account local outbox folders.
* src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
only use this (internally) now for the non-outbox local folders.
* src/modest-init.h:
* src/modest-init.c: Added modest_init_one_local_folder(), for
setting up the directory structure for each local folder.
* src/modest-local-folder-info.c:
(modest_per_account_local_outbox_folder_info_get_maildir_path),
(modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
tbox_folder):
* src/modest-local-folder-info.h:
* src/modest-tny-account-store.c: (on_account_removed),
(on_account_changed), (create_per_account_local_outbox_folders),
(get_server_accounts), (modest_tny_account_store_get_accounts),
(modest_tny_account_store_get_tny_account_by_account),
(modest_tny_folder_store_is_virtual_local_folders):
* src/modest-tny-account.h:
* src/modest-tny-account.c:
Added modest_tny_account_new_for_per_account_local_outbox_folder(),
to create an on-disk per-account local outbox folder for each
transport account.
(create_per_account_local_outbox_folders): Create a local outbox folder
for each transport account.
(modest_tny_account_new_for_local_folders): Do not create an outbox folder
for all local folders.
Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
instead of using g_object_get/set() directly. It is clearer.
(modest_tny_folder_store_get_message_count),
(modest_tny_folder_store_get_local_size
(modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
because we now use these with non-acount folder stores.
(modest_tny_account_get_special_folder),
(modest_tny_account_new_from_server_account),
(modest_tny_account_new_from_account):
(recurse_folders): Adjust to the new outbox system.
* src/modest-tny-folder.h:
* src/modest-tny-folder.c:
(modest_tny_folder_is_local_folder),
(modest_tny_folder_get_local_folder_type),
(modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
* src/widgets/modest-main-window.h:
* src/maemo/modest-main-window.c: (create_details_widget),
(modest_main_window_set_contents_style): Show details for any folder store,
not just accounts.
(modest_tny_folder_get_rules):
Remove the const. C does not support constness enough for this.
* src/modest-ui-actions.c:
update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
make all outboxes appear as one, in the usual local-folders tree node.
(set_active_account_from_tny_account),
(modest_ui_actions_on_folder_selection_changed):
* src/widgets/modest-folder-view.c: (text_cell_data),
(icon_cell_data), (filter_row),
(add_account_folders_to_merged_folder),
(add_account_folders_to_simple_folder_store), (),
(get_cmp_rows_type_pos), (cmp_rows),
(modest_folder_view_set_account_id_of_visible_server_account):
Adjust to the new outbox system, using generic folder stores and folder
in the GtkTreeModel.
pmo-trunk-r1963
Christian Kellner [Wed, 23 May 2007 11:48:24 +0000 (11:48 +0000)]
2007-05-23 Christian Kellner <ckellner@openismus.com>
* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
Use info->max_size instead of unintialized local var [small
build fix]. (Added TODO to review that change since I don't
know the code)
pmo-trunk-r1962
Sergio Villar Senin [Wed, 23 May 2007 08:20:29 +0000 (08:20 +0000)]
* First steps to apply global and per-account settings to send&receive
pmo-trunk-r1961
Sergio Villar Senin [Wed, 23 May 2007 07:30:54 +0000 (07:30 +0000)]
* Fixes NB#57328
* Fixed a memory leak
pmo-trunk-r1960
Marcus Bauer [Wed, 23 May 2007 07:10:55 +0000 (07:10 +0000)]
2007-05-23 Marcus Bauer <marcusb@openismus.com>
* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_compose_mail): function added
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
(on_compose_mail): Implementation of the SendAsMail functionality
pmo-trunk-r1959
Sergio Villar Senin [Tue, 22 May 2007 18:18:55 +0000 (18:18 +0000)]
* Reverted the two new folder rules, both are NON_WRITABLE
pmo-trunk-r1958
Sergio Villar Senin [Tue, 22 May 2007 17:54:40 +0000 (17:54 +0000)]
* Added some missing rules to the xfer_folder and xfer_msgs operations
pmo-trunk-r1956
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:40:54 +0000 (17:40 +0000)]
* move modest/scripts to modest-script (separate place)
pmo-trunk-r1955
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:39:18 +0000 (17:39 +0000)]
* add some error error checking when trying to retrieve the device name
pmo-trunk-r1954
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:34:47 +0000 (17:34 +0000)]
* remove wrong dep
pmo-trunk-r1953
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:32:23 +0000 (17:32 +0000)]
* remove changelog2 in garage
pmo-trunk-r1952
Sergio Villar Senin [Tue, 22 May 2007 16:56:16 +0000 (16:56 +0000)]
* Fixes: NB#57465
* Fixed a bug in the account store
* Fixed several memory leaks
* Refactored the code that loads a list of messages from the headers
* Improved reference counting in msg view window
* Added modest_mail_operation_get_source
* Added the global account settings default values to modest init
pmo-trunk-r1950
Dirk-Jan C. Binnema [Tue, 22 May 2007 12:30:58 +0000 (12:30 +0000)]
* updated debian/changelog
pmo-trunk-r1949
Dirk-Jan C. Binnema [Tue, 22 May 2007 12:28:09 +0000 (12:28 +0000)]
* put shlib symlinks in the library package
pmo-trunk-r1948
Murray Cumming [Tue, 22 May 2007 09:05:51 +0000 (09:05 +0000)]
2007-05-22 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c:
(modest_account_mgr_add_server_account): Set the secure-connection
conf key for transport accounts as well as store accounts. I don't know
why the if was there. For instance, this makes sure that we use SSL
for the gmail preset from the easysetup wizard.
pmo-trunk-r1947
Sergio Villar Senin [Tue, 22 May 2007 08:49:46 +0000 (08:49 +0000)]
* Fixes NB#57478
* Fixes NB#57325
pmo-trunk-r1946
Murray Cumming [Tue, 22 May 2007 08:21:20 +0000 (08:21 +0000)]
2007-05-22 Murray Cumming <murrayc@murrayc.com>
* src/gnome/modest-main-window.c:
(on_account_store_connecting_finished), (connect_signals):
* src/maemo/modest-main-window.c:
(on_account_store_connecting_finished), (connect_signals),
(modest_main_window_new):
Handle TnyAccountStore::connecting-finished instead of
TnyDevice::connection-changed, because we cannot actually perform
operations on accounts until TnyAccountStore has itself responded to
the TnyDevice::connection-changed signal. This prevents a GError from
tinymail.
Do not try to update at startup, because we (at least on scratchbox)
already do an update at startup when the device goes online.
This prevents a GError from tinymail.
* src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
Added TODO about stopping simultaneous operations.
pmo-trunk-r1945
Marcus Bauer [Tue, 22 May 2007 06:39:06 +0000 (06:39 +0000)]
2007-05-22 Marcus Bauer <marcusb@openismus.com>
* src/dbus_api/modest-dbus-api.h:
added MODEST_DBUS_METHOD_COMPOSE_MAIL
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
(on_compose_mail), (on_idle_open_message),
(modest_dbus_req_handler):
added on_compose_mail()
pmo-trunk-r1944
Dirk-Jan C. Binnema [Mon, 21 May 2007 18:48:31 +0000 (18:48 +0000)]
* update the scripts
pmo-trunk-r1943
Murray Cumming [Mon, 21 May 2007 14:46:40 +0000 (14:46 +0000)]
2007-05-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c: (modest_account_mgr_add_account):
* src/modest-mail-operation-queue.c:
(modest_mail_operation_queue_remove):
* src/modest-tny-account-store.c: When GErrors happen, give more clues
about where they happened.
pmo-trunk-r1942
Sergio Villar Senin [Mon, 21 May 2007 14:36:27 +0000 (14:36 +0000)]
* Removed xfer_folder_async, all the xfer_folder operations are now async
* Fixed a logical error when drag&drop
pmo-trunk-r1941
Murray Cumming [Mon, 21 May 2007 13:35:22 +0000 (13:35 +0000)]
2007-05-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested): Make sure that the remember
output parameter is always TRUE.
pmo-trunk-r1940