modest
16 years ago* src/modest-tny-msg.c
Alberto Garcia [Fri, 14 Mar 2008 09:34:23 +0000 (09:34 +0000)]
* src/modest-tny-msg.c
(modest_tny_msg_find_body_part_from_mime_part):
Check for NULL values of Content-Type, avoids a Gtk Warning

pmo-trunk-r4308

16 years ago* src/modest-tny-msg.c:
Jose Dapena Paz [Thu, 13 Mar 2008 15:36:07 +0000 (15:36 +0000)]
* src/modest-tny-msg.c:
* Don't ignore signed multiparts (and then, now we can see
  multipart/signed messages).

pmo-trunk-r4307

16 years ago* src/maemo/modest-main-window-ui.h
Alberto Garcia [Thu, 13 Mar 2008 11:52:05 +0000 (11:52 +0000)]
* src/maemo/modest-main-window-ui.h
Replace some messages with their logical strings
Fixes NB#80972

pmo-trunk-r4306

16 years ago * Fixes NB#82487, added logical id for the auth detection dialog
Sergio Villar Senin [Thu, 13 Mar 2008 10:22:14 +0000 (10:22 +0000)]
* Fixes NB#82487, added logical id for the auth detection dialog

pmo-trunk-r4305

16 years ago * Fixes NB#82486, use the proper logical id while checking auth methods
Sergio Villar Senin [Thu, 13 Mar 2008 09:54:18 +0000 (09:54 +0000)]
* Fixes NB#82486, use the proper logical id while checking auth methods

pmo-trunk-r4304

16 years ago * Fixes NB#82493, show proper translation string for secure auth methods
Sergio Villar Senin [Thu, 13 Mar 2008 09:36:14 +0000 (09:36 +0000)]
* Fixes NB#82493, show proper translation string for secure auth methods

pmo-trunk-r4303

16 years ago* src/maemo/modest-msg-edit-window.c
Alberto Garcia [Wed, 12 Mar 2008 14:31:17 +0000 (14:31 +0000)]
* src/maemo/modest-msg-edit-window.c
(modest_msg_edit_window_remove_attachments): Fix problem
showing the plural form of emev_nc_delete_attachment
Fixes NB#81015

pmo-trunk-r4302

16 years ago* src/modest-mail-operation.c
Alberto Garcia [Wed, 12 Mar 2008 14:04:34 +0000 (14:04 +0000)]
* src/modest-mail-operation.c
(modest_mail_operation_get_msgs_full): Fix memory leak
Fixes NB#80198

pmo-trunk-r4301

16 years ago* src/modest-ui-actions.c:
Jose Dapena Paz [Wed, 12 Mar 2008 12:17:52 +0000 (12:17 +0000)]
* src/modest-ui-actions.c:
* Modified the error strings for smtp send failure, as suggested
  in NB#81989.

pmo-trunk-r4300

16 years agoWork to fix bug NB#81989:
Jose Dapena Paz [Wed, 12 Mar 2008 11:57:23 +0000 (11:57 +0000)]
Work to fix bug NB#81989:
* src/modest-ui-actions.[ch]:
        * Now send receive operations get an interactive parameter. This
          is used to know if the action was scheduled pressing any UI
          send receive action.
        * If a send queue operation has errors, and last operation done
          on it was an interactive send receive, we show the errors. If
          not, errors do not show feedback.
* src/dbus_api/modest-dbus-callback.c:
        * Set as non interactive send receive operations requested from
          dbus.
* src/maemo/modest-main-window.c:
        * Set as interactive send receive mail operations requested from
          toolbar button.
* src/modest-mail-operation.[ch]:
        * Set "send mail" operations as non interactive to disable
          error feedback.
        * Propagate and set properly the interactive values for send
          receive operations.
* src/modest-tny-send-queue.[ch]:
        * Add an internal attribute to set if last request to send queue
          was an interactive send receive.
* src/modest-tny-account-store.c:
        * Send receive scheduled by a connection status change is a
          non interactive send receive.

pmo-trunk-r4299

16 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 12 Mar 2008 09:33:19 +0000 (09:33 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now we manage to hide properly the IM keyboard (without losing
  focus on find toolbar). Fixes NB#82358.

pmo-trunk-r4298

16 years ago* src/maemo/easysetup/modest-easysetup-wizard-dialog.c:
Jose Dapena Paz [Wed, 12 Mar 2008 08:27:18 +0000 (08:27 +0000)]
* src/maemo/easysetup/modest-easysetup-wizard-dialog.c:
* Update reference to account settings dialog include new path.

pmo-trunk-r4297

16 years ago* src/gnome/modest-account-view-window.c:
Jose Dapena Paz [Wed, 12 Mar 2008 08:15:45 +0000 (08:15 +0000)]
* src/gnome/modest-account-view-window.c:
        * Check wether any connection is active, and cancel them if
          user wants to when we try to set the account.
* src/gnome/modest-msg-edit-window.c:
        * Added support for handling attachments (attachments view and
          attach button).
        * Added management of drafts and outbox messages. Keeps properly
          the current message uid.
        * Better layout of the recipients buttons.
        * Now body editor shows a box around.
        * Added support for dimming rules (fixes menus) and translations
          in menus.
* src/gnome/modest-platform.c:
        * Add stub implementation for double_connect_and_perform.
* src/gnome/Makefile.am:
        * Added gnome implementation for gnome account settings dialog.
* src/gnome/modest-account-settings-dialog.c:
        * Added. New gnome implementation for account settings dialog.
          With this we can begin to edit properly an account.
* src/gnome/modest-msg-edit-window-ui-dimming.h:
        * Dimming rules for gnome editor. Should be very similar to
          maemo counterpart.
* src/gnome/ui/modest-msg-edit-window-ui.xml:
        * Restructure the menu of the editor to get more or less the
          same features the maemo client has.
* Moved src/maemo/modest-account-settings-dialog.h to src/widgets. Also
  added .c in maemo.
* src/modest-tny-account-store.c:
        * Remove specific maemo implementation in account store. All the
          code should be common now.

pmo-trunk-r4296

16 years ago* Remove non-common code to prepare moving the include to common
Jose Dapena Paz [Wed, 12 Mar 2008 08:08:36 +0000 (08:08 +0000)]
* Remove non-common code to prepare moving the include to common
  widgets.

pmo-trunk-r4295

16 years agoWork to fix bug NB#81294
Jose Dapena Paz [Tue, 11 Mar 2008 13:23:25 +0000 (13:23 +0000)]
Work to fix bug NB#81294
* src/maemo/modest-account-view-window.c:
        * Now we also disconnect the account if account is not connected
         but also it's not in disconnected status (handles broken
         states).
* src/modest-tny-account.c:
        * Sets the password setting dialogs again to force getting
          feedback if connection attempt fails.

pmo-trunk-r4294

16 years ago* src/modest-mail-operation.c:
Jose Dapena Paz [Mon, 10 Mar 2008 12:20:11 +0000 (12:20 +0000)]
* src/modest-mail-operation.c:
* If we haven't got cached messages, then we are in an open
  operation instead of a receive operation on moving messages
  (fixes NB#81891).

pmo-trunk-r4293

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 10 Mar 2008 12:03:25 +0000 (12:03 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we have ways to get "next cid" instead of last cid
          available for attachments and images. Before, we were using
          this confusingly, and we caused some bugs because of reusing
          the first content id for a new image (fixes NB#82197).

pmo-trunk-r4292

16 years ago * Fixes NB#80782, INBOX folder is now localized
Sergio Villar Senin [Mon, 10 Mar 2008 10:19:21 +0000 (10:19 +0000)]
* Fixes NB#80782, INBOX folder is now localized

pmo-trunk-r4291

16 years agoAdded week 11 bug fixes and info to NEWS file.
Vivek Sekar [Fri, 7 Mar 2008 12:28:21 +0000 (12:28 +0000)]
Added week 11 bug fixes and info to NEWS file.

pmo-trunk-r4287

16 years agoNew version of the remove WIMAX patch
Sergio Villar Senin [Fri, 7 Mar 2008 10:30:00 +0000 (10:30 +0000)]
New version of the remove WIMAX patch

pmo-trunk-r4286

16 years ago * Most likely fixes the crash when s&r in the background
Sergio Villar Senin [Fri, 7 Mar 2008 08:57:54 +0000 (08:57 +0000)]
* Most likely fixes the crash when s&r in the background
* Fixes a bug in the send queue error handler (freeing a const char *)

pmo-trunk-r4285

16 years ago* src/maemo/modest-msg-view-window.c
Alberto Garcia [Thu, 6 Mar 2008 18:57:35 +0000 (18:57 +0000)]
* src/maemo/modest-msg-view-window.c
(message_reader_performer):
Call modest_window_mgr_register_header() before retrieving a new message
(view_msg_cb):
Call modest_window_mgr_unregister_header() after retrieving the message
Fixes NB#81606

pmo-trunk-r4284

16 years ago* src/modest-formatter.c
Alberto Garcia [Thu, 6 Mar 2008 11:45:41 +0000 (11:45 +0000)]
* src/modest-formatter.c
(construct_from_text)
Fix a memory leak building the TnyStream

* src/modest-tny-msg.c
(add_body_part)
(add_html_body_part):
Fix a memory leak building the TnyStream

pmo-trunk-r4283

16 years agoAdded comment explaining r4281
Alberto Garcia [Thu, 6 Mar 2008 10:36:58 +0000 (10:36 +0000)]
Added comment explaining r4281

pmo-trunk-r4282

16 years ago* src/maemo/modest-connection-specific-smtp-edit-window.c
Alberto Garcia [Thu, 6 Mar 2008 10:30:53 +0000 (10:30 +0000)]
* src/maemo/modest-connection-specific-smtp-edit-window.c
(modest_connection_specific_smtp_edit_window_init):
Make the dialog wider so the title fits entirely
Fixes NB#80947

pmo-trunk-r4281

16 years ago * Fixes NB#81911, show an error dialog when the rename action fails
Sergio Villar Senin [Thu, 6 Mar 2008 09:29:13 +0000 (09:29 +0000)]
* Fixes NB#81911, show an error dialog when the rename action fails
* Select the first inbox if the rename fails, in order not to lose the focus

pmo-trunk-r4279

16 years ago* src/maemo/modest-msg-view-window.c:
Jose Dapena Paz [Wed, 5 Mar 2008 12:34:56 +0000 (12:34 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now we properly update the model signal handler pointers
  so that we can disconnect them on finalize (fixes NB#81522).

pmo-trunk-r4278

16 years ago * Fixed NB#80996, resized the rename folder dialog to allow pt_BR strings to fit...
Sergio Villar Senin [Tue, 4 Mar 2008 19:08:06 +0000 (19:08 +0000)]
* Fixed NB#80996, resized the rename folder dialog to allow pt_BR strings to fit in the window
* The entry is now properly resized and fills the dialog if the original folder name is too short

pmo-trunk-r4277

16 years ago* src/widgets/modest-mail-header-view.c
Alberto Garcia [Tue, 4 Mar 2008 18:46:13 +0000 (18:46 +0000)]
* src/widgets/modest-mail-header-view.c
(modest_mail_header_view_set_header_default):
Use "Date:" instead of "Received:" for the date
Fixes NB#81762

pmo-trunk-r4276

16 years ago I forgot to move this code inside the if
Sergio Villar Senin [Tue, 4 Mar 2008 18:27:54 +0000 (18:27 +0000)]
 I forgot to move this code inside the if

pmo-trunk-r4275

16 years ago * Fixes NB#81719, modest is no longer crashing when the send queue notifies errors...
Sergio Villar Senin [Tue, 4 Mar 2008 17:53:49 +0000 (17:53 +0000)]
* Fixes NB#81719, modest is no longer crashing when the send queue notifies errors not related to headers

pmo-trunk-r4274

16 years ago* src/maemo/modest-msg-view-window.c
Alberto Garcia [Tue, 4 Mar 2008 17:38:44 +0000 (17:38 +0000)]
* src/maemo/modest-msg-view-window.c
(modest_msg_view_window_save_attachments):
Escape file names when saving multiple files
Fixes NB#81715

pmo-trunk-r4273

16 years ago * Fixes NB#81719, modest_tny_account_get_server_account could return NULL, so now...
Sergio Villar Senin [Tue, 4 Mar 2008 17:27:05 +0000 (17:27 +0000)]
* Fixes NB#81719, modest_tny_account_get_server_account could return NULL, so now we check that
* This fix does not fix the root cause of the bug because it was previously fixed by some other commits (the bug could not be reproduced with the current HEAD)

pmo-trunk-r4272

16 years ago * Fixes NB#80734, viewer opened with dimmed toolbar
Sergio Villar Senin [Tue, 4 Mar 2008 12:46:28 +0000 (12:46 +0000)]
* Fixes NB#80734, viewer opened with dimmed toolbar
* Now row references to the model are gotten *before* calling tinymail because the model could dissapear. This could cause weird behaviours, because the user could switch between folders while the message is being opened

pmo-trunk-r4271

16 years agoAdded comment explaining r4269
Alberto Garcia [Tue, 4 Mar 2008 09:54:01 +0000 (09:54 +0000)]
Added comment explaining r4269

pmo-trunk-r4270

16 years ago* src/modest-ui-actions.c
Alberto Garcia [Tue, 4 Mar 2008 09:51:28 +0000 (09:51 +0000)]
* src/modest-ui-actions.c
(modest_ui_actions_on_password_requested):
Don't make the "Login cancelled" banner disappear with
its parent dialog.
Fixes NB#81698

pmo-trunk-r4269

16 years ago * Fixes NB#81525, added proper error messages when device memory is full in some...
Sergio Villar Senin [Mon, 3 Mar 2008 18:53:02 +0000 (18:53 +0000)]
* Fixes NB#81525, added proper error messages when device memory is full in some conditions

pmo-trunk-r4268

16 years ago * Fixes NB#81652, only add the Wimax support to the devices that actually have it
Sergio Villar Senin [Mon, 3 Mar 2008 16:18:10 +0000 (16:18 +0000)]
* Fixes NB#81652, only add the Wimax support to the devices that actually have it

pmo-trunk-r4265

16 years agoBugfix for 81611
Philip Van Hoof [Mon, 3 Mar 2008 10:49:03 +0000 (10:49 +0000)]
Bugfix for 81611

pmo-trunk-r4264

16 years agoBugfix for 81611
Philip Van Hoof [Mon, 3 Mar 2008 10:44:52 +0000 (10:44 +0000)]
Bugfix for 81611

pmo-trunk-r4263

16 years ago* src/modest-tny-account-store.c:
Jose Dapena Paz [Mon, 3 Mar 2008 09:05:17 +0000 (09:05 +0000)]
* src/modest-tny-account-store.c:
* Now we show the username/password error information banner
  without parent, to show it on top of the password dialog
  (fixes NB#80991).

pmo-trunk-r4262

16 years ago* update the localization string ('subject not modified')
Dirk-Jan C. Binnema [Mon, 3 Mar 2008 08:24:09 +0000 (08:24 +0000)]
* update the localization string ('subject not modified')
* update english po file
=> fixes NB#81595

pmo-trunk-r4261

16 years ago* src/maemo/modest-signature-editor-dialog.c:
Jose Dapena Paz [Mon, 3 Mar 2008 07:39:26 +0000 (07:39 +0000)]
* src/maemo/modest-signature-editor-dialog.c:
* Set a fixed width for signature dialog (fixes NB#80914).

pmo-trunk-r4260

16 years ago * Deleted unused code
Sergio Villar Senin [Fri, 29 Feb 2008 17:08:59 +0000 (17:08 +0000)]
* Deleted unused code
* Added some documentation
* Added optimizations when refreshing accounts, do not recurse folders if we don't want to poke status
* Issue send&receive only after a succesful connect
* Added a poke_status parametter to do_send_receive
* Do not update the "Last updated" when refreshing folders, only when send&receive
* Fixes  NB#80728, username no longer gets dimmed when an invalid username is given

pmo-trunk-r4259

16 years ago* src/widgets/modest-dnd.c
Alberto Garcia [Fri, 29 Feb 2008 15:50:14 +0000 (15:50 +0000)]
* src/widgets/modest-dnd.c
(modest_dnd_selection_data_set_paths):
Don't crash if selected_rows is an empty list
Fixes NB#81573

pmo-trunk-r4258

16 years ago* src/modest-account-mgr-helpers.c:
Jose Dapena Paz [Fri, 29 Feb 2008 14:05:58 +0000 (14:05 +0000)]
* src/modest-account-mgr-helpers.c:
        * When we set new server configuration, we forget that we
          had succeeded to connect with a username (fixes NB#80728).
* src/modest-mail-operation.c:
        * When we succeed to refresh or retrieve an account, then we
          set that the username has succeeded

pmo-trunk-r4257

16 years agoAdded bug fixes for week 10.
Vivek Sekar [Fri, 29 Feb 2008 12:53:13 +0000 (12:53 +0000)]
Added bug fixes for week 10.

pmo-trunk-r4255

16 years ago* Deleted the *svg from Makefile
Sergio Villar Senin [Fri, 29 Feb 2008 09:50:29 +0000 (09:50 +0000)]
* Deleted the *svg from Makefile

pmo-trunk-r4254

16 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Thu, 28 Feb 2008 20:54:33 +0000 (20:54 +0000)]
* src/modest-ui-dimming-rules.c:
        * Now we use the custom modest method to know if a mime
          part is an attached message (as it was failing for "file as
          message" attachments).
* src/widgets/modest-attachment-view.c:
        * Now we show the filename of the attachment even if it's
          a TnyMsg. This makes "file as message" attachments show
          the proper name (fixes NB#81527).

pmo-trunk-r4253

16 years ago* src/modest-tny-account.[ch]:
Jose Dapena Paz [Thu, 28 Feb 2008 20:19:20 +0000 (20:19 +0000)]
* src/modest-tny-account.[ch]:
        * Now update from account also gets the password funcs
          to get proper notifications of problems (we need to
          do a set_pass_func to reactivate an account with a new setup).
        * Show an alert when connection attempt after an account update
          fails (strangely it's not working always).
        * Set pass func after an account settings update to force it to
          be reactivated (and this way refresh connection properly).
* src/modest-tny-account-store.c:
        * Use the new tny account api.

pmo-trunk-r4252

16 years ago* update NEWS for W10
Dirk-Jan C. Binnema [Thu, 28 Feb 2008 18:33:28 +0000 (18:33 +0000)]
* update NEWS for W10

pmo-trunk-r4251

16 years ago* src/modest-ui-actions.c
Alberto Garcia [Thu, 28 Feb 2008 16:28:22 +0000 (16:28 +0000)]
* src/modest-ui-actions.c
(open_msgs_from_headers):
Use a banner instead of a dialog to show mcen_ib_select_one_message
Fixes NB#81538

pmo-trunk-r4250

16 years ago * Removed invalid initializations, that were breaking the account setup
Sergio Villar Senin [Thu, 28 Feb 2008 16:14:00 +0000 (16:14 +0000)]
* Removed invalid initializations, that were breaking the account setup

pmo-trunk-r4249

16 years ago* src/modest-tny-mime-part.c
Alberto Garcia [Thu, 28 Feb 2008 14:57:09 +0000 (14:57 +0000)]
* src/modest-tny-mime-part.c
(modest_tny_mime_part_is_attachment_for_modest):
Consider alternate formats for the "name" parameter in the
Content-Disposition header, so files with inline disposition and
encoded as detailed in RFC2231 appear as attachments in Modest
Partially fixes NB#81300

pmo-trunk-r4247

16 years ago * Fixes NB#81497, crash in the easysetup combo box
Sergio Villar Senin [Thu, 28 Feb 2008 12:38:25 +0000 (12:38 +0000)]
* Fixes NB#81497, crash in the easysetup combo box

pmo-trunk-r4246

16 years ago* src/modest-tny-account-store.c
Alberto Garcia [Thu, 28 Feb 2008 12:33:53 +0000 (12:33 +0000)]
* src/modest-tny-account-store.c
(modest_tny_account_store_alert): Don't show the "Secure connection
failed" in any authentication error. Use specific errors for POP, IMAP
and SMTP instead.
Fixes NB#81204

pmo-trunk-r4245

16 years ago * Renamed modest-easysetup-wizard by modest-easysetup-wizard-dialog because it was...
Sergio Villar Senin [Thu, 28 Feb 2008 12:01:07 +0000 (12:01 +0000)]
* Renamed modest-easysetup-wizard by modest-easysetup-wizard-dialog because it was actually the object's name
* Moved easysetup wizard dialog public attributes to the private structure

pmo-trunk-r4244

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Thu, 28 Feb 2008 11:18:05 +0000 (11:18 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we add the initial clipboard owner change handler in
          an idle, so that we don't get an opportunity to destroy the
          window when it's not completely created before (fixes
          NB#81380).

pmo-trunk-r4243

16 years agoTemporarily adding the wimax removal patch, to help the integration process.
Vivek Sekar [Thu, 28 Feb 2008 10:34:17 +0000 (10:34 +0000)]
Temporarily adding the wimax removal patch, to help the integration process.

pmo-trunk-r4241

16 years agoRemoved an old comment
Sergio Villar Senin [Thu, 28 Feb 2008 09:58:28 +0000 (09:58 +0000)]
Removed an old comment

pmo-trunk-r4240

16 years ago* src/widgets/modest-account-view.c:
Alberto Garcia [Wed, 27 Feb 2008 20:49:32 +0000 (20:49 +0000)]
* src/widgets/modest-account-view.c:
(get_last_updated_string): Remove obsolete comment

* src/modest-mail-operation.c
(modest_mail_operation_refresh_folder):
(on_refresh_folder):
If the folder is remote, mark its account as busy during the refresh
and set the "Last updated" time afterwards

Fixes NB#81471

pmo-trunk-r4239

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Wed, 27 Feb 2008 18:53:59 +0000 (18:53 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Refresh toolbar attributes after changing the format so that
          it's updated (fixes NB#81406).

pmo-trunk-r4238

16 years ago * Fixes NB#81473, start header retrieval even though it's not the first one
Sergio Villar Senin [Wed, 27 Feb 2008 18:51:34 +0000 (18:51 +0000)]
* Fixes NB#81473, start header retrieval even though it's not the first one

pmo-trunk-r4237

16 years ago* src/modest-mail-operation-queue.c:
Alberto Garcia [Wed, 27 Feb 2008 18:08:48 +0000 (18:08 +0000)]
* src/modest-mail-operation-queue.c:
(modest_mail_operation_queue_remove): Revert changes from 4235,
they're not necessary actually.

pmo-trunk-r4236

16 years ago* src/modest-mail-operation.c:
Alberto Garcia [Wed, 27 Feb 2008 17:44:51 +0000 (17:44 +0000)]
* src/modest-mail-operation.c:
(get_msg_async_cb): If the operation has been canceled by the user,
ignore then error that comes from Tinymail and don't touch the error
code of the mail operation.

* src/modest-mail-operation-queue.c:
(modest_mail_operation_queue_remove): Don't call the error handler if
the operation has been canceled by the user.

Fixes NB#81459

pmo-trunk-r4235

16 years ago * Fixes NB#81429, Delete HW button was not behaving correctly when header view was...
Sergio Villar Senin [Wed, 27 Feb 2008 13:02:52 +0000 (13:02 +0000)]
* Fixes NB#81429, Delete HW button was not behaving correctly when header view was focused

pmo-trunk-r4234

16 years ago * Fixes NB#81413, Esc key closes the "Save changes" dialog and the editor window...
Sergio Villar Senin [Wed, 27 Feb 2008 12:43:56 +0000 (12:43 +0000)]
* Fixes NB#81413, Esc key closes the "Save changes" dialog and the editor window instead of saving the message

pmo-trunk-r4233

16 years ago* src/maemo/modest-main-window.c:
Jose Dapena Paz [Wed, 27 Feb 2008 09:47:08 +0000 (09:47 +0000)]
* src/maemo/modest-main-window.c:
        * Now, when the window is destroyed, we destroy the
          pending information banners (redundantly) and information
          banner handlers (to avoid showing them when the window is
          already closed) (fixes NB#81215).

pmo-trunk-r4232

16 years ago * Partially fixes NB#81238, fixes some problems reported by coverity
Sergio Villar Senin [Tue, 26 Feb 2008 18:23:18 +0000 (18:23 +0000)]
* Partially fixes NB#81238, fixes some problems reported by coverity

pmo-trunk-r4231

16 years ago * Fixes NB#81095, UI is now properly updated when deleting an account while retrievi...
Sergio Villar Senin [Tue, 26 Feb 2008 17:37:43 +0000 (17:37 +0000)]
* Fixes NB#81095, UI is now properly updated when deleting an account while retrieving a message

pmo-trunk-r4230

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 26 Feb 2008 17:24:09 +0000 (17:24 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * If the body buffer is marked as modified we evaluate the
          dimming rules, to know if we should dim save to drafts or
          not (fixes NB#81353).

pmo-trunk-r4229

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Tue, 26 Feb 2008 15:23:21 +0000 (15:23 +0000)]
* src/maemo/modest-msg-edit-window.c:
        * Now we get the decoded stream from messages, to show the
          expected attached images in editor (fixes NB#79624).

pmo-trunk-r4228

16 years ago* src/modest-text-utils.[ch]:
Jose Dapena Paz [Tue, 26 Feb 2008 13:10:56 +0000 (13:10 +0000)]
* src/modest-text-utils.[ch]:
        * Added a new method to escape mnemonics
* src/maemo/modest-main-window.c:
        * Now we escape mnemonics on account names in menus and toolbar
          (fixes NB#81327).

pmo-trunk-r4227

16 years ago* src/maemo/modest-account-settings-dialog.[ch]:
Jose Dapena Paz [Tue, 26 Feb 2008 12:30:20 +0000 (12:30 +0000)]
* src/maemo/modest-account-settings-dialog.[ch]:
        * Added methods to set the modified state, and to avoid showing
          the "settings saved" ib if we showed the dialog because of an
          auth error.
* src/modest-tny-account-store.c:
        * If an auth error has been produced and we want to show the
          account settings dialog, then we force the dialog to save its
          results always (fixes partially NB#81055).

pmo-trunk-r4226

16 years ago* src/maemo/modest-msg-edit-window.c:
Jose Dapena Paz [Mon, 25 Feb 2008 12:10:29 +0000 (12:10 +0000)]
* src/maemo/modest-msg-edit-window.c:
* Update properly the alignment radio menu items from current
  alignment status (fixes NB#81024).

pmo-trunk-r4225

16 years agoremoved the internet-mail.svg file.
Vivek Sekar [Mon, 25 Feb 2008 10:54:18 +0000 (10:54 +0000)]
removed the internet-mail.svg file.

pmo-trunk-r4224

16 years agoAdded the week 09 bug fixes to debian/changelog
Vivek Sekar [Mon, 25 Feb 2008 09:51:53 +0000 (09:51 +0000)]
Added the week 09 bug fixes to debian/changelog

pmo-trunk-r4222

16 years ago* src/modest-tny-account-store.[ch]:
Jose Dapena Paz [Fri, 22 Feb 2008 14:53:39 +0000 (14:53 +0000)]
* src/modest-tny-account-store.[ch]:
        * (modest_tny_account_store_show_account_settings_dialog):
          new method for single access to create the account settings
          dialog. This should make all attempts to show settings dialog
          when it's already shown go through this (fixes NB#80817).
* src/maemo/modest-account-view-window.c:
        * Use the new show account settings method.

pmo-trunk-r4221

16 years ago* src/widgets/modest-folder-view.c:
Jose Dapena Paz [Thu, 21 Feb 2008 19:06:29 +0000 (19:06 +0000)]
* src/widgets/modest-folder-view.c:
        * Now we highlight on all valid destinations of dnd, not only on
          valid ones that will be expanded (fixes NB#81198).

pmo-trunk-r4220

16 years ago * Fixes NB#81189, able to drop a folder in the root MMC account
Sergio Villar Senin [Thu, 21 Feb 2008 16:48:10 +0000 (16:48 +0000)]
* Fixes NB#81189, able to drop a folder in the root MMC account

pmo-trunk-r4219

16 years ago * Fixed a lot of reference leaks
Sergio Villar Senin [Thu, 21 Feb 2008 10:55:06 +0000 (10:55 +0000)]
* Fixed a lot of reference leaks
* Updated some documentation

pmo-trunk-r4218

16 years agoChanges to fix NB#80521.
Jose Dapena Paz [Thu, 21 Feb 2008 09:31:22 +0000 (09:31 +0000)]
Changes to fix NB#80521.
* src/modest-tny-mime-part.c:
        * Now we recognise a purged attachment as an attachment for
          modest.
* src/maemo/modest-msg-view-window.c:
        * As we now detect purged attachments as attachments, we filter
          here to disallow saving purged attachments.
* src/modest-ui-dimming-rules.c:
        * Remove invalid_account_for_purge as it was wrong, and it's now
          superseeded by _invalid_folder_for_purge.

pmo-trunk-r4217

16 years ago* po/en_GB.po:
Jose Dapena Paz [Thu, 21 Feb 2008 09:25:57 +0000 (09:25 +0000)]
* po/en_GB.po:
* Fix the translation issue of
  mcen_nc_unable_to_delete_n_messages, as now it expects a %d
  instead of a %s.

pmo-trunk-r4216

16 years ago* src/widgets/modest-details-dialog.c:
Jose Dapena Paz [Wed, 20 Feb 2008 17:00:39 +0000 (17:00 +0000)]
* src/widgets/modest-details-dialog.c:
* Now up/down keys scroll the details (fixes NB#79330).

pmo-trunk-r4215

16 years ago* src/widgets/modest-header-view-render.c:
Jose Dapena Paz [Wed, 20 Feb 2008 15:49:04 +0000 (15:49 +0000)]
* src/widgets/modest-header-view-render.c:
* Fix rendering of already opened messages.

pmo-trunk-r4214

16 years agoFix obsolete string mail_ib_unable_to_purge_editable_msg
Alberto Garcia [Wed, 20 Feb 2008 15:03:21 +0000 (15:03 +0000)]
Fix obsolete string mail_ib_unable_to_purge_editable_msg

pmo-trunk-r4213

16 years ago * src/modest-ui-dimming-rules.c
Alberto Garcia [Wed, 20 Feb 2008 14:49:27 +0000 (14:49 +0000)]
* src/modest-ui-dimming-rules.c
(_invalid_folder_for_purge):
Don't allow removal of attachments from messages in remote
folders.
Fixes NB#75422

pmo-trunk-r4212

16 years ago * Fixes NB#80917, added wimax support
Sergio Villar Senin [Wed, 20 Feb 2008 12:51:42 +0000 (12:51 +0000)]
* Fixes NB#80917, added wimax support
* Most of work had been already commited in revision 4203

pmo-trunk-r4211

16 years ago * src/modest-ui-actions.c:
Alberto Garcia [Wed, 20 Feb 2008 12:49:04 +0000 (12:49 +0000)]
* src/modest-ui-actions.c:
(modest_ui_actions_on_save_to_drafts):
Change string shown on banner according to UI Specs v3.0
Fixes NB#80964

pmo-trunk-r4210

16 years ago * Fixes NB#81063, now it's not possible to select purged attachments using select all
Sergio Villar Senin [Wed, 20 Feb 2008 12:25:47 +0000 (12:25 +0000)]
* Fixes NB#81063, now it's not possible to select purged attachments using select all
* It's no longer possible to select them using the HW keys as well

pmo-trunk-r4209

16 years ago* src/modest-ui-dimming-rules.c:
Jose Dapena Paz [Wed, 20 Feb 2008 11:58:33 +0000 (11:58 +0000)]
* src/modest-ui-dimming-rules.c:
* Now we can send messages without body (fixes NB#80962).

pmo-trunk-r4208

16 years ago* src/maemo/modest-maemo-global-settings-dialog.c:
Jose Dapena Paz [Wed, 20 Feb 2008 11:27:50 +0000 (11:27 +0000)]
* src/maemo/modest-maemo-global-settings-dialog.c:
* Changed the default width of the dialog to 700 to fit the
  translation strings for most languages (fixes NB#80866).

pmo-trunk-r4207

16 years ago* src/widgets/modest-header-view.c:
Jose Dapena Paz [Wed, 20 Feb 2008 11:07:32 +0000 (11:07 +0000)]
* src/widgets/modest-header-view.c:
        * Set the fixed height from font in text cell renderers.
* src/widgets/modest-header-view-render.c:
        * Avoid using pango markup as pango parsing is expensive.
          Instead of this use cell renderer properties to set the
          default fonts.
        * We set the properties now using freeze and thaw, for avoiding
          preparing the font as many times as properties we have.
* src/modest-ui-actions.c:
        * Show proper information banner on opening a drafts message.
* src/maemo/modest-msg-edit-window.c:
        * Delay show all just until all the window is ready to be shown.
          This should reduce expensive redraws and relocations.
* src/maemo/modest-msg-view-window.c:
        * Also delay show all until all the window is ready to be shown.

pmo-trunk-r4206

16 years ago * Fixes NB#80896, fixes an endless reconnection against Welho.com
Sergio Villar Senin [Wed, 20 Feb 2008 10:39:30 +0000 (10:39 +0000)]
* Fixes NB#80896, fixes an endless reconnection against Welho.com

pmo-trunk-r4205

16 years ago * Fixes NB#81047, the colon after "folders" is now getting the proper "dimmed" color
Sergio Villar Senin [Wed, 20 Feb 2008 09:52:54 +0000 (09:52 +0000)]
* Fixes NB#81047, the colon after "folders" is now getting the proper "dimmed" color

pmo-trunk-r4204

16 years ago * Partially fixes NB#80917, we still need the strings from the translation team
Sergio Villar Senin [Tue, 19 Feb 2008 19:06:55 +0000 (19:06 +0000)]
* Partially fixes NB#80917, we still need the strings from the translation team

pmo-trunk-r4203

16 years ago * src/maemo/modest-signature-editor-dialog.c
Alberto Garcia [Tue, 19 Feb 2008 17:52:03 +0000 (17:52 +0000)]
* src/maemo/modest-signature-editor-dialog.c
(modest_signature_editor_dialog_set_settings):
Don't let the "Signature for account" label be truncated
Partially fixes NB#80914

pmo-trunk-r4202

16 years ago * Fixes NB#80994, adds a "retrieving" info banner when opening a message takes more...
Sergio Villar Senin [Tue, 19 Feb 2008 17:09:16 +0000 (17:09 +0000)]
* Fixes NB#80994, adds a "retrieving" info banner when opening a message takes more than 2 seconds

pmo-trunk-r4201

16 years ago * src/maemo/modest-platform.c:
Alberto Garcia [Tue, 19 Feb 2008 17:08:00 +0000 (17:08 +0000)]
* src/maemo/modest-platform.c:
(modest_platform_run_folder_name_dialog):
Make the width of the text entry proportional to the size of
the default text, so it works OK in all languages.
Fixes NB#81007

pmo-trunk-r4200

16 years ago * Fixes NB#81009, show the proper title when saving multiple attachments
Sergio Villar Senin [Tue, 19 Feb 2008 16:30:13 +0000 (16:30 +0000)]
* Fixes NB#81009, show the proper title when saving multiple attachments

pmo-trunk-r4199