Johannes Schmid [Thu, 14 Jun 2007 17:22:18 +0000 (17:22 +0000)]
2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(on_change), (on_combo_security_changed),
(modest_connection_specific_smtp_edit_window_init),
(modest_connection_specific_smtp_edit_window_set_connection),
(modest_connection_specific_smtp_edit_window_is_dirty):
* src/maemo/modest-connection-specific-smtp-edit-window.h:
* src/maemo/modest-connection-specific-smtp-window.c:
(on_button_edit):
Show an comfirmation dialog for the smpt-edit-window if there are
unsaved changes and the user hits cancel.
(projects.maemo.org but NB#60479
pmo-trunk-r2242
Jose Dapena Paz [Thu, 14 Jun 2007 16:44:47 +0000 (16:44 +0000)]
* src/modest-text-utils.[ch]:
* Reworked the quote code to add attachmetns list.
This should make attachments be shown on replying
messages (fixes NB#58194).
* Reworked the quote methods, to be more compliant
to specs.
* src/modest-tny-msg.c, src/modest-formatter.[ch]:
* Proper changes to pass the attachments list to the
code that creates the quoted messages. It's used
for showing the attachments names in replies including
the original message.
pmo-trunk-r2241
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 16:07:35 +0000 (16:07 +0000)]
* add the time to the details; fixes NB#58620
pmo-trunk-r2240
Armin Burgmeier [Thu, 14 Jun 2007 15:42:19 +0000 (15:42 +0000)]
2007-06-14 Armin Burgmeier <armin@openismus.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c: Show "invalid email
address" info in banner instead of node, and select all the text as
per UI spec. This fixes projects.maemo.org bug NB#60550.
pmo-trunk-r2239
Jose Dapena Paz [Thu, 14 Jun 2007 15:14:07 +0000 (15:14 +0000)]
* src/modest-text-utils.c:
* (modest_text_utils_cite): cite shouldn't include
replied message body, only signature (fixes NB#58185).
pmo-trunk-r2238
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 15:10:28 +0000 (15:10 +0000)]
* fix a refcounting issue if account_id is NULL when trying to get the local_folder_type
* changed the folder rules; drafts cannot receive from drag&drop
pmo-trunk-r2237
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 15:08:35 +0000 (15:08 +0000)]
* set FolderName(<all>) for Outbox, Drafts,FolderName (<unread>) for the others
* get the type thing correctly
* depends on a tinymail fix too
pmo-trunk-r2236
Sergio Villar Senin [Thu, 14 Jun 2007 14:52:59 +0000 (14:52 +0000)]
* Added modest_platform_create_folder_view
* Fixes NB#59468, the move to folder shows the folder view even if there is no main window
pmo-trunk-r2235
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 14:49:44 +0000 (14:49 +0000)]
* Updated the changelog with the fixes made on 14 june 2007.
pmo-trunk-r2234
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 13:34:32 +0000 (13:34 +0000)]
* modest_text_utils_get_display_date:
- use the localized (%X) display date
* _modest_header_view_compact_header_cell_data
- don't try to display the date when it's zero
pmo-trunk-r2233
Murray Cumming [Thu, 14 Jun 2007 12:52:45 +0000 (12:52 +0000)]
Added useful debug output to help us figure out the no-messages bug.
pmo-trunk-r2232
Sergio Villar Senin [Thu, 14 Jun 2007 12:42:44 +0000 (12:42 +0000)]
* Fixed a memory leak with mail operations that issued progress information
* Fixed a memory leak in the progress object
* Fixes NB#59461, now it's possible to navigate between messages in the viewer without any main window
pmo-trunk-r2231
Murray Cumming [Thu, 14 Jun 2007 12:41:28 +0000 (12:41 +0000)]
2007-06-14 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-folder-view.c: (filter_row):
Explictly filter out the per-account outbox accounts. I don't know why
these only sometimes show up, but now they should never show up in the UI.
This should fix projects.maemo.org bug NB#60160.
pmo-trunk-r2230
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 11:42:33 +0000 (11:42 +0000)]
* Added libhildonnotify-dev and libnotify-dev the control-maemo1 file.
pmo-trunk-r2228
Murray Cumming [Thu, 14 Jun 2007 10:40:20 +0000 (10:40 +0000)]
do this properly.
pmo-trunk-r2227
Murray Cumming [Thu, 14 Jun 2007 10:38:15 +0000 (10:38 +0000)]
2007-06-14 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
when the toolbar does not exist yet.
* src/modest-widget-memory.c: (save_settings_header_view):
Added g_warnings() to help us to discover when we are trying to set
an empty columns list in gconf.
pmo-trunk-r2226
Jose Dapena Paz [Thu, 14 Jun 2007 10:36:29 +0000 (10:36 +0000)]
* src/modest-text-utils.c:
* Now _quote functions add signature to the end if
available (fixes NB#58181).
pmo-trunk-r2225
Murray Cumming [Thu, 14 Jun 2007 10:22:39 +0000 (10:22 +0000)]
2007-06-14 Murray Cumming <murrayc@murrayc.com>
* src/modest-init.h:
* src/modest-init.c:
Added modest_init_get_default_header_view_column_ids().
* src/modest-widget-memory.c: (restore_settings_header_view):
Use the new function to get defaults, if the gconf key is empty,
instead of not creating any columns. This seems to fix the
empty right-hand pane problems.
* src/widgets/modest-header-view.h: Improved documentation.
pmo-trunk-r2224
Jose Dapena Paz [Thu, 14 Jun 2007 10:13:38 +0000 (10:13 +0000)]
Work for making select all work as expected in
message view (body). Fixes NB#58104.
* src/widgets/modest-msg-view.[ch]:
* New method ..._grab_focus, that grabs the
focus on the body.
* src/modest-msg-view-window.c:
* Use new method modest_msg_view_grab_focus to
put the default focus instead of just using
gtk_widget_grab_focus. This should fix the
default focus when the window is created (that
should be in the message body).
* src/modest-ui-actions.c:
* Add an implementation of select all for
gtkhtml widgets.
pmo-trunk-r2223
Jose Dapena Paz [Thu, 14 Jun 2007 09:50:42 +0000 (09:50 +0000)]
* src/modest-formatter.[ch]:
* New API to create modest new messages. Method
modest_formatter_create_message creates a message
with the expected multiparts.
modest_formatter_create_body_part obtains a new
body part to add body contents.
* The new API is used now in modest_formatter_do
and modest_formatter_attach.
* src/modest-tny-msg.c:
* (modest_tny_msg_new, modest_tny_msg_new_html_plain,
add_body_part, add_html_body_part, add_attachments,
create_reply_forward_mail) Uses the new ModestFormatter
API to create specific modest formatted messages. This
should make creation of messages with attachments and
alternatives work far better.
* (modest_tny_msg_create_forward_msg): silly bug creating
the attachments list removed.
* src/modest-mail-operation.c:
* Removes a warning on sending new mails without priority
set.
pmo-trunk-r2222
Dirk-Jan C. Binnema [Thu, 14 Jun 2007 09:32:36 +0000 (09:32 +0000)]
* always check accounts are set up before opening the editor; if none are
specified, open the account wizard
* make sure the editor cannot be opened with a NULL account
* Fixes: NB#55368
pmo-trunk-r2221
Sergio Villar Senin [Thu, 14 Jun 2007 09:01:03 +0000 (09:01 +0000)]
* Do not select the INBOX until the widget is not already mapped, because it could cause some issues
pmo-trunk-r2220
Sergio Villar Senin [Thu, 14 Jun 2007 06:52:13 +0000 (06:52 +0000)]
* Removed the code that checks the message count before refreshing, the message count at that point is not correct. It is located in the callback of the refresh function
* The first INBOX folder is now selected again when starting the application
pmo-trunk-r2219
Dirk-Jan C. Binnema [Wed, 13 Jun 2007 16:58:18 +0000 (16:58 +0000)]
* set the default paned pos for the main window to something sane
pmo-trunk-r2218
Murray Cumming [Wed, 13 Jun 2007 16:54:11 +0000 (16:54 +0000)]
2007-06-13 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
Revert the use of the display name as the account name, because this
is generally wrong and would break the code that follows.
pmo-trunk-r2217
Dirk-Jan C. Binnema [Wed, 13 Jun 2007 16:25:14 +0000 (16:25 +0000)]
* compile fix
pmo-trunk-r2216
Dirk-Jan C. Binnema [Wed, 13 Jun 2007 16:18:22 +0000 (16:18 +0000)]
* some fixes towards fixing the right-hand-pane-empty problem
- save/restore header before/after changing folder
- special casing for guessing the local-folder-type; this makes outbox/sent now show the correct headers (ie. To:, Sent: instead of From:,Received:)
- fix some weirdness in modest-widget-memory (reading -1 into a guint...)
pmo-trunk-r2215
Johannes Schmid [Wed, 13 Jun 2007 16:14:17 +0000 (16:14 +0000)]
2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/easysetup/modest-easysetup-wizard.c:
(check_for_supported_auth_methods), (on_before_next),
(create_account):
More correct fix for projects.maemo.org bug NB# 58991
Do not longer accept AUTH_PASSWORD as secure method and choose
correct method when creating the account.
pmo-trunk-r2214
Dirk-Jan C. Binnema [Wed, 13 Jun 2007 15:38:54 +0000 (15:38 +0000)]
* Updated the changelog with the fixes done on 2007.06.13 18:00
pmo-trunk-r2212
Johannes Schmid [Wed, 13 Jun 2007 15:01:04 +0000 (15:01 +0000)]
2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
Fixed projects.maemo.org bug NB# 58991
pmo-trunk-r2211
Murray Cumming [Wed, 13 Jun 2007 14:51:09 +0000 (14:51 +0000)]
2007-06-13 Murray Cumming <murrayc@murrayc.com>
* src/modest-init.c: (modest_init_init_core),
(modest_init_local_folders): Fixed compilation errors.
pmo-trunk-r2210
Philip Van Hoof [Wed, 13 Jun 2007 14:49:12 +0000 (14:49 +0000)]
A few small fixes for the modest-search feature
pmo-trunk-r2209
Murray Cumming [Wed, 13 Jun 2007 13:46:12 +0000 (13:46 +0000)]
2007-06-13 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
Remove unnecessary lib/include, though it is good in principle when needed.
* src/modest-init.c: (modest_init_one_local_folder),
(modest_init_local_folders):
* src/modest-init.h: Initialize the .modest library for memory cards,
instead of just doing nothing for them. This should allow us to create
folders there, fixing projects.maemo.org bug NB#59297.
pmo-trunk-r2208
Sergio Villar Senin [Wed, 13 Jun 2007 13:35:31 +0000 (13:35 +0000)]
* Follow the 30/70 rule for the main paned separation position when there is no configuration set
pmo-trunk-r2207
Sergio Villar Senin [Wed, 13 Jun 2007 13:19:19 +0000 (13:19 +0000)]
* Moved back the contents style code to the UI actions
pmo-trunk-r2205
Murray Cumming [Wed, 13 Jun 2007 12:50:33 +0000 (12:50 +0000)]
2007-06-13 Murray Cumming <murrayc@murrayc.com>
* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
(libmodest_dbus_client_compose_mail),
(libmodest_dbus_client_open_message),
(libmodest_dbus_client_send_and_receive),
(libmodest_dbus_client_open_default_inbox): Improved debug messages.
* src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
(on_idle_open_message), (modest_dbus_req_handler),
(search_result_to_message), (modest_dbus_req_filter):
* src/modest-search.c: (add_hit), (modest_search_folder),
(modest_search_all_accounts): Improved debug messages.
* tests/dbus_api/test_open_message.c: (main): Improved comments.
* src/modest-tny-account-store.c:
(modest_tny_account_store_get_tny_account_by): Initialize a variable to
fix the build.
pmo-trunk-r2202
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 11:15:49 +0000 (11:15 +0000)]
Comment 'msg-sending' signal handler, waiting for patch approval
on tinymail camel send queues.
pmo-trunk-r2200
Sergio Villar Senin [Wed, 13 Jun 2007 11:03:46 +0000 (11:03 +0000)]
* Fixes NB#59753, the account that is created is now visible if it's the unique account
* The visible account key is removed if the currently visible account is deleted
* the View->AccountX option to view a particular account works again
* Fixed a bug when opening messages that are already opened
* The folder view now listens to account-remove signal
* refactored modest_tny_account_store_get_tny_account_by_* in a single function
* Fixed a bug when removing the visible account, now the default one is selected as the new visible account
pmo-trunk-r2198
Philip Van Hoof [Wed, 13 Jun 2007 10:50:40 +0000 (10:50 +0000)]
Initialization improvements
pmo-trunk-r2197
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 09:15:01 +0000 (09:15 +0000)]
* Fixed bug in _selected_msg_sent_in_progress function,
cause an invalid g_free over an TnyIterator object.
pmo-trunk-r2196
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 09:02:33 +0000 (09:02 +0000)]
* Remove a g_return_if_fail in _selected_msg_sent_in_progress because
this function is allowed now for both, main and msg view window.
pmo-trunk-r2195
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 08:48:42 +0000 (08:48 +0000)]
* Added two new signal handlers to detect when messages are bieng processed to be sent
and when they have been finnaly sent.
* Add new dimming rules to detect sending operation in progress.
* Fixes: NB#60176
pmo-trunk-r2194
Philip Van Hoof [Wed, 13 Jun 2007 08:32:41 +0000 (08:32 +0000)]
Initialization speedup
pmo-trunk-r2193
Javier Fernandez Garcia-Boente [Wed, 13 Jun 2007 06:59:20 +0000 (06:59 +0000)]
* Added a new function to check selected folder is an MMC or POP root.
* Fixes: NB#59433
pmo-trunk-r2191
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 16:33:43 +0000 (16:33 +0000)]
* updated the changelog
pmo-trunk-r2189
Murray Cumming [Tue, 12 Jun 2007 16:19:29 +0000 (16:19 +0000)]
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_server_accounts):
Call modest_tny_local_folders_account_add_merged_outbox_folders()
even when there are no accounts, so that the Outbox folder is always
visible. This fixes projects.maemo.org bug NB#60158.
pmo-trunk-r2188
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 16:15:22 +0000 (16:15 +0000)]
* Updated the changelog with the lates fixes and know issues.
pmo-trunk-r2187
Javier Fernandez Garcia-Boente [Tue, 12 Jun 2007 15:33:47 +0000 (15:33 +0000)]
* Fixes: NB#60332
pmo-trunk-r2186
Javier Fernandez Garcia-Boente [Tue, 12 Jun 2007 15:17:11 +0000 (15:17 +0000)]
Fixes: NB#60186
pmo-trunk-r2185
Javier Fernandez Garcia-Boente [Tue, 12 Jun 2007 14:32:29 +0000 (14:32 +0000)]
I forgot to upload this file.
pmo-trunk-r2184
Javier Fernandez Garcia-Boente [Tue, 12 Jun 2007 14:29:46 +0000 (14:29 +0000)]
* Fixed bug in empty_view of headers treeview when selected folder is empty.
* Fixes: NB#60141, NB#60144
pmo-trunk-r2183
Philip Van Hoof [Tue, 12 Jun 2007 14:16:46 +0000 (14:16 +0000)]
Initialization speedups
pmo-trunk-r2182
Sergio Villar Senin [Tue, 12 Jun 2007 14:14:54 +0000 (14:14 +0000)]
* Fixed a bug when trying to launch modest without accounts
pmo-trunk-r2181
Murray Cumming [Tue, 12 Jun 2007 13:58:34 +0000 (13:58 +0000)]
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window.c: (create_details_widget):
Use the mcen_va_never logical ID.
pmo-trunk-r2180
Murray Cumming [Tue, 12 Jun 2007 11:25:18 +0000 (11:25 +0000)]
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c:
(on_idle_open_default_inbox), (on_open_default_inbox),
(modest_dbus_req_handler):
Added a new OpenDefaultInbox method.
* libmodest-dbus-client/libmodest-dbus-client.h:
* libmodest-dbus-client/libmodest-dbus-client.c:
Added libmodest_dbus_client_open_default_inbox() to call the new
dbus method. This should be useful to projects.maemo.org bug NB#57214,
though it should maybe be used by a new osso-email-interface function.
* tests/dbus_api/Makefile.am:
* tests/dbus_api/test_open_default_inbox.c: Added a test for the new
function.
pmo-trunk-r2179
Murray Cumming [Tue, 12 Jun 2007 10:46:25 +0000 (10:46 +0000)]
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c: (on_key_change): Append to the list, not to
NULL, so that the signals get all the keys. This should not actually
change any behaviour because we currently update everything when anything
changes.
2007-06-12 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-folder-view.c: (text_cell_data),
(icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
(find_inbox_iter): If tinymail tells us that the folder is
a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
This causes the inbox to be selected at startup, fixing part of
projects.maemo.org bug NB#56305.
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_tools_smtp_servers):
* src/modest-ui-dimming-rules.h: Added a callback function to dim
the SMTP servers menu item.
* src/maemo/modest-main-window-ui-dimming.h: Used the function, so
that the SMTP Servers menu item is dimmed when there are no accounts,
as a future version of the UI spec will require. This fixes
projects.maemo.org bug NB#56305.
pmo-trunk-r2178
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:37:55 +0000 (10:37 +0000)]
* remove my debug g_warnings from modest_tny_account_store
pmo-trunk-r2177
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:36:32 +0000 (10:36 +0000)]
* small cosmetic cleanups, leak fix for modest_account_mgr_set_first_account_as_default
pmo-trunk-r2176
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:34:12 +0000 (10:34 +0000)]
* use modest_account_mgr_set_first_account_as default; remove dupl code
pmo-trunk-r2175
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:32:57 +0000 (10:32 +0000)]
* no need to set a new default account explicitely anymore
pmo-trunk-r2174
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:31:24 +0000 (10:31 +0000)]
* set a new default account when removing the current one
pmo-trunk-r2173
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 10:29:19 +0000 (10:29 +0000)]
* add libnotify dep
pmo-trunk-r2172
Jose Dapena Paz [Tue, 12 Jun 2007 09:31:02 +0000 (09:31 +0000)]
* src/maemo/modest-msg-view-window.c:
* Now it updates the window title with the subject (fixes NB#58040).
pmo-trunk-r2171
Jose Dapena Paz [Tue, 12 Jun 2007 08:31:31 +0000 (08:31 +0000)]
* src/maemo/modest-msg-view-window.c:
* Added insensitive press handlers for view attachment and save attachment
* Now Find Toolbar sets focus on itself on being shown.
pmo-trunk-r2170
Sergio Villar Senin [Tue, 12 Jun 2007 08:09:04 +0000 (08:09 +0000)]
* Fixed a reference leak in the main window
* The update_model function of the folder view is now public
* The main window now unregisters some signals that was causing a lot of problems
* The Move to dialog now shows contents even if the main window do not exists. Fixes NB#59468
pmo-trunk-r2169
Sergio Villar Senin [Tue, 12 Jun 2007 07:10:41 +0000 (07:10 +0000)]
* The open menu item of the header view CSM now opens a message. Fixes NB#60246
pmo-trunk-r2168
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 07:00:21 +0000 (07:00 +0000)]
* Updated the changelog with fixes made on Week 24 day 2
pmo-trunk-r2167
Dirk-Jan C. Binnema [Tue, 12 Jun 2007 06:49:36 +0000 (06:49 +0000)]
* add a forgotten g_object_uref(iter) to _modest_ui_actions_open
pmo-trunk-r2166
Johannes Schmid [Mon, 11 Jun 2007 21:21:33 +0000 (21:21 +0000)]
2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/modest-maemo-utils.c:
(modest_maemo_utils_get_supported_secure_authentication_methods):
Added label to dialog instead of unreadable title
* src/maemo/modest-main-window.c: (sync_accounts_cb),
(modest_main_window_new):
Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
dead code.
* src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
* src/modest-account-mgr.h:
Added method to avoid code duplication
* src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
(modest_ui_actions_on_send_receive):
Use modest_account_mgr_has_accounts
pmo-trunk-r2165
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 17:08:21 +0000 (17:08 +0000)]
* fix crasher when cancelling all operations ('operations_to_cancel' needs to be initialized)
pmo-trunk-r2164
Murray Cumming [Mon, 11 Jun 2007 16:50:17 +0000 (16:50 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-presets.c:
(modest_presets_get_info_server_security): Do not report secure auth
if there is none.
* src/modest-protocol-info.c: Use the defines for the gconf key names
for secure authentication. This was not working because we were writing
Password and reading password, and the check was case sensitive.
With this, gmail now works for receiving and sending when created via
easysetup.
pmo-trunk-r2163
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 16:28:08 +0000 (16:28 +0000)]
* do a disconnect/reconnect with pop-servers upon send-receive, as they may not report new messages otherwise. needs the latest tinymail
pmo-trunk-r2162
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 16:26:20 +0000 (16:26 +0000)]
* do some extra checking to prevent a random segfault sometimes; small cleanup
pmo-trunk-r2161
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 16:25:03 +0000 (16:25 +0000)]
* in some cases, cancel_all would core, apparently because cur->data was invalid.
now, we don't crash, but give an error on stderr instead
pmo-trunk-r2160
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 16:23:20 +0000 (16:23 +0000)]
* some crash fixes - in some cases, modest core'd because of errors when copying/moving
pmo-trunk-r2159
Dirk-Jan C. Binnema [Mon, 11 Jun 2007 15:48:29 +0000 (15:48 +0000)]
* Updated the changelog with fixes made on Week 24 day 01.
pmo-trunk-r2158
Murray Cumming [Mon, 11 Jun 2007 15:43:20 +0000 (15:43 +0000)]
Murray Cumming <murrayc@murrayc.com>
pmo-trunk-r2157
Sergio Villar Senin [Mon, 11 Jun 2007 14:32:05 +0000 (14:32 +0000)]
* Changed the order of some CSM menu entries. This Fixes NB#60247
pmo-trunk-r2154
Murray Cumming [Mon, 11 Jun 2007 13:30:29 +0000 (13:30 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c: (modest_platform_on_new_msg):
Prevent use of the new notification feature for now, because it currently
shows one dialog for each new email, which is annoying.
pmo-trunk-r2153
Murray Cumming [Mon, 11 Jun 2007 12:29:24 +0000 (12:29 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
(easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
when no country was selected, so that we show the global ones.
* src/maemo/easysetup/modest-presets.c:
(modest_presets_get_providers): Return only the global providers, not
all providers when mmc=0 was requested.
pmo-trunk-r2152
Jose Dapena Paz [Mon, 11 Jun 2007 12:17:29 +0000 (12:17 +0000)]
* src/modest-attachments-view.c:
* Fixed the calculation of the attachment clicked, that broke
all the widget clicking code (fixes NB#59462).
pmo-trunk-r2151
Murray Cumming [Mon, 11 Jun 2007 11:42:14 +0000 (11:42 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
(easysetup_provider_combo_box_fill): Remove debug code that showed the
provider ID in the combo.
* src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
Do not show the page numbers, because it would be confusing when we add
the 2 extra pages for the custom setup, when the user chooses the Other
provider. This fixes projects.maemo.org bug NB#59028
* src/modest-init.c: (modest_init_init_core),
(modest_init_local_folders):
* src/modest-init.h:
* src/modest-tny-account.c:
(modest_tny_account_new_for_local_folders): Do not create default folders
for the memory card. This should fix projects.maemo.org bug NB#59328.
pmo-trunk-r2150
Jose Dapena Paz [Mon, 11 Jun 2007 11:32:13 +0000 (11:32 +0000)]
Fix for NB#58037. Not reply to all removes the user's address. To do it
first it gets the address itself (the a@b.c part), and then it removes
all the Cc: addresses that match with this part:
* src/modest-text-utils.c:
* Now remove_address takes into account the email address
instead of the full address string.
pmo-trunk-r2149
Sergio Villar Senin [Mon, 11 Jun 2007 11:08:36 +0000 (11:08 +0000)]
* Added a first implementation for new messages notifications
pmo-trunk-r2148
Jose Dapena Paz [Mon, 11 Jun 2007 11:01:23 +0000 (11:01 +0000)]
Fix for NB#59458 (should dim sort button when the selected folder
is a root folder).
* src/maemo/modest-main-window-ui-dimming.h:
* Added dimming handler for sort dialog actions.
* src/modest-ui-dimming-rules.[ch]:
* Added dimming handler for sort dialog actions. Should
be dimmed when the folder is a root folder.
Restored the UI menu actions available in viewer.
* src/maemo/ui/modest-msg-view-window-ui.xml:
* Readded show toolbar actions.
* Readded find in page actions.
pmo-trunk-r2147
Murray Cumming [Mon, 11 Jun 2007 08:19:49 +0000 (08:19 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c: (modest_account_mgr_finalize):
Free the changed_conf_keys string items. They are already freed in the
idle handler if that runs first.
pmo-trunk-r2145
Sergio Villar Senin [Mon, 11 Jun 2007 08:11:07 +0000 (08:11 +0000)]
* Removed a TODO
* Fixed the account manager new batch notification system, it was not working
* Do not reload the accounts if only the last-updated key has changed, it was working but it seems that somebody commented it
pmo-trunk-r2144
Murray Cumming [Mon, 11 Jun 2007 07:43:23 +0000 (07:43 +0000)]
2007-06-11 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested): Check that the server name
is not NULL, because I just saw a password dialog with (null) as the
server name.
* src/modest-tny-folder.[h|c]: Added
modest_tny_folder_is_memory_card_folder().
* src/modest-ui-dimming-rules.c:
(modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
menu item for memory cards, as per the UI spec (section 7.4). This should
fix projects.maemo.org bug NB#59297.
pmo-trunk-r2143
Murray Cumming [Mon, 11 Jun 2007 06:45:10 +0000 (06:45 +0000)]
fixed a typo.
pmo-trunk-r2142
Johannes Schmid [Sun, 10 Jun 2007 18:25:17 +0000 (18:25 +0000)]
2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/modest-main-window.c: (sync_accounts_cb):
Fixed projects.maemo.org bug NB#58576 (not yet activated as there
is another problem with the code, see Murray\'s comment at line 772)
pmo-trunk-r2141
Dirk-Jan C. Binnema [Sun, 10 Jun 2007 18:06:21 +0000 (18:06 +0000)]
* add (c)-headers, forgotten g_object_unref
pmo-trunk-r2140
Johannes Schmid [Sun, 10 Jun 2007 17:44:43 +0000 (17:44 +0000)]
2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
* src/maemo/modest-main-window.c: (sync_accounts_cb):
Fixed projects.maemo.org bug NB#56472 (not yet activated as there
is another problem with the code, see Murray\'s comment at line 772)
pmo-trunk-r2139
Dirk-Jan C. Binnema [Fri, 8 Jun 2007 16:17:28 +0000 (16:17 +0000)]
* partial fix for NB#58220, waiting for desktop now
pmo-trunk-r2138
Murray Cumming [Fri, 8 Jun 2007 16:09:26 +0000 (16:09 +0000)]
2007-06-08 Murray Cumming <murrayc@murrayc.com>
* src/maemo/easysetup/modest-easysetup-country-combo-box.h:
* src/maemo/easysetup/modest-easysetup-country-combo-box.c:
(on_model_foreach_release), (easysetup_country_combo_box_finalize),
(load_from_file), (easysetup_country_combo_box_init),
(easysetup_country_combo_box_get_active_country_ids),
(on_model_foreach_select_id): Store a GSList* of IDs in the model row,
instead of just one ID, to avoid duplicate country names in the UI.
* src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
* src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
(easysetup_provider_combo_box_fill): Adapt to use a list rather than
a single ID, avoiding duplicate providers.
* src/maemo/easysetup/modest-easysetup-wizard.c:
(on_combo_account_country): Adapt to use a list.
pmo-trunk-r2137
Dirk-Jan C. Binnema [Fri, 8 Jun 2007 14:48:05 +0000 (14:48 +0000)]
* updated the changelog with six new bug fixes.
pmo-trunk-r2135
Sergio Villar Senin [Fri, 8 Jun 2007 14:08:05 +0000 (14:08 +0000)]
* Fixed a mistake in the last commit thanks to Murray's good sight
pmo-trunk-r2134
Sergio Villar Senin [Fri, 8 Jun 2007 13:49:22 +0000 (13:49 +0000)]
* Deleted a priv .c file, it's enough with the .h file to make their methods protected
* Fixed a crasher related to DBUS when setting the last update value
* Added an emission of the account_removed signal
* Fixes NB#56420, the account cache is now cleared when an account is removed
pmo-trunk-r2132
Murray Cumming [Fri, 8 Jun 2007 12:45:59 +0000 (12:45 +0000)]
2007-06-08 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
keys changed in the last X seconds.
* src/modest-account-mgr.h:
* src/modest-account-mgr.c: (on_timeout_notify_changes),
(on_key_change), (modest_account_mgr_class_init),
(modest_account_mgr_init), (modest_account_mgr_finalize):
As the keys are changed, save them in a GSList* and signal that GSList*
further every X seconds, to batch changes, to allow us to do just one
update per batch. This should fix bug projects.maemo.org bug NB#56472 and
bug NB#56941 and other (UI-blocking) delays when changing account settings.
* src/modest-tny-account-store.c: (on_account_changed): Adapted to
changed signal signature.
* src/modest-conf.c: (modest_conf_set_list),
(modest_conf_on_change): Reenable notification.
(modest_conf_maemo_fake_on_change): Comment out the hack that
notified immediately instead of asynchronously.
* src/widgets/modest-account-view.h:
* src/widgets/modest-account-view.c:
(update_account_view): Select the previously-selected account ID,
if possible. This fixes projects.maemo.org bug NB#56933.
(on_account_changed), (on_account_removed),
(modest_account_view_select_account):
Remove the block/unblock functions
because they were not useful.
* src/maemo/modest-account-view-window.c:
(on_delete_button_clicked), (on_edit_button_clicked),
(on_new_button_clicked): Remove the use of the non-working block/unblock.
pmo-trunk-r2130
Javier Fernandez Garcia-Boente [Fri, 8 Jun 2007 09:59:04 +0000 (09:59 +0000)]
* Fixes: NB#59378, NB#59389
* Implemented some pending dimming rules
pmo-trunk-r2129
Philip Van Hoof [Fri, 8 Jun 2007 09:45:33 +0000 (09:45 +0000)]
Added some comments
pmo-trunk-r2128