From 2940eee6b6e016398a6cc8d404f59143c6140920 Mon Sep 17 00:00:00 2001 From: Sergio Villar Senin Date: Thu, 23 Oct 2008 11:39:19 +0000 Subject: [PATCH] * Fixes NB#90705, commented an unused function and added a couple of initializations pmo-trunk-r6149 --- src/widgets/modest-security-options-view.c | 138 ++++++++++++++-------------- 1 file changed, 70 insertions(+), 68 deletions(-) diff --git a/src/widgets/modest-security-options-view.c b/src/widgets/modest-security-options-view.c index 26915c1..571a293 100644 --- a/src/widgets/modest-security-options-view.c +++ b/src/widgets/modest-security-options-view.c @@ -348,75 +348,75 @@ modest_security_options_view_auth_check (ModestSecurityOptionsView* self) return FALSE; } -GList* -modest_security_options_view_get_supported_auth_methods (ModestSecurityOptionsView *self, - const gchar *hostname, - const gchar *username, - ModestProtocolType server_type) -{ - GtkWindow *window; - GError *error = NULL; - GList *list_auth_methods, *retval = NULL; - ModestSecurityOptionsViewPrivate *priv; - ModestAccountSettings current_settings; - ModestServerAccountSettings *server_settings; +/* GList* */ +/* modest_security_options_view_get_supported_auth_methods (ModestSecurityOptionsView *self, */ +/* const gchar *hostname, */ +/* const gchar *username, */ +/* ModestProtocolType server_type) */ +/* { */ +/* GtkWindow *window; */ +/* GError *error = NULL; */ +/* GList *list_auth_methods, *retval = NULL; */ +/* ModestSecurityOptionsViewPrivate *priv; */ +/* ModestAccountSettings current_settings; */ +/* ModestServerAccountSettings *server_settings; */ - priv = MODEST_SECURITY_OPTIONS_VIEW_GET_PRIVATE (self); - - window = GTK_WINDOW (gtk_widget_get_ancestor (GTK_WIDGET (self), GTK_TYPE_WINDOW)); - - /* Get current settings */ - modest_security_options_view_save_settings (self, ¤t_settings); - - if (self->type == MODEST_SECURITY_OPTIONS_INCOMING) - server_settings = modest_account_settings_get_store_settings (¤t_settings); - else - server_settings = modest_account_settings_get_transport_settings (¤t_settings); - - list_auth_methods = - modest_utils_get_supported_secure_authentication_methods (server_type, - hostname, - modest_server_account_settings_get_port (server_settings), - username, - window, - &error); - - if (list_auth_methods) { - GList *list = NULL, *method = NULL; - ModestProtocolRegistry *registry = modest_runtime_get_protocol_registry (); - - for (method = list_auth_methods; method != NULL; method = g_list_next(method)) { - ModestProtocolType auth_protocol_type = - (ModestProtocolType) (GPOINTER_TO_INT(method->data)); - if (modest_protocol_registry_protocol_type_is_secure (registry, - auth_protocol_type)) { - list = g_list_append(list, GINT_TO_POINTER(auth_protocol_type)); - } - } - g_list_free(list_auth_methods); - if (list) { - retval = list; - goto end; - } - } - - if(error == NULL || - error->domain != modest_utils_get_supported_secure_authentication_error_quark() || - error->code != MODEST_UTILS_GET_SUPPORTED_SECURE_AUTHENTICATION_ERROR_CANCELED) { - modest_platform_information_banner (GTK_WIDGET(self), - NULL, - _("mcen_ib_unableto_discover_auth_methods")); - } - - if(error != NULL) - g_error_free(error); - - end: - /* Frees */ - g_object_unref (server_settings); - - return retval; -} +/* priv = MODEST_SECURITY_OPTIONS_VIEW_GET_PRIVATE (self); */ + +/* window = GTK_WINDOW (gtk_widget_get_ancestor (GTK_WIDGET (self), GTK_TYPE_WINDOW)); */ + +/* /\* Get current settings *\/ */ +/* modest_security_options_view_save_settings (self, ¤t_settings); */ + +/* if (self->type == MODEST_SECURITY_OPTIONS_INCOMING) */ +/* server_settings = modest_account_settings_get_store_settings (¤t_settings); */ +/* else */ +/* server_settings = modest_account_settings_get_transport_settings (¤t_settings); */ + +/* list_auth_methods = */ +/* modest_utils_get_supported_secure_authentication_methods (server_type, */ +/* hostname, */ +/* modest_server_account_settings_get_port (server_settings), */ +/* username, */ +/* window, */ +/* &error); */ + +/* if (list_auth_methods) { */ +/* GList *list = NULL, *method = NULL; */ +/* ModestProtocolRegistry *registry = modest_runtime_get_protocol_registry (); */ + +/* for (method = list_auth_methods; method != NULL; method = g_list_next(method)) { */ +/* ModestProtocolType auth_protocol_type = */ +/* (ModestProtocolType) (GPOINTER_TO_INT(method->data)); */ +/* if (modest_protocol_registry_protocol_type_is_secure (registry, */ +/* auth_protocol_type)) { */ +/* list = g_list_append(list, GINT_TO_POINTER(auth_protocol_type)); */ +/* } */ +/* } */ +/* g_list_free(list_auth_methods); */ +/* if (list) { */ +/* retval = list; */ +/* goto end; */ +/* } */ +/* } */ + +/* if(error != NULL && */ +/* error->domain == modest_utils_get_supported_secure_authentication_error_quark() && */ +/* error->code != MODEST_UTILS_GET_SUPPORTED_SECURE_AUTHENTICATION_ERROR_CANCELED) { */ +/* modest_platform_information_banner (GTK_WIDGET(self), */ +/* NULL, */ +/* _("mcen_ib_unableto_discover_auth_methods")); */ +/* } */ + +/* if(error != NULL) */ +/* g_error_free(error); */ + +/* end: */ +/* /\* Frees *\/ */ +/* g_object_unref (server_settings); */ + +/* return retval; */ +/* } */ static void modest_security_options_view_init (ModestSecurityOptionsView *self) @@ -430,6 +430,8 @@ modest_security_options_view_init (ModestSecurityOptionsView *self) priv->auth_view = NULL; priv->user_entry = NULL; priv->pwd_entry = NULL; + priv->full = FALSE; + priv->changed = FALSE; } static void -- 1.7.9.5