From 47b9de7a73030206f0f366ec60164e8f1e549916 Mon Sep 17 00:00:00 2001 From: Murray Cumming Date: Mon, 21 May 2007 14:46:40 +0000 Subject: [PATCH] 2007-05-21 Murray Cumming * src/modest-account-mgr.c: (modest_account_mgr_add_account): * src/modest-mail-operation-queue.c: (modest_mail_operation_queue_remove): * src/modest-tny-account-store.c: When GErrors happen, give more clues about where they happened. pmo-trunk-r1942 --- ChangeLog2 | 8 ++++++++ src/modest-account-mgr.c | 6 +++--- src/modest-mail-operation-queue.c | 2 +- src/modest-tny-account-store.c | 3 ++- 4 files changed, 14 insertions(+), 5 deletions(-) diff --git a/ChangeLog2 b/ChangeLog2 index 825e318..02382d4 100644 --- a/ChangeLog2 +++ b/ChangeLog2 @@ -1,5 +1,13 @@ 2007-05-21 Murray Cumming + * src/modest-account-mgr.c: (modest_account_mgr_add_account): + * src/modest-mail-operation-queue.c: + (modest_mail_operation_queue_remove): + * src/modest-tny-account-store.c: When GErrors happen, give more clues + about where they happened. + +2007-05-21 Murray Cumming + * src/modest-ui-actions.c: (modest_ui_actions_on_password_requested): Make sure that the remember output parameter is always TRUE. diff --git a/src/modest-account-mgr.c b/src/modest-account-mgr.c index fde5cc4..ea8afe4 100644 --- a/src/modest-account-mgr.c +++ b/src/modest-account-mgr.c @@ -251,7 +251,7 @@ modest_account_mgr_add_account (ModestAccountMgr *self, if (!ok) { g_printerr ("modest: cannot set display name\n"); if (err) { - g_printerr ("modest: %s\n", err->message); + g_printerr ("modest: Error adding account conf: %s\n", err->message); g_error_free (err); } return FALSE; @@ -265,7 +265,7 @@ modest_account_mgr_add_account (ModestAccountMgr *self, g_printerr ("modest: failed to set store account '%s'\n", store_account); if (err) { - g_printerr ("modest: %s\n", err->message); + g_printerr ("modest: Error adding store account conf: %s\n", err->message); g_error_free (err); } @@ -282,7 +282,7 @@ modest_account_mgr_add_account (ModestAccountMgr *self, g_printerr ("modest: failed to set transport account '%s'\n", transport_account); if (err) { - g_printerr ("modest: %s\n", err->message); + g_printerr ("modest: Error adding transport account conf: %s\n", err->message); g_error_free (err); } return FALSE; diff --git a/src/modest-mail-operation-queue.c b/src/modest-mail-operation-queue.c index db14af7..1893768 100644 --- a/src/modest-mail-operation-queue.c +++ b/src/modest-mail-operation-queue.c @@ -198,7 +198,7 @@ modest_mail_operation_queue_remove (ModestMailOperationQueue *self, const GError *err; err = modest_mail_operation_get_error (mail_op); if (err) - g_printerr (err->message); + g_printerr ("Error in %s: %s", __FUNCTION__, err->message); } /* Notify observers */ diff --git a/src/modest-tny-account-store.c b/src/modest-tny-account-store.c index 9e1db5f..c577ded 100644 --- a/src/modest-tny-account-store.c +++ b/src/modest-tny-account-store.c @@ -355,7 +355,8 @@ get_password (TnyAccount *account, const gchar *prompt, gboolean *cancel) return pwd; } - +/* tinymail calls this if the connection failed due to an incorrect password. + * And it seems to call this for any general connection failure. */ static void forget_password (TnyAccount *account) { -- 1.7.9.5