From a3aa80cab7e6a43ab7fc90e74a82eef9d479cc72 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 15 Jan 2010 23:41:04 +0100 Subject: [PATCH] Fix "off-by-one" bug in hddtemp found by valgrind --- src/hddtemp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/hddtemp.c b/src/hddtemp.c index 12e6f24..5f7edec 100644 --- a/src/hddtemp.c +++ b/src/hddtemp.c @@ -130,7 +130,7 @@ static char *fetch_hddtemp_output(void) close(sockfd); } if (!rp) { - NORM_ERR("could not connect to mpd host"); + NORM_ERR("could not connect to hddtemp host"); goto GET_OUT; } @@ -172,6 +172,8 @@ static int read_hdd_val(const char *line, char **dev, short *val, char *unit, line_s = *saveptr; again: + if(!*p) + goto out_fail; /* read the device */ *dev = ++p; if (!(p = strchr(p, line_s[0]))) -- 1.7.9.5