1 ##############################################################################
2 # $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitStringyEval.pm $
3 # $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $
6 ##############################################################################
8 package Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval;
15 use Perl::Critic::Utils qw{ :severities :classification :ppi };
16 use base 'Perl::Critic::Policy';
18 our $VERSION = '1.088';
20 #-----------------------------------------------------------------------------
22 Readonly::Scalar my $DESC => q{Expression form of "eval"};
23 Readonly::Scalar my $EXPL => [ 161 ];
25 #-----------------------------------------------------------------------------
27 sub supported_parameters { return () }
28 sub default_severity { return $SEVERITY_HIGHEST }
29 sub default_themes { return qw( core pbp bugs ) }
30 sub applies_to { return 'PPI::Token::Word' }
32 #-----------------------------------------------------------------------------
35 my ( $self, $elem, undef ) = @_;
37 return if $elem ne 'eval';
38 return if ! is_function_call($elem);
40 my $arg = first_arg($elem);
42 return if $arg->isa('PPI::Structure::Block');
44 return $self->violation( $DESC, $EXPL, $elem );
51 #-----------------------------------------------------------------------------
57 Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval - Write C<eval { my $foo; bar($foo) }> instead of C<eval "my $foo; bar($foo);">.
61 This Policy is part of the core L<Perl::Critic> distribution.
66 The string form of C<eval> is recompiled every time it is executed,
67 whereas the block form is only compiled once. Also, the string form
68 doesn't give compile-time warnings.
70 eval "print $foo"; #not ok
71 eval {print $foo}; #ok
76 This Policy is not configurable except for the standard options.
81 L<Perl::Critic::Policy::ControlStrucutres::RequireBlockGrep>
83 L<Perl::Critic::Policy::ControlStrucutres::RequireBlockMap>
87 Jeffrey Ryan Thalhammer <thaljef@cpan.org>
91 Copyright (c) 2005-2008 Jeffrey Ryan Thalhammer. All rights reserved.
93 This program is free software; you can redistribute it and/or modify
94 it under the same terms as Perl itself. The full text of this license
95 can be found in the LICENSE file included with this module.
101 # cperl-indent-level: 4
103 # indent-tabs-mode: nil
104 # c-indentation-style: bsd
106 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :