1 ##############################################################################
2 # $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/ControlStructures/ProhibitCStyleForLoops.pm $
3 # $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $
6 ##############################################################################
8 package Perl::Critic::Policy::ControlStructures::ProhibitCStyleForLoops;
15 use Perl::Critic::Utils qw{ :characters :severities };
16 use base 'Perl::Critic::Policy';
18 our $VERSION = '1.088';
20 #-----------------------------------------------------------------------------
22 Readonly::Scalar my $DESC => q{C-style "for" loop used};
23 Readonly::Scalar my $EXPL => [ 100 ];
25 #-----------------------------------------------------------------------------
27 sub supported_parameters { return () }
28 sub default_severity { return $SEVERITY_LOW }
29 sub default_themes { return qw( core pbp maintenance ) }
30 sub applies_to { return 'PPI::Structure::ForLoop' }
32 #-----------------------------------------------------------------------------
35 my ( $self, $elem, undef ) = @_;
37 if ( _is_cstyle($elem) ) {
38 return $self->violation( $DESC, $EXPL, $elem );
45 my $nodes_ref = $elem->find('PPI::Token::Structure');
46 return if !$nodes_ref;
47 my @semis = grep { $_ eq $SCOLON } @{$nodes_ref};
48 return scalar @semis == 2;
55 #-----------------------------------------------------------------------------
61 Perl::Critic::Policy::ControlStructures::ProhibitCStyleForLoops - Write C<for(0..20)> instead of C<for($i=0; $i<=20; $i++)>.
65 This Policy is part of the core L<Perl::Critic> distribution.
70 The 3-part C<for> loop that Perl inherits from C is butt-ugly, and only
71 really necessary if you need irregular counting. The very Perlish
72 C<..> operator is much more elegant and readable.
74 for($i=0; $i<=$max; $i++){ #ick!
78 for(0..$max){ #very nice
85 This Policy is not configurable except for the standard options.
90 Jeffrey Ryan Thalhammer <thaljef@cpan.org>
94 Copyright (c) 2005-2008 Jeffrey Ryan Thalhammer. All rights reserved.
96 This program is free software; you can redistribute it and/or modify
97 it under the same terms as Perl itself. The full text of this license
98 can be found in the LICENSE file included with this module.
104 # cperl-indent-level: 4
106 # indent-tabs-mode: nil
107 # c-indentation-style: bsd
109 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :