1 ##############################################################################
2 # $URL: http://perlcritic.tigris.org/svn/perlcritic/trunk/Perl-Critic/lib/Perl/Critic/Policy/InputOutput/RequireCheckedClose.pm $
3 # $Date: 2008-07-03 10:19:10 -0500 (Thu, 03 Jul 2008) $
6 ##############################################################################
8 package Perl::Critic::Policy::InputOutput::RequireCheckedClose;
15 use Perl::Critic::Utils qw{ :severities :classification };
16 use base 'Perl::Critic::Policy';
18 our $VERSION = '1.088';
20 #-----------------------------------------------------------------------------
22 Readonly::Scalar my $DESC => q{Return value of "close" ignored};
23 Readonly::Scalar my $EXPL => q{Check the return value of "close" for success};
25 #-----------------------------------------------------------------------------
27 sub supported_parameters { return () }
28 sub default_severity { return $SEVERITY_LOW }
29 sub default_themes { return qw( core maintenance ) }
30 sub applies_to { return 'PPI::Token::Word' }
32 #-----------------------------------------------------------------------------
35 my ( $self, $elem, undef ) = @_;
37 return if $elem ne 'close';
38 return if ! is_unchecked_call( $elem );
40 return $self->violation( $DESC, $EXPL, $elem );
49 #-----------------------------------------------------------------------------
55 Perl::Critic::Policy::InputOutput::RequireCheckedClose - Write C<< my $error = close $fh; >> instead of C<< close $fh; >>.
59 This Policy is part of the core L<Perl::Critic> distribution.
64 The perl builtin I/O function C<close> returns a false value on failure. That
65 value should be checked to ensure that the close was successful.
68 my $error = close $filehandle; # ok
69 close $filehandle or die "unable to close: $!"; # ok
70 close $filehandle; # not ok
75 This Policy is not configurable except for the standard options.
80 Andrew Moore <amoore@mooresystems.com>
82 =head1 ACKNOWLEDGMENTS
84 This policy module is based heavily on policies written by Jeffrey Ryan
85 Thalhammer <thaljef@cpan.org>.
89 Copyright (c) 2007-2008 Andrew Moore. All rights reserved.
91 This program is free software; you can redistribute it and/or modify
92 it under the same terms as Perl itself. The full text of this license
93 can be found in the LICENSE file included with this module.
97 ##############################################################################
100 # cperl-indent-level: 4
102 # indent-tabs-mode: nil
103 # c-indentation-style: bsd
105 # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :