Forcing calls to quit immediately rather than giving time to cancel to fix issues...
[theonering] / src / channel / text.py
index f9c00ae..5212cd7 100644 (file)
@@ -4,101 +4,181 @@ import logging
 
 import telepathy
 
-import util.go_utils as gobject_utils
+import tp
 import util.coroutines as coroutines
-import gtk_toolbox
+import util.misc as misc_utils
+import util.go_utils as gobject_utils
+import gvoice
+
 
+_moduleLogger = logging.getLogger(__name__)
 
-_moduleLogger = logging.getLogger("channel.text")
 
+class TextChannel(tp.ChannelTypeText):
 
-class TextChannel(telepathy.server.ChannelTypeText):
-       """
-       Look into implementing ChannelInterfaceMessages for rich text formatting
-       """
+       OLDEST_MESSAGE_WINDOW = datetime.timedelta(days=1)
 
-       def __init__(self, connection, h):
-               telepathy.server.ChannelTypeText.__init__(self, connection, h)
-               self._nextRecievedId = 0
-               self._lastMessageTimestamp = datetime.datetime(1, 1, 1)
+       def __init__(self, connection, manager, props, contactHandle):
+               self.__manager = manager
+               self.__props = props
 
-               self._otherHandle = h
+               tp.ChannelTypeText.__init__(self, connection, manager, props)
+               self.__nextRecievedId = 0
 
-               self._conn.session.conversations.updateSignalHandler.register_sink(
-                       self._on_conversations_updated
+               self.__otherHandle = contactHandle
+
+               self.__callback = coroutines.func_sink(
+                       coroutines.expand_positional(
+                               self._on_conversations_updated
+                       )
+               )
+               self._conn.session.voicemails.updateSignalHandler.register_sink(
+                       self.__callback
+               )
+               self._conn.session.texts.updateSignalHandler.register_sink(
+                       self.__callback
                )
 
                # The only reason there should be anything in the conversation is if
                # its new, so report it all
                try:
-                       conversation = self._conn.session.conversations.get_conversation(self._contactKey)
+                       mergedConversations = self._conn.session.voicemails.get_conversation(self._contactKey)
+               except KeyError:
+                       _moduleLogger.debug("No voicemails in the conversation yet for %r" % (self._contactKey, ))
+               else:
+                       self._report_conversation(mergedConversations)
+               try:
+                       mergedConversations = self._conn.session.texts.get_conversation(self._contactKey)
                except KeyError:
-                       pass
+                       _moduleLogger.debug("No texts conversation yet for %r" % (self._contactKey, ))
                else:
-                       self._report_conversation(conversation)
+                       self._report_conversation(mergedConversations)
 
-       @gtk_toolbox.log_exception(_moduleLogger)
+       @misc_utils.log_exception(_moduleLogger)
        def Send(self, messageType, text):
+               le = gobject_utils.AsyncLinearExecution(self._conn.session.pool, self._send)
+               le.start(messageType, text)
+
+       @misc_utils.log_exception(_moduleLogger)
+       def _send(self, messageType, text):
                if messageType != telepathy.CHANNEL_TEXT_MESSAGE_TYPE_NORMAL:
                        raise telepathy.errors.NotImplemented("Unhandled message type: %r" % messageType)
 
-               self._conn.session.backend.send_sms(self._otherHandle.phoneNumber, text)
+               _moduleLogger.info("Sending message to %r" % (self.__otherHandle, ))
+               try:
+                       result = yield (
+                               self._conn.session.backend.send_sms,
+                               ([self.__otherHandle.phoneNumber], text),
+                               {},
+                       )
+               except Exception:
+                       _moduleLogger.exception("Oh no, what happened?")
+                       return
+
+               self._conn.session.textsStateMachine.reset_timers()
 
                self.Sent(int(time.time()), messageType, text)
 
-       @gtk_toolbox.log_exception(_moduleLogger)
+       @misc_utils.log_exception(_moduleLogger)
+       def _on_send_sms_failed(self, error):
+               _moduleLogger.error(error)
+
+       @misc_utils.log_exception(_moduleLogger)
        def Close(self):
-               try:
-                       # Clear since the user has seen it all and it should start a new conversation
-                       self._conn.session.conversations.clear_conversation(self._contactKey)
+               self.close()
 
-                       self._conn.session.conversations.updateSignalHandler.unregister_sink(
-                               self._on_conversations_updated
-                       )
-               finally:
-                       telepathy.server.ChannelTypeText.Close(self)
-                       self.remove_from_connection()
+       def close(self):
+               _moduleLogger.debug("Closing text")
+               self._conn.session.voicemails.updateSignalHandler.unregister_sink(
+                       self.__callback
+               )
+               self._conn.session.texts.updateSignalHandler.unregister_sink(
+                       self.__callback
+               )
+               self.__callback = None
+
+               tp.ChannelTypeText.Close(self)
+               self.remove_from_connection()
 
        @property
        def _contactKey(self):
-               contactKey = self._otherHandle.contactID, self._otherHandle.phoneNumber
+               contactKey = self.__otherHandle.phoneNumber
                return contactKey
 
-       @coroutines.func_sink
-       @coroutines.expand_positional
-       @gobject_utils.async
-       def _on_conversations_updated(self, conversationIds):
+       @misc_utils.log_exception(_moduleLogger)
+       def _on_conversations_updated(self, conv, conversationIds):
                if self._contactKey not in conversationIds:
                        return
-               conversation = self._conn.session.conversations.get_conversation(self._contactKey)
-               self._report_conversation(conversation)
-
-       def _report_conversation(self, conversation):
-               # @bug Check if messages sent need to be filtered out
-               completeMessageHistory = conversation["messageParts"]
-               messages = self._filter_seen_messages(completeMessageHistory)
-               self._lastMessageTimestamp = messages[-1][0]
-               formattedMessage = self._format_messages(messages)
-               self._report_new_message(formattedMessage)
-
-       def _filter_seen_messages(self, messages):
-               return (
-                       message
-                       for message in messages
-                       if self._lastMessageTimestamp < message[0]
-               )
+               _moduleLogger.debug("Incoming messages from %r for existing conversation" % (self._contactKey, ))
+               mergedConversations = conv.get_conversation(self._contactKey)
+               self._report_conversation(mergedConversations)
+
+       def _report_conversation(self, mergedConversations):
+               newConversations = mergedConversations.conversations
+               if not newConversations:
+                       _moduleLogger.info(
+                               "No messages ended up existing for %r" % (self._contactKey, )
+                       )
+                       return
+
+               # Can't filter out messages in a texting conversation that came in
+               # before the last one sent because that creates a race condition of two
+               # people sending at about the same time, which happens quite a bit
+               postUpdateLen = len(newConversations)
+               newConversations = gvoice.conversations.filter_out_self(newConversations)
+               newConversations = list(newConversations)
+               postSelfLen = len(newConversations)
+               if postSelfLen < postUpdateLen:
+                       _moduleLogger.info("Dropped %s messages due to being from self" % (postUpdateLen - postSelfLen))
+               if not newConversations:
+                       _moduleLogger.debug(
+                               "New messages for %r are from yourself" % (self._contactKey, )
+                       )
+                       return
+
+               newConversations = gvoice.conversations.filter_out_read(newConversations)
+               newConversations = list(newConversations)
+               postReadLen = len(newConversations)
+               if postReadLen < postSelfLen:
+                       _moduleLogger.info("Dropped %s messages due to already being read" % (postSelfLen- postReadLen))
+               if not newConversations:
+                       _moduleLogger.debug(
+                               "New messages for %r have already been read externally" % (self._contactKey, )
+                       )
+                       return
+
+               messages = [
+                       (newMessage, newConversation)
+                       for newConversation in newConversations
+                       for newMessage in newConversation.messages
+                       if not gvoice.conversations.is_message_from_self(newMessage)
+               ]
+               if not messages:
+                       _moduleLogger.debug(
+                               "How did this happen for %r?" % (self._contactKey, )
+                       )
+                       return
+
+               now = datetime.datetime.now()
+               for newMessage, conv in messages:
+                       if self.OLDEST_MESSAGE_WINDOW < (now - conv.time):
+                               _moduleLogger.warning("Why are we reporting a message that is so old?")
+                               _moduleLogger.warning("\t%r %r (%r) with %r messages" % (conv.number, conv.id, conv.time, len(conv.messages)))
+                       formattedMessage = self._format_message(newMessage)
+                       self._report_new_message(formattedMessage, conv.time)
 
-       def _format_messages(self, messages):
-               return "\n".join(message[1] for message in messages)
+               for conv in mergedConversations.conversations:
+                       conv.isRead = True
 
-       def _report_new_message(self, message):
-               currentReceivedId = self._nextRecievedId
+       def _format_message(self, message):
+               return " ".join(part.text.strip() for part in message.body)
 
-               timestamp = int(time.time())
+       def _report_new_message(self, message, convTime):
+               currentReceivedId = self.__nextRecievedId
+               timestamp = time.mktime(convTime.timetuple())
                type = telepathy.CHANNEL_TEXT_MESSAGE_TYPE_NORMAL
-               message = message.content
 
-               _moduleLogger.info("Received message from User %r" % self._otherHandle)
-               self.Received(id, timestamp, self._otherHandle, type, 0, message)
+               _moduleLogger.info("Received message from User %r" % self.__otherHandle)
+               self.Received(currentReceivedId, timestamp, self.__otherHandle, type, 0, message)
 
-               self._nextRecievedId += 1
+               self.__nextRecievedId += 1