#!/usr/bin/python
+# @bug False positives on startup. Luckily the object path for the channel is
+# unique, so can use that to cache some of the data out to file
+
+from __future__ import with_statement
import logging
import util.coroutines as coroutines
+import util.misc as util_misc
_moduleLogger = logging.getLogger("gvoice.conversations")
class Conversations(object):
- def __init__(self, backend):
- self._backend = backend
+ def __init__(self, getter):
+ self._get_raw_conversations = getter
self._conversations = {}
self.updateSignalHandler = coroutines.CoTee()
oldConversationIds = set(self._conversations.iterkeys())
updateConversationIds = set()
- conversations = list(self._backend.get_conversations())
+ conversations = list(self._get_raw_conversations())
conversations.sort()
for conversation in conversations:
- key = conversation.contactId, conversation.number
+ key = conversation.contactId, util_misc.normalize_number(conversation.number)
try:
mergedConversations = self._conversations[key]
except KeyError:
try:
mergedConversations.append_conversation(conversation)
isConversationUpdated = True
- except RuntimeError:
+ except RuntimeError, e:
+ if False:
+ _moduleLogger.info("Skipping conversation for %r because '%s'" % (key, e))
isConversationUpdated = False
if isConversationUpdated:
def append_conversation(self, newConversation):
self._validate(newConversation)
- self._remove_repeats(newConversation)
+ for similarConversation in self._find_related_conversation(newConversation.id):
+ self._update_previous_related_conversation(similarConversation, newConversation)
+ self._remove_repeats(similarConversation, newConversation)
self._conversations.append(newConversation)
@property
if newConversation.time <= self._conversations[-1].time:
raise RuntimeError("Conversations got out of order")
- def _remove_repeats(self, newConversation):
- similarConversations = [
+ def _find_related_conversation(self, convId):
+ similarConversations = (
conversation
for conversation in self._conversations
- if conversation.id == newConversation.id
+ if conversation.id == convId
+ )
+ return similarConversations
+
+ def _update_previous_related_conversation(self, relatedConversation, newConversation):
+ for commonField in ("isRead", "isSpam", "isTrash", "isArchived"):
+ newValue = getattr(newConversation, commonField)
+ setattr(relatedConversation, commonField, newValue)
+
+ def _remove_repeats(self, relatedConversation, newConversation):
+ newConversationMessages = newConversation.messages
+ newConversation.messages = [
+ newMessage
+ for newMessage in newConversationMessages
+ if newMessage not in relatedConversation.messages
]
-
- for similarConversation in similarConversations:
- for commonField in ("isRead", "isSpam", "isTrash", "isArchived"):
- newValue = getattr(newConversation, commonField)
- setattr(similarConversation, commonField, newValue)
-
- newConversation.messages = [
- newMessage
- for newMessage in newConversation.messages
- if newMessage not in similarConversation.messages
- ]
- assert 0 < len(newConversation.messages), "Everything shouldn't have been removed"
+ _moduleLogger.debug("Found %d new messages in conversation %s (%d/%d)" % (
+ len(newConversationMessages) - len(newConversation.messages),
+ newConversation.id,
+ len(newConversation.messages),
+ len(newConversationMessages),
+ ))
+ assert 0 < len(newConversation.messages), "Everything shouldn't have been removed"