From: Ed Page <eopage@byu.net>
Date: Wed, 27 Jan 2010 03:18:45 +0000 (-0600)
Subject: Explaining the hack I put in
X-Git-Url: http://git.maemo.org/git/?p=theonering;a=commitdiff_plain;h=b9ad2ac3c7c44c94b107932c533edcc08e6be95b

Explaining the hack I put in
---

diff --git a/src/gvoice/conversations.py b/src/gvoice/conversations.py
index e5d71fe..7fbe1ca 100644
--- a/src/gvoice/conversations.py
+++ b/src/gvoice/conversations.py
@@ -115,6 +115,11 @@ class MergedConversations(object):
 			self._remove_repeats(similarConversation, newConversation)
 			similarExist = True
 		if similarExist:
+			# Hack to reduce a race window with GV marking messages as read
+			# because it thinks we replied when really we replied to the
+			# previous message.  Clients of this code are expected to handle
+			# this gracefully.  Other race conditions may exist but clients are
+			# responsible for them
 			if newConversation.messages:
 				newConversation.isRead = False
 			else: