From b15b70a605a2aa7cef1e08ef83e98acc1df585e0 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Thu, 26 Nov 2009 07:49:55 -0600 Subject: [PATCH] Marking all of the current TODOs --- src/channel/call.py | 1 + src/channel/text.py | 1 + src/connection.py | 2 ++ src/simple_presence.py | 10 +++++++--- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/channel/call.py b/src/channel/call.py index c9a753e..0e2bebf 100644 --- a/src/channel/call.py +++ b/src/channel/call.py @@ -9,6 +9,7 @@ import handle _moduleLogger = logging.getLogger("channel.call") +# @todo Test Calls class CallChannel( telepathy.server.ChannelTypeStreamedMedia, telepathy.server.ChannelInterfaceCallState, diff --git a/src/channel/text.py b/src/channel/text.py index 4adc544..d394b0f 100644 --- a/src/channel/text.py +++ b/src/channel/text.py @@ -10,6 +10,7 @@ import handle _moduleLogger = logging.getLogger("channel.text") +# @todo Get receiving of texts to work class TextChannel(telepathy.server.ChannelTypeText): """ Look into implementing ChannelInterfaceMessages for rich text formatting diff --git a/src/connection.py b/src/connection.py index 9071996..00c0e83 100644 --- a/src/connection.py +++ b/src/connection.py @@ -22,6 +22,8 @@ class TheOneRingConnection( ): # Overriding a base class variable + # @todo remove forward as one of the settings but instead use the alias + # with set sane defaults and saving it to an ini file _mandatory_parameters = { 'username' : 's', 'password' : 's', diff --git a/src/simple_presence.py b/src/simple_presence.py index 29deb88..6e6e324 100644 --- a/src/simple_presence.py +++ b/src/simple_presence.py @@ -44,7 +44,7 @@ class SimplePresenceMixin(telepathy.server.ConnectionInterfaceSimplePresence): @gtk_toolbox.log_exception(_moduleLogger) def GetPresences(self, contacts): """ - @todo Figure out how to know when its self and get whether busy or not + @todo Copy Aliasing's approach to knowing if self and get whether busy or not @return {ContactHandle: (Status, Presence Type, Message)} """ @@ -64,11 +64,15 @@ class SimplePresenceMixin(telepathy.server.ConnectionInterfaceSimplePresence): if message: raise telepathy.errors.InvalidArgument("Messages aren't supported") + if status == TheOneRingPresence.ONLINE: - self.gvoice_backend.mark_dnd(True) + # @todo Implement dnd + #self.gvoice_backend.mark_dnd(True) + pass elif status == TheOneRingPresence.BUSY: + # @todo Implement dnd + #self.gvoice_backend.mark_dnd(False) raise telepathy.errors.NotAvailable("DnD support not yet added to TheOneRing") - self.gvoice_backend.mark_dnd(False) else: raise telepathy.errors.InvalidArgument("Unsupported status: %r" % status) _moduleLogger.info("Setting Presence to '%s'" % status) -- 1.7.9.5