From b9ad2ac3c7c44c94b107932c533edcc08e6be95b Mon Sep 17 00:00:00 2001 From: Ed Page Date: Tue, 26 Jan 2010 21:18:45 -0600 Subject: [PATCH] Explaining the hack I put in --- src/gvoice/conversations.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/gvoice/conversations.py b/src/gvoice/conversations.py index e5d71fe..7fbe1ca 100644 --- a/src/gvoice/conversations.py +++ b/src/gvoice/conversations.py @@ -115,6 +115,11 @@ class MergedConversations(object): self._remove_repeats(similarConversation, newConversation) similarExist = True if similarExist: + # Hack to reduce a race window with GV marking messages as read + # because it thinks we replied when really we replied to the + # previous message. Clients of this code are expected to handle + # this gracefully. Other race conditions may exist but clients are + # responsible for them if newConversation.messages: newConversation.isRead = False else: -- 1.7.9.5