1 2007-08-16 Armin Burgmeier <armin@openismus.com>
3 * src/modest-ui-actions.c: Show a banner instead of a dialog when
4 renaming a folder fails, to stay consistent with what happens when
5 creating a folder fails.
7 * src/maemo/easysetup/modest-easysetup-country-combo-box.c: Optimized
8 slightly country loading from the mmc_mappings file, fixed a memory
11 2007-08-16 Murray Cumming <murrayc@murrayc.com>
13 * src/modest-tny-account-store.c: (volume_path_is_mounted):
14 Check the GnomeVFSVolume activation path instead of the device path,
15 so that the memory card is really really shown in the UI.
17 2007-08-16 Murray Cumming <murrayc@murrayc.com>
19 * src/maemo/easysetup/modest-easysetup-wizard.c:
20 (get_entered_account_title), (on_before_next), (entry_is_empty),
22 * src/maemo/modest-account-settings-dialog.c:
23 (get_entered_account_title), (on_button_signature), (check_data),
24 (save_configuration), (entry_is_empty):
25 Strip the account title of whitespace at the start and end before
26 using it or checking it. This means that an all-whitespace title
27 is not allowed, fixing projects.maemo.org bug NB#64977.
29 2007-08-15 Murray Cumming <murrayc@murrayc.com>
31 * src/modest-ui-actions.h:
32 * src/modest-ui-actions.c: Renamed modest_run_account_setup_wizard()
33 to modest_run_account_setup_wizard() and made it public.
34 * src/dbus_api/modest-dbus-callbacks.c:
35 (check_and_offer_account_creation), (on_idle_mail_to),
36 (on_idle_compose_mail), (on_idle_open_default_inbox):
37 Offer account creation if necessary, fixing projects.maemo.org
40 2007-08-15 Murray Cumming <murrayc@murrayc.com>
42 * src/modest-ui-actions.c: (run_account_setup_wizard):
43 Return a gboolean to indicate success.
44 (modest_ui_actions_on_new_msg), (open_msg_cb), (reply_forward),
45 (modest_ui_actions_on_send): When offering account creation, only
46 give up (return) if account creation failed. Otherwise continue
47 with the original request. This fixed projects.maemo.org bug
50 2007-08-15 Murray Cumming <murrayc@murrayc.com>
52 * src/widgets/modest-recpt-editor.c:
53 (modest_recpt_editor_instance_init): Turn off hildon auto-capitalization,
54 to fix projects.maemo.org bug NB#63789.
56 2007-08-15 Murray Cumming <murrayc@murrayc.com>
58 * src/modest-tny-account-store.c: Added volume_path_is_mounted().
59 (modest_tny_account_store_new): Properly detect the memory card at
60 startup, and add an account for it.
62 2007-08-14 Murray Cumming <murrayc@murrayc.com>
64 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
65 Commented out the MMC code again because it mistakenly detects
66 the card even when it isn't inserted.
68 2007-08-14 Murray Cumming <murrayc@murrayc.com>
70 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
71 Renabled the call to add_mmc_account() because I do not believe
72 it could be the cause of the mentioned hang (in scratchbox, where
73 there is no memory card), and because I have tested that it works
76 2007-08-14 Murray Cumming <murrayc@murrayc.com>
78 * src/modest-tny-account-store.c: (modest_tny_account_store_new):
79 Comment out part of the last commit because it apparently causes
82 2007-08-14 Murray Cumming <murrayc@murrayc.com>
84 * src/modest-tny-account-store.c: Added the add_mmc_account()
85 function to save some copy/pasting.
86 (modest_tny_account_store_new): If the memory card is mounted,
87 create an account for it at the start, instead of waiting for the
88 user to unmount it and mount it.
90 2007-08-13 Murray Cumming <murrayc@murrayc.com>
92 * src/widgets/modest-account-view.c: (on_account_changed):
93 Do not try to use the human-readable TnyAccount name instead of the
94 ID of the modest account to get the transport account. And unref
95 the transport account. This prevents a g_warning(), and a possible
98 2007-08-13 Murray Cumming <murrayc@murrayc.com>
100 * src/maemo/modest-platform.c:
101 (modest_platform_set_update_interval): Handle the new
102 alarmd error to warn when alarmd is not running, as is the case in
103 scratchbox for me now because
104 "Module /usr/lib/alarmd/libretu.so initialization failed"
106 2007-08-13 Murray Cumming <murrayc@murrayc.com>
108 * src/widgets/modest-header-view-render.c:
109 (_modest_header_view_compact_header_cell_data):
110 NULL some strings after freeing them, trying to deal with
111 the double deletion found in projects.maemo.org bug 64183,
112 probably having no effect.
114 2007-08-13 Murray Cumming <murrayc@murrayc.com>
116 * src/maemo/modest-account-settings-dialog.c:
117 (create_page_incoming), (create_page_outgoing): Use a define
118 for the min and max port numbers.
120 (check_hildon_number_editor_and_warn_value_not_in_range),
121 (check_data): Do an extra check for an invalid port number, as needed
122 in projects.maemo.org bug #64275, when the number is cleared, but this
123 does not work due to bugs.maemo.org bug #1806.
125 2007-08-13 Murray Cumming <murrayc@murrayc.com>
127 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
128 Comment out the debug warning about the unexpected D-Bus methods.
129 They are just annoying now.
130 * src/maemo/modest-platform.c:
131 (modest_platform_set_update_interval): Correct the D-Bus path, instead
132 of using a file path, though it did not seem to break things before.
133 It might be needed now:
134 Use the ALARM_EVENT_ACTIVATION flag so that emails are updated even when
135 modest is not already running. This is the behaviour of the old client, and
136 Mox says it is what we should do for modest.
137 This closes projects.maemo.org bug NB#64327.
139 2007-08-04 Johannes Schmid <johannes.schmid@openismus.com>
141 * src/modest-text-utils.c:
142 Fixed invalid jump due to incorrect string/pointer
144 (See https://projects.maemo.org/trac/email/wiki/ValgrindErrors
147 2007-08-01 Murray Cumming <murrayc@murrayc.com>
149 * src/modest-account-mgr-helpers.h:
150 * src/modest-account-mgr-helpers.c:
151 Added modest_account_mgr_get_first_account_name(),
152 using code from modest_account_mgr_set_first_account_as_default().
154 * src/maemo/modest-main-window.c: Added set_at_least_one_account_visible().
155 (account_number_changed): Call set_at_least_one_account_visible() so that
156 the first account is visible when first added, without the user having to
158 I do wonder how this worked before.
160 2007-08-01 Murray Cumming <murrayc@murrayc.com>
162 * src/modest-tny-account-store.c: (show_password_warning_only),
163 (show_wrong_password), (request_password_and_wait), (get_password),
164 (modest_tny_account_store_alert): Remove the (incomplete anyway)
165 attempts to show UI only in the main context, which used g_idle_add()
166 and mainloops, because tinymail now guarantees that it only calls these
167 callbacks in the mainloop with the gdk lock. This makes everything much
170 2007-08-01 Murray Cumming <murrayc@murrayc.com>
172 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
173 Handle TNY_ACCOUNT_ERROR_TRY_CONNECT_SERVICE_UNAVAILABLE in the same
174 way as TNY_ACCOUNT_ERROR_TRY_CONNECT_HOST_LOOKUP_FAILED, showing an
175 error dialog, instead of ignoring it.
177 2007-08-01 Murray Cumming <murrayc@murrayc.com>
179 * src/maemo/modest-msg-view-window.c:
180 (modest_msg_view_window_get_header),
181 (modest_msg_view_window_last_message_selected):
182 Added comments to explain the use of priv->header_model.
183 * src/modest-ui-dimming-rules.c:
184 (modest_ui_dimming_rules_on_open_msg),
185 (modest_ui_dimming_rules_on_mark_as_read_msg),
186 (modest_ui_dimming_rules_on_mark_as_unread_msg),
187 (modest_ui_dimming_rules_on_remove_attachments),
188 (_invalid_attach_selected), (_selected_msg_marked_as):
189 Renamed _marked_as_deleted() to _selected_message_is_marked_as_deleted(),
190 and changed the parameter to a ModestMainWindow to make it clearer that
191 it never uses any other kind of window.
192 Added _message_is_marked_as_deleted() for examining a ModestMsgViewWindow
193 instead of the selected message.
194 I notice that much of the dimming code and the ModestMsgViewWindow code
195 hard-codes the assumption that the viewed message is always selected in
196 the header view. This does not seem wise or simple.
198 (modest_ui_dimming_rules_on_delete_msg): For a ModestMsgViewWindow,
199 examine the actual message instead of whatever might be selected
200 in the header view. This stops the delete toolbar button and menu item
201 from being dimmed when opening a message view the search UI,
202 partially fixing projects.maemo.org bug NB#63811.
204 However, when actually deleting, I now get this warning:
205 "tny_header_set_flags: This is a header instance for a new message.
206 Only priority and attachment flags are supported"
208 2007-07-30 Johannes Schmid <johannes.schmid@openismus.com>
210 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
212 Show account wizard if no accounts are defined while sending
213 (automatic sending after the account wizard finished does not
214 work because it takes some time until the account manager
215 synchronizes everything. (projects.maemo.org NB#62792)
217 2007-07-30 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-tny-account-store.c: (on_account_removed),
220 (on_account_changed): Emit the ACCOUNT_UPDATE signal so that the
221 account is removed from the View menu. We have TnyAccountStore
222 and ModestTnyAccountStore signals that seem very similar, but this
223 seems to work for now.
225 * src/maemo/modest-main-window.c:
226 (on_show_account_action_activated): Prevent dereference
227 of a NULL if the accoutn does not really exist, though that
228 should not happen anymore.
230 This fixes projects.maemo.org bug NB#64606.
232 2007-07-30 Murray Cumming <murrayc@murrayc.com>
234 * src/modest-ui-actions.c: (run_account_setup_wizard),
235 (modest_ui_actions_on_accounts): Revert a change that set these
236 to modal dialogs, freezing the UI when they show secondary dialogs.
237 This fixed projects.maemo.org bug NB#64519.
239 2007-07-27 Murray Cumming <murrayc@murrayc.com>
241 * src/widgets/modest-header-view-render.c:
242 (_modest_header_view_compact_header_cell_data):
243 Some checks and initialization to try to deal with a crash,
244 probably ineffective.
246 2007-07-27 Murray Cumming <murrayc@murrayc.com>
248 * src/maemo/modest-maemo-utils.c:
249 (modest_maemo_utils_get_supported_secure_authentication_methods):
250 Make sure that we have a connection, asking the user for one
252 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
253 Check for a connection before showing the wizard, because
254 the wizard needs a connection to check for server capabilities.
256 2007-07-27 Murray Cumming <murrayc@murrayc.com>
258 * src/maemo/modest-account-view-window.c:
259 (on_new_button_clicked): Remember the wizard dialog instance,
260 so we can just present it again if necessary. This prevents
261 multiple windows from appearing if you click again quickly on the
262 New button before the dialog appears, fixing projects.maemo.org
265 2007-07-27 Murray Cumming <murrayc@murrayc.com>
267 * src/maemo/modest-main-window.c: (modest_main_window_on_show):
268 Offer a connection dialog if there is no connection when
269 starting modest. This should fix projects.maemo.org bug NB#61134.
271 2007-07-27 Murray Cumming <murrayc@murrayc.com>
273 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
274 Reverted my last commit. I was able to fix the build by doing
275 apt-get install wpeditor0 (replacing other wpeditor packages) and
276 an explicit apt-get install wpeditor-dev to upgrade the -dev
279 2007-07-27 Murray Cumming <murrayc@murrayc.com>
281 * src/maemo/modest-msg-edit-window.c: (replace_with_attachments):
282 Commented out the use of wp_text_buffer_replace_image()
283 because it does not exist, to break the build. Added a TODO for it.
285 2007-07-26 Murray Cumming <murrayc@murrayc.com>
287 * src/modest-tny-account-store.c: (recreate_all_accounts):
288 Recreate them even if they were NULL before. I guess something
289 else was already creating them before, or this would never
291 (modest_tny_account_store_get_server_account): Make sure that
292 the tny accounts have been created before trying to find one.
293 This allows libmodest_dbus_client_compose_mail() to work
294 when the UI is not yet visible.
295 This is probably useful in other cases too.
297 (get_password): When the password is wrong after it is entered
298 in the protected password dialog, show an info banner (in an
299 idle handler) before showing the protected password dialog
302 2007-07-26 Murray Cumming <murrayc@murrayc.com>
304 * src/modest-ui-actions.h:
305 * src/modest-ui-actions.c: Added
306 modest_do_refresh_current_folder() containing some code from
307 modest_ui_actions_on_send_receive().
308 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive):
309 Call modest_do_refresh_current_folder() before refreshing the
310 requested account, as in modest_ui_actions_on_send_receive().
311 This is strange, but seems to be necessary to show new mails.
312 Now new emails are finally visible in the UI when downloaded
313 via the automatic update interval, fixing bug NB#57458.
314 This also works because bug NB#57458 has been fixed somehow.
316 2007-07-26 Murray Cumming <murrayc@murrayc.com>
318 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
319 printf more details when we get unhandled D-Bus methods, because
322 * src/modest-mail-operation.c: (update_account_thread):
323 Comment out the tny_camel_pop_store_account_reconnect(), because this
324 is apparently no longer needed, and it did not work before anyway.
325 See the comment in the code.
327 * src/modest-search.c: (modest_search_folder): Ignore deleted emails,
328 by checking the header flags. This fixes projects.maemo.org bug
331 2007-07-25 Murray Cumming <murrayc@murrayc.com>
333 * src/maemo/modest-maemo-utils.h:
334 * src/maemo/modest-maemo-utils.c: Added
335 modest_maemo_show_information_note_in_main_context_and_forget().
336 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
337 Use the new function to show simple error dialogs in the main
338 context, though question dialogs are still in the current context,
339 which is unfortunately usually not the main context. This should
342 2007-07-25 Murray Cumming <murrayc@murrayc.com>
344 * src/modest-tny-account-store.c: (get_password):
345 Never save the entered username and password in gconf,
346 because the UI spec says we should not. This helps
347 slightly with projects.maemo.org bug NB#63671.
349 2007-07-25 Murray Cumming <murrayc@murrayc.com>
351 * src/widgets/modest-msg-edit-window.h:
352 * src/maemo/modest-msg-edit-window.c: (create_stream_for_uri):
353 Moved some code here to make it simpler.
354 (modest_msg_edit_window_attach_file_one): Renamed from
355 modest_msg_edit_window_attach_file_interactive().
356 (modest_msg_edit_window_offer_attach_file): Renamed from
357 modest_msg_edit_window_attach_file() and used
358 modest_msg_edit_window_attach_file_one() instead of
359 copy/pasting the code. The old code for one was not using
360 GnomeVFS. This allows use of smb:// URLs when using send-as
361 from external applications, fixing bug NB#63741.
363 (modest_msg_edit_window_insert_image),
364 (modest_msg_edit_window_add_attachment_clicked):
365 * src/modest-ui-actions.c: (modest_ui_actions_on_attach_file):
366 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail):
367 Adapted to the new function names.
369 2007-07-25 Murray Cumming <murrayc@murrayc.com>
371 (modest_platform_set_update_interval): Set the alarm recurrence
372 fields so that auto-update does not just happen the first time.
373 This should have fixed projects.maemo.org bug NB#63938.
375 When this happens you can see a printf when the D-Bus method is
377 GLIB DEBUG default - debug: modest_dbus_req_handler: method received: SendReceive
379 However, I do not actually seem to get new POP messages even when
380 clicking the refresh button manually. A restart gets them.
381 This might be a problem in today's tinymail only.
383 2007-07-24 Murray Cumming <murrayc@murrayc.com>
385 * src/maemo/modest-maemo-global-settings-dialog.c:
386 (current_connection):
387 Avoid a crash (probably only in scratchbox) when strcmp()ing a
388 NULL when closing the dialog.
390 2007-07-24 Murray Cumming <murrayc@murrayc.com>
392 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
393 Remove the hacky send/receive that didn't work, and instead
394 refilter the treemodel to make the deleted email really vanish from
395 the UI (though the delete-from-menu code does has commented out
396 the code that does that). This fixes projects.maemo.org bug
399 2007-07-24 Murray Cumming <murrayc@murrayc.com>
401 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
402 Try a couple of tricks to force the treeview to update (
403 poke the folder, and do a send/receive refresh), but the deleted
404 email still appears with a strike-through instead of really being
407 2007-07-23 Murray Cumming <murrayc@murrayc.com>
409 * src/dbus_api/modest-dbus-callbacks.c:
410 (add_single_folder_to_list): Ignore TnyMergeFolder folders,
411 because their ID is not human-readable (see the comment about
412 improvements needed to the osso-email-interface API) and
413 TnyMergeFolder::get_id_func() currently crashes with DBC enabled.
415 2007-07-23 Murray Cumming <murrayc@murrayc.com>
417 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler),
418 (add_folders_to_list), (on_dbus_method_get_folders),
419 (modest_dbus_req_filter):
420 * src/maemo/modest-maemo-utils.c:
421 (on_camel_account_get_supported_secure_authentication):
422 * src/maemo/modest-main-window.c: (modest_main_window_set_style),
423 (on_header_view_focus_in):
424 * src/modest-email-clipboard.c: (modest_email_clipboard_set_data):
425 * src/modest-formatter.c: (modest_formatter_create_body_part):
426 * src/modest-mail-operation.c: (recurse_folders),
427 (update_account_thread), (get_msgs_full_thread),
428 (modest_mail_operation_get_msgs_full),
429 (modest_mail_operation_xfer_msgs):
430 * src/modest-search.c: (search_mime_part_and_child_parts),
431 (modest_search_account), (modest_search_all_accounts):
432 * src/modest-tny-account.c:
433 (modest_tny_account_get_special_folder), (recurse_folders):
434 * src/modest-tny-local-folders-account.c:
435 (modest_tny_local_folders_account_query_passes):
436 * src/modest-tny-msg.c: (copy_mime_part),
437 (modest_tny_msg_find_body_part_from_mime_part):
438 * src/modest-tny-send-queue.c: (modest_tny_send_queue_cancel),
439 (modest_tny_send_queue_try_to_send):
440 * src/modest-ui-actions.c: (modest_ui_actions_on_delete_message),
441 (_modest_ui_actions_open), (download_uncached_messages),
442 (reply_forward), (modest_ui_actions_on_copy),
443 (modest_ui_actions_on_details), (has_retrieved_msgs),
444 (msgs_move_to_confirmation), (open_msg_for_purge_cb),
446 * src/modest-ui-dimming-rules.c: (_already_opened_msg),
447 (_selected_msg_marked_as), (_msg_download_completed),
448 (_selected_msg_sent_in_progress):
449 * src/widgets/modest-attachments-view.c:
450 (modest_attachments_view_set_message):
451 * src/widgets/modest-msg-view.c: (find_cid_image):
452 * tests/check_folder-transfer.c: (find_folders):
453 * tests/check_update-account.c: (func):
454 * tests/dbus_api/test_get_folders.c: (main):
455 Checked all uses of tny_iterator_get_current(), making sure
456 that the object is unreferenced (3 or 4 places did not),
457 and adding checks for NULL.
459 2007-07-23 Murray Cumming <murrayc@murrayc.com>
461 * src/dbus_api/modest-dbus-callbacks.c:
462 (on_idle_open_default_inbox): Make sure that the application UI is
464 * src/maemo/easysetup/modest-easysetup-wizard.c:
465 (on_entry_invalid_character): Show the word whitespace instead
466 of (null) in the banner when whitespace was entered.
467 (show_error): Add a comment that this does not work in
468 Maemo Bora, though we do not know why.
470 2007-07-23 Murray Cumming <murrayc@murrayc.com>
472 * src/modest-tny-account.c:
473 (modest_tny_account_get_special_folder): Use an if instead of
474 an assert for when the parent account name is NULL, because this
475 might be causing a crash in projects.maemo.org bug 63192.
476 * src/modest-mail-operation.c:
477 (modest_mail_operation_send_new_mail_cb),
478 (modest_mail_operation_remove_folder): unref the folder that is
479 returned from modest_tny_account_get_special_folder().
481 2007-07-23 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-ui-actions.c:
484 (modest_ui_actions_on_password_requested):
485 Show mail_ib_login_cancelled info banner when the user cancels
486 the protected password dialog, to fix projects.maemo.org
489 2007-07-23 Murray Cumming <murrayc@murrayc.com>
491 * src/maemo/modest-account-settings-dialog.c:
492 (create_page_outgoing): Put this page in a GtkScrolledWindow,
493 matching the UI mock-up in the UI spec, and allowing access
494 to all widgets even when the on-screen keyboard is active.
496 2007-07-23 Murray Cumming <murrayc@murrayc.com>
498 Reverted this previous commit from Johannes,
499 because the scrollbars are always visible and because
500 I think we only need it on onepage of the account
501 settings, not the account wizard.
502 (I wrote the wrong instructions in the bug.)
504 * src/maemo/easysetup/modest-easysetup-wizard.c:
505 Added scrollbars to account wizard dialog.
506 Fixed projects.maemo.org NB #62744
508 2007-07-22 Johannes Schmid <johannes.schmid@openismus.com>
510 * src/maemo/easysetup/modest-easysetup-wizard.c:
511 (create_page_user_details):
512 Use auto-cap for name (projects.maemo.org NB#63716)
513 * src/widgets/modest-account-view.c: (on_account_busy_changed):
515 2007-07-22 Armin Burgmeier <armin@openismus.com>
517 * src/maemo/modest-ui-actions.c: Use current account instead of
518 default account for creating viewer windows, so that the viewer
519 window knows to which account the viewed message belongs.
521 * src/maemo/modest-msg-view-window.c: Destroy the window when the
522 corresponding account is deleted. This fixes projects.maemo.org bug
525 2007-07-18 Armin Burgmeier <armin@openismus.com>
527 * src/maemo/modest-connection-specific-smtp-edit-window.c: Don't let
528 the dialog close after entering an invalid port number and clicking
529 OK. This fixes projects.maemo.org bug NB#63602.
531 2007-07-18 Armin Burgmeier <armin@openismus.com>
533 * src/modest-tny-account-store.c:
534 (get_server_accounts): Set parent modest account name for each
535 connection-specific transport account so that special folders of such
536 an account can be looked up. This fixes a crash when changing account
537 settings. This might also be related to projects.maemo.org bug
540 2007-07-16 Armin Burgmeier <armin@openismus.com>
542 * src/modest-ui-actions.c: Added a button to create a folder to the
543 move-to dialog. This fixes projects.maemo.org bug NB#59863.
545 2007-07-16 Johannes Schmid <johannes.schmid@openismus.com>
547 * src/maemo/easysetup/modest-easysetup-wizard.c:
548 Added scrollbars to account wizard dialog.
549 Fixed projects.maemo.org NB #62744
551 2007-07-16 Murray Cumming <murrayc@murrayc.com>
553 * src/widgets/modest-msg-view.h:
554 * src/widgets/modest-msg-view.c:
555 Added modest_msg_view_get_message_is_empty() but this needs
557 * src/maemo/modest-msg-edit-window.c: (message_is_empty):
558 Check if there is any text in the message yet.
559 But this needs to be implemented properly.
560 (modest_msg_edit_window_toggle_find_toolbar):
561 * src/maemo/modest-msg-view-window.c:
562 (modest_msg_view_window_toggle_find_toolbar):
563 Show a banner warning if there is no text to search, when
564 trying to start a search. This partially fixes
565 projects.maemo.org bug NB#62350.
567 2007-07-13 Murray Cumming <murrayc@murrayc.com>
569 * src/modest-mail-operation.c: (update_account_thread):
570 Initialized num_new_headers to fix the build.
572 2007-07-13 Murray Cumming <murrayc@murrayc.com>
574 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
575 Ignore modest accounts whose server accounts don't exist in gconf.
576 This prevents us trying to create TnyAccount instances for those
577 server accounts when the server account has been removed from gconf,
578 but the parent modest account has not yet been removed from modest.
579 I don't know why this is only noticeable now. It was probably just
580 a harmeless g_warning() anyway.
582 2007-07-13 Murray Cumming <murrayc@murrayc.com>
584 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
585 Fix my previous commit, to avoid unrefing a NULL TnyFolderStore.
587 2007-07-12 Armin Burgmeier <armin@openismus.com>
589 * src/maemo/modest-main-window.c: Make default account appear bold
590 in view, tools/send & receive and toolbar/send & receive SCM menus.
591 This fixes projects.maemo.org bug NB#59010.
593 2007-07-12 Murray Cumming <murrayc@murrayc.com>
595 * src/modest-ui-dimming-rules.c: (_selected_folder_is_root):
596 Add a short-cut, by checking if the folder store is an account.
597 This ensures that the Sort menu item and toolbar is dimmed for
598 the local-folders account root item, fixing
599 projects.maemo.org bug NB#62545.
601 2007-07-12 Murray Cumming <murrayc@murrayc.com>
603 * src/modest-tny-account-store.c: (get_password):
604 Show the password dialog (via the signal) only in the mainloop, via
605 an idle handler that we wait for. This could theoretically prevent
606 hangs, though I worry that it could introduce some too.
608 2007-07-12 Murray Cumming <murrayc@murrayc.com>
610 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
611 * src/maemo/modest-platform.c:
612 (modest_platform_connect_and_wait):
613 Take a TnyAccount* parameter and try to set it to online
614 (a TnyCamel-only API), because tinymail sets accounts to offline
615 when the user cancels a password dialog, and doesn't ask again until
616 it has been set to online.
617 However, this is commented out because it causes a hang now.
619 (modest_platform_connect_and_wait_if_network_account):
620 * src/modest-mail-operation.c:
621 (modest_mail_operation_update_account):
622 * src/modest-platform.h:
623 * src/modest-ui-actions.c: (_modest_ui_actions_open),
624 (download_uncached_messages), (modest_ui_actions_on_send): Adapted.
626 2007-07-12 Armin Burgmeier <armin@openismus.com>
628 * src/modest-error.h: Added MODEST_MAIL_OPERATION_FOLDER_EXISTS error.
630 * src/modest-mail-operation.c:
631 * src/modest-ui-actions.c: Check for already existing folder before
632 querying the server, show error message from camel if the request
633 still fails. This fixes projects.maemo.org bug NB#58701.
635 2007-07-12 Murray Cumming <murrayc@murrayc.com>
637 * src/modest-tny-account-store.h:
638 * src/modest-tny-account-store.c:
639 Added modest_tny_account_store_forget_password_in_memory(),
640 (get_server_accounts): Called modest_tny_account_store_forget_password_in_memory()
641 when creating a new account, so that new passwords will be used, instead of
642 us thinking that it's a second request as a result of a failed password again.
644 2007-07-12 Murray Cumming <murrayc@murrayc.com>
646 * src/dbus_api/modest-dbus-callbacks.c:
647 (on_idle_open_message): If the message is in drafts then open it
648 in an edit window instead of a view window. This fixes
649 projects.maemo.org bug NB#63005.
651 2007-07-12 Murray Cumming <murrayc@murrayc.com>
653 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
654 Avoided a harmless g_warning().
656 2007-07-12 Murray Cumming <murrayc@murrayc.com>
658 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message),
659 Pass the modest account name, not the TnyAccount display name to
660 modest_msg_view_window_new() so that the reply feature works,
661 fixing projects.maemo.org bug NB#62892.
663 * src/gnome/modest-msg-view-window.c: (modest_msg_view_window_new),
664 (modest_msg_view_window_new_with_header_model):
665 * src/maemo/modest-msg-view-window.c:
666 (modest_msg_view_window_new_with_header_model),
667 (modest_msg_view_window_new):
668 * src/modest-ui-actions.c: (reply_forward):
669 * src/widgets/modest-msg-view-window.h:
670 * src/widgets/modest-window.c: (modest_window_set_active_account):
671 Rename an account parameter to modest_account_name to make this clearer.
673 2007-07-11 Murray Cumming <murrayc@murrayc.com>
675 * src/modest-ui-actions.h:
676 * src/modest-ui-actions.c: (headers_action_delete): Moved some code into
677 modest_do_message_delete().
678 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_delete_message):
679 Call modest_do_message_delete(), hoping that this would cause messages
680 to be really deleted from search instead of just marked with strike through.
681 Does not seem to help.
683 2007-07-11 Armin Burgmeier <armin@openismus.com>
685 * src/widgets/maemo-folder-view.c (modest_folder_view_on_map): Set
686 priv->reselect to FALSE prior to calling
687 modest_folder_view_select_first_inbox_or_local() to prevent endless
688 recursion and thus a crash on startup.
690 2007-07-11 Armin Burgmeier <armin@openismus.com>
692 * src/maemo/modest-account-settings-dialog.h: Include
693 <gtk/gtknotebook.h> to fix the build (at least for me).
695 * src/maemo/modest-platform.c (modest_platform_run_new_folder_dialog):
696 Use "New FolderN" as default suggested name if "New folder" already
697 exists, with N being the first free number, though never exceed "New
698 folder99" in which case we just fall back to "New Folder" even though
699 it already exists. This fixes projects.maemo.org bug NB#58663.
701 2007-07-11 Murray Cumming <murrayc@murrayc.com>
703 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
704 Do not use gtk_dialog_run() to avoid modality hang problems. This fixes
705 projects.maemo.org bug NB#62778.
707 2007-07-11 Murray Cumming <murrayc@murrayc.com>
709 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
710 Ignore the wrong (for now) secure-smtp setting in the presets -
711 just default to requiring secure authentication for SMTP, because
714 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
716 * src/widgets/modest-folder-view.c: (filter_row)
717 Do not show drafts folder (see UI specs)
719 2007-07-11 Johannes Schmid <johannes.schmid@openismus.com>
721 * src/modest-ui-actions.c:
722 Remove call to show_non_move_folders(TRUE) which was moved to a wrong
723 place and also not necessary.
725 * src/widgets/modest-folder-view.c: (filter_row)
726 Guess folder type and hide Sent & Outbox if necessary.
727 Fixed project.maemo.org NB#57328
729 2007-07-11 Murray Cumming <murrayc@murrayc.com>
731 * src/modest-ui-actions.h:
732 * src/modest-ui-actions.c:
733 (modest_ui_actions_on_delete_message):
734 Move some code into a new
735 modest_ui_actions_refresh_message_window_after_delete()
736 function so we can use it from elsewhere.
738 * src/dbus_api/modest-dbus-callbacks.c:
739 (on_idle_delete_message), (on_delete_message): Used an idle
740 handler, as we do for the other D-Bus method handlers.
741 Call modest_ui_actions_refresh_message_window_after_delete()
742 if the deleted message was open in a window. This fixed
743 projects.maemo.org bug NB#62862.
745 2007-07-11 Murray Cumming <murrayc@murrayc.com>
747 * src/modest-main.c: (main): Only show the UI at the start if
748 the showui command line option was given. For instance,
749 run-standalone src/modest showui
750 Otherwise, we wait for the top_application D-Bus method to
751 be sent by hildon-desktop when the application is selected
753 This allows us to run without a UI when osso-global-search
754 uses our D-Bus methods.
756 2007-07-11 Murray Cumming <murrayc@murrayc.com>
758 * src/dbus_api/modest-dbus-api.h: Added a define for a
759 top-application D-Bus method.
760 * src/dbus_api/modest-dbus-callbacks.c:
761 (on_top_application),
762 (modest_dbus_req_handler): Handle the top-application D-Bus
763 method, which might be an undocumented D-Bus signal sent by
764 hildon-desktop when it starts the application from the menu.
765 But I am not sure and I need to test it on the device, because
766 my scratchbox does not have the application in the menu now.
767 This method shows the main window, so that it can be invisible
768 when started, for instance, just for email searching from
771 * src/maemo/modest-main-window.c: (restore_settings),
772 (modest_main_window_new): Do not show the window immediately
773 upon creation. We show it later.
774 * src/modest-widget-memory.c: (save_settings_paned):
775 Try (unsuccessfully) to avoid saving the paned position when
776 it is not even visible.
777 (restore_settings_paned): Do not allow a silly paned position.
778 This seems necessary when not showing the window at first.
780 * tests/dbus_api/Makefile.am:
781 * tests/dbus_api/test_top_application.c: (main): Test for the
784 2007-07-10 Murray Cumming <murrayc@murrayc.com>
786 * src/modest-ui-dimming-rules.c:
787 (modest_ui_dimming_rules_on_new_msg),
788 (modest_ui_dimming_rules_on_reply_msg),
789 (modest_ui_dimming_rules_on_delete_msg),
790 (modest_ui_dimming_rules_on_details),
791 (modest_ui_dimming_rules_on_view_window_move_to),
792 (modest_ui_dimming_rules_on_view_previous),
793 (modest_ui_dimming_rules_on_view_next),
794 (_invalid_folder_for_purge): Added checks before
795 casting the window. This looks like an actual
796 logic error in _invalid_folder_for_purge(), because it
797 tries to use a ModestMainWindow as a message window.
799 2007-07-10 Murray Cumming <murrayc@murrayc.com>
801 * src/maemo/modest-account-settings-dialog.c:
802 (show_error): Use the same implementation as in
803 modest-easysetup-wizard.c:
804 (on_entry_invalid_character): The logical ID contains a %s.
805 Guessed what it should be.
806 (on_entry_max), (check_data), (on_response): Adapt to
807 changed show_error().
808 (create_page_account_details): Really call
809 modest_validating_entry_set_func() on the correct widgets.
810 * src/maemo/easysetup/modest-easysetup-wizard.c:
811 (on_entry_invalid_character): Fix the logical ID here too.
812 (create_page_account_details),
813 (create_page_user_details):
815 modest_validating_entry_set_func() on the correct widgets.
817 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
818 Do not try to use the account if it is NULL.
820 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
822 * src/modest-ui-actions.c: (create_move_to_dialog),
823 (modest_ui_actions_on_main_window_move_to),
824 (modest_ui_actions_on_msg_view_window_move_to):
825 * src/widgets/modest-folder-view.c: (modest_folder_view_init),
826 (filter_row), (modest_folder_view_show_non_move_folders):
827 * src/widgets/modest-folder-view.h:
829 Hide Sent & Outbox folder in "move to"-dialog. Does not work for
830 the Sent folder yet as it does not report the correct folder type.
832 2007-07-10 Johannes Schmid <johannes.schmid@openismus.com>
834 * src/maemo/modest-msg-edit-window.c: (init_window):
837 2007-07-10 Murray Cumming <murrayc@murrayc.com>
839 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
840 Take a parent widget instead of a parent window, and
841 implement this with hildon_banner_show_information() instead.
842 Non-Maemo builds can just ifdef that there.
843 This fixed projects.maemo.org bug NB#62766.
845 (on_entry_invalid_character): Use show_error() again instead
846 of using hildon directly, and use the _CS() macro to use the correct
848 (create_account), (check_for_supported_auth_methods), (on_entry_max):
849 Pass a widget instead od a window to show_error().
851 2007-07-10 Murray Cumming <murrayc@murrayc.com>
853 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
854 Adapt to the changed tinymail API, using the new TnyAccount* parameter.
855 This allows us to show the server name in the error message, fixing
856 projects.maemo.org bug NB#62904.
857 Also, use the appropriate logical ID message for the account protocol.
859 2007-07-10 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-tny-account-store.c: (on_idle_wrong_password):
862 A compilation fix, though the build wasn't broken for me.
864 2007-07-09 Murray Cumming <murrayc@murrayc.com>
866 * src/modest-ui-actions.c: (modest_ui_actions_on_send_receive):
867 Do not try to unref a NULL folder store, to avoid a runtime warning.
868 This seems to happen sometimes when changing accounts settings.
870 2007-07-09 Murray Cumming <murrayc@murrayc.com>
872 * src/modest-tny-account-store.c:
873 (modest_tny_account_store_instance_init),
874 (modest_tny_account_store_finalize),
875 (on_account_settings_hide), (on_idle_wrong_password):
876 Use a GHashTable to ensure that we only show one account settings
877 dialog per modest account. This avoids us having a dialog open for
878 both the store and transport accounts, or due to repeated get_password()
879 calls that shouldn't happen anyway.
881 2007-07-09 Murray Cumming <murrayc@murrayc.com>
883 * src/maemo/modest-maemo-utils.c: (on_hide),
884 (modest_maemo_show_dialog_and_forget): Handle the response, because
885 the window is not even hidden by default.
887 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
888 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts):
889 Use modest_maemo_show_dialog_and_forget() instead of gtk_dialog_run()
890 which seems to prevent some modality problems.
892 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
893 Ignore user cancellation errors.
895 * src/modest-account-mgr-helpers.h:
896 * src/modest-account-mgr-helpers.c:
897 Added modest_server_account_get_password() and
898 modest_server_account_get_has_password() to avoid direct use of
901 * src/maemo/modest-account-settings-dialog.h:
902 * src/maemo/modest-account-settings-dialog.c:
903 (modest_account_settings_dialog_init): Store the notebook so we can
905 Added modest_account_settings_dialog_switch_to_user_info().
907 * src/modest-tny-account-store.c:
908 (get_password): When the password in the account settings is wrong (we think),
909 show the relevant page of the account settings dialog, in the mainloop.
910 However, we currently get many of these at once because cancel does not
912 (forget_password): Do not forget the password
913 from the account settings, because this causes side-effects when
914 tinymail seems to call it at strange time, maybe because of how we
915 are cancelling get_password().
916 (modest_tny_account_store_alert): Ignore user cancellations.
918 2007-07-09 Murray Cumming <murrayc@murrayc.com>
920 * src/maemo/modest-maemo-utils.h:
921 * src/maemo/modest-maemo-utils.c:
922 Added modest_maemo_show_information_note_and_forget() for use instead of
923 gtk_dialog_run() when the response is not needed, to avoid an extra
924 mainloop which could cause a hang.
926 * src/maemo/modest-main-window.c: (on_sendqueue_error_happened):
927 Use the logical IDs for the error message, though they are not
928 specific enough. Note that I used modest_maemo_show_information_note_and_forget()
929 because gtk_dialog_run() caused a hang here (the window did not close).
930 This fixes projects.maemo.org bug NB#62646.
932 2007-07-09 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-account-mgr-helpers.h:
935 * src/modest-account-mgr-helpers.c:
936 Added modest_account_mgr_get_store_protocol().
938 * src/maemo/modest-account-view-window.c:
939 (on_delete_button_clicked): Show different warning text depending on
940 the protocol (IMAP or POP) as per the UI spec. Use a HildonNote instead
941 of a GtkDialog, which fixes the truncation, fixing projects.maemo.org bug
944 2007-07-09 Murray Cumming <murrayc@murrayc.com>
946 * src/maemo/modest-msg-edit-window.c:
947 (modest_msg_edit_window_attach_file): Set the file chooser dialog title
948 as per the UI spec. This fixes proejcts.maemo.org bug NB#59056.
950 2007-07-07 Armin Burgmeier <armin@openismus.com>
952 * src/maemo/easysetup/modest-easysetup-wizard.c: Translate
953 ckdg_ib_maximum_characters_reached from correct package.
955 * src/modest-ui-actions.c: Show an error message when a folder could
956 not be created. Tinymail does not give us specific error codes about
957 what has gone wrong, so we assume that a folder with that name
958 already exists, though there might be other reasons.
960 2007-07-06 Murray Cumming <murrayc@murrayc.com>
962 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
963 Use the new TNY_ACCOUNT_ERROR_TRY_CONNECT_CERTIFICATE error code to
964 give a more exact error message that can be partly translated.
966 2007-07-05 Murray Cumming <murrayc@murrayc.com>
968 * src/maemo/modest-address-book.c:
969 (select_email_addrs_for_contact): Specify a default window size for the
970 select-email-address dialog, so that it is probably big enough for the
971 title. This should fix projects.maemo.org bug NB#62277.
973 2007-07-05 Murray Cumming <murrayc@murrayc.com>
975 * src/maemo/easysetup/modest-easysetup-wizard.c:
976 (create_page_complete_easysetup): Use
977 gtk_widget_set_size() request to ensure that the text wraps
980 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
982 * src/maemo/easysetup/modest-easysetup-wizard.c:
983 (on_entry_invalid_character), (create_page_account_details),
984 (create_page_user_details):
985 Use new API of ModestValidatingEntry. But for some reason the banner is
986 not shown. I will have to investigate that further.
988 * src/widgets/modest-validating-entry.c: (on_insert_text),
989 (modest_validating_entry_set_func):
990 * src/widgets/modest-validating-entry.h:
991 Added a new callback function to be able to react to prevented
992 characters whitespaces to e.g show a banner.
994 2007-07-05 Armin Burgmeier <armin@openismus.com>
996 * src/maemo/modest-account-settings-dialog.c: Use the notify::value
997 notification of HildonNumberEditor instead of remembering the port
998 number. Thanks to Johannes for pointing this out.
1000 2007-07-05 Johannes Schmid <johannes.schmid@openismus.com>
1002 * src/maemo/easysetup/modest-easysetup-wizard.c:
1003 Check if there are any user changes before showing a confirmation
1004 dialog (projects.maemo.org NB#60946)
1006 2007-07-05 Armin Burgmeier <armin@openismus.com>
1008 * src/maemo/modest-account-settings-dialog.c: Remember custom port
1009 number at the beginning of the dialog and set the modified flag at the
1010 end if the port number has changed. This is necessary because
1011 HildonNumberEditor does not support notification when the value has
1014 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1016 * src/modest-ui-actions.c:
1017 (modest_ui_actions_on_main_window_move_to): Check whether the source folder needs
1018 a connection before asking anything else. Correct the check for the destination
1019 folder so that it succeeds when online.
1020 This fixed projects.maemo.org bug NB#61645.
1022 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1024 * src/modest-ui-actions.c: (modest_ui_actions_on_send):
1025 Call modest_platform_connect_and_wait() to ask for a connection if necessary,
1026 to fix projects.maemo.org bug NB#62439.
1028 2007-07-05 Murray Cumming <murrayc@murrayc.com>
1030 * src/modest-tny-account.c: (on_connection_status_changed):
1031 Really do not use tny_device_force_offline() here. See the previous comment.
1033 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1035 * src/modest-tny-account.c: (on_connection_status_changed):
1036 Do not use tny_device_force_offline() when tinymail says that something
1037 went wrong with the connection. It seems to report this unnecessarily.
1039 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1041 * src/maemo/modest-connection-specific-smtp-window.c:
1042 (modest_connection_specific_smtp_window_init):
1043 Use gtk_widget_set_size_request(), because gtk_label_set_max_width_chars()
1044 does not seem to have any effect in osso 1.1 (though it works in
1045 Maemo Bora). This fixes bug projects.maemo.org NB#59212.
1047 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1049 * src/maemo/modest-connection-specific-smtp-window.c:
1050 Fix UI specification problems with projects.meamo.org NB#60479
1052 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1054 * src/modest-ui-actions.c: (open_msg_cb): Add a printf() to provide a
1055 clue when this has failed, because the error dialog is not always shown
1056 (at least in earlier version).
1058 (modest_ui_actions_get_msgs_full_error_handler): prinf() the actual
1059 GError message, because the generic error dialog is not helpful.
1061 'This message is not currently available (can't let a new connection go online)'
1062 when trying to open an IMAP message.
1064 (_modest_ui_actions_open): Offer a connection when some messages would
1065 have to be downloaded and we are offline.
1067 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1069 * src/widgets/modest-folder-view.c:
1070 Don't check for MERGE type anymore as we use the correct type
1072 NOTE: For the last two changes you need to update your tinymail copy
1073 because of API changes!
1075 2007-07-04 Johannes Schmid <johannes.schmid@openismus.com>
1077 * src/modest-tny-local-folders-account.c:
1078 Set the folder type for the TnyMergeFolder to TNY_MERGE_FOLDER_OUTBOX
1079 (see projects.maemo.org NB#61580)
1081 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1083 * src/modest-tny-account.c: (on_connection_status_changed):
1084 Commented out the call to modest_platform_connect_and_wait() because this
1085 seems to always hang, and I would like to know if this is the only thing
1086 that causes a hang when showing the connection dialog.
1087 It is not very useful anyway.
1089 2007-07-04 Murray Cumming <murrayc@murrayc.com>
1091 * src/maemo/modest-msg-view-window.c:
1092 (modest_msg_view_window_select_next_message):
1094 * src/modest-platform.h:
1095 * src/maemo/modest-platform.c:
1096 Added modest_platform_connect_and_wait(), which calls
1097 tny_maemo_conic_device_connect() always in the main thread, by calling it
1098 in an idle handler and waiting for the idle handler to run. It should be
1099 in the main thread because it uses GTK+ UI code. It just returns TRUE
1100 if the device is already online.
1102 There is some nasty code to ensure that subsequent calls to
1103 modest_platform_connect_and_wait() just wait for the first one to finish,
1104 by checking repeatedly in another idle handler. This is necessary,
1105 because other threads (or even the main thread, via another idle handler)
1106 can call modest_platform_connect_and_wait() while
1107 modest_platform_connect_and_wait() is running.
1109 (modest_platform_connect_and_wait_if_network_account),
1110 (modest_platform_connect_and_wait_if_network_folderstore):
1111 Convenience functions that calls modest_platform_connect_and_wait() if
1112 the account or folder might want network access.
1114 * src/modest-mail-operation.c:
1115 (modest_mail_operation_update_account):
1116 * src/modest-ui-actions.c: (download_uncached_messages),
1117 (modest_ui_actions_on_rename_folder), (delete_folder),
1118 (modest_ui_actions_on_main_window_move_to),
1119 (modest_ui_actions_on_msg_view_window_move_to):
1120 * src/widgets/modest-folder-view.c:
1121 (drag_and_drop_from_folder_view):
1122 Offer a connection if we are offline.
1124 * src/modest-tny-account.c: (on_connection_status_changed):
1125 Document this as only handling errors during network operations in progress,
1126 and replace the idle code with a simple call to
1127 modest_platform_connect_and_wait(), which does this instead.
1129 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1131 * src/modest-tny-account.c:
1132 (modest_tny_account_get_special_folder): (util_on_idle),
1133 Handle the GError so we can see when tny_folder_store_get_folders()
1134 fails, as it currently does while something else is connecting.
1136 Added util_run_in_main_thread_and_wait()
1137 which uses an idlen handler and mainloop to ensure that the function
1138 is called in the main thread.
1139 (on_connection_status_changed): Use util_run_in_main_thread_and_wait()
1140 to make sure that we call attempt the connection in the mainloop only,
1141 which might solve some hangs.
1143 2007-07-03 Murray Cumming <murrayc@murrayc.com>
1145 (modest_tny_account_store_get_tny_account_by): Do not allow accounts to
1146 be found by their display name. This is never useful.
1147 * src/modest-tny-account-store.c: (on_account_removed): Find the account
1148 by its ID, instead of trying to use its ID as its display name.
1150 * src/modest-tny-account-store.h:
1151 * src/modest-tny-account.c:
1152 (modest_tny_account_get_special_folder): Add a g_warning() when
1153 tny_folder_store_get_folders() returns an empty list for the maildir.
1155 * src/modest-tny-send-queue.c: (modest_tny_send_queue_get_outbox):
1156 Add a g_warning() when this returns NULL, because that it not allowed
1159 2007-07-02 Armin Burgmeier <armin@openismus.com>
1161 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a confirmation
1162 note when trying to cancel the wizard. This fixes projects.maemo.org
1165 2007-07-02 Murray Cumming <murrayc@murrayc.com>
1167 * src/modest-tny-account.h:
1168 * src/modest-tny-account.c:
1169 (modest_tny_account_new_from_server_account),
1170 (modest_tny_account_new_from_server_account_name),
1171 (modest_tny_account_new_from_account): Added a TnyCamelSession parameter,
1172 because this must now be set before setting the proto. This is usd in
1173 modest_tny_account_new_from_server_account(). It avoids a (maybe harmless)
1174 warning in camel_session_get_service() caused by
1175 tny_camel_transport_account_prepare().
1177 * src/modest-tny-account-store.c: (get_server_accounts): Pass the new
1180 2007-06-30 Johannes Schmid <johannes.schmid@openismus.com>
1182 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1184 (modest_connection_specific_smtp_edit_window_init):
1186 Fixed project.maemo.org bug NB#60479 by using "notify::value" instead
1187 of "changed" for now
1189 2007-06-29 Murray Cumming <murrayc@murrayc.com>
1191 * src/modest-tny-account.c:
1192 (modest_tny_account_new_from_server_account):
1193 Handle the TnyAccount::"connection-status-changed" signal, which tinymail
1194 now uses to request a connection when it needs one, and which it uses
1195 to tell us that something is wrong with the connection, so we can force
1196 the accounts offline to prevent further problems.
1198 * src/modest-defs.h:
1199 * src/modest-init.c: (init_default_settings):
1200 * src/modest-mail-operation.c:
1201 (modest_mail_operation_update_account):
1202 * src/modest-main.c: (on_show): Do not try to connect explicitly on startup.
1203 This should not be necessary anymore. Do not set the conf key that
1204 determined this (it was always TRUE and not set anywhere else).
1206 * src/modest-ui-actions.h: Remove unused and unimplemented
1207 modest_ui_actions_on_online_toggle_toggled().
1209 2007-06-29 Murray Cumming <murrayc@murrayc.com
1211 * src/maemo/modest-main-window.c: (connect_signals):
1212 Don't connect to delete_event twice. Maybe this was harmless.
1214 2007-06-29 Murray Cumming <murrayc@murrayc.com
1216 * libmodest-dbus-client/libmodest-dbus-client.c: Improved the documentation slightly.
1217 * src/modest-mail-operation.c: (modest_mail_operation_xfer_folder):
1218 Debug output to give some more clue when a folder move is not allowed.
1220 2007-06-28 Murray Cumming <murrayc@murrayc.com
1222 * src/modest-tny-account.c: (on_modest_file_system_info),
1223 (modest_tny_account_get_mmc_account_name):
1224 Always call the callback, without checking whether the name has changed.
1225 * src/widgets/modest-folder-view.c: (strings_are_equal),
1226 (on_model_foreach_set_name), (on_get_mmc_account_name),
1227 (text_cell_data): Compare the name here, and use the name from
1228 the account rather than from the
1229 TNY_GTK_FOLDER_STORE_TREE_MODEL_NAME_COLUMN because that will be wrong
1230 if the name was changed after the account was added to the model.
1231 That's a tinymail bug but not one that I want to fix now.
1233 This finally fixes projects.maemo.org bug NB#59301.
1235 2007-06-27 Armin Burgmeier <armin@openismus.com>
1237 * src/modest-mail-operation.c: Fixed a crash when canceling a mail
1240 2007-06-27 Murray Cumming <murrayc@murrayc.com
1242 * src/modest-tny-account.h:
1243 * src/modest-tny-account.c:
1244 Added modest_tny_account_get_mmc_account_name(), to set the memory
1245 card name asynchronously for the given account and then notify.
1246 (modest_tny_account_new_for_local_folders): Use this new function instead
1247 of using hildon_file_system_info_async_new() directly.
1249 * src/widgets/modest-folder-view.c: (text_cell_data):
1250 Use modest_tny_account_get_mmc_account_name() to get the real name, calling
1251 gtk_tree_model_row_changed() when it is available.
1253 This should fix projects.maemo.org bug NB#59301.
1255 2007-06-27 Murray Cumming <murrayc@murrayc.com
1257 * src/modest-mail-operation.c: (update_account_thread),
1258 (get_msgs_full_thread): Fix typo failures in the revert
1261 2007-06-27 Murray Cumming <murrayc@murrayc.com
1263 * src/maemo/modest-maemo-global-settings-dialog.c:
1264 (idle_select_default_focus):
1265 * src/modest-mail-operation.c: (idle_notify_progress),
1266 (idle_notify_progress_once), (set_last_updated_idle),
1267 (update_account_thread), (get_msgs_full_thread):
1268 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1269 * src/widgets/modest-header-view.c:
1270 (idle_notify_headers_count_changed_destroy),
1271 (idle_notify_headers_count_changed):
1272 Reverted the additions of gdk_threads_enter/leave(), in case this
1273 helps with a startup hang on the device.
1275 2007-06-26 Armin Burgmeier <armin@openismus.com>
1277 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
1278 for supported secure authentication methods from server by
1279 gtk_dialog_run(), saving CPU time and a potential race condition.
1281 2007-06-26 Armin Burgmeier <armin@openismus.com>
1283 * src/maemo/modest-maemo-utils.h:
1284 * src/maemo/modest-maemo-utils.c: Added a
1285 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
1286 only error code to tell the calling code when the user canceled the
1289 * src/maemo/modest-account-settings-dialog.h:
1290 * src/maemo/modest-account-settings-dialog.c:
1291 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
1292 message if the retrieval of secure authentication methods was canceled
1293 by the user. Perform the check before saving anything to configuration
1294 to not end up with half-committed configuration changes, do not show
1295 a "Saving to configuration failed" note when authentication methods
1296 could not be retrieved.
1298 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
1301 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1303 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1304 Only return the first level of folders under accounts, because the
1305 osso-global-search UI spec doesn't want the rest.
1306 This fixed projects.maemo.org bug NB#61811.
1308 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1310 * src/modest-tny-account-store.c:
1311 * src/modest-tny-account-store.h:
1312 Added modest_tny_account_is_memory_card_account().
1313 * src/maemo/modest-main-window.c: (create_details_widget):
1314 Show the same information items for the memory card as we show for the
1315 local-folders, to fix projects.maemo.org bug NB#59307.
1317 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1319 * src/modest-tny-account-store.c: (get_password):
1320 Added some checks for NULL to maybe prevent crashes, though I think
1321 it was Philip's last commit that actually prevented the crash here
1322 when creating a first new account.
1323 But the new account is still not usable (no messages are shown)
1324 until a restart of the application.
1326 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/modest-maemo-global-settings-dialog.c:
1329 (idle_select_default_focus):
1330 * src/modest-mail-operation.c: (idle_notify_progress),
1331 (idle_notify_progress_once), (idle_notify_update_account_queue),
1332 (set_last_updated_idle), (update_account_thread),
1333 (notify_get_msgs_full), (get_msgs_full_destroyer),
1334 (get_msgs_full_thread):
1335 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
1336 * src/widgets/modest-header-view.c:
1337 (idle_notify_headers_count_changed_destroy),
1338 (idle_notify_headers_count_changed):
1339 Use gdk_threads_enter() and gdk_threads_enter_leave() in
1340 all idle handlers, because some other thread could be blocking
1341 the GDK lock, so that it can do GUI stuff.
1343 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1345 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
1346 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
1347 (on_idle_send_receive), (on_idle_open_default_inbox):
1348 * src/maemo/modest-msg-edit-window.c:
1349 (modest_msg_edit_window_attach_file_noninteractive):
1350 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
1351 to prevent a hang. I don't quite understand why these are necessary,
1352 beause we should already be in the main loop. I guess something outside
1353 of the main loop is taking the lock.
1355 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
1356 we are really using URIs, and use files that are more likely to exist.
1358 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1360 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
1361 necessary because configure.ac now defines different variables.
1363 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1365 * libmodest-dbus-client/libmodest-dbus-client.c:
1366 * libmodest-dbus-client/libmodest-dbus-client.h:
1367 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
1368 libmodest_dbus_client_compose_mail() is what things actually use.
1370 * src/dbus_api/modest-dbus-api.h:
1371 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
1372 * tests/dbus_api/Makefile.am:
1373 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
1376 2007-06-26 Murray Cumming <murrayc@murrayc.com>
1378 * src/modest-init.c: (modest_init_local_folders):
1379 For memory-card (or other non local-folders) maildir accounts,
1380 always create an Archive folder, so that there is somewhere to put
1381 messages. This should be less confusing, because the user does not need
1382 to guess that the need to create a folder.
1384 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1386 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1387 Fixed icon size by using (50, 50) which is the same as defined by
1390 2007-06-25 Armin Burgmeier <armin@openismus.com>
1392 * src/widgets/modest-window-mgr.c:
1393 * src/modest-init.c:
1394 * configure.ac: Correctly recognize hildon-notify presence and fixed
1395 the build without it being installed.
1397 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1399 * libmodest-dbus-client/libmodest-dbus-client.c:
1400 (libmodest_dbus_client_search): Fix the build. Sorry.
1401 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
1402 (reply_forward_cb): Initialize variables to fix the build.
1404 * src/modest-tny-account-store.c:
1405 (modest_tny_account_store_get_tny_account_by): Fix the account URI
1406 comparison (a silly typo) so that email search results can be opened
1407 when there are more than one account.
1409 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1411 * libmodest-dbus-client/libmodest-dbus-client.c:
1412 (libmodest_dbus_client_search),
1413 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
1414 instead of 1 second, because the search gets folders and messages from
1415 the server, which can take a long time. When it times out,
1416 osso-global-search will report no results.
1418 We need to specify whether we should search only cached information
1419 (maybe with a user preference), and the osso-email-search-plugin
1420 API should really be improved to allow that option, and to allow results
1421 to be delivered asynchronously in batches.
1423 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1425 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1426 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
1427 GTK_ICON_SIZE_DIALOG is probably the wrong size.
1429 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1431 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
1432 that is an empty string. D-Bus seems to give us these instead of NULL.
1434 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
1436 * src/dbus_api/modest-dbus-callbacks.c:
1437 * src/maemo/easysetup/modest-easysetup-wizard.h:
1438 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
1439 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1440 (modest_connection_specific_smtp_edit_window_init):
1441 * src/maemo/modest-maemo-global-settings-dialog.c:
1443 * src/maemo/modest-maemo-utils.c:
1444 (modest_maemo_utils_setup_images_filechooser):
1445 * src/maemo/modest-main-window.c: (create_details_widget):
1446 * src/maemo/modest-msg-edit-window.c:
1447 (modest_msg_edit_window_attach_file_noninteractive),
1448 (modest_msg_edit_window_color_button_change),
1449 (modest_msg_edit_window_set_zoom):
1450 * src/modest-mail-operation.c: (update_account_thread):
1451 * src/modest-tny-account-store.c:
1452 * src/modest-tny-account.c:
1453 * src/widgets/modest-global-settings-dialog.c:
1454 * src/widgets/modest-window.h:
1456 Fixed build on bora!
1458 2007-06-25 Murray Cumming <murrayc@murrayc.com>
1460 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
1461 * src/modest-search.c: (modest_search_folder),
1462 (modest_search_all_accounts): Actually search only in the specified folder,
1463 doing a simple match on the folder ID.
1464 * src/modest-search.h: Added a folder field to the ModestSearch struct,
1465 and added some documentation.
1467 2007-06-22 Armin Burgmeier <armin@openismus.com>
1469 * src/maemo/modest-maemo-utils.h:
1470 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
1471 modest_maemo_utils_get_supported_secure_authentication_methods.
1473 * src/maemo/easysetup/modest-easysetup-wizard.c:
1474 * src/maemo/modest-account-settings-dialog.c: Show correct error if
1475 one occured, not just "Server does not support secure authentication".
1477 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1479 * src/modest-tny-account-store.c: (get_password):
1480 Restored the call to tny_account_set_user() because Philip seems to have
1481 stopped this from crashing (by not using the freed string). It still does
1482 not work, but now we can test it.
1484 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1486 * src/maemo/modest-msg-edit-window.c: (init_window):
1487 Comment out use of an uninitialzed GtkScrolledWindow variable,
1488 to fix the build and stop a crash. Yet again.
1490 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1492 * src/modest-tny-account-store.c: (get_password):
1493 Remove the call to tny_account_set_user() because this actually crashes.
1494 As mentioned in the last commit, it is known to not work anyway.
1496 2007-06-22 Murray Cumming <murrayc@murrayc.com>
1498 * src/modest-tny-account-store.c: (get_password):
1499 Use tny_account_set_username() to tell tinymail that the username might
1500 have changed too. But tinymail ignores this: see projects.maemo.org
1502 * src/modest-ui-actions.c:
1503 (modest_ui_actions_on_password_requested): Remove the useless attempt to
1504 reset the connection when changing the username, and improve the comments.
1505 Save the changed username to gconf at least, so it is used when Modest is
1508 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1510 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
1511 Do not use a query, so that we get all folders, including for POP and
1512 local-folders. They work as search criteria too.
1513 This fixes projects.maemo.org bug NB#57740.
1515 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1517 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1518 Comment out the use of hildon_notification_set_sound() because it is
1519 not declared, to fix the build. Warnings are serious, people.
1521 2007-06-21 Armin Burgmeier <armin@openismus.com>
1523 * src/maemo/modest-maemo-utils.h:
1524 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
1525 modest_maemo_utils_get_supported_secure_authentication_methods()
1526 to query authentication methods for a specific user. This should fix
1527 projects.maemo.org bug NB#61369.
1529 * src/maemo/easysetup/modest-easysetup-wizard.c:
1530 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
1533 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1535 * libmodest-dbus-client/libmodest-dbus-client.h:
1536 * libmodest-dbus-client/libmodest-dbus-client.c:
1537 (modest_dbus_message_iter_get_search_hit),
1538 (libmodest_dbus_client_search):
1539 Reorganised and commented this.
1540 Removed modest_search_hit_free() from the public API because it
1543 Added libmodest_dbus_client_get_folders() and
1544 modest_folder_result_list_free().
1546 * src/dbus_api/modest-dbus-api.h:
1547 * src/dbus_api/modest-dbus-callbacks.c:
1548 (modest_dbus_req_filter): Commented. Moved most code to
1549 on_dbus_method_search() and added on_dbus_method_get_folders().
1551 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
1552 of the extra D-Bus handler.
1554 * tests/dbus_api/Makefile.am:
1555 * tests/dbus_api/test_get_folders.c: New test for
1556 libmodest_dbus_client_get_folders(). This seems to return an empty list
1557 at the moment. That could be the same error that causes the message list
1558 to be empty sometimes.
1559 This should help with projects.maemo.org bug NB#57740.
1561 2007-06-21 Armin Burgmeier <armin@openismus.com>
1563 * src/modest-mail-operation.c: Do not call
1564 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
1565 notify the operation's end after having set the status to CANCELED for
1566 the operation queue to listen on. This fixes a deadlock when there
1567 were mail operations in the queue during its finalization.
1569 * src/modest-singletons.c: Reordered uninitialization of the account
1570 manager to happen after the mail operation queue was uninitialized
1571 because the mail operation's in the queue might still try to access
1572 the account manager (see modest_mail_operation_notify_end()). This
1573 fixes a potential crash when terminating the application.
1575 2007-06-21 Murray Cumming <murrayc@murrayc.com>
1577 * src/modest-search.c:
1578 (search_mime_part_and_child_parts): Moved some code here so we
1579 can search recursively in child folders.
1580 (modest_search_folder): Search in the message as a mime part, instead
1581 of just its child mime parts.
1582 (read_chunk), (search_mime_part_ogs):
1583 Check how many bytes were read, to prevent an endless loop.
1584 Searching in message bodies now works. This finishes the fix for
1585 projects.maemo.org bug NB#61007.
1587 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1589 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
1590 Add a g_warning when the item is not a folder.
1592 * src/modest-ui-dimming-rules.c:
1593 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
1594 when selected item is not a folder (for instance, an account), because
1595 the UI spec only talks about folders.
1596 I am not sure what the UI spec wants, so this might not totally fix
1597 projects.maemo.org bug NB#60794.
1599 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1601 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1602 (load_from_file): Sort the list. The unsorted list would be more noticeable
1603 in non-English locales.
1605 * src/maemo/modest-msg-edit-window.c:
1606 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
1607 warning and fix the build.
1609 * src/maemo/modest-progress-bar-widget.c:
1610 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
1611 avoid a g_warning, and probably to avoid a crash.
1613 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1615 * src/modest-search.c: (modest_search_folder): Check for a GError
1616 when calling tny_folder_get_headers(), to show that this is not the cause
1619 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1621 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1622 Actually set the body query instead of the subject query.
1624 * src/modest-search.c: (search_mime_part_ogs),
1625 (search_mime_part_strcmp): Remove extra space from the text/* regex,
1626 which would probably cause it to fail if we got this far.
1628 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
1629 to simplify the code.
1630 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
1631 be causing search-in-body to fail.
1633 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1635 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
1637 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
1638 Better debug message when the folder cannot be found.
1639 This should help with fixing projects.maemo.org bug #61287.
1640 * src/modest-search.c: (add_hit): Do not leak the furl string.
1642 2007-06-20 Murray Cumming <murrayc@murrayc.com>
1644 * src/modest-ui-actions.c:
1645 (modest_ui_actions_on_folder_selection_changed):
1646 Do not special-case TNY_MERGE_FOLDER here, because
1647 modest_tny_folder_get_account() already does that. This fixes
1648 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
1649 shown when the Outbox was selected).
1651 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
1653 * libmodest-dbus-client/libmodest-dbus-client.c:
1654 (_dbus_iter_get_string_or_null): Initialize the string variable in
1655 case this helps with Dirk's crash.
1657 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1659 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
1660 though it is not implemented yet (this function is maybe not even used),
1661 to avoid breaking ABI in future.
1662 * libmodest-dbus-client/libmodest-dbus-client.c:
1663 (get_attachments_string): Moved some code into this generic function.
1664 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
1665 sends email. It is maybe not used.
1666 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1667 (on_send_mail): Use attachments.
1669 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
1670 * src/maemo/modest-msg-edit-window.c:
1671 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
1672 a filename before using it, to fix projects.maemo.org bug NB#58233.
1674 2007-06-19 Murray Cumming <murrayc@murrayc.com>
1676 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
1677 Initialize the continue_download variable to fix the build, and probably
1678 to fix randome behaviour.
1680 2007-06-18 Armin Burgmeier <armin@openismus.com>
1682 * src/modest-tny-send-queue.h:
1683 * src/modest-tny-send-queue.c: Keep track of the status of messages in
1684 the queue so we can later show it in the UI. Replaced
1685 modest_tny_send_queue_msg_is_being_sent() by
1686 modest_tny_send_queue_get_msg_status().
1688 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
1690 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
1691 gpointer. This probably was not harmful, but just to be sure.
1693 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1695 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
1696 Fix the build, but leave the function broken on Bora, because
1697 hildon_uri_action_get_service() does not exist.
1698 osso_uri_action_get_service() does not exist either, it seems.
1700 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1702 * src/modest-tny-account.c:
1703 (modest_tny_account_new_from_server_account):
1704 Uncommented the url debug output again, because it is useful for
1705 debugging, as I said in the comment.
1707 2007-06-18 Murray Cumming <murrayc@murrayc.com>
1709 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
1711 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
1712 for Mameo Bora, to fix the build.
1714 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
1717 Fixed build with hildon < 0.99
1719 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1720 Check if the selected account is busy instead of checking all accounts
1722 * src/modest-account-mgr-priv.h:
1723 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
1724 (modest_account_mgr_init), (compare_account_name),
1725 (modest_account_mgr_set_account_busy),
1726 (modest_account_mgr_account_is_busy):
1727 * src/modest-account-mgr.h:
1728 Added busy information to the account manager. It possible to
1729 set an account to busy or not busy now.
1731 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
1732 (modest_mail_operation_update_account),
1733 (modest_mail_operation_notify_end):
1734 Set the account to busy/not busy depending on the operation state.
1736 * src/widgets/modest-account-view.c:
1737 (modest_account_view_finalize), (get_last_updated_string),
1738 (update_account_view), (on_account_busy_changed), (init_view):
1739 Show string "Refreshing..." if the account is currently busy.
1741 All this fixes projects.maemo.org bug NB#59711
1743 2007-06-14 Armin Burgmeier <armin@openismus.com>
1745 * src/widgets/modest-attachments-view.h:
1746 * src/widgets/modest-attachments-view.c: Added
1747 modest_attachments_view_has_attachments() and fixed coordinate
1748 transformation in get_att_view_at_coords(). This fixes attachment
1751 * src/widgets/modest-msg-view.c: Make use of
1752 modest_attachments_view_has_attachments() to decide whether to show
1753 attachments in the header.
1755 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
1757 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1758 (on_change), (on_combo_security_changed),
1759 (modest_connection_specific_smtp_edit_window_init),
1760 (modest_connection_specific_smtp_edit_window_set_connection),
1761 (modest_connection_specific_smtp_edit_window_is_dirty):
1762 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1763 * src/maemo/modest-connection-specific-smtp-window.c:
1766 Show an comfirmation dialog for the smpt-edit-window if there are
1767 unsaved changes and the user hits cancel.
1768 (projects.maemo.org bug NB#60479)
1770 2007-06-14 Armin Burgmeier <armin@openismus.com>
1772 * src/maemo/easysetup/modest-easysetup-wizard.c:
1773 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
1774 address" info in banner instead of node, and select all the text as
1775 per UI spec. This fixes projects.maemo.org bug NB#60550.
1777 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
1779 reviewed by: <delete if not using a buddy>
1781 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
1782 * src/modest-ui-actions.c: (folder_refreshed_cb):
1784 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1786 * src/widgets/modest-folder-view.c: (filter_row):
1787 Explictly filter out the per-account outbox accounts. I don't know why
1788 these only sometimes show up, but now they should never show up in the UI.
1789 This should fix projects.maemo.org bug NB#60160.
1791 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1793 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
1794 when the toolbar does not exist yet.
1795 * src/modest-widget-memory.c: (save_settings_header_view):
1796 Added g_warnings() to help us to discover when we are trying to set
1797 an empty columns list in gconf.
1799 2007-06-14 Murray Cumming <murrayc@murrayc.com>
1801 * src/modest-init.h:
1802 * src/modest-init.c:
1803 Added modest_init_get_default_header_view_column_ids().
1805 * src/modest-widget-memory.c: (restore_settings_header_view):
1806 Use the new function to get defaults, if the gconf key is empty,
1807 instead of not creating any columns. This seems to fix the
1808 empty right-hand pane problems.
1810 * src/widgets/modest-header-view.h: Improved documentation.
1812 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1814 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1815 Revert the use of the display name as the account name, because this
1816 is generally wrong and would break the code that follows.
1818 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1820 * src/maemo/easysetup/modest-easysetup-wizard.c:
1821 (check_for_supported_auth_methods), (on_before_next),
1824 More correct fix for projects.maemo.org bug NB# 58991
1825 Do not longer accept AUTH_PASSWORD as secure method and choose
1826 correct method when creating the account.
1828 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
1830 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1831 Fixed projects.maemo.org bug NB# 58991
1833 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-init.c: (modest_init_init_core),
1836 (modest_init_local_folders): Fixed compilation errors.
1838 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1840 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1841 Remove unnecessary lib/include, though it is good in principle when needed.
1843 * src/modest-init.c: (modest_init_one_local_folder),
1844 (modest_init_local_folders):
1845 * src/modest-init.h: Initialize the .modest library for memory cards,
1846 instead of just doing nothing for them. This should allow us to create
1847 folders there, fixing projects.maemo.org bug NB#59297.
1849 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1851 * libmodest-dbus-client/libmodest-dbus-client.c:
1852 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
1853 (libmodest_dbus_client_compose_mail),
1854 (libmodest_dbus_client_open_message),
1855 (libmodest_dbus_client_send_and_receive),
1856 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
1858 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
1859 (on_idle_open_message), (modest_dbus_req_handler),
1860 (search_result_to_message), (modest_dbus_req_filter):
1861 * src/modest-search.c: (add_hit), (modest_search_folder),
1862 (modest_search_all_accounts): Improved debug messages.
1864 * tests/dbus_api/test_open_message.c: (main): Improved comments.
1866 * src/modest-tny-account-store.c:
1867 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
1870 2007-06-13 Murray Cumming <murrayc@murrayc.com>
1873 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1875 * src/modest-tny-account-store.c: (get_server_accounts):
1876 Call modest_tny_local_folders_account_add_merged_outbox_folders()
1877 even when there are no accounts, so that the Outbox folder is always
1878 visible. This fixes projects.maemo.org bug NB#60158.
1880 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1882 * src/maemo/modest-main-window.c: (create_details_widget):
1883 Use the mcen_va_never logical ID.
1885 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1887 * src/dbus_api/modest-dbus-api.h:
1888 * src/dbus_api/modest-dbus-callbacks.c:
1889 (on_idle_open_default_inbox), (on_open_default_inbox),
1890 (modest_dbus_req_handler):
1891 Added a new OpenDefaultInbox method.
1893 * libmodest-dbus-client/libmodest-dbus-client.h:
1894 * libmodest-dbus-client/libmodest-dbus-client.c:
1895 Added libmodest_dbus_client_open_default_inbox() to call the new
1896 dbus method. This should be useful to projects.maemo.org bug NB#57214,
1897 though it should maybe be used by a new osso-email-interface function.
1899 * tests/dbus_api/Makefile.am:
1900 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
1903 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1905 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
1906 NULL, so that the signals get all the keys. This should not actually
1907 change any behaviour because we currently update everything when anything
1910 2007-06-12 Murray Cumming <murrayc@murrayc.com>
1912 * src/widgets/modest-folder-view.c: (text_cell_data),
1913 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
1914 (find_inbox_iter): If tinymail tells us that the folder is
1915 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
1916 This causes the inbox to be selected at startup, fixing part of
1917 projects.maemo.org bug NB#56305.
1919 * src/modest-ui-dimming-rules.c:
1920 (modest_ui_dimming_rules_on_tools_smtp_servers):
1921 * src/modest-ui-dimming-rules.h: Added a callback function to dim
1922 the SMTP servers menu item.
1923 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
1924 that the SMTP Servers menu item is dimmed when there are no accounts,
1925 as a future version of the UI spec will require. This fixes
1926 projects.maemo.org bug NB#56305.
1928 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
1930 * src/maemo/modest-maemo-utils.c:
1931 (modest_maemo_utils_get_supported_secure_authentication_methods):
1932 Added label to dialog instead of unreadable title
1934 * src/maemo/modest-main-window.c: (sync_accounts_cb),
1935 (modest_main_window_new):
1936 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
1939 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
1940 * src/modest-account-mgr.h:
1941 Added method to avoid code duplication
1943 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1944 (modest_ui_actions_on_send_receive):
1945 Use modest_account_mgr_has_accounts
1947 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1949 * src/maemo/easysetup/modest-presets.c:
1950 (modest_presets_get_info_server_security): Do not report secure auth
1952 * src/modest-protocol-info.c: Use the defines for the gconf key names
1953 for secure authentication. This was not working because we were writing
1954 Password and reading password, and the check was case sensitive.
1955 With this, gmail now works for receiving and sending when created via
1958 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1960 * src/maemo/easysetup/modest-presets.c:
1961 (modest_presets_get_info_server_security): Correct the key name for
1962 SecureSmtp, because it seems to be case-sensitive.
1963 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1964 Do not try to get the 0th notebook page if there are 0 pages, to
1965 avoid a g_warning().
1967 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1969 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
1970 Prevent use of the new notification feature for now, because it currently
1971 shows one dialog for each new email, which is annoying.
1973 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1975 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1976 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
1977 when no country was selected, so that we show the global ones.
1978 * src/maemo/easysetup/modest-presets.c:
1979 (modest_presets_get_providers): Return only the global providers, not
1980 all providers when mmc=0 was requested.
1982 2007-06-11 Murray Cumming <murrayc@murrayc.com>
1984 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
1985 (easysetup_provider_combo_box_fill): Remove debug code that showed the
1986 provider ID in the combo.
1988 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
1989 Do not show the page numbers, because it would be confusing when we add
1990 the 2 extra pages for the custom setup, when the user chooses the "Other"
1991 provider. This fixes projects.maemo.org bug NB#59028
1993 * src/modest-init.c: (modest_init_init_core),
1994 (modest_init_local_folders):
1995 * src/modest-init.h:
1996 * src/modest-tny-account.c:
1997 (modest_tny_account_new_for_local_folders): Do not create default folders
1998 for the memory card. This should fix projects.maemo.org bug NB#59328.
2000 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2002 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
2003 Free the changed_conf_keys string items. They are already freed in the
2004 idle handler if that runs first.
2006 2007-06-11 Murray Cumming <murrayc@murrayc.com>
2008 * src/modest-ui-actions.c:
2009 (modest_ui_actions_on_password_requested): Check that the server name
2010 is not NULL, because I just saw a password dialog with (null) as the
2013 * src/modest-tny-folder.[h|c]: Added
2014 modest_tny_folder_is_memory_card_folder().
2015 * src/modest-ui-dimming-rules.c:
2016 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
2017 menu item for memory cards, as per the UI spec (section 7.4). This should
2018 fix projects.maemo.org bug NB#59297.
2020 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
2022 * src/maemo/modest-main-window.c: (sync_accounts_cb):
2023 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
2024 is another problem with the code, see Murray's comment at line 772)
2026 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
2029 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2030 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
2031 (load_from_file), (easysetup_country_combo_box_init),
2032 (easysetup_country_combo_box_get_active_country_ids),
2033 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
2034 instead of just one ID, to avoid duplicate country names in the UI.
2036 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
2037 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
2038 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
2039 a single ID, avoiding duplicate providers.
2040 * src/maemo/easysetup/modest-easysetup-wizard.c:
2041 (on_combo_account_country): Adapt to use a list.
2043 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2045 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
2046 keys changed in the last X seconds.
2048 * src/modest-account-mgr.h:
2049 * src/modest-account-mgr.c: (on_timeout_notify_changes),
2050 (on_key_change), (modest_account_mgr_class_init),
2051 (modest_account_mgr_init), (modest_account_mgr_finalize):
2052 As the keys are changed, save them in a GSList* and signal that GSList*
2053 further every X seconds, to batch changes, to allow us to do just one
2054 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
2055 bug NB#56941 and other (UI-blocking) delays when changing account settings.
2057 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
2058 changed signal signature.
2060 * src/modest-conf.c: (modest_conf_set_list),
2061 (modest_conf_on_change): Reenable notification.
2063 (modest_conf_maemo_fake_on_change): Comment out the hack that
2064 notified immediately instead of asynchronously.
2066 * src/widgets/modest-account-view.h:
2067 * src/widgets/modest-account-view.c:
2068 (update_account_view): Select the previously-selected account ID,
2069 if possible. This fixes projects.maemo.org bug NB#56933.
2071 (on_account_changed), (on_account_removed),
2072 (modest_account_view_select_account):
2074 Remove the block/unblock functions
2075 because they were not useful.
2077 * src/maemo/modest-account-view-window.c:
2078 (on_delete_button_clicked), (on_edit_button_clicked),
2079 (on_new_button_clicked): Remove the use of the non-working block/unblock.
2081 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2083 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2084 Improve the error dialog to show Incorrect Account Settings, which seems
2085 clearer, and say that the internal error message (to be removed from the
2086 dialog later) is often misleading.
2087 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
2089 * src/modest-tny-account.c:
2090 (modest_tny_account_new_from_server_account): Uncomment the printf of the
2091 URL because this is so useful for debugging on the device.
2093 * src/widgets/modest-serversecurity-combo-box.c:
2094 (modest_serversecurity_combo_box_fill): Correct a logical ID.
2096 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2098 * src/modest-mail-operation.c:
2099 (modest_mail_operation_send_new_mail):
2100 Added a comment about a nasty but apparently harmless message. Details
2101 added to the wiki g_warnings() page.
2103 2007-06-08 Murray Cumming <murrayc@murrayc.com>
2105 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
2106 (modest_tny_send_queue_class_init):
2107 Do not use the priv struct because it is empty, to avoid g_warnings
2108 about a non-existant priv struct.
2110 * src/modest-tny-account-store.c:
2111 (modest_tny_account_store_get_server_account),
2112 (modest_tny_account_store_get_transport_account_for_open_connection
2113 ): Do not try to get transport server accounts for local folders,
2114 because they don't have any. This avoids a g_warning().
2116 * src/maemo/modest-main-window.c:
2117 (modest_main_window_notify_send_receive_initied),
2118 (on_configuration_key_changed):
2119 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
2120 * src/modest-defs.h:
2121 * src/modest-mail-operation.c:
2122 (modest_mail_operation_update_account):
2123 * src/modest-tny-account-store.h:
2124 * src/modest-tny-account.c:
2125 (modest_tny_account_get_special_folder),
2126 (modest_tny_account_new_for_local_folders),
2127 (modest_tny_account_new_for_per_account_local_outbox_folder):
2128 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
2129 * src/modest-tny-local-folders-account.c:
2130 (add_account_folders_to_merged_folder):
2131 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
2132 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
2133 (modest_ui_actions_on_send):
2134 * src/widgets/modest-folder-view.c: (update_model):
2135 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
2136 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
2137 modest_tny_account_store_get_tny_account_by_account() to
2138 modest_tny_account_store_get_server_account() to make the code clearer.
2140 2007-06-07 Marcus Bauer <marcusb@openismus.com>
2142 * src/dbus_api/modest-dbus-api.h:
2143 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
2144 * src/maemo/modest-msg-edit-window.c:
2145 (modest_msg_edit_window_attach_file_noninteractive):
2146 added g_warning in case the file to be attached does not exist
2147 * tests/dbus_api/test_compose_mail.c: (main):
2148 removed obsolete comment, added generic files as test case
2150 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2152 * src/modest-tny-account-store.c: (get_server_accounts):
2153 Create the local folders account only once, not once for each outbox, and
2154 not only when there are some outboxes.
2156 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2158 * src/widgets/modest-folder-view.c: (update_model): Comment out some
2159 code that is causing a crash at startup. Sergio says that he is fixing this.
2161 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
2163 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2164 * src/maemo/modest-account-settings-dialog.c:
2165 (create_page_outgoing),
2166 (modest_account_settings_dialog_set_account_name),
2167 (save_configuration):
2168 - Fixed handling of the "Use secure authentication" toggle to comply with
2169 the ui specification. See also projects.maemo.org bug NB#58400
2171 - Restore the Secure connection setting combo correctly when loading
2174 * src/maemo/modest-maemo-utils.c:
2175 (on_camel_account_get_supported_secure_authentication),
2176 (modest_maemo_utils_get_supported_secure_authentication_methods):
2177 Fixed a crasher if operation is canceled
2179 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
2180 (modest_protocol_info_auth_is_secure):
2181 * src/modest-protocol-info.h:
2183 Added two new methods to determine if a protocol/auth method is secure/encrypted in
2184 the sense of the "Use secure authentication" toggle.
2186 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2188 * src/modest-tny-account-store.h:
2189 * src/modest-tny-account-store.c:
2190 Added modest_tny_account_store_get_local_folders_account().
2192 * src/modest-tny-folder.h:
2193 * src/modest-tny-folder.c:
2194 (modest_tny_folder_get_account):
2195 Added this replacement for tny_folder_get_account() which returns
2196 the local-folders account for TnyMergeFolders, to avoid the
2197 warning about the unimplemented get_account_func() vfunc().
2199 (modest_tny_folder_get_rules),
2200 * src/modest-ui-actions.c:
2201 (modest_ui_actions_on_folder_selection_changed):
2202 * src/modest-mail-operation.c:
2203 (modest_mail_operation_remove_folder),
2204 (modest_mail_operation_xfer_folder),
2205 (modest_mail_operation_rename_folder),
2206 (modest_mail_operation_get_msg),
2207 (modest_mail_operation_get_msgs_full),
2208 (modest_mail_operation_remove_msg),
2209 (modest_mail_operation_xfer_msgs),
2210 (modest_mail_operation_refresh_folder):
2211 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
2213 2007-06-07 Murray Cumming <murrayc@murrayc.com>
2215 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
2216 (modest_server_account_set_security):
2217 * src/modest-defs.h: Add comments explaining that our
2218 UI spec means TLS when it says Normal, so these do not look like errors.
2220 * src/modest-tny-account.c:
2221 (modest_tny_account_new_from_server_account): Use the new tinymail
2222 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
2223 for TLS. This should fix projects.maemo.org bug NB#58460.
2225 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2227 * src/maemo/easysetup/modest-easysetup-wizard.c:
2228 (create_account): Correct the position of the gconf sanity check warning.
2229 (on_button_edit_advanced_settings): Show the dialog immediately, instead
2230 of using the g_idle_add() hack, because this does not seem to be necessary
2231 on osso 1.1. It might even work on Maemo Bora if the problems were actually
2232 caused by something other than maemo's gconf.
2233 This fixes projects.maemo.org bug #59022.
2235 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2237 * src/modest-account-mgr-helpers.c:
2238 (modest_account_mgr_get_default_account): Do not check that the account
2239 exists if there is no default account (NULL), to fix a runtime warning.
2241 2007-06-06 Murray Cumming <murrayc@murrayc.com>
2243 * src/widgets/modest-folder-view.c: (update_model):
2244 Do not unref the treemodel before we have finished with it.
2245 This prevents a valgrind warning and an occasional crash at startup.
2247 2007-06-06 Marcus Bauer <marcusb@openismus.com>
2249 * libmodest-dbus-client/libmodest-dbus-client.h:
2250 added libmodest_dbus_client_compose_mail()
2251 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2253 added functions needed for SendAsMail() functionality
2254 * src/maemo/modest-msg-edit-window.c:
2255 (modest_msg_edit_window_attach_file_noninteractive):
2256 non interactively attaching files to message edit window
2257 * src/widgets/modest-msg-edit-window.h:
2258 * tests/dbus_api/Makefile.am:
2259 added test_compose_mail.c
2260 * tests/dbus_api/test_compose_mail.c: (main):
2262 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2264 * src/modest-account-view.c:
2265 Fixed bug projects.maemo.org bug NB#59307
2267 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
2269 * src/maemo/easysetup/modest-easysetup-wizard.c:
2270 (get_serverport_incoming), (on_before_next), (create_account):
2271 * src/maemo/modest-account-settings-dialog.c:
2272 (modest_account_settings_dialog_set_account_name):
2273 * src/maemo/modest-maemo-utils.c:
2274 (on_camel_account_get_supported_secure_authentication_status),
2275 (on_camel_account_get_supported_secure_authentication),
2276 (on_secure_auth_cancel),
2277 (modest_maemo_utils_get_supported_secure_authentication_methods):
2279 Implemented security authentication for settings and easysetup.
2281 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2283 * src/maemo/modest-main-window.c: (create_details_widget):
2284 Show the total size for memory card accounts too, instead of showing
2285 the name again. Fixes bug projects.maemo.org bug NB#59307.
2287 2007-06-05 Murray Cumming <murrayc@murrayc.com>
2290 * src/modest-tny-simple-folder-store.c:
2291 * src/modest-tny-simple-folder-store.h: Removed.
2293 * src/modest-tny-local-folders-account.h
2294 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
2295 for the local-folders maildir, with an extra TnyMergedFolder containing
2296 the folders of the per-account outbox store accounts.
2297 * src/modest-tny-account-store.c: (get_server_accounts):
2298 Add the outboxes to the special local folders account after creating it.
2300 * src/modest-tny-account.c:
2301 (modest_tny_account_new_for_local_folders): Create the derived
2302 account when creating the main local-folders account.
2304 * src/maemo/modest-main-window.c: (create_details_widget),
2305 (modest_main_window_set_contents_style):
2306 Adapted to the use of the derived account instead of the folder store.
2308 * src/modest-ui-actions.c:
2309 (modest_ui_actions_on_folder_selection_changed):
2310 * src/modest-ui-dimming-rules.c:
2311 (modest_ui_dimming_rules_on_new_folder):
2312 * src/widgets/modest-folder-view.c: (text_cell_data),
2313 (icon_cell_data), (filter_row), (update_model),
2314 (get_cmp_rows_type_pos):
2317 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
2318 Do not get the priv struct, because no priv struct has been set,
2319 to avoid a runtime warning.
2321 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
2322 #ifelse with #else, to fix a warning, to fix the build.
2325 2007-06-05 Christian Kellner <ckellner@openismus.com>
2327 * libmodest-dbus-client/libmodest-dbus-client.c:
2328 Fix small typo in doc (why do you always see them
2329 AFTER committing stuff?)
2332 2007-06-05 Christian Kellner <ckellner@openismus.com>
2334 * libmodest-dbus-client/libmodest-dbus-client.c:
2335 (libmodest_dbus_client_search):
2336 Initialize hit list with NULL. Also set folder list
2337 to "" if NULL was supplied.
2340 2007-06-03 Christian Kellner <ckellner@openismus.com>
2342 * libmodest-dbus-client/libmodest-dbus-client.c:
2343 (modest_search_hit_list_free):
2344 Make it save to call it with NULL.
2346 * src/dbus_api/modest-dbus-callbacks.c:
2347 * src/modest-search.c:
2348 Return full ModestSearchHits as the search result list not TnyHeader
2349 since can't be around withouth the correspoding TnyFolder.
2351 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2353 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
2354 Added currently commented code to check for secure auth
2356 * src/maemo/modest-account-settings-dialog.c: (on_response),
2357 (save_configuration), (show_ok):
2358 Fixed projects.maemo.org bugs NB #59248 and #59251
2360 * src/maemo/modest-maemo-utils.c:
2361 (on_camel_account_get_supported_secure_authentication_status),
2362 (on_camel_account_get_supported_secure_authentication),
2363 (modest_maemo_utils_get_supported_secure_authentication_methods):
2364 * src/maemo/modest-maemo-utils.h:
2365 Moved get_supported_secure_authentication() method here to be able
2366 to use it from easysetup wizard.
2368 * src/modest-pair.c: (on_pair_compare_as_string):
2369 Should compare string with first part of pair and not
2370 strcmp pairs which will crash.
2372 * src/modest-protocol-info.c:
2373 (modest_protocol_info_protocol_is_store):
2374 * src/modest-protocol-info.h:
2375 Added modest_protocol_info_get_auth_protocol_name()
2377 2007-06-03 Armin Burgmeier <armin@openismus.com>
2379 * src/modest-mail-operation.c:
2380 (modest_mail_operation_get_msgs_full): Set priv->account also when
2381 only retrieving a single message. This avoids a crash when canceling
2384 (modest_mail_operation_notify_end): Do not explicitely remove the
2385 operation from the queue but only emit the progress_changed signal.
2386 The queue itself listens to that signal to remove the operation when
2387 it is finished. This reduces coupling and removes a potential deadlock
2388 when modest_mail_operation_notify_end() is called from the queue
2389 itself. If that is a problem performance-wise, I would suggest to
2390 implement a status-changed signal or something.
2392 * src/modest-mail-operation-queue.c: Make sure to never call a
2393 function from another file while the queue is locked. This (hopefully)
2394 fixes another deadlock when exiting the application while retrieving
2397 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
2399 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
2400 Fixed build if libogs is not available
2402 2007-06-03 Christian Kellner <ckellner@openismus.com>
2404 * libmodest-dbus-client/libmodest-dbus-client.h:
2405 * libmodest-dbus-client/libmodest-dbus-client.c:
2406 (libmodest_dbus_client_delete_message):
2407 Implement deletion of messages (Client side).
2409 (modest_search_hit_free),
2410 (modest_search_hit_list_free):
2411 Utility functions to free the result hits.
2413 * src/dbus_api/modest-dbus-api.h:
2414 * src/dbus_api/modest-dbus-callbacks.c:
2415 (on_delete_message),
2416 (modest_dbus_req_handler):
2417 Implement deletion of messages (Server side).
2419 * tests/dbus_api/test_search.c: (main):
2422 * tests/dbus_api/Makefile.am:
2423 * tests/dbus_api/test_delete_message:
2424 Add little test for the message deletion logic
2426 2007-06-03 Armin Burgmeier <armin@openismus.com>
2428 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
2429 when the operation queue was not empty. projects.maemo.org bug
2432 2007-06-03 Armin Burgmeier <armin@openismus.com>
2434 * src/widgets/modest-account-view.c
2435 (on_account_default_toggled): Toggle default account column
2436 explicitely instead of waiting for gconf notification (which is
2437 currently ignored). This should fix projects.maemo.org bug NB#56910
2438 for now. It should probably be removed when gconf notifications are
2441 2007-06-03 Christian Kellner <ckellner@openismus.com>
2443 * libmodest-dbus-client/libmodest-dbus-client.c:
2444 Removed debugging spew.
2446 * src/dbus_api/modest-dbus-callbacks.c:
2447 Added debugging info.
2449 * src/modest-search.c:
2450 (modest_search_all_accounts):
2451 Use tny_account_store_get_accounts () on the account store
2452 to get all accounts which is the way to get all accounts.
2454 * tests/dbus_api/test_search.c: (main):
2455 Make it possible to supply the search term on the command line.
2457 2007-06-03 Christian Kellner <ckellner@openismus.com>
2459 * libmodest-dbus-client/libmodest-dbus-client.c:
2460 * libmodest-dbus-client/libmodest-dbus-client.h:
2461 Implement searching for mesages over raw dbus. (Client side)
2463 * src/dbus_api/Makefile.am:
2464 * src/dbus_api/modest-dbus-api.h:
2465 * src/dbus_api/modest-dbus-callbacks.c:
2466 * src/dbus_api/modest-dbus-callbacks.h:
2467 Search framework (Server side). Also implement on_idle_open_message().
2469 * src/maemo/modest-platform.c: (modest_platform_init):
2470 Prepare for raw dbus/osso rpc interaction.
2472 * src/modest-search.h:
2473 Changed minsize from unspecific guint to guint32.
2475 * src/modest-search.c:
2477 Added strange hack which magically made tnymail work.
2479 (modest_search_folder),
2480 (modest_search_account),
2481 (modest_search_all_accounts):
2482 Implement helper functions to search all accounts, specific account
2485 * tests/dbus_api/Makefile.am:
2486 * tests/dbus_api/test_open_message.c:
2487 Read url to open from commandline.
2489 * tests/dbus_api/test_search.c:
2490 Implement small test for dbus search stuff
2492 2007-06-02 Armin Burgmeier <armin@openismus.com>
2494 * src/maemo/modest-account-settings-dialog.c: Changed window title to
2495 include account type and account title. This fixes projects.maemo.org
2498 * src/maemo/modest-account-view-window.c: Set a title for the window.
2500 2007-06-02 Armin Burgmeier <armin@openismus.com>
2502 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
2503 incoming and outgoing server name based on email address and server
2504 types as long as the names have not been edited manually. This fixes
2505 projects.maemo.org bug NB#58671.
2507 2007-06-02 Armin Burgmeier <armin@openismus.com>
2509 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
2510 server type cannot be changed in future to the incoming details page
2511 when creating an account. This fixes projects.maemo.org bug NB#59029.
2513 2007-06-02 Armin Burgmeier <armin@openismus.com>
2515 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
2516 and assigned max width chars so that they wrap instead of being
2517 truncated. Fixes projects.maemo.org bug NB#56126.
2519 2007-06-02 Armin Burgmeier <armin@openismus.com>
2521 * src/maemo/modest-connection-specific-smtp-window.c: Add an
2522 introductory note to the connection specific smtp servers dialog, as
2523 section 8.12 of the email UI specification requires. This fixes
2524 projects.maemo.org bug NB#59212.
2526 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2528 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2529 Check for running mail operations, and offer to cancel them, as per the UI
2530 spec. This fixes projects.maemo.org bug NB#59041 .
2531 However, I suspect that tinymail may still use the network connection
2532 in ways that we cannot detect or cancel. But it should at least adapt to
2533 changes fairly well.
2535 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2537 * src/modest-tny-account-store.c: (recreate_all_accounts),
2538 (get_cached_accounts), (get_server_accounts): Do more sensible
2539 ref-counting of the temporarily-cached outbox accounts list. This seems
2540 to fix a crash when entering the password when the password was wrong.
2542 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2544 * src/gnome/modest-main-window.c: (connect_signals):
2545 * src/modest-tny-account-store.c: (get_password),
2546 (modest_tny_account_store_alert): Added comments and clues and
2547 commented-out code about how we currently fail to deal with connection
2548 errors and wrong passwords, and how we should.
2550 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2552 * src/widgets/modest-retrieve-combo-box.c:
2553 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
2554 This fixes projects.maemo.org bug NB#58472 .
2556 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2558 * src/maemo/easysetup/modest-easysetup-wizard.c:
2559 (create_page_complete_easysetup):
2560 (create_page_complete_custom): Correct the last commit,
2561 putting the correct sentences in the correct pages.
2563 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2565 * src/maemo/easysetup/modest-easysetup-wizard.c:
2566 (create_page_complete_custom): Show the second sentence of text
2567 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
2570 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2572 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
2573 Set the leave-on-server conf key by default. This fixes
2574 projects.maemo.org bug NB#59258 .
2576 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2578 * src/maemo/modest-account-view-window.c:
2579 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
2580 logical ID for the confirmation messages. Fixed projects.maemo.org bug
2583 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2585 * src/maemo/easysetup/modest-easysetup-wizard.c:
2586 (create_caption_new_with_asterisk):
2587 * src/maemo/modest-account-settings-dialog.c:
2588 (create_caption_new_with_asterisk):
2589 Uncomment the code to add the asterisk, because they are no longer in the
2590 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
2591 (update_incoming_server_title): Add an asterisk here too.
2593 2007-06-01 Murray Cumming <murrayc@murrayc.com>
2595 * src/maemo/modest-maemo-global-settings-dialog.c:
2596 (current_connection): Check that we are even connected before trying to
2597 get the current connection name, to prevent a warning.
2599 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2600 Change the comments because tny_maemo_conic_device_connect() is now meant to
2602 * src/modest-mail-operation.c:
2603 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
2604 make sure we have a connection and fail if we can't connect.
2606 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2608 * src/maemo/modest-main-window.c:
2609 (on_account_store_connecting_finished): Do not try to get the
2610 connection ID if we are not really connected. I am surprised that
2611 this signal handler is called when we are not connected.
2613 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2615 * src/modest-error.h:
2616 * src/modest-ui-actions.c:
2617 (modest_ui_actions_get_msgs_full_error_handler):
2618 Renamed an enum, added comments, added an enum
2619 for retrieve-limit errors.
2621 * src/modest-mail-operation.c: (foreach_add_item),
2622 (internal_folder_observer_update), (update_account_thread),
2623 (modest_mail_operation_get_msgs_full):
2624 (modest_mail_operation_update_account),
2625 Added comments about how this works, and some code that should
2626 (but does not) check the retrieve-limit. See the TODO comment.
2628 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2630 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
2631 Initialize help_id to fix the build. Warnings are good.
2633 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2635 * src/widgets/modest-hbox-cell-renderer.c:
2636 (modest_hbox_cell_renderer_append):
2637 * src/widgets/modest-vbox-cell-renderer.c:
2638 (modest_vbox_cell_renderer_append):
2639 Fix the last commit by doing an extra ref.
2641 2007-05-31 Murray Cumming <murrayc@murrayc.com>
2643 * src/widgets/modest-hbox-cell-renderer.c:
2644 (modest_hbox_cell_renderer_append):
2645 * src/widgets/modest-vbox-cell-renderer.c:
2646 (modest_vbox_cell_renderer_append):
2647 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
2648 to fix the build with Maemo Bora.
2649 However, there seems to be a remaining crash, probably due to reference
2652 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2654 * src/modest-tny-account.c:
2655 (modest_tny_account_new_for_local_folders):
2656 Use hildon_file_system_info_async_new() to get a better name for
2657 the memory card account, setting it as the account name.
2658 The timing seems to work, but this is probably
2659 not the best place to do this. See the TODO comment.
2660 * src/maemo/modest-main-window.c: (create_details_widget):
2661 * src/widgets/modest-folder-view.c: (text_cell_data):
2662 Use the tny account name instead of hardcoding a name.
2664 2007-05-30 Christian Kellner <ckellner@openismus.com>
2666 * src/modest-search.c: (modest_search):
2667 Correctly set part_search_func even if we have already parsed
2668 the query and thus a valid OgsTextSearcher object.
2670 2007-05-30 Christian Kellner <ckellner@openismus.com>
2673 Search and check for libogs.
2676 Incooparte the ogs build env.
2678 * src/modest-mime-part-search-stream.c:
2679 * src/modest-mime-part-search-stream.h:
2680 Removed since we do the real searching now in modest-search.c.
2682 * src/modest-search.c:
2683 * src/modest-search.h:
2684 Implement support for ogs. We use that if available and requested
2685 and fall back to modest_text_utils_utf8_strcmp (). The search logic
2686 should now handle the corner case when the search term is spread
2687 across multiple reads.
2688 Also the logic in modest_search () was corrected to search all
2689 requested fields until one is found.
2691 2007-05-30 Murray Cumming <murrayc@murrayc.com>
2693 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
2695 * src/modest-init.h:
2696 * src/modest-init.c: Made modest_init_local_folders() take a
2697 path and be public so we can iniitialize maildir folders on
2700 * src/modest-local-folder-info.h:
2701 * src/modest-local-folder-info.c:
2702 (modest_local_folder_info_get_maildir_path): Add a path parameter.
2704 * src/modest-tny-account.c:
2705 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
2706 still means the standard local-folders path on the local volume.
2708 * src/modest-tny-account-store.c:
2709 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
2710 signal so we can detect mount/unmount of the MMC1 card, and do an update of
2711 all accounts when that happens.
2712 (get_server_accounts): If the MMC1 card is mounted, create a store account for
2713 this too, so it shows up in the treeview.
2715 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2717 * src/maemo/modest-maemo-global-settings-dialog.c:
2718 (current_connection):
2719 * src/widgets/modest-global-settings-dialog.c:
2720 (current_connection_default):
2721 Use the enum values instead of 0, 1 and -1,
2722 to make the code clearer.
2724 * src/modest-account-mgr-helpers.c:
2725 (modest_account_mgr_get_connection_specific_smtp): Make this code
2728 * src/modest-runtime.h:
2729 * src/modest-runtime.c:
2730 Added modest_runtime_remove_all_send_queues().
2731 * src/maemo/modest-main-window.c:
2732 (on_account_store_connecting_finished): Recreate the send queues,
2733 using the appropriate transport accounts for this new connection.
2734 Some futher adapting might be needed if the old send queues are not
2735 automatically stopped at this point.
2737 * src/modest-tny-account-store.c: (get_server_accounts):
2738 Create the connection-specific transport accounts, so that they can
2739 be found later by their ID.
2741 * src/modest-tny-account.h:
2742 * src/modest-tny-account.c:
2743 Added modest_tny_account_new_from_server_account_name().
2744 modest_tny_account_new_from_server_account(): Do not create the
2745 send queues here, because they will be
2746 recreated anyway when the connection changes for the first time.
2748 2007-05-28 Murray Cumming <murrayc@murrayc.com>
2750 * src/modest-local-folder-info.h:
2751 * src/modest-local-folder-info.c:
2752 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2753 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2754 tbox_folder): Take a modest account name instead of a server TnyAccount,
2755 so we can have per-modest-account rather than per-transport-account
2757 We must make sure that we change or recreate the exisitng send queues
2758 when the connection changes for connection-specific transport accounts.
2760 * src/modest-tny-account-store.c:
2761 (create_per_account_local_outbox_folders): Create outboxed per modest
2762 account, not per transport account.
2764 * src/modest-tny-account.h:
2765 * src/modest-tny-account.c:
2766 (modest_tny_account_get_special_folder): For outboxes, get the
2767 parent modest account name. The account is ignored for other folders.
2768 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
2769 modest account name rather than a server TnyAccount.
2771 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2773 * src/modest-tny-account.c:
2774 (modest_tny_account_new_from_server_account):
2775 Call modest_runtime_get_send_queue() immediately after creating transport
2776 accounts, so that they start trying to send email from the outbox as soon
2777 as possible at startup. This is probably what we want.
2779 * src/modest-mail-operation.c: (update_account_thread):
2780 * src/modest-runtime.c: (modest_runtime_get_send_queue):
2781 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
2782 * src/modest-tny-send-queue.h:
2783 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
2784 (modest_ui_actions_on_send):
2785 Added comments about how sending works, though it needs some more work.
2787 2007-05-25 Murray Cumming <murrayc@murrayc.com>
2789 * src/modest-tny-account.c:
2790 (modest_tny_account_get_special_folder): Add TODO because this fails when
2791 the network is busy.
2792 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
2793 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
2794 Do not try to show this window when there is no active account. The UI
2795 specs does not tell us what to do in this case.
2797 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2801 * src/maemo/Makefile.am:
2802 * src/widgets/Makefile.am: Some dist fixes.
2804 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2806 * src/maemo/modest-connection-specific-smtp-window.c:
2807 (on_button_edit): Make the code clearer, to prevent a double free.
2809 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2811 * src/maemo/modest-account-settings-dialog.c:
2812 (modest_account_settings_dialog_set_account_name),
2813 Check the connection-specific smtp servers checkbox if there are any.
2815 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2816 (modest_connection_specific_smtp_edit_window_init):
2817 Start with a suitable port number.
2819 * src/modest-account-mgr-helpers.h:
2820 * src/modest-account-mgr-helpers.c: Added
2821 modest_account_mgr_get_has_connection_specific_smtp().
2823 (modest_account_mgr_set_connection_specific_smtp),
2824 (modest_account_mgr_remove_connection_specific_smtp),
2825 (modest_account_mgr_get_has_connection_specific_smtp),
2826 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
2827 connection-specific smtp server accounts in the account, rather than
2828 the server account conf dir.
2830 This fixes bug projects.maemo.org bug NB#58263 .
2832 * src/modest-tny-account-store.c:
2833 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
2834 if there are no server accounts yet, to prevent an infinite loop when there
2835 are no accounts. Document that one must be called before the other.
2837 2007-05-24 Murray Cumming <murrayc@murrayc.com>
2839 * src/modest-account-mgr-helpers.c:
2840 (modest_account_mgr_get_default_account): Make sure that at least
2841 one account is always the default, if there are any enabled accounts.
2842 This is just a sanity check that shouldn't be necessary.
2844 * src/modest-account-mgr-priv.c:
2845 (_modest_account_mgr_account_from_key): Unescape the conf key to
2846 get the real account name. For instance, this is an issue if a space
2847 was in the account name, which can happen because the account name
2848 is generated from the display name.
2849 (_modest_account_mgr_get_account_keyname): Always escape the
2851 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
2852 Unescape the conf keys to get the real account names.
2854 For instance, previously the is-default radio button in the accounts
2855 list was not checked for any accounts at first. This fixes that,
2856 and might fix several similar bugs.
2858 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2860 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
2861 Removed some debug printfs.
2863 2007-05-23 Murray Cumming <murrayc@murrayc.com>
2865 Modest on-disk outbox directories are now here, for instance:
2866 $HOME/.modest/outboxes/<account-id-1>/outbox
2867 $HOME/.modest/outboxes/<account-id-2>/outbox
2869 $HOME/.modest/local-folders/outbox
2870 so we can have a separate outbox for each account.
2871 But they are shown as one outbox in the GtkTreeView, by using a
2872 TnyMergeFolder in a ModestTnySimpleFolderStore.
2875 * src/modest-tny-simple-folder-store.c:
2876 * src/modest-tny-simple-folder-store.h:
2877 Added ModestTnySimpleFolderStore, used to contain folders from
2878 other folder stores, such as other accounts.
2880 * src/modest-tny-outbox-account.h:
2881 * src/modest-tny-outbox-account.c:
2882 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
2883 used for the per-account local outbox folders.
2885 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
2886 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
2887 only use this (internally) now for the non-outbox local folders.
2889 * src/modest-init.h:
2890 * src/modest-init.c: Added modest_init_one_local_folder(), for
2891 setting up the directory structure for each local folder.
2893 * src/modest-local-folder-info.c:
2894 (modest_per_account_local_outbox_folder_info_get_maildir_path),
2895 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
2897 * src/modest-local-folder-info.h:
2898 * src/modest-tny-account-store.c: (on_account_removed),
2899 (on_account_changed), (create_per_account_local_outbox_folders),
2900 (get_server_accounts), (modest_tny_account_store_get_accounts),
2901 (modest_tny_account_store_get_tny_account_by_account),
2902 (modest_tny_folder_store_is_virtual_local_folders):
2904 * src/modest-tny-account.h:
2905 * src/modest-tny-account.c:
2906 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
2907 to create an on-disk per-account local outbox folder for each
2909 (create_per_account_local_outbox_folders): Create a local outbox folder
2910 for each transport account.
2911 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
2912 for all local folders.
2914 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
2915 instead of using g_object_get/set() directly. It is clearer.
2917 (modest_tny_folder_store_get_message_count),
2918 (modest_tny_folder_store_get_local_size
2919 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
2920 because we now use these with non-acount folder stores.
2922 (modest_tny_account_get_special_folder),
2923 (modest_tny_account_new_from_server_account),
2924 (modest_tny_account_new_from_account):
2925 (recurse_folders): Adjust to the new outbox system.
2927 * src/modest-tny-folder.h:
2928 * src/modest-tny-folder.c:
2929 (modest_tny_folder_is_local_folder),
2930 (modest_tny_folder_get_local_folder_type),
2931 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
2933 * src/widgets/modest-main-window.h:
2934 * src/maemo/modest-main-window.c: (create_details_widget),
2935 (modest_main_window_set_contents_style): Show details for any folder store,
2938 (modest_tny_folder_get_rules):
2939 Remove the const. C does not support constness enough for this.
2941 * src/modest-ui-actions.c:
2942 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
2943 make all outboxes appear as one, in the usual local-folders tree node.
2945 (set_active_account_from_tny_account),
2946 (modest_ui_actions_on_folder_selection_changed):
2947 * src/widgets/modest-folder-view.c: (text_cell_data),
2948 (icon_cell_data), (filter_row),
2949 (add_account_folders_to_merged_folder),
2950 (add_account_folders_to_simple_folder_store), (),
2951 (get_cmp_rows_type_pos), (cmp_rows),
2952 (modest_folder_view_set_account_id_of_visible_server_account):
2953 Adjust to the new outbox system, using generic folder stores and folders
2954 in the GtkTreeModel.
2956 2007-05-23 Christian Kellner <ckellner@openismus.com>
2958 * src/modest-mail-operation.c:
2959 (modest_mail_operation_update_account):
2960 Use info->max_size instead of unintialized local var [small
2961 build fix]. (Added TODO to review that change since I don't
2964 2007-05-23 Marcus Bauer <marcusb@openismus.com>
2966 * libmodest-dbus-client/libmodest-dbus-client.c:
2967 (libmodest_dbus_client_compose_mail): function added
2968 * src/dbus_api/modest-dbus-api.h:
2969 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
2970 (on_compose_mail): Implementation of the SendAsMail functionality
2972 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2974 * src/modest-account-mgr.c:
2975 (modest_account_mgr_add_server_account): Set the secure-connection
2976 conf key for transport accounts as well as store accounts. I don't know
2977 why the if was there. For instance, this makes sure that we use SSL
2978 for the gmail preset from the easysetup wizard.
2980 2007-05-22 Murray Cumming <murrayc@murrayc.com>
2982 * src/gnome/modest-main-window.c:
2983 (on_account_store_connecting_finished), (connect_signals):
2984 * src/maemo/modest-main-window.c:
2985 (on_account_store_connecting_finished), (connect_signals),
2986 (modest_main_window_new):
2987 Handle TnyAccountStore::connecting-finished instead of
2988 TnyDevice::connection-changed, because we cannot actually perform
2989 operations on accounts until TnyAccountStore has itself responded to
2990 the TnyDevice::connection-changed signal. This prevents a GError from
2992 Do not try to update at startup, because we (at least on scratchbox)
2993 already do an update at startup when the device goes online.
2994 This prevents a GError from tinymail.
2995 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
2996 Added TODO about stopping simultaneous operations.
2998 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3000 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
3001 * src/modest-mail-operation-queue.c:
3002 (modest_mail_operation_queue_remove):
3003 * src/modest-tny-account-store.c: When GErrors happen, give more clues
3004 about where they happened.
3006 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3008 * src/modest-ui-actions.c:
3009 (modest_ui_actions_on_password_requested): Make sure that the remember
3010 output parameter is always TRUE.
3012 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3014 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3015 Show a OK/Cancel dialog if the error is a question, though we still do not
3016 know anything more about what we are asking the user.
3017 * src/widgets/modest-folder-view.c: (on_drag_data_received):
3018 Fix an uninitialized variable (helper). This is a logic error, however.
3020 2007-05-21 Christian Kellner <ckellner@openismus.com>
3022 * src/modest-search.h:
3023 Correct bit shifting in the ModestSearchFlags enum.
3025 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3027 * src/modest-tny-account.c:
3028 (modest_tny_account_new_from_server_account): Do not use the lsub and
3029 check-all hard-coded IMAP options when using POP.
3031 2007-05-21 Murray Cumming <murrayc@murrayc.com>
3033 * src/modest-tny-account.c:
3034 (modest_tny_account_new_from_server_account):
3035 Use NULL for the secure-auth method for POP when Password auth has been
3036 specified by the user, as we already do for IMAP. "auth=Login" causes
3037 an error from camel or the server.
3039 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3041 * src/maemo/modest-account-settings-dialog.c:
3042 (create_page_account_details),
3043 (modest_account_settings_dialog_set_account_name):
3044 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
3045 for the leave-on-server checkbox, rathr than just the checkbox, when
3046 the protocol is not POP.
3048 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3050 * src/widgets/modest-account-view.c:
3051 * src/widgets/modest-account-view.h:
3052 Added modest_account_view_select_account() which will be useful later
3053 to asynchronously re-select the edited account.
3055 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3057 * src/maemo/modest-account-settings-dialog.c:
3058 (modest_account_settings_dialog_set_account_name):
3059 Automatically choose the port numbers based on the secure authentication
3060 methods, if they have not been chosen before.
3061 This fixes projects.maemo.org bug NB#56273 .
3063 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3065 * src/maemo/modest-main-window-ui.h:
3066 * src/modest-ui-actions.c:
3067 * src/modest-ui-actions.h:
3068 Connect the Tools/SMTP Servers menu item to
3069 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
3070 SMTP servers dialog, as in the UI specification and saves changes when it
3071 is closed. This fixed projects.maemo.org bug NB#56305 .
3073 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3075 * src/maemo/modest-connection-specific-smtp-window.c:
3076 (modest_connection_specific_smtp_window_init):
3077 Use gtk_window_set_default_size() to make this window big enough, so
3078 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
3080 2007-05-17 Murray Cumming <murrayc@murrayc.com>
3082 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3083 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3084 (modest_connection_specific_smtp_edit_window_init),
3085 Do not try to connect to a combobox signal before the combobox exists.
3086 This fixes the cras in projects.maemo.org bug NB#56288 .
3087 (modest_connection_specific_smtp_edit_window_get_settings):
3088 Remove the server_account_name parameter which was being checked for NULL
3089 though it was not used.
3091 * src/maemo/modest-connection-specific-smtp-window.c:
3092 (modest_connection_specific_smtp_window_fill_with_connections),
3093 (on_button_edit), (modest_connection_specific_smtp_window_init):
3094 Correct the number of treemodel columns to prevent a warning.
3095 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
3096 libconic does not work.
3098 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3100 * src/modest-tny-account.c:
3101 (modest_tny_account_new_from_server_account):
3102 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
3103 SMTP when "None" was chosen by the user. However, with my SMTP server that
3104 does not support ANONYMOUS, the emails do not leave the Outbox and I see
3107 2007-05-16 Murray Cumming <murrayc@murrayc.com>
3109 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
3110 to explain the memory management issue with the ID in the ModestPair.
3112 * src/gnome/modest-account-assistant.c: (add_receiving_page),
3113 (add_sending_page), (modest_account_assistant_finalize):
3114 * src/gnome/modest-gnome-global-settings-dialog.c:
3115 (create_updating_page), (create_composing_page):
3116 * src/gnome/modest-msg-edit-window.c: (get_transports),
3117 (init_window), (modest_msg_edit_window_finalize),
3118 (modest_msg_edit_window_get_msg_data):
3119 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
3120 * src/gnome/modest-transport-widget.c:
3121 (modest_transport_widget_finalize), (smtp_configuration):
3122 * src/maemo/modest-maemo-global-settings-dialog.c:
3123 (create_updating_page), (create_composing_page):
3124 * src/maemo/modest-msg-edit-window.c: (get_transports),
3125 (init_window), (modest_msg_edit_window_finalize),
3126 (modest_msg_edit_window_get_msg_data),
3127 (modest_msg_edit_window_free_msg_data):
3128 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
3129 (modest_store_widget_finalize):
3130 * src/maemo/modest-transport-widget.c:
3131 (modest_transport_widget_finalize), (smtp_configuration):
3132 * src/modest-main.c: (send_mail):
3133 * src/widgets/modest-combo-box.h:
3134 * src/widgets/modest-global-settings-dialog-priv.h:
3135 * src/widgets/modest-global-settings-dialog.c:
3136 (modest_global_settings_dialog_finalize):
3137 * src/widgets/modest-msg-edit-window.h:
3138 Whenever using modest_combo_box_new(), keep the ModestPairList alive
3139 as long as the combo box, to prevent use of freed memory for the ID.
3141 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3143 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
3144 get_accounts(), to make this clearer. Do not check for the enabled gconf
3145 key, because we do not use this for server accounts (at least, not yet).
3146 This allows us to send email again.
3148 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3150 * src/maemo/modest-platform.c:
3151 (on_modest_conf_update_interval_changed), (modest_platform_init):
3152 Only respond to this particular key change. All these strcmp()s cannot be
3155 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3157 * src/maemo/modest-maemo-global-settings-dialog.c:
3158 (current_connection): Prevent a crash in scratchbox when
3159 ny_maemo_conic_device_get_current_iap_id() returns NULL.
3160 * src/maemo/modest-platform.c:
3161 (on_modest_conf_update_interval_changed), (modest_platform_init):
3162 Get the update interval from gconf and reset it when the gconf key changes.
3164 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3166 * src/modest-protocol-info.c:
3167 * src/modest-protocol-info.h: Adde enum-specific get functions,
3168 instead of using a ModestProtocolType enum parameter.
3170 * src/gnome/modest-account-assistant.c:
3171 * src/gnome/modest-store-widget.c:
3172 * src/gnome/modest-store-widget.h:
3173 * src/gnome/modest-transport-widget.c:
3174 * src/gnome/modest-transport-widget.h:
3175 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
3176 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
3177 * src/maemo/easysetup/modest-easysetup-wizard.c:
3178 * src/maemo/modest-account-settings-dialog.c:
3179 * src/maemo/modest-account-settings-dialog.h:
3180 * src/maemo/modest-store-widget.c:
3181 * src/maemo/modest-store-widget.h:
3182 * src/maemo/modest-transport-widget.c:
3183 * src/maemo/modest-transport-widget.h:
3184 * src/modest-account-mgr-helpers.c:
3185 * src/modest-account-mgr-helpers.h:
3186 * src/modest-account-mgr.c:
3187 * src/modest-account-mgr.h:
3188 * src/modest-tny-account.c:
3189 * src/modest-tny-folder.c:
3190 * src/widgets/modest-account-view.c:
3191 * src/widgets/modest-retrieve-combo-box.c:
3192 * src/widgets/modest-retrieve-combo-box.h:
3193 * src/widgets/modest-secureauth-combo-box.c:
3194 * src/widgets/modest-serversecurity-combo-box.c:
3195 * src/widgets/modest-serversecurity-combo-box.h:
3196 * tests/check_account-mgr.c:
3197 Use the specific functions, and use the re-renamed enum values for GNOME too.
3199 2007-05-15 Murray Cumming <murrayc@murrayc.com>
3201 * src/modest-pair.h:
3202 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
3203 so we can get the second based on the first.
3205 * src/maemo/modest-account-settings-dialog.h:
3206 * src/maemo/modest-account-settings-dialog.c:
3207 Added get_supported_secure_authentication_methods(), though it is mostly
3208 commented-out for now until the necessary API is committed to tinymail.
3209 (modest_account_settings_dialog_set_account_name),
3210 (save_configuration): Request the supported authentication methods from the
3211 server, so we can choose a working method.
3213 * src/modest-tny-account-store.h:
3214 * src/modest-tny-account-store.c:
3215 (modest_tny_account_store_get_session): Rename from
3216 tny_account_store_get_session().
3218 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3220 * src/modest-protocol-info.h: Split the ModestProtocol enum
3221 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
3222 There was no need to have these unrelated values in one enum.
3224 * src/: many files: Adapted to changed enum. This makes the code a bit
3225 clearer, and the compiler could catch some errors.
3227 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3229 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3230 Show the detailed internal camel error message when an error happens
3231 during the configuration, so that our testers can give us more clues.
3232 For instance, in projects.maemo.org bug NB#56910 .
3234 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3236 * src/modest-tny-account.c:
3237 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
3238 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
3240 2007-05-14 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3243 * src/maemo/modest-account-settings-dialog.c:
3244 (modest_account_settings_dialog_set_account_name),
3245 (save_configuration): For the incoming secure authentication checkbox,
3246 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
3247 the UI specification. PLAIN does not seem to be supported for most IMAP
3248 servers anyway, and I am not sure what it would mean.
3249 However, we probably need to discover which of the secure-authentication
3250 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
3251 * src/modest-account-mgr-helpers.c:
3252 (modest_account_mgr_get_server_account_data):
3254 * src/modest-tny-account.c:
3255 (modest_tny_account_new_from_server_account):
3256 Use tny_account_set_mech() to set secure-authentication methods,
3257 with some special-casing for IMAP, based on my observations of how
3260 * src/modest-account-mgr-helpers.h:
3261 * src/modest-account-mgr.c:
3262 * src/modest-defs.h: Comment that the URI is only used for local folders.
3264 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3266 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
3267 parameter const, just to be neat.
3268 * src/modest-text-utils.c: (modest_text_utils_inline):
3269 End g_strconcat() with NULL, as its documentation says. This is almost
3270 certainly the cause of my crash at startup on the device. Interestingly,
3271 valgrind doesn't tell us about these errors.
3273 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3275 * scripts/build-packages: Added more precise comments about how to use
3276 this script, though I still get this error:
3277 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
3278 error building tinymail
3280 2007-05-11 Murray Cumming <murrayc@murrayc.com>
3282 * src/maemo/modest-main-window.c: (on_account_update):
3283 Very slight cleanup, hoping to make it simpler to discover what causes
3284 a crash here sometimes.
3286 * src/modest-tny-account.c:
3287 (modest_tny_account_new_from_server_account): Set the port. Added
3288 comments about the options and a TODO comment because I need to find out
3289 how to specify the secure authentication method.
3291 2007-05-11 Marcus Bauer <marcusb@openismus.com>
3293 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3294 changed CFlags paths form modest to libmodest
3296 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3298 * src/modest-account-mgr-helpers.c:
3299 (modest_account_mgr_get_server_account_data),
3300 (modest_account_mgr_free_server_account_data):
3301 * src/modest-account-mgr-helpers.h:
3302 * src/modest-account-mgr.c:
3303 (modest_account_mgr_add_server_account):
3304 * src/modest-defs.h:
3305 * src/modest-tny-account.c:
3306 (modest_tny_account_new_from_server_account):
3307 Determine the options for tny_camel_account_add_option() here,
3308 based on the settings, rather than storing them directly in gconf.
3310 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3312 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3313 Show a more friendly error dialog now that we expect (from the tinymail
3314 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
3316 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3318 * src/maemo/modest-main-window.c: (on_account_update): Check that
3319 account_name is not NULL, to prevent a crash at startup that I am
3320 seeing on the N800. I do wonder why it is NULL.
3322 * src/maemo/easysetup/modest-easysetup-wizard.c:
3323 (create_page_user_details):
3324 * src/maemo/modest-account-settings-dialog.c:
3325 (create_page_user_details), (create_page_outgoing):
3326 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3327 (modest_connection_specific_smtp_edit_window_init):
3328 * src/modest-ui-actions.c:
3329 (modest_ui_actions_on_password_requested):
3330 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
3331 might do something useful with the on-screen keyboard.
3333 2007-05-10 Murray Cumming <murrayc@murrayc.com>
3335 * src/maemo/modest-main-window.c: (on_account_update):
3336 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
3337 NULL, to avoid lots of warnings. However, it probably should not be NULL.
3339 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3341 * src/modest-tny-account-store.c: (on_account_changed):
3342 Correct the signature of this signal handler.
3344 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3346 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3347 Show a HildonNote instead of a GtkDialog for Maemo.
3349 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3351 * src/widgets/modest-account-view.h:
3352 * src/widgets/modest-account-view.c: (on_account_changed),
3353 (on_account_removed). Added a boolean flag, set/unset by
3354 modest_account_view_block_conf_updates(),
3355 modest_account_view_unblock_conf_updates() to prevent unnecessary
3356 updates, but this is not very useful because the gconf notifications are
3357 so delays (maybe only on Maemo Bora).
3358 So auto-updating is turned off, and these functions do an explicit
3359 update when necessary.
3360 However, something else is still doing too much work when adding/removing
3361 accounts, probably in another part of the application.
3363 * src/maemo/modest-account-view-window.c:
3364 (on_delete_button_clicked), (on_edit_button_clicked),
3365 (on_new_button_clicked): Use the new functions.
3367 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3369 * src/modest-account-mgr-helpers.c:
3370 (modest_account_mgr_set_first_account_as_default):
3371 Sort the list of names alphabetically-by-title, so we choose the first one
3373 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
3374 alphabetically by the title.
3376 This fixes projects.maemo.org bug NB#56418 .
3378 * src/modest-account-mgr-priv.c:
3379 (_modest_account_mgr_account_from_key):
3380 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
3381 avoid a valgrind error, and possible random behaviour.
3383 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3385 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
3386 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
3387 tinymail documentation to say that this can be expected.
3388 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
3389 pretty, and should not happen, but I would prefer to know when it does.
3391 2007-05-09 Murray Cumming <murrayc@murrayc.com>
3393 * configure.ac: When using the older hildon version, probably on Bora,
3394 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
3396 * src/widgets/modest-attachment-view.c:
3397 (modest_attachment_view_set_part_default): Initialize variables, to fix the
3400 2007-05-09 Marcus Bauer <marcusb@openismus.com>
3402 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
3403 Implemented the prototype. Can be tested with
3404 tests/dbus_api/test_open_message:
3406 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3408 * src/modest-tny-account-store.c:
3409 (modest_tny_account_store_instance_init), (get_password):
3410 * src/modest-ui-actions.c:
3411 (modest_ui_actions_on_password_requested):
3412 Do not store the password in gconf, because this function is called
3413 for non-remembered passwords. Actually use the cached (in the hash map)
3414 password instead of releasing it.
3415 The password will now not be remembered if it is asked via the protected
3416 password dialog, as per the UI spec.
3418 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3420 * src/modest-defs.h:
3421 * src/modest-account-mgr-helpers.h:
3422 * src/modest-account-mgr-helpers.c:
3423 Added modest_server_account_get_username_has_succeeded(),
3424 modest_server_account_set_username_has_succeeded().
3425 (modest_server_account_set_username),
3426 Reset the has-succeeded flag if the username changes.
3428 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3429 * src/maemo/modest-connection-specific-smtp-window.c:
3430 (modest_connection_specific_smtp_window_save_server_accounts):
3431 Use modest_server_account_set_username() instead of using
3432 modest_conf_set_string() directly, so that the has-succeeded flag is always
3435 * src/modest-ui-actions.c:
3436 (modest_ui_actions_on_password_requested): Dim the username entry if
3437 the username has ever worked, as per the UI spec.
3439 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3441 * src/modest-tny-account-store.c: (get_password):
3442 * src/modest-ui-actions.c:
3443 (modest_ui_actions_on_password_requested):
3444 Allow the username to be changed too, though there is more work to
3445 be done on exactly how this behaves.
3447 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3449 * src/modest-account-mgr-helpers.h:
3450 * src/modest-account-mgr-helpers.c:
3451 Added modest_account_mgr_get_display_name(),
3452 modest_server_account_get_username(),
3453 modest_server_account_set_username(),
3454 modest_server_account_set_password(),
3455 modest_server_account_get_hostname() functions so we do not need to
3456 use the conf API directly.
3458 * src/maemo/modest-main-window.c: (connect_signals):
3459 Actually connect ot the ModestAccountStore::request-password signal,
3460 so that we show the dialog when the password is requested by Tinymail,
3461 for isntance if it is empty.
3463 * src/modest-marshal.list:
3464 * src/modest-tny-account-store.c:
3465 (modest_tny_account_store_class_init), (get_password),
3466 (modest_tny_account_store_alert):
3467 * src/modest-tny-account-store.h:
3468 * src/modest-ui-actions.h:
3469 * src/modest-ui-actions.c:
3470 (modest_ui_actions_on_password_requested):
3471 Change the signal parameters, so it is obvious that we are providing
3472 the non human-readable server name, and receiving both the username
3473 and password, though changing of the username is not yet implemented.
3474 Change the dialog UI to match the Maemo UI specifications, with #idfefing
3475 for the GNOME version.
3477 This should fix the projects.maemo.org bug NB#56209, though it does not
3478 work on Bora, because the gconf_client_get() for the password fails
3479 immediately after we save it with gconf_client_set().
3481 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3484 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
3485 caused an undefined symbol error:
3486 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
3488 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3490 * src/modest-tny-account-store.c:
3491 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
3492 using a GError instead of a string message, so we can translate it in
3495 2007-05-08 Murray Cumming <murrayc@murrayc.com>
3497 * src/maemo/modest-address-book.c:
3498 (modest_address_book_check_names):
3499 * src/maemo/modest-msg-view-window.c:
3500 (modest_msg_view_window_clipboard_owner_change):
3501 * src/modest-init.c: (modest_init_init_ui):
3502 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
3503 (update_folders_cb), (modest_mail_operation_update_account):
3504 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
3505 (modest_ui_actions_on_msg_attachment_clicked),
3506 (modest_ui_actions_on_msg_recpt_activated):
3507 * src/widgets/modest-header-view.c: (drag_data_get_cb):
3508 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
3509 (modest_msg_view_search_next):
3510 * src/widgets/modest-recpt-editor.c:
3511 (modest_recpt_editor_on_button_release_event),
3512 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
3513 g_message(). At this point we should only be seeing interesting errors on
3514 stdout. Debugging messages could be #ifdefed-out if they are still useful.
3516 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3518 (modest_wizard_dialog_force_title_update):
3519 * src/maemo/easysetup/modest-wizard-dialog.h:
3520 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
3521 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
3522 can update the title when appropriate. Otherwise the title is wrong if the
3523 pages are added after adding the notebook to the dialog.
3524 This must be a problem in HildonWizardDialog too.
3525 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
3527 * src/maemo/easysetup/modest-easysetup-wizard.c:
3528 (create_subsequent_customsetup_pages),
3529 (create_subsequent_easysetup_pages):
3530 Call modest_wizard_dialog_force_title_update() so that the title is
3531 correct even with GTK+ < 2.10.
3532 This fixes projects.maemo.org bug NB#56145 .
3534 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3536 * src/maemo/modest-platform.c:
3537 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
3538 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
3541 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3543 * src/widgets/modest-window.h:
3544 * src/widgets/modest-window.c: Added a save_state_func vfunc,
3545 and modest_window_save_state(), which invokes it.
3547 * src/widgets/modest-window-mgr.h:
3548 * src/widgets/modest-window-mgr.c:
3549 Added modest_window_mgr_save_state_for_all_windows(), which calls
3550 the save_state vfunc on all registered windows, if implemented.
3552 * src/gnome/modest-msg-edit-window.c:
3553 * src/gnome/modest-msg-view-window.c:
3554 * src/maemo/modest-msg-edit-window.c:
3555 * src/maemo/modest-msg-view-window.c:
3556 * src/maemo/modest-main-window.c:
3557 Specify the existing save_settings functions as implementations of
3558 ModestWindow::save_state_func().
3560 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
3561 Call modest_window_mgr_save_state_for_all_windows(). This happens before
3562 enabling hibernation, for instance.
3564 We may need to do the same thing for restoring settings.
3567 2007-05-07 Murray Cumming <murrayc@murrayc.com>
3569 * src/widgets/modest-window-mgr.c:
3570 * src/widgets/modest-window-mgr.h:
3571 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
3572 modest_window_mgr_get_hibernation_is_prevented().
3574 * src/maemo/modest-main-window.c:
3575 (on_hildon_program_is_topmost_notify): Prevent hibernation
3576 (possible when the application goes to the background in the WM),
3577 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
3579 * src/maemo/easysetup/modest-easysetup-wizard.c:
3580 (modest_easysetup_wizard_dialog_init):
3581 * src/maemo/modest-account-settings-dialog.c:
3582 (modest_account_settings_dialog_init):
3583 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3584 (modest_connection_specific_smtp_edit_window_init):
3585 * src/maemo/modest-connection-specific-smtp-window.c:
3586 (modest_connection_specific_smtp_window_init):
3587 * src/maemo/modest-signature-editor-dialog.c:
3588 (modest_signature_editor_dialog_init):
3589 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
3590 prevent hibernation while any of these account settings dialogs are open.
3592 2007-05-04 Murray Cumming <murrayc@murrayc.com>
3594 * src/maemo/Makefile.am:
3595 * src/maemo/modest-osso-state-saving.c:
3596 * src/maemo/modest-osso-state-saving.h: Added
3597 modest_osso_load_state() and modest_osso_save_state() though they do
3598 nothing now. They should iterate through all the open windows and load/save
3600 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
3601 save state when closing.
3603 * src/maemo/modest-main-window.c:
3604 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
3605 Add a notification handler for the HildonProgram::is-topmost property,
3606 so we can allow hibernation when the application goes into the background.
3607 But we still need to detect when the accounts setup windows are open so
3608 we can stop hibernation when they are open.
3609 To do this, I also added the main window the HildonProgram. This might have
3610 other side-effects/benefits, and should maybe be done for other windows.
3612 * src/maemo/modest-osso-autosave-callbacks.h:
3613 * src/maemo/modest-osso-autosave-callbacks.c:
3614 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
3615 though it does not do anything yet, and we might never need this to do
3616 anything. For instance, we already save drafts.
3618 * src/maemo/modest-platform.c: (modest_platform_init):
3619 Specify the libosso auto-save callback.
3621 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3623 * src/maemo/modest-platform.c:
3624 (modest_platform_set_update_interval):
3625 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
3626 aparently stays valid between application instances, so we can use this
3627 to remove and reset it later. According to a maemo-developers email from
3630 2007-05-03 Murray Cumming <murrayc@murrayc.com>
3632 * configure.ac: Depend on libalarm for Maemo.
3634 * src/dbus_api/modest-dbus-api.h:
3635 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
3636 (on_send_receive), (modest_dbus_req_handler):
3637 Handle a SEND_RECEIVE D-Bus method.
3639 * libmodest-dbus-client/libmodest-dbus-client.c:
3640 (libmodest_dbus_client_send_and_receive):
3641 * libmodest-dbus-client/libmodest-dbus-client.h:
3642 Add C convenience functions for calling the new D-Bus method.
3644 * src/modest-platform.h:
3645 * src/gnome/modest-platform.c:
3646 * src/maemo/modest-platform.c:
3647 Added modest_platform_set_update_interval(), which uses the
3648 alarmd API on Maemo.
3649 (modest_platform_init),
3650 Call modest_platform_set_update_interval(), using a hard-coded
3651 interval for now (until the global settings dialog is implemented),
3652 though I am not sure that this makes sense yet.
3654 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3656 * src/dbus_api/modest-dbus-callbacks.c:
3657 (modest_osso_cb_hw_state_handler):
3658 * src/dbus_api/modest-dbus-callbacks.h:
3659 * src/maemo/modest-platform.c: (modest_platform_init):
3660 Registered (empty) callbacks for the osso hardware state D-Bus signals,
3661 in case this has some effect on the ability for Maemo to ping the
3664 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3666 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
3667 Comment out an if() that checks a gchar for < 0, causing a build-breaking
3668 warning. It is probably a logic error, but I need to fix the build.
3670 2007-05-02 Murray Cumming <murrayc@murrayc.com>
3672 * src/modest-account-mgr.h:
3673 * src/modest-account-mgr.c:
3674 (modest_account_mgr_account_names): Add a gboolean enabled_only
3675 parameter, so we can get lists of onlt the enabled accounts.
3677 (modest_account_mgr_add_account),,
3678 (modest_account_mgr_account_with_display_name_exists):
3679 * src/maemo/modest-msg-edit-window.c: (get_transports):
3680 * src/modest-account-mgr-helpers.c:
3681 (modest_account_mgr_set_first_account_as_default):
3682 * src/modest-init.c: (init_default_account_maybe):
3683 * src/modest-tny-account-store.c: (get_accounts):
3684 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3685 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
3686 * tests/check_account-mgr.c: (START_TEST):
3687 Provide the extra parameter, as appropriate.
3689 * src/widgets/modest-account-view.c: (update_account_view):
3690 Do not show disabled accounts (meaning that there is no way to
3691 enable/disable accounts in the UI (the feature is not in our UI
3692 specification), so we can use this internally only to mark unfinished
3693 or temporary account data.
3695 * src/maemo/easysetup/modest-easysetup-wizard.c:
3696 (create_account): Add boolean enable parameter, so we can specify FALSE
3697 to create the temporary account.
3698 (on_button_edit_advanced_settings): Create the temporary account as disabled.
3699 (on_before_next): When finishing, when there is a temporary account, just
3701 Also, use a timeout to delay the showing of the dialog until gconf is likely
3702 to return correct information, due to a maemo gconf bug that is fixed in
3703 osso 1.1, but not yet in Bora.
3704 However, the dialog stays on screen after it is destroyed.
3706 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
3707 for invalid data when cancelling. Use a hildon note instead of a dialog
3708 to complain about invalid data. Do not show the account-saved note if the
3709 account is disabled (a temporary account that will not really be saved for use
3712 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3714 * src/modest-account-mgr-helpers.h:
3715 * src/modest-account-mgr-helpers.c:
3716 Added modest_account_mgr_unset_default_account(),
3717 Added modest_account_mgr_set_first_account_as_default().
3719 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
3720 If it was the default account, unset the default account name.
3722 * src/maemo/modest-account-view-window.c:
3723 (on_delete_button_clicked): If it was the default account,
3724 set the first remaining account as the default instead.
3726 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
3727 a NULL account or a NULL default account, to prevent a crash. This should
3728 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
3731 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3733 * src/widgets/modest-recpt-editor.c:
3734 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
3735 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
3736 TODO comment for this. This fixes the build.
3738 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
3739 be the best place for it. This will in future update all auto-update accounts,
3740 rather than just the current/default account, when that gconf key exists.
3741 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
3742 if there are no accounts, before calling do_send_receive().
3743 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
3745 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
3746 * src/maemo/modest-main-window-ui.h:
3747 * src/maemo/modest-main-window.c: (on_connection_changed),
3748 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
3749 directly, becaue the signal handler does more.
3751 2007-04-30 Murray Cumming <murrayc@murrayc.com>
3753 * src/modest-account-mgr-helpers.c:
3754 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
3755 for the case that the account does not exist.
3757 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
3758 (equivalent to the modest account name) rather than the tinymail account name
3759 (equivalent to the modest account title - human readable) to get the account data.
3760 Check for null account data to prevent the crash, and add a TODO comment saying that
3761 this needs fixing because it is using the server account name instead of the account name.
3763 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3765 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
3766 * src/maemo/modest-account-settings-dialog.c: (show_error),
3768 Use hildon_note_new_information() for informative and error messages,
3769 which seems to be expected for Maemo applications (no documentation that I know of
3770 says this). I am surprised that there is no distinction between info and error
3773 2007-04-29 Murray Cumming <murrayc@murrayc.com>
3775 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
3776 it is easy to find where this is used.
3778 * src/maemo/easysetup/modest-easysetup-wizard.c:
3779 (create_page_welcome), (create_page_account_details),
3780 (create_page_user_details), (create_page_complete_easysetup),
3781 (create_page_custom_incoming), (create_page_custom_outgoing),
3782 (create_page_complete_custom):
3783 * src/maemo/modest-account-settings-dialog.c:
3784 (create_page_account_details), (create_page_user_details),
3785 (create_page_incoming), (create_page_outgoing):
3786 * src/maemo/modest-account-view-window.c: (window_vbox_new):
3787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3788 (modest_connection_specific_smtp_edit_window_init):
3789 * src/maemo/modest-connection-specific-smtp-window.c:
3790 (modest_connection_specific_smtp_window_init):
3791 * src/maemo/modest-signature-editor-dialog.c:
3792 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
3793 and scrolling policy as per the Email Application Layout Guide, if I have
3796 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3798 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
3799 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
3800 which were empty, because these vfuncs have been removed from TnyAccountStore.
3801 This fixes the build.
3803 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3805 * src/maemo/modest-main-window.c:
3806 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
3807 showing/hiding it. Added TODO because it probably should not be NULL.
3808 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
3809 because unnecessary g_warnings() make degugging difficult.
3811 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3813 * src/maemo/modest-msg-edit-window.c:
3814 (modest_msg_edit_window_select_color),
3815 (modest_msg_edit_window_select_background_color): 2 const corrections and
3816 moving 2 #endifs before closing brackets, to fix the build.
3818 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3820 * src/maemo/easysetup/modest-easysetup-wizard.h:
3821 * src/maemo/easysetup/modest-easysetup-wizard.c:
3822 (modest_easysetup_wizard_dialog_finalize),
3823 (on_button_edit_advanced_settings), (create_page_complete_custom),
3824 (on_response), (create_account):
3825 Implement the Advanced Settings edit button, by saving the account information,
3826 for the Advanded Settings dialog to use directly from gconf, and removing it
3827 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
3828 Bug #5533 in the projects.maemo.org bugzilla.
3830 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3832 * src/maemo/modest-msg-view-window.c:
3833 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
3834 when opening a message window.
3836 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3838 * src/maemo/easysetup/modest-easysetup-wizard.c:
3839 (create_page_custom_outgoing): Correct the position of the horizontal separator to
3842 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
3843 before showing/hiding them, to avoid a crash when clicking on folders when there are no
3844 gconf settings. I probably added more checks than necessary, but that is safer.
3846 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
3847 variable to fix the build, but this seems to be used when it is still NULL.
3849 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3851 * src/modest-platform.h:
3852 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
3853 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
3854 * src/modest-main.c: Implement this function so we can avoid using
3855 maemo-specific API from cross-platform code.
3857 * src/modest-tny-account-store.c:
3858 (get_smtp_specific_transport_account_for_open_connection):
3859 * src/modest-ui-actions.c: (check_for_connection),
3860 (modest_ui_actions_on_item_not_found):
3861 Use modest_platform_connect_and_wait() and put #idefs around other
3862 maemo-specific code, because only maemo currently has a way to
3863 identify connection names.
3865 2007-04-27 Murray Cumming <murrayc@murrayc.com>
3867 * src/modest-tny-account-store.h:
3868 * src/modest-tny-account-store.c:
3869 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
3870 the connection-specific SMTP server settings in the configuration.
3872 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
3874 * src/maemo/modest-main-window.c: (on_connection_changed),
3876 * src/modest-main.c: (main), (start_ui), (send_mail):
3877 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
3878 that is what is intended.
3880 * src/modest-ui-actions.c: (action_send), (action_receive),
3881 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
3882 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
3883 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
3884 SMTP server is used when it is specified.
3886 (modest_ui_actions_on_send_receive):
3887 Check that a connection is open before proceeding.
3888 Receive and then send, instead of vice-versa, as per the specification.
3890 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3892 * src/modest-mail-operation.c:
3893 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
3894 though I guess it should be something other than NULL.
3896 2007-04-26 Murray Cumming <murrayc@murrayc.com>
3898 * src/maemo/easysetup/modest-easysetup-wizard.c:
3899 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
3900 combo twice, to avoid an g_warning and to make it visible again.
3901 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
3902 attached before detaching it, to avoid a g_warning, and add comment about the implicit
3903 (already intended) dereference when detaching, because we then recreate the menu.
3904 But I am not sure why the warning was happening, and it is possible that this is a memory
3907 2007-04-25 Murray Cumming <murrayc@murrayc.com>
3909 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
3910 and uri_parse_mailto() utility functions.
3911 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
3913 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
3915 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3917 * src/dbus_api/modest-dbus-api.h:
3918 * src/dbus_api/modest-dbus-callbacks.c:
3919 Use an idle callback to execute the modest code in the application's own thread.
3920 Remove the helloworld example method.
3921 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
3922 parsed, and the open-message method is not implemented because this is not yet implemented in
3924 * libmodest-dbus-client/libmodest-dbus-client.c:
3925 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
3926 (libmodest_dbus_client_open_message):
3927 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
3929 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
3930 body without crashing.
3932 * tests/dbus_api/Makefile.am:
3933 * tests/dbus_api/test_mail_to.c:
3934 * tests/dbus_api/test_open_message.c: New tests for the new methods.
3936 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3938 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
3939 Added file to fix the build. Sorry.
3941 * src/dbus_api/Makefile.am:
3942 * src/dbus_api/modest-dbus-api.h:
3943 * src/dbus_api/modest-dbus-callbacks.h:
3944 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
3945 (modest_dbus_req_handler):
3946 Put constants in a separate header so it can be reused by the
3947 client library, without duplication
3949 * libmodest-dbus-client/Makefile.am:
3950 * libmodest-dbus-client/libmodest-dbus-client.c:
3951 (libmodest_dbus_client_call_helloworld),
3952 (libmodfest_dbus_client_send_mail),
3953 (libmodfest_dbus_client_mailto),
3954 (libmodfest_dbus_client_open_message):
3955 * libmodest-dbus-client/libmodest-dbus-client.h:
3956 (Partly) Implement a send_mail D-Bus method.
3958 * tests/dbus_api/Makefile.am:
3959 * tests/dbus_api/test_send_mail.c: (main): Added a test for
3960 the send_email D-Bus method.
3962 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3966 * libmodest-dbus-client/Makefile.am:
3967 * libmodest-dbus-client/libmodest-dbus-client.c:
3968 * libmodest-dbus-client/libmodest-dbus-client.h:
3969 * tests/dbus_api/Makefile.am:
3970 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
3971 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
3973 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3975 * src/maemo/easysetup/modest-easysetup-wizard.c:
3976 (create_page_account_details):
3977 * src/maemo/modest-account-settings-dialog.c:
3978 (create_page_account_details): Explicitly set auto-capitalization mode for the title
3979 widgets, because this might not be the default in future versions of the Maemo GTK+.
3980 However, I can not not get capitalization to work even in a simple test case.
3982 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3984 * src/maemo/easysetup/modest-easysetup-wizard.c:
3985 (create_page_custom_incoming), (create_page_custom_outgoing):
3986 * src/maemo/modest-account-settings-dialog.c:
3987 (create_page_account_details), (create_page_incoming),
3988 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
3989 instead of using gtk_check_button_with_label(), so they are aligned like the other
3990 widgets, as per the UI spec.
3992 2007-04-24 Murray Cumming <murrayc@murrayc.com>
3994 * src/maemo/easysetup/modest-easysetup-wizard.c:
3995 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3996 * src/widgets/modest-validating-entry.c:
3997 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
3998 Modest prefix instead of an EasySetup prefix.
4000 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4002 * src/widgets/modest-validating-entry.h:
4003 * src/widgets/modest-validating-entry.c: (on_insert_text),
4004 Added easysetup_validating_entry_set_max_func(), used to set a callback
4005 to call when the max number of characters is reached. GtkEntry has a max-length
4006 already but is silent about it.
4008 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
4009 (create_page_account_details), (create_page_user_details),
4011 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
4012 (create_page_account_details), (create_page_user_details),
4013 (create_page_outgoing):
4014 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
4015 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
4016 the UI spec, when the user tries to enter more than the max number of characters.
4018 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4020 * src/maemo/easysetup/modest-easysetup-wizard.c:
4021 (create_page_user_details), (create_page_custom_incoming),
4022 (create_page_custom_outgoing):
4023 * src/maemo/modest-account-settings-dialog.c:
4024 (create_page_user_details), (create_page_incoming),
4025 (create_page_outgoing):
4026 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4027 (modest_connection_specific_smtp_edit_window_init):
4028 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
4029 not appropriate. Bad Maemo-specific defaults!.
4031 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4033 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
4034 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
4035 (modest_signature_editor_dialog_set_settings):
4036 Disable the label and textview when the checkbox is disabled, and use the
4037 specified (UI spec) default signature text.
4039 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4041 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4042 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
4044 * src/modest-defs.h:
4045 * src/modest-account-mgr-helpers.h:
4046 * src/modest-account-mgr-helpers.c:
4047 Added modest_account_mgr_get/set_signature(), using new gconf keys.
4049 * src/maemo/Makefile.am:
4050 * src/maemo/modest-signature-editor-dialog.c:
4051 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
4054 * src/maemo/modest-account-settings-dialog.h:
4055 * src/maemo/modest-account-settings-dialog.c:
4056 (modest_account_settings_dialog_finalize), (on_button_signature),
4057 (save_configuration): Use the new dialog when the Edit button is pressed, and
4058 save the changes if necessary, as per the UI spec.
4060 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4062 * src/maemo/Makefile.am:
4063 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
4064 based on maemo-develoers email from Dirk.
4066 * src/maemo/easysetup/modest-easysetup-wizard.c:
4067 (create_page_welcome), (create_page_account_details),
4068 (create_page_user_details), (create_page_complete_easysetup),
4069 (create_page_custom_incoming), (create_page_custom_outgoing),
4070 (create_page_complete_custom),
4071 (modest_easysetup_wizard_dialog_init):
4072 * src/maemo/modest-account-settings-dialog.c:
4073 (create_page_account_details), (create_page_user_details),
4074 (create_page_incoming), (create_page_outgoing),
4075 (modest_account_settings_dialog_init):
4076 * src/maemo/modest-connection-specific-smtp-window.c:
4077 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
4079 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4081 * src/maemo/easysetup/modest-easysetup-wizard.c:
4082 (create_page_account_details), (create_page_custom_outgoing),
4083 (create_page_complete_custom):
4084 * src/maemo/modest-account-settings-dialog.c:
4085 (create_page_user_details), (create_page_incoming),
4086 (create_page_outgoing):
4087 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4088 (modest_connection_specific_smtp_edit_window_init):
4089 Use the correct (UI spec) port min/max, and use horizontal separators,
4092 2007-04-23 Murray Cumming <murrayc@murrayc.com>
4094 * src/maemo/easysetup/modest-easysetup-wizard.c:
4095 (set_default_custom_servernames):
4096 * src/maemo/modest-account-settings-dialog.c:
4097 (create_page_incoming), (on_combo_outgoing_security_changed),
4098 (on_combo_incoming_security_changed), (create_page_outgoing),
4099 (modest_account_settings_dialog_set_account_name),
4100 (save_configuration):
4101 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4102 (on_combo_security_changed),
4103 (modest_connection_specific_smtp_edit_window_init),
4104 (modest_connection_specific_smtp_edit_window_set_connection),
4105 (modest_connection_specific_smtp_edit_window_get_settings):
4106 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
4109 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4112 * src/maemo/easysetup/modest-easysetup-wizard.c:
4113 (create_page_custom_outgoing), (create_page_complete_custom):
4114 * src/maemo/modest-account-settings-dialog.c:
4115 (create_page_user_details), (create_page_outgoing):
4116 * src/maemo/modest-account-view-window.c: (button_box_new):
4117 Use changed logical IDs as per the most recent UI spec:
4118 mcen_bd_emailsetup_edit -> mcen_bd_edit
4119 mcen_bd_emailsetup_delete -> mcen_bd_delete
4120 mcen_bd_emailsetup_close -> mcen_bd_close
4122 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4126 * src/dbus_api/Makefile.am:
4127 * src/dbus_api/modest-dbus-callbacks.c:
4128 * src/dbus_api/modest-dbus-callbacks.h:
4129 * src/maemo/modest-platform.c: (modest_platform_init):
4130 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
4132 * tests/Makefile.am:
4133 * tests/dbus_api/Makefile.am:
4134 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
4136 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4138 * src/maemo/modest-account-settings-dialog.c:
4139 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4140 Removed unnecessary includes.
4142 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4144 * src/maemo/easysetup/modest-easysetup-wizard.c:
4145 * src/maemo/modest-account-settings-dialog.c:
4146 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4147 * src/widgets/Makefile.am:
4148 * src/widgets/modest-easysetup-secureauth-combo-box.c:
4149 * src/widgets/modest-easysetup-secureauth-combo-box.h:
4150 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
4151 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
4152 * src/widgets/modest-secureauth-combo-box.c:
4153 * src/widgets/modest-secureauth-combo-box.h:
4154 * src/widgets/modest-serversecurity-combo-box.c:
4155 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
4156 made the GObject names more consistent with the rest of the Modest code.
4158 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4160 * src/maemo/easysetup/Makefile.am:
4161 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4162 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
4163 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4164 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4165 * src/maemo/easysetup/modest-easysetup-wizard.c:
4166 * src/maemo/easysetup/modest-validating-entry.c:
4167 * src/maemo/easysetup/modest-validating-entry.h:
4168 * src/maemo/modest-account-settings-dialog.c:
4169 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4170 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
4171 widgets/ because they are used outside of easysetup too. After checking in,
4172 svn will allow me to rename them too.
4174 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4176 * src/gnome/modest-msg-edit-window.c:
4177 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
4178 linker error, to fix the build on the GNOME platform.
4179 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
4180 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
4181 ifdefed out to avoid a warning.
4183 2007-04-20 Murray Cumming <murrayc@murrayc.com>
4185 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
4186 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
4187 some alternative for GTK+ 2.6.
4189 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4191 * src/maemo/modest-address-book.c: Added include to avoid a warning.
4193 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
4194 specified for EmailAccountsDialog in UI spec.
4196 * src/maemo/easysetup/modest-easysetup-wizard.c:
4197 * src/maemo/easysetup/modest-easysetup-wizard.h:
4198 * src/maemo/modest-account-settings-dialog.c:
4199 * src/maemo/modest-account-settings-dialog.h:
4200 Reuse a member window widget for the connection-specific SMTP server accounts,
4201 so we can tell it to create/save the accounts only if we actually save changes.
4203 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4204 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4205 (modest_connection_specific_smtp_edit_window_get_settings):
4206 Return a struct instance for temporarily remembering the entered data.
4208 * src/maemo/modest-connection-specific-smtp-window.h:
4209 * src/maemo/modest-connection-specific-smtp-window.c:
4210 (modest_connection_specific_smtp_window_finalize),
4211 (modest_connection_specific_smtp_window_fill_with_connections),
4213 (modest_connection_specific_smtp_window_save_server_accounts),
4214 (update_model_server_names): Do not actually save data until asked,
4215 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
4217 (on_selection_changed),
4218 (modest_connection_specific_smtp_window_init): Disable the edit
4219 button when nothing is selected.
4221 * src/modest-account-mgr-helpers.c:
4222 * src/modest-account-mgr-helpers.h:
4223 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
4226 2007-04-19 Murray Cumming <murrayc@murrayc.com>
4228 * src/modest-account-mgr-helpers.h:
4229 * src/modest-account-mgr-helpers.c:
4230 (modest_account_mgr_get_unused_account_name),
4231 (modest_account_mgr_get_unused_account_display_name): Added these
4232 utility functions, to avoid code duplication.
4234 * src/maemo/easysetup/modest-easysetup-wizard.c:
4235 (create_page_account_details), (create_account):
4236 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4237 (on_combo_security_changed),
4238 (modest_connection_specific_smtp_edit_window_init),
4239 (modest_connection_specific_smtp_edit_window_save_settings):
4240 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4241 * src/maemo/modest-connection-specific-smtp-window.c:
4242 (modest_connection_specific_smtp_window_finalize),
4243 (modest_connection_specific_smtp_window_fill_with_connections),
4244 (on_button_edit), (modest_connection_specific_smtp_window_init):
4245 * src/maemo/modest-connection-specific-smtp-window.h:
4246 Implementing saving of connection-specific server accounts.
4248 But I need to refactor this so we can save the data for each
4249 possible connection-specific account and only actually create the server accounts
4250 when the easysetup finished, or the OK button is pressed on the account settings
4253 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4255 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4256 (on_combo_security_changed):
4257 (modest_connection_specific_smtp_edit_window_init):
4258 Auto-fill the port number as in the account settings.
4260 (modest_connection_specific_smtp_edit_window_set_connection):
4261 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4262 * src/maemo/modest-connection-specific-smtp-window.c:
4263 (fill_with_connections), (on_button_edit),
4264 (modest_connection_specific_smtp_window_init):
4265 Turn the edit window into a dialog to simplify the code, and
4266 set a WM hint as in a GtkDialog, because only a popup can be on top of
4267 another window in Maemo, and popups usually have no WM decoration.
4269 * src/modest-defs.h:
4270 * src/modest-account-mgr-helpers.c:
4271 (modest_account_mgr_set_connection_specific_smtp),
4272 (modest_account_mgr_remove_connection_specific_smtp),
4273 (modest_account_mgr_get_connection_specific_smtp):
4274 * src/modest-account-mgr-helpers.h: Some functions to write the
4275 connection-specific SMTP server information. Not yet used.
4278 * src/widgets/modest-folder-view.c: (text_cell_data):
4279 Fix a warning about an uninitialized variable.
4280 (on_configuration_key_changed): Put an #ifdef around the use
4281 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
4283 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4285 * src/maemo/modest-account-settings-dialog.h:
4286 * src/maemo/modest-account-settings-dialog.c:
4287 Added connect_for_modified() utility function to mark the new modified boolean.
4289 (create_page_account_details), (create_page_user_details),
4290 (create_page_incoming), (create_page_outgoing), (on_response),
4291 (modest_account_settings_dialog_init),
4292 (modest_account_settings_dialog_set_account_name):
4293 Only warn about unsaved changes when there are actually unsaved changes.
4295 * src/modest-account-mgr-helpers.c:
4296 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
4297 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
4298 to get the data from there in future.
4300 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4302 * src/modest-defs.h:
4304 * src/modest-account-mgr-helpers.h:
4305 * src/modest-account-mgr-helpers.c:
4306 Store the security account setting in a single conf key instead of using
4307 the options list, so that the list is left for just the to-be-removed camel hack,
4308 and because gconf_client_set_list() is failing for some reason.
4310 * src/modest-account-mgr.c:
4311 (modest_account_mgr_add_server_account):
4312 * src/maemo/modest-account-settings-dialog.c:
4313 (modest_account_settings_dialog_set_account_name),
4314 (save_configuration): Use the renamed functions.
4317 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4319 * src/widgets/Makefile.am:
4320 * src/widgets/modest-limit-retrieve-combo-box.c:
4321 * src/widgets/modest-limit-retrieve-combo-box.h:
4322 * src/widgets/modest-retrieve-combo-box.c:
4323 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
4324 the account settings dialog.
4326 * src/modest-defs.h:
4327 * src/modest-account-mgr-helpers.h:
4328 * src/modest-account-mgr-helpers.c:
4329 (modest_server_account_get_option_secure_auth),
4330 (modest_server_account_set_option_secure_auth):
4331 * src/modest-account-mgr.c:
4332 (modest_account_mgr_add_server_account):
4333 Use the existing AUTH_MECH conf key for the secure-auth setting,
4334 instead of putting it in the list options, because this was actually used already.
4336 * src/maemo/modest-account-settings-dialog.c:
4337 (create_page_account_details),
4338 (modest_account_settings_dialog_set_account_name),
4339 (save_configuration):
4340 * src/maemo/modest-account-settings-dialog.h:
4341 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
4342 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
4344 2007-04-18 Murray Cumming <murrayc@murrayc.com>
4346 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
4347 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
4348 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
4350 * src/modest-defs.h:
4351 * src/maemo/modest-account-settings-dialog.c:
4352 (create_page_incoming), (on_combo_outgoing_security_changed),
4353 (on_combo_incoming_security_changed), (create_page_outgoing),
4354 (modest_account_settings_dialog_set_account_name),
4355 (save_configuration): Load/Save the port number, and change it when the
4356 security combo changes, to suitable defaults.
4358 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4360 * src/modest-account-mgr.c:
4361 (modest_account_mgr_add_server_account): Set the security and secure-auth
4362 options, and add a comment saying that the other camel-specific options should be
4365 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4367 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
4369 * src/modest-tny-account-store.c: (account_list_free),
4370 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
4371 cursor->data after unreffing it. But there is some strange stuff there so it might not be
4374 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4376 * src/modest-protocol-info.c:
4377 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
4378 is required by our UI spec. Maybe something in our implementation will use this eventually.
4379 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
4380 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
4381 instead of the previous 0 placeholder.
4383 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
4384 secure-auth settings.
4385 * src/modest-account-mgr-helpers.h:
4386 * src/modest-account-mgr-helpers.c:
4387 (modest_server_account_data_get_option_secure_auth),
4388 (modest_server_account_set_option_secure_auth),
4389 (modest_server_account_data_get_option_security),
4390 (modest_server_account_set_option_security): Added this API for getting and setting the security
4391 and secure-auth settings.
4393 * src/maemo/modest-account-settings-dialog.h:
4394 * src/maemo/modest-account-settings-dialog.c:
4395 (modest_account_settings_dialog_finalize), (check_data),
4396 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
4397 about changing titles.
4398 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
4399 (save_configuration): Save the security and secure-auth settings.
4401 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
4402 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
4404 2007-04-17 Murray Cumming <murrayc@murrayc.com>
4406 * src/modest-defs.h:
4407 * src/modest-account-mgr.c:
4408 (modest_account_mgr_add_server_account):
4409 Added and used defines for the options key and value pair strings,
4410 that are used so far, though they do not seem to correspond to anything in our
4411 UI specs or ModestProtocol enum.
4413 * src/modest-account-mgr-helpers.h:
4414 * src/modest-account-mgr-helpers.c:
4415 (compare_option_strings_for_name),
4416 (modest_server_account_data_get_option_value),
4417 (modest_server_account_data_get_option_bool),
4418 (modest_account_mgr_get_server_account_option):
4419 Added helper functions for parsing the options GSList.
4421 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4423 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
4424 display name is based on the supplied account name.
4425 * src/modest-account-mgr.c:
4426 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
4427 with an inefficient, but good-enough, implementation.
4429 * src/maemo/easysetup/modest-easysetup-wizard.c:
4430 (create_page_account_details), (on_before_next), (create_account):
4431 Check for existing display names rather than (non-user-visible) account names, and just
4432 create and set a unique account name at the end.
4434 * src/maemo/modest-account-settings-dialog.c:
4435 (modest_account_settings_dialog_init),
4436 (modest_account_settings_dialog_set_account_name),
4437 (create_page_incoming): Show the display name, instead of the account name.
4438 (on_response): Do some (not all) extra checks, as in the UI spec.
4439 (save_configuration): Save the display name if it was changed.
4441 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4443 * po/en_GB.po: Added needed logical ID and translation.
4444 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4445 (init_view): Made the is-default column clicking work.
4447 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4450 * src/maemo/easysetup/Makefile.am:
4451 * src/maemo/easysetup/modest-easysetup-wizard.c:
4452 (modest_easysetup_wizard_dialog_init):
4453 * src/maemo/easysetup/provider-data-test.keyfile:
4454 * src/maemo/easysetup/provider-data.keyfile:
4455 Moved the provider data file to the new modest-providers-data package and used it from there.
4457 2007-04-16 Murray Cumming <murrayc@murrayc.com>
4459 * src/modest-local-folder-info.c:
4460 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
4461 N_() was already used on the static strings, but this just marks it for translation without
4462 using the translation.
4464 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4466 * src/maemo/modest-account-settings-dialog.c:
4467 (create_page_incoming),
4468 (modest_account_settings_dialog_set_account_name):
4469 Added comments about the need for new API in ModestAccountMgr to handle the authentication
4470 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
4471 I will do this if nobody else gets there first.
4473 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4475 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
4476 Saved much of the incoming and outgoing data too, though I cannot yet see how to
4477 save the security stuff.
4479 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4481 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4482 Set the email address and user fullname, which I now see must be
4485 * src/maemo/modest-account-settings-dialog.h:
4486 * src/maemo/modest-account-settings-dialog.c:
4488 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
4489 leave-on-server and authentication.
4490 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
4493 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4496 * src/maemo/modest-account-settings-dialog.c:
4497 * src/maemo/modest-account-settings-dialog.h:
4498 Most (but not all) of the widgets are now present as specified by the UI spec.
4499 No changes are yet saved, and some details are not properly shown yet.
4501 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
4503 2007-04-06 Murray Cumming <murrayc@murrayc.com>
4505 * src/maemo/Makefile.am:
4506 * src/maemo/modest-account-settings-dialog.c:
4507 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
4508 an existing account. Doesn't do much yet.
4510 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
4511 Open the accounts settings dialog when Edit is clicked.
4513 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4515 * src/maemo/easysetup/Makefile.am:
4516 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4518 * src/maemo/easysetup/modest-easysetup-wizard.c:
4519 (modest_easysetup_wizard_dialog_init):
4520 Try to get the source directory from the build system,
4521 instead of hard-coding "./" into the source code, when opening our local
4522 copies of the configuration files.
4523 But this still fails when opening the wizard from the Accounts window,
4524 maybe because the working directory seems to change at runtime.
4525 So the wizard will fail the second time unless you copy the files into their
4526 proper locations - see the stdout warnings for the paths.
4528 (create_page_account_details),(on_before_next):
4529 Check for existing non-server accounts instead of server accounts,
4530 so the default account name is useful again, and to prevent trying to
4533 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
4534 Show the wizard when New is clicked.
4536 * src/widgets/modest-account-view.c: (on_account_default_toggled),
4537 (init_view): Show the column headers, and show the columns that are
4538 specified in the UI specs. However, something in Maemo's GTK+ prevents
4539 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
4540 change the default account. This is despite unsetting the special properties.
4542 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4544 * docs/reference/modest-design.sgml: Corrected spelling mistake.
4545 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4546 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
4547 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
4548 to make that clearer.
4549 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
4551 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4553 * src/maemo/modest-account-view-window.c:
4554 (modest_account_view_window_init),
4555 (modest_account_view_window_new):
4556 Use the same buttons as specified in the
4557 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
4558 the existing widgets, which never had a chance of working.
4559 Put the ModestAccountView treeview in a scrolled window.
4560 Do not repeat the initialization in both _init() and _new().
4562 * src/widgets/modest-account-view.c: (update_account_view):
4563 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
4564 this widget and window shows no accounts.
4566 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
4568 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4570 * src/maemo/easysetup/modest-easysetup-wizard.c:
4571 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
4572 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
4573 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
4576 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
4577 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
4578 accounts exist yet, as in the UI spec.
4580 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
4582 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4584 * src/maemo/Makefile.am:
4585 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4586 * src/maemo/modest-connection-specific-smtp-edit-window.h:
4587 New window for editing connection-specific smtp details.
4588 Not fully implemented.
4590 * src/maemo/modest-connection-specific-smtp-window.c:
4591 (modest_connection_specific_smtp_window_finalize) :
4592 unref the tree model.
4593 (on_button_edit): Show the edit window.
4595 2007-04-05 Murray Cumming <murrayc@murrayc.com>
4597 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
4600 * src/maemo/Makefile.am:
4601 * src/maemo/modest-connection-specific-smtp-window.c:
4602 * src/maemo/modest-connection-specific-smtp-window.h:
4603 New window for showing the list of connections, for connection-specific
4604 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
4605 * src/maemo/easysetup/modest-easysetup-wizard.c:
4606 (create_page_custom_outgoing): Show the new window when the button is clicked.
4608 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4610 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
4611 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4612 * src/maemo/modest-msg-edit-window.c:
4613 (modest_msg_edit_window_insert_image):
4614 * src/modest-conf.c: (modest_conf_key_escape):
4615 * src/modest-mail-operation.c:
4616 (modest_mail_operation_send_new_mail):
4617 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
4618 (modest_ui_actions_on_new_account):
4619 * src/widgets/modest-attachment-view.c: (update_filename_request):
4620 * src/widgets/modest-mail-header-view.c:
4621 Corrected warnings that were breaking the build, by commenting out unused variables,
4622 and a function, and by including a header.
4624 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4626 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
4627 so we can #ifdef around platform-specific code when necessary.
4628 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
4629 to allow this to build for the GNOME platform too.
4631 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4633 * src/maemo/easysetup/modest-easysetup-wizard.c:
4634 Added util_increment_name() and used it in create_page_account_details()
4635 to make sure that the default account name is always a new name.
4637 (modest_easysetup_wizard_dialog_init),
4638 (set_default_custom_servernames): Some minor memory management fixes.
4640 2007-04-04 Murray Cumming <murrayc@murrayc.com>
4644 * src/modest-runtime.c: (init_i18n): Restored the translation
4645 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
4646 are defined in config.h, and the translations are installed.
4648 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
4649 is defined for translation.
4651 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4653 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
4655 * src/maemo/easysetup/modest-easysetup-wizard.c:
4656 (modest_easysetup_wizard_dialog_init):
4657 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
4658 Use realistic paths (though they should use $prefix generically) to the
4659 mcc_mapping and provider-data.keyfile files which might work when they
4660 are installed by the future version of the operator-wizard package,
4661 and then fallback to paths in our source code, with an explanatory
4664 2007-04-03 Murray Cumming <murrayc@murrayc.com>
4668 * src/maemo/Makefile.am:
4669 * src/maemo/easysetup/: Added files from the previously-exernal
4670 osso-modest-easysetup.
4671 * src/maemo/modest-main-window-ui.h:
4672 * src/modest-ui-actions.c:
4673 * src/modest-ui-actions.h:
4674 Added modest_ui_actions_on_new_account() as a signal handler for the
4675 New Account menu item. It shows the easysetup wizard.
4676 * po/en_GB.po: Added additional needed logical IDs and translations.