Javier Fernandez Garcia-Boente [Tue, 29 May 2007 10:04:41 +0000 (10:04 +0000)]
* Fix bug on create_account wizard.
retrieve_type was not set when a new account
is created. I set 'Headers only' type as
default value.
pmo-trunk-r1984
Sergio Villar Senin [Tue, 29 May 2007 06:51:16 +0000 (06:51 +0000)]
* Added some comments
* Deleted unneccessary async helper structure
pmo-trunk-r1983
Murray Cumming [Mon, 28 May 2007 16:52:15 +0000 (16:52 +0000)]
2007-05-28 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-global-settings-dialog.c:
(current_connection):
* src/widgets/modest-global-settings-dialog.c:
(current_connection_default):
Use the enum values instead of 0, 1 and -1,
to make the code clearer.
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_get_connection_specific_smtp): Make this code
more robust.
* src/modest-runtime.h:
* src/modest-runtime.c:
Added modest_runtime_remove_all_send_queues().
* src/maemo/modest-main-window.c:
(on_account_store_connecting_finished): Recreate the send queues,
using the appropriate transport accounts for this new connection.
Some futher adapting might be needed if the old send queues are not
automatically stopped at this point.
* src/modest-tny-account-store.c: (get_server_accounts):
Create the connection-specific transport accounts, so that they can
be found later by their ID.
* src/modest-tny-account.h:
* src/modest-tny-account.c:
Added modest_tny_account_new_from_server_account_name().
modest_tny_account_new_from_server_account(): Do not create the
send queues here, because they will be
recreated anyway when the connection changes for the first time.
pmo-trunk-r1982
Sergio Villar Senin [Mon, 28 May 2007 16:38:11 +0000 (16:38 +0000)]
* Fixes NB#57398
pmo-trunk-r1981
Sergio Villar Senin [Mon, 28 May 2007 10:27:19 +0000 (10:27 +0000)]
* Sort messages by date, before retrieving the last N ones
pmo-trunk-r1980
Murray Cumming [Mon, 28 May 2007 09:48:34 +0000 (09:48 +0000)]
2007-05-28 Murray Cumming <murrayc@murrayc.com>
* src/modest-local-folder-info.h:
* src/modest-local-folder-info.c:
(modest_per_account_local_outbox_folder_info_get_maildir_path),
(modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
tbox_folder): Take a modest account name instead of a server TnyAccount,
so we can have per-modest-account rather than per-transport-account
outboxes.
We must make sure that we change or recreate the exisitng send queues
when the connection changes for connection-specific transport accounts.
* src/modest-tny-account-store.c:
(create_per_account_local_outbox_folders): Create outboxed per modest
account, not per transport account.
* src/modest-tny-account.h:
* src/modest-tny-account.c:
(modest_tny_account_get_special_folder): For outboxes, get the
parent modest account name. The account is ignored for other folders.
(modest_tny_account_new_for_per_account_local_outbox_folder): Take a
modest account name rather than a server TnyAccount.
pmo-trunk-r1979
Sergio Villar Senin [Mon, 28 May 2007 08:18:45 +0000 (08:18 +0000)]
* Only return the local account if we're asking for store accounts
pmo-trunk-r1978
Murray Cumming [Mon, 28 May 2007 08:16:02 +0000 (08:16 +0000)]
Added a TODO comment
pmo-trunk-r1977
Murray Cumming [Fri, 25 May 2007 11:07:29 +0000 (11:07 +0000)]
2007-05-25 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
Call modest_runtime_get_send_queue() immediately after creating transport
accounts, so that they start trying to send email from the outbox as soon
as possible at startup. This is probably what we want.
* src/modest-mail-operation.c: (update_account_thread):
* src/modest-runtime.c: (modest_runtime_get_send_queue):
* src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
* src/modest-tny-send-queue.h:
* src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
(modest_ui_actions_on_send):
Added comments about how sending works, though it needs some more work.
pmo-trunk-r1976
Murray Cumming [Fri, 25 May 2007 09:19:25 +0000 (09:19 +0000)]
Make the debug messages slightly more attractive.
pmo-trunk-r1975
Murray Cumming [Fri, 25 May 2007 09:08:15 +0000 (09:08 +0000)]
2007-05-25 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_get_special_folder): Add TODO because this fails when
the network is busy.
(modest_tny_folder_store_get_local_size): Fix an incorrect type check.
* src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
Do not try to show this window when there is no active account. The UI
specs does not tell us what to do in this case.
pmo-trunk-r1974
Sergio Villar Senin [Thu, 24 May 2007 16:48:44 +0000 (16:48 +0000)]
* Added mcen_nc_get_multi_msg_txt confirmation dialog when replying/forwarding a mail
pmo-trunk-r1973
Sergio Villar Senin [Thu, 24 May 2007 15:25:31 +0000 (15:25 +0000)]
* Added per-message size limit to send&receive
* Added per-account amount limit to s&r
* Added per-account retrieve last N feature
* Added an unique id to each mail operation
* Renamed id field of mail operation by operation type
* Added ModestMailOperationState to provide progress information
* Added a new parameter of type ModestMailOperationState to progress-changed signal
* Added an internal object to mail operation to get the new messages after a refresh
pmo-trunk-r1972
Murray Cumming [Thu, 24 May 2007 14:40:48 +0000 (14:40 +0000)]
2007-05-24 Murray Cumming <murrayc@murrayc.com>
* Makefile.am:
* po/POTFILES.in:
* src/maemo/Makefile.am:
* src/widgets/Makefile.am: Some dist fixes.
pmo-trunk-r1971
Murray Cumming [Thu, 24 May 2007 12:31:42 +0000 (12:31 +0000)]
2007-05-24 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-connection-specific-smtp-window.c:
(on_button_edit): Make the code clearer, to prevent a double free.
pmo-trunk-r1970
Murray Cumming [Thu, 24 May 2007 11:56:19 +0000 (11:56 +0000)]
2007-05-24 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name),
Check the connection-specific smtp servers checkbox if there are any.
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init):
Start with a suitable port number.
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr-helpers.c: Added
modest_account_mgr_get_has_connection_specific_smtp().
(modest_account_mgr_set_connection_specific_smtp),
(modest_account_mgr_remove_connection_specific_smtp),
(modest_account_mgr_get_has_connection_specific_smtp),
(modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
connection-specific smtp server accounts in the account, rather than
the server account conf dir.
This fixes bug projects.maemo.org bug NB#58263 .
* src/modest-tny-account-store.c:
(create_per_account_local_outbox_folders): Do not call get_server_accounts()
if there are no server accounts yet, to prevent an infinite loop when there
are no accounts. Document that one must be called before the other.
pmo-trunk-r1969
Murray Cumming [Thu, 24 May 2007 10:40:39 +0000 (10:40 +0000)]
2007-05-24 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr-helpers.c:
(modest_account_mgr_get_default_account): Make sure that at least
one account is always the default, if there are any enabled accounts.
This is just a sanity check that shouldn't be necessary.
* src/modest-account-mgr-priv.c:
(_modest_account_mgr_account_from_key): Unescape the conf key to
get the real account name. For instance, this is an issue if a space
was in the account name, which can happen because the account name
is generated from the display name.
(_modest_account_mgr_get_account_keyname): Always escape the
account name.
* src/modest-account-mgr.c: (modest_account_mgr_account_names):
Unescape the conf keys to get the real account names.
For instance, previously the is-default radio button in the accounts
list was not checked for any accounts at first. This fixes that,
and might fix several similar bugs.
pmo-trunk-r1968
Murray Cumming [Thu, 24 May 2007 08:26:03 +0000 (08:26 +0000)]
Remove unnecessary check and add a comment.
pmo-trunk-r1967
Sergio Villar Senin [Thu, 24 May 2007 08:20:35 +0000 (08:20 +0000)]
* Removed an invalid comment
pmo-trunk-r1966
Murray Cumming [Wed, 23 May 2007 16:47:32 +0000 (16:47 +0000)]
2007-05-23 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (set_active_account_from_tny_account):
Removed some debug printfs.
pmo-trunk-r1965
Murray Cumming [Wed, 23 May 2007 16:45:57 +0000 (16:45 +0000)]
2007-05-23 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c: (set_active_account_from_tny_account):
Removed some debug printfs.
pmo-trunk-r1964
Murray Cumming [Wed, 23 May 2007 14:05:45 +0000 (14:05 +0000)]
2007-05-23 Murray Cumming <murrayc@murrayc.com>
Modest on-disk outbox directories are now here, for instance:
/home/murrayc/.modest/outboxes/<account-id-1>/outbox
/home/murrayc/.modest/outboxes/<account-id-2>/outbox
instead of here:
/home/murrayc/.modest/local-folders/outbox
so we can have a separate outbox for each account.
But they are shown as one outbox in the GtkTreeView, by using a
TnyMergeFolder in a ModestTnySimpleFolderStore.
* src/Makefile.am:
* src/modest-tny-simple-folder-store.c:
* src/modest-tny-simple-folder-store.h:
Added ModestTnySimpleFolderStore, used to contain folders from
other folder stores, such as other accounts.
* src/modest-tny-outbox-account.h:
* src/modest-tny-outbox-account.c:
Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
used for the per-account local outbox folders.
* src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
only use this (internally) now for the non-outbox local folders.
* src/modest-init.h:
* src/modest-init.c: Added modest_init_one_local_folder(), for
setting up the directory structure for each local folder.
* src/modest-local-folder-info.c:
(modest_per_account_local_outbox_folder_info_get_maildir_path),
(modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
tbox_folder):
* src/modest-local-folder-info.h:
* src/modest-tny-account-store.c: (on_account_removed),
(on_account_changed), (create_per_account_local_outbox_folders),
(get_server_accounts), (modest_tny_account_store_get_accounts),
(modest_tny_account_store_get_tny_account_by_account),
(modest_tny_folder_store_is_virtual_local_folders):
* src/modest-tny-account.h:
* src/modest-tny-account.c:
Added modest_tny_account_new_for_per_account_local_outbox_folder(),
to create an on-disk per-account local outbox folder for each
transport account.
(create_per_account_local_outbox_folders): Create a local outbox folder
for each transport account.
(modest_tny_account_new_for_local_folders): Do not create an outbox folder
for all local folders.
Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
instead of using g_object_get/set() directly. It is clearer.
(modest_tny_folder_store_get_message_count),
(modest_tny_folder_store_get_local_size
(modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
because we now use these with non-acount folder stores.
(modest_tny_account_get_special_folder),
(modest_tny_account_new_from_server_account),
(modest_tny_account_new_from_account):
(recurse_folders): Adjust to the new outbox system.
* src/modest-tny-folder.h:
* src/modest-tny-folder.c:
(modest_tny_folder_is_local_folder),
(modest_tny_folder_get_local_folder_type),
(modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
* src/widgets/modest-main-window.h:
* src/maemo/modest-main-window.c: (create_details_widget),
(modest_main_window_set_contents_style): Show details for any folder store,
not just accounts.
(modest_tny_folder_get_rules):
Remove the const. C does not support constness enough for this.
* src/modest-ui-actions.c:
update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
make all outboxes appear as one, in the usual local-folders tree node.
(set_active_account_from_tny_account),
(modest_ui_actions_on_folder_selection_changed):
* src/widgets/modest-folder-view.c: (text_cell_data),
(icon_cell_data), (filter_row),
(add_account_folders_to_merged_folder),
(add_account_folders_to_simple_folder_store), (),
(get_cmp_rows_type_pos), (cmp_rows),
(modest_folder_view_set_account_id_of_visible_server_account):
Adjust to the new outbox system, using generic folder stores and folder
in the GtkTreeModel.
pmo-trunk-r1963
Christian Kellner [Wed, 23 May 2007 11:48:24 +0000 (11:48 +0000)]
2007-05-23 Christian Kellner <ckellner@openismus.com>
* src/modest-mail-operation.c:
(modest_mail_operation_update_account):
Use info->max_size instead of unintialized local var [small
build fix]. (Added TODO to review that change since I don't
know the code)
pmo-trunk-r1962
Sergio Villar Senin [Wed, 23 May 2007 08:20:29 +0000 (08:20 +0000)]
* First steps to apply global and per-account settings to send&receive
pmo-trunk-r1961
Sergio Villar Senin [Wed, 23 May 2007 07:30:54 +0000 (07:30 +0000)]
* Fixes NB#57328
* Fixed a memory leak
pmo-trunk-r1960
Marcus Bauer [Wed, 23 May 2007 07:10:55 +0000 (07:10 +0000)]
2007-05-23 Marcus Bauer <marcusb@openismus.com>
* libmodest-dbus-client/libmodest-dbus-client.c:
(libmodest_dbus_client_compose_mail): function added
* src/dbus_api/modest-dbus-api.h:
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
(on_compose_mail): Implementation of the SendAsMail functionality
pmo-trunk-r1959
Sergio Villar Senin [Tue, 22 May 2007 18:18:55 +0000 (18:18 +0000)]
* Reverted the two new folder rules, both are NON_WRITABLE
pmo-trunk-r1958
Sergio Villar Senin [Tue, 22 May 2007 17:54:40 +0000 (17:54 +0000)]
* Added some missing rules to the xfer_folder and xfer_msgs operations
pmo-trunk-r1956
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:40:54 +0000 (17:40 +0000)]
* move modest/scripts to modest-script (separate place)
pmo-trunk-r1955
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:39:18 +0000 (17:39 +0000)]
* add some error error checking when trying to retrieve the device name
pmo-trunk-r1954
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:34:47 +0000 (17:34 +0000)]
* remove wrong dep
pmo-trunk-r1953
Dirk-Jan C. Binnema [Tue, 22 May 2007 17:32:23 +0000 (17:32 +0000)]
* remove changelog2 in garage
pmo-trunk-r1952
Sergio Villar Senin [Tue, 22 May 2007 16:56:16 +0000 (16:56 +0000)]
* Fixes: NB#57465
* Fixed a bug in the account store
* Fixed several memory leaks
* Refactored the code that loads a list of messages from the headers
* Improved reference counting in msg view window
* Added modest_mail_operation_get_source
* Added the global account settings default values to modest init
pmo-trunk-r1950
Dirk-Jan C. Binnema [Tue, 22 May 2007 12:30:58 +0000 (12:30 +0000)]
* updated debian/changelog
pmo-trunk-r1949
Dirk-Jan C. Binnema [Tue, 22 May 2007 12:28:09 +0000 (12:28 +0000)]
* put shlib symlinks in the library package
pmo-trunk-r1948
Murray Cumming [Tue, 22 May 2007 09:05:51 +0000 (09:05 +0000)]
2007-05-22 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c:
(modest_account_mgr_add_server_account): Set the secure-connection
conf key for transport accounts as well as store accounts. I don't know
why the if was there. For instance, this makes sure that we use SSL
for the gmail preset from the easysetup wizard.
pmo-trunk-r1947
Sergio Villar Senin [Tue, 22 May 2007 08:49:46 +0000 (08:49 +0000)]
* Fixes NB#57478
* Fixes NB#57325
pmo-trunk-r1946
Murray Cumming [Tue, 22 May 2007 08:21:20 +0000 (08:21 +0000)]
2007-05-22 Murray Cumming <murrayc@murrayc.com>
* src/gnome/modest-main-window.c:
(on_account_store_connecting_finished), (connect_signals):
* src/maemo/modest-main-window.c:
(on_account_store_connecting_finished), (connect_signals),
(modest_main_window_new):
Handle TnyAccountStore::connecting-finished instead of
TnyDevice::connection-changed, because we cannot actually perform
operations on accounts until TnyAccountStore has itself responded to
the TnyDevice::connection-changed signal. This prevents a GError from
tinymail.
Do not try to update at startup, because we (at least on scratchbox)
already do an update at startup when the device goes online.
This prevents a GError from tinymail.
* src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
Added TODO about stopping simultaneous operations.
pmo-trunk-r1945
Marcus Bauer [Tue, 22 May 2007 06:39:06 +0000 (06:39 +0000)]
2007-05-22 Marcus Bauer <marcusb@openismus.com>
* src/dbus_api/modest-dbus-api.h:
added MODEST_DBUS_METHOD_COMPOSE_MAIL
* src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
(on_compose_mail), (on_idle_open_message),
(modest_dbus_req_handler):
added on_compose_mail()
pmo-trunk-r1944
Dirk-Jan C. Binnema [Mon, 21 May 2007 18:48:31 +0000 (18:48 +0000)]
* update the scripts
pmo-trunk-r1943
Murray Cumming [Mon, 21 May 2007 14:46:40 +0000 (14:46 +0000)]
2007-05-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-account-mgr.c: (modest_account_mgr_add_account):
* src/modest-mail-operation-queue.c:
(modest_mail_operation_queue_remove):
* src/modest-tny-account-store.c: When GErrors happen, give more clues
about where they happened.
pmo-trunk-r1942
Sergio Villar Senin [Mon, 21 May 2007 14:36:27 +0000 (14:36 +0000)]
* Removed xfer_folder_async, all the xfer_folder operations are now async
* Fixed a logical error when drag&drop
pmo-trunk-r1941
Murray Cumming [Mon, 21 May 2007 13:35:22 +0000 (13:35 +0000)]
2007-05-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-ui-actions.c:
(modest_ui_actions_on_password_requested): Make sure that the remember
output parameter is always TRUE.
pmo-trunk-r1940
Murray Cumming [Mon, 21 May 2007 13:18:03 +0000 (13:18 +0000)]
2007-05-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (modest_tny_account_store_alert):
Show a OK/Cancel dialog if the error is a question, though we still do not
know anything more about what we are asking the user.
* src/widgets/modest-folder-view.c: (on_drag_data_received):
Fix an uninitialized variable (helper). This is a logic error, however.
pmo-trunk-r1939
Sergio Villar Senin [Mon, 21 May 2007 12:53:48 +0000 (12:53 +0000)]
* Fixed drag&drop for folders
* Fixed drag&drop for headers
* Added progress-changed notification to all mail operations when they finish
* Fixed a bug when selecting folders in the UI actions
* Added some debug code to the mail operation queue, prints mail operation errors
pmo-trunk-r1938
Javier Fernandez Garcia-Boente [Mon, 21 May 2007 11:27:16 +0000 (11:27 +0000)]
* Removed call to mail_operation_queue_remove from
ui-actions, and put it into mail_operation.
pmo-trunk-r1937
Javier Fernandez Garcia-Boente [Mon, 21 May 2007 10:40:06 +0000 (10:40 +0000)]
* modest-mail-operation.c: Set FAILED status if an exception is received.
* modest-ui-actions.c: check if copy_folder_async failed to
remove mail operation from queue.
pmo-trunk-r1936
Christian Kellner [Mon, 21 May 2007 10:27:04 +0000 (10:27 +0000)]
2007-05-21 Christian Kellner <ckellner@openismus.com>
* src/modest-search.h:
Correct bit shifting in the ModestSearchFlags enum.
pmo-trunk-r1935
Murray Cumming [Mon, 21 May 2007 10:18:26 +0000 (10:18 +0000)]
2007-05-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account): Do not use the lsub and
check-all hard-coded IMAP options when using POP.
pmo-trunk-r1934
Murray Cumming [Mon, 21 May 2007 10:02:53 +0000 (10:02 +0000)]
2007-05-21 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
Use NULL for the secure-auth method for POP when Password auth has been
specified by the user, as we already do for IMAP. auth=Login causes
an error from camel or the server.
pmo-trunk-r1933
Dirk-Jan C. Binnema [Sun, 20 May 2007 16:19:13 +0000 (16:19 +0000)]
* update for tinymail API change
pmo-trunk-r1929
Dirk-Jan C. Binnema [Sun, 20 May 2007 13:51:02 +0000 (13:51 +0000)]
* also allow pop-accounts to come without authentication options;
one step further in supporting pop.gmail.com
pmo-trunk-r1928
Dirk-Jan C. Binnema [Sun, 20 May 2007 13:10:46 +0000 (13:10 +0000)]
* account options should *not* include spaces... according to
tny_account_get_url_string, the options would look like [...];use_ssl=%20always;[...]
ie. with the %20... this broke pop.gmail.com, and probably all accounts which
need options.
pmo-trunk-r1927
Dirk-Jan C. Binnema [Sun, 20 May 2007 11:04:12 +0000 (11:04 +0000)]
* workaround for the slow gconf-notifications on maemo; now, (on maemo),
modest-conf will send the change notifications by itself, 100 ms after
a change has been made, and ignores the notifications that come from gconf
(much later)
this is not perfect - eg, it won't notice changes which did not go through
modest-conf. but for the end user, it seems to work a bit smoother
pmo-trunk-r1926
Dirk-Jan C. Binnema [Sat, 19 May 2007 22:00:59 +0000 (22:00 +0000)]
* add a missing 'break' in the switch statement in
modest_tny_account_new_from_server_account
this fixes some weird errors when CRAMMD5 is chosen
* igore stats value < 0, as we sometimes get with new accounts;
this fixes the weird negative # of messages in the UI
account view
pmo-trunk-r1925
Dirk-Jan C. Binnema [Sat, 19 May 2007 21:46:40 +0000 (21:46 +0000)]
* only get the server_accounts that are used by enabled accounts
* refresh the caches for both transport / store account after change notifications have been received; this fixes the bug where the transport accounts were cleared but not recached after an update
(ie. the dreaded 'cannot find transport account' error)
pmo-trunk-r1924
Dirk-Jan C. Binnema [Sat, 19 May 2007 16:03:30 +0000 (16:03 +0000)]
* set the correct server options from the preset data,
and set the right port number as well; i restructured the code a bit,
the problem was that (apparently) the easy setup wizard did not set the
port number; also, modest-presets confused && and & for bitwise-and
somehow
* add explicit port number argument to modest_account_mgr_add_server_account
pmo-trunk-r1921
Dirk-Jan C. Binnema [Sat, 19 May 2007 10:05:50 +0000 (10:05 +0000)]
* added 'update-garage', crude script to update modest in garage with the latest changes in the internal repo
pmo-trunk-r1920
Dirk-Jan C. Binnema [Sat, 19 May 2007 09:42:12 +0000 (09:42 +0000)]
* add dummy image for testing
pmo-trunk-r1919
Dirk-Jan C. Binnema [Sat, 19 May 2007 09:28:42 +0000 (09:28 +0000)]
* AC_MSG_ERROR for Gnome build
pmo-trunk-r1918
Dirk-Jan C. Binnema [Fri, 18 May 2007 21:23:32 +0000 (21:23 +0000)]
* make control-maemo0 depend on maemo-providers-data instead of modest-providers-data
pmo-trunk-r1917
Dirk-Jan C. Binnema [Fri, 18 May 2007 21:22:06 +0000 (21:22 +0000)]
* turn off the maemo-launcher for now, as it seems to break connectivity
pmo-trunk-r1916
Dirk-Jan C. Binnema [Fri, 18 May 2007 15:54:45 +0000 (15:54 +0000)]
* add modest_platform_show_help helper function, to invoke the help browser
pmo-trunk-r1914
Dirk-Jan C. Binnema [Fri, 18 May 2007 15:26:26 +0000 (15:26 +0000)]
* fix for bug NB#57325 ("Local folders on: %s")
pmo-trunk-r1913
Javier Fernandez Garcia-Boente [Fri, 18 May 2007 14:17:48 +0000 (14:17 +0000)]
* maemo/modest-main-window.c:
- use mail_operation error handling capabilities when
operation os removed from queue.
* modest-mail-operation.c:
- folder_copy_async works fine now.
- added a new private field, error_handler to perfomrs
required operations during an error state.
* modest-ui-actions.c
- use a mail operation with error handling capabilities
to perform copy_async operation.
- get message header from tree model, when message is
deleted using toolitem of viewer view. (Fixes: #NB55370)
pmo-trunk-r1912
Sergio Villar Senin [Fri, 18 May 2007 13:43:31 +0000 (13:43 +0000)]
* Added per-message size limit to get_msgs mail operation
pmo-trunk-r1911
Dirk-Jan C. Binnema [Fri, 18 May 2007 13:05:02 +0000 (13:05 +0000)]
* some fixes to make lintian happy
pmo-trunk-r1910
Philip Van Hoof [Fri, 18 May 2007 12:15:42 +0000 (12:15 +0000)]
A search API for Modest
pmo-trunk-r1909
Dirk-Jan C. Binnema [Fri, 18 May 2007 12:08:47 +0000 (12:08 +0000)]
* fix the (c) headers
pmo-trunk-r1908
Sergio Villar Senin [Fri, 18 May 2007 10:01:23 +0000 (10:01 +0000)]
* Created a new get_full_msgs mail operation to asynchronously receive several full messages
pmo-trunk-r1905
Dirk-Jan C. Binnema [Fri, 18 May 2007 09:02:11 +0000 (09:02 +0000)]
* update debian changelog for w21 prerelease
pmo-trunk-r1904
Philip Van Hoof [Thu, 17 May 2007 12:28:18 +0000 (12:28 +0000)]
Build fix, updating API changes from Tinymail
pmo-trunk-r1903
Murray Cumming [Thu, 17 May 2007 11:17:08 +0000 (11:17 +0000)]
2007-05-17 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
(create_page_account_details),
(modest_account_settings_dialog_set_account_name):
* src/maemo/modest-account-settings-dialog.h: Hide the whole caption
for the leave-on-server checkbox, rathr than just the checkbox, when
the protocol is not POP.
pmo-trunk-r1901
Murray Cumming [Thu, 17 May 2007 11:09:12 +0000 (11:09 +0000)]
2007-05-17 Murray Cumming <murrayc@murrayc.com>
* src/widgets/modest-account-view.c:
* src/widgets/modest-account-view.h:
Added modest_account_view_select_account() which will be useful later
to asynchronously re-select the edited account.
pmo-trunk-r1900
Murray Cumming [Thu, 17 May 2007 10:34:01 +0000 (10:34 +0000)]
2007-05-17 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-account-settings-dialog.c:
(modest_account_settings_dialog_set_account_name):
Automatically choose the port numbers based on the secure authentication
methods, if they have not been chosen before.
This fixes projects.maemo.org bug NB#56273 .
pmo-trunk-r1897
Murray Cumming [Thu, 17 May 2007 09:56:12 +0000 (09:56 +0000)]
2007-05-17 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-main-window-ui.h:
* src/modest-ui-actions.c:
* src/modest-ui-actions.h:
Connect the Tools/SMTP Servers menu item to
modest_ui_actions_on_smtp_servers(), which shows the connection-specific
SMTP servers dialog, as in the UI specification and saves changes when it
is closed. This fixed projects.maemo.org bug NB#56305 .
pmo-trunk-r1896
Murray Cumming [Thu, 17 May 2007 09:06:59 +0000 (09:06 +0000)]
2007-05-17 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_init):
Use gtk_window_set_default_size() to make this window big enough, so
we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
pmo-trunk-r1895
Murray Cumming [Thu, 17 May 2007 08:56:53 +0000 (08:56 +0000)]
2007-05-17 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-connection-specific-smtp-edit-window.h:
* src/maemo/modest-connection-specific-smtp-edit-window.c:
(modest_connection_specific_smtp_edit_window_init),
Do not try to connect to a combobox signal before the combobox exists.
This fixes the cras in projects.maemo.org bug NB#56288 .
(modest_connection_specific_smtp_edit_window_get_settings):
Remove the server_account_name parameter which was being checked for NULL
though it was not used.
* src/maemo/modest-connection-specific-smtp-window.c:
(modest_connection_specific_smtp_window_fill_with_connections),
(on_button_edit), (modest_connection_specific_smtp_window_init):
Correct the number of treemodel columns to prevent a warning.
Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
libconic does not work.
pmo-trunk-r1894
Murray Cumming [Wed, 16 May 2007 17:33:07 +0000 (17:33 +0000)]
2007-05-16 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account.c:
(modest_tny_account_new_from_server_account):
Excplicitly use ANONYMOUS secure authentication, instead of PLAIN for
SMTP when None was chosen by the user. However, with my SMTP server that
does not support ANONYMOUS, the emails do not leave the Outbox and I see
no error dialog.
pmo-trunk-r1893
Javier Fernandez Garcia-Boente [Wed, 16 May 2007 16:20:08 +0000 (16:20 +0000)]
* maemo/modest-main-window-ui.h
- add handler for move_to toolbar button
* maemo/modest-progress-bar-widget.c
- avoid to show done=1 and total=100 progress,
because these values are inital values for all
mail operations.
* modest-ui-actions.c
- show confirmation dialog on delete message events
from headers view
- Add a user_callback function to xfer_msgs method in order
to restore row_reference attribute on viewer window and
set current message to first message of recenlty update
treemodel.
* modest-folder-view.c
- fix bug about an incorrect unref over header object after
added it to a tiny list. this header object will be unreferenced
when tiny list was destroyed.
* modest-mail-operation.c
- call to recently created copy_folder_async tinymail operation.
- define an user_callback for message transfer operations
- fix bug on xfer_msgs operation, due an incorrect references management.
pmo-trunk-r1892
Sergio Villar Senin [Wed, 16 May 2007 14:34:31 +0000 (14:34 +0000)]
* Some fixes
pmo-trunk-r1891
Dirk-Jan C. Binnema [Wed, 16 May 2007 13:42:50 +0000 (13:42 +0000)]
* fix for compile breakage
pmo-trunk-r1890
Dirk-Jan C. Binnema [Wed, 16 May 2007 13:09:09 +0000 (13:09 +0000)]
* fix broken debian/changelog, as integration barfs on this
pmo-trunk-r1889
Sergio Villar Senin [Wed, 16 May 2007 12:58:58 +0000 (12:58 +0000)]
* Added support to send&receive async in that particular order
pmo-trunk-r1888
Murray Cumming [Wed, 16 May 2007 12:30:07 +0000 (12:30 +0000)]
2007-05-16 Murray Cumming <murrayc@murrayc.com>
* src/modest-pair.h: Improve the documentation for modest_combo_box_new()
to explain the memory management issue with the ID in the ModestPair.
* src/gnome/modest-account-assistant.c: (add_receiving_page),
(add_sending_page), (modest_account_assistant_finalize):
* src/gnome/modest-gnome-global-settings-dialog.c:
(create_updating_page), (create_composing_page):
* src/gnome/modest-msg-edit-window.c: (get_transports),
(init_window), (modest_msg_edit_window_finalize),
(modest_msg_edit_window_get_msg_data):
* src/gnome/modest-store-widget.c: (imap_pop_configuration):
* src/gnome/modest-transport-widget.c:
(modest_transport_widget_finalize), (smtp_configuration):
* src/maemo/modest-maemo-global-settings-dialog.c:
(create_updating_page), (create_composing_page):
* src/maemo/modest-msg-edit-window.c: (get_transports),
(init_window), (modest_msg_edit_window_finalize),
(modest_msg_edit_window_get_msg_data),
(modest_msg_edit_window_free_msg_data):
* src/maemo/modest-store-widget.c: (imap_pop_configuration),
(modest_store_widget_finalize):
* src/maemo/modest-transport-widget.c:
(modest_transport_widget_finalize), (smtp_configuration):
* src/modest-main.c: (send_mail):
* src/widgets/modest-combo-box.h:
* src/widgets/modest-global-settings-dialog-priv.h:
* src/widgets/modest-global-settings-dialog.c:
(modest_global_settings_dialog_finalize):
* src/widgets/modest-msg-edit-window.h:
Whenever using modest_combo_box_new(), keep the ModestPairList alive
as long as the combo box, to prevent use of freed memory for the ID.
pmo-trunk-r1887
Sergio Villar Senin [Wed, 16 May 2007 10:38:31 +0000 (10:38 +0000)]
* Better status information notification for account updates
pmo-trunk-r1886
Dirk-Jan C. Binnema [Wed, 16 May 2007 09:02:27 +0000 (09:02 +0000)]
* added the prepare-integration script, which does the building work for integrating packages; only useful for pre-integrators
pmo-trunk-r1885
Dirk-Jan C. Binnema [Wed, 16 May 2007 08:58:47 +0000 (08:58 +0000)]
* fix the changelog syntax
pmo-trunk-r1884
Sergio Villar Senin [Wed, 16 May 2007 07:38:54 +0000 (07:38 +0000)]
* Fixed a build error
pmo-trunk-r1883
Murray Cumming [Tue, 15 May 2007 18:06:30 +0000 (18:06 +0000)]
Pedantic grammar stuff in a comment.
pmo-trunk-r1882
Dirk-Jan C. Binnema [Tue, 15 May 2007 17:57:48 +0000 (17:57 +0000)]
* prepare for new prerelease
pmo-trunk-r1881
Murray Cumming [Tue, 15 May 2007 15:36:57 +0000 (15:36 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/modest-tny-account-store.c: (get_server_accounts): Renamed from
get_accounts(), to make this clearer. Do not check for the enabled gconf
key, because we do not use this for server accounts (at least, not yet).
This allows us to send email again.
pmo-trunk-r1880
Dirk-Jan C. Binnema [Tue, 15 May 2007 15:04:28 +0000 (15:04 +0000)]
* number the columns (MODEST_HEADER_VIEW_COLUMN_*) explicitely, to make changes that screw up our config settings less likely
pmo-trunk-r1879
Dirk-Jan C. Binnema [Tue, 15 May 2007 14:54:25 +0000 (14:54 +0000)]
* added missing backup settings file
pmo-trunk-r1878
Murray Cumming [Tue, 15 May 2007 14:39:42 +0000 (14:39 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-platform.c:
(on_modest_conf_update_interval_changed), (modest_platform_init):
Only respond to this particular key change. All these strcmp()s cannot be
efficient.
pmo-trunk-r1877
Murray Cumming [Tue, 15 May 2007 14:28:00 +0000 (14:28 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/maemo/modest-maemo-global-settings-dialog.c:
(current_connection): Prevent a crash in scratchbox when
ny_maemo_conic_device_get_current_iap_id() returns NULL.
* src/maemo/modest-platform.c:
(on_modest_conf_update_interval_changed), (modest_platform_init):
Get the update interval from gconf and reset it when the gconf key changes.
pmo-trunk-r1876
Dirk-Jan C. Binnema [Tue, 15 May 2007 14:08:16 +0000 (14:08 +0000)]
* add the rather trivial backup support; this implements the "Backup" workitem.
* needs testing though, and possibly a conversion script for pre-modest email import
pmo-trunk-r1875
Murray Cumming [Tue, 15 May 2007 13:55:43 +0000 (13:55 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/modest-protocol-info.c:
* src/modest-protocol-info.h: Adde enum-specific get functions,
instead of using a ModestProtocolType enum parameter.
* src/gnome/modest-account-assistant.c:
* src/gnome/modest-store-widget.c:
* src/gnome/modest-store-widget.h:
* src/gnome/modest-transport-widget.c:
* src/gnome/modest-transport-widget.h:
* src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
* src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
* src/maemo/easysetup/modest-easysetup-wizard.c:
* src/maemo/modest-account-settings-dialog.c:
* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-store-widget.c:
* src/maemo/modest-store-widget.h:
* src/maemo/modest-transport-widget.c:
* src/maemo/modest-transport-widget.h:
* src/modest-account-mgr-helpers.c:
* src/modest-account-mgr-helpers.h:
* src/modest-account-mgr.c:
* src/modest-account-mgr.h:
* src/modest-tny-account.c:
* src/modest-tny-folder.c:
* src/widgets/modest-account-view.c:
* src/widgets/modest-retrieve-combo-box.c:
* src/widgets/modest-retrieve-combo-box.h:
* src/widgets/modest-secureauth-combo-box.c:
* src/widgets/modest-serversecurity-combo-box.c:
* src/widgets/modest-serversecurity-combo-box.h:
* tests/check_account-mgr.c:
Use the specific functions, and use the re-renamed enum values for GNOME too.
pmo-trunk-r1874
Sergio Villar Senin [Tue, 15 May 2007 12:28:19 +0000 (12:28 +0000)]
* Modified the update_account signature to ensure that the account is a ModestTnyAccount
* Added last_update feature
pmo-trunk-r1873
Murray Cumming [Tue, 15 May 2007 11:53:41 +0000 (11:53 +0000)]
2007-05-15 Murray Cumming <murrayc@murrayc.com>
* src/modest-pair.h:
* src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
so we can get the second based on the first.
* src/maemo/modest-account-settings-dialog.h:
* src/maemo/modest-account-settings-dialog.c:
Added get_supported_secure_authentication_methods(), though it is mostly
commented-out for now until the necessary API is committed to tinymail.
(modest_account_settings_dialog_set_account_name),
(save_configuration): Request the supported authentication methods from the
server, so we can choose a working method.
* src/modest-tny-account-store.h:
* src/modest-tny-account-store.c:
(modest_tny_account_store_get_session): Rename from
tny_account_store_get_session().
pmo-trunk-r1872