projects
/
emufront
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
cc1ab01
)
comment
author
Mikko Keinänen
<mikko.keinanen@gmail.com>
Sat, 19 Jun 2010 15:40:00 +0000
(18:40 +0300)
committer
Mikko Keinänen
<mikko.keinanen@gmail.com>
Sat, 19 Jun 2010 15:40:00 +0000
(18:40 +0300)
src/utils/fileutil.cpp
patch
|
blob
|
history
diff --git
a/src/utils/fileutil.cpp
b/src/utils/fileutil.cpp
index
410d0b8
..
a4ded34
100644
(file)
--- a/
src/utils/fileutil.cpp
+++ b/
src/utils/fileutil.cpp
@@
-40,7
+40,12
@@
QList<MediaImageContainer*> FileUtil::scanFilePath(const FilePathObject *fp, QSt
"" /* TODO */,
fileInfo.size(),
files,
"" /* TODO */,
fileInfo.size(),
files,
- fp->getSetup() // TODO: maybe assign a copy of the setup object, we cannot guarantee that the setup object in file path object will stay alive!!!
+ // TODO: is it guaranteed, that the file path object containing the setup object remains alive
+ // the whole lifecycle of (this) media image container object?
+ // * if we assign a copy of the setup object -> waste of memory and time
+ // * this function is designed to be used from media image path main dialog
+ // where we can ensure the lifecycle of file path object -> maybe move the implementation there!?
+ fp->getSetup()
);
containers.append(con);
}
);
containers.append(con);
}