1 2007-05-21 Christian Kellner <ckellner@openismus.com>
4 Correct bit shifting in the ModestSearchFlags enum.
6 2007-05-21 Murray Cumming <murrayc@murrayc.com>
8 * src/modest-tny-account.c:
9 (modest_tny_account_new_from_server_account): Do not use the lsub and
10 check-all hard-coded IMAP options when using POP.
12 2007-05-21 Murray Cumming <murrayc@murrayc.com>
14 * src/modest-tny-account.c:
15 (modest_tny_account_new_from_server_account):
16 Use NULL for the secure-auth method for POP when Password auth has been
17 specified by the user, as we already do for IMAP. "auth=Login" causes
18 an error from camel or the server.
20 2007-05-17 Murray Cumming <murrayc@murrayc.com>
22 * src/maemo/modest-account-settings-dialog.c:
23 (create_page_account_details),
24 (modest_account_settings_dialog_set_account_name):
25 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
26 for the leave-on-server checkbox, rathr than just the checkbox, when
27 the protocol is not POP.
29 2007-05-17 Murray Cumming <murrayc@murrayc.com>
31 * src/widgets/modest-account-view.c:
32 * src/widgets/modest-account-view.h:
33 Added modest_account_view_select_account() which will be useful later
34 to asynchronously re-select the edited account.
36 2007-05-17 Murray Cumming <murrayc@murrayc.com>
38 * src/maemo/modest-account-settings-dialog.c:
39 (modest_account_settings_dialog_set_account_name):
40 Automatically choose the port numbers based on the secure authentication
41 methods, if they have not been chosen before.
42 This fixes projects.maemo.org bug NB#56273 .
44 2007-05-17 Murray Cumming <murrayc@murrayc.com>
46 * src/maemo/modest-main-window-ui.h:
47 * src/modest-ui-actions.c:
48 * src/modest-ui-actions.h:
49 Connect the Tools/SMTP Servers menu item to
50 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
51 SMTP servers dialog, as in the UI specification and saves changes when it
52 is closed. This fixed projects.maemo.org bug NB#56305 .
54 2007-05-17 Murray Cumming <murrayc@murrayc.com>
56 * src/maemo/modest-connection-specific-smtp-window.c:
57 (modest_connection_specific_smtp_window_init):
58 Use gtk_window_set_default_size() to make this window big enough, so
59 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
61 2007-05-17 Murray Cumming <murrayc@murrayc.com>
63 * src/maemo/modest-connection-specific-smtp-edit-window.h:
64 * src/maemo/modest-connection-specific-smtp-edit-window.c:
65 (modest_connection_specific_smtp_edit_window_init),
66 Do not try to connect to a combobox signal before the combobox exists.
67 This fixes the cras in projects.maemo.org bug NB#56288 .
68 (modest_connection_specific_smtp_edit_window_get_settings):
69 Remove the server_account_name parameter which was being checked for NULL
70 though it was not used.
72 * src/maemo/modest-connection-specific-smtp-window.c:
73 (modest_connection_specific_smtp_window_fill_with_connections),
74 (on_button_edit), (modest_connection_specific_smtp_window_init):
75 Correct the number of treemodel columns to prevent a warning.
76 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
77 libconic does not work.
79 2007-05-16 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-tny-account.c:
82 (modest_tny_account_new_from_server_account):
83 Excplicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
84 SMTP when "None" was chosen by the user. However, with my SMTP server that
85 does not support ANONYMOUS, the emails do not leave the Outbox and I see
88 2007-05-16 Murray Cumming <murrayc@murrayc.com>
90 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
91 to explain the memory management issue with the ID in the ModestPair.
93 * src/gnome/modest-account-assistant.c: (add_receiving_page),
94 (add_sending_page), (modest_account_assistant_finalize):
95 * src/gnome/modest-gnome-global-settings-dialog.c:
96 (create_updating_page), (create_composing_page):
97 * src/gnome/modest-msg-edit-window.c: (get_transports),
98 (init_window), (modest_msg_edit_window_finalize),
99 (modest_msg_edit_window_get_msg_data):
100 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
101 * src/gnome/modest-transport-widget.c:
102 (modest_transport_widget_finalize), (smtp_configuration):
103 * src/maemo/modest-maemo-global-settings-dialog.c:
104 (create_updating_page), (create_composing_page):
105 * src/maemo/modest-msg-edit-window.c: (get_transports),
106 (init_window), (modest_msg_edit_window_finalize),
107 (modest_msg_edit_window_get_msg_data),
108 (modest_msg_edit_window_free_msg_data):
109 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
110 (modest_store_widget_finalize):
111 * src/maemo/modest-transport-widget.c:
112 (modest_transport_widget_finalize), (smtp_configuration):
113 * src/modest-main.c: (send_mail):
114 * src/widgets/modest-combo-box.h:
115 * src/widgets/modest-global-settings-dialog-priv.h:
116 * src/widgets/modest-global-settings-dialog.c:
117 (modest_global_settings_dialog_finalize):
118 * src/widgets/modest-msg-edit-window.h:
119 Whenever using modest_combo_box_new(), keep the ModestPairList alive
120 as long as the combo box, to prevent use of freed memory for the ID.
122 2007-05-15 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
125 get_accounts(), to make this clearer. Do not check for the enabled gconf
126 key, because we do not use this for server accounts (at least, not yet).
127 This allows us to send email again.
129 2007-05-15 Murray Cumming <murrayc@murrayc.com>
131 * src/maemo/modest-platform.c:
132 (on_modest_conf_update_interval_changed), (modest_platform_init):
133 Only respond to this particular key change. All these strcmp()s cannot be
136 2007-05-15 Murray Cumming <murrayc@murrayc.com>
138 * src/maemo/modest-maemo-global-settings-dialog.c:
139 (current_connection): Prevent a crash in scratchbox when
140 ny_maemo_conic_device_get_current_iap_id() returns NULL.
141 * src/maemo/modest-platform.c:
142 (on_modest_conf_update_interval_changed), (modest_platform_init):
143 Get the update interval from gconf and reset it when the gconf key changes.
145 2007-05-15 Murray Cumming <murrayc@murrayc.com>
147 * src/modest-protocol-info.c:
148 * src/modest-protocol-info.h: Adde enum-specific get functions,
149 instead of using a ModestProtocolType enum parameter.
151 * src/gnome/modest-account-assistant.c:
152 * src/gnome/modest-store-widget.c:
153 * src/gnome/modest-store-widget.h:
154 * src/gnome/modest-transport-widget.c:
155 * src/gnome/modest-transport-widget.h:
156 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
157 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
158 * src/maemo/easysetup/modest-easysetup-wizard.c:
159 * src/maemo/modest-account-settings-dialog.c:
160 * src/maemo/modest-account-settings-dialog.h:
161 * src/maemo/modest-store-widget.c:
162 * src/maemo/modest-store-widget.h:
163 * src/maemo/modest-transport-widget.c:
164 * src/maemo/modest-transport-widget.h:
165 * src/modest-account-mgr-helpers.c:
166 * src/modest-account-mgr-helpers.h:
167 * src/modest-account-mgr.c:
168 * src/modest-account-mgr.h:
169 * src/modest-tny-account.c:
170 * src/modest-tny-folder.c:
171 * src/widgets/modest-account-view.c:
172 * src/widgets/modest-retrieve-combo-box.c:
173 * src/widgets/modest-retrieve-combo-box.h:
174 * src/widgets/modest-secureauth-combo-box.c:
175 * src/widgets/modest-serversecurity-combo-box.c:
176 * src/widgets/modest-serversecurity-combo-box.h:
177 * tests/check_account-mgr.c:
178 Use the specific functions, and use the re-renamed enum values for GNOME too.
180 2007-05-15 Murray Cumming <murrayc@murrayc.com>
183 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
184 so we can get the second based on the first.
186 * src/maemo/modest-account-settings-dialog.h:
187 * src/maemo/modest-account-settings-dialog.c:
188 Added get_supported_secure_authentication_methods(), though it is mostly
189 commented-out for now until the necessary API is committed to tinymail.
190 (modest_account_settings_dialog_set_account_name),
191 (save_configuration): Request the supported authentication methods from the
192 server, so we can choose a working method.
194 * src/modest-tny-account-store.h:
195 * src/modest-tny-account-store.c:
196 (modest_tny_account_store_get_session): Rename from
197 tny_account_store_get_session().
199 2007-05-14 Murray Cumming <murrayc@murrayc.com>
201 * src/modest-protocol-info.h: Split the ModestProtocol enum
202 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
203 There was no need to have these unrelated values in one enum.
205 * src/: many files: Adapted to changed enum. This makes the code a bit
206 clearer, and the compiler could catch some errors.
208 2007-05-14 Murray Cumming <murrayc@murrayc.com>
210 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
211 Show the detailed internal camel error message when an error happens
212 during the configuration, so that our testers can give us more clues.
213 For instance, in projects.maemo.org bug NB#56910 .
215 2007-05-14 Murray Cumming <murrayc@murrayc.com>
217 * src/modest-tny-account.c:
218 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
219 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
221 2007-05-14 Murray Cumming <murrayc@murrayc.com>
223 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
224 * src/maemo/modest-account-settings-dialog.c:
225 (modest_account_settings_dialog_set_account_name),
226 (save_configuration): For the incoming secure authentication checkbox,
227 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
228 the UI specification. PLAIN does not seem to be supported for most IMAP
229 servers anyway, and I am not sure what it would mean.
230 However, we probably need to discover which of the secure-authentication
231 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
232 * src/modest-account-mgr-helpers.c:
233 (modest_account_mgr_get_server_account_data):
235 * src/modest-tny-account.c:
236 (modest_tny_account_new_from_server_account):
237 Use tny_account_set_mech() to set secure-authentication methods,
238 with some special-casing for IMAP, based on my observations of how
241 * src/modest-account-mgr-helpers.h:
242 * src/modest-account-mgr.c:
243 * src/modest-defs.h: Comment that the URI is only used for local folders.
245 2007-05-11 Murray Cumming <murrayc@murrayc.com>
247 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
248 parameter const, just to be neat.
249 * src/modest-text-utils.c: (modest_text_utils_inline):
250 End g_strconcat() with NULL, as its documentation says. This is almost
251 certainly the cause of my crash at startup on the device. Interestingly,
252 valgrind doesn't tell us about these errors.
254 2007-05-11 Murray Cumming <murrayc@murrayc.com>
256 * scripts/build-packages: Added more precise comments about how to use
257 this script, though I still get this error:
258 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
259 error building tinymail
261 2007-05-11 Murray Cumming <murrayc@murrayc.com>
263 * src/maemo/modest-main-window.c: (on_account_update):
264 Very slight cleanup, hoping to make it simpler to discover what causes
265 a crash here sometimes.
267 * src/modest-tny-account.c:
268 (modest_tny_account_new_from_server_account): Set the port. Added
269 comments about the options and a TODO comment because I need to find out
270 how to specify the secure authentication method.
272 2007-05-11 Marcus Bauer <marcusb@openismus.com>
274 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
275 changed CFlags paths form modest to libmodest
277 2007-05-10 Murray Cumming <murrayc@murrayc.com>
279 * src/modest-account-mgr-helpers.c:
280 (modest_account_mgr_get_server_account_data),
281 (modest_account_mgr_free_server_account_data):
282 * src/modest-account-mgr-helpers.h:
283 * src/modest-account-mgr.c:
284 (modest_account_mgr_add_server_account):
286 * src/modest-tny-account.c:
287 (modest_tny_account_new_from_server_account):
288 Determine the options for tny_camel_account_add_option() here,
289 based on the settings, rather than storing them directly in gconf.
291 2007-05-10 Murray Cumming <murrayc@murrayc.com>
293 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
294 Show a more friendly error dialog now that we expect (from the tinymail
295 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
297 2007-05-10 Murray Cumming <murrayc@murrayc.com>
299 * src/maemo/modest-main-window.c: (on_account_update): Check that
300 account_name is not NULL, to prevent a crash at startup that I am
301 seeing on the N800. I do wonder why it is NULL.
303 * src/maemo/easysetup/modest-easysetup-wizard.c:
304 (create_page_user_details):
305 * src/maemo/modest-account-settings-dialog.c:
306 (create_page_user_details), (create_page_outgoing):
307 * src/maemo/modest-connection-specific-smtp-edit-window.c:
308 (modest_connection_specific_smtp_edit_window_init):
309 * src/modest-ui-actions.c:
310 (modest_ui_actions_on_password_requested):
311 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
312 might do something useful with the on-screen keyboard.
314 2007-05-10 Murray Cumming <murrayc@murrayc.com>
316 * src/maemo/modest-main-window.c: (on_account_update):
317 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
318 NULL, to avoid lots of warnings. However, it probably should not be NULL.
320 2007-05-09 Murray Cumming <murrayc@murrayc.com>
322 * src/modest-tny-account-store.c: (on_account_changed):
323 Correct the signature of this signal handler.
325 2007-05-09 Murray Cumming <murrayc@murrayc.com>
327 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
328 Show a HildonNote instead of a GtkDialog for Maemo.
330 2007-05-09 Murray Cumming <murrayc@murrayc.com>
332 * src/widgets/modest-account-view.h:
333 * src/widgets/modest-account-view.c: (on_account_changed),
334 (on_account_removed). Added a boolean flag, set/unset by
335 modest_account_view_block_conf_updates(),
336 modest_account_view_unblock_conf_updates() to prevent unnecessary
337 updates, but this is not very useful because the gconf notifications are
338 so delays (maybe only on Maemo Bora).
339 So auto-updating is turned off, and these functions do an explicit
340 update when necessary.
341 However, something else is still doing too much work when adding/removing
342 accounts, probably in another part of the application.
344 * src/maemo/modest-account-view-window.c:
345 (on_delete_button_clicked), (on_edit_button_clicked),
346 (on_new_button_clicked): Use the new functions.
348 2007-05-09 Murray Cumming <murrayc@murrayc.com>
350 * src/modest-account-mgr-helpers.c:
351 (modest_account_mgr_set_first_account_as_default):
352 Sort the list of names alphabetically-by-title, so we choose the first one
354 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
355 alphabetically by the title.
357 This fixes projects.maemo.org bug NB#56418 .
359 * src/modest-account-mgr-priv.c:
360 (_modest_account_mgr_account_from_key):
361 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
362 avoid a valgrind error, and possible random behaviour.
364 2007-05-09 Murray Cumming <murrayc@murrayc.com>
366 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
367 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
368 tinymail documentation to say that this can be expected.
369 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
370 pretty, and should not happen, but I would prefer to know when it does.
372 2007-05-09 Murray Cumming <murrayc@murrayc.com>
374 * configure.ac: When using the older hildon version, probably on Bora,
375 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
377 * src/widgets/modest-attachment-view.c:
378 (modest_attachment_view_set_part_default): Initialize variables, to fix the
381 2007-05-09 Marcus Bauer <marcusb@openismus.com>
383 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
384 Implemented the prototype. Can be tested with
385 tests/dbus_api/test_open_message:
387 2007-05-08 Murray Cumming <murrayc@murrayc.com>
389 * src/modest-tny-account-store.c:
390 (modest_tny_account_store_instance_init), (get_password):
391 * src/modest-ui-actions.c:
392 (modest_ui_actions_on_password_requested):
393 Do not store the password in gconf, because this function is called
394 for non-remembered passwords. Actually use the cached (in the hash map)
395 password instead of releasing it.
396 The password will now not be remembered if it is asked via the protected
397 password dialog, as per the UI spec.
399 2007-05-08 Murray Cumming <murrayc@murrayc.com>
402 * src/modest-account-mgr-helpers.h:
403 * src/modest-account-mgr-helpers.c:
404 Added modest_server_account_get_username_has_succeeded(),
405 modest_server_account_set_username_has_succeeded().
406 (modest_server_account_set_username),
407 Reset the has-succeeded flag if the username changes.
409 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
410 * src/maemo/modest-connection-specific-smtp-window.c:
411 (modest_connection_specific_smtp_window_save_server_accounts):
412 Use modest_server_account_set_username() instead of using
413 modest_conf_set_string() directly, so that the has-succeeded flag is always
416 * src/modest-ui-actions.c:
417 (modest_ui_actions_on_password_requested): Dim the username entry if
418 the username has ever worked, as per the UI spec.
420 2007-05-08 Murray Cumming <murrayc@murrayc.com>
422 * src/modest-tny-account-store.c: (get_password):
423 * src/modest-ui-actions.c:
424 (modest_ui_actions_on_password_requested):
425 Allow the username to be changed too, though there is more work to
426 be done on exactly how this behaves.
428 2007-05-08 Murray Cumming <murrayc@murrayc.com>
430 * src/modest-account-mgr-helpers.h:
431 * src/modest-account-mgr-helpers.c:
432 Added modest_account_mgr_get_display_name(),
433 modest_server_account_get_username(),
434 modest_server_account_set_username(),
435 modest_server_account_set_password(),
436 modest_server_account_get_hostname() functions so we do not need to
437 use the conf API directly.
439 * src/maemo/modest-main-window.c: (connect_signals):
440 Actually connect ot the ModestAccountStore::request-password signal,
441 so that we show the dialog when the password is requested by Tinymail,
442 for isntance if it is empty.
444 * src/modest-marshal.list:
445 * src/modest-tny-account-store.c:
446 (modest_tny_account_store_class_init), (get_password),
447 (modest_tny_account_store_alert):
448 * src/modest-tny-account-store.h:
449 * src/modest-ui-actions.h:
450 * src/modest-ui-actions.c:
451 (modest_ui_actions_on_password_requested):
452 Change the signal parameters, so it is obvious that we are providing
453 the non human-readable server name, and receiving both the username
454 and password, though changing of the username is not yet implemented.
455 Change the dialog UI to match the Maemo UI specifications, with #idfefing
456 for the GNOME version.
458 This should fix the projects.maemo.org bug NB#56209, though it does not
459 work on Bora, because the gconf_client_get() for the password fails
460 immediately after we save it with gconf_client_set().
462 2007-05-08 Murray Cumming <murrayc@murrayc.com>
465 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
466 caused an undefined symbol error:
467 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
469 2007-05-08 Murray Cumming <murrayc@murrayc.com>
471 * src/modest-tny-account-store.c:
472 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
473 using a GError instead of a string message, so we can translate it in
476 2007-05-08 Murray Cumming <murrayc@murrayc.com>
478 * src/maemo/modest-address-book.c:
479 (modest_address_book_check_names):
480 * src/maemo/modest-msg-view-window.c:
481 (modest_msg_view_window_clipboard_owner_change):
482 * src/modest-init.c: (modest_init_init_ui):
483 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
484 (update_folders_cb), (modest_mail_operation_update_account):
485 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
486 (modest_ui_actions_on_msg_attachment_clicked),
487 (modest_ui_actions_on_msg_recpt_activated):
488 * src/widgets/modest-header-view.c: (drag_data_get_cb):
489 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
490 (modest_msg_view_search_next):
491 * src/widgets/modest-recpt-editor.c:
492 (modest_recpt_editor_on_button_release_event),
493 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
494 g_message(). At this point we should only be seeing interesting errors on
495 stdout. Debugging messages could be #ifdefed-out if they are still useful.
497 2007-05-07 Murray Cumming <murrayc@murrayc.com>
499 (modest_wizard_dialog_force_title_update):
500 * src/maemo/easysetup/modest-wizard-dialog.h:
501 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
502 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
503 can update the title when appropriate. Otherwise the title is wrong if the
504 pages are added after adding the notebook to the dialog.
505 This must be a problem in HildonWizardDialog too.
506 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
508 * src/maemo/easysetup/modest-easysetup-wizard.c:
509 (create_subsequent_customsetup_pages),
510 (create_subsequent_easysetup_pages):
511 Call modest_wizard_dialog_force_title_update() so that the title is
512 correct even with GTK+ < 2.10.
513 This fixes projects.maemo.org bug NB#56145 .
515 2007-05-07 Murray Cumming <murrayc@murrayc.com>
517 * src/maemo/modest-platform.c:
518 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
519 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
522 2007-05-07 Murray Cumming <murrayc@murrayc.com>
524 * src/widgets/modest-window.h:
525 * src/widgets/modest-window.c: Added a save_state_func vfunc,
526 and modest_window_save_state(), which invokes it.
528 * src/widgets/modest-window-mgr.h:
529 * src/widgets/modest-window-mgr.c:
530 Added modest_window_mgr_save_state_for_all_windows(), which calls
531 the save_state vfunc on all registered windows, if implemented.
533 * src/gnome/modest-msg-edit-window.c:
534 * src/gnome/modest-msg-view-window.c:
535 * src/maemo/modest-msg-edit-window.c:
536 * src/maemo/modest-msg-view-window.c:
537 * src/maemo/modest-main-window.c:
538 Specify the existing save_settings functions as implementations of
539 ModestWindow::save_state_func().
541 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
542 Call modest_window_mgr_save_state_for_all_windows(). This happens before
543 enabling hibernation, for instance.
545 We may need to do the same thing for restoring settings.
548 2007-05-07 Murray Cumming <murrayc@murrayc.com>
550 * src/widgets/modest-window-mgr.c:
551 * src/widgets/modest-window-mgr.h:
552 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
553 modest_window_mgr_get_hibernation_is_prevented().
555 * src/maemo/modest-main-window.c:
556 (on_hildon_program_is_topmost_notify): Prevent hibernation
557 (possible when the application goes to the background in the WM),
558 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
560 * src/maemo/easysetup/modest-easysetup-wizard.c:
561 (modest_easysetup_wizard_dialog_init):
562 * src/maemo/modest-account-settings-dialog.c:
563 (modest_account_settings_dialog_init):
564 * src/maemo/modest-connection-specific-smtp-edit-window.c:
565 (modest_connection_specific_smtp_edit_window_init):
566 * src/maemo/modest-connection-specific-smtp-window.c:
567 (modest_connection_specific_smtp_window_init):
568 * src/maemo/modest-signature-editor-dialog.c:
569 (modest_signature_editor_dialog_init):
570 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
571 prevent hibernation while any of these account settings dialogs are open.
573 2007-05-04 Murray Cumming <murrayc@murrayc.com>
575 * src/maemo/Makefile.am:
576 * src/maemo/modest-osso-state-saving.c:
577 * src/maemo/modest-osso-state-saving.h: Added
578 modest_osso_load_state() and modest_osso_save_state() though they do
579 nothing now. They should iterate through all the open windows and load/save
581 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
582 save state when closing.
584 * src/maemo/modest-main-window.c:
585 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
586 Add a notification handler for the HildonProgram::is-topmost property,
587 so we can allow hibernation when the application goes into the background.
588 But we still need to detect when the accounts setup windows are open so
589 we can stop hibernation when they are open.
590 To do this, I also added the main window the HildonProgram. This might have
591 other side-effects/benefits, and should maybe be done for other windows.
593 * src/maemo/modest-osso-autosave-callbacks.h:
594 * src/maemo/modest-osso-autosave-callbacks.c:
595 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
596 though it does not do anything yet, and we might never need this to do
597 anything. For instance, we already save drafts.
599 * src/maemo/modest-platform.c: (modest_platform_init):
600 Specify the libosso auto-save callback.
602 2007-05-03 Murray Cumming <murrayc@murrayc.com>
604 * src/maemo/modest-platform.c:
605 (modest_platform_set_update_interval):
606 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
607 aparently stays valid between application instances, so we can use this
608 to remove and reset it later. According to a maemo-developers email from
611 2007-05-03 Murray Cumming <murrayc@murrayc.com>
613 * configure.ac: Depend on libalarm for Maemo.
615 * src/dbus_api/modest-dbus-api.h:
616 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
617 (on_send_receive), (modest_dbus_req_handler):
618 Handle a SEND_RECEIVE D-Bus method.
620 * libmodest-dbus-client/libmodest-dbus-client.c:
621 (libmodest_dbus_client_send_and_receive):
622 * libmodest-dbus-client/libmodest-dbus-client.h:
623 Add C convenience functions for calling the new D-Bus method.
625 * src/modest-platform.h:
626 * src/gnome/modest-platform.c:
627 * src/maemo/modest-platform.c:
628 Added modest_platform_set_update_interval(), which uses the
630 (modest_platform_init),
631 Call modest_platform_set_update_interval(), using a hard-coded
632 interval for now (until the global settings dialog is implemented),
633 though I am not sure that this makes sense yet.
635 2007-05-02 Murray Cumming <murrayc@murrayc.com>
637 * src/dbus_api/modest-dbus-callbacks.c:
638 (modest_osso_cb_hw_state_handler):
639 * src/dbus_api/modest-dbus-callbacks.h:
640 * src/maemo/modest-platform.c: (modest_platform_init):
641 Registered (empty) callbacks for the osso hardware state D-Bus signals,
642 in case this has some effect on the ability for Maemo to ping the
645 2007-05-02 Murray Cumming <murrayc@murrayc.com>
647 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
648 Comment out an if() that checks a gchar for < 0, causing a build-breaking
649 warning. It is probably a logic error, but I need to fix the build.
651 2007-05-02 Murray Cumming <murrayc@murrayc.com>
653 * src/modest-account-mgr.h:
654 * src/modest-account-mgr.c:
655 (modest_account_mgr_account_names): Add a gboolean enabled_only
656 parameter, so we can get lists of onlt the enabled accounts.
658 (modest_account_mgr_add_account),,
659 (modest_account_mgr_account_with_display_name_exists):
660 * src/maemo/modest-msg-edit-window.c: (get_transports):
661 * src/modest-account-mgr-helpers.c:
662 (modest_account_mgr_set_first_account_as_default):
663 * src/modest-init.c: (init_default_account_maybe):
664 * src/modest-tny-account-store.c: (get_accounts):
665 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
666 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
667 * tests/check_account-mgr.c: (START_TEST):
668 Provide the extra parameter, as appropriate.
670 * src/widgets/modest-account-view.c: (update_account_view):
671 Do not show disabled accounts (meaning that there is no way to
672 enable/disable accounts in the UI (the feature is not in our UI
673 specification), so we can use this internally only to mark unfinished
674 or temporary account data.
676 * src/maemo/easysetup/modest-easysetup-wizard.c:
677 (create_account): Add boolean enable parameter, so we can specify FALSE
678 to create the temporary account.
679 (on_button_edit_advanced_settings): Create the temporary account as disabled.
680 (on_before_next): When finishing, when there is a temporary account, just
682 Also, use a timeout to delay the showing of the dialog until gconf is likely
683 to return correct information, due to a maemo gconf bug that is fixed in
684 osso 1.1, but not yet in Bora.
685 However, the dialog stays on screen after it is destroyed.
687 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
688 for invalid data when cancelling. Use a hildon note instead of a dialog
689 to complain about invalid data. Do not show the account-saved note if the
690 account is disabled (a temporary account that will not really be saved for use
693 2007-04-30 Murray Cumming <murrayc@murrayc.com>
695 * src/modest-account-mgr-helpers.h:
696 * src/modest-account-mgr-helpers.c:
697 Added modest_account_mgr_unset_default_account(),
698 Added modest_account_mgr_set_first_account_as_default().
700 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
701 If it was the default account, unset the default account name.
703 * src/maemo/modest-account-view-window.c:
704 (on_delete_button_clicked): If it was the default account,
705 set the first remaining account as the default instead.
707 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
708 a NULL account or a NULL default account, to prevent a crash. This should
709 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
712 2007-04-30 Murray Cumming <murrayc@murrayc.com>
714 * src/widgets/modest-recpt-editor.c:
715 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
716 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
717 TODO comment for this. This fixes the build.
719 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
720 be the best place for it. This will in future update all auto-update accounts,
721 rather than just the current/default account, when that gconf key exists.
722 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
723 if there are no accounts, before calling do_send_receive().
724 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
726 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
727 * src/maemo/modest-main-window-ui.h:
728 * src/maemo/modest-main-window.c: (on_connection_changed),
729 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
730 directly, becaue the signal handler does more.
732 2007-04-30 Murray Cumming <murrayc@murrayc.com>
734 * src/modest-account-mgr-helpers.c:
735 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
736 for the case that the account does not exist.
738 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
739 (equivalent to the modest account name) rather than the tinymail account name
740 (equivalent to the modest account title - human readable) to get the account data.
741 Check for null account data to prevent the crash, and add a TODO comment saying that
742 this needs fixing because it is using the server account name instead of the account name.
744 2007-04-29 Murray Cumming <murrayc@murrayc.com>
746 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
747 * src/maemo/modest-account-settings-dialog.c: (show_error),
749 Use hildon_note_new_information() for informative and error messages,
750 which seems to be expected for Maemo applications (no documentation that I know of
751 says this). I am surprised that there is no distinction between info and error
754 2007-04-29 Murray Cumming <murrayc@murrayc.com>
756 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
757 it is easy to find where this is used.
759 * src/maemo/easysetup/modest-easysetup-wizard.c:
760 (create_page_welcome), (create_page_account_details),
761 (create_page_user_details), (create_page_complete_easysetup),
762 (create_page_custom_incoming), (create_page_custom_outgoing),
763 (create_page_complete_custom):
764 * src/maemo/modest-account-settings-dialog.c:
765 (create_page_account_details), (create_page_user_details),
766 (create_page_incoming), (create_page_outgoing):
767 * src/maemo/modest-account-view-window.c: (window_vbox_new):
768 * src/maemo/modest-connection-specific-smtp-edit-window.c:
769 (modest_connection_specific_smtp_edit_window_init):
770 * src/maemo/modest-connection-specific-smtp-window.c:
771 (modest_connection_specific_smtp_window_init):
772 * src/maemo/modest-signature-editor-dialog.c:
773 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
774 and scrolling policy as per the Email Application Layout Guide, if I have
777 2007-04-27 Murray Cumming <murrayc@murrayc.com>
779 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
780 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
781 which were empty, because these vfuncs have been removed from TnyAccountStore.
782 This fixes the build.
784 2007-04-27 Murray Cumming <murrayc@murrayc.com>
786 * src/maemo/modest-main-window.c:
787 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
788 showing/hiding it. Added TODO because it probably should not be NULL.
789 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
790 because unnecessary g_warnings() make degugging difficult.
792 2007-04-27 Murray Cumming <murrayc@murrayc.com>
794 * src/maemo/modest-msg-edit-window.c:
795 (modest_msg_edit_window_select_color),
796 (modest_msg_edit_window_select_background_color): 2 const corrections and
797 moving 2 #endifs before closing brackets, to fix the build.
799 2007-04-27 Murray Cumming <murrayc@murrayc.com>
801 * src/maemo/easysetup/modest-easysetup-wizard.h:
802 * src/maemo/easysetup/modest-easysetup-wizard.c:
803 (modest_easysetup_wizard_dialog_finalize),
804 (on_button_edit_advanced_settings), (create_page_complete_custom),
805 (on_response), (create_account):
806 Implement the Advanced Settings edit button, by saving the account information,
807 for the Advanded Settings dialog to use directly from gconf, and removing it
808 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
809 Bug #5533 in the projects.maemo.org bugzilla.
811 2007-04-27 Murray Cumming <murrayc@murrayc.com>
813 * src/maemo/modest-msg-view-window.c:
814 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
815 when opening a message window.
817 2007-04-27 Murray Cumming <murrayc@murrayc.com>
819 * src/maemo/easysetup/modest-easysetup-wizard.c:
820 (create_page_custom_outgoing): Correct the position of the horizontal separator to
823 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
824 before showing/hiding them, to avoid a crash when clicking on folders when there are no
825 gconf settings. I probably added more checks than necessary, but that is safer.
827 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
828 variable to fix the build, but this seems to be used when it is still NULL.
830 2007-04-27 Murray Cumming <murrayc@murrayc.com>
832 * src/modest-platform.h:
833 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
834 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
835 * src/modest-main.c: Implement this function so we can avoid using
836 maemo-specific API from cross-platform code.
838 * src/modest-tny-account-store.c:
839 (get_smtp_specific_transport_account_for_open_connection):
840 * src/modest-ui-actions.c: (check_for_connection),
841 (modest_ui_actions_on_item_not_found):
842 Use modest_platform_connect_and_wait() and put #idefs around other
843 maemo-specific code, because only maemo currently has a way to
844 identify connection names.
846 2007-04-27 Murray Cumming <murrayc@murrayc.com>
848 * src/modest-tny-account-store.h:
849 * src/modest-tny-account-store.c:
850 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
851 the connection-specific SMTP server settings in the configuration.
853 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
855 * src/maemo/modest-main-window.c: (on_connection_changed),
857 * src/modest-main.c: (main), (start_ui), (send_mail):
858 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
859 that is what is intended.
861 * src/modest-ui-actions.c: (action_send), (action_receive),
862 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
863 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
864 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
865 SMTP server is used when it is specified.
867 (modest_ui_actions_on_send_receive):
868 Check that a connection is open before proceeding.
869 Receive and then send, instead of vice-versa, as per the specification.
871 2007-04-26 Murray Cumming <murrayc@murrayc.com>
873 * src/modest-mail-operation.c:
874 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
875 though I guess it should be something other than NULL.
877 2007-04-26 Murray Cumming <murrayc@murrayc.com>
879 * src/maemo/easysetup/modest-easysetup-wizard.c:
880 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
881 combo twice, to avoid an g_warning and to make it visible again.
882 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
883 attached before detaching it, to avoid a g_warning, and add comment about the implicit
884 (already intended) dereference when detaching, because we then recreate the menu.
885 But I am not sure why the warning was happening, and it is possible that this is a memory
888 2007-04-25 Murray Cumming <murrayc@murrayc.com>
890 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
891 and uri_parse_mailto() utility functions.
892 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
894 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
896 2007-04-24 Murray Cumming <murrayc@murrayc.com>
898 * src/dbus_api/modest-dbus-api.h:
899 * src/dbus_api/modest-dbus-callbacks.c:
900 Use an idle callback to execute the modest code in the application's own thread.
901 Remove the helloworld example method.
902 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
903 parsed, and the open-message method is not implemented because this is not yet implemented in
905 * libmodest-dbus-client/libmodest-dbus-client.c:
906 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
907 (libmodest_dbus_client_open_message):
908 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
910 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
911 body without crashing.
913 * tests/dbus_api/Makefile.am:
914 * tests/dbus_api/test_mail_to.c:
915 * tests/dbus_api/test_open_message.c: New tests for the new methods.
917 2007-04-24 Murray Cumming <murrayc@murrayc.com>
919 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
920 Added file to fix the build. Sorry.
922 * src/dbus_api/Makefile.am:
923 * src/dbus_api/modest-dbus-api.h:
924 * src/dbus_api/modest-dbus-callbacks.h:
925 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
926 (modest_dbus_req_handler):
927 Put constants in a separate header so it can be reused by the
928 client library, without duplication
930 * libmodest-dbus-client/Makefile.am:
931 * libmodest-dbus-client/libmodest-dbus-client.c:
932 (libmodest_dbus_client_call_helloworld),
933 (libmodfest_dbus_client_send_mail),
934 (libmodfest_dbus_client_mailto),
935 (libmodfest_dbus_client_open_message):
936 * libmodest-dbus-client/libmodest-dbus-client.h:
937 (Partly) Implement a send_mail D-Bus method.
939 * tests/dbus_api/Makefile.am:
940 * tests/dbus_api/test_send_mail.c: (main): Added a test for
941 the send_email D-Bus method.
943 2007-04-24 Murray Cumming <murrayc@murrayc.com>
947 * libmodest-dbus-client/Makefile.am:
948 * libmodest-dbus-client/libmodest-dbus-client.c:
949 * libmodest-dbus-client/libmodest-dbus-client.h:
950 * tests/dbus_api/Makefile.am:
951 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
952 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
954 2007-04-24 Murray Cumming <murrayc@murrayc.com>
956 * src/maemo/easysetup/modest-easysetup-wizard.c:
957 (create_page_account_details):
958 * src/maemo/modest-account-settings-dialog.c:
959 (create_page_account_details): Explicitly set auto-capitalization mode for the title
960 widgets, because this might not be the default in future versions of the Maemo GTK+.
961 However, I can not not get capitalization to work even in a simple test case.
963 2007-04-24 Murray Cumming <murrayc@murrayc.com>
965 * src/maemo/easysetup/modest-easysetup-wizard.c:
966 (create_page_custom_incoming), (create_page_custom_outgoing):
967 * src/maemo/modest-account-settings-dialog.c:
968 (create_page_account_details), (create_page_incoming),
969 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
970 instead of using gtk_check_button_with_label(), so they are aligned like the other
971 widgets, as per the UI spec.
973 2007-04-24 Murray Cumming <murrayc@murrayc.com>
975 * src/maemo/easysetup/modest-easysetup-wizard.c:
976 * src/maemo/modest-connection-specific-smtp-edit-window.c:
977 * src/widgets/modest-validating-entry.c:
978 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
979 Modest prefix instead of an EasySetup prefix.
981 2007-04-23 Murray Cumming <murrayc@murrayc.com>
983 * src/widgets/modest-validating-entry.h:
984 * src/widgets/modest-validating-entry.c: (on_insert_text),
985 Added easysetup_validating_entry_set_max_func(), used to set a callback
986 to call when the max number of characters is reached. GtkEntry has a max-length
987 already but is silent about it.
989 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
990 (create_page_account_details), (create_page_user_details),
992 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
993 (create_page_account_details), (create_page_user_details),
994 (create_page_outgoing):
995 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
996 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
997 the UI spec, when the user tries to enter more than the max number of characters.
999 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1001 * src/maemo/easysetup/modest-easysetup-wizard.c:
1002 (create_page_user_details), (create_page_custom_incoming),
1003 (create_page_custom_outgoing):
1004 * src/maemo/modest-account-settings-dialog.c:
1005 (create_page_user_details), (create_page_incoming),
1006 (create_page_outgoing):
1007 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1008 (modest_connection_specific_smtp_edit_window_init):
1009 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
1010 not appropriate. Bad Maemo-specific defaults!.
1012 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1014 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
1015 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
1016 (modest_signature_editor_dialog_set_settings):
1017 Disable the label and textview when the checkbox is disabled, and use the
1018 specified (UI spec) default signature text.
1020 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1022 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1023 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
1025 * src/modest-defs.h:
1026 * src/modest-account-mgr-helpers.h:
1027 * src/modest-account-mgr-helpers.c:
1028 Added modest_account_mgr_get/set_signature(), using new gconf keys.
1030 * src/maemo/Makefile.am:
1031 * src/maemo/modest-signature-editor-dialog.c:
1032 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
1035 * src/maemo/modest-account-settings-dialog.h:
1036 * src/maemo/modest-account-settings-dialog.c:
1037 (modest_account_settings_dialog_finalize), (on_button_signature),
1038 (save_configuration): Use the new dialog when the Edit button is pressed, and
1039 save the changes if necessary, as per the UI spec.
1041 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1043 * src/maemo/Makefile.am:
1044 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
1045 based on maemo-develoers email from Dirk.
1047 * src/maemo/easysetup/modest-easysetup-wizard.c:
1048 (create_page_welcome), (create_page_account_details),
1049 (create_page_user_details), (create_page_complete_easysetup),
1050 (create_page_custom_incoming), (create_page_custom_outgoing),
1051 (create_page_complete_custom),
1052 (modest_easysetup_wizard_dialog_init):
1053 * src/maemo/modest-account-settings-dialog.c:
1054 (create_page_account_details), (create_page_user_details),
1055 (create_page_incoming), (create_page_outgoing),
1056 (modest_account_settings_dialog_init):
1057 * src/maemo/modest-connection-specific-smtp-window.c:
1058 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
1060 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1062 * src/maemo/easysetup/modest-easysetup-wizard.c:
1063 (create_page_account_details), (create_page_custom_outgoing),
1064 (create_page_complete_custom):
1065 * src/maemo/modest-account-settings-dialog.c:
1066 (create_page_user_details), (create_page_incoming),
1067 (create_page_outgoing):
1068 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1069 (modest_connection_specific_smtp_edit_window_init):
1070 Use the correct (UI spec) port min/max, and use horizontal separators,
1073 2007-04-23 Murray Cumming <murrayc@murrayc.com>
1075 * src/maemo/easysetup/modest-easysetup-wizard.c:
1076 (set_default_custom_servernames):
1077 * src/maemo/modest-account-settings-dialog.c:
1078 (create_page_incoming), (on_combo_outgoing_security_changed),
1079 (on_combo_incoming_security_changed), (create_page_outgoing),
1080 (modest_account_settings_dialog_set_account_name),
1081 (save_configuration):
1082 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1083 (on_combo_security_changed),
1084 (modest_connection_specific_smtp_edit_window_init),
1085 (modest_connection_specific_smtp_edit_window_set_connection),
1086 (modest_connection_specific_smtp_edit_window_get_settings):
1087 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
1090 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1093 * src/maemo/easysetup/modest-easysetup-wizard.c:
1094 (create_page_custom_outgoing), (create_page_complete_custom):
1095 * src/maemo/modest-account-settings-dialog.c:
1096 (create_page_user_details), (create_page_outgoing):
1097 * src/maemo/modest-account-view-window.c: (button_box_new):
1098 Use changed logical IDs as per the most recent UI spec:
1099 mcen_bd_emailsetup_edit -> mcen_bd_edit
1100 mcen_bd_emailsetup_delete -> mcen_bd_delete
1101 mcen_bd_emailsetup_close -> mcen_bd_close
1103 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1107 * src/dbus_api/Makefile.am:
1108 * src/dbus_api/modest-dbus-callbacks.c:
1109 * src/dbus_api/modest-dbus-callbacks.h:
1110 * src/maemo/modest-platform.c: (modest_platform_init):
1111 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
1113 * tests/Makefile.am:
1114 * tests/dbus_api/Makefile.am:
1115 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
1117 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1119 * src/maemo/modest-account-settings-dialog.c:
1120 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1121 Removed unnecessary includes.
1123 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1125 * src/maemo/easysetup/modest-easysetup-wizard.c:
1126 * src/maemo/modest-account-settings-dialog.c:
1127 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1128 * src/widgets/Makefile.am:
1129 * src/widgets/modest-easysetup-secureauth-combo-box.c:
1130 * src/widgets/modest-easysetup-secureauth-combo-box.h:
1131 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
1132 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
1133 * src/widgets/modest-secureauth-combo-box.c:
1134 * src/widgets/modest-secureauth-combo-box.h:
1135 * src/widgets/modest-serversecurity-combo-box.c:
1136 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
1137 made the GObject names more consistent with the rest of the Modest code.
1139 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1141 * src/maemo/easysetup/Makefile.am:
1142 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1143 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
1144 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1145 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1146 * src/maemo/easysetup/modest-easysetup-wizard.c:
1147 * src/maemo/easysetup/modest-validating-entry.c:
1148 * src/maemo/easysetup/modest-validating-entry.h:
1149 * src/maemo/modest-account-settings-dialog.c:
1150 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1151 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
1152 widgets/ because they are used outside of easysetup too. After checking in,
1153 svn will allow me to rename them too.
1155 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1157 * src/gnome/modest-msg-edit-window.c:
1158 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
1159 linker error, to fix the build on the GNOME platform.
1160 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
1161 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
1162 ifdefed out to avoid a warning.
1164 2007-04-20 Murray Cumming <murrayc@murrayc.com>
1166 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
1167 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
1168 some alternative for GTK+ 2.6.
1170 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1172 * src/maemo/modest-address-book.c: Added include to avoid a warning.
1174 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
1175 specified for EmailAccountsDialog in UI spec.
1177 * src/maemo/easysetup/modest-easysetup-wizard.c:
1178 * src/maemo/easysetup/modest-easysetup-wizard.h:
1179 * src/maemo/modest-account-settings-dialog.c:
1180 * src/maemo/modest-account-settings-dialog.h:
1181 Reuse a member window widget for the connection-specific SMTP server accounts,
1182 so we can tell it to create/save the accounts only if we actually save changes.
1184 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1185 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1186 (modest_connection_specific_smtp_edit_window_get_settings):
1187 Return a struct instance for temporarily remembering the entered data.
1189 * src/maemo/modest-connection-specific-smtp-window.h:
1190 * src/maemo/modest-connection-specific-smtp-window.c:
1191 (modest_connection_specific_smtp_window_finalize),
1192 (modest_connection_specific_smtp_window_fill_with_connections),
1194 (modest_connection_specific_smtp_window_save_server_accounts),
1195 (update_model_server_names): Do not actually save data until asked,
1196 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
1198 (on_selection_changed),
1199 (modest_connection_specific_smtp_window_init): Disable the edit
1200 button when nothing is selected.
1202 * src/modest-account-mgr-helpers.c:
1203 * src/modest-account-mgr-helpers.h:
1204 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
1207 2007-04-19 Murray Cumming <murrayc@murrayc.com>
1209 * src/modest-account-mgr-helpers.h:
1210 * src/modest-account-mgr-helpers.c:
1211 (modest_account_mgr_get_unused_account_name),
1212 (modest_account_mgr_get_unused_account_display_name): Added these
1213 utility functions, to avoid code duplication.
1215 * src/maemo/easysetup/modest-easysetup-wizard.c:
1216 (create_page_account_details), (create_account):
1217 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1218 (on_combo_security_changed),
1219 (modest_connection_specific_smtp_edit_window_init),
1220 (modest_connection_specific_smtp_edit_window_save_settings):
1221 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1222 * src/maemo/modest-connection-specific-smtp-window.c:
1223 (modest_connection_specific_smtp_window_finalize),
1224 (modest_connection_specific_smtp_window_fill_with_connections),
1225 (on_button_edit), (modest_connection_specific_smtp_window_init):
1226 * src/maemo/modest-connection-specific-smtp-window.h:
1227 Implementing saving of connection-specific server accounts.
1229 But I need to refactor this so we can save the data for each
1230 possible connection-specific account and only actually create the server accounts
1231 when the easysetup finished, or the OK button is pressed on the account settings
1234 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1236 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1237 (on_combo_security_changed):
1238 (modest_connection_specific_smtp_edit_window_init):
1239 Auto-fill the port number as in the account settings.
1241 (modest_connection_specific_smtp_edit_window_set_connection):
1242 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1243 * src/maemo/modest-connection-specific-smtp-window.c:
1244 (fill_with_connections), (on_button_edit),
1245 (modest_connection_specific_smtp_window_init):
1246 Turn the edit window into a dialog to simplify the code, and
1247 set a WM hint as in a GtkDialog, because only a popup can be on top of
1248 another window in Maemo, and popups usually have no WM decoration.
1250 * src/modest-defs.h:
1251 * src/modest-account-mgr-helpers.c:
1252 (modest_account_mgr_set_connection_specific_smtp),
1253 (modest_account_mgr_remove_connection_specific_smtp),
1254 (modest_account_mgr_get_connection_specific_smtp):
1255 * src/modest-account-mgr-helpers.h: Some functions to write the
1256 connection-specific SMTP server information. Not yet used.
1259 * src/widgets/modest-folder-view.c: (text_cell_data):
1260 Fix a warning about an uninitialized variable.
1261 (on_configuration_key_changed): Put an #ifdef around the use
1262 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
1264 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1266 * src/maemo/modest-account-settings-dialog.h:
1267 * src/maemo/modest-account-settings-dialog.c:
1268 Added connect_for_modified() utility function to mark the new modified boolean.
1270 (create_page_account_details), (create_page_user_details),
1271 (create_page_incoming), (create_page_outgoing), (on_response),
1272 (modest_account_settings_dialog_init),
1273 (modest_account_settings_dialog_set_account_name):
1274 Only warn about unsaved changes when there are actually unsaved changes.
1276 * src/modest-account-mgr-helpers.c:
1277 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
1278 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
1279 to get the data from there in future.
1281 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1283 * src/modest-defs.h:
1285 * src/modest-account-mgr-helpers.h:
1286 * src/modest-account-mgr-helpers.c:
1287 Store the security account setting in a single conf key instead of using
1288 the options list, so that the list is left for just the to-be-removed camel hack,
1289 and because gconf_client_set_list() is failing for some reason.
1291 * src/modest-account-mgr.c:
1292 (modest_account_mgr_add_server_account):
1293 * src/maemo/modest-account-settings-dialog.c:
1294 (modest_account_settings_dialog_set_account_name),
1295 (save_configuration): Use the renamed functions.
1298 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1300 * src/widgets/Makefile.am:
1301 * src/widgets/modest-limit-retrieve-combo-box.c:
1302 * src/widgets/modest-limit-retrieve-combo-box.h:
1303 * src/widgets/modest-retrieve-combo-box.c:
1304 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
1305 the account settings dialog.
1307 * src/modest-defs.h:
1308 * src/modest-account-mgr-helpers.h:
1309 * src/modest-account-mgr-helpers.c:
1310 (modest_server_account_get_option_secure_auth),
1311 (modest_server_account_set_option_secure_auth):
1312 * src/modest-account-mgr.c:
1313 (modest_account_mgr_add_server_account):
1314 Use the existing AUTH_MECH conf key for the secure-auth setting,
1315 instead of putting it in the list options, because this was actually used already.
1317 * src/maemo/modest-account-settings-dialog.c:
1318 (create_page_account_details),
1319 (modest_account_settings_dialog_set_account_name),
1320 (save_configuration):
1321 * src/maemo/modest-account-settings-dialog.h:
1322 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
1323 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
1325 2007-04-18 Murray Cumming <murrayc@murrayc.com>
1327 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
1328 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
1329 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
1331 * src/modest-defs.h:
1332 * src/maemo/modest-account-settings-dialog.c:
1333 (create_page_incoming), (on_combo_outgoing_security_changed),
1334 (on_combo_incoming_security_changed), (create_page_outgoing),
1335 (modest_account_settings_dialog_set_account_name),
1336 (save_configuration): Load/Save the port number, and change it when the
1337 security combo changes, to suitable defaults.
1339 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-account-mgr.c:
1342 (modest_account_mgr_add_server_account): Set the security and secure-auth
1343 options, and add a comment saying that the other camel-specific options should be
1346 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1348 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
1350 * src/modest-tny-account-store.c: (account_list_free),
1351 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
1352 cursor->data after unreffing it. But there is some strange stuff there so it might not be
1355 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1357 * src/modest-protocol-info.c:
1358 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
1359 is required by our UI spec. Maybe something in our implementation will use this eventually.
1360 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
1361 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
1362 instead of the previous 0 placeholder.
1364 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
1365 secure-auth settings.
1366 * src/modest-account-mgr-helpers.h:
1367 * src/modest-account-mgr-helpers.c:
1368 (modest_server_account_data_get_option_secure_auth),
1369 (modest_server_account_set_option_secure_auth),
1370 (modest_server_account_data_get_option_security),
1371 (modest_server_account_set_option_security): Added this API for getting and setting the security
1372 and secure-auth settings.
1374 * src/maemo/modest-account-settings-dialog.h:
1375 * src/maemo/modest-account-settings-dialog.c:
1376 (modest_account_settings_dialog_finalize), (check_data),
1377 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
1378 about changing titles.
1379 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
1380 (save_configuration): Save the security and secure-auth settings.
1382 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
1383 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
1385 2007-04-17 Murray Cumming <murrayc@murrayc.com>
1387 * src/modest-defs.h:
1388 * src/modest-account-mgr.c:
1389 (modest_account_mgr_add_server_account):
1390 Added and used defines for the options key and value pair strings,
1391 that are used so far, though they do not seem to correspond to anything in our
1392 UI specs or ModestProtocol enum.
1394 * src/modest-account-mgr-helpers.h:
1395 * src/modest-account-mgr-helpers.c:
1396 (compare_option_strings_for_name),
1397 (modest_server_account_data_get_option_value),
1398 (modest_server_account_data_get_option_bool),
1399 (modest_account_mgr_get_server_account_option):
1400 Added helper functions for parsing the options GSList.
1402 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1404 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
1405 display name is based on the supplied account name.
1406 * src/modest-account-mgr.c:
1407 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
1408 with an inefficient, but good-enough, implementation.
1410 * src/maemo/easysetup/modest-easysetup-wizard.c:
1411 (create_page_account_details), (on_before_next), (create_account):
1412 Check for existing display names rather than (non-user-visible) account names, and just
1413 create and set a unique account name at the end.
1415 * src/maemo/modest-account-settings-dialog.c:
1416 (modest_account_settings_dialog_init),
1417 (modest_account_settings_dialog_set_account_name),
1418 (create_page_incoming): Show the display name, instead of the account name.
1419 (on_response): Do some (not all) extra checks, as in the UI spec.
1420 (save_configuration): Save the display name if it was changed.
1422 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1424 * po/en_GB.po: Added needed logical ID and translation.
1425 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1426 (init_view): Made the is-default column clicking work.
1428 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1431 * src/maemo/easysetup/Makefile.am:
1432 * src/maemo/easysetup/modest-easysetup-wizard.c:
1433 (modest_easysetup_wizard_dialog_init):
1434 * src/maemo/easysetup/provider-data-test.keyfile:
1435 * src/maemo/easysetup/provider-data.keyfile:
1436 Moved the provider data file to the new modest-providers-data package and used it from there.
1438 2007-04-16 Murray Cumming <murrayc@murrayc.com>
1440 * src/modest-local-folder-info.c:
1441 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
1442 N_() was already used on the static strings, but this just marks it for translation without
1443 using the translation.
1445 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1447 * src/maemo/modest-account-settings-dialog.c:
1448 (create_page_incoming),
1449 (modest_account_settings_dialog_set_account_name):
1450 Added comments about the need for new API in ModestAccountMgr to handle the authentication
1451 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
1452 I will do this if nobody else gets there first.
1454 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1456 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1457 Saved much of the incoming and outgoing data too, though I cannot yet see how to
1458 save the security stuff.
1460 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1462 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1463 Set the email address and user fullname, which I now see must be
1466 * src/maemo/modest-account-settings-dialog.h:
1467 * src/maemo/modest-account-settings-dialog.c:
1469 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
1470 leave-on-server and authentication.
1471 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
1474 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1477 * src/maemo/modest-account-settings-dialog.c:
1478 * src/maemo/modest-account-settings-dialog.h:
1479 Most (but not all) of the widgets are now present as specified by the UI spec.
1480 No changes are yet saved, and some details are not properly shown yet.
1482 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
1484 2007-04-06 Murray Cumming <murrayc@murrayc.com>
1486 * src/maemo/Makefile.am:
1487 * src/maemo/modest-account-settings-dialog.c:
1488 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
1489 an existing account. Doesn't do much yet.
1491 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1492 Open the accounts settings dialog when Edit is clicked.
1494 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1496 * src/maemo/easysetup/Makefile.am:
1497 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1499 * src/maemo/easysetup/modest-easysetup-wizard.c:
1500 (modest_easysetup_wizard_dialog_init):
1501 Try to get the source directory from the build system,
1502 instead of hard-coding "./" into the source code, when opening our local
1503 copies of the configuration files.
1504 But this still fails when opening the wizard from the Accounts window,
1505 maybe because the working directory seems to change at runtime.
1506 So the wizard will fail the second time unless you copy the files into their
1507 proper locations - see the stdout warnings for the paths.
1509 (create_page_account_details),(on_before_next):
1510 Check for existing non-server accounts instead of server accounts,
1511 so the default account name is useful again, and to prevent trying to
1514 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
1515 Show the wizard when New is clicked.
1517 * src/widgets/modest-account-view.c: (on_account_default_toggled),
1518 (init_view): Show the column headers, and show the columns that are
1519 specified in the UI specs. However, something in Maemo's GTK+ prevents
1520 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
1521 change the default account. This is despite unsetting the special properties.
1523 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1525 * docs/reference/modest-design.sgml: Corrected spelling mistake.
1526 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1527 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
1528 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
1529 to make that clearer.
1530 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
1532 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1534 * src/maemo/modest-account-view-window.c:
1535 (modest_account_view_window_init),
1536 (modest_account_view_window_new):
1537 Use the same buttons as specified in the
1538 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
1539 the existing widgets, which never had a chance of working.
1540 Put the ModestAccountView treeview in a scrolled window.
1541 Do not repeat the initialization in both _init() and _new().
1543 * src/widgets/modest-account-view.c: (update_account_view):
1544 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
1545 this widget and window shows no accounts.
1547 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
1549 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1551 * src/maemo/easysetup/modest-easysetup-wizard.c:
1552 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
1553 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
1554 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
1557 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
1558 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
1559 accounts exist yet, as in the UI spec.
1561 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
1563 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1565 * src/maemo/Makefile.am:
1566 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1567 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1568 New window for editing connection-specific smtp details.
1569 Not fully implemented.
1571 * src/maemo/modest-connection-specific-smtp-window.c:
1572 (modest_connection_specific_smtp_window_finalize) :
1573 unref the tree model.
1574 (on_button_edit): Show the edit window.
1576 2007-04-05 Murray Cumming <murrayc@murrayc.com>
1578 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
1581 * src/maemo/Makefile.am:
1582 * src/maemo/modest-connection-specific-smtp-window.c:
1583 * src/maemo/modest-connection-specific-smtp-window.h:
1584 New window for showing the list of connections, for connection-specific
1585 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
1586 * src/maemo/easysetup/modest-easysetup-wizard.c:
1587 (create_page_custom_outgoing): Show the new window when the button is clicked.
1589 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1591 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1592 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1593 * src/maemo/modest-msg-edit-window.c:
1594 (modest_msg_edit_window_insert_image):
1595 * src/modest-conf.c: (modest_conf_key_escape):
1596 * src/modest-mail-operation.c:
1597 (modest_mail_operation_send_new_mail):
1598 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1599 (modest_ui_actions_on_new_account):
1600 * src/widgets/modest-attachment-view.c: (update_filename_request):
1601 * src/widgets/modest-mail-header-view.c:
1602 Corrected warnings that were breaking the build, by commenting out unused variables,
1603 and a function, and by including a header.
1605 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1607 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
1608 so we can #ifdef around platform-specific code when necessary.
1609 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
1610 to allow this to build for the GNOME platform too.
1612 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1614 * src/maemo/easysetup/modest-easysetup-wizard.c:
1615 Added util_increment_name() and used it in create_page_account_details()
1616 to make sure that the default account name is always a new name.
1618 (modest_easysetup_wizard_dialog_init),
1619 (set_default_custom_servernames): Some minor memory management fixes.
1621 2007-04-04 Murray Cumming <murrayc@murrayc.com>
1625 * src/modest-runtime.c: (init_i18n): Restored the translation
1626 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
1627 are defined in config.h, and the translations are installed.
1629 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
1630 is defined for translation.
1632 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1634 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
1636 * src/maemo/easysetup/modest-easysetup-wizard.c:
1637 (modest_easysetup_wizard_dialog_init):
1638 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
1639 Use realistic paths (though they should use $prefix generically) to the
1640 mcc_mapping and provider-data.keyfile files which might work when they
1641 are installed by the future version of the operator-wizard package,
1642 and then fallback to paths in our source code, with an explanatory
1645 2007-04-03 Murray Cumming <murrayc@murrayc.com>
1649 * src/maemo/Makefile.am:
1650 * src/maemo/easysetup/: Added files from the previously-exernal
1651 osso-modest-easysetup.
1652 * src/maemo/modest-main-window-ui.h:
1653 * src/modest-ui-actions.c:
1654 * src/modest-ui-actions.h:
1655 Added modest_ui_actions_on_new_account() as a signal handler for the
1656 New Account menu item. It shows the easysetup wizard.
1657 * po/en_GB.po: Added additional needed logical IDs and translations.
1659 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
1660 Apparently ChangeLog is not used for some vague Nokia legal reasons.