1 2007-06-27 Murray Cumming <murrayc@murrayc.com
3 * src/maemo/modest-maemo-global-settings-dialog.c:
4 (idle_select_default_focus):
5 * src/modest-mail-operation.c: (idle_notify_progress),
6 (idle_notify_progress_once), (set_last_updated_idle),
7 (update_account_thread), (get_msgs_full_thread):
8 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
9 * src/widgets/modest-header-view.c:
10 (idle_notify_headers_count_changed_destroy),
11 (idle_notify_headers_count_changed):
12 Reverted the additions of gdk_threads_enter/leave(), in case this
13 helps with a startup hang on the device.
15 2007-06-26 Armin Burgmeier <armin@openismus.com>
17 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
18 for supported secure authentication methods from server by
19 gtk_dialog_run(), saving CPU time and a potential race condition.
21 2007-06-26 Armin Burgmeier <armin@openismus.com>
23 * src/maemo/modest-maemo-utils.h:
24 * src/maemo/modest-maemo-utils.c: Added a
25 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
26 only error code to tell the calling code when the user canceled the
29 * src/maemo/modest-account-settings-dialog.h:
30 * src/maemo/modest-account-settings-dialog.c:
31 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
32 message if the retrieval of secure authentication methods was canceled
33 by the user. Perform the check before saving anything to configuration
34 to not end up with half-committed configuration changes, do not show
35 a "Saving to configuration failed" note when authentication methods
36 could not be retrieved.
38 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
41 2007-06-26 Murray Cumming <murrayc@murrayc.com>
43 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
44 Only return the first level of folders under accounts, because the
45 osso-global-search UI spec doesn't want the rest.
46 This fixed projects.maemo.org bug NB#61811.
48 2007-06-26 Murray Cumming <murrayc@murrayc.com>
50 * src/modest-tny-account-store.c:
51 * src/modest-tny-account-store.h:
52 Added modest_tny_account_is_memory_card_account().
53 * src/maemo/modest-main-window.c: (create_details_widget):
54 Show the same information items for the memory card as we show for the
55 local-folders, to fix projects.maemo.org bug NB#59307.
57 2007-06-26 Murray Cumming <murrayc@murrayc.com>
59 * src/modest-tny-account-store.c: (get_password):
60 Added some checks for NULL to maybe prevent crashes, though I think
61 it was Philip's last commit that actually prevented the crash here
62 when creating a first new account.
63 But the new account is still not usable (no messages are shown)
64 until a restart of the application.
66 2007-06-26 Murray Cumming <murrayc@murrayc.com>
68 * src/maemo/modest-maemo-global-settings-dialog.c:
69 (idle_select_default_focus):
70 * src/modest-mail-operation.c: (idle_notify_progress),
71 (idle_notify_progress_once), (idle_notify_update_account_queue),
72 (set_last_updated_idle), (update_account_thread),
73 (notify_get_msgs_full), (get_msgs_full_destroyer),
74 (get_msgs_full_thread):
75 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
76 * src/widgets/modest-header-view.c:
77 (idle_notify_headers_count_changed_destroy),
78 (idle_notify_headers_count_changed):
79 Use gdk_threads_enter() and gdk_threads_enter_leave() in
80 all idle handlers, because some other thread could be blocking
81 the GDK lock, so that it can do GUI stuff.
83 2007-06-26 Murray Cumming <murrayc@murrayc.com>
85 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
86 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
87 (on_idle_send_receive), (on_idle_open_default_inbox):
88 * src/maemo/modest-msg-edit-window.c:
89 (modest_msg_edit_window_attach_file_noninteractive):
90 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
91 to prevent a hang. I don't quite understand why these are necessary,
92 beause we should already be in the main loop. I guess something outside
93 of the main loop is taking the lock.
95 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
96 we are really using URIs, and use files that are more likely to exist.
98 2007-06-26 Murray Cumming <murrayc@murrayc.com>
100 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
101 necessary because configure.ac now defines different variables.
103 2007-06-26 Murray Cumming <murrayc@murrayc.com>
105 * libmodest-dbus-client/libmodest-dbus-client.c:
106 * libmodest-dbus-client/libmodest-dbus-client.h:
107 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
108 libmodest_dbus_client_compose_mail() is what things actually use.
110 * src/dbus_api/modest-dbus-api.h:
111 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
112 * tests/dbus_api/Makefile.am:
113 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
116 2007-06-26 Murray Cumming <murrayc@murrayc.com>
118 * src/modest-init.c: (modest_init_local_folders):
119 For memory-card (or other non local-folders) maildir accounts,
120 always create an Archive folder, so that there is somewhere to put
121 messages. This should be less confusing, because the user does not need
122 to guess that the need to create a folder.
124 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
126 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
127 Fixed icon size by using (50, 50) which is the same as defined by
130 2007-06-25 Armin Burgmeier <armin@openismus.com>
132 * src/widgets/modest-window-mgr.c:
134 * configure.ac: Correctly recognize hildon-notify presence and fixed
135 the build without it being installed.
137 2007-06-25 Murray Cumming <murrayc@murrayc.com>
139 * libmodest-dbus-client/libmodest-dbus-client.c:
140 (libmodest_dbus_client_search): Fix the build. Sorry.
141 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
142 (reply_forward_cb): Initialize variables to fix the build.
144 * src/modest-tny-account-store.c:
145 (modest_tny_account_store_get_tny_account_by): Fix the account URI
146 comparison (a silly typo) so that email search results can be opened
147 when there are more than one account.
149 2007-06-25 Murray Cumming <murrayc@murrayc.com>
151 * libmodest-dbus-client/libmodest-dbus-client.c:
152 (libmodest_dbus_client_search),
153 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
154 instead of 1 second, because the search gets folders and messages from
155 the server, which can take a long time. When it times out,
156 osso-global-search will report no results.
158 We need to specify whether we should search only cached information
159 (maybe with a user preference), and the osso-email-search-plugin
160 API should really be improved to allow that option, and to allow results
161 to be delivered asynchronously in batches.
163 2007-06-25 Murray Cumming <murrayc@murrayc.com>
165 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
166 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
167 GTK_ICON_SIZE_DIALOG is probably the wrong size.
169 2007-06-25 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
172 that is an empty string. D-Bus seems to give us these instead of NULL.
174 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
176 * src/dbus_api/modest-dbus-callbacks.c:
177 * src/maemo/easysetup/modest-easysetup-wizard.h:
178 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
179 * src/maemo/modest-connection-specific-smtp-edit-window.c:
180 (modest_connection_specific_smtp_edit_window_init):
181 * src/maemo/modest-maemo-global-settings-dialog.c:
183 * src/maemo/modest-maemo-utils.c:
184 (modest_maemo_utils_setup_images_filechooser):
185 * src/maemo/modest-main-window.c: (create_details_widget):
186 * src/maemo/modest-msg-edit-window.c:
187 (modest_msg_edit_window_attach_file_noninteractive),
188 (modest_msg_edit_window_color_button_change),
189 (modest_msg_edit_window_set_zoom):
190 * src/modest-mail-operation.c: (update_account_thread):
191 * src/modest-tny-account-store.c:
192 * src/modest-tny-account.c:
193 * src/widgets/modest-global-settings-dialog.c:
194 * src/widgets/modest-window.h:
198 2007-06-25 Murray Cumming <murrayc@murrayc.com>
200 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
201 * src/modest-search.c: (modest_search_folder),
202 (modest_search_all_accounts): Actually search only in the specified folder,
203 doing a simple match on the folder ID.
204 * src/modest-search.h: Added a folder field to the ModestSearch struct,
205 and added some documentation.
207 2007-06-22 Armin Burgmeier <armin@openismus.com>
209 * src/maemo/modest-maemo-utils.h:
210 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
211 modest_maemo_utils_get_supported_secure_authentication_methods.
213 * src/maemo/easysetup/modest-easysetup-wizard.c:
214 * src/maemo/modest-account-settings-dialog.c: Show correct error if
215 one occured, not just "Server does not support secure authentication".
217 2007-06-22 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-tny-account-store.c: (get_password):
220 Restored the call to tny_account_set_user() because Philip seems to have
221 stopped this from crashing (by not using the freed string). It still does
222 not work, but now we can test it.
224 2007-06-22 Murray Cumming <murrayc@murrayc.com>
226 * src/maemo/modest-msg-edit-window.c: (init_window):
227 Comment out use of an uninitialzed GtkScrolledWindow variable,
228 to fix the build and stop a crash. Yet again.
230 2007-06-22 Murray Cumming <murrayc@murrayc.com>
232 * src/modest-tny-account-store.c: (get_password):
233 Remove the call to tny_account_set_user() because this actually crashes.
234 As mentioned in the last commit, it is known to not work anyway.
236 2007-06-22 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-tny-account-store.c: (get_password):
239 Use tny_account_set_username() to tell tinymail that the username might
240 have changed too. But tinymail ignores this: see projects.maemo.org
242 * src/modest-ui-actions.c:
243 (modest_ui_actions_on_password_requested): Remove the useless attempt to
244 reset the connection when changing the username, and improve the comments.
245 Save the changed username to gconf at least, so it is used when Modest is
248 2007-06-21 Murray Cumming <murrayc@murrayc.com>
250 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
251 Do not use a query, so that we get all folders, including for POP and
252 local-folders. They work as search criteria too.
253 This fixes projects.maemo.org bug NB#57740.
255 2007-06-21 Murray Cumming <murrayc@murrayc.com>
257 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
258 Comment out the use of hildon_notification_set_sound() because it is
259 not declared, to fix the build. Warnings are serious, people.
261 2007-06-21 Armin Burgmeier <armin@openismus.com>
263 * src/maemo/modest-maemo-utils.h:
264 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
265 modest_maemo_utils_get_supported_secure_authentication_methods()
266 to query authentication methods for a specific user. This should fix
267 projects.maemo.org bug NB#61369.
269 * src/maemo/easysetup/modest-easysetup-wizard.c:
270 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
273 2007-06-21 Murray Cumming <murrayc@murrayc.com>
275 * libmodest-dbus-client/libmodest-dbus-client.h:
276 * libmodest-dbus-client/libmodest-dbus-client.c:
277 (modest_dbus_message_iter_get_search_hit),
278 (libmodest_dbus_client_search):
279 Reorganised and commented this.
280 Removed modest_search_hit_free() from the public API because it
283 Added libmodest_dbus_client_get_folders() and
284 modest_folder_result_list_free().
286 * src/dbus_api/modest-dbus-api.h:
287 * src/dbus_api/modest-dbus-callbacks.c:
288 (modest_dbus_req_filter): Commented. Moved most code to
289 on_dbus_method_search() and added on_dbus_method_get_folders().
291 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
292 of the extra D-Bus handler.
294 * tests/dbus_api/Makefile.am:
295 * tests/dbus_api/test_get_folders.c: New test for
296 libmodest_dbus_client_get_folders(). This seems to return an empty list
297 at the moment. That could be the same error that causes the message list
298 to be empty sometimes.
299 This should help with projects.maemo.org bug NB#57740.
301 2007-06-21 Armin Burgmeier <armin@openismus.com>
303 * src/modest-mail-operation.c: Do not call
304 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
305 notify the operation's end after having set the status to CANCELED for
306 the operation queue to listen on. This fixes a deadlock when there
307 were mail operations in the queue during its finalization.
309 * src/modest-singletons.c: Reordered uninitialization of the account
310 manager to happen after the mail operation queue was uninitialized
311 because the mail operation's in the queue might still try to access
312 the account manager (see modest_mail_operation_notify_end()). This
313 fixes a potential crash when terminating the application.
315 2007-06-21 Murray Cumming <murrayc@murrayc.com>
317 * src/modest-search.c:
318 (search_mime_part_and_child_parts): Moved some code here so we
319 can search recursively in child folders.
320 (modest_search_folder): Search in the message as a mime part, instead
321 of just its child mime parts.
322 (read_chunk), (search_mime_part_ogs):
323 Check how many bytes were read, to prevent an endless loop.
324 Searching in message bodies now works. This finishes the fix for
325 projects.maemo.org bug NB#61007.
327 2007-06-20 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
330 Add a g_warning when the item is not a folder.
332 * src/modest-ui-dimming-rules.c:
333 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
334 when selected item is not a folder (for instance, an account), because
335 the UI spec only talks about folders.
336 I am not sure what the UI spec wants, so this might not totally fix
337 projects.maemo.org bug NB#60794.
339 2007-06-20 Murray Cumming <murrayc@murrayc.com>
341 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
342 (load_from_file): Sort the list. The unsorted list would be more noticeable
343 in non-English locales.
345 * src/maemo/modest-msg-edit-window.c:
346 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
347 warning and fix the build.
349 * src/maemo/modest-progress-bar-widget.c:
350 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
351 avoid a g_warning, and probably to avoid a crash.
353 2007-06-20 Murray Cumming <murrayc@murrayc.com>
355 * src/modest-search.c: (modest_search_folder): Check for a GError
356 when calling tny_folder_get_headers(), to show that this is not the cause
359 2007-06-20 Murray Cumming <murrayc@murrayc.com>
361 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
362 Actually set the body query instead of the subject query.
364 * src/modest-search.c: (search_mime_part_ogs),
365 (search_mime_part_strcmp): Remove extra space from the text/* regex,
366 which would probably cause it to fail if we got this far.
368 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
369 to simplify the code.
370 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
371 be causing search-in-body to fail.
373 2007-06-20 Murray Cumming <murrayc@murrayc.com>
375 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
377 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
378 Better debug message when the folder cannot be found.
379 This should help with fixing projects.maemo.org bug #61287.
380 * src/modest-search.c: (add_hit): Do not leak the furl string.
382 2007-06-20 Murray Cumming <murrayc@murrayc.com>
384 * src/modest-ui-actions.c:
385 (modest_ui_actions_on_folder_selection_changed):
386 Do not special-case TNY_MERGE_FOLDER here, because
387 modest_tny_folder_get_account() already does that. This fixes
388 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
389 shown when the Outbox was selected).
391 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
393 * libmodest-dbus-client/libmodest-dbus-client.c:
394 (_dbus_iter_get_string_or_null): Initialize the string variable in
395 case this helps with Dirk's crash.
397 2007-06-19 Murray Cumming <murrayc@murrayc.com>
399 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
400 though it is not implemented yet (this function is maybe not even used),
401 to avoid breaking ABI in future.
402 * libmodest-dbus-client/libmodest-dbus-client.c:
403 (get_attachments_string): Moved some code into this generic function.
404 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
405 sends email. It is maybe not used.
406 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
407 (on_send_mail): Use attachments.
409 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
410 * src/maemo/modest-msg-edit-window.c:
411 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
412 a filename before using it, to fix projects.maemo.org bug NB#58233.
414 2007-06-19 Murray Cumming <murrayc@murrayc.com>
416 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
417 Initialize the continue_download variable to fix the build, and probably
418 to fix randome behaviour.
420 2007-06-18 Armin Burgmeier <armin@openismus.com>
422 * src/modest-tny-send-queue.h:
423 * src/modest-tny-send-queue.c: Keep track of the status of messages in
424 the queue so we can later show it in the UI. Replaced
425 modest_tny_send_queue_msg_is_being_sent() by
426 modest_tny_send_queue_get_msg_status().
428 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
430 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
431 gpointer. This probably was not harmful, but just to be sure.
433 2007-06-18 Murray Cumming <murrayc@murrayc.com>
435 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
436 Fix the build, but leave the function broken on Bora, because
437 hildon_uri_action_get_service() does not exist.
438 osso_uri_action_get_service() does not exist either, it seems.
440 2007-06-18 Murray Cumming <murrayc@murrayc.com>
442 * src/modest-tny-account.c:
443 (modest_tny_account_new_from_server_account):
444 Uncommented the url debug output again, because it is useful for
445 debugging, as I said in the comment.
447 2007-06-18 Murray Cumming <murrayc@murrayc.com>
449 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
451 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
452 for Mameo Bora, to fix the build.
454 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
457 Fixed build with hildon < 0.99
459 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
460 Check if the selected account is busy instead of checking all accounts
462 * src/modest-account-mgr-priv.h:
463 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
464 (modest_account_mgr_init), (compare_account_name),
465 (modest_account_mgr_set_account_busy),
466 (modest_account_mgr_account_is_busy):
467 * src/modest-account-mgr.h:
468 Added busy information to the account manager. It possible to
469 set an account to busy or not busy now.
471 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
472 (modest_mail_operation_update_account),
473 (modest_mail_operation_notify_end):
474 Set the account to busy/not busy depending on the operation state.
476 * src/widgets/modest-account-view.c:
477 (modest_account_view_finalize), (get_last_updated_string),
478 (update_account_view), (on_account_busy_changed), (init_view):
479 Show string "Refreshing..." if the account is currently busy.
481 All this fixes projects.maemo.org bug NB#59711
483 2007-06-14 Armin Burgmeier <armin@openismus.com>
485 * src/widgets/modest-attachments-view.h:
486 * src/widgets/modest-attachments-view.c: Added
487 modest_attachments_view_has_attachments() and fixed coordinate
488 transformation in get_att_view_at_coords(). This fixes attachment
491 * src/widgets/modest-msg-view.c: Make use of
492 modest_attachments_view_has_attachments() to decide whether to show
493 attachments in the header.
495 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
497 * src/maemo/modest-connection-specific-smtp-edit-window.c:
498 (on_change), (on_combo_security_changed),
499 (modest_connection_specific_smtp_edit_window_init),
500 (modest_connection_specific_smtp_edit_window_set_connection),
501 (modest_connection_specific_smtp_edit_window_is_dirty):
502 * src/maemo/modest-connection-specific-smtp-edit-window.h:
503 * src/maemo/modest-connection-specific-smtp-window.c:
506 Show an comfirmation dialog for the smpt-edit-window if there are
507 unsaved changes and the user hits cancel.
508 (projects.maemo.org bug NB#60479)
510 2007-06-14 Armin Burgmeier <armin@openismus.com>
512 * src/maemo/easysetup/modest-easysetup-wizard.c:
513 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
514 address" info in banner instead of node, and select all the text as
515 per UI spec. This fixes projects.maemo.org bug NB#60550.
517 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
519 reviewed by: <delete if not using a buddy>
521 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
522 * src/modest-ui-actions.c: (folder_refreshed_cb):
524 2007-06-14 Murray Cumming <murrayc@murrayc.com>
526 * src/widgets/modest-folder-view.c: (filter_row):
527 Explictly filter out the per-account outbox accounts. I don't know why
528 these only sometimes show up, but now they should never show up in the UI.
529 This should fix projects.maemo.org bug NB#60160.
531 2007-06-14 Murray Cumming <murrayc@murrayc.com>
533 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
534 when the toolbar does not exist yet.
535 * src/modest-widget-memory.c: (save_settings_header_view):
536 Added g_warnings() to help us to discover when we are trying to set
537 an empty columns list in gconf.
539 2007-06-14 Murray Cumming <murrayc@murrayc.com>
543 Added modest_init_get_default_header_view_column_ids().
545 * src/modest-widget-memory.c: (restore_settings_header_view):
546 Use the new function to get defaults, if the gconf key is empty,
547 instead of not creating any columns. This seems to fix the
548 empty right-hand pane problems.
550 * src/widgets/modest-header-view.h: Improved documentation.
552 2007-06-13 Murray Cumming <murrayc@murrayc.com>
554 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
555 Revert the use of the display name as the account name, because this
556 is generally wrong and would break the code that follows.
558 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
560 * src/maemo/easysetup/modest-easysetup-wizard.c:
561 (check_for_supported_auth_methods), (on_before_next),
564 More correct fix for projects.maemo.org bug NB# 58991
565 Do not longer accept AUTH_PASSWORD as secure method and choose
566 correct method when creating the account.
568 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
570 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
571 Fixed projects.maemo.org bug NB# 58991
573 2007-06-13 Murray Cumming <murrayc@murrayc.com>
575 * src/modest-init.c: (modest_init_init_core),
576 (modest_init_local_folders): Fixed compilation errors.
578 2007-06-13 Murray Cumming <murrayc@murrayc.com>
580 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
581 Remove unnecessary lib/include, though it is good in principle when needed.
583 * src/modest-init.c: (modest_init_one_local_folder),
584 (modest_init_local_folders):
585 * src/modest-init.h: Initialize the .modest library for memory cards,
586 instead of just doing nothing for them. This should allow us to create
587 folders there, fixing projects.maemo.org bug NB#59297.
589 2007-06-13 Murray Cumming <murrayc@murrayc.com>
591 * libmodest-dbus-client/libmodest-dbus-client.c:
592 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
593 (libmodest_dbus_client_compose_mail),
594 (libmodest_dbus_client_open_message),
595 (libmodest_dbus_client_send_and_receive),
596 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
598 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
599 (on_idle_open_message), (modest_dbus_req_handler),
600 (search_result_to_message), (modest_dbus_req_filter):
601 * src/modest-search.c: (add_hit), (modest_search_folder),
602 (modest_search_all_accounts): Improved debug messages.
604 * tests/dbus_api/test_open_message.c: (main): Improved comments.
606 * src/modest-tny-account-store.c:
607 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
610 2007-06-13 Murray Cumming <murrayc@murrayc.com>
613 2007-06-12 Murray Cumming <murrayc@murrayc.com>
615 * src/modest-tny-account-store.c: (get_server_accounts):
616 Call modest_tny_local_folders_account_add_merged_outbox_folders()
617 even when there are no accounts, so that the Outbox folder is always
618 visible. This fixes projects.maemo.org bug NB#60158.
620 2007-06-12 Murray Cumming <murrayc@murrayc.com>
622 * src/maemo/modest-main-window.c: (create_details_widget):
623 Use the mcen_va_never logical ID.
625 2007-06-12 Murray Cumming <murrayc@murrayc.com>
627 * src/dbus_api/modest-dbus-api.h:
628 * src/dbus_api/modest-dbus-callbacks.c:
629 (on_idle_open_default_inbox), (on_open_default_inbox),
630 (modest_dbus_req_handler):
631 Added a new OpenDefaultInbox method.
633 * libmodest-dbus-client/libmodest-dbus-client.h:
634 * libmodest-dbus-client/libmodest-dbus-client.c:
635 Added libmodest_dbus_client_open_default_inbox() to call the new
636 dbus method. This should be useful to projects.maemo.org bug NB#57214,
637 though it should maybe be used by a new osso-email-interface function.
639 * tests/dbus_api/Makefile.am:
640 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
643 2007-06-12 Murray Cumming <murrayc@murrayc.com>
645 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
646 NULL, so that the signals get all the keys. This should not actually
647 change any behaviour because we currently update everything when anything
650 2007-06-12 Murray Cumming <murrayc@murrayc.com>
652 * src/widgets/modest-folder-view.c: (text_cell_data),
653 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
654 (find_inbox_iter): If tinymail tells us that the folder is
655 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
656 This causes the inbox to be selected at startup, fixing part of
657 projects.maemo.org bug NB#56305.
659 * src/modest-ui-dimming-rules.c:
660 (modest_ui_dimming_rules_on_tools_smtp_servers):
661 * src/modest-ui-dimming-rules.h: Added a callback function to dim
662 the SMTP servers menu item.
663 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
664 that the SMTP Servers menu item is dimmed when there are no accounts,
665 as a future version of the UI spec will require. This fixes
666 projects.maemo.org bug NB#56305.
668 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
670 * src/maemo/modest-maemo-utils.c:
671 (modest_maemo_utils_get_supported_secure_authentication_methods):
672 Added label to dialog instead of unreadable title
674 * src/maemo/modest-main-window.c: (sync_accounts_cb),
675 (modest_main_window_new):
676 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
679 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
680 * src/modest-account-mgr.h:
681 Added method to avoid code duplication
683 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
684 (modest_ui_actions_on_send_receive):
685 Use modest_account_mgr_has_accounts
687 2007-06-11 Murray Cumming <murrayc@murrayc.com>
689 * src/maemo/easysetup/modest-presets.c:
690 (modest_presets_get_info_server_security): Do not report secure auth
692 * src/modest-protocol-info.c: Use the defines for the gconf key names
693 for secure authentication. This was not working because we were writing
694 Password and reading password, and the check was case sensitive.
695 With this, gmail now works for receiving and sending when created via
698 2007-06-11 Murray Cumming <murrayc@murrayc.com>
700 * src/maemo/easysetup/modest-presets.c:
701 (modest_presets_get_info_server_security): Correct the key name for
702 SecureSmtp, because it seems to be case-sensitive.
703 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
704 Do not try to get the 0th notebook page if there are 0 pages, to
707 2007-06-11 Murray Cumming <murrayc@murrayc.com>
709 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
710 Prevent use of the new notification feature for now, because it currently
711 shows one dialog for each new email, which is annoying.
713 2007-06-11 Murray Cumming <murrayc@murrayc.com>
715 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
716 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
717 when no country was selected, so that we show the global ones.
718 * src/maemo/easysetup/modest-presets.c:
719 (modest_presets_get_providers): Return only the global providers, not
720 all providers when mmc=0 was requested.
722 2007-06-11 Murray Cumming <murrayc@murrayc.com>
724 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
725 (easysetup_provider_combo_box_fill): Remove debug code that showed the
726 provider ID in the combo.
728 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
729 Do not show the page numbers, because it would be confusing when we add
730 the 2 extra pages for the custom setup, when the user chooses the "Other"
731 provider. This fixes projects.maemo.org bug NB#59028
733 * src/modest-init.c: (modest_init_init_core),
734 (modest_init_local_folders):
736 * src/modest-tny-account.c:
737 (modest_tny_account_new_for_local_folders): Do not create default folders
738 for the memory card. This should fix projects.maemo.org bug NB#59328.
740 2007-06-11 Murray Cumming <murrayc@murrayc.com>
742 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
743 Free the changed_conf_keys string items. They are already freed in the
744 idle handler if that runs first.
746 2007-06-11 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-ui-actions.c:
749 (modest_ui_actions_on_password_requested): Check that the server name
750 is not NULL, because I just saw a password dialog with (null) as the
753 * src/modest-tny-folder.[h|c]: Added
754 modest_tny_folder_is_memory_card_folder().
755 * src/modest-ui-dimming-rules.c:
756 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
757 menu item for memory cards, as per the UI spec (section 7.4). This should
758 fix projects.maemo.org bug NB#59297.
760 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
762 * src/maemo/modest-main-window.c: (sync_accounts_cb):
763 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
764 is another problem with the code, see Murray's comment at line 772)
766 2007-06-08 Murray Cumming <murrayc@murrayc.com>
768 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
769 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
770 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
771 (load_from_file), (easysetup_country_combo_box_init),
772 (easysetup_country_combo_box_get_active_country_ids),
773 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
774 instead of just one ID, to avoid duplicate country names in the UI.
776 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
777 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
778 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
779 a single ID, avoiding duplicate providers.
780 * src/maemo/easysetup/modest-easysetup-wizard.c:
781 (on_combo_account_country): Adapt to use a list.
783 2007-06-08 Murray Cumming <murrayc@murrayc.com>
785 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
786 keys changed in the last X seconds.
788 * src/modest-account-mgr.h:
789 * src/modest-account-mgr.c: (on_timeout_notify_changes),
790 (on_key_change), (modest_account_mgr_class_init),
791 (modest_account_mgr_init), (modest_account_mgr_finalize):
792 As the keys are changed, save them in a GSList* and signal that GSList*
793 further every X seconds, to batch changes, to allow us to do just one
794 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
795 bug NB#56941 and other (UI-blocking) delays when changing account settings.
797 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
798 changed signal signature.
800 * src/modest-conf.c: (modest_conf_set_list),
801 (modest_conf_on_change): Reenable notification.
803 (modest_conf_maemo_fake_on_change): Comment out the hack that
804 notified immediately instead of asynchronously.
806 * src/widgets/modest-account-view.h:
807 * src/widgets/modest-account-view.c:
808 (update_account_view): Select the previously-selected account ID,
809 if possible. This fixes projects.maemo.org bug NB#56933.
811 (on_account_changed), (on_account_removed),
812 (modest_account_view_select_account):
814 Remove the block/unblock functions
815 because they were not useful.
817 * src/maemo/modest-account-view-window.c:
818 (on_delete_button_clicked), (on_edit_button_clicked),
819 (on_new_button_clicked): Remove the use of the non-working block/unblock.
821 2007-06-08 Murray Cumming <murrayc@murrayc.com>
823 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
824 Improve the error dialog to show Incorrect Account Settings, which seems
825 clearer, and say that the internal error message (to be removed from the
826 dialog later) is often misleading.
827 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
829 * src/modest-tny-account.c:
830 (modest_tny_account_new_from_server_account): Uncomment the printf of the
831 URL because this is so useful for debugging on the device.
833 * src/widgets/modest-serversecurity-combo-box.c:
834 (modest_serversecurity_combo_box_fill): Correct a logical ID.
836 2007-06-08 Murray Cumming <murrayc@murrayc.com>
838 * src/modest-mail-operation.c:
839 (modest_mail_operation_send_new_mail):
840 Added a comment about a nasty but apparently harmless message. Details
841 added to the wiki g_warnings() page.
843 2007-06-08 Murray Cumming <murrayc@murrayc.com>
845 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
846 (modest_tny_send_queue_class_init):
847 Do not use the priv struct because it is empty, to avoid g_warnings
848 about a non-existant priv struct.
850 * src/modest-tny-account-store.c:
851 (modest_tny_account_store_get_server_account),
852 (modest_tny_account_store_get_transport_account_for_open_connection
853 ): Do not try to get transport server accounts for local folders,
854 because they don't have any. This avoids a g_warning().
856 * src/maemo/modest-main-window.c:
857 (modest_main_window_notify_send_receive_initied),
858 (on_configuration_key_changed):
859 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
861 * src/modest-mail-operation.c:
862 (modest_mail_operation_update_account):
863 * src/modest-tny-account-store.h:
864 * src/modest-tny-account.c:
865 (modest_tny_account_get_special_folder),
866 (modest_tny_account_new_for_local_folders),
867 (modest_tny_account_new_for_per_account_local_outbox_folder):
868 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
869 * src/modest-tny-local-folders-account.c:
870 (add_account_folders_to_merged_folder):
871 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
872 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
873 (modest_ui_actions_on_send):
874 * src/widgets/modest-folder-view.c: (update_model):
875 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
876 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
877 modest_tny_account_store_get_tny_account_by_account() to
878 modest_tny_account_store_get_server_account() to make the code clearer.
880 2007-06-07 Marcus Bauer <marcusb@openismus.com>
882 * src/dbus_api/modest-dbus-api.h:
883 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
884 * src/maemo/modest-msg-edit-window.c:
885 (modest_msg_edit_window_attach_file_noninteractive):
886 added g_warning in case the file to be attached does not exist
887 * tests/dbus_api/test_compose_mail.c: (main):
888 removed obsolete comment, added generic files as test case
890 2007-06-07 Murray Cumming <murrayc@murrayc.com>
892 * src/modest-tny-account-store.c: (get_server_accounts):
893 Create the local folders account only once, not once for each outbox, and
894 not only when there are some outboxes.
896 2007-06-07 Murray Cumming <murrayc@murrayc.com>
898 * src/widgets/modest-folder-view.c: (update_model): Comment out some
899 code that is causing a crash at startup. Sergio says that he is fixing this.
901 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
903 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
904 * src/maemo/modest-account-settings-dialog.c:
905 (create_page_outgoing),
906 (modest_account_settings_dialog_set_account_name),
907 (save_configuration):
908 - Fixed handling of the "Use secure authentication" toggle to comply with
909 the ui specification. See also projects.maemo.org bug NB#58400
911 - Restore the Secure connection setting combo correctly when loading
914 * src/maemo/modest-maemo-utils.c:
915 (on_camel_account_get_supported_secure_authentication),
916 (modest_maemo_utils_get_supported_secure_authentication_methods):
917 Fixed a crasher if operation is canceled
919 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
920 (modest_protocol_info_auth_is_secure):
921 * src/modest-protocol-info.h:
923 Added two new methods to determine if a protocol/auth method is secure/encrypted in
924 the sense of the "Use secure authentication" toggle.
926 2007-06-07 Murray Cumming <murrayc@murrayc.com>
928 * src/modest-tny-account-store.h:
929 * src/modest-tny-account-store.c:
930 Added modest_tny_account_store_get_local_folders_account().
932 * src/modest-tny-folder.h:
933 * src/modest-tny-folder.c:
934 (modest_tny_folder_get_account):
935 Added this replacement for tny_folder_get_account() which returns
936 the local-folders account for TnyMergeFolders, to avoid the
937 warning about the unimplemented get_account_func() vfunc().
939 (modest_tny_folder_get_rules),
940 * src/modest-ui-actions.c:
941 (modest_ui_actions_on_folder_selection_changed):
942 * src/modest-mail-operation.c:
943 (modest_mail_operation_remove_folder),
944 (modest_mail_operation_xfer_folder),
945 (modest_mail_operation_rename_folder),
946 (modest_mail_operation_get_msg),
947 (modest_mail_operation_get_msgs_full),
948 (modest_mail_operation_remove_msg),
949 (modest_mail_operation_xfer_msgs),
950 (modest_mail_operation_refresh_folder):
951 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
953 2007-06-07 Murray Cumming <murrayc@murrayc.com>
955 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
956 (modest_server_account_set_security):
957 * src/modest-defs.h: Add comments explaining that our
958 UI spec means TLS when it says Normal, so these do not look like errors.
960 * src/modest-tny-account.c:
961 (modest_tny_account_new_from_server_account): Use the new tinymail
962 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
963 for TLS. This should fix projects.maemo.org bug NB#58460.
965 2007-06-06 Murray Cumming <murrayc@murrayc.com>
967 * src/maemo/easysetup/modest-easysetup-wizard.c:
968 (create_account): Correct the position of the gconf sanity check warning.
969 (on_button_edit_advanced_settings): Show the dialog immediately, instead
970 of using the g_idle_add() hack, because this does not seem to be necessary
971 on osso 1.1. It might even work on Maemo Bora if the problems were actually
972 caused by something other than maemo's gconf.
973 This fixes projects.maemo.org bug #59022.
975 2007-06-06 Murray Cumming <murrayc@murrayc.com>
977 * src/modest-account-mgr-helpers.c:
978 (modest_account_mgr_get_default_account): Do not check that the account
979 exists if there is no default account (NULL), to fix a runtime warning.
981 2007-06-06 Murray Cumming <murrayc@murrayc.com>
983 * src/widgets/modest-folder-view.c: (update_model):
984 Do not unref the treemodel before we have finished with it.
985 This prevents a valgrind warning and an occasional crash at startup.
987 2007-06-06 Marcus Bauer <marcusb@openismus.com>
989 * libmodest-dbus-client/libmodest-dbus-client.h:
990 added libmodest_dbus_client_compose_mail()
991 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
993 added functions needed for SendAsMail() functionality
994 * src/maemo/modest-msg-edit-window.c:
995 (modest_msg_edit_window_attach_file_noninteractive):
996 non interactively attaching files to message edit window
997 * src/widgets/modest-msg-edit-window.h:
998 * tests/dbus_api/Makefile.am:
999 added test_compose_mail.c
1000 * tests/dbus_api/test_compose_mail.c: (main):
1002 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1004 * src/modest-account-view.c:
1005 Fixed bug projects.maemo.org bug NB#59307
1007 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1009 * src/maemo/easysetup/modest-easysetup-wizard.c:
1010 (get_serverport_incoming), (on_before_next), (create_account):
1011 * src/maemo/modest-account-settings-dialog.c:
1012 (modest_account_settings_dialog_set_account_name):
1013 * src/maemo/modest-maemo-utils.c:
1014 (on_camel_account_get_supported_secure_authentication_status),
1015 (on_camel_account_get_supported_secure_authentication),
1016 (on_secure_auth_cancel),
1017 (modest_maemo_utils_get_supported_secure_authentication_methods):
1019 Implemented security authentication for settings and easysetup.
1021 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1023 * src/maemo/modest-main-window.c: (create_details_widget):
1024 Show the total size for memory card accounts too, instead of showing
1025 the name again. Fixes bug projects.maemo.org bug NB#59307.
1027 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1030 * src/modest-tny-simple-folder-store.c:
1031 * src/modest-tny-simple-folder-store.h: Removed.
1033 * src/modest-tny-local-folders-account.h
1034 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1035 for the local-folders maildir, with an extra TnyMergedFolder containing
1036 the folders of the per-account outbox store accounts.
1037 * src/modest-tny-account-store.c: (get_server_accounts):
1038 Add the outboxes to the special local folders account after creating it.
1040 * src/modest-tny-account.c:
1041 (modest_tny_account_new_for_local_folders): Create the derived
1042 account when creating the main local-folders account.
1044 * src/maemo/modest-main-window.c: (create_details_widget),
1045 (modest_main_window_set_contents_style):
1046 Adapted to the use of the derived account instead of the folder store.
1048 * src/modest-ui-actions.c:
1049 (modest_ui_actions_on_folder_selection_changed):
1050 * src/modest-ui-dimming-rules.c:
1051 (modest_ui_dimming_rules_on_new_folder):
1052 * src/widgets/modest-folder-view.c: (text_cell_data),
1053 (icon_cell_data), (filter_row), (update_model),
1054 (get_cmp_rows_type_pos):
1057 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1058 Do not get the priv struct, because no priv struct has been set,
1059 to avoid a runtime warning.
1061 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1062 #ifelse with #else, to fix a warning, to fix the build.
1065 2007-06-05 Christian Kellner <ckellner@openismus.com>
1067 * libmodest-dbus-client/libmodest-dbus-client.c:
1068 Fix small typo in doc (why do you always see them
1069 AFTER committing stuff?)
1072 2007-06-05 Christian Kellner <ckellner@openismus.com>
1074 * libmodest-dbus-client/libmodest-dbus-client.c:
1075 (libmodest_dbus_client_search):
1076 Initialize hit list with NULL. Also set folder list
1077 to "" if NULL was supplied.
1080 2007-06-03 Christian Kellner <ckellner@openismus.com>
1082 * libmodest-dbus-client/libmodest-dbus-client.c:
1083 (modest_search_hit_list_free):
1084 Make it save to call it with NULL.
1086 * src/dbus_api/modest-dbus-callbacks.c:
1087 * src/modest-search.c:
1088 Return full ModestSearchHits as the search result list not TnyHeader
1089 since can't be around withouth the correspoding TnyFolder.
1091 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1093 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1094 Added currently commented code to check for secure auth
1096 * src/maemo/modest-account-settings-dialog.c: (on_response),
1097 (save_configuration), (show_ok):
1098 Fixed projects.maemo.org bugs NB #59248 and #59251
1100 * src/maemo/modest-maemo-utils.c:
1101 (on_camel_account_get_supported_secure_authentication_status),
1102 (on_camel_account_get_supported_secure_authentication),
1103 (modest_maemo_utils_get_supported_secure_authentication_methods):
1104 * src/maemo/modest-maemo-utils.h:
1105 Moved get_supported_secure_authentication() method here to be able
1106 to use it from easysetup wizard.
1108 * src/modest-pair.c: (on_pair_compare_as_string):
1109 Should compare string with first part of pair and not
1110 strcmp pairs which will crash.
1112 * src/modest-protocol-info.c:
1113 (modest_protocol_info_protocol_is_store):
1114 * src/modest-protocol-info.h:
1115 Added modest_protocol_info_get_auth_protocol_name()
1117 2007-06-03 Armin Burgmeier <armin@openismus.com>
1119 * src/modest-mail-operation.c:
1120 (modest_mail_operation_get_msgs_full): Set priv->account also when
1121 only retrieving a single message. This avoids a crash when canceling
1124 (modest_mail_operation_notify_end): Do not explicitely remove the
1125 operation from the queue but only emit the progress_changed signal.
1126 The queue itself listens to that signal to remove the operation when
1127 it is finished. This reduces coupling and removes a potential deadlock
1128 when modest_mail_operation_notify_end() is called from the queue
1129 itself. If that is a problem performance-wise, I would suggest to
1130 implement a status-changed signal or something.
1132 * src/modest-mail-operation-queue.c: Make sure to never call a
1133 function from another file while the queue is locked. This (hopefully)
1134 fixes another deadlock when exiting the application while retrieving
1137 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1139 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1140 Fixed build if libogs is not available
1142 2007-06-03 Christian Kellner <ckellner@openismus.com>
1144 * libmodest-dbus-client/libmodest-dbus-client.h:
1145 * libmodest-dbus-client/libmodest-dbus-client.c:
1146 (libmodest_dbus_client_delete_message):
1147 Implement deletion of messages (Client side).
1149 (modest_search_hit_free),
1150 (modest_search_hit_list_free):
1151 Utility functions to free the result hits.
1153 * src/dbus_api/modest-dbus-api.h:
1154 * src/dbus_api/modest-dbus-callbacks.c:
1155 (on_delete_message),
1156 (modest_dbus_req_handler):
1157 Implement deletion of messages (Server side).
1159 * tests/dbus_api/test_search.c: (main):
1162 * tests/dbus_api/Makefile.am:
1163 * tests/dbus_api/test_delete_message:
1164 Add little test for the message deletion logic
1166 2007-06-03 Armin Burgmeier <armin@openismus.com>
1168 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1169 when the operation queue was not empty. projects.maemo.org bug
1172 2007-06-03 Armin Burgmeier <armin@openismus.com>
1174 * src/widgets/modest-account-view.c
1175 (on_account_default_toggled): Toggle default account column
1176 explicitely instead of waiting for gconf notification (which is
1177 currently ignored). This should fix projects.maemo.org bug NB#56910
1178 for now. It should probably be removed when gconf notifications are
1181 2007-06-03 Christian Kellner <ckellner@openismus.com>
1183 * libmodest-dbus-client/libmodest-dbus-client.c:
1184 Removed debugging spew.
1186 * src/dbus_api/modest-dbus-callbacks.c:
1187 Added debugging info.
1189 * src/modest-search.c:
1190 (modest_search_all_accounts):
1191 Use tny_account_store_get_accounts () on the account store
1192 to get all accounts which is the way to get all accounts.
1194 * tests/dbus_api/test_search.c: (main):
1195 Make it possible to supply the search term on the command line.
1197 2007-06-03 Christian Kellner <ckellner@openismus.com>
1199 * libmodest-dbus-client/libmodest-dbus-client.c:
1200 * libmodest-dbus-client/libmodest-dbus-client.h:
1201 Implement searching for mesages over raw dbus. (Client side)
1203 * src/dbus_api/Makefile.am:
1204 * src/dbus_api/modest-dbus-api.h:
1205 * src/dbus_api/modest-dbus-callbacks.c:
1206 * src/dbus_api/modest-dbus-callbacks.h:
1207 Search framework (Server side). Also implement on_idle_open_message().
1209 * src/maemo/modest-platform.c: (modest_platform_init):
1210 Prepare for raw dbus/osso rpc interaction.
1212 * src/modest-search.h:
1213 Changed minsize from unspecific guint to guint32.
1215 * src/modest-search.c:
1217 Added strange hack which magically made tnymail work.
1219 (modest_search_folder),
1220 (modest_search_account),
1221 (modest_search_all_accounts):
1222 Implement helper functions to search all accounts, specific account
1225 * tests/dbus_api/Makefile.am:
1226 * tests/dbus_api/test_open_message.c:
1227 Read url to open from commandline.
1229 * tests/dbus_api/test_search.c:
1230 Implement small test for dbus search stuff
1232 2007-06-02 Armin Burgmeier <armin@openismus.com>
1234 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1235 include account type and account title. This fixes projects.maemo.org
1238 * src/maemo/modest-account-view-window.c: Set a title for the window.
1240 2007-06-02 Armin Burgmeier <armin@openismus.com>
1242 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1243 incoming and outgoing server name based on email address and server
1244 types as long as the names have not been edited manually. This fixes
1245 projects.maemo.org bug NB#58671.
1247 2007-06-02 Armin Burgmeier <armin@openismus.com>
1249 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1250 server type cannot be changed in future to the incoming details page
1251 when creating an account. This fixes projects.maemo.org bug NB#59029.
1253 2007-06-02 Armin Burgmeier <armin@openismus.com>
1255 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1256 and assigned max width chars so that they wrap instead of being
1257 truncated. Fixes projects.maemo.org bug NB#56126.
1259 2007-06-02 Armin Burgmeier <armin@openismus.com>
1261 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1262 introductory note to the connection specific smtp servers dialog, as
1263 section 8.12 of the email UI specification requires. This fixes
1264 projects.maemo.org bug NB#59212.
1266 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1268 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1269 Check for running mail operations, and offer to cancel them, as per the UI
1270 spec. This fixes projects.maemo.org bug NB#59041 .
1271 However, I suspect that tinymail may still use the network connection
1272 in ways that we cannot detect or cancel. But it should at least adapt to
1273 changes fairly well.
1275 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1277 * src/modest-tny-account-store.c: (recreate_all_accounts),
1278 (get_cached_accounts), (get_server_accounts): Do more sensible
1279 ref-counting of the temporarily-cached outbox accounts list. This seems
1280 to fix a crash when entering the password when the password was wrong.
1282 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1284 * src/gnome/modest-main-window.c: (connect_signals):
1285 * src/modest-tny-account-store.c: (get_password),
1286 (modest_tny_account_store_alert): Added comments and clues and
1287 commented-out code about how we currently fail to deal with connection
1288 errors and wrong passwords, and how we should.
1290 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1292 * src/widgets/modest-retrieve-combo-box.c:
1293 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1294 This fixes projects.maemo.org bug NB#58472 .
1296 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1298 * src/maemo/easysetup/modest-easysetup-wizard.c:
1299 (create_page_complete_easysetup):
1300 (create_page_complete_custom): Correct the last commit,
1301 putting the correct sentences in the correct pages.
1303 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1305 * src/maemo/easysetup/modest-easysetup-wizard.c:
1306 (create_page_complete_custom): Show the second sentence of text
1307 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1310 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1312 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1313 Set the leave-on-server conf key by default. This fixes
1314 projects.maemo.org bug NB#59258 .
1316 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1318 * src/maemo/modest-account-view-window.c:
1319 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1320 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1323 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1325 * src/maemo/easysetup/modest-easysetup-wizard.c:
1326 (create_caption_new_with_asterisk):
1327 * src/maemo/modest-account-settings-dialog.c:
1328 (create_caption_new_with_asterisk):
1329 Uncomment the code to add the asterisk, because they are no longer in the
1330 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1331 (update_incoming_server_title): Add an asterisk here too.
1333 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1335 * src/maemo/modest-maemo-global-settings-dialog.c:
1336 (current_connection): Check that we are even connected before trying to
1337 get the current connection name, to prevent a warning.
1339 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1340 Change the comments because tny_maemo_conic_device_connect() is now meant to
1342 * src/modest-mail-operation.c:
1343 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1344 make sure we have a connection and fail if we can't connect.
1346 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1348 * src/maemo/modest-main-window.c:
1349 (on_account_store_connecting_finished): Do not try to get the
1350 connection ID if we are not really connected. I am surprised that
1351 this signal handler is called when we are not connected.
1353 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1355 * src/modest-error.h:
1356 * src/modest-ui-actions.c:
1357 (modest_ui_actions_get_msgs_full_error_handler):
1358 Renamed an enum, added comments, added an enum
1359 for retrieve-limit errors.
1361 * src/modest-mail-operation.c: (foreach_add_item),
1362 (internal_folder_observer_update), (update_account_thread),
1363 (modest_mail_operation_get_msgs_full):
1364 (modest_mail_operation_update_account),
1365 Added comments about how this works, and some code that should
1366 (but does not) check the retrieve-limit. See the TODO comment.
1368 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1370 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1371 Initialize help_id to fix the build. Warnings are good.
1373 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1375 * src/widgets/modest-hbox-cell-renderer.c:
1376 (modest_hbox_cell_renderer_append):
1377 * src/widgets/modest-vbox-cell-renderer.c:
1378 (modest_vbox_cell_renderer_append):
1379 Fix the last commit by doing an extra ref.
1381 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1383 * src/widgets/modest-hbox-cell-renderer.c:
1384 (modest_hbox_cell_renderer_append):
1385 * src/widgets/modest-vbox-cell-renderer.c:
1386 (modest_vbox_cell_renderer_append):
1387 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1388 to fix the build with Maemo Bora.
1389 However, there seems to be a remaining crash, probably due to reference
1392 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1394 * src/modest-tny-account.c:
1395 (modest_tny_account_new_for_local_folders):
1396 Use hildon_file_system_info_async_new() to get a better name for
1397 the memory card account, setting it as the account name.
1398 The timing seems to work, but this is probably
1399 not the best place to do this. See the TODO comment.
1400 * src/maemo/modest-main-window.c: (create_details_widget):
1401 * src/widgets/modest-folder-view.c: (text_cell_data):
1402 Use the tny account name instead of hardcoding a name.
1404 2007-05-30 Christian Kellner <ckellner@openismus.com>
1406 * src/modest-search.c: (modest_search):
1407 Correctly set part_search_func even if we have already parsed
1408 the query and thus a valid OgsTextSearcher object.
1410 2007-05-30 Christian Kellner <ckellner@openismus.com>
1413 Search and check for libogs.
1416 Incooparte the ogs build env.
1418 * src/modest-mime-part-search-stream.c:
1419 * src/modest-mime-part-search-stream.h:
1420 Removed since we do the real searching now in modest-search.c.
1422 * src/modest-search.c:
1423 * src/modest-search.h:
1424 Implement support for ogs. We use that if available and requested
1425 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1426 should now handle the corner case when the search term is spread
1427 across multiple reads.
1428 Also the logic in modest_search () was corrected to search all
1429 requested fields until one is found.
1431 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1433 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1435 * src/modest-init.h:
1436 * src/modest-init.c: Made modest_init_local_folders() take a
1437 path and be public so we can iniitialize maildir folders on
1440 * src/modest-local-folder-info.h:
1441 * src/modest-local-folder-info.c:
1442 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1444 * src/modest-tny-account.c:
1445 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1446 still means the standard local-folders path on the local volume.
1448 * src/modest-tny-account-store.c:
1449 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1450 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1451 all accounts when that happens.
1452 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1453 this too, so it shows up in the treeview.
1455 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1457 * src/maemo/modest-maemo-global-settings-dialog.c:
1458 (current_connection):
1459 * src/widgets/modest-global-settings-dialog.c:
1460 (current_connection_default):
1461 Use the enum values instead of 0, 1 and -1,
1462 to make the code clearer.
1464 * src/modest-account-mgr-helpers.c:
1465 (modest_account_mgr_get_connection_specific_smtp): Make this code
1468 * src/modest-runtime.h:
1469 * src/modest-runtime.c:
1470 Added modest_runtime_remove_all_send_queues().
1471 * src/maemo/modest-main-window.c:
1472 (on_account_store_connecting_finished): Recreate the send queues,
1473 using the appropriate transport accounts for this new connection.
1474 Some futher adapting might be needed if the old send queues are not
1475 automatically stopped at this point.
1477 * src/modest-tny-account-store.c: (get_server_accounts):
1478 Create the connection-specific transport accounts, so that they can
1479 be found later by their ID.
1481 * src/modest-tny-account.h:
1482 * src/modest-tny-account.c:
1483 Added modest_tny_account_new_from_server_account_name().
1484 modest_tny_account_new_from_server_account(): Do not create the
1485 send queues here, because they will be
1486 recreated anyway when the connection changes for the first time.
1488 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1490 * src/modest-local-folder-info.h:
1491 * src/modest-local-folder-info.c:
1492 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1493 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1494 tbox_folder): Take a modest account name instead of a server TnyAccount,
1495 so we can have per-modest-account rather than per-transport-account
1497 We must make sure that we change or recreate the exisitng send queues
1498 when the connection changes for connection-specific transport accounts.
1500 * src/modest-tny-account-store.c:
1501 (create_per_account_local_outbox_folders): Create outboxed per modest
1502 account, not per transport account.
1504 * src/modest-tny-account.h:
1505 * src/modest-tny-account.c:
1506 (modest_tny_account_get_special_folder): For outboxes, get the
1507 parent modest account name. The account is ignored for other folders.
1508 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1509 modest account name rather than a server TnyAccount.
1511 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1513 * src/modest-tny-account.c:
1514 (modest_tny_account_new_from_server_account):
1515 Call modest_runtime_get_send_queue() immediately after creating transport
1516 accounts, so that they start trying to send email from the outbox as soon
1517 as possible at startup. This is probably what we want.
1519 * src/modest-mail-operation.c: (update_account_thread):
1520 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1521 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1522 * src/modest-tny-send-queue.h:
1523 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1524 (modest_ui_actions_on_send):
1525 Added comments about how sending works, though it needs some more work.
1527 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1529 * src/modest-tny-account.c:
1530 (modest_tny_account_get_special_folder): Add TODO because this fails when
1531 the network is busy.
1532 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1533 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1534 Do not try to show this window when there is no active account. The UI
1535 specs does not tell us what to do in this case.
1537 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1541 * src/maemo/Makefile.am:
1542 * src/widgets/Makefile.am: Some dist fixes.
1544 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1546 * src/maemo/modest-connection-specific-smtp-window.c:
1547 (on_button_edit): Make the code clearer, to prevent a double free.
1549 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1551 * src/maemo/modest-account-settings-dialog.c:
1552 (modest_account_settings_dialog_set_account_name),
1553 Check the connection-specific smtp servers checkbox if there are any.
1555 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1556 (modest_connection_specific_smtp_edit_window_init):
1557 Start with a suitable port number.
1559 * src/modest-account-mgr-helpers.h:
1560 * src/modest-account-mgr-helpers.c: Added
1561 modest_account_mgr_get_has_connection_specific_smtp().
1563 (modest_account_mgr_set_connection_specific_smtp),
1564 (modest_account_mgr_remove_connection_specific_smtp),
1565 (modest_account_mgr_get_has_connection_specific_smtp),
1566 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1567 connection-specific smtp server accounts in the account, rather than
1568 the server account conf dir.
1570 This fixes bug projects.maemo.org bug NB#58263 .
1572 * src/modest-tny-account-store.c:
1573 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1574 if there are no server accounts yet, to prevent an infinite loop when there
1575 are no accounts. Document that one must be called before the other.
1577 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1579 * src/modest-account-mgr-helpers.c:
1580 (modest_account_mgr_get_default_account): Make sure that at least
1581 one account is always the default, if there are any enabled accounts.
1582 This is just a sanity check that shouldn't be necessary.
1584 * src/modest-account-mgr-priv.c:
1585 (_modest_account_mgr_account_from_key): Unescape the conf key to
1586 get the real account name. For instance, this is an issue if a space
1587 was in the account name, which can happen because the account name
1588 is generated from the display name.
1589 (_modest_account_mgr_get_account_keyname): Always escape the
1591 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1592 Unescape the conf keys to get the real account names.
1594 For instance, previously the is-default radio button in the accounts
1595 list was not checked for any accounts at first. This fixes that,
1596 and might fix several similar bugs.
1598 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1600 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1601 Removed some debug printfs.
1603 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1605 Modest on-disk outbox directories are now here, for instance:
1606 $HOME/.modest/outboxes/<account-id-1>/outbox
1607 $HOME/.modest/outboxes/<account-id-2>/outbox
1609 $HOME/.modest/local-folders/outbox
1610 so we can have a separate outbox for each account.
1611 But they are shown as one outbox in the GtkTreeView, by using a
1612 TnyMergeFolder in a ModestTnySimpleFolderStore.
1615 * src/modest-tny-simple-folder-store.c:
1616 * src/modest-tny-simple-folder-store.h:
1617 Added ModestTnySimpleFolderStore, used to contain folders from
1618 other folder stores, such as other accounts.
1620 * src/modest-tny-outbox-account.h:
1621 * src/modest-tny-outbox-account.c:
1622 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1623 used for the per-account local outbox folders.
1625 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1626 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1627 only use this (internally) now for the non-outbox local folders.
1629 * src/modest-init.h:
1630 * src/modest-init.c: Added modest_init_one_local_folder(), for
1631 setting up the directory structure for each local folder.
1633 * src/modest-local-folder-info.c:
1634 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1635 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1637 * src/modest-local-folder-info.h:
1638 * src/modest-tny-account-store.c: (on_account_removed),
1639 (on_account_changed), (create_per_account_local_outbox_folders),
1640 (get_server_accounts), (modest_tny_account_store_get_accounts),
1641 (modest_tny_account_store_get_tny_account_by_account),
1642 (modest_tny_folder_store_is_virtual_local_folders):
1644 * src/modest-tny-account.h:
1645 * src/modest-tny-account.c:
1646 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1647 to create an on-disk per-account local outbox folder for each
1649 (create_per_account_local_outbox_folders): Create a local outbox folder
1650 for each transport account.
1651 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1652 for all local folders.
1654 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1655 instead of using g_object_get/set() directly. It is clearer.
1657 (modest_tny_folder_store_get_message_count),
1658 (modest_tny_folder_store_get_local_size
1659 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1660 because we now use these with non-acount folder stores.
1662 (modest_tny_account_get_special_folder),
1663 (modest_tny_account_new_from_server_account),
1664 (modest_tny_account_new_from_account):
1665 (recurse_folders): Adjust to the new outbox system.
1667 * src/modest-tny-folder.h:
1668 * src/modest-tny-folder.c:
1669 (modest_tny_folder_is_local_folder),
1670 (modest_tny_folder_get_local_folder_type),
1671 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1673 * src/widgets/modest-main-window.h:
1674 * src/maemo/modest-main-window.c: (create_details_widget),
1675 (modest_main_window_set_contents_style): Show details for any folder store,
1678 (modest_tny_folder_get_rules):
1679 Remove the const. C does not support constness enough for this.
1681 * src/modest-ui-actions.c:
1682 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1683 make all outboxes appear as one, in the usual local-folders tree node.
1685 (set_active_account_from_tny_account),
1686 (modest_ui_actions_on_folder_selection_changed):
1687 * src/widgets/modest-folder-view.c: (text_cell_data),
1688 (icon_cell_data), (filter_row),
1689 (add_account_folders_to_merged_folder),
1690 (add_account_folders_to_simple_folder_store), (),
1691 (get_cmp_rows_type_pos), (cmp_rows),
1692 (modest_folder_view_set_account_id_of_visible_server_account):
1693 Adjust to the new outbox system, using generic folder stores and folders
1694 in the GtkTreeModel.
1696 2007-05-23 Christian Kellner <ckellner@openismus.com>
1698 * src/modest-mail-operation.c:
1699 (modest_mail_operation_update_account):
1700 Use info->max_size instead of unintialized local var [small
1701 build fix]. (Added TODO to review that change since I don't
1704 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1706 * libmodest-dbus-client/libmodest-dbus-client.c:
1707 (libmodest_dbus_client_compose_mail): function added
1708 * src/dbus_api/modest-dbus-api.h:
1709 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1710 (on_compose_mail): Implementation of the SendAsMail functionality
1712 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1714 * src/modest-account-mgr.c:
1715 (modest_account_mgr_add_server_account): Set the secure-connection
1716 conf key for transport accounts as well as store accounts. I don't know
1717 why the if was there. For instance, this makes sure that we use SSL
1718 for the gmail preset from the easysetup wizard.
1720 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1722 * src/gnome/modest-main-window.c:
1723 (on_account_store_connecting_finished), (connect_signals):
1724 * src/maemo/modest-main-window.c:
1725 (on_account_store_connecting_finished), (connect_signals),
1726 (modest_main_window_new):
1727 Handle TnyAccountStore::connecting-finished instead of
1728 TnyDevice::connection-changed, because we cannot actually perform
1729 operations on accounts until TnyAccountStore has itself responded to
1730 the TnyDevice::connection-changed signal. This prevents a GError from
1732 Do not try to update at startup, because we (at least on scratchbox)
1733 already do an update at startup when the device goes online.
1734 This prevents a GError from tinymail.
1735 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1736 Added TODO about stopping simultaneous operations.
1738 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1740 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1741 * src/modest-mail-operation-queue.c:
1742 (modest_mail_operation_queue_remove):
1743 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1744 about where they happened.
1746 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1748 * src/modest-ui-actions.c:
1749 (modest_ui_actions_on_password_requested): Make sure that the remember
1750 output parameter is always TRUE.
1752 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1754 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1755 Show a OK/Cancel dialog if the error is a question, though we still do not
1756 know anything more about what we are asking the user.
1757 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1758 Fix an uninitialized variable (helper). This is a logic error, however.
1760 2007-05-21 Christian Kellner <ckellner@openismus.com>
1762 * src/modest-search.h:
1763 Correct bit shifting in the ModestSearchFlags enum.
1765 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1767 * src/modest-tny-account.c:
1768 (modest_tny_account_new_from_server_account): Do not use the lsub and
1769 check-all hard-coded IMAP options when using POP.
1771 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1773 * src/modest-tny-account.c:
1774 (modest_tny_account_new_from_server_account):
1775 Use NULL for the secure-auth method for POP when Password auth has been
1776 specified by the user, as we already do for IMAP. "auth=Login" causes
1777 an error from camel or the server.
1779 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1781 * src/maemo/modest-account-settings-dialog.c:
1782 (create_page_account_details),
1783 (modest_account_settings_dialog_set_account_name):
1784 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1785 for the leave-on-server checkbox, rathr than just the checkbox, when
1786 the protocol is not POP.
1788 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1790 * src/widgets/modest-account-view.c:
1791 * src/widgets/modest-account-view.h:
1792 Added modest_account_view_select_account() which will be useful later
1793 to asynchronously re-select the edited account.
1795 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1797 * src/maemo/modest-account-settings-dialog.c:
1798 (modest_account_settings_dialog_set_account_name):
1799 Automatically choose the port numbers based on the secure authentication
1800 methods, if they have not been chosen before.
1801 This fixes projects.maemo.org bug NB#56273 .
1803 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1805 * src/maemo/modest-main-window-ui.h:
1806 * src/modest-ui-actions.c:
1807 * src/modest-ui-actions.h:
1808 Connect the Tools/SMTP Servers menu item to
1809 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1810 SMTP servers dialog, as in the UI specification and saves changes when it
1811 is closed. This fixed projects.maemo.org bug NB#56305 .
1813 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1815 * src/maemo/modest-connection-specific-smtp-window.c:
1816 (modest_connection_specific_smtp_window_init):
1817 Use gtk_window_set_default_size() to make this window big enough, so
1818 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1820 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1822 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1823 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1824 (modest_connection_specific_smtp_edit_window_init),
1825 Do not try to connect to a combobox signal before the combobox exists.
1826 This fixes the cras in projects.maemo.org bug NB#56288 .
1827 (modest_connection_specific_smtp_edit_window_get_settings):
1828 Remove the server_account_name parameter which was being checked for NULL
1829 though it was not used.
1831 * src/maemo/modest-connection-specific-smtp-window.c:
1832 (modest_connection_specific_smtp_window_fill_with_connections),
1833 (on_button_edit), (modest_connection_specific_smtp_window_init):
1834 Correct the number of treemodel columns to prevent a warning.
1835 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1836 libconic does not work.
1838 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1840 * src/modest-tny-account.c:
1841 (modest_tny_account_new_from_server_account):
1842 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1843 SMTP when "None" was chosen by the user. However, with my SMTP server that
1844 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1847 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1849 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1850 to explain the memory management issue with the ID in the ModestPair.
1852 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1853 (add_sending_page), (modest_account_assistant_finalize):
1854 * src/gnome/modest-gnome-global-settings-dialog.c:
1855 (create_updating_page), (create_composing_page):
1856 * src/gnome/modest-msg-edit-window.c: (get_transports),
1857 (init_window), (modest_msg_edit_window_finalize),
1858 (modest_msg_edit_window_get_msg_data):
1859 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1860 * src/gnome/modest-transport-widget.c:
1861 (modest_transport_widget_finalize), (smtp_configuration):
1862 * src/maemo/modest-maemo-global-settings-dialog.c:
1863 (create_updating_page), (create_composing_page):
1864 * src/maemo/modest-msg-edit-window.c: (get_transports),
1865 (init_window), (modest_msg_edit_window_finalize),
1866 (modest_msg_edit_window_get_msg_data),
1867 (modest_msg_edit_window_free_msg_data):
1868 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1869 (modest_store_widget_finalize):
1870 * src/maemo/modest-transport-widget.c:
1871 (modest_transport_widget_finalize), (smtp_configuration):
1872 * src/modest-main.c: (send_mail):
1873 * src/widgets/modest-combo-box.h:
1874 * src/widgets/modest-global-settings-dialog-priv.h:
1875 * src/widgets/modest-global-settings-dialog.c:
1876 (modest_global_settings_dialog_finalize):
1877 * src/widgets/modest-msg-edit-window.h:
1878 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1879 as long as the combo box, to prevent use of freed memory for the ID.
1881 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1883 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1884 get_accounts(), to make this clearer. Do not check for the enabled gconf
1885 key, because we do not use this for server accounts (at least, not yet).
1886 This allows us to send email again.
1888 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1890 * src/maemo/modest-platform.c:
1891 (on_modest_conf_update_interval_changed), (modest_platform_init):
1892 Only respond to this particular key change. All these strcmp()s cannot be
1895 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1897 * src/maemo/modest-maemo-global-settings-dialog.c:
1898 (current_connection): Prevent a crash in scratchbox when
1899 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1900 * src/maemo/modest-platform.c:
1901 (on_modest_conf_update_interval_changed), (modest_platform_init):
1902 Get the update interval from gconf and reset it when the gconf key changes.
1904 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1906 * src/modest-protocol-info.c:
1907 * src/modest-protocol-info.h: Adde enum-specific get functions,
1908 instead of using a ModestProtocolType enum parameter.
1910 * src/gnome/modest-account-assistant.c:
1911 * src/gnome/modest-store-widget.c:
1912 * src/gnome/modest-store-widget.h:
1913 * src/gnome/modest-transport-widget.c:
1914 * src/gnome/modest-transport-widget.h:
1915 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1916 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1917 * src/maemo/easysetup/modest-easysetup-wizard.c:
1918 * src/maemo/modest-account-settings-dialog.c:
1919 * src/maemo/modest-account-settings-dialog.h:
1920 * src/maemo/modest-store-widget.c:
1921 * src/maemo/modest-store-widget.h:
1922 * src/maemo/modest-transport-widget.c:
1923 * src/maemo/modest-transport-widget.h:
1924 * src/modest-account-mgr-helpers.c:
1925 * src/modest-account-mgr-helpers.h:
1926 * src/modest-account-mgr.c:
1927 * src/modest-account-mgr.h:
1928 * src/modest-tny-account.c:
1929 * src/modest-tny-folder.c:
1930 * src/widgets/modest-account-view.c:
1931 * src/widgets/modest-retrieve-combo-box.c:
1932 * src/widgets/modest-retrieve-combo-box.h:
1933 * src/widgets/modest-secureauth-combo-box.c:
1934 * src/widgets/modest-serversecurity-combo-box.c:
1935 * src/widgets/modest-serversecurity-combo-box.h:
1936 * tests/check_account-mgr.c:
1937 Use the specific functions, and use the re-renamed enum values for GNOME too.
1939 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1941 * src/modest-pair.h:
1942 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1943 so we can get the second based on the first.
1945 * src/maemo/modest-account-settings-dialog.h:
1946 * src/maemo/modest-account-settings-dialog.c:
1947 Added get_supported_secure_authentication_methods(), though it is mostly
1948 commented-out for now until the necessary API is committed to tinymail.
1949 (modest_account_settings_dialog_set_account_name),
1950 (save_configuration): Request the supported authentication methods from the
1951 server, so we can choose a working method.
1953 * src/modest-tny-account-store.h:
1954 * src/modest-tny-account-store.c:
1955 (modest_tny_account_store_get_session): Rename from
1956 tny_account_store_get_session().
1958 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1960 * src/modest-protocol-info.h: Split the ModestProtocol enum
1961 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1962 There was no need to have these unrelated values in one enum.
1964 * src/: many files: Adapted to changed enum. This makes the code a bit
1965 clearer, and the compiler could catch some errors.
1967 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1969 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1970 Show the detailed internal camel error message when an error happens
1971 during the configuration, so that our testers can give us more clues.
1972 For instance, in projects.maemo.org bug NB#56910 .
1974 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1976 * src/modest-tny-account.c:
1977 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1978 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1980 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1982 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1983 * src/maemo/modest-account-settings-dialog.c:
1984 (modest_account_settings_dialog_set_account_name),
1985 (save_configuration): For the incoming secure authentication checkbox,
1986 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1987 the UI specification. PLAIN does not seem to be supported for most IMAP
1988 servers anyway, and I am not sure what it would mean.
1989 However, we probably need to discover which of the secure-authentication
1990 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1991 * src/modest-account-mgr-helpers.c:
1992 (modest_account_mgr_get_server_account_data):
1994 * src/modest-tny-account.c:
1995 (modest_tny_account_new_from_server_account):
1996 Use tny_account_set_mech() to set secure-authentication methods,
1997 with some special-casing for IMAP, based on my observations of how
2000 * src/modest-account-mgr-helpers.h:
2001 * src/modest-account-mgr.c:
2002 * src/modest-defs.h: Comment that the URI is only used for local folders.
2004 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2006 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2007 parameter const, just to be neat.
2008 * src/modest-text-utils.c: (modest_text_utils_inline):
2009 End g_strconcat() with NULL, as its documentation says. This is almost
2010 certainly the cause of my crash at startup on the device. Interestingly,
2011 valgrind doesn't tell us about these errors.
2013 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2015 * scripts/build-packages: Added more precise comments about how to use
2016 this script, though I still get this error:
2017 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2018 error building tinymail
2020 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/modest-main-window.c: (on_account_update):
2023 Very slight cleanup, hoping to make it simpler to discover what causes
2024 a crash here sometimes.
2026 * src/modest-tny-account.c:
2027 (modest_tny_account_new_from_server_account): Set the port. Added
2028 comments about the options and a TODO comment because I need to find out
2029 how to specify the secure authentication method.
2031 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2033 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2034 changed CFlags paths form modest to libmodest
2036 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2038 * src/modest-account-mgr-helpers.c:
2039 (modest_account_mgr_get_server_account_data),
2040 (modest_account_mgr_free_server_account_data):
2041 * src/modest-account-mgr-helpers.h:
2042 * src/modest-account-mgr.c:
2043 (modest_account_mgr_add_server_account):
2044 * src/modest-defs.h:
2045 * src/modest-tny-account.c:
2046 (modest_tny_account_new_from_server_account):
2047 Determine the options for tny_camel_account_add_option() here,
2048 based on the settings, rather than storing them directly in gconf.
2050 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2052 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2053 Show a more friendly error dialog now that we expect (from the tinymail
2054 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2056 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2058 * src/maemo/modest-main-window.c: (on_account_update): Check that
2059 account_name is not NULL, to prevent a crash at startup that I am
2060 seeing on the N800. I do wonder why it is NULL.
2062 * src/maemo/easysetup/modest-easysetup-wizard.c:
2063 (create_page_user_details):
2064 * src/maemo/modest-account-settings-dialog.c:
2065 (create_page_user_details), (create_page_outgoing):
2066 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2067 (modest_connection_specific_smtp_edit_window_init):
2068 * src/modest-ui-actions.c:
2069 (modest_ui_actions_on_password_requested):
2070 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2071 might do something useful with the on-screen keyboard.
2073 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2075 * src/maemo/modest-main-window.c: (on_account_update):
2076 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2077 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2079 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2081 * src/modest-tny-account-store.c: (on_account_changed):
2082 Correct the signature of this signal handler.
2084 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2086 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2087 Show a HildonNote instead of a GtkDialog for Maemo.
2089 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2091 * src/widgets/modest-account-view.h:
2092 * src/widgets/modest-account-view.c: (on_account_changed),
2093 (on_account_removed). Added a boolean flag, set/unset by
2094 modest_account_view_block_conf_updates(),
2095 modest_account_view_unblock_conf_updates() to prevent unnecessary
2096 updates, but this is not very useful because the gconf notifications are
2097 so delays (maybe only on Maemo Bora).
2098 So auto-updating is turned off, and these functions do an explicit
2099 update when necessary.
2100 However, something else is still doing too much work when adding/removing
2101 accounts, probably in another part of the application.
2103 * src/maemo/modest-account-view-window.c:
2104 (on_delete_button_clicked), (on_edit_button_clicked),
2105 (on_new_button_clicked): Use the new functions.
2107 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2109 * src/modest-account-mgr-helpers.c:
2110 (modest_account_mgr_set_first_account_as_default):
2111 Sort the list of names alphabetically-by-title, so we choose the first one
2113 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2114 alphabetically by the title.
2116 This fixes projects.maemo.org bug NB#56418 .
2118 * src/modest-account-mgr-priv.c:
2119 (_modest_account_mgr_account_from_key):
2120 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2121 avoid a valgrind error, and possible random behaviour.
2123 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2125 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2126 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2127 tinymail documentation to say that this can be expected.
2128 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2129 pretty, and should not happen, but I would prefer to know when it does.
2131 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2133 * configure.ac: When using the older hildon version, probably on Bora,
2134 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2136 * src/widgets/modest-attachment-view.c:
2137 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2140 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2142 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2143 Implemented the prototype. Can be tested with
2144 tests/dbus_api/test_open_message:
2146 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2148 * src/modest-tny-account-store.c:
2149 (modest_tny_account_store_instance_init), (get_password):
2150 * src/modest-ui-actions.c:
2151 (modest_ui_actions_on_password_requested):
2152 Do not store the password in gconf, because this function is called
2153 for non-remembered passwords. Actually use the cached (in the hash map)
2154 password instead of releasing it.
2155 The password will now not be remembered if it is asked via the protected
2156 password dialog, as per the UI spec.
2158 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2160 * src/modest-defs.h:
2161 * src/modest-account-mgr-helpers.h:
2162 * src/modest-account-mgr-helpers.c:
2163 Added modest_server_account_get_username_has_succeeded(),
2164 modest_server_account_set_username_has_succeeded().
2165 (modest_server_account_set_username),
2166 Reset the has-succeeded flag if the username changes.
2168 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2169 * src/maemo/modest-connection-specific-smtp-window.c:
2170 (modest_connection_specific_smtp_window_save_server_accounts):
2171 Use modest_server_account_set_username() instead of using
2172 modest_conf_set_string() directly, so that the has-succeeded flag is always
2175 * src/modest-ui-actions.c:
2176 (modest_ui_actions_on_password_requested): Dim the username entry if
2177 the username has ever worked, as per the UI spec.
2179 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2181 * src/modest-tny-account-store.c: (get_password):
2182 * src/modest-ui-actions.c:
2183 (modest_ui_actions_on_password_requested):
2184 Allow the username to be changed too, though there is more work to
2185 be done on exactly how this behaves.
2187 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2189 * src/modest-account-mgr-helpers.h:
2190 * src/modest-account-mgr-helpers.c:
2191 Added modest_account_mgr_get_display_name(),
2192 modest_server_account_get_username(),
2193 modest_server_account_set_username(),
2194 modest_server_account_set_password(),
2195 modest_server_account_get_hostname() functions so we do not need to
2196 use the conf API directly.
2198 * src/maemo/modest-main-window.c: (connect_signals):
2199 Actually connect ot the ModestAccountStore::request-password signal,
2200 so that we show the dialog when the password is requested by Tinymail,
2201 for isntance if it is empty.
2203 * src/modest-marshal.list:
2204 * src/modest-tny-account-store.c:
2205 (modest_tny_account_store_class_init), (get_password),
2206 (modest_tny_account_store_alert):
2207 * src/modest-tny-account-store.h:
2208 * src/modest-ui-actions.h:
2209 * src/modest-ui-actions.c:
2210 (modest_ui_actions_on_password_requested):
2211 Change the signal parameters, so it is obvious that we are providing
2212 the non human-readable server name, and receiving both the username
2213 and password, though changing of the username is not yet implemented.
2214 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2215 for the GNOME version.
2217 This should fix the projects.maemo.org bug NB#56209, though it does not
2218 work on Bora, because the gconf_client_get() for the password fails
2219 immediately after we save it with gconf_client_set().
2221 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2224 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2225 caused an undefined symbol error:
2226 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2228 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2230 * src/modest-tny-account-store.c:
2231 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2232 using a GError instead of a string message, so we can translate it in
2235 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2237 * src/maemo/modest-address-book.c:
2238 (modest_address_book_check_names):
2239 * src/maemo/modest-msg-view-window.c:
2240 (modest_msg_view_window_clipboard_owner_change):
2241 * src/modest-init.c: (modest_init_init_ui):
2242 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2243 (update_folders_cb), (modest_mail_operation_update_account):
2244 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2245 (modest_ui_actions_on_msg_attachment_clicked),
2246 (modest_ui_actions_on_msg_recpt_activated):
2247 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2248 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2249 (modest_msg_view_search_next):
2250 * src/widgets/modest-recpt-editor.c:
2251 (modest_recpt_editor_on_button_release_event),
2252 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2253 g_message(). At this point we should only be seeing interesting errors on
2254 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2256 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2258 (modest_wizard_dialog_force_title_update):
2259 * src/maemo/easysetup/modest-wizard-dialog.h:
2260 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2261 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2262 can update the title when appropriate. Otherwise the title is wrong if the
2263 pages are added after adding the notebook to the dialog.
2264 This must be a problem in HildonWizardDialog too.
2265 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2267 * src/maemo/easysetup/modest-easysetup-wizard.c:
2268 (create_subsequent_customsetup_pages),
2269 (create_subsequent_easysetup_pages):
2270 Call modest_wizard_dialog_force_title_update() so that the title is
2271 correct even with GTK+ < 2.10.
2272 This fixes projects.maemo.org bug NB#56145 .
2274 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2276 * src/maemo/modest-platform.c:
2277 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2278 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2281 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2283 * src/widgets/modest-window.h:
2284 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2285 and modest_window_save_state(), which invokes it.
2287 * src/widgets/modest-window-mgr.h:
2288 * src/widgets/modest-window-mgr.c:
2289 Added modest_window_mgr_save_state_for_all_windows(), which calls
2290 the save_state vfunc on all registered windows, if implemented.
2292 * src/gnome/modest-msg-edit-window.c:
2293 * src/gnome/modest-msg-view-window.c:
2294 * src/maemo/modest-msg-edit-window.c:
2295 * src/maemo/modest-msg-view-window.c:
2296 * src/maemo/modest-main-window.c:
2297 Specify the existing save_settings functions as implementations of
2298 ModestWindow::save_state_func().
2300 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2301 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2302 enabling hibernation, for instance.
2304 We may need to do the same thing for restoring settings.
2307 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2309 * src/widgets/modest-window-mgr.c:
2310 * src/widgets/modest-window-mgr.h:
2311 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2312 modest_window_mgr_get_hibernation_is_prevented().
2314 * src/maemo/modest-main-window.c:
2315 (on_hildon_program_is_topmost_notify): Prevent hibernation
2316 (possible when the application goes to the background in the WM),
2317 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2319 * src/maemo/easysetup/modest-easysetup-wizard.c:
2320 (modest_easysetup_wizard_dialog_init):
2321 * src/maemo/modest-account-settings-dialog.c:
2322 (modest_account_settings_dialog_init):
2323 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2324 (modest_connection_specific_smtp_edit_window_init):
2325 * src/maemo/modest-connection-specific-smtp-window.c:
2326 (modest_connection_specific_smtp_window_init):
2327 * src/maemo/modest-signature-editor-dialog.c:
2328 (modest_signature_editor_dialog_init):
2329 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2330 prevent hibernation while any of these account settings dialogs are open.
2332 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2334 * src/maemo/Makefile.am:
2335 * src/maemo/modest-osso-state-saving.c:
2336 * src/maemo/modest-osso-state-saving.h: Added
2337 modest_osso_load_state() and modest_osso_save_state() though they do
2338 nothing now. They should iterate through all the open windows and load/save
2340 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2341 save state when closing.
2343 * src/maemo/modest-main-window.c:
2344 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2345 Add a notification handler for the HildonProgram::is-topmost property,
2346 so we can allow hibernation when the application goes into the background.
2347 But we still need to detect when the accounts setup windows are open so
2348 we can stop hibernation when they are open.
2349 To do this, I also added the main window the HildonProgram. This might have
2350 other side-effects/benefits, and should maybe be done for other windows.
2352 * src/maemo/modest-osso-autosave-callbacks.h:
2353 * src/maemo/modest-osso-autosave-callbacks.c:
2354 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2355 though it does not do anything yet, and we might never need this to do
2356 anything. For instance, we already save drafts.
2358 * src/maemo/modest-platform.c: (modest_platform_init):
2359 Specify the libosso auto-save callback.
2361 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2363 * src/maemo/modest-platform.c:
2364 (modest_platform_set_update_interval):
2365 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2366 aparently stays valid between application instances, so we can use this
2367 to remove and reset it later. According to a maemo-developers email from
2370 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2372 * configure.ac: Depend on libalarm for Maemo.
2374 * src/dbus_api/modest-dbus-api.h:
2375 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2376 (on_send_receive), (modest_dbus_req_handler):
2377 Handle a SEND_RECEIVE D-Bus method.
2379 * libmodest-dbus-client/libmodest-dbus-client.c:
2380 (libmodest_dbus_client_send_and_receive):
2381 * libmodest-dbus-client/libmodest-dbus-client.h:
2382 Add C convenience functions for calling the new D-Bus method.
2384 * src/modest-platform.h:
2385 * src/gnome/modest-platform.c:
2386 * src/maemo/modest-platform.c:
2387 Added modest_platform_set_update_interval(), which uses the
2388 alarmd API on Maemo.
2389 (modest_platform_init),
2390 Call modest_platform_set_update_interval(), using a hard-coded
2391 interval for now (until the global settings dialog is implemented),
2392 though I am not sure that this makes sense yet.
2394 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2396 * src/dbus_api/modest-dbus-callbacks.c:
2397 (modest_osso_cb_hw_state_handler):
2398 * src/dbus_api/modest-dbus-callbacks.h:
2399 * src/maemo/modest-platform.c: (modest_platform_init):
2400 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2401 in case this has some effect on the ability for Maemo to ping the
2404 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2406 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2407 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2408 warning. It is probably a logic error, but I need to fix the build.
2410 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2412 * src/modest-account-mgr.h:
2413 * src/modest-account-mgr.c:
2414 (modest_account_mgr_account_names): Add a gboolean enabled_only
2415 parameter, so we can get lists of onlt the enabled accounts.
2417 (modest_account_mgr_add_account),,
2418 (modest_account_mgr_account_with_display_name_exists):
2419 * src/maemo/modest-msg-edit-window.c: (get_transports):
2420 * src/modest-account-mgr-helpers.c:
2421 (modest_account_mgr_set_first_account_as_default):
2422 * src/modest-init.c: (init_default_account_maybe):
2423 * src/modest-tny-account-store.c: (get_accounts):
2424 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2425 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2426 * tests/check_account-mgr.c: (START_TEST):
2427 Provide the extra parameter, as appropriate.
2429 * src/widgets/modest-account-view.c: (update_account_view):
2430 Do not show disabled accounts (meaning that there is no way to
2431 enable/disable accounts in the UI (the feature is not in our UI
2432 specification), so we can use this internally only to mark unfinished
2433 or temporary account data.
2435 * src/maemo/easysetup/modest-easysetup-wizard.c:
2436 (create_account): Add boolean enable parameter, so we can specify FALSE
2437 to create the temporary account.
2438 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2439 (on_before_next): When finishing, when there is a temporary account, just
2441 Also, use a timeout to delay the showing of the dialog until gconf is likely
2442 to return correct information, due to a maemo gconf bug that is fixed in
2443 osso 1.1, but not yet in Bora.
2444 However, the dialog stays on screen after it is destroyed.
2446 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2447 for invalid data when cancelling. Use a hildon note instead of a dialog
2448 to complain about invalid data. Do not show the account-saved note if the
2449 account is disabled (a temporary account that will not really be saved for use
2452 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2454 * src/modest-account-mgr-helpers.h:
2455 * src/modest-account-mgr-helpers.c:
2456 Added modest_account_mgr_unset_default_account(),
2457 Added modest_account_mgr_set_first_account_as_default().
2459 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2460 If it was the default account, unset the default account name.
2462 * src/maemo/modest-account-view-window.c:
2463 (on_delete_button_clicked): If it was the default account,
2464 set the first remaining account as the default instead.
2466 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2467 a NULL account or a NULL default account, to prevent a crash. This should
2468 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2471 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2473 * src/widgets/modest-recpt-editor.c:
2474 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2475 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2476 TODO comment for this. This fixes the build.
2478 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2479 be the best place for it. This will in future update all auto-update accounts,
2480 rather than just the current/default account, when that gconf key exists.
2481 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2482 if there are no accounts, before calling do_send_receive().
2483 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2485 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2486 * src/maemo/modest-main-window-ui.h:
2487 * src/maemo/modest-main-window.c: (on_connection_changed),
2488 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2489 directly, becaue the signal handler does more.
2491 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2493 * src/modest-account-mgr-helpers.c:
2494 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2495 for the case that the account does not exist.
2497 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2498 (equivalent to the modest account name) rather than the tinymail account name
2499 (equivalent to the modest account title - human readable) to get the account data.
2500 Check for null account data to prevent the crash, and add a TODO comment saying that
2501 this needs fixing because it is using the server account name instead of the account name.
2503 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2505 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2506 * src/maemo/modest-account-settings-dialog.c: (show_error),
2508 Use hildon_note_new_information() for informative and error messages,
2509 which seems to be expected for Maemo applications (no documentation that I know of
2510 says this). I am surprised that there is no distinction between info and error
2513 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2515 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2516 it is easy to find where this is used.
2518 * src/maemo/easysetup/modest-easysetup-wizard.c:
2519 (create_page_welcome), (create_page_account_details),
2520 (create_page_user_details), (create_page_complete_easysetup),
2521 (create_page_custom_incoming), (create_page_custom_outgoing),
2522 (create_page_complete_custom):
2523 * src/maemo/modest-account-settings-dialog.c:
2524 (create_page_account_details), (create_page_user_details),
2525 (create_page_incoming), (create_page_outgoing):
2526 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2527 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2528 (modest_connection_specific_smtp_edit_window_init):
2529 * src/maemo/modest-connection-specific-smtp-window.c:
2530 (modest_connection_specific_smtp_window_init):
2531 * src/maemo/modest-signature-editor-dialog.c:
2532 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2533 and scrolling policy as per the Email Application Layout Guide, if I have
2536 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2538 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2539 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2540 which were empty, because these vfuncs have been removed from TnyAccountStore.
2541 This fixes the build.
2543 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2545 * src/maemo/modest-main-window.c:
2546 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2547 showing/hiding it. Added TODO because it probably should not be NULL.
2548 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2549 because unnecessary g_warnings() make degugging difficult.
2551 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2553 * src/maemo/modest-msg-edit-window.c:
2554 (modest_msg_edit_window_select_color),
2555 (modest_msg_edit_window_select_background_color): 2 const corrections and
2556 moving 2 #endifs before closing brackets, to fix the build.
2558 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2560 * src/maemo/easysetup/modest-easysetup-wizard.h:
2561 * src/maemo/easysetup/modest-easysetup-wizard.c:
2562 (modest_easysetup_wizard_dialog_finalize),
2563 (on_button_edit_advanced_settings), (create_page_complete_custom),
2564 (on_response), (create_account):
2565 Implement the Advanced Settings edit button, by saving the account information,
2566 for the Advanded Settings dialog to use directly from gconf, and removing it
2567 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2568 Bug #5533 in the projects.maemo.org bugzilla.
2570 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2572 * src/maemo/modest-msg-view-window.c:
2573 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2574 when opening a message window.
2576 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2578 * src/maemo/easysetup/modest-easysetup-wizard.c:
2579 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2582 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2583 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2584 gconf settings. I probably added more checks than necessary, but that is safer.
2586 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2587 variable to fix the build, but this seems to be used when it is still NULL.
2589 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2591 * src/modest-platform.h:
2592 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2593 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2594 * src/modest-main.c: Implement this function so we can avoid using
2595 maemo-specific API from cross-platform code.
2597 * src/modest-tny-account-store.c:
2598 (get_smtp_specific_transport_account_for_open_connection):
2599 * src/modest-ui-actions.c: (check_for_connection),
2600 (modest_ui_actions_on_item_not_found):
2601 Use modest_platform_connect_and_wait() and put #idefs around other
2602 maemo-specific code, because only maemo currently has a way to
2603 identify connection names.
2605 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2607 * src/modest-tny-account-store.h:
2608 * src/modest-tny-account-store.c:
2609 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2610 the connection-specific SMTP server settings in the configuration.
2612 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2614 * src/maemo/modest-main-window.c: (on_connection_changed),
2616 * src/modest-main.c: (main), (start_ui), (send_mail):
2617 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2618 that is what is intended.
2620 * src/modest-ui-actions.c: (action_send), (action_receive),
2621 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2622 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2623 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2624 SMTP server is used when it is specified.
2626 (modest_ui_actions_on_send_receive):
2627 Check that a connection is open before proceeding.
2628 Receive and then send, instead of vice-versa, as per the specification.
2630 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2632 * src/modest-mail-operation.c:
2633 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2634 though I guess it should be something other than NULL.
2636 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2638 * src/maemo/easysetup/modest-easysetup-wizard.c:
2639 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2640 combo twice, to avoid an g_warning and to make it visible again.
2641 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2642 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2643 (already intended) dereference when detaching, because we then recreate the menu.
2644 But I am not sure why the warning was happening, and it is possible that this is a memory
2647 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2649 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2650 and uri_parse_mailto() utility functions.
2651 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2653 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2655 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2657 * src/dbus_api/modest-dbus-api.h:
2658 * src/dbus_api/modest-dbus-callbacks.c:
2659 Use an idle callback to execute the modest code in the application's own thread.
2660 Remove the helloworld example method.
2661 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2662 parsed, and the open-message method is not implemented because this is not yet implemented in
2664 * libmodest-dbus-client/libmodest-dbus-client.c:
2665 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2666 (libmodest_dbus_client_open_message):
2667 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2669 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2670 body without crashing.
2672 * tests/dbus_api/Makefile.am:
2673 * tests/dbus_api/test_mail_to.c:
2674 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2676 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2678 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2679 Added file to fix the build. Sorry.
2681 * src/dbus_api/Makefile.am:
2682 * src/dbus_api/modest-dbus-api.h:
2683 * src/dbus_api/modest-dbus-callbacks.h:
2684 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2685 (modest_dbus_req_handler):
2686 Put constants in a separate header so it can be reused by the
2687 client library, without duplication
2689 * libmodest-dbus-client/Makefile.am:
2690 * libmodest-dbus-client/libmodest-dbus-client.c:
2691 (libmodest_dbus_client_call_helloworld),
2692 (libmodfest_dbus_client_send_mail),
2693 (libmodfest_dbus_client_mailto),
2694 (libmodfest_dbus_client_open_message):
2695 * libmodest-dbus-client/libmodest-dbus-client.h:
2696 (Partly) Implement a send_mail D-Bus method.
2698 * tests/dbus_api/Makefile.am:
2699 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2700 the send_email D-Bus method.
2702 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2706 * libmodest-dbus-client/Makefile.am:
2707 * libmodest-dbus-client/libmodest-dbus-client.c:
2708 * libmodest-dbus-client/libmodest-dbus-client.h:
2709 * tests/dbus_api/Makefile.am:
2710 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2711 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2713 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2715 * src/maemo/easysetup/modest-easysetup-wizard.c:
2716 (create_page_account_details):
2717 * src/maemo/modest-account-settings-dialog.c:
2718 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2719 widgets, because this might not be the default in future versions of the Maemo GTK+.
2720 However, I can not not get capitalization to work even in a simple test case.
2722 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2724 * src/maemo/easysetup/modest-easysetup-wizard.c:
2725 (create_page_custom_incoming), (create_page_custom_outgoing):
2726 * src/maemo/modest-account-settings-dialog.c:
2727 (create_page_account_details), (create_page_incoming),
2728 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2729 instead of using gtk_check_button_with_label(), so they are aligned like the other
2730 widgets, as per the UI spec.
2732 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2734 * src/maemo/easysetup/modest-easysetup-wizard.c:
2735 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2736 * src/widgets/modest-validating-entry.c:
2737 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2738 Modest prefix instead of an EasySetup prefix.
2740 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2742 * src/widgets/modest-validating-entry.h:
2743 * src/widgets/modest-validating-entry.c: (on_insert_text),
2744 Added easysetup_validating_entry_set_max_func(), used to set a callback
2745 to call when the max number of characters is reached. GtkEntry has a max-length
2746 already but is silent about it.
2748 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2749 (create_page_account_details), (create_page_user_details),
2751 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2752 (create_page_account_details), (create_page_user_details),
2753 (create_page_outgoing):
2754 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2755 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2756 the UI spec, when the user tries to enter more than the max number of characters.
2758 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2760 * src/maemo/easysetup/modest-easysetup-wizard.c:
2761 (create_page_user_details), (create_page_custom_incoming),
2762 (create_page_custom_outgoing):
2763 * src/maemo/modest-account-settings-dialog.c:
2764 (create_page_user_details), (create_page_incoming),
2765 (create_page_outgoing):
2766 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2767 (modest_connection_specific_smtp_edit_window_init):
2768 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2769 not appropriate. Bad Maemo-specific defaults!.
2771 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2773 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2774 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2775 (modest_signature_editor_dialog_set_settings):
2776 Disable the label and textview when the checkbox is disabled, and use the
2777 specified (UI spec) default signature text.
2779 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2781 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2782 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2784 * src/modest-defs.h:
2785 * src/modest-account-mgr-helpers.h:
2786 * src/modest-account-mgr-helpers.c:
2787 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2789 * src/maemo/Makefile.am:
2790 * src/maemo/modest-signature-editor-dialog.c:
2791 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2794 * src/maemo/modest-account-settings-dialog.h:
2795 * src/maemo/modest-account-settings-dialog.c:
2796 (modest_account_settings_dialog_finalize), (on_button_signature),
2797 (save_configuration): Use the new dialog when the Edit button is pressed, and
2798 save the changes if necessary, as per the UI spec.
2800 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2802 * src/maemo/Makefile.am:
2803 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2804 based on maemo-develoers email from Dirk.
2806 * src/maemo/easysetup/modest-easysetup-wizard.c:
2807 (create_page_welcome), (create_page_account_details),
2808 (create_page_user_details), (create_page_complete_easysetup),
2809 (create_page_custom_incoming), (create_page_custom_outgoing),
2810 (create_page_complete_custom),
2811 (modest_easysetup_wizard_dialog_init):
2812 * src/maemo/modest-account-settings-dialog.c:
2813 (create_page_account_details), (create_page_user_details),
2814 (create_page_incoming), (create_page_outgoing),
2815 (modest_account_settings_dialog_init):
2816 * src/maemo/modest-connection-specific-smtp-window.c:
2817 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2819 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2821 * src/maemo/easysetup/modest-easysetup-wizard.c:
2822 (create_page_account_details), (create_page_custom_outgoing),
2823 (create_page_complete_custom):
2824 * src/maemo/modest-account-settings-dialog.c:
2825 (create_page_user_details), (create_page_incoming),
2826 (create_page_outgoing):
2827 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2828 (modest_connection_specific_smtp_edit_window_init):
2829 Use the correct (UI spec) port min/max, and use horizontal separators,
2832 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2834 * src/maemo/easysetup/modest-easysetup-wizard.c:
2835 (set_default_custom_servernames):
2836 * src/maemo/modest-account-settings-dialog.c:
2837 (create_page_incoming), (on_combo_outgoing_security_changed),
2838 (on_combo_incoming_security_changed), (create_page_outgoing),
2839 (modest_account_settings_dialog_set_account_name),
2840 (save_configuration):
2841 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2842 (on_combo_security_changed),
2843 (modest_connection_specific_smtp_edit_window_init),
2844 (modest_connection_specific_smtp_edit_window_set_connection),
2845 (modest_connection_specific_smtp_edit_window_get_settings):
2846 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2849 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2852 * src/maemo/easysetup/modest-easysetup-wizard.c:
2853 (create_page_custom_outgoing), (create_page_complete_custom):
2854 * src/maemo/modest-account-settings-dialog.c:
2855 (create_page_user_details), (create_page_outgoing):
2856 * src/maemo/modest-account-view-window.c: (button_box_new):
2857 Use changed logical IDs as per the most recent UI spec:
2858 mcen_bd_emailsetup_edit -> mcen_bd_edit
2859 mcen_bd_emailsetup_delete -> mcen_bd_delete
2860 mcen_bd_emailsetup_close -> mcen_bd_close
2862 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2866 * src/dbus_api/Makefile.am:
2867 * src/dbus_api/modest-dbus-callbacks.c:
2868 * src/dbus_api/modest-dbus-callbacks.h:
2869 * src/maemo/modest-platform.c: (modest_platform_init):
2870 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2872 * tests/Makefile.am:
2873 * tests/dbus_api/Makefile.am:
2874 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2876 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2878 * src/maemo/modest-account-settings-dialog.c:
2879 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2880 Removed unnecessary includes.
2882 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2884 * src/maemo/easysetup/modest-easysetup-wizard.c:
2885 * src/maemo/modest-account-settings-dialog.c:
2886 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2887 * src/widgets/Makefile.am:
2888 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2889 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2890 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2891 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2892 * src/widgets/modest-secureauth-combo-box.c:
2893 * src/widgets/modest-secureauth-combo-box.h:
2894 * src/widgets/modest-serversecurity-combo-box.c:
2895 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2896 made the GObject names more consistent with the rest of the Modest code.
2898 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2900 * src/maemo/easysetup/Makefile.am:
2901 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2902 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2903 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2904 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2905 * src/maemo/easysetup/modest-easysetup-wizard.c:
2906 * src/maemo/easysetup/modest-validating-entry.c:
2907 * src/maemo/easysetup/modest-validating-entry.h:
2908 * src/maemo/modest-account-settings-dialog.c:
2909 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2910 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2911 widgets/ because they are used outside of easysetup too. After checking in,
2912 svn will allow me to rename them too.
2914 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2916 * src/gnome/modest-msg-edit-window.c:
2917 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2918 linker error, to fix the build on the GNOME platform.
2919 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2920 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2921 ifdefed out to avoid a warning.
2923 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2925 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2926 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2927 some alternative for GTK+ 2.6.
2929 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2931 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2933 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2934 specified for EmailAccountsDialog in UI spec.
2936 * src/maemo/easysetup/modest-easysetup-wizard.c:
2937 * src/maemo/easysetup/modest-easysetup-wizard.h:
2938 * src/maemo/modest-account-settings-dialog.c:
2939 * src/maemo/modest-account-settings-dialog.h:
2940 Reuse a member window widget for the connection-specific SMTP server accounts,
2941 so we can tell it to create/save the accounts only if we actually save changes.
2943 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2944 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2945 (modest_connection_specific_smtp_edit_window_get_settings):
2946 Return a struct instance for temporarily remembering the entered data.
2948 * src/maemo/modest-connection-specific-smtp-window.h:
2949 * src/maemo/modest-connection-specific-smtp-window.c:
2950 (modest_connection_specific_smtp_window_finalize),
2951 (modest_connection_specific_smtp_window_fill_with_connections),
2953 (modest_connection_specific_smtp_window_save_server_accounts),
2954 (update_model_server_names): Do not actually save data until asked,
2955 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2957 (on_selection_changed),
2958 (modest_connection_specific_smtp_window_init): Disable the edit
2959 button when nothing is selected.
2961 * src/modest-account-mgr-helpers.c:
2962 * src/modest-account-mgr-helpers.h:
2963 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2966 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2968 * src/modest-account-mgr-helpers.h:
2969 * src/modest-account-mgr-helpers.c:
2970 (modest_account_mgr_get_unused_account_name),
2971 (modest_account_mgr_get_unused_account_display_name): Added these
2972 utility functions, to avoid code duplication.
2974 * src/maemo/easysetup/modest-easysetup-wizard.c:
2975 (create_page_account_details), (create_account):
2976 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2977 (on_combo_security_changed),
2978 (modest_connection_specific_smtp_edit_window_init),
2979 (modest_connection_specific_smtp_edit_window_save_settings):
2980 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2981 * src/maemo/modest-connection-specific-smtp-window.c:
2982 (modest_connection_specific_smtp_window_finalize),
2983 (modest_connection_specific_smtp_window_fill_with_connections),
2984 (on_button_edit), (modest_connection_specific_smtp_window_init):
2985 * src/maemo/modest-connection-specific-smtp-window.h:
2986 Implementing saving of connection-specific server accounts.
2988 But I need to refactor this so we can save the data for each
2989 possible connection-specific account and only actually create the server accounts
2990 when the easysetup finished, or the OK button is pressed on the account settings
2993 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2995 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2996 (on_combo_security_changed):
2997 (modest_connection_specific_smtp_edit_window_init):
2998 Auto-fill the port number as in the account settings.
3000 (modest_connection_specific_smtp_edit_window_set_connection):
3001 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3002 * src/maemo/modest-connection-specific-smtp-window.c:
3003 (fill_with_connections), (on_button_edit),
3004 (modest_connection_specific_smtp_window_init):
3005 Turn the edit window into a dialog to simplify the code, and
3006 set a WM hint as in a GtkDialog, because only a popup can be on top of
3007 another window in Maemo, and popups usually have no WM decoration.
3009 * src/modest-defs.h:
3010 * src/modest-account-mgr-helpers.c:
3011 (modest_account_mgr_set_connection_specific_smtp),
3012 (modest_account_mgr_remove_connection_specific_smtp),
3013 (modest_account_mgr_get_connection_specific_smtp):
3014 * src/modest-account-mgr-helpers.h: Some functions to write the
3015 connection-specific SMTP server information. Not yet used.
3018 * src/widgets/modest-folder-view.c: (text_cell_data):
3019 Fix a warning about an uninitialized variable.
3020 (on_configuration_key_changed): Put an #ifdef around the use
3021 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3023 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3025 * src/maemo/modest-account-settings-dialog.h:
3026 * src/maemo/modest-account-settings-dialog.c:
3027 Added connect_for_modified() utility function to mark the new modified boolean.
3029 (create_page_account_details), (create_page_user_details),
3030 (create_page_incoming), (create_page_outgoing), (on_response),
3031 (modest_account_settings_dialog_init),
3032 (modest_account_settings_dialog_set_account_name):
3033 Only warn about unsaved changes when there are actually unsaved changes.
3035 * src/modest-account-mgr-helpers.c:
3036 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3037 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3038 to get the data from there in future.
3040 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3042 * src/modest-defs.h:
3044 * src/modest-account-mgr-helpers.h:
3045 * src/modest-account-mgr-helpers.c:
3046 Store the security account setting in a single conf key instead of using
3047 the options list, so that the list is left for just the to-be-removed camel hack,
3048 and because gconf_client_set_list() is failing for some reason.
3050 * src/modest-account-mgr.c:
3051 (modest_account_mgr_add_server_account):
3052 * src/maemo/modest-account-settings-dialog.c:
3053 (modest_account_settings_dialog_set_account_name),
3054 (save_configuration): Use the renamed functions.
3057 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3059 * src/widgets/Makefile.am:
3060 * src/widgets/modest-limit-retrieve-combo-box.c:
3061 * src/widgets/modest-limit-retrieve-combo-box.h:
3062 * src/widgets/modest-retrieve-combo-box.c:
3063 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3064 the account settings dialog.
3066 * src/modest-defs.h:
3067 * src/modest-account-mgr-helpers.h:
3068 * src/modest-account-mgr-helpers.c:
3069 (modest_server_account_get_option_secure_auth),
3070 (modest_server_account_set_option_secure_auth):
3071 * src/modest-account-mgr.c:
3072 (modest_account_mgr_add_server_account):
3073 Use the existing AUTH_MECH conf key for the secure-auth setting,
3074 instead of putting it in the list options, because this was actually used already.
3076 * src/maemo/modest-account-settings-dialog.c:
3077 (create_page_account_details),
3078 (modest_account_settings_dialog_set_account_name),
3079 (save_configuration):
3080 * src/maemo/modest-account-settings-dialog.h:
3081 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3082 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3084 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3086 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3087 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3088 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3090 * src/modest-defs.h:
3091 * src/maemo/modest-account-settings-dialog.c:
3092 (create_page_incoming), (on_combo_outgoing_security_changed),
3093 (on_combo_incoming_security_changed), (create_page_outgoing),
3094 (modest_account_settings_dialog_set_account_name),
3095 (save_configuration): Load/Save the port number, and change it when the
3096 security combo changes, to suitable defaults.
3098 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3100 * src/modest-account-mgr.c:
3101 (modest_account_mgr_add_server_account): Set the security and secure-auth
3102 options, and add a comment saying that the other camel-specific options should be
3105 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3107 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3109 * src/modest-tny-account-store.c: (account_list_free),
3110 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3111 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3114 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3116 * src/modest-protocol-info.c:
3117 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3118 is required by our UI spec. Maybe something in our implementation will use this eventually.
3119 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3120 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3121 instead of the previous 0 placeholder.
3123 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3124 secure-auth settings.
3125 * src/modest-account-mgr-helpers.h:
3126 * src/modest-account-mgr-helpers.c:
3127 (modest_server_account_data_get_option_secure_auth),
3128 (modest_server_account_set_option_secure_auth),
3129 (modest_server_account_data_get_option_security),
3130 (modest_server_account_set_option_security): Added this API for getting and setting the security
3131 and secure-auth settings.
3133 * src/maemo/modest-account-settings-dialog.h:
3134 * src/maemo/modest-account-settings-dialog.c:
3135 (modest_account_settings_dialog_finalize), (check_data),
3136 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3137 about changing titles.
3138 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3139 (save_configuration): Save the security and secure-auth settings.
3141 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3142 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3144 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3146 * src/modest-defs.h:
3147 * src/modest-account-mgr.c:
3148 (modest_account_mgr_add_server_account):
3149 Added and used defines for the options key and value pair strings,
3150 that are used so far, though they do not seem to correspond to anything in our
3151 UI specs or ModestProtocol enum.
3153 * src/modest-account-mgr-helpers.h:
3154 * src/modest-account-mgr-helpers.c:
3155 (compare_option_strings_for_name),
3156 (modest_server_account_data_get_option_value),
3157 (modest_server_account_data_get_option_bool),
3158 (modest_account_mgr_get_server_account_option):
3159 Added helper functions for parsing the options GSList.
3161 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3163 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3164 display name is based on the supplied account name.
3165 * src/modest-account-mgr.c:
3166 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3167 with an inefficient, but good-enough, implementation.
3169 * src/maemo/easysetup/modest-easysetup-wizard.c:
3170 (create_page_account_details), (on_before_next), (create_account):
3171 Check for existing display names rather than (non-user-visible) account names, and just
3172 create and set a unique account name at the end.
3174 * src/maemo/modest-account-settings-dialog.c:
3175 (modest_account_settings_dialog_init),
3176 (modest_account_settings_dialog_set_account_name),
3177 (create_page_incoming): Show the display name, instead of the account name.
3178 (on_response): Do some (not all) extra checks, as in the UI spec.
3179 (save_configuration): Save the display name if it was changed.
3181 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3183 * po/en_GB.po: Added needed logical ID and translation.
3184 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3185 (init_view): Made the is-default column clicking work.
3187 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3190 * src/maemo/easysetup/Makefile.am:
3191 * src/maemo/easysetup/modest-easysetup-wizard.c:
3192 (modest_easysetup_wizard_dialog_init):
3193 * src/maemo/easysetup/provider-data-test.keyfile:
3194 * src/maemo/easysetup/provider-data.keyfile:
3195 Moved the provider data file to the new modest-providers-data package and used it from there.
3197 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3199 * src/modest-local-folder-info.c:
3200 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3201 N_() was already used on the static strings, but this just marks it for translation without
3202 using the translation.
3204 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3206 * src/maemo/modest-account-settings-dialog.c:
3207 (create_page_incoming),
3208 (modest_account_settings_dialog_set_account_name):
3209 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3210 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3211 I will do this if nobody else gets there first.
3213 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3215 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3216 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3217 save the security stuff.
3219 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3221 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3222 Set the email address and user fullname, which I now see must be
3225 * src/maemo/modest-account-settings-dialog.h:
3226 * src/maemo/modest-account-settings-dialog.c:
3228 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3229 leave-on-server and authentication.
3230 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3233 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3236 * src/maemo/modest-account-settings-dialog.c:
3237 * src/maemo/modest-account-settings-dialog.h:
3238 Most (but not all) of the widgets are now present as specified by the UI spec.
3239 No changes are yet saved, and some details are not properly shown yet.
3241 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3243 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3245 * src/maemo/Makefile.am:
3246 * src/maemo/modest-account-settings-dialog.c:
3247 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3248 an existing account. Doesn't do much yet.
3250 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3251 Open the accounts settings dialog when Edit is clicked.
3253 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3255 * src/maemo/easysetup/Makefile.am:
3256 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3258 * src/maemo/easysetup/modest-easysetup-wizard.c:
3259 (modest_easysetup_wizard_dialog_init):
3260 Try to get the source directory from the build system,
3261 instead of hard-coding "./" into the source code, when opening our local
3262 copies of the configuration files.
3263 But this still fails when opening the wizard from the Accounts window,
3264 maybe because the working directory seems to change at runtime.
3265 So the wizard will fail the second time unless you copy the files into their
3266 proper locations - see the stdout warnings for the paths.
3268 (create_page_account_details),(on_before_next):
3269 Check for existing non-server accounts instead of server accounts,
3270 so the default account name is useful again, and to prevent trying to
3273 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3274 Show the wizard when New is clicked.
3276 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3277 (init_view): Show the column headers, and show the columns that are
3278 specified in the UI specs. However, something in Maemo's GTK+ prevents
3279 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3280 change the default account. This is despite unsetting the special properties.
3282 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3284 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3285 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3286 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3287 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3288 to make that clearer.
3289 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3291 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3293 * src/maemo/modest-account-view-window.c:
3294 (modest_account_view_window_init),
3295 (modest_account_view_window_new):
3296 Use the same buttons as specified in the
3297 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3298 the existing widgets, which never had a chance of working.
3299 Put the ModestAccountView treeview in a scrolled window.
3300 Do not repeat the initialization in both _init() and _new().
3302 * src/widgets/modest-account-view.c: (update_account_view):
3303 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3304 this widget and window shows no accounts.
3306 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3308 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3310 * src/maemo/easysetup/modest-easysetup-wizard.c:
3311 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3312 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3313 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3316 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3317 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3318 accounts exist yet, as in the UI spec.
3320 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3322 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3324 * src/maemo/Makefile.am:
3325 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3326 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3327 New window for editing connection-specific smtp details.
3328 Not fully implemented.
3330 * src/maemo/modest-connection-specific-smtp-window.c:
3331 (modest_connection_specific_smtp_window_finalize) :
3332 unref the tree model.
3333 (on_button_edit): Show the edit window.
3335 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3337 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3340 * src/maemo/Makefile.am:
3341 * src/maemo/modest-connection-specific-smtp-window.c:
3342 * src/maemo/modest-connection-specific-smtp-window.h:
3343 New window for showing the list of connections, for connection-specific
3344 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3345 * src/maemo/easysetup/modest-easysetup-wizard.c:
3346 (create_page_custom_outgoing): Show the new window when the button is clicked.
3348 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3350 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3351 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3352 * src/maemo/modest-msg-edit-window.c:
3353 (modest_msg_edit_window_insert_image):
3354 * src/modest-conf.c: (modest_conf_key_escape):
3355 * src/modest-mail-operation.c:
3356 (modest_mail_operation_send_new_mail):
3357 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3358 (modest_ui_actions_on_new_account):
3359 * src/widgets/modest-attachment-view.c: (update_filename_request):
3360 * src/widgets/modest-mail-header-view.c:
3361 Corrected warnings that were breaking the build, by commenting out unused variables,
3362 and a function, and by including a header.
3364 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3366 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3367 so we can #ifdef around platform-specific code when necessary.
3368 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3369 to allow this to build for the GNOME platform too.
3371 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3373 * src/maemo/easysetup/modest-easysetup-wizard.c:
3374 Added util_increment_name() and used it in create_page_account_details()
3375 to make sure that the default account name is always a new name.
3377 (modest_easysetup_wizard_dialog_init),
3378 (set_default_custom_servernames): Some minor memory management fixes.
3380 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3384 * src/modest-runtime.c: (init_i18n): Restored the translation
3385 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3386 are defined in config.h, and the translations are installed.
3388 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3389 is defined for translation.
3391 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3393 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3395 * src/maemo/easysetup/modest-easysetup-wizard.c:
3396 (modest_easysetup_wizard_dialog_init):
3397 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3398 Use realistic paths (though they should use $prefix generically) to the
3399 mcc_mapping and provider-data.keyfile files which might work when they
3400 are installed by the future version of the operator-wizard package,
3401 and then fallback to paths in our source code, with an explanatory
3404 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3408 * src/maemo/Makefile.am:
3409 * src/maemo/easysetup/: Added files from the previously-exernal
3410 osso-modest-easysetup.
3411 * src/maemo/modest-main-window-ui.h:
3412 * src/modest-ui-actions.c:
3413 * src/modest-ui-actions.h:
3414 Added modest_ui_actions_on_new_account() as a signal handler for the
3415 New Account menu item. It shows the easysetup wizard.
3416 * po/en_GB.po: Added additional needed logical IDs and translations.