git.maemo.org Git - modest/blob - ChangeLog2

   1 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
   2
   3         * src/maemo/modest-address-book.c: Added include to avoid a warning.
   4
   5         * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
   6         specified for EmailAccountsDialog in UI spec.
   7
   8         * src/maemo/easysetup/modest-easysetup-wizard.c:
   9         * src/maemo/easysetup/modest-easysetup-wizard.h:
  10         * src/maemo/modest-account-settings-dialog.c:
  11         * src/maemo/modest-account-settings-dialog.h:
  12         Reuse a member window widget for the connection-specific SMTP server accounts,
  13         so we can tell it to create/save the accounts only if we actually save changes.
  14
  15         * src/maemo/modest-connection-specific-smtp-edit-window.h:
  16         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  17         (modest_connection_specific_smtp_edit_window_get_settings):
  18         Return a struct instance for temporarily remembering the entered data.
  19
  20         * src/maemo/modest-connection-specific-smtp-window.h:
  21         * src/maemo/modest-connection-specific-smtp-window.c:
  22         (modest_connection_specific_smtp_window_finalize),
  23         (modest_connection_specific_smtp_window_fill_with_connections),
  24         (on_button_edit),
  25         (modest_connection_specific_smtp_window_save_server_accounts),
  26         (update_model_server_names): Do not actually save data until asked,
  27         when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
  28
  29         (on_selection_changed),
  30         (modest_connection_specific_smtp_window_init): Disable the edit
  31         button when nothing is selected.
  32
  33         * src/modest-account-mgr-helpers.c:
  34         * src/modest-account-mgr-helpers.h:
  35         Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
  36         elsewhere.
  37
  38 2007-04-19  Murray Cumming  <murrayc@murrayc.com>
  39
  40         * src/modest-account-mgr-helpers.h:
  41         * src/modest-account-mgr-helpers.c:
  42         (modest_account_mgr_get_unused_account_name),
  43         (modest_account_mgr_get_unused_account_display_name): Added these
  44         utility functions, to avoid code duplication.
  45
  46         * src/maemo/easysetup/modest-easysetup-wizard.c:
  47         (create_page_account_details), (create_account):
  48         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  49         (on_combo_security_changed),
  50         (modest_connection_specific_smtp_edit_window_init),
  51         (modest_connection_specific_smtp_edit_window_save_settings):
  52         * src/maemo/modest-connection-specific-smtp-edit-window.h:
  53         * src/maemo/modest-connection-specific-smtp-window.c:
  54         (modest_connection_specific_smtp_window_finalize),
  55         (modest_connection_specific_smtp_window_fill_with_connections),
  56         (on_button_edit), (modest_connection_specific_smtp_window_init):
  57         * src/maemo/modest-connection-specific-smtp-window.h:
  58         Implementing saving of connection-specific server accounts.
  59
  60         But I need to refactor this so we can save the data for each
  61         possible connection-specific account and only actually create the server accounts
  62         when the easysetup finished, or the OK button is pressed on the account settings
  63         dialog.
  64
  65 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
  66
  67         * src/maemo/modest-connection-specific-smtp-edit-window.c:
  68         (on_combo_security_changed):
  69         (modest_connection_specific_smtp_edit_window_init):
  70         Auto-fill the port number as in the account settings.
  71
  72         (modest_connection_specific_smtp_edit_window_set_connection):
  73         * src/maemo/modest-connection-specific-smtp-edit-window.h:
  74         * src/maemo/modest-connection-specific-smtp-window.c:
  75         (fill_with_connections), (on_button_edit),
  76         (modest_connection_specific_smtp_window_init):
  77         Turn the edit window into a dialog to simplify the code, and
  78         set a WM hint as in a GtkDialog, because only a popup can be on top of
  79         another window in Maemo, and popups usually have no WM decoration.
  80
  81         * src/modest-defs.h:
  82         * src/modest-account-mgr-helpers.c:
  83         (modest_account_mgr_set_connection_specific_smtp),
  84         (modest_account_mgr_remove_connection_specific_smtp),
  85         (modest_account_mgr_get_connection_specific_smtp):
  86         * src/modest-account-mgr-helpers.h: Some functions to write the
  87         connection-specific SMTP server information. Not yet used.
  88
  89
  90         * src/widgets/modest-folder-view.c: (text_cell_data):
  91         Fix a warning about an uninitialized variable.
  92         (on_configuration_key_changed): Put an #ifdef around the use
  93         of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
  94
  95 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
  96
  97         * src/maemo/modest-account-settings-dialog.h:
  98         * src/maemo/modest-account-settings-dialog.c:
  99         Added connect_for_modified() utility function to mark the new modified boolean.
 100
 101         (create_page_account_details), (create_page_user_details),
 102         (create_page_incoming), (create_page_outgoing), (on_response),
 103         (modest_account_settings_dialog_init),
 104         (modest_account_settings_dialog_set_account_name):
 105         Only warn about unsaved changes when there are actually unsaved changes.
 106
 107         * src/modest-account-mgr-helpers.c:
 108         * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
 109         into the ModestServerAccountData struct. I do not use it yet, but someone might expect
 110         to get the data from there in future.
 111
 112 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 113
 114         * src/modest-defs.h:
 115
 116         * src/modest-account-mgr-helpers.h:
 117         * src/modest-account-mgr-helpers.c:
 118         Store the security account setting in a single conf key instead of using
 119         the options list, so that the list is left for just the to-be-removed camel hack,
 120         and because gconf_client_set_list() is failing for some reason.
 121
 122         * src/modest-account-mgr.c:
 123         (modest_account_mgr_add_server_account):
 124         * src/maemo/modest-account-settings-dialog.c:
 125         (modest_account_settings_dialog_set_account_name),
 126         (save_configuration): Use the renamed functions.
 127
 128
 129 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 130
 131         * src/widgets/Makefile.am:
 132         * src/widgets/modest-limit-retrieve-combo-box.c:
 133         * src/widgets/modest-limit-retrieve-combo-box.h:
 134         * src/widgets/modest-retrieve-combo-box.c:
 135         * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
 136         the account settings dialog.
 137
 138         * src/modest-defs.h:
 139         * src/modest-account-mgr-helpers.h:
 140         * src/modest-account-mgr-helpers.c:
 141         (modest_server_account_get_option_secure_auth),
 142         (modest_server_account_set_option_secure_auth):
 143         * src/modest-account-mgr.c:
 144         (modest_account_mgr_add_server_account):
 145         Use the existing AUTH_MECH conf key for the secure-auth setting,
 146         instead of putting it in the list options, because this was actually used already.
 147
 148         * src/maemo/modest-account-settings-dialog.c:
 149         (create_page_account_details),
 150         (modest_account_settings_dialog_set_account_name),
 151         (save_configuration):
 152         * src/maemo/modest-account-settings-dialog.h:
 153         Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
 154         Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
 155
 156 2007-04-18  Murray Cumming  <murrayc@murrayc.com>
 157
 158         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
 159         * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
 160         Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
 161
 162         * src/modest-defs.h:
 163         * src/maemo/modest-account-settings-dialog.c:
 164         (create_page_incoming), (on_combo_outgoing_security_changed),
 165         (on_combo_incoming_security_changed), (create_page_outgoing),
 166         (modest_account_settings_dialog_set_account_name),
 167         (save_configuration): Load/Save the port number, and change it when the
 168         security combo changes, to suitable defaults.
 169
 170 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 171
 172         * src/modest-account-mgr.c:
 173         (modest_account_mgr_add_server_account): Set the security and secure-auth
 174         options, and add a comment saying that the other camel-specific options should be
 175         removed in future.
 176
 177 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 178
 179         * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
 180         found by valgrind.
 181         * src/modest-tny-account-store.c: (account_list_free),
 182         (on_account_changed): Add a TODO comment about a valgrind error, caused by using
 183         cursor->data after unreffing it. But there is some strange stuff there so it might not be
 184         easy to fix.
 185
 186 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 187
 188         * src/modest-protocol-info.c:
 189         * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
 190         is required by our UI spec. Maybe something in our implementation will use this eventually.
 191         * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
 192         (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
 193         instead of the previous 0 placeholder.
 194
 195         * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
 196         secure-auth settings.
 197         * src/modest-account-mgr-helpers.h:
 198         * src/modest-account-mgr-helpers.c:
 199         (modest_server_account_data_get_option_secure_auth),
 200         (modest_server_account_set_option_secure_auth),
 201         (modest_server_account_data_get_option_security),
 202         (modest_server_account_set_option_security): Added this API for getting and setting the security
 203         and secure-auth settings.
 204
 205         * src/maemo/modest-account-settings-dialog.h:
 206         * src/maemo/modest-account-settings-dialog.c:
 207         (modest_account_settings_dialog_finalize), (check_data),
 208         (on_response): Store the original title as well as the name, to avoid unnececessary warnings
 209         about changing titles.
 210         (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
 211         (save_configuration): Save the security and secure-auth settings.
 212
 213         * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
 214         is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
 215
 216 2007-04-17  Murray Cumming  <murrayc@murrayc.com>
 217
 218         * src/modest-defs.h:
 219         * src/modest-account-mgr.c:
 220         (modest_account_mgr_add_server_account):
 221         Added and used defines for the options key and value pair strings,
 222         that are used so far, though they do not seem to correspond to anything in our
 223         UI specs or ModestProtocol enum.
 224
 225         * src/modest-account-mgr-helpers.h:
 226         * src/modest-account-mgr-helpers.c:
 227         (compare_option_strings_for_name),
 228         (modest_server_account_data_get_option_value),
 229         (modest_server_account_data_get_option_bool),
 230         (modest_account_mgr_get_server_account_option):
 231         Added helper functions for parsing the options GSList.
 232
 233 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 234
 235         * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
 236         display name is based on the supplied account name.
 237         * src/modest-account-mgr.c:
 238         * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
 239         with an inefficient, but good-enough, implementation.
 240
 241         * src/maemo/easysetup/modest-easysetup-wizard.c:
 242         (create_page_account_details), (on_before_next), (create_account):
 243         Check for existing display names rather than (non-user-visible) account names, and just
 244         create and set a unique account name at the end.
 245
 246         * src/maemo/modest-account-settings-dialog.c:
 247         (modest_account_settings_dialog_init),
 248         (modest_account_settings_dialog_set_account_name),
 249         (create_page_incoming): Show the display name, instead of the account name.
 250         (on_response): Do some (not all) extra checks, as in the UI spec.
 251         (save_configuration): Save the display name if it was changed.
 252
 253 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 254
 255         * po/en_GB.po: Added needed logical ID and translation.
 256         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 257         (init_view): Made the is-default column clicking work.
 258
 259 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 260
 261         * configure.ac:
 262         * src/maemo/easysetup/Makefile.am:
 263         * src/maemo/easysetup/modest-easysetup-wizard.c:
 264         (modest_easysetup_wizard_dialog_init):
 265         * src/maemo/easysetup/provider-data-test.keyfile:
 266         * src/maemo/easysetup/provider-data.keyfile:
 267         Moved the provider data file to the new modest-providers-data package and used it from there.
 268
 269 2007-04-16  Murray Cumming  <murrayc@murrayc.com>
 270
 271         * src/modest-local-folder-info.c:
 272         (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
 273         N_() was already used on the static strings, but this just marks it for translation without
 274         using the translation.
 275
 276 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 277
 278         * src/maemo/modest-account-settings-dialog.c:
 279         (create_page_incoming),
 280         (modest_account_settings_dialog_set_account_name):
 281         Added comments about the need for new API in ModestAccountMgr to handle the authentication
 282         and secure-connection stuff that is stored in the options GSList* with hard-coded names.
 283         I will do this if nobody else gets there first.
 284
 285 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 286
 287         * src/maemo/modest-account-settings-dialog.c: (save_configuration):
 288         Saved much of the incoming and outgoing data too, though I cannot yet see how to
 289         save the security stuff.
 290
 291 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 292
 293         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 294         Set the email address and user fullname, which I now see must be
 295         done separately.
 296
 297         * src/maemo/modest-account-settings-dialog.h:
 298         * src/maemo/modest-account-settings-dialog.c:
 299          (on_response),
 300         (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
 301         leave-on-server and authentication.
 302         (save_configuration): Save most of the non-server-account specific stuff, but I don't see
 303         how to do the rest.
 304
 305 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 306
 307
 308         * src/maemo/modest-account-settings-dialog.c:
 309         * src/maemo/modest-account-settings-dialog.h:
 310         Most (but not all) of the widgets are now present as specified by the UI spec.
 311         No changes are yet saved, and some details are not properly shown yet.
 312
 313         * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
 314
 315 2007-04-06  Murray Cumming  <murrayc@murrayc.com>
 316
 317         * src/maemo/Makefile.am:
 318         * src/maemo/modest-account-settings-dialog.c:
 319         * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
 320         an existing account. Doesn't do much yet.
 321
 322         * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
 323         Open the accounts settings dialog when Edit is clicked.
 324
 325 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 326
 327         * src/maemo/easysetup/Makefile.am:
 328         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 329         (load_from_file):
 330         * src/maemo/easysetup/modest-easysetup-wizard.c:
 331         (modest_easysetup_wizard_dialog_init):
 332         Try to get the source directory from the build system,
 333         instead of hard-coding "./" into the source code, when opening our local
 334         copies of the configuration files.
 335         But this still fails when opening the wizard from the Accounts window,
 336         maybe because the working directory seems to change at runtime.
 337         So the wizard will fail the second time unless you copy the files into their
 338         proper locations - see the stdout warnings for the paths.
 339
 340         (create_page_account_details),(on_before_next):
 341         Check for existing non-server accounts instead of server accounts,
 342         so the default account name is useful again, and to prevent trying to
 343         recreate accounts.
 344
 345         * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
 346         Show the wizard when New is clicked.
 347
 348         * src/widgets/modest-account-view.c: (on_account_default_toggled),
 349         (init_view): Show the column headers, and show the columns that are
 350         specified in the UI specs. However, something in Maemo's GTK+ prevents
 351         us from handling the GtkCellRendererToggle::toggled signal, so we cannot
 352         change the default account. This is despite unsetting the special properties.
 353
 354 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 355
 356         * docs/reference/modest-design.sgml: Corrected spelling mistake.
 357         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 358         Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
 359         This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
 360         to make that clearer.
 361         * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
 362
 363 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 364
 365         * src/maemo/modest-account-view-window.c:
 366         (modest_account_view_window_init),
 367         (modest_account_view_window_new):
 368         Use the same buttons as specified in the
 369         UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
 370         the existing widgets, which never had a chance of working.
 371         Put the ModestAccountView treeview in a scrolled window.
 372         Do not repeat the initialization in both _init() and _new().
 373
 374         * src/widgets/modest-account-view.c: (update_account_view):
 375         Add a warning about modest_account_mgr_account_names() returning NULL, which is why
 376         this widget and window shows no accounts.
 377
 378         * po/en_GB.po: Added translations needed for the dialog button logical IDs.
 379
 380 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 381
 382         * src/maemo/easysetup/modest-easysetup-wizard.c:
 383         (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
 384         (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
 385         returns NULL after modest_account_mgr_add_server_account() returned TRUE,
 386         which seems wrong.
 387
 388         * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
 389         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
 390         accounts exist yet, as in the UI spec.
 391
 392         * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
 393
 394 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 395
 396         * src/maemo/Makefile.am:
 397         * src/maemo/modest-connection-specific-smtp-edit-window.c:
 398         * src/maemo/modest-connection-specific-smtp-edit-window.h:
 399         New window for editing connection-specific smtp details.
 400         Not fully implemented.
 401
 402         * src/maemo/modest-connection-specific-smtp-window.c:
 403         (modest_connection_specific_smtp_window_finalize) :
 404         unref the tree model.
 405         (on_button_edit): Show the edit window.
 406
 407 2007-04-05  Murray Cumming  <murrayc@murrayc.com>
 408
 409         * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
 410         error for me.
 411
 412         * src/maemo/Makefile.am:
 413         * src/maemo/modest-connection-specific-smtp-window.c:
 414         * src/maemo/modest-connection-specific-smtp-window.h:
 415         New window for showing the list of connections, for connection-specific
 416         SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
 417         * src/maemo/easysetup/modest-easysetup-wizard.c:
 418         (create_page_custom_outgoing): Show the new window when the button is clicked.
 419
 420 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 421
 422         * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
 423         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 424         * src/maemo/modest-msg-edit-window.c:
 425         (modest_msg_edit_window_insert_image):
 426         * src/modest-conf.c: (modest_conf_key_escape):
 427         * src/modest-mail-operation.c:
 428         (modest_mail_operation_send_new_mail):
 429         * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
 430         (modest_ui_actions_on_new_account):
 431         * src/widgets/modest-attachment-view.c: (update_filename_request):
 432         * src/widgets/modest-mail-header-view.c:
 433         Corrected warnings that were breaking the build, by commenting out unused variables,
 434         and a function, and by including a header.
 435
 436 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 437
 438         * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
 439         so we can #ifdef around platform-specific code when necessary.
 440         * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
 441         to allow this to build for the GNOME platform too.
 442
 443 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 444
 445         * src/maemo/easysetup/modest-easysetup-wizard.c:
 446         Added util_increment_name() and used it in create_page_account_details()
 447         to make sure that the default account name is always a new name.
 448
 449         (modest_easysetup_wizard_dialog_init),
 450         (set_default_custom_servernames): Some minor memory management fixes.
 451
 452 2007-04-04  Murray Cumming  <murrayc@murrayc.com>
 453
 454         * Makefile.am:
 455         * configure.ac:
 456         * src/modest-runtime.c: (init_i18n): Restored the translation
 457         infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
 458         are defined in config.h, and the translations are installed.
 459
 460         * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
 461         is defined for translation.
 462
 463 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 464
 465         * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
 466         (load_from_file):
 467         * src/maemo/easysetup/modest-easysetup-wizard.c:
 468         (modest_easysetup_wizard_dialog_init):
 469         * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
 470         Use realistic paths (though they should use $prefix generically) to the
 471         mcc_mapping and provider-data.keyfile files which might work when they
 472         are installed by the future version of the operator-wizard package,
 473         and then fallback to paths in our source code, with an explanatory
 474         warning.
 475
 476 2007-04-03  Murray Cumming  <murrayc@murrayc.com>
 477
 478         * configure.ac:
 479         * src/Makefile.am:
 480         * src/maemo/Makefile.am:
 481         * src/maemo/easysetup/: Added files from the previously-exernal
 482         osso-modest-easysetup.
 483         * src/maemo/modest-main-window-ui.h:
 484         * src/modest-ui-actions.c:
 485         * src/modest-ui-actions.h:
 486         Added modest_ui_actions_on_new_account() as a signal handler for the
 487         New Account menu item. It shows the easysetup wizard.
 488         * po/en_GB.po: Added additional needed logical IDs and translations.
 489
 490 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
 491 Apparently ChangeLog is not used for some vague Nokia legal reasons.
 492