1 2007-06-27 Murray Cumming <murrayc@murrayc.com
3 * src/modest-mail-operation.c: (update_account_thread),
4 (get_msgs_full_thread): Fix typo failures in the revert
7 2007-06-27 Murray Cumming <murrayc@murrayc.com
9 * src/maemo/modest-maemo-global-settings-dialog.c:
10 (idle_select_default_focus):
11 * src/modest-mail-operation.c: (idle_notify_progress),
12 (idle_notify_progress_once), (set_last_updated_idle),
13 (update_account_thread), (get_msgs_full_thread):
14 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
15 * src/widgets/modest-header-view.c:
16 (idle_notify_headers_count_changed_destroy),
17 (idle_notify_headers_count_changed):
18 Reverted the additions of gdk_threads_enter/leave(), in case this
19 helps with a startup hang on the device.
21 2007-06-26 Armin Burgmeier <armin@openismus.com>
23 * src/maemo/modest-maemo-utils.c: Replaced a busy wait while waiting
24 for supported secure authentication methods from server by
25 gtk_dialog_run(), saving CPU time and a potential race condition.
27 2007-06-26 Armin Burgmeier <armin@openismus.com>
29 * src/maemo/modest-maemo-utils.h:
30 * src/maemo/modest-maemo-utils.c: Added a
31 ModestMaemoUtilsGetSupportedSecureAuthenticationError with CANCELED as
32 only error code to tell the calling code when the user canceled the
35 * src/maemo/modest-account-settings-dialog.h:
36 * src/maemo/modest-account-settings-dialog.c:
37 * src/maemo/easysetup/modest-easysetup-wizard.c: Do not show an error
38 message if the retrieval of secure authentication methods was canceled
39 by the user. Perform the check before saving anything to configuration
40 to not end up with half-committed configuration changes, do not show
41 a "Saving to configuration failed" note when authentication methods
42 could not be retrieved.
44 * src/maemo/modest-main-window.c: Fixed a crash on startup when built
47 2007-06-26 Murray Cumming <murrayc@murrayc.com>
49 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
50 Only return the first level of folders under accounts, because the
51 osso-global-search UI spec doesn't want the rest.
52 This fixed projects.maemo.org bug NB#61811.
54 2007-06-26 Murray Cumming <murrayc@murrayc.com>
56 * src/modest-tny-account-store.c:
57 * src/modest-tny-account-store.h:
58 Added modest_tny_account_is_memory_card_account().
59 * src/maemo/modest-main-window.c: (create_details_widget):
60 Show the same information items for the memory card as we show for the
61 local-folders, to fix projects.maemo.org bug NB#59307.
63 2007-06-26 Murray Cumming <murrayc@murrayc.com>
65 * src/modest-tny-account-store.c: (get_password):
66 Added some checks for NULL to maybe prevent crashes, though I think
67 it was Philip's last commit that actually prevented the crash here
68 when creating a first new account.
69 But the new account is still not usable (no messages are shown)
70 until a restart of the application.
72 2007-06-26 Murray Cumming <murrayc@murrayc.com>
74 * src/maemo/modest-maemo-global-settings-dialog.c:
75 (idle_select_default_focus):
76 * src/modest-mail-operation.c: (idle_notify_progress),
77 (idle_notify_progress_once), (idle_notify_update_account_queue),
78 (set_last_updated_idle), (update_account_thread),
79 (notify_get_msgs_full), (get_msgs_full_destroyer),
80 (get_msgs_full_thread):
81 * src/widgets/modest-attachment-view.c: (get_size_idle_func):
82 * src/widgets/modest-header-view.c:
83 (idle_notify_headers_count_changed_destroy),
84 (idle_notify_headers_count_changed):
85 Use gdk_threads_enter() and gdk_threads_enter_leave() in
86 all idle handlers, because some other thread could be blocking
87 the GDK lock, so that it can do GUI stuff.
89 2007-06-26 Murray Cumming <murrayc@murrayc.com>
91 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_mail_to),
92 (on_idle_compose_mail), (on_compose_mail), (on_idle_open_message),
93 (on_idle_send_receive), (on_idle_open_default_inbox):
94 * src/maemo/modest-msg-edit-window.c:
95 (modest_msg_edit_window_attach_file_noninteractive):
96 Use gdk_threads_enter() and gdk_threads_leave() in all the idle handlers,
97 to prevent a hang. I don't quite understand why these are necessary,
98 beause we should already be in the main loop. I guess something outside
99 of the main loop is taking the lock.
101 * tests/dbus_api/test_compose_mail.c: (main): Use file:// prefixes so
102 we are really using URIs, and use files that are more likely to exist.
104 2007-06-26 Murray Cumming <murrayc@murrayc.com>
106 * tests/dbus_api/Makefile.am: Fix the build of the tests. This was
107 necessary because configure.ac now defines different variables.
109 2007-06-26 Murray Cumming <murrayc@murrayc.com>
111 * libmodest-dbus-client/libmodest-dbus-client.c:
112 * libmodest-dbus-client/libmodest-dbus-client.h:
113 Removed libmodest_dbus_client_send_mail() because it is not used by anything.
114 libmodest_dbus_client_compose_mail() is what things actually use.
116 * src/dbus_api/modest-dbus-api.h:
117 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_handler):
118 * tests/dbus_api/Makefile.am:
119 * tests/dbus_api/test_send_mail.c: Removed the MODEST_DBUS_METHOD_SEND_MAIL
122 2007-06-26 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-init.c: (modest_init_local_folders):
125 For memory-card (or other non local-folders) maildir accounts,
126 always create an Archive folder, so that there is somewhere to put
127 messages. This should be less confusing, because the user does not need
128 to guess that the need to create a folder.
130 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
132 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
133 Fixed icon size by using (50, 50) which is the same as defined by
136 2007-06-25 Armin Burgmeier <armin@openismus.com>
138 * src/widgets/modest-window-mgr.c:
140 * configure.ac: Correctly recognize hildon-notify presence and fixed
141 the build without it being installed.
143 2007-06-25 Murray Cumming <murrayc@murrayc.com>
145 * libmodest-dbus-client/libmodest-dbus-client.c:
146 (libmodest_dbus_client_search): Fix the build. Sorry.
147 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
148 (reply_forward_cb): Initialize variables to fix the build.
150 * src/modest-tny-account-store.c:
151 (modest_tny_account_store_get_tny_account_by): Fix the account URI
152 comparison (a silly typo) so that email search results can be opened
153 when there are more than one account.
155 2007-06-25 Murray Cumming <murrayc@murrayc.com>
157 * libmodest-dbus-client/libmodest-dbus-client.c:
158 (libmodest_dbus_client_search),
159 (libmodest_dbus_client_get_folders): Use large timeouts (2 minutes)
160 instead of 1 second, because the search gets folders and messages from
161 the server, which can take a long time. When it times out,
162 osso-global-search will report no results.
164 We need to specify whether we should search only cached information
165 (maybe with a user preference), and the osso-email-search-plugin
166 API should really be improved to allow that option, and to allow results
167 to be delivered asynchronously in batches.
169 2007-06-25 Murray Cumming <murrayc@murrayc.com>
171 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
172 Fix a typo to fix the osso 1.1. build. See the TODO comment though -
173 GTK_ICON_SIZE_DIALOG is probably the wrong size.
175 2007-06-25 Murray Cumming <murrayc@murrayc.com>
177 * src/modest-search.c: (modest_search_folder): Ignore a seach folder
178 that is an empty string. D-Bus seems to give us these instead of NULL.
180 2007-06-25 Johannes Schmid <johannes.schmid@openismus.com>
182 * src/dbus_api/modest-dbus-callbacks.c:
183 * src/maemo/easysetup/modest-easysetup-wizard.h:
184 * src/maemo/easysetup/modest-wizard-dialog.c: (init):
185 * src/maemo/modest-connection-specific-smtp-edit-window.c:
186 (modest_connection_specific_smtp_edit_window_init):
187 * src/maemo/modest-maemo-global-settings-dialog.c:
189 * src/maemo/modest-maemo-utils.c:
190 (modest_maemo_utils_setup_images_filechooser):
191 * src/maemo/modest-main-window.c: (create_details_widget):
192 * src/maemo/modest-msg-edit-window.c:
193 (modest_msg_edit_window_attach_file_noninteractive),
194 (modest_msg_edit_window_color_button_change),
195 (modest_msg_edit_window_set_zoom):
196 * src/modest-mail-operation.c: (update_account_thread):
197 * src/modest-tny-account-store.c:
198 * src/modest-tny-account.c:
199 * src/widgets/modest-global-settings-dialog.c:
200 * src/widgets/modest-window.h:
204 2007-06-25 Murray Cumming <murrayc@murrayc.com>
206 * src/dbus_api/modest-dbus-callbacks.c: (on_dbus_method_search):
207 * src/modest-search.c: (modest_search_folder),
208 (modest_search_all_accounts): Actually search only in the specified folder,
209 doing a simple match on the folder ID.
210 * src/modest-search.h: Added a folder field to the ModestSearch struct,
211 and added some documentation.
213 2007-06-22 Armin Burgmeier <armin@openismus.com>
215 * src/maemo/modest-maemo-utils.h:
216 * src/maemo/modest-maemo-utils.c: Added a GError parameter to
217 modest_maemo_utils_get_supported_secure_authentication_methods.
219 * src/maemo/easysetup/modest-easysetup-wizard.c:
220 * src/maemo/modest-account-settings-dialog.c: Show correct error if
221 one occured, not just "Server does not support secure authentication".
223 2007-06-22 Murray Cumming <murrayc@murrayc.com>
225 * src/modest-tny-account-store.c: (get_password):
226 Restored the call to tny_account_set_user() because Philip seems to have
227 stopped this from crashing (by not using the freed string). It still does
228 not work, but now we can test it.
230 2007-06-22 Murray Cumming <murrayc@murrayc.com>
232 * src/maemo/modest-msg-edit-window.c: (init_window):
233 Comment out use of an uninitialzed GtkScrolledWindow variable,
234 to fix the build and stop a crash. Yet again.
236 2007-06-22 Murray Cumming <murrayc@murrayc.com>
238 * src/modest-tny-account-store.c: (get_password):
239 Remove the call to tny_account_set_user() because this actually crashes.
240 As mentioned in the last commit, it is known to not work anyway.
242 2007-06-22 Murray Cumming <murrayc@murrayc.com>
244 * src/modest-tny-account-store.c: (get_password):
245 Use tny_account_set_username() to tell tinymail that the username might
246 have changed too. But tinymail ignores this: see projects.maemo.org
248 * src/modest-ui-actions.c:
249 (modest_ui_actions_on_password_requested): Remove the useless attempt to
250 reset the connection when changing the username, and improve the comments.
251 Save the changed username to gconf at least, so it is used when Modest is
254 2007-06-21 Murray Cumming <murrayc@murrayc.com>
256 * src/dbus_api/modest-dbus-callbacks.c: (add_folders_to_list):
257 Do not use a query, so that we get all folders, including for POP and
258 local-folders. They work as search criteria too.
259 This fixes projects.maemo.org bug NB#57740.
261 2007-06-21 Murray Cumming <murrayc@murrayc.com>
263 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
264 Comment out the use of hildon_notification_set_sound() because it is
265 not declared, to fix the build. Warnings are serious, people.
267 2007-06-21 Armin Burgmeier <armin@openismus.com>
269 * src/maemo/modest-maemo-utils.h:
270 * src/maemo/modest-maemo-utils.c: Added a username parameter to the
271 modest_maemo_utils_get_supported_secure_authentication_methods()
272 to query authentication methods for a specific user. This should fix
273 projects.maemo.org bug NB#61369.
275 * src/maemo/easysetup/modest-easysetup-wizard.c:
276 * src/maemo/modest-account-settings-dialog.c: Adjusted calls to that
279 2007-06-21 Murray Cumming <murrayc@murrayc.com>
281 * libmodest-dbus-client/libmodest-dbus-client.h:
282 * libmodest-dbus-client/libmodest-dbus-client.c:
283 (modest_dbus_message_iter_get_search_hit),
284 (libmodest_dbus_client_search):
285 Reorganised and commented this.
286 Removed modest_search_hit_free() from the public API because it
289 Added libmodest_dbus_client_get_folders() and
290 modest_folder_result_list_free().
292 * src/dbus_api/modest-dbus-api.h:
293 * src/dbus_api/modest-dbus-callbacks.c:
294 (modest_dbus_req_filter): Commented. Moved most code to
295 on_dbus_method_search() and added on_dbus_method_get_folders().
297 * src/maemo/modest-platform.c: (modest_platform_init): Commented the use
298 of the extra D-Bus handler.
300 * tests/dbus_api/Makefile.am:
301 * tests/dbus_api/test_get_folders.c: New test for
302 libmodest_dbus_client_get_folders(). This seems to return an empty list
303 at the moment. That could be the same error that causes the message list
304 to be empty sometimes.
305 This should help with projects.maemo.org bug NB#57740.
307 2007-06-21 Armin Burgmeier <armin@openismus.com>
309 * src/modest-mail-operation.c: Do not call
310 modest_mail_operation_queue_cancel_all() in _cancel() but do instead
311 notify the operation's end after having set the status to CANCELED for
312 the operation queue to listen on. This fixes a deadlock when there
313 were mail operations in the queue during its finalization.
315 * src/modest-singletons.c: Reordered uninitialization of the account
316 manager to happen after the mail operation queue was uninitialized
317 because the mail operation's in the queue might still try to access
318 the account manager (see modest_mail_operation_notify_end()). This
319 fixes a potential crash when terminating the application.
321 2007-06-21 Murray Cumming <murrayc@murrayc.com>
323 * src/modest-search.c:
324 (search_mime_part_and_child_parts): Moved some code here so we
325 can search recursively in child folders.
326 (modest_search_folder): Search in the message as a mime part, instead
327 of just its child mime parts.
328 (read_chunk), (search_mime_part_ogs):
329 Check how many bytes were read, to prevent an endless loop.
330 Searching in message bodies now works. This finishes the fix for
331 projects.maemo.org bug NB#61007.
333 2007-06-20 Murray Cumming <murrayc@murrayc.com>
335 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
336 Add a g_warning when the item is not a folder.
338 * src/modest-ui-dimming-rules.c:
339 (modest_ui_dimming_rules_on_details): Dim the Email/Details menu item
340 when selected item is not a folder (for instance, an account), because
341 the UI spec only talks about folders.
342 I am not sure what the UI spec wants, so this might not totally fix
343 projects.maemo.org bug NB#60794.
345 2007-06-20 Murray Cumming <murrayc@murrayc.com>
347 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
348 (load_from_file): Sort the list. The unsorted list would be more noticeable
349 in non-English locales.
351 * src/maemo/modest-msg-edit-window.c:
352 (modest_msg_edit_window_attach_file): Initialize a variable to avoid a
353 warning and fix the build.
355 * src/maemo/modest-progress-bar-widget.c:
356 (modest_progress_bar_widget_set_progress): Avoid a division by zero, to
357 avoid a g_warning, and probably to avoid a crash.
359 2007-06-20 Murray Cumming <murrayc@murrayc.com>
361 * src/modest-search.c: (modest_search_folder): Check for a GError
362 when calling tny_folder_get_headers(), to show that this is not the cause
365 2007-06-20 Murray Cumming <murrayc@murrayc.com>
367 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
368 Actually set the body query instead of the subject query.
370 * src/modest-search.c: (search_mime_part_ogs),
371 (search_mime_part_strcmp): Remove extra space from the text/* regex,
372 which would probably cause it to fail if we got this far.
374 (modest_search_folder): Use simple #ifdefs instead of the function pointer,
375 to simplify the code.
376 Warn when tny_mime_part_get_parts() returns an empty list, which seems to
377 be causing search-in-body to fail.
379 2007-06-20 Murray Cumming <murrayc@murrayc.com>
381 * libmodest-dbus-client/libmodest-dbus-client.h: Document the folder
383 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url):
384 Better debug message when the folder cannot be found.
385 This should help with fixing projects.maemo.org bug #61287.
386 * src/modest-search.c: (add_hit): Do not leak the furl string.
388 2007-06-20 Murray Cumming <murrayc@murrayc.com>
390 * src/modest-ui-actions.c:
391 (modest_ui_actions_on_folder_selection_changed):
392 Do not special-case TNY_MERGE_FOLDER here, because
393 modest_tny_folder_get_account() already does that. This fixes
394 projects.maemo.org bug NB#60955 (The smtp connections dialog was not
395 shown when the Outbox was selected).
397 2007-06-19 Murray Cumming,,, <murrayc@murrayc.com>
399 * libmodest-dbus-client/libmodest-dbus-client.c:
400 (_dbus_iter_get_string_or_null): Initialize the string variable in
401 case this helps with Dirk's crash.
403 2007-06-19 Murray Cumming <murrayc@murrayc.com>
405 * src/dbus_api/modest-dbus-api.h: Add the attachments enum for send_mail,
406 though it is not implemented yet (this function is maybe not even used),
407 to avoid breaking ABI in future.
408 * libmodest-dbus-client/libmodest-dbus-client.c:
409 (get_attachments_string): Moved some code into this generic function.
410 (libmodest_dbus_client_send_mail): Corrected the documentation. This really
411 sends email. It is maybe not used.
412 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
413 (on_send_mail): Use attachments.
415 * src/widgets/modest-msg-edit-window.h: Improve the documentation.
416 * src/maemo/modest-msg-edit-window.c:
417 (modest_msg_edit_window_attach_file_noninteractive): Convert the URI to
418 a filename before using it, to fix projects.maemo.org bug NB#58233.
420 2007-06-19 Murray Cumming <murrayc@murrayc.com>
422 * src/modest-ui-actions.c: (modest_ui_actions_on_copy):
423 Initialize the continue_download variable to fix the build, and probably
424 to fix randome behaviour.
426 2007-06-18 Armin Burgmeier <armin@openismus.com>
428 * src/modest-tny-send-queue.h:
429 * src/modest-tny-send-queue.c: Keep track of the status of messages in
430 the queue so we can later show it in the UI. Replaced
431 modest_tny_send_queue_msg_is_being_sent() by
432 modest_tny_send_queue_get_msg_status().
434 * src/modest-ui-dimming-rules.c: Adjust for the replaced function.
436 * src/modest-tny-account.c: Changed a cast to gpointer* to one to
437 gpointer. This probably was not harmful, but just to be sure.
439 2007-06-18 Murray Cumming <murrayc@murrayc.com>
441 * src/maemo/modest-platform.c: (modest_platform_activate_uri):
442 Fix the build, but leave the function broken on Bora, because
443 hildon_uri_action_get_service() does not exist.
444 osso_uri_action_get_service() does not exist either, it seems.
446 2007-06-18 Murray Cumming <murrayc@murrayc.com>
448 * src/modest-tny-account.c:
449 (modest_tny_account_new_from_server_account):
450 Uncommented the url debug output again, because it is useful for
451 debugging, as I said in the comment.
453 2007-06-18 Murray Cumming <murrayc@murrayc.com>
455 * configure.ac: Do not require hildon-notify for Maemo Bora. It is not
457 * src/modest-init.c: (modest_init_init_ui): Do not call notify_init()
458 for Mameo Bora, to fix the build.
460 2007-06-17 Johannes Schmid <johannes.schmid@openismus.com>
463 Fixed build with hildon < 0.99
465 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
466 Check if the selected account is busy instead of checking all accounts
468 * src/modest-account-mgr-priv.h:
469 * src/modest-account-mgr.c: (modest_account_mgr_class_init),
470 (modest_account_mgr_init), (compare_account_name),
471 (modest_account_mgr_set_account_busy),
472 (modest_account_mgr_account_is_busy):
473 * src/modest-account-mgr.h:
474 Added busy information to the account manager. It possible to
475 set an account to busy or not busy now.
477 * src/modest-mail-operation.c: (modest_mail_operation_finalize),
478 (modest_mail_operation_update_account),
479 (modest_mail_operation_notify_end):
480 Set the account to busy/not busy depending on the operation state.
482 * src/widgets/modest-account-view.c:
483 (modest_account_view_finalize), (get_last_updated_string),
484 (update_account_view), (on_account_busy_changed), (init_view):
485 Show string "Refreshing..." if the account is currently busy.
487 All this fixes projects.maemo.org bug NB#59711
489 2007-06-14 Armin Burgmeier <armin@openismus.com>
491 * src/widgets/modest-attachments-view.h:
492 * src/widgets/modest-attachments-view.c: Added
493 modest_attachments_view_has_attachments() and fixed coordinate
494 transformation in get_att_view_at_coords(). This fixes attachment
497 * src/widgets/modest-msg-view.c: Make use of
498 modest_attachments_view_has_attachments() to decide whether to show
499 attachments in the header.
501 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
503 * src/maemo/modest-connection-specific-smtp-edit-window.c:
504 (on_change), (on_combo_security_changed),
505 (modest_connection_specific_smtp_edit_window_init),
506 (modest_connection_specific_smtp_edit_window_set_connection),
507 (modest_connection_specific_smtp_edit_window_is_dirty):
508 * src/maemo/modest-connection-specific-smtp-edit-window.h:
509 * src/maemo/modest-connection-specific-smtp-window.c:
512 Show an comfirmation dialog for the smpt-edit-window if there are
513 unsaved changes and the user hits cancel.
514 (projects.maemo.org bug NB#60479)
516 2007-06-14 Armin Burgmeier <armin@openismus.com>
518 * src/maemo/easysetup/modest-easysetup-wizard.c:
519 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
520 address" info in banner instead of node, and select all the text as
521 per UI spec. This fixes projects.maemo.org bug NB#60550.
523 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
525 reviewed by: <delete if not using a buddy>
527 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
528 * src/modest-ui-actions.c: (folder_refreshed_cb):
530 2007-06-14 Murray Cumming <murrayc@murrayc.com>
532 * src/widgets/modest-folder-view.c: (filter_row):
533 Explictly filter out the per-account outbox accounts. I don't know why
534 these only sometimes show up, but now they should never show up in the UI.
535 This should fix projects.maemo.org bug NB#60160.
537 2007-06-14 Murray Cumming <murrayc@murrayc.com>
539 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
540 when the toolbar does not exist yet.
541 * src/modest-widget-memory.c: (save_settings_header_view):
542 Added g_warnings() to help us to discover when we are trying to set
543 an empty columns list in gconf.
545 2007-06-14 Murray Cumming <murrayc@murrayc.com>
549 Added modest_init_get_default_header_view_column_ids().
551 * src/modest-widget-memory.c: (restore_settings_header_view):
552 Use the new function to get defaults, if the gconf key is empty,
553 instead of not creating any columns. This seems to fix the
554 empty right-hand pane problems.
556 * src/widgets/modest-header-view.h: Improved documentation.
558 2007-06-13 Murray Cumming <murrayc@murrayc.com>
560 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
561 Revert the use of the display name as the account name, because this
562 is generally wrong and would break the code that follows.
564 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
566 * src/maemo/easysetup/modest-easysetup-wizard.c:
567 (check_for_supported_auth_methods), (on_before_next),
570 More correct fix for projects.maemo.org bug NB# 58991
571 Do not longer accept AUTH_PASSWORD as secure method and choose
572 correct method when creating the account.
574 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
576 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
577 Fixed projects.maemo.org bug NB# 58991
579 2007-06-13 Murray Cumming <murrayc@murrayc.com>
581 * src/modest-init.c: (modest_init_init_core),
582 (modest_init_local_folders): Fixed compilation errors.
584 2007-06-13 Murray Cumming <murrayc@murrayc.com>
586 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
587 Remove unnecessary lib/include, though it is good in principle when needed.
589 * src/modest-init.c: (modest_init_one_local_folder),
590 (modest_init_local_folders):
591 * src/modest-init.h: Initialize the .modest library for memory cards,
592 instead of just doing nothing for them. This should allow us to create
593 folders there, fixing projects.maemo.org bug NB#59297.
595 2007-06-13 Murray Cumming <murrayc@murrayc.com>
597 * libmodest-dbus-client/libmodest-dbus-client.c:
598 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
599 (libmodest_dbus_client_compose_mail),
600 (libmodest_dbus_client_open_message),
601 (libmodest_dbus_client_send_and_receive),
602 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
604 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
605 (on_idle_open_message), (modest_dbus_req_handler),
606 (search_result_to_message), (modest_dbus_req_filter):
607 * src/modest-search.c: (add_hit), (modest_search_folder),
608 (modest_search_all_accounts): Improved debug messages.
610 * tests/dbus_api/test_open_message.c: (main): Improved comments.
612 * src/modest-tny-account-store.c:
613 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
616 2007-06-13 Murray Cumming <murrayc@murrayc.com>
619 2007-06-12 Murray Cumming <murrayc@murrayc.com>
621 * src/modest-tny-account-store.c: (get_server_accounts):
622 Call modest_tny_local_folders_account_add_merged_outbox_folders()
623 even when there are no accounts, so that the Outbox folder is always
624 visible. This fixes projects.maemo.org bug NB#60158.
626 2007-06-12 Murray Cumming <murrayc@murrayc.com>
628 * src/maemo/modest-main-window.c: (create_details_widget):
629 Use the mcen_va_never logical ID.
631 2007-06-12 Murray Cumming <murrayc@murrayc.com>
633 * src/dbus_api/modest-dbus-api.h:
634 * src/dbus_api/modest-dbus-callbacks.c:
635 (on_idle_open_default_inbox), (on_open_default_inbox),
636 (modest_dbus_req_handler):
637 Added a new OpenDefaultInbox method.
639 * libmodest-dbus-client/libmodest-dbus-client.h:
640 * libmodest-dbus-client/libmodest-dbus-client.c:
641 Added libmodest_dbus_client_open_default_inbox() to call the new
642 dbus method. This should be useful to projects.maemo.org bug NB#57214,
643 though it should maybe be used by a new osso-email-interface function.
645 * tests/dbus_api/Makefile.am:
646 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
649 2007-06-12 Murray Cumming <murrayc@murrayc.com>
651 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
652 NULL, so that the signals get all the keys. This should not actually
653 change any behaviour because we currently update everything when anything
656 2007-06-12 Murray Cumming <murrayc@murrayc.com>
658 * src/widgets/modest-folder-view.c: (text_cell_data),
659 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
660 (find_inbox_iter): If tinymail tells us that the folder is
661 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
662 This causes the inbox to be selected at startup, fixing part of
663 projects.maemo.org bug NB#56305.
665 * src/modest-ui-dimming-rules.c:
666 (modest_ui_dimming_rules_on_tools_smtp_servers):
667 * src/modest-ui-dimming-rules.h: Added a callback function to dim
668 the SMTP servers menu item.
669 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
670 that the SMTP Servers menu item is dimmed when there are no accounts,
671 as a future version of the UI spec will require. This fixes
672 projects.maemo.org bug NB#56305.
674 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
676 * src/maemo/modest-maemo-utils.c:
677 (modest_maemo_utils_get_supported_secure_authentication_methods):
678 Added label to dialog instead of unreadable title
680 * src/maemo/modest-main-window.c: (sync_accounts_cb),
681 (modest_main_window_new):
682 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
685 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
686 * src/modest-account-mgr.h:
687 Added method to avoid code duplication
689 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
690 (modest_ui_actions_on_send_receive):
691 Use modest_account_mgr_has_accounts
693 2007-06-11 Murray Cumming <murrayc@murrayc.com>
695 * src/maemo/easysetup/modest-presets.c:
696 (modest_presets_get_info_server_security): Do not report secure auth
698 * src/modest-protocol-info.c: Use the defines for the gconf key names
699 for secure authentication. This was not working because we were writing
700 Password and reading password, and the check was case sensitive.
701 With this, gmail now works for receiving and sending when created via
704 2007-06-11 Murray Cumming <murrayc@murrayc.com>
706 * src/maemo/easysetup/modest-presets.c:
707 (modest_presets_get_info_server_security): Correct the key name for
708 SecureSmtp, because it seems to be case-sensitive.
709 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
710 Do not try to get the 0th notebook page if there are 0 pages, to
713 2007-06-11 Murray Cumming <murrayc@murrayc.com>
715 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
716 Prevent use of the new notification feature for now, because it currently
717 shows one dialog for each new email, which is annoying.
719 2007-06-11 Murray Cumming <murrayc@murrayc.com>
721 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
722 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
723 when no country was selected, so that we show the global ones.
724 * src/maemo/easysetup/modest-presets.c:
725 (modest_presets_get_providers): Return only the global providers, not
726 all providers when mmc=0 was requested.
728 2007-06-11 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
731 (easysetup_provider_combo_box_fill): Remove debug code that showed the
732 provider ID in the combo.
734 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
735 Do not show the page numbers, because it would be confusing when we add
736 the 2 extra pages for the custom setup, when the user chooses the "Other"
737 provider. This fixes projects.maemo.org bug NB#59028
739 * src/modest-init.c: (modest_init_init_core),
740 (modest_init_local_folders):
742 * src/modest-tny-account.c:
743 (modest_tny_account_new_for_local_folders): Do not create default folders
744 for the memory card. This should fix projects.maemo.org bug NB#59328.
746 2007-06-11 Murray Cumming <murrayc@murrayc.com>
748 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
749 Free the changed_conf_keys string items. They are already freed in the
750 idle handler if that runs first.
752 2007-06-11 Murray Cumming <murrayc@murrayc.com>
754 * src/modest-ui-actions.c:
755 (modest_ui_actions_on_password_requested): Check that the server name
756 is not NULL, because I just saw a password dialog with (null) as the
759 * src/modest-tny-folder.[h|c]: Added
760 modest_tny_folder_is_memory_card_folder().
761 * src/modest-ui-dimming-rules.c:
762 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
763 menu item for memory cards, as per the UI spec (section 7.4). This should
764 fix projects.maemo.org bug NB#59297.
766 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
768 * src/maemo/modest-main-window.c: (sync_accounts_cb):
769 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
770 is another problem with the code, see Murray's comment at line 772)
772 2007-06-08 Murray Cumming <murrayc@murrayc.com>
774 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
775 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
776 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
777 (load_from_file), (easysetup_country_combo_box_init),
778 (easysetup_country_combo_box_get_active_country_ids),
779 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
780 instead of just one ID, to avoid duplicate country names in the UI.
782 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
783 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
784 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
785 a single ID, avoiding duplicate providers.
786 * src/maemo/easysetup/modest-easysetup-wizard.c:
787 (on_combo_account_country): Adapt to use a list.
789 2007-06-08 Murray Cumming <murrayc@murrayc.com>
791 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
792 keys changed in the last X seconds.
794 * src/modest-account-mgr.h:
795 * src/modest-account-mgr.c: (on_timeout_notify_changes),
796 (on_key_change), (modest_account_mgr_class_init),
797 (modest_account_mgr_init), (modest_account_mgr_finalize):
798 As the keys are changed, save them in a GSList* and signal that GSList*
799 further every X seconds, to batch changes, to allow us to do just one
800 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
801 bug NB#56941 and other (UI-blocking) delays when changing account settings.
803 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
804 changed signal signature.
806 * src/modest-conf.c: (modest_conf_set_list),
807 (modest_conf_on_change): Reenable notification.
809 (modest_conf_maemo_fake_on_change): Comment out the hack that
810 notified immediately instead of asynchronously.
812 * src/widgets/modest-account-view.h:
813 * src/widgets/modest-account-view.c:
814 (update_account_view): Select the previously-selected account ID,
815 if possible. This fixes projects.maemo.org bug NB#56933.
817 (on_account_changed), (on_account_removed),
818 (modest_account_view_select_account):
820 Remove the block/unblock functions
821 because they were not useful.
823 * src/maemo/modest-account-view-window.c:
824 (on_delete_button_clicked), (on_edit_button_clicked),
825 (on_new_button_clicked): Remove the use of the non-working block/unblock.
827 2007-06-08 Murray Cumming <murrayc@murrayc.com>
829 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
830 Improve the error dialog to show Incorrect Account Settings, which seems
831 clearer, and say that the internal error message (to be removed from the
832 dialog later) is often misleading.
833 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
835 * src/modest-tny-account.c:
836 (modest_tny_account_new_from_server_account): Uncomment the printf of the
837 URL because this is so useful for debugging on the device.
839 * src/widgets/modest-serversecurity-combo-box.c:
840 (modest_serversecurity_combo_box_fill): Correct a logical ID.
842 2007-06-08 Murray Cumming <murrayc@murrayc.com>
844 * src/modest-mail-operation.c:
845 (modest_mail_operation_send_new_mail):
846 Added a comment about a nasty but apparently harmless message. Details
847 added to the wiki g_warnings() page.
849 2007-06-08 Murray Cumming <murrayc@murrayc.com>
851 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
852 (modest_tny_send_queue_class_init):
853 Do not use the priv struct because it is empty, to avoid g_warnings
854 about a non-existant priv struct.
856 * src/modest-tny-account-store.c:
857 (modest_tny_account_store_get_server_account),
858 (modest_tny_account_store_get_transport_account_for_open_connection
859 ): Do not try to get transport server accounts for local folders,
860 because they don't have any. This avoids a g_warning().
862 * src/maemo/modest-main-window.c:
863 (modest_main_window_notify_send_receive_initied),
864 (on_configuration_key_changed):
865 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
867 * src/modest-mail-operation.c:
868 (modest_mail_operation_update_account):
869 * src/modest-tny-account-store.h:
870 * src/modest-tny-account.c:
871 (modest_tny_account_get_special_folder),
872 (modest_tny_account_new_for_local_folders),
873 (modest_tny_account_new_for_per_account_local_outbox_folder):
874 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
875 * src/modest-tny-local-folders-account.c:
876 (add_account_folders_to_merged_folder):
877 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
878 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
879 (modest_ui_actions_on_send):
880 * src/widgets/modest-folder-view.c: (update_model):
881 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
882 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
883 modest_tny_account_store_get_tny_account_by_account() to
884 modest_tny_account_store_get_server_account() to make the code clearer.
886 2007-06-07 Marcus Bauer <marcusb@openismus.com>
888 * src/dbus_api/modest-dbus-api.h:
889 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
890 * src/maemo/modest-msg-edit-window.c:
891 (modest_msg_edit_window_attach_file_noninteractive):
892 added g_warning in case the file to be attached does not exist
893 * tests/dbus_api/test_compose_mail.c: (main):
894 removed obsolete comment, added generic files as test case
896 2007-06-07 Murray Cumming <murrayc@murrayc.com>
898 * src/modest-tny-account-store.c: (get_server_accounts):
899 Create the local folders account only once, not once for each outbox, and
900 not only when there are some outboxes.
902 2007-06-07 Murray Cumming <murrayc@murrayc.com>
904 * src/widgets/modest-folder-view.c: (update_model): Comment out some
905 code that is causing a crash at startup. Sergio says that he is fixing this.
907 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
909 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
910 * src/maemo/modest-account-settings-dialog.c:
911 (create_page_outgoing),
912 (modest_account_settings_dialog_set_account_name),
913 (save_configuration):
914 - Fixed handling of the "Use secure authentication" toggle to comply with
915 the ui specification. See also projects.maemo.org bug NB#58400
917 - Restore the Secure connection setting combo correctly when loading
920 * src/maemo/modest-maemo-utils.c:
921 (on_camel_account_get_supported_secure_authentication),
922 (modest_maemo_utils_get_supported_secure_authentication_methods):
923 Fixed a crasher if operation is canceled
925 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
926 (modest_protocol_info_auth_is_secure):
927 * src/modest-protocol-info.h:
929 Added two new methods to determine if a protocol/auth method is secure/encrypted in
930 the sense of the "Use secure authentication" toggle.
932 2007-06-07 Murray Cumming <murrayc@murrayc.com>
934 * src/modest-tny-account-store.h:
935 * src/modest-tny-account-store.c:
936 Added modest_tny_account_store_get_local_folders_account().
938 * src/modest-tny-folder.h:
939 * src/modest-tny-folder.c:
940 (modest_tny_folder_get_account):
941 Added this replacement for tny_folder_get_account() which returns
942 the local-folders account for TnyMergeFolders, to avoid the
943 warning about the unimplemented get_account_func() vfunc().
945 (modest_tny_folder_get_rules),
946 * src/modest-ui-actions.c:
947 (modest_ui_actions_on_folder_selection_changed):
948 * src/modest-mail-operation.c:
949 (modest_mail_operation_remove_folder),
950 (modest_mail_operation_xfer_folder),
951 (modest_mail_operation_rename_folder),
952 (modest_mail_operation_get_msg),
953 (modest_mail_operation_get_msgs_full),
954 (modest_mail_operation_remove_msg),
955 (modest_mail_operation_xfer_msgs),
956 (modest_mail_operation_refresh_folder):
957 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
959 2007-06-07 Murray Cumming <murrayc@murrayc.com>
961 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
962 (modest_server_account_set_security):
963 * src/modest-defs.h: Add comments explaining that our
964 UI spec means TLS when it says Normal, so these do not look like errors.
966 * src/modest-tny-account.c:
967 (modest_tny_account_new_from_server_account): Use the new tinymail
968 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
969 for TLS. This should fix projects.maemo.org bug NB#58460.
971 2007-06-06 Murray Cumming <murrayc@murrayc.com>
973 * src/maemo/easysetup/modest-easysetup-wizard.c:
974 (create_account): Correct the position of the gconf sanity check warning.
975 (on_button_edit_advanced_settings): Show the dialog immediately, instead
976 of using the g_idle_add() hack, because this does not seem to be necessary
977 on osso 1.1. It might even work on Maemo Bora if the problems were actually
978 caused by something other than maemo's gconf.
979 This fixes projects.maemo.org bug #59022.
981 2007-06-06 Murray Cumming <murrayc@murrayc.com>
983 * src/modest-account-mgr-helpers.c:
984 (modest_account_mgr_get_default_account): Do not check that the account
985 exists if there is no default account (NULL), to fix a runtime warning.
987 2007-06-06 Murray Cumming <murrayc@murrayc.com>
989 * src/widgets/modest-folder-view.c: (update_model):
990 Do not unref the treemodel before we have finished with it.
991 This prevents a valgrind warning and an occasional crash at startup.
993 2007-06-06 Marcus Bauer <marcusb@openismus.com>
995 * libmodest-dbus-client/libmodest-dbus-client.h:
996 added libmodest_dbus_client_compose_mail()
997 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
999 added functions needed for SendAsMail() functionality
1000 * src/maemo/modest-msg-edit-window.c:
1001 (modest_msg_edit_window_attach_file_noninteractive):
1002 non interactively attaching files to message edit window
1003 * src/widgets/modest-msg-edit-window.h:
1004 * tests/dbus_api/Makefile.am:
1005 added test_compose_mail.c
1006 * tests/dbus_api/test_compose_mail.c: (main):
1008 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1010 * src/modest-account-view.c:
1011 Fixed bug projects.maemo.org bug NB#59307
1013 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
1015 * src/maemo/easysetup/modest-easysetup-wizard.c:
1016 (get_serverport_incoming), (on_before_next), (create_account):
1017 * src/maemo/modest-account-settings-dialog.c:
1018 (modest_account_settings_dialog_set_account_name):
1019 * src/maemo/modest-maemo-utils.c:
1020 (on_camel_account_get_supported_secure_authentication_status),
1021 (on_camel_account_get_supported_secure_authentication),
1022 (on_secure_auth_cancel),
1023 (modest_maemo_utils_get_supported_secure_authentication_methods):
1025 Implemented security authentication for settings and easysetup.
1027 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1029 * src/maemo/modest-main-window.c: (create_details_widget):
1030 Show the total size for memory card accounts too, instead of showing
1031 the name again. Fixes bug projects.maemo.org bug NB#59307.
1033 2007-06-05 Murray Cumming <murrayc@murrayc.com>
1036 * src/modest-tny-simple-folder-store.c:
1037 * src/modest-tny-simple-folder-store.h: Removed.
1039 * src/modest-tny-local-folders-account.h
1040 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
1041 for the local-folders maildir, with an extra TnyMergedFolder containing
1042 the folders of the per-account outbox store accounts.
1043 * src/modest-tny-account-store.c: (get_server_accounts):
1044 Add the outboxes to the special local folders account after creating it.
1046 * src/modest-tny-account.c:
1047 (modest_tny_account_new_for_local_folders): Create the derived
1048 account when creating the main local-folders account.
1050 * src/maemo/modest-main-window.c: (create_details_widget),
1051 (modest_main_window_set_contents_style):
1052 Adapted to the use of the derived account instead of the folder store.
1054 * src/modest-ui-actions.c:
1055 (modest_ui_actions_on_folder_selection_changed):
1056 * src/modest-ui-dimming-rules.c:
1057 (modest_ui_dimming_rules_on_new_folder):
1058 * src/widgets/modest-folder-view.c: (text_cell_data),
1059 (icon_cell_data), (filter_row), (update_model),
1060 (get_cmp_rows_type_pos):
1063 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
1064 Do not get the priv struct, because no priv struct has been set,
1065 to avoid a runtime warning.
1067 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
1068 #ifelse with #else, to fix a warning, to fix the build.
1071 2007-06-05 Christian Kellner <ckellner@openismus.com>
1073 * libmodest-dbus-client/libmodest-dbus-client.c:
1074 Fix small typo in doc (why do you always see them
1075 AFTER committing stuff?)
1078 2007-06-05 Christian Kellner <ckellner@openismus.com>
1080 * libmodest-dbus-client/libmodest-dbus-client.c:
1081 (libmodest_dbus_client_search):
1082 Initialize hit list with NULL. Also set folder list
1083 to "" if NULL was supplied.
1086 2007-06-03 Christian Kellner <ckellner@openismus.com>
1088 * libmodest-dbus-client/libmodest-dbus-client.c:
1089 (modest_search_hit_list_free):
1090 Make it save to call it with NULL.
1092 * src/dbus_api/modest-dbus-callbacks.c:
1093 * src/modest-search.c:
1094 Return full ModestSearchHits as the search result list not TnyHeader
1095 since can't be around withouth the correspoding TnyFolder.
1097 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1099 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
1100 Added currently commented code to check for secure auth
1102 * src/maemo/modest-account-settings-dialog.c: (on_response),
1103 (save_configuration), (show_ok):
1104 Fixed projects.maemo.org bugs NB #59248 and #59251
1106 * src/maemo/modest-maemo-utils.c:
1107 (on_camel_account_get_supported_secure_authentication_status),
1108 (on_camel_account_get_supported_secure_authentication),
1109 (modest_maemo_utils_get_supported_secure_authentication_methods):
1110 * src/maemo/modest-maemo-utils.h:
1111 Moved get_supported_secure_authentication() method here to be able
1112 to use it from easysetup wizard.
1114 * src/modest-pair.c: (on_pair_compare_as_string):
1115 Should compare string with first part of pair and not
1116 strcmp pairs which will crash.
1118 * src/modest-protocol-info.c:
1119 (modest_protocol_info_protocol_is_store):
1120 * src/modest-protocol-info.h:
1121 Added modest_protocol_info_get_auth_protocol_name()
1123 2007-06-03 Armin Burgmeier <armin@openismus.com>
1125 * src/modest-mail-operation.c:
1126 (modest_mail_operation_get_msgs_full): Set priv->account also when
1127 only retrieving a single message. This avoids a crash when canceling
1130 (modest_mail_operation_notify_end): Do not explicitely remove the
1131 operation from the queue but only emit the progress_changed signal.
1132 The queue itself listens to that signal to remove the operation when
1133 it is finished. This reduces coupling and removes a potential deadlock
1134 when modest_mail_operation_notify_end() is called from the queue
1135 itself. If that is a problem performance-wise, I would suggest to
1136 implement a status-changed signal or something.
1138 * src/modest-mail-operation-queue.c: Make sure to never call a
1139 function from another file while the queue is locked. This (hopefully)
1140 fixes another deadlock when exiting the application while retrieving
1143 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
1145 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
1146 Fixed build if libogs is not available
1148 2007-06-03 Christian Kellner <ckellner@openismus.com>
1150 * libmodest-dbus-client/libmodest-dbus-client.h:
1151 * libmodest-dbus-client/libmodest-dbus-client.c:
1152 (libmodest_dbus_client_delete_message):
1153 Implement deletion of messages (Client side).
1155 (modest_search_hit_free),
1156 (modest_search_hit_list_free):
1157 Utility functions to free the result hits.
1159 * src/dbus_api/modest-dbus-api.h:
1160 * src/dbus_api/modest-dbus-callbacks.c:
1161 (on_delete_message),
1162 (modest_dbus_req_handler):
1163 Implement deletion of messages (Server side).
1165 * tests/dbus_api/test_search.c: (main):
1168 * tests/dbus_api/Makefile.am:
1169 * tests/dbus_api/test_delete_message:
1170 Add little test for the message deletion logic
1172 2007-06-03 Armin Burgmeier <armin@openismus.com>
1174 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
1175 when the operation queue was not empty. projects.maemo.org bug
1178 2007-06-03 Armin Burgmeier <armin@openismus.com>
1180 * src/widgets/modest-account-view.c
1181 (on_account_default_toggled): Toggle default account column
1182 explicitely instead of waiting for gconf notification (which is
1183 currently ignored). This should fix projects.maemo.org bug NB#56910
1184 for now. It should probably be removed when gconf notifications are
1187 2007-06-03 Christian Kellner <ckellner@openismus.com>
1189 * libmodest-dbus-client/libmodest-dbus-client.c:
1190 Removed debugging spew.
1192 * src/dbus_api/modest-dbus-callbacks.c:
1193 Added debugging info.
1195 * src/modest-search.c:
1196 (modest_search_all_accounts):
1197 Use tny_account_store_get_accounts () on the account store
1198 to get all accounts which is the way to get all accounts.
1200 * tests/dbus_api/test_search.c: (main):
1201 Make it possible to supply the search term on the command line.
1203 2007-06-03 Christian Kellner <ckellner@openismus.com>
1205 * libmodest-dbus-client/libmodest-dbus-client.c:
1206 * libmodest-dbus-client/libmodest-dbus-client.h:
1207 Implement searching for mesages over raw dbus. (Client side)
1209 * src/dbus_api/Makefile.am:
1210 * src/dbus_api/modest-dbus-api.h:
1211 * src/dbus_api/modest-dbus-callbacks.c:
1212 * src/dbus_api/modest-dbus-callbacks.h:
1213 Search framework (Server side). Also implement on_idle_open_message().
1215 * src/maemo/modest-platform.c: (modest_platform_init):
1216 Prepare for raw dbus/osso rpc interaction.
1218 * src/modest-search.h:
1219 Changed minsize from unspecific guint to guint32.
1221 * src/modest-search.c:
1223 Added strange hack which magically made tnymail work.
1225 (modest_search_folder),
1226 (modest_search_account),
1227 (modest_search_all_accounts):
1228 Implement helper functions to search all accounts, specific account
1231 * tests/dbus_api/Makefile.am:
1232 * tests/dbus_api/test_open_message.c:
1233 Read url to open from commandline.
1235 * tests/dbus_api/test_search.c:
1236 Implement small test for dbus search stuff
1238 2007-06-02 Armin Burgmeier <armin@openismus.com>
1240 * src/maemo/modest-account-settings-dialog.c: Changed window title to
1241 include account type and account title. This fixes projects.maemo.org
1244 * src/maemo/modest-account-view-window.c: Set a title for the window.
1246 2007-06-02 Armin Burgmeier <armin@openismus.com>
1248 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
1249 incoming and outgoing server name based on email address and server
1250 types as long as the names have not been edited manually. This fixes
1251 projects.maemo.org bug NB#58671.
1253 2007-06-02 Armin Burgmeier <armin@openismus.com>
1255 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
1256 server type cannot be changed in future to the incoming details page
1257 when creating an account. This fixes projects.maemo.org bug NB#59029.
1259 2007-06-02 Armin Burgmeier <armin@openismus.com>
1261 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
1262 and assigned max width chars so that they wrap instead of being
1263 truncated. Fixes projects.maemo.org bug NB#56126.
1265 2007-06-02 Armin Burgmeier <armin@openismus.com>
1267 * src/maemo/modest-connection-specific-smtp-window.c: Add an
1268 introductory note to the connection specific smtp servers dialog, as
1269 section 8.12 of the email UI specification requires. This fixes
1270 projects.maemo.org bug NB#59212.
1272 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1274 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
1275 Check for running mail operations, and offer to cancel them, as per the UI
1276 spec. This fixes projects.maemo.org bug NB#59041 .
1277 However, I suspect that tinymail may still use the network connection
1278 in ways that we cannot detect or cancel. But it should at least adapt to
1279 changes fairly well.
1281 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1283 * src/modest-tny-account-store.c: (recreate_all_accounts),
1284 (get_cached_accounts), (get_server_accounts): Do more sensible
1285 ref-counting of the temporarily-cached outbox accounts list. This seems
1286 to fix a crash when entering the password when the password was wrong.
1288 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1290 * src/gnome/modest-main-window.c: (connect_signals):
1291 * src/modest-tny-account-store.c: (get_password),
1292 (modest_tny_account_store_alert): Added comments and clues and
1293 commented-out code about how we currently fail to deal with connection
1294 errors and wrong passwords, and how we should.
1296 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1298 * src/widgets/modest-retrieve-combo-box.c:
1299 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
1300 This fixes projects.maemo.org bug NB#58472 .
1302 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1304 * src/maemo/easysetup/modest-easysetup-wizard.c:
1305 (create_page_complete_easysetup):
1306 (create_page_complete_custom): Correct the last commit,
1307 putting the correct sentences in the correct pages.
1309 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1311 * src/maemo/easysetup/modest-easysetup-wizard.c:
1312 (create_page_complete_custom): Show the second sentence of text
1313 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
1316 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1318 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1319 Set the leave-on-server conf key by default. This fixes
1320 projects.maemo.org bug NB#59258 .
1322 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1324 * src/maemo/modest-account-view-window.c:
1325 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
1326 logical ID for the confirmation messages. Fixed projects.maemo.org bug
1329 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1331 * src/maemo/easysetup/modest-easysetup-wizard.c:
1332 (create_caption_new_with_asterisk):
1333 * src/maemo/modest-account-settings-dialog.c:
1334 (create_caption_new_with_asterisk):
1335 Uncomment the code to add the asterisk, because they are no longer in the
1336 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
1337 (update_incoming_server_title): Add an asterisk here too.
1339 2007-06-01 Murray Cumming <murrayc@murrayc.com>
1341 * src/maemo/modest-maemo-global-settings-dialog.c:
1342 (current_connection): Check that we are even connected before trying to
1343 get the current connection name, to prevent a warning.
1345 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1346 Change the comments because tny_maemo_conic_device_connect() is now meant to
1348 * src/modest-mail-operation.c:
1349 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
1350 make sure we have a connection and fail if we can't connect.
1352 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1354 * src/maemo/modest-main-window.c:
1355 (on_account_store_connecting_finished): Do not try to get the
1356 connection ID if we are not really connected. I am surprised that
1357 this signal handler is called when we are not connected.
1359 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1361 * src/modest-error.h:
1362 * src/modest-ui-actions.c:
1363 (modest_ui_actions_get_msgs_full_error_handler):
1364 Renamed an enum, added comments, added an enum
1365 for retrieve-limit errors.
1367 * src/modest-mail-operation.c: (foreach_add_item),
1368 (internal_folder_observer_update), (update_account_thread),
1369 (modest_mail_operation_get_msgs_full):
1370 (modest_mail_operation_update_account),
1371 Added comments about how this works, and some code that should
1372 (but does not) check the retrieve-limit. See the TODO comment.
1374 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1376 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
1377 Initialize help_id to fix the build. Warnings are good.
1379 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1381 * src/widgets/modest-hbox-cell-renderer.c:
1382 (modest_hbox_cell_renderer_append):
1383 * src/widgets/modest-vbox-cell-renderer.c:
1384 (modest_vbox_cell_renderer_append):
1385 Fix the last commit by doing an extra ref.
1387 2007-05-31 Murray Cumming <murrayc@murrayc.com>
1389 * src/widgets/modest-hbox-cell-renderer.c:
1390 (modest_hbox_cell_renderer_append):
1391 * src/widgets/modest-vbox-cell-renderer.c:
1392 (modest_vbox_cell_renderer_append):
1393 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
1394 to fix the build with Maemo Bora.
1395 However, there seems to be a remaining crash, probably due to reference
1398 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1400 * src/modest-tny-account.c:
1401 (modest_tny_account_new_for_local_folders):
1402 Use hildon_file_system_info_async_new() to get a better name for
1403 the memory card account, setting it as the account name.
1404 The timing seems to work, but this is probably
1405 not the best place to do this. See the TODO comment.
1406 * src/maemo/modest-main-window.c: (create_details_widget):
1407 * src/widgets/modest-folder-view.c: (text_cell_data):
1408 Use the tny account name instead of hardcoding a name.
1410 2007-05-30 Christian Kellner <ckellner@openismus.com>
1412 * src/modest-search.c: (modest_search):
1413 Correctly set part_search_func even if we have already parsed
1414 the query and thus a valid OgsTextSearcher object.
1416 2007-05-30 Christian Kellner <ckellner@openismus.com>
1419 Search and check for libogs.
1422 Incooparte the ogs build env.
1424 * src/modest-mime-part-search-stream.c:
1425 * src/modest-mime-part-search-stream.h:
1426 Removed since we do the real searching now in modest-search.c.
1428 * src/modest-search.c:
1429 * src/modest-search.h:
1430 Implement support for ogs. We use that if available and requested
1431 and fall back to modest_text_utils_utf8_strcmp (). The search logic
1432 should now handle the corner case when the search term is spread
1433 across multiple reads.
1434 Also the logic in modest_search () was corrected to search all
1435 requested fields until one is found.
1437 2007-05-30 Murray Cumming <murrayc@murrayc.com>
1439 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
1441 * src/modest-init.h:
1442 * src/modest-init.c: Made modest_init_local_folders() take a
1443 path and be public so we can iniitialize maildir folders on
1446 * src/modest-local-folder-info.h:
1447 * src/modest-local-folder-info.c:
1448 (modest_local_folder_info_get_maildir_path): Add a path parameter.
1450 * src/modest-tny-account.c:
1451 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
1452 still means the standard local-folders path on the local volume.
1454 * src/modest-tny-account-store.c:
1455 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
1456 signal so we can detect mount/unmount of the MMC1 card, and do an update of
1457 all accounts when that happens.
1458 (get_server_accounts): If the MMC1 card is mounted, create a store account for
1459 this too, so it shows up in the treeview.
1461 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1463 * src/maemo/modest-maemo-global-settings-dialog.c:
1464 (current_connection):
1465 * src/widgets/modest-global-settings-dialog.c:
1466 (current_connection_default):
1467 Use the enum values instead of 0, 1 and -1,
1468 to make the code clearer.
1470 * src/modest-account-mgr-helpers.c:
1471 (modest_account_mgr_get_connection_specific_smtp): Make this code
1474 * src/modest-runtime.h:
1475 * src/modest-runtime.c:
1476 Added modest_runtime_remove_all_send_queues().
1477 * src/maemo/modest-main-window.c:
1478 (on_account_store_connecting_finished): Recreate the send queues,
1479 using the appropriate transport accounts for this new connection.
1480 Some futher adapting might be needed if the old send queues are not
1481 automatically stopped at this point.
1483 * src/modest-tny-account-store.c: (get_server_accounts):
1484 Create the connection-specific transport accounts, so that they can
1485 be found later by their ID.
1487 * src/modest-tny-account.h:
1488 * src/modest-tny-account.c:
1489 Added modest_tny_account_new_from_server_account_name().
1490 modest_tny_account_new_from_server_account(): Do not create the
1491 send queues here, because they will be
1492 recreated anyway when the connection changes for the first time.
1494 2007-05-28 Murray Cumming <murrayc@murrayc.com>
1496 * src/modest-local-folder-info.h:
1497 * src/modest-local-folder-info.c:
1498 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1499 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1500 tbox_folder): Take a modest account name instead of a server TnyAccount,
1501 so we can have per-modest-account rather than per-transport-account
1503 We must make sure that we change or recreate the exisitng send queues
1504 when the connection changes for connection-specific transport accounts.
1506 * src/modest-tny-account-store.c:
1507 (create_per_account_local_outbox_folders): Create outboxed per modest
1508 account, not per transport account.
1510 * src/modest-tny-account.h:
1511 * src/modest-tny-account.c:
1512 (modest_tny_account_get_special_folder): For outboxes, get the
1513 parent modest account name. The account is ignored for other folders.
1514 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1515 modest account name rather than a server TnyAccount.
1517 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1519 * src/modest-tny-account.c:
1520 (modest_tny_account_new_from_server_account):
1521 Call modest_runtime_get_send_queue() immediately after creating transport
1522 accounts, so that they start trying to send email from the outbox as soon
1523 as possible at startup. This is probably what we want.
1525 * src/modest-mail-operation.c: (update_account_thread):
1526 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1527 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1528 * src/modest-tny-send-queue.h:
1529 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1530 (modest_ui_actions_on_send):
1531 Added comments about how sending works, though it needs some more work.
1533 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1535 * src/modest-tny-account.c:
1536 (modest_tny_account_get_special_folder): Add TODO because this fails when
1537 the network is busy.
1538 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1539 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1540 Do not try to show this window when there is no active account. The UI
1541 specs does not tell us what to do in this case.
1543 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1547 * src/maemo/Makefile.am:
1548 * src/widgets/Makefile.am: Some dist fixes.
1550 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1552 * src/maemo/modest-connection-specific-smtp-window.c:
1553 (on_button_edit): Make the code clearer, to prevent a double free.
1555 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1557 * src/maemo/modest-account-settings-dialog.c:
1558 (modest_account_settings_dialog_set_account_name),
1559 Check the connection-specific smtp servers checkbox if there are any.
1561 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1562 (modest_connection_specific_smtp_edit_window_init):
1563 Start with a suitable port number.
1565 * src/modest-account-mgr-helpers.h:
1566 * src/modest-account-mgr-helpers.c: Added
1567 modest_account_mgr_get_has_connection_specific_smtp().
1569 (modest_account_mgr_set_connection_specific_smtp),
1570 (modest_account_mgr_remove_connection_specific_smtp),
1571 (modest_account_mgr_get_has_connection_specific_smtp),
1572 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1573 connection-specific smtp server accounts in the account, rather than
1574 the server account conf dir.
1576 This fixes bug projects.maemo.org bug NB#58263 .
1578 * src/modest-tny-account-store.c:
1579 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1580 if there are no server accounts yet, to prevent an infinite loop when there
1581 are no accounts. Document that one must be called before the other.
1583 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1585 * src/modest-account-mgr-helpers.c:
1586 (modest_account_mgr_get_default_account): Make sure that at least
1587 one account is always the default, if there are any enabled accounts.
1588 This is just a sanity check that shouldn't be necessary.
1590 * src/modest-account-mgr-priv.c:
1591 (_modest_account_mgr_account_from_key): Unescape the conf key to
1592 get the real account name. For instance, this is an issue if a space
1593 was in the account name, which can happen because the account name
1594 is generated from the display name.
1595 (_modest_account_mgr_get_account_keyname): Always escape the
1597 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1598 Unescape the conf keys to get the real account names.
1600 For instance, previously the is-default radio button in the accounts
1601 list was not checked for any accounts at first. This fixes that,
1602 and might fix several similar bugs.
1604 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1606 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1607 Removed some debug printfs.
1609 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1611 Modest on-disk outbox directories are now here, for instance:
1612 $HOME/.modest/outboxes/<account-id-1>/outbox
1613 $HOME/.modest/outboxes/<account-id-2>/outbox
1615 $HOME/.modest/local-folders/outbox
1616 so we can have a separate outbox for each account.
1617 But they are shown as one outbox in the GtkTreeView, by using a
1618 TnyMergeFolder in a ModestTnySimpleFolderStore.
1621 * src/modest-tny-simple-folder-store.c:
1622 * src/modest-tny-simple-folder-store.h:
1623 Added ModestTnySimpleFolderStore, used to contain folders from
1624 other folder stores, such as other accounts.
1626 * src/modest-tny-outbox-account.h:
1627 * src/modest-tny-outbox-account.c:
1628 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1629 used for the per-account local outbox folders.
1631 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1632 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1633 only use this (internally) now for the non-outbox local folders.
1635 * src/modest-init.h:
1636 * src/modest-init.c: Added modest_init_one_local_folder(), for
1637 setting up the directory structure for each local folder.
1639 * src/modest-local-folder-info.c:
1640 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1641 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1643 * src/modest-local-folder-info.h:
1644 * src/modest-tny-account-store.c: (on_account_removed),
1645 (on_account_changed), (create_per_account_local_outbox_folders),
1646 (get_server_accounts), (modest_tny_account_store_get_accounts),
1647 (modest_tny_account_store_get_tny_account_by_account),
1648 (modest_tny_folder_store_is_virtual_local_folders):
1650 * src/modest-tny-account.h:
1651 * src/modest-tny-account.c:
1652 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1653 to create an on-disk per-account local outbox folder for each
1655 (create_per_account_local_outbox_folders): Create a local outbox folder
1656 for each transport account.
1657 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1658 for all local folders.
1660 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1661 instead of using g_object_get/set() directly. It is clearer.
1663 (modest_tny_folder_store_get_message_count),
1664 (modest_tny_folder_store_get_local_size
1665 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1666 because we now use these with non-acount folder stores.
1668 (modest_tny_account_get_special_folder),
1669 (modest_tny_account_new_from_server_account),
1670 (modest_tny_account_new_from_account):
1671 (recurse_folders): Adjust to the new outbox system.
1673 * src/modest-tny-folder.h:
1674 * src/modest-tny-folder.c:
1675 (modest_tny_folder_is_local_folder),
1676 (modest_tny_folder_get_local_folder_type),
1677 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1679 * src/widgets/modest-main-window.h:
1680 * src/maemo/modest-main-window.c: (create_details_widget),
1681 (modest_main_window_set_contents_style): Show details for any folder store,
1684 (modest_tny_folder_get_rules):
1685 Remove the const. C does not support constness enough for this.
1687 * src/modest-ui-actions.c:
1688 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1689 make all outboxes appear as one, in the usual local-folders tree node.
1691 (set_active_account_from_tny_account),
1692 (modest_ui_actions_on_folder_selection_changed):
1693 * src/widgets/modest-folder-view.c: (text_cell_data),
1694 (icon_cell_data), (filter_row),
1695 (add_account_folders_to_merged_folder),
1696 (add_account_folders_to_simple_folder_store), (),
1697 (get_cmp_rows_type_pos), (cmp_rows),
1698 (modest_folder_view_set_account_id_of_visible_server_account):
1699 Adjust to the new outbox system, using generic folder stores and folders
1700 in the GtkTreeModel.
1702 2007-05-23 Christian Kellner <ckellner@openismus.com>
1704 * src/modest-mail-operation.c:
1705 (modest_mail_operation_update_account):
1706 Use info->max_size instead of unintialized local var [small
1707 build fix]. (Added TODO to review that change since I don't
1710 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1712 * libmodest-dbus-client/libmodest-dbus-client.c:
1713 (libmodest_dbus_client_compose_mail): function added
1714 * src/dbus_api/modest-dbus-api.h:
1715 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1716 (on_compose_mail): Implementation of the SendAsMail functionality
1718 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1720 * src/modest-account-mgr.c:
1721 (modest_account_mgr_add_server_account): Set the secure-connection
1722 conf key for transport accounts as well as store accounts. I don't know
1723 why the if was there. For instance, this makes sure that we use SSL
1724 for the gmail preset from the easysetup wizard.
1726 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1728 * src/gnome/modest-main-window.c:
1729 (on_account_store_connecting_finished), (connect_signals):
1730 * src/maemo/modest-main-window.c:
1731 (on_account_store_connecting_finished), (connect_signals),
1732 (modest_main_window_new):
1733 Handle TnyAccountStore::connecting-finished instead of
1734 TnyDevice::connection-changed, because we cannot actually perform
1735 operations on accounts until TnyAccountStore has itself responded to
1736 the TnyDevice::connection-changed signal. This prevents a GError from
1738 Do not try to update at startup, because we (at least on scratchbox)
1739 already do an update at startup when the device goes online.
1740 This prevents a GError from tinymail.
1741 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1742 Added TODO about stopping simultaneous operations.
1744 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1746 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1747 * src/modest-mail-operation-queue.c:
1748 (modest_mail_operation_queue_remove):
1749 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1750 about where they happened.
1752 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1754 * src/modest-ui-actions.c:
1755 (modest_ui_actions_on_password_requested): Make sure that the remember
1756 output parameter is always TRUE.
1758 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1760 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1761 Show a OK/Cancel dialog if the error is a question, though we still do not
1762 know anything more about what we are asking the user.
1763 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1764 Fix an uninitialized variable (helper). This is a logic error, however.
1766 2007-05-21 Christian Kellner <ckellner@openismus.com>
1768 * src/modest-search.h:
1769 Correct bit shifting in the ModestSearchFlags enum.
1771 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1773 * src/modest-tny-account.c:
1774 (modest_tny_account_new_from_server_account): Do not use the lsub and
1775 check-all hard-coded IMAP options when using POP.
1777 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1779 * src/modest-tny-account.c:
1780 (modest_tny_account_new_from_server_account):
1781 Use NULL for the secure-auth method for POP when Password auth has been
1782 specified by the user, as we already do for IMAP. "auth=Login" causes
1783 an error from camel or the server.
1785 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1787 * src/maemo/modest-account-settings-dialog.c:
1788 (create_page_account_details),
1789 (modest_account_settings_dialog_set_account_name):
1790 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1791 for the leave-on-server checkbox, rathr than just the checkbox, when
1792 the protocol is not POP.
1794 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1796 * src/widgets/modest-account-view.c:
1797 * src/widgets/modest-account-view.h:
1798 Added modest_account_view_select_account() which will be useful later
1799 to asynchronously re-select the edited account.
1801 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1803 * src/maemo/modest-account-settings-dialog.c:
1804 (modest_account_settings_dialog_set_account_name):
1805 Automatically choose the port numbers based on the secure authentication
1806 methods, if they have not been chosen before.
1807 This fixes projects.maemo.org bug NB#56273 .
1809 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1811 * src/maemo/modest-main-window-ui.h:
1812 * src/modest-ui-actions.c:
1813 * src/modest-ui-actions.h:
1814 Connect the Tools/SMTP Servers menu item to
1815 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1816 SMTP servers dialog, as in the UI specification and saves changes when it
1817 is closed. This fixed projects.maemo.org bug NB#56305 .
1819 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1821 * src/maemo/modest-connection-specific-smtp-window.c:
1822 (modest_connection_specific_smtp_window_init):
1823 Use gtk_window_set_default_size() to make this window big enough, so
1824 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1826 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1828 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1829 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1830 (modest_connection_specific_smtp_edit_window_init),
1831 Do not try to connect to a combobox signal before the combobox exists.
1832 This fixes the cras in projects.maemo.org bug NB#56288 .
1833 (modest_connection_specific_smtp_edit_window_get_settings):
1834 Remove the server_account_name parameter which was being checked for NULL
1835 though it was not used.
1837 * src/maemo/modest-connection-specific-smtp-window.c:
1838 (modest_connection_specific_smtp_window_fill_with_connections),
1839 (on_button_edit), (modest_connection_specific_smtp_window_init):
1840 Correct the number of treemodel columns to prevent a warning.
1841 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1842 libconic does not work.
1844 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1846 * src/modest-tny-account.c:
1847 (modest_tny_account_new_from_server_account):
1848 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1849 SMTP when "None" was chosen by the user. However, with my SMTP server that
1850 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1853 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1855 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1856 to explain the memory management issue with the ID in the ModestPair.
1858 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1859 (add_sending_page), (modest_account_assistant_finalize):
1860 * src/gnome/modest-gnome-global-settings-dialog.c:
1861 (create_updating_page), (create_composing_page):
1862 * src/gnome/modest-msg-edit-window.c: (get_transports),
1863 (init_window), (modest_msg_edit_window_finalize),
1864 (modest_msg_edit_window_get_msg_data):
1865 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1866 * src/gnome/modest-transport-widget.c:
1867 (modest_transport_widget_finalize), (smtp_configuration):
1868 * src/maemo/modest-maemo-global-settings-dialog.c:
1869 (create_updating_page), (create_composing_page):
1870 * src/maemo/modest-msg-edit-window.c: (get_transports),
1871 (init_window), (modest_msg_edit_window_finalize),
1872 (modest_msg_edit_window_get_msg_data),
1873 (modest_msg_edit_window_free_msg_data):
1874 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1875 (modest_store_widget_finalize):
1876 * src/maemo/modest-transport-widget.c:
1877 (modest_transport_widget_finalize), (smtp_configuration):
1878 * src/modest-main.c: (send_mail):
1879 * src/widgets/modest-combo-box.h:
1880 * src/widgets/modest-global-settings-dialog-priv.h:
1881 * src/widgets/modest-global-settings-dialog.c:
1882 (modest_global_settings_dialog_finalize):
1883 * src/widgets/modest-msg-edit-window.h:
1884 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1885 as long as the combo box, to prevent use of freed memory for the ID.
1887 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1889 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1890 get_accounts(), to make this clearer. Do not check for the enabled gconf
1891 key, because we do not use this for server accounts (at least, not yet).
1892 This allows us to send email again.
1894 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1896 * src/maemo/modest-platform.c:
1897 (on_modest_conf_update_interval_changed), (modest_platform_init):
1898 Only respond to this particular key change. All these strcmp()s cannot be
1901 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1903 * src/maemo/modest-maemo-global-settings-dialog.c:
1904 (current_connection): Prevent a crash in scratchbox when
1905 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1906 * src/maemo/modest-platform.c:
1907 (on_modest_conf_update_interval_changed), (modest_platform_init):
1908 Get the update interval from gconf and reset it when the gconf key changes.
1910 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1912 * src/modest-protocol-info.c:
1913 * src/modest-protocol-info.h: Adde enum-specific get functions,
1914 instead of using a ModestProtocolType enum parameter.
1916 * src/gnome/modest-account-assistant.c:
1917 * src/gnome/modest-store-widget.c:
1918 * src/gnome/modest-store-widget.h:
1919 * src/gnome/modest-transport-widget.c:
1920 * src/gnome/modest-transport-widget.h:
1921 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1922 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1923 * src/maemo/easysetup/modest-easysetup-wizard.c:
1924 * src/maemo/modest-account-settings-dialog.c:
1925 * src/maemo/modest-account-settings-dialog.h:
1926 * src/maemo/modest-store-widget.c:
1927 * src/maemo/modest-store-widget.h:
1928 * src/maemo/modest-transport-widget.c:
1929 * src/maemo/modest-transport-widget.h:
1930 * src/modest-account-mgr-helpers.c:
1931 * src/modest-account-mgr-helpers.h:
1932 * src/modest-account-mgr.c:
1933 * src/modest-account-mgr.h:
1934 * src/modest-tny-account.c:
1935 * src/modest-tny-folder.c:
1936 * src/widgets/modest-account-view.c:
1937 * src/widgets/modest-retrieve-combo-box.c:
1938 * src/widgets/modest-retrieve-combo-box.h:
1939 * src/widgets/modest-secureauth-combo-box.c:
1940 * src/widgets/modest-serversecurity-combo-box.c:
1941 * src/widgets/modest-serversecurity-combo-box.h:
1942 * tests/check_account-mgr.c:
1943 Use the specific functions, and use the re-renamed enum values for GNOME too.
1945 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1947 * src/modest-pair.h:
1948 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1949 so we can get the second based on the first.
1951 * src/maemo/modest-account-settings-dialog.h:
1952 * src/maemo/modest-account-settings-dialog.c:
1953 Added get_supported_secure_authentication_methods(), though it is mostly
1954 commented-out for now until the necessary API is committed to tinymail.
1955 (modest_account_settings_dialog_set_account_name),
1956 (save_configuration): Request the supported authentication methods from the
1957 server, so we can choose a working method.
1959 * src/modest-tny-account-store.h:
1960 * src/modest-tny-account-store.c:
1961 (modest_tny_account_store_get_session): Rename from
1962 tny_account_store_get_session().
1964 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1966 * src/modest-protocol-info.h: Split the ModestProtocol enum
1967 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1968 There was no need to have these unrelated values in one enum.
1970 * src/: many files: Adapted to changed enum. This makes the code a bit
1971 clearer, and the compiler could catch some errors.
1973 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1975 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1976 Show the detailed internal camel error message when an error happens
1977 during the configuration, so that our testers can give us more clues.
1978 For instance, in projects.maemo.org bug NB#56910 .
1980 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1982 * src/modest-tny-account.c:
1983 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1984 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1986 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1988 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1989 * src/maemo/modest-account-settings-dialog.c:
1990 (modest_account_settings_dialog_set_account_name),
1991 (save_configuration): For the incoming secure authentication checkbox,
1992 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1993 the UI specification. PLAIN does not seem to be supported for most IMAP
1994 servers anyway, and I am not sure what it would mean.
1995 However, we probably need to discover which of the secure-authentication
1996 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1997 * src/modest-account-mgr-helpers.c:
1998 (modest_account_mgr_get_server_account_data):
2000 * src/modest-tny-account.c:
2001 (modest_tny_account_new_from_server_account):
2002 Use tny_account_set_mech() to set secure-authentication methods,
2003 with some special-casing for IMAP, based on my observations of how
2006 * src/modest-account-mgr-helpers.h:
2007 * src/modest-account-mgr.c:
2008 * src/modest-defs.h: Comment that the URI is only used for local folders.
2010 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2012 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
2013 parameter const, just to be neat.
2014 * src/modest-text-utils.c: (modest_text_utils_inline):
2015 End g_strconcat() with NULL, as its documentation says. This is almost
2016 certainly the cause of my crash at startup on the device. Interestingly,
2017 valgrind doesn't tell us about these errors.
2019 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2021 * scripts/build-packages: Added more precise comments about how to use
2022 this script, though I still get this error:
2023 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
2024 error building tinymail
2026 2007-05-11 Murray Cumming <murrayc@murrayc.com>
2028 * src/maemo/modest-main-window.c: (on_account_update):
2029 Very slight cleanup, hoping to make it simpler to discover what causes
2030 a crash here sometimes.
2032 * src/modest-tny-account.c:
2033 (modest_tny_account_new_from_server_account): Set the port. Added
2034 comments about the options and a TODO comment because I need to find out
2035 how to specify the secure authentication method.
2037 2007-05-11 Marcus Bauer <marcusb@openismus.com>
2039 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2040 changed CFlags paths form modest to libmodest
2042 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2044 * src/modest-account-mgr-helpers.c:
2045 (modest_account_mgr_get_server_account_data),
2046 (modest_account_mgr_free_server_account_data):
2047 * src/modest-account-mgr-helpers.h:
2048 * src/modest-account-mgr.c:
2049 (modest_account_mgr_add_server_account):
2050 * src/modest-defs.h:
2051 * src/modest-tny-account.c:
2052 (modest_tny_account_new_from_server_account):
2053 Determine the options for tny_camel_account_add_option() here,
2054 based on the settings, rather than storing them directly in gconf.
2056 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2058 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2059 Show a more friendly error dialog now that we expect (from the tinymail
2060 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
2062 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2064 * src/maemo/modest-main-window.c: (on_account_update): Check that
2065 account_name is not NULL, to prevent a crash at startup that I am
2066 seeing on the N800. I do wonder why it is NULL.
2068 * src/maemo/easysetup/modest-easysetup-wizard.c:
2069 (create_page_user_details):
2070 * src/maemo/modest-account-settings-dialog.c:
2071 (create_page_user_details), (create_page_outgoing):
2072 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2073 (modest_connection_specific_smtp_edit_window_init):
2074 * src/modest-ui-actions.c:
2075 (modest_ui_actions_on_password_requested):
2076 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
2077 might do something useful with the on-screen keyboard.
2079 2007-05-10 Murray Cumming <murrayc@murrayc.com>
2081 * src/maemo/modest-main-window.c: (on_account_update):
2082 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
2083 NULL, to avoid lots of warnings. However, it probably should not be NULL.
2085 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2087 * src/modest-tny-account-store.c: (on_account_changed):
2088 Correct the signature of this signal handler.
2090 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2092 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2093 Show a HildonNote instead of a GtkDialog for Maemo.
2095 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2097 * src/widgets/modest-account-view.h:
2098 * src/widgets/modest-account-view.c: (on_account_changed),
2099 (on_account_removed). Added a boolean flag, set/unset by
2100 modest_account_view_block_conf_updates(),
2101 modest_account_view_unblock_conf_updates() to prevent unnecessary
2102 updates, but this is not very useful because the gconf notifications are
2103 so delays (maybe only on Maemo Bora).
2104 So auto-updating is turned off, and these functions do an explicit
2105 update when necessary.
2106 However, something else is still doing too much work when adding/removing
2107 accounts, probably in another part of the application.
2109 * src/maemo/modest-account-view-window.c:
2110 (on_delete_button_clicked), (on_edit_button_clicked),
2111 (on_new_button_clicked): Use the new functions.
2113 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2115 * src/modest-account-mgr-helpers.c:
2116 (modest_account_mgr_set_first_account_as_default):
2117 Sort the list of names alphabetically-by-title, so we choose the first one
2119 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
2120 alphabetically by the title.
2122 This fixes projects.maemo.org bug NB#56418 .
2124 * src/modest-account-mgr-priv.c:
2125 (_modest_account_mgr_account_from_key):
2126 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
2127 avoid a valgrind error, and possible random behaviour.
2129 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2131 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
2132 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
2133 tinymail documentation to say that this can be expected.
2134 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
2135 pretty, and should not happen, but I would prefer to know when it does.
2137 2007-05-09 Murray Cumming <murrayc@murrayc.com>
2139 * configure.ac: When using the older hildon version, probably on Bora,
2140 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
2142 * src/widgets/modest-attachment-view.c:
2143 (modest_attachment_view_set_part_default): Initialize variables, to fix the
2146 2007-05-09 Marcus Bauer <marcusb@openismus.com>
2148 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
2149 Implemented the prototype. Can be tested with
2150 tests/dbus_api/test_open_message:
2152 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2154 * src/modest-tny-account-store.c:
2155 (modest_tny_account_store_instance_init), (get_password):
2156 * src/modest-ui-actions.c:
2157 (modest_ui_actions_on_password_requested):
2158 Do not store the password in gconf, because this function is called
2159 for non-remembered passwords. Actually use the cached (in the hash map)
2160 password instead of releasing it.
2161 The password will now not be remembered if it is asked via the protected
2162 password dialog, as per the UI spec.
2164 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2166 * src/modest-defs.h:
2167 * src/modest-account-mgr-helpers.h:
2168 * src/modest-account-mgr-helpers.c:
2169 Added modest_server_account_get_username_has_succeeded(),
2170 modest_server_account_set_username_has_succeeded().
2171 (modest_server_account_set_username),
2172 Reset the has-succeeded flag if the username changes.
2174 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2175 * src/maemo/modest-connection-specific-smtp-window.c:
2176 (modest_connection_specific_smtp_window_save_server_accounts):
2177 Use modest_server_account_set_username() instead of using
2178 modest_conf_set_string() directly, so that the has-succeeded flag is always
2181 * src/modest-ui-actions.c:
2182 (modest_ui_actions_on_password_requested): Dim the username entry if
2183 the username has ever worked, as per the UI spec.
2185 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2187 * src/modest-tny-account-store.c: (get_password):
2188 * src/modest-ui-actions.c:
2189 (modest_ui_actions_on_password_requested):
2190 Allow the username to be changed too, though there is more work to
2191 be done on exactly how this behaves.
2193 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2195 * src/modest-account-mgr-helpers.h:
2196 * src/modest-account-mgr-helpers.c:
2197 Added modest_account_mgr_get_display_name(),
2198 modest_server_account_get_username(),
2199 modest_server_account_set_username(),
2200 modest_server_account_set_password(),
2201 modest_server_account_get_hostname() functions so we do not need to
2202 use the conf API directly.
2204 * src/maemo/modest-main-window.c: (connect_signals):
2205 Actually connect ot the ModestAccountStore::request-password signal,
2206 so that we show the dialog when the password is requested by Tinymail,
2207 for isntance if it is empty.
2209 * src/modest-marshal.list:
2210 * src/modest-tny-account-store.c:
2211 (modest_tny_account_store_class_init), (get_password),
2212 (modest_tny_account_store_alert):
2213 * src/modest-tny-account-store.h:
2214 * src/modest-ui-actions.h:
2215 * src/modest-ui-actions.c:
2216 (modest_ui_actions_on_password_requested):
2217 Change the signal parameters, so it is obvious that we are providing
2218 the non human-readable server name, and receiving both the username
2219 and password, though changing of the username is not yet implemented.
2220 Change the dialog UI to match the Maemo UI specifications, with #idfefing
2221 for the GNOME version.
2223 This should fix the projects.maemo.org bug NB#56209, though it does not
2224 work on Bora, because the gconf_client_get() for the password fails
2225 immediately after we save it with gconf_client_set().
2227 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2230 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
2231 caused an undefined symbol error:
2232 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
2234 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2236 * src/modest-tny-account-store.c:
2237 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
2238 using a GError instead of a string message, so we can translate it in
2241 2007-05-08 Murray Cumming <murrayc@murrayc.com>
2243 * src/maemo/modest-address-book.c:
2244 (modest_address_book_check_names):
2245 * src/maemo/modest-msg-view-window.c:
2246 (modest_msg_view_window_clipboard_owner_change):
2247 * src/modest-init.c: (modest_init_init_ui):
2248 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
2249 (update_folders_cb), (modest_mail_operation_update_account):
2250 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
2251 (modest_ui_actions_on_msg_attachment_clicked),
2252 (modest_ui_actions_on_msg_recpt_activated):
2253 * src/widgets/modest-header-view.c: (drag_data_get_cb):
2254 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
2255 (modest_msg_view_search_next):
2256 * src/widgets/modest-recpt-editor.c:
2257 (modest_recpt_editor_on_button_release_event),
2258 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
2259 g_message(). At this point we should only be seeing interesting errors on
2260 stdout. Debugging messages could be #ifdefed-out if they are still useful.
2262 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2264 (modest_wizard_dialog_force_title_update):
2265 * src/maemo/easysetup/modest-wizard-dialog.h:
2266 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
2267 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
2268 can update the title when appropriate. Otherwise the title is wrong if the
2269 pages are added after adding the notebook to the dialog.
2270 This must be a problem in HildonWizardDialog too.
2271 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
2273 * src/maemo/easysetup/modest-easysetup-wizard.c:
2274 (create_subsequent_customsetup_pages),
2275 (create_subsequent_easysetup_pages):
2276 Call modest_wizard_dialog_force_title_update() so that the title is
2277 correct even with GTK+ < 2.10.
2278 This fixes projects.maemo.org bug NB#56145 .
2280 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2282 * src/maemo/modest-platform.c:
2283 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
2284 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
2287 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2289 * src/widgets/modest-window.h:
2290 * src/widgets/modest-window.c: Added a save_state_func vfunc,
2291 and modest_window_save_state(), which invokes it.
2293 * src/widgets/modest-window-mgr.h:
2294 * src/widgets/modest-window-mgr.c:
2295 Added modest_window_mgr_save_state_for_all_windows(), which calls
2296 the save_state vfunc on all registered windows, if implemented.
2298 * src/gnome/modest-msg-edit-window.c:
2299 * src/gnome/modest-msg-view-window.c:
2300 * src/maemo/modest-msg-edit-window.c:
2301 * src/maemo/modest-msg-view-window.c:
2302 * src/maemo/modest-main-window.c:
2303 Specify the existing save_settings functions as implementations of
2304 ModestWindow::save_state_func().
2306 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
2307 Call modest_window_mgr_save_state_for_all_windows(). This happens before
2308 enabling hibernation, for instance.
2310 We may need to do the same thing for restoring settings.
2313 2007-05-07 Murray Cumming <murrayc@murrayc.com>
2315 * src/widgets/modest-window-mgr.c:
2316 * src/widgets/modest-window-mgr.h:
2317 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
2318 modest_window_mgr_get_hibernation_is_prevented().
2320 * src/maemo/modest-main-window.c:
2321 (on_hildon_program_is_topmost_notify): Prevent hibernation
2322 (possible when the application goes to the background in the WM),
2323 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
2325 * src/maemo/easysetup/modest-easysetup-wizard.c:
2326 (modest_easysetup_wizard_dialog_init):
2327 * src/maemo/modest-account-settings-dialog.c:
2328 (modest_account_settings_dialog_init):
2329 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2330 (modest_connection_specific_smtp_edit_window_init):
2331 * src/maemo/modest-connection-specific-smtp-window.c:
2332 (modest_connection_specific_smtp_window_init):
2333 * src/maemo/modest-signature-editor-dialog.c:
2334 (modest_signature_editor_dialog_init):
2335 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
2336 prevent hibernation while any of these account settings dialogs are open.
2338 2007-05-04 Murray Cumming <murrayc@murrayc.com>
2340 * src/maemo/Makefile.am:
2341 * src/maemo/modest-osso-state-saving.c:
2342 * src/maemo/modest-osso-state-saving.h: Added
2343 modest_osso_load_state() and modest_osso_save_state() though they do
2344 nothing now. They should iterate through all the open windows and load/save
2346 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
2347 save state when closing.
2349 * src/maemo/modest-main-window.c:
2350 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
2351 Add a notification handler for the HildonProgram::is-topmost property,
2352 so we can allow hibernation when the application goes into the background.
2353 But we still need to detect when the accounts setup windows are open so
2354 we can stop hibernation when they are open.
2355 To do this, I also added the main window the HildonProgram. This might have
2356 other side-effects/benefits, and should maybe be done for other windows.
2358 * src/maemo/modest-osso-autosave-callbacks.h:
2359 * src/maemo/modest-osso-autosave-callbacks.c:
2360 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
2361 though it does not do anything yet, and we might never need this to do
2362 anything. For instance, we already save drafts.
2364 * src/maemo/modest-platform.c: (modest_platform_init):
2365 Specify the libosso auto-save callback.
2367 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2369 * src/maemo/modest-platform.c:
2370 (modest_platform_set_update_interval):
2371 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
2372 aparently stays valid between application instances, so we can use this
2373 to remove and reset it later. According to a maemo-developers email from
2376 2007-05-03 Murray Cumming <murrayc@murrayc.com>
2378 * configure.ac: Depend on libalarm for Maemo.
2380 * src/dbus_api/modest-dbus-api.h:
2381 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
2382 (on_send_receive), (modest_dbus_req_handler):
2383 Handle a SEND_RECEIVE D-Bus method.
2385 * libmodest-dbus-client/libmodest-dbus-client.c:
2386 (libmodest_dbus_client_send_and_receive):
2387 * libmodest-dbus-client/libmodest-dbus-client.h:
2388 Add C convenience functions for calling the new D-Bus method.
2390 * src/modest-platform.h:
2391 * src/gnome/modest-platform.c:
2392 * src/maemo/modest-platform.c:
2393 Added modest_platform_set_update_interval(), which uses the
2394 alarmd API on Maemo.
2395 (modest_platform_init),
2396 Call modest_platform_set_update_interval(), using a hard-coded
2397 interval for now (until the global settings dialog is implemented),
2398 though I am not sure that this makes sense yet.
2400 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2402 * src/dbus_api/modest-dbus-callbacks.c:
2403 (modest_osso_cb_hw_state_handler):
2404 * src/dbus_api/modest-dbus-callbacks.h:
2405 * src/maemo/modest-platform.c: (modest_platform_init):
2406 Registered (empty) callbacks for the osso hardware state D-Bus signals,
2407 in case this has some effect on the ability for Maemo to ping the
2410 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2412 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
2413 Comment out an if() that checks a gchar for < 0, causing a build-breaking
2414 warning. It is probably a logic error, but I need to fix the build.
2416 2007-05-02 Murray Cumming <murrayc@murrayc.com>
2418 * src/modest-account-mgr.h:
2419 * src/modest-account-mgr.c:
2420 (modest_account_mgr_account_names): Add a gboolean enabled_only
2421 parameter, so we can get lists of onlt the enabled accounts.
2423 (modest_account_mgr_add_account),,
2424 (modest_account_mgr_account_with_display_name_exists):
2425 * src/maemo/modest-msg-edit-window.c: (get_transports):
2426 * src/modest-account-mgr-helpers.c:
2427 (modest_account_mgr_set_first_account_as_default):
2428 * src/modest-init.c: (init_default_account_maybe):
2429 * src/modest-tny-account-store.c: (get_accounts):
2430 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2431 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
2432 * tests/check_account-mgr.c: (START_TEST):
2433 Provide the extra parameter, as appropriate.
2435 * src/widgets/modest-account-view.c: (update_account_view):
2436 Do not show disabled accounts (meaning that there is no way to
2437 enable/disable accounts in the UI (the feature is not in our UI
2438 specification), so we can use this internally only to mark unfinished
2439 or temporary account data.
2441 * src/maemo/easysetup/modest-easysetup-wizard.c:
2442 (create_account): Add boolean enable parameter, so we can specify FALSE
2443 to create the temporary account.
2444 (on_button_edit_advanced_settings): Create the temporary account as disabled.
2445 (on_before_next): When finishing, when there is a temporary account, just
2447 Also, use a timeout to delay the showing of the dialog until gconf is likely
2448 to return correct information, due to a maemo gconf bug that is fixed in
2449 osso 1.1, but not yet in Bora.
2450 However, the dialog stays on screen after it is destroyed.
2452 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
2453 for invalid data when cancelling. Use a hildon note instead of a dialog
2454 to complain about invalid data. Do not show the account-saved note if the
2455 account is disabled (a temporary account that will not really be saved for use
2458 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2460 * src/modest-account-mgr-helpers.h:
2461 * src/modest-account-mgr-helpers.c:
2462 Added modest_account_mgr_unset_default_account(),
2463 Added modest_account_mgr_set_first_account_as_default().
2465 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
2466 If it was the default account, unset the default account name.
2468 * src/maemo/modest-account-view-window.c:
2469 (on_delete_button_clicked): If it was the default account,
2470 set the first remaining account as the default instead.
2472 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
2473 a NULL account or a NULL default account, to prevent a crash. This should
2474 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
2477 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2479 * src/widgets/modest-recpt-editor.c:
2480 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
2481 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
2482 TODO comment for this. This fixes the build.
2484 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
2485 be the best place for it. This will in future update all auto-update accounts,
2486 rather than just the current/default account, when that gconf key exists.
2487 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
2488 if there are no accounts, before calling do_send_receive().
2489 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
2491 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
2492 * src/maemo/modest-main-window-ui.h:
2493 * src/maemo/modest-main-window.c: (on_connection_changed),
2494 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
2495 directly, becaue the signal handler does more.
2497 2007-04-30 Murray Cumming <murrayc@murrayc.com>
2499 * src/modest-account-mgr-helpers.c:
2500 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2501 for the case that the account does not exist.
2503 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2504 (equivalent to the modest account name) rather than the tinymail account name
2505 (equivalent to the modest account title - human readable) to get the account data.
2506 Check for null account data to prevent the crash, and add a TODO comment saying that
2507 this needs fixing because it is using the server account name instead of the account name.
2509 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2511 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2512 * src/maemo/modest-account-settings-dialog.c: (show_error),
2514 Use hildon_note_new_information() for informative and error messages,
2515 which seems to be expected for Maemo applications (no documentation that I know of
2516 says this). I am surprised that there is no distinction between info and error
2519 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2521 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2522 it is easy to find where this is used.
2524 * src/maemo/easysetup/modest-easysetup-wizard.c:
2525 (create_page_welcome), (create_page_account_details),
2526 (create_page_user_details), (create_page_complete_easysetup),
2527 (create_page_custom_incoming), (create_page_custom_outgoing),
2528 (create_page_complete_custom):
2529 * src/maemo/modest-account-settings-dialog.c:
2530 (create_page_account_details), (create_page_user_details),
2531 (create_page_incoming), (create_page_outgoing):
2532 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2533 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2534 (modest_connection_specific_smtp_edit_window_init):
2535 * src/maemo/modest-connection-specific-smtp-window.c:
2536 (modest_connection_specific_smtp_window_init):
2537 * src/maemo/modest-signature-editor-dialog.c:
2538 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2539 and scrolling policy as per the Email Application Layout Guide, if I have
2542 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2544 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2545 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2546 which were empty, because these vfuncs have been removed from TnyAccountStore.
2547 This fixes the build.
2549 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2551 * src/maemo/modest-main-window.c:
2552 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2553 showing/hiding it. Added TODO because it probably should not be NULL.
2554 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2555 because unnecessary g_warnings() make degugging difficult.
2557 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2559 * src/maemo/modest-msg-edit-window.c:
2560 (modest_msg_edit_window_select_color),
2561 (modest_msg_edit_window_select_background_color): 2 const corrections and
2562 moving 2 #endifs before closing brackets, to fix the build.
2564 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2566 * src/maemo/easysetup/modest-easysetup-wizard.h:
2567 * src/maemo/easysetup/modest-easysetup-wizard.c:
2568 (modest_easysetup_wizard_dialog_finalize),
2569 (on_button_edit_advanced_settings), (create_page_complete_custom),
2570 (on_response), (create_account):
2571 Implement the Advanced Settings edit button, by saving the account information,
2572 for the Advanded Settings dialog to use directly from gconf, and removing it
2573 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2574 Bug #5533 in the projects.maemo.org bugzilla.
2576 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2578 * src/maemo/modest-msg-view-window.c:
2579 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2580 when opening a message window.
2582 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2584 * src/maemo/easysetup/modest-easysetup-wizard.c:
2585 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2588 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2589 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2590 gconf settings. I probably added more checks than necessary, but that is safer.
2592 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2593 variable to fix the build, but this seems to be used when it is still NULL.
2595 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2597 * src/modest-platform.h:
2598 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2599 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2600 * src/modest-main.c: Implement this function so we can avoid using
2601 maemo-specific API from cross-platform code.
2603 * src/modest-tny-account-store.c:
2604 (get_smtp_specific_transport_account_for_open_connection):
2605 * src/modest-ui-actions.c: (check_for_connection),
2606 (modest_ui_actions_on_item_not_found):
2607 Use modest_platform_connect_and_wait() and put #idefs around other
2608 maemo-specific code, because only maemo currently has a way to
2609 identify connection names.
2611 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2613 * src/modest-tny-account-store.h:
2614 * src/modest-tny-account-store.c:
2615 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2616 the connection-specific SMTP server settings in the configuration.
2618 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2620 * src/maemo/modest-main-window.c: (on_connection_changed),
2622 * src/modest-main.c: (main), (start_ui), (send_mail):
2623 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2624 that is what is intended.
2626 * src/modest-ui-actions.c: (action_send), (action_receive),
2627 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2628 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2629 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2630 SMTP server is used when it is specified.
2632 (modest_ui_actions_on_send_receive):
2633 Check that a connection is open before proceeding.
2634 Receive and then send, instead of vice-versa, as per the specification.
2636 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2638 * src/modest-mail-operation.c:
2639 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2640 though I guess it should be something other than NULL.
2642 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2644 * src/maemo/easysetup/modest-easysetup-wizard.c:
2645 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2646 combo twice, to avoid an g_warning and to make it visible again.
2647 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2648 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2649 (already intended) dereference when detaching, because we then recreate the menu.
2650 But I am not sure why the warning was happening, and it is possible that this is a memory
2653 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2655 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2656 and uri_parse_mailto() utility functions.
2657 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2659 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2661 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2663 * src/dbus_api/modest-dbus-api.h:
2664 * src/dbus_api/modest-dbus-callbacks.c:
2665 Use an idle callback to execute the modest code in the application's own thread.
2666 Remove the helloworld example method.
2667 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2668 parsed, and the open-message method is not implemented because this is not yet implemented in
2670 * libmodest-dbus-client/libmodest-dbus-client.c:
2671 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2672 (libmodest_dbus_client_open_message):
2673 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2675 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2676 body without crashing.
2678 * tests/dbus_api/Makefile.am:
2679 * tests/dbus_api/test_mail_to.c:
2680 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2682 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2684 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2685 Added file to fix the build. Sorry.
2687 * src/dbus_api/Makefile.am:
2688 * src/dbus_api/modest-dbus-api.h:
2689 * src/dbus_api/modest-dbus-callbacks.h:
2690 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2691 (modest_dbus_req_handler):
2692 Put constants in a separate header so it can be reused by the
2693 client library, without duplication
2695 * libmodest-dbus-client/Makefile.am:
2696 * libmodest-dbus-client/libmodest-dbus-client.c:
2697 (libmodest_dbus_client_call_helloworld),
2698 (libmodfest_dbus_client_send_mail),
2699 (libmodfest_dbus_client_mailto),
2700 (libmodfest_dbus_client_open_message):
2701 * libmodest-dbus-client/libmodest-dbus-client.h:
2702 (Partly) Implement a send_mail D-Bus method.
2704 * tests/dbus_api/Makefile.am:
2705 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2706 the send_email D-Bus method.
2708 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2712 * libmodest-dbus-client/Makefile.am:
2713 * libmodest-dbus-client/libmodest-dbus-client.c:
2714 * libmodest-dbus-client/libmodest-dbus-client.h:
2715 * tests/dbus_api/Makefile.am:
2716 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2717 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2719 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2721 * src/maemo/easysetup/modest-easysetup-wizard.c:
2722 (create_page_account_details):
2723 * src/maemo/modest-account-settings-dialog.c:
2724 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2725 widgets, because this might not be the default in future versions of the Maemo GTK+.
2726 However, I can not not get capitalization to work even in a simple test case.
2728 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2730 * src/maemo/easysetup/modest-easysetup-wizard.c:
2731 (create_page_custom_incoming), (create_page_custom_outgoing):
2732 * src/maemo/modest-account-settings-dialog.c:
2733 (create_page_account_details), (create_page_incoming),
2734 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2735 instead of using gtk_check_button_with_label(), so they are aligned like the other
2736 widgets, as per the UI spec.
2738 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2740 * src/maemo/easysetup/modest-easysetup-wizard.c:
2741 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2742 * src/widgets/modest-validating-entry.c:
2743 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2744 Modest prefix instead of an EasySetup prefix.
2746 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2748 * src/widgets/modest-validating-entry.h:
2749 * src/widgets/modest-validating-entry.c: (on_insert_text),
2750 Added easysetup_validating_entry_set_max_func(), used to set a callback
2751 to call when the max number of characters is reached. GtkEntry has a max-length
2752 already but is silent about it.
2754 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2755 (create_page_account_details), (create_page_user_details),
2757 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2758 (create_page_account_details), (create_page_user_details),
2759 (create_page_outgoing):
2760 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2761 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2762 the UI spec, when the user tries to enter more than the max number of characters.
2764 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2766 * src/maemo/easysetup/modest-easysetup-wizard.c:
2767 (create_page_user_details), (create_page_custom_incoming),
2768 (create_page_custom_outgoing):
2769 * src/maemo/modest-account-settings-dialog.c:
2770 (create_page_user_details), (create_page_incoming),
2771 (create_page_outgoing):
2772 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2773 (modest_connection_specific_smtp_edit_window_init):
2774 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2775 not appropriate. Bad Maemo-specific defaults!.
2777 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2779 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2780 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2781 (modest_signature_editor_dialog_set_settings):
2782 Disable the label and textview when the checkbox is disabled, and use the
2783 specified (UI spec) default signature text.
2785 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2788 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2790 * src/modest-defs.h:
2791 * src/modest-account-mgr-helpers.h:
2792 * src/modest-account-mgr-helpers.c:
2793 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2795 * src/maemo/Makefile.am:
2796 * src/maemo/modest-signature-editor-dialog.c:
2797 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2800 * src/maemo/modest-account-settings-dialog.h:
2801 * src/maemo/modest-account-settings-dialog.c:
2802 (modest_account_settings_dialog_finalize), (on_button_signature),
2803 (save_configuration): Use the new dialog when the Edit button is pressed, and
2804 save the changes if necessary, as per the UI spec.
2806 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2808 * src/maemo/Makefile.am:
2809 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2810 based on maemo-develoers email from Dirk.
2812 * src/maemo/easysetup/modest-easysetup-wizard.c:
2813 (create_page_welcome), (create_page_account_details),
2814 (create_page_user_details), (create_page_complete_easysetup),
2815 (create_page_custom_incoming), (create_page_custom_outgoing),
2816 (create_page_complete_custom),
2817 (modest_easysetup_wizard_dialog_init):
2818 * src/maemo/modest-account-settings-dialog.c:
2819 (create_page_account_details), (create_page_user_details),
2820 (create_page_incoming), (create_page_outgoing),
2821 (modest_account_settings_dialog_init):
2822 * src/maemo/modest-connection-specific-smtp-window.c:
2823 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2825 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2827 * src/maemo/easysetup/modest-easysetup-wizard.c:
2828 (create_page_account_details), (create_page_custom_outgoing),
2829 (create_page_complete_custom):
2830 * src/maemo/modest-account-settings-dialog.c:
2831 (create_page_user_details), (create_page_incoming),
2832 (create_page_outgoing):
2833 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2834 (modest_connection_specific_smtp_edit_window_init):
2835 Use the correct (UI spec) port min/max, and use horizontal separators,
2838 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2840 * src/maemo/easysetup/modest-easysetup-wizard.c:
2841 (set_default_custom_servernames):
2842 * src/maemo/modest-account-settings-dialog.c:
2843 (create_page_incoming), (on_combo_outgoing_security_changed),
2844 (on_combo_incoming_security_changed), (create_page_outgoing),
2845 (modest_account_settings_dialog_set_account_name),
2846 (save_configuration):
2847 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2848 (on_combo_security_changed),
2849 (modest_connection_specific_smtp_edit_window_init),
2850 (modest_connection_specific_smtp_edit_window_set_connection),
2851 (modest_connection_specific_smtp_edit_window_get_settings):
2852 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2855 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2858 * src/maemo/easysetup/modest-easysetup-wizard.c:
2859 (create_page_custom_outgoing), (create_page_complete_custom):
2860 * src/maemo/modest-account-settings-dialog.c:
2861 (create_page_user_details), (create_page_outgoing):
2862 * src/maemo/modest-account-view-window.c: (button_box_new):
2863 Use changed logical IDs as per the most recent UI spec:
2864 mcen_bd_emailsetup_edit -> mcen_bd_edit
2865 mcen_bd_emailsetup_delete -> mcen_bd_delete
2866 mcen_bd_emailsetup_close -> mcen_bd_close
2868 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2872 * src/dbus_api/Makefile.am:
2873 * src/dbus_api/modest-dbus-callbacks.c:
2874 * src/dbus_api/modest-dbus-callbacks.h:
2875 * src/maemo/modest-platform.c: (modest_platform_init):
2876 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2878 * tests/Makefile.am:
2879 * tests/dbus_api/Makefile.am:
2880 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2882 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2884 * src/maemo/modest-account-settings-dialog.c:
2885 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2886 Removed unnecessary includes.
2888 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2890 * src/maemo/easysetup/modest-easysetup-wizard.c:
2891 * src/maemo/modest-account-settings-dialog.c:
2892 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2893 * src/widgets/Makefile.am:
2894 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2895 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2896 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2897 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2898 * src/widgets/modest-secureauth-combo-box.c:
2899 * src/widgets/modest-secureauth-combo-box.h:
2900 * src/widgets/modest-serversecurity-combo-box.c:
2901 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2902 made the GObject names more consistent with the rest of the Modest code.
2904 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2906 * src/maemo/easysetup/Makefile.am:
2907 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2908 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2909 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2910 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2911 * src/maemo/easysetup/modest-easysetup-wizard.c:
2912 * src/maemo/easysetup/modest-validating-entry.c:
2913 * src/maemo/easysetup/modest-validating-entry.h:
2914 * src/maemo/modest-account-settings-dialog.c:
2915 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2916 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2917 widgets/ because they are used outside of easysetup too. After checking in,
2918 svn will allow me to rename them too.
2920 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2922 * src/gnome/modest-msg-edit-window.c:
2923 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2924 linker error, to fix the build on the GNOME platform.
2925 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2926 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2927 ifdefed out to avoid a warning.
2929 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2931 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2932 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2933 some alternative for GTK+ 2.6.
2935 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2937 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2939 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2940 specified for EmailAccountsDialog in UI spec.
2942 * src/maemo/easysetup/modest-easysetup-wizard.c:
2943 * src/maemo/easysetup/modest-easysetup-wizard.h:
2944 * src/maemo/modest-account-settings-dialog.c:
2945 * src/maemo/modest-account-settings-dialog.h:
2946 Reuse a member window widget for the connection-specific SMTP server accounts,
2947 so we can tell it to create/save the accounts only if we actually save changes.
2949 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2950 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2951 (modest_connection_specific_smtp_edit_window_get_settings):
2952 Return a struct instance for temporarily remembering the entered data.
2954 * src/maemo/modest-connection-specific-smtp-window.h:
2955 * src/maemo/modest-connection-specific-smtp-window.c:
2956 (modest_connection_specific_smtp_window_finalize),
2957 (modest_connection_specific_smtp_window_fill_with_connections),
2959 (modest_connection_specific_smtp_window_save_server_accounts),
2960 (update_model_server_names): Do not actually save data until asked,
2961 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2963 (on_selection_changed),
2964 (modest_connection_specific_smtp_window_init): Disable the edit
2965 button when nothing is selected.
2967 * src/modest-account-mgr-helpers.c:
2968 * src/modest-account-mgr-helpers.h:
2969 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2972 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2974 * src/modest-account-mgr-helpers.h:
2975 * src/modest-account-mgr-helpers.c:
2976 (modest_account_mgr_get_unused_account_name),
2977 (modest_account_mgr_get_unused_account_display_name): Added these
2978 utility functions, to avoid code duplication.
2980 * src/maemo/easysetup/modest-easysetup-wizard.c:
2981 (create_page_account_details), (create_account):
2982 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2983 (on_combo_security_changed),
2984 (modest_connection_specific_smtp_edit_window_init),
2985 (modest_connection_specific_smtp_edit_window_save_settings):
2986 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2987 * src/maemo/modest-connection-specific-smtp-window.c:
2988 (modest_connection_specific_smtp_window_finalize),
2989 (modest_connection_specific_smtp_window_fill_with_connections),
2990 (on_button_edit), (modest_connection_specific_smtp_window_init):
2991 * src/maemo/modest-connection-specific-smtp-window.h:
2992 Implementing saving of connection-specific server accounts.
2994 But I need to refactor this so we can save the data for each
2995 possible connection-specific account and only actually create the server accounts
2996 when the easysetup finished, or the OK button is pressed on the account settings
2999 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3001 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3002 (on_combo_security_changed):
3003 (modest_connection_specific_smtp_edit_window_init):
3004 Auto-fill the port number as in the account settings.
3006 (modest_connection_specific_smtp_edit_window_set_connection):
3007 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3008 * src/maemo/modest-connection-specific-smtp-window.c:
3009 (fill_with_connections), (on_button_edit),
3010 (modest_connection_specific_smtp_window_init):
3011 Turn the edit window into a dialog to simplify the code, and
3012 set a WM hint as in a GtkDialog, because only a popup can be on top of
3013 another window in Maemo, and popups usually have no WM decoration.
3015 * src/modest-defs.h:
3016 * src/modest-account-mgr-helpers.c:
3017 (modest_account_mgr_set_connection_specific_smtp),
3018 (modest_account_mgr_remove_connection_specific_smtp),
3019 (modest_account_mgr_get_connection_specific_smtp):
3020 * src/modest-account-mgr-helpers.h: Some functions to write the
3021 connection-specific SMTP server information. Not yet used.
3024 * src/widgets/modest-folder-view.c: (text_cell_data):
3025 Fix a warning about an uninitialized variable.
3026 (on_configuration_key_changed): Put an #ifdef around the use
3027 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
3029 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3031 * src/maemo/modest-account-settings-dialog.h:
3032 * src/maemo/modest-account-settings-dialog.c:
3033 Added connect_for_modified() utility function to mark the new modified boolean.
3035 (create_page_account_details), (create_page_user_details),
3036 (create_page_incoming), (create_page_outgoing), (on_response),
3037 (modest_account_settings_dialog_init),
3038 (modest_account_settings_dialog_set_account_name):
3039 Only warn about unsaved changes when there are actually unsaved changes.
3041 * src/modest-account-mgr-helpers.c:
3042 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
3043 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
3044 to get the data from there in future.
3046 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3048 * src/modest-defs.h:
3050 * src/modest-account-mgr-helpers.h:
3051 * src/modest-account-mgr-helpers.c:
3052 Store the security account setting in a single conf key instead of using
3053 the options list, so that the list is left for just the to-be-removed camel hack,
3054 and because gconf_client_set_list() is failing for some reason.
3056 * src/modest-account-mgr.c:
3057 (modest_account_mgr_add_server_account):
3058 * src/maemo/modest-account-settings-dialog.c:
3059 (modest_account_settings_dialog_set_account_name),
3060 (save_configuration): Use the renamed functions.
3063 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3065 * src/widgets/Makefile.am:
3066 * src/widgets/modest-limit-retrieve-combo-box.c:
3067 * src/widgets/modest-limit-retrieve-combo-box.h:
3068 * src/widgets/modest-retrieve-combo-box.c:
3069 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
3070 the account settings dialog.
3072 * src/modest-defs.h:
3073 * src/modest-account-mgr-helpers.h:
3074 * src/modest-account-mgr-helpers.c:
3075 (modest_server_account_get_option_secure_auth),
3076 (modest_server_account_set_option_secure_auth):
3077 * src/modest-account-mgr.c:
3078 (modest_account_mgr_add_server_account):
3079 Use the existing AUTH_MECH conf key for the secure-auth setting,
3080 instead of putting it in the list options, because this was actually used already.
3082 * src/maemo/modest-account-settings-dialog.c:
3083 (create_page_account_details),
3084 (modest_account_settings_dialog_set_account_name),
3085 (save_configuration):
3086 * src/maemo/modest-account-settings-dialog.h:
3087 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
3088 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
3090 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3092 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
3093 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
3094 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
3096 * src/modest-defs.h:
3097 * src/maemo/modest-account-settings-dialog.c:
3098 (create_page_incoming), (on_combo_outgoing_security_changed),
3099 (on_combo_incoming_security_changed), (create_page_outgoing),
3100 (modest_account_settings_dialog_set_account_name),
3101 (save_configuration): Load/Save the port number, and change it when the
3102 security combo changes, to suitable defaults.
3104 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3106 * src/modest-account-mgr.c:
3107 (modest_account_mgr_add_server_account): Set the security and secure-auth
3108 options, and add a comment saying that the other camel-specific options should be
3111 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3113 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
3115 * src/modest-tny-account-store.c: (account_list_free),
3116 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
3117 cursor->data after unreffing it. But there is some strange stuff there so it might not be
3120 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3122 * src/modest-protocol-info.c:
3123 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
3124 is required by our UI spec. Maybe something in our implementation will use this eventually.
3125 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
3126 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
3127 instead of the previous 0 placeholder.
3129 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
3130 secure-auth settings.
3131 * src/modest-account-mgr-helpers.h:
3132 * src/modest-account-mgr-helpers.c:
3133 (modest_server_account_data_get_option_secure_auth),
3134 (modest_server_account_set_option_secure_auth),
3135 (modest_server_account_data_get_option_security),
3136 (modest_server_account_set_option_security): Added this API for getting and setting the security
3137 and secure-auth settings.
3139 * src/maemo/modest-account-settings-dialog.h:
3140 * src/maemo/modest-account-settings-dialog.c:
3141 (modest_account_settings_dialog_finalize), (check_data),
3142 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
3143 about changing titles.
3144 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
3145 (save_configuration): Save the security and secure-auth settings.
3147 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
3148 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
3150 2007-04-17 Murray Cumming <murrayc@murrayc.com>
3152 * src/modest-defs.h:
3153 * src/modest-account-mgr.c:
3154 (modest_account_mgr_add_server_account):
3155 Added and used defines for the options key and value pair strings,
3156 that are used so far, though they do not seem to correspond to anything in our
3157 UI specs or ModestProtocol enum.
3159 * src/modest-account-mgr-helpers.h:
3160 * src/modest-account-mgr-helpers.c:
3161 (compare_option_strings_for_name),
3162 (modest_server_account_data_get_option_value),
3163 (modest_server_account_data_get_option_bool),
3164 (modest_account_mgr_get_server_account_option):
3165 Added helper functions for parsing the options GSList.
3167 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3169 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
3170 display name is based on the supplied account name.
3171 * src/modest-account-mgr.c:
3172 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
3173 with an inefficient, but good-enough, implementation.
3175 * src/maemo/easysetup/modest-easysetup-wizard.c:
3176 (create_page_account_details), (on_before_next), (create_account):
3177 Check for existing display names rather than (non-user-visible) account names, and just
3178 create and set a unique account name at the end.
3180 * src/maemo/modest-account-settings-dialog.c:
3181 (modest_account_settings_dialog_init),
3182 (modest_account_settings_dialog_set_account_name),
3183 (create_page_incoming): Show the display name, instead of the account name.
3184 (on_response): Do some (not all) extra checks, as in the UI spec.
3185 (save_configuration): Save the display name if it was changed.
3187 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3189 * po/en_GB.po: Added needed logical ID and translation.
3190 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3191 (init_view): Made the is-default column clicking work.
3193 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3196 * src/maemo/easysetup/Makefile.am:
3197 * src/maemo/easysetup/modest-easysetup-wizard.c:
3198 (modest_easysetup_wizard_dialog_init):
3199 * src/maemo/easysetup/provider-data-test.keyfile:
3200 * src/maemo/easysetup/provider-data.keyfile:
3201 Moved the provider data file to the new modest-providers-data package and used it from there.
3203 2007-04-16 Murray Cumming <murrayc@murrayc.com>
3205 * src/modest-local-folder-info.c:
3206 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
3207 N_() was already used on the static strings, but this just marks it for translation without
3208 using the translation.
3210 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3212 * src/maemo/modest-account-settings-dialog.c:
3213 (create_page_incoming),
3214 (modest_account_settings_dialog_set_account_name):
3215 Added comments about the need for new API in ModestAccountMgr to handle the authentication
3216 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
3217 I will do this if nobody else gets there first.
3219 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3221 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
3222 Saved much of the incoming and outgoing data too, though I cannot yet see how to
3223 save the security stuff.
3225 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3227 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3228 Set the email address and user fullname, which I now see must be
3231 * src/maemo/modest-account-settings-dialog.h:
3232 * src/maemo/modest-account-settings-dialog.c:
3234 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
3235 leave-on-server and authentication.
3236 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
3239 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3242 * src/maemo/modest-account-settings-dialog.c:
3243 * src/maemo/modest-account-settings-dialog.h:
3244 Most (but not all) of the widgets are now present as specified by the UI spec.
3245 No changes are yet saved, and some details are not properly shown yet.
3247 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
3249 2007-04-06 Murray Cumming <murrayc@murrayc.com>
3251 * src/maemo/Makefile.am:
3252 * src/maemo/modest-account-settings-dialog.c:
3253 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
3254 an existing account. Doesn't do much yet.
3256 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
3257 Open the accounts settings dialog when Edit is clicked.
3259 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3261 * src/maemo/easysetup/Makefile.am:
3262 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3264 * src/maemo/easysetup/modest-easysetup-wizard.c:
3265 (modest_easysetup_wizard_dialog_init):
3266 Try to get the source directory from the build system,
3267 instead of hard-coding "./" into the source code, when opening our local
3268 copies of the configuration files.
3269 But this still fails when opening the wizard from the Accounts window,
3270 maybe because the working directory seems to change at runtime.
3271 So the wizard will fail the second time unless you copy the files into their
3272 proper locations - see the stdout warnings for the paths.
3274 (create_page_account_details),(on_before_next):
3275 Check for existing non-server accounts instead of server accounts,
3276 so the default account name is useful again, and to prevent trying to
3279 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
3280 Show the wizard when New is clicked.
3282 * src/widgets/modest-account-view.c: (on_account_default_toggled),
3283 (init_view): Show the column headers, and show the columns that are
3284 specified in the UI specs. However, something in Maemo's GTK+ prevents
3285 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
3286 change the default account. This is despite unsetting the special properties.
3288 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3290 * docs/reference/modest-design.sgml: Corrected spelling mistake.
3291 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3292 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
3293 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
3294 to make that clearer.
3295 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
3297 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3299 * src/maemo/modest-account-view-window.c:
3300 (modest_account_view_window_init),
3301 (modest_account_view_window_new):
3302 Use the same buttons as specified in the
3303 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
3304 the existing widgets, which never had a chance of working.
3305 Put the ModestAccountView treeview in a scrolled window.
3306 Do not repeat the initialization in both _init() and _new().
3308 * src/widgets/modest-account-view.c: (update_account_view):
3309 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
3310 this widget and window shows no accounts.
3312 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
3314 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3316 * src/maemo/easysetup/modest-easysetup-wizard.c:
3317 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
3318 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
3319 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
3322 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
3323 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
3324 accounts exist yet, as in the UI spec.
3326 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
3328 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3330 * src/maemo/Makefile.am:
3331 * src/maemo/modest-connection-specific-smtp-edit-window.c:
3332 * src/maemo/modest-connection-specific-smtp-edit-window.h:
3333 New window for editing connection-specific smtp details.
3334 Not fully implemented.
3336 * src/maemo/modest-connection-specific-smtp-window.c:
3337 (modest_connection_specific_smtp_window_finalize) :
3338 unref the tree model.
3339 (on_button_edit): Show the edit window.
3341 2007-04-05 Murray Cumming <murrayc@murrayc.com>
3343 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
3346 * src/maemo/Makefile.am:
3347 * src/maemo/modest-connection-specific-smtp-window.c:
3348 * src/maemo/modest-connection-specific-smtp-window.h:
3349 New window for showing the list of connections, for connection-specific
3350 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
3351 * src/maemo/easysetup/modest-easysetup-wizard.c:
3352 (create_page_custom_outgoing): Show the new window when the button is clicked.
3354 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3356 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
3357 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3358 * src/maemo/modest-msg-edit-window.c:
3359 (modest_msg_edit_window_insert_image):
3360 * src/modest-conf.c: (modest_conf_key_escape):
3361 * src/modest-mail-operation.c:
3362 (modest_mail_operation_send_new_mail):
3363 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
3364 (modest_ui_actions_on_new_account):
3365 * src/widgets/modest-attachment-view.c: (update_filename_request):
3366 * src/widgets/modest-mail-header-view.c:
3367 Corrected warnings that were breaking the build, by commenting out unused variables,
3368 and a function, and by including a header.
3370 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3372 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
3373 so we can #ifdef around platform-specific code when necessary.
3374 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
3375 to allow this to build for the GNOME platform too.
3377 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3379 * src/maemo/easysetup/modest-easysetup-wizard.c:
3380 Added util_increment_name() and used it in create_page_account_details()
3381 to make sure that the default account name is always a new name.
3383 (modest_easysetup_wizard_dialog_init),
3384 (set_default_custom_servernames): Some minor memory management fixes.
3386 2007-04-04 Murray Cumming <murrayc@murrayc.com>
3390 * src/modest-runtime.c: (init_i18n): Restored the translation
3391 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
3392 are defined in config.h, and the translations are installed.
3394 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
3395 is defined for translation.
3397 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3399 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
3401 * src/maemo/easysetup/modest-easysetup-wizard.c:
3402 (modest_easysetup_wizard_dialog_init):
3403 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
3404 Use realistic paths (though they should use $prefix generically) to the
3405 mcc_mapping and provider-data.keyfile files which might work when they
3406 are installed by the future version of the operator-wizard package,
3407 and then fallback to paths in our source code, with an explanatory
3410 2007-04-03 Murray Cumming <murrayc@murrayc.com>
3414 * src/maemo/Makefile.am:
3415 * src/maemo/easysetup/: Added files from the previously-exernal
3416 osso-modest-easysetup.
3417 * src/maemo/modest-main-window-ui.h:
3418 * src/modest-ui-actions.c:
3419 * src/modest-ui-actions.h:
3420 Added modest_ui_actions_on_new_account() as a signal handler for the
3421 New Account menu item. It shows the easysetup wizard.
3422 * po/en_GB.po: Added additional needed logical IDs and translations.