1 2007-06-14 Murray Cumming <murrayc@murrayc.com>
5 Added modest_init_get_default_header_view_column_ids().
7 * src/modest-widget-memory.c: (restore_settings_header_view):
8 Use the new function to get defaults, if the gconf key is empty,
9 instead of not creating any columns. This seems to fix the
10 empty right-hand pane problems.
12 * src/widgets/modest-header-view.h: Improved documentation.
14 2007-06-13 Murray Cumming <murrayc@murrayc.com>
16 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
17 Revert the use of the display name as the account name, because this
18 is generally wrong and would break the code that follows.
20 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
22 * src/maemo/easysetup/modest-easysetup-wizard.c:
23 (check_for_supported_auth_methods), (on_before_next),
26 More correct fix for projects.maemo.org bug NB# 58991
27 Do not longer accept AUTH_PASSWORD as secure method and choose
28 correct method when creating the account.
30 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
32 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
33 Fixed projects.maemo.org bug NB# 58991
35 2007-06-13 Murray Cumming <murrayc@murrayc.com>
37 * src/modest-init.c: (modest_init_init_core),
38 (modest_init_local_folders): Fixed compilation errors.
40 2007-06-13 Murray Cumming <murrayc@murrayc.com>
42 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
43 Remove unnecessary lib/include, though it is good in principle when needed.
45 * src/modest-init.c: (modest_init_one_local_folder),
46 (modest_init_local_folders):
47 * src/modest-init.h: Initialize the .modest library for memory cards,
48 instead of just doing nothing for them. This should allow us to create
49 folders there, fixing projects.maemo.org bug NB#59297.
51 2007-06-13 Murray Cumming <murrayc@murrayc.com>
53 * libmodest-dbus-client/libmodest-dbus-client.c:
54 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
55 (libmodest_dbus_client_compose_mail),
56 (libmodest_dbus_client_open_message),
57 (libmodest_dbus_client_send_and_receive),
58 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
60 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
61 (on_idle_open_message), (modest_dbus_req_handler),
62 (search_result_to_message), (modest_dbus_req_filter):
63 * src/modest-search.c: (add_hit), (modest_search_folder),
64 (modest_search_all_accounts): Improved debug messages.
66 * tests/dbus_api/test_open_message.c: (main): Improved comments.
68 * src/modest-tny-account-store.c:
69 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
72 2007-06-13 Murray Cumming <murrayc@murrayc.com>
75 2007-06-12 Murray Cumming <murrayc@murrayc.com>
77 * src/modest-tny-account-store.c: (get_server_accounts):
78 Call modest_tny_local_folders_account_add_merged_outbox_folders()
79 even when there are no accounts, so that the Outbox folder is always
80 visible. This fixes projects.maemo.org bug NB#60158.
82 2007-06-12 Murray Cumming <murrayc@murrayc.com>
84 * src/maemo/modest-main-window.c: (create_details_widget):
85 Use the mcen_va_never logical ID.
87 2007-06-12 Murray Cumming <murrayc@murrayc.com>
89 * src/dbus_api/modest-dbus-api.h:
90 * src/dbus_api/modest-dbus-callbacks.c:
91 (on_idle_open_default_inbox), (on_open_default_inbox),
92 (modest_dbus_req_handler):
93 Added a new OpenDefaultInbox method.
95 * libmodest-dbus-client/libmodest-dbus-client.h:
96 * libmodest-dbus-client/libmodest-dbus-client.c:
97 Added libmodest_dbus_client_open_default_inbox() to call the new
98 dbus method. This should be useful to projects.maemo.org bug NB#57214,
99 though it should maybe be used by a new osso-email-interface function.
101 * tests/dbus_api/Makefile.am:
102 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
105 2007-06-12 Murray Cumming <murrayc@murrayc.com>
107 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
108 NULL, so that the signals get all the keys. This should not actually
109 change any behaviour because we currently update everything when anything
112 2007-06-12 Murray Cumming <murrayc@murrayc.com>
114 * src/widgets/modest-folder-view.c: (text_cell_data),
115 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
116 (find_inbox_iter): If tinymail tells us that the folder is
117 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
118 This causes the inbox to be selected at startup, fixing part of
119 projects.maemo.org bug NB#56305.
121 * src/modest-ui-dimming-rules.c:
122 (modest_ui_dimming_rules_on_tools_smtp_servers):
123 * src/modest-ui-dimming-rules.h: Added a callback function to dim
124 the SMTP servers menu item.
125 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
126 that the SMTP Servers menu item is dimmed when there are no accounts,
127 as a future version of the UI spec will require. This fixes
128 projects.maemo.org bug NB#56305.
130 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
132 * src/maemo/modest-maemo-utils.c:
133 (modest_maemo_utils_get_supported_secure_authentication_methods):
134 Added label to dialog instead of unreadable title
136 * src/maemo/modest-main-window.c: (sync_accounts_cb),
137 (modest_main_window_new):
138 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
141 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
142 * src/modest-account-mgr.h:
143 Added method to avoid code duplication
145 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
146 (modest_ui_actions_on_send_receive):
147 Use modest_account_mgr_has_accounts
149 2007-06-11 Murray Cumming <murrayc@murrayc.com>
151 * src/maemo/easysetup/modest-presets.c:
152 (modest_presets_get_info_server_security): Do not report secure auth
154 * src/modest-protocol-info.c: Use the defines for the gconf key names
155 for secure authentication. This was not working because we were writing
156 Password and reading password, and the check was case sensitive.
157 With this, gmail now works for receiving and sending when created via
160 2007-06-11 Murray Cumming <murrayc@murrayc.com>
162 * src/maemo/easysetup/modest-presets.c:
163 (modest_presets_get_info_server_security): Correct the key name for
164 SecureSmtp, because it seems to be case-sensitive.
165 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
166 Do not try to get the 0th notebook page if there are 0 pages, to
169 2007-06-11 Murray Cumming <murrayc@murrayc.com>
171 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
172 Prevent use of the new notification feature for now, because it currently
173 shows one dialog for each new email, which is annoying.
175 2007-06-11 Murray Cumming <murrayc@murrayc.com>
177 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
178 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
179 when no country was selected, so that we show the global ones.
180 * src/maemo/easysetup/modest-presets.c:
181 (modest_presets_get_providers): Return only the global providers, not
182 all providers when mmc=0 was requested.
184 2007-06-11 Murray Cumming <murrayc@murrayc.com>
186 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
187 (easysetup_provider_combo_box_fill): Remove debug code that showed the
188 provider ID in the combo.
190 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
191 Do not show the page numbers, because it would be confusing when we add
192 the 2 extra pages for the custom setup, when the user chooses the "Other"
193 provider. This fixes projects.maemo.org bug NB#59028
195 * src/modest-init.c: (modest_init_init_core),
196 (modest_init_local_folders):
198 * src/modest-tny-account.c:
199 (modest_tny_account_new_for_local_folders): Do not create default folders
200 for the memory card. This should fix projects.maemo.org bug NB#59328.
202 2007-06-11 Murray Cumming <murrayc@murrayc.com>
204 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
205 Free the changed_conf_keys string items. They are already freed in the
206 idle handler if that runs first.
208 2007-06-11 Murray Cumming <murrayc@murrayc.com>
210 * src/modest-ui-actions.c:
211 (modest_ui_actions_on_password_requested): Check that the server name
212 is not NULL, because I just saw a password dialog with (null) as the
215 * src/modest-tny-folder.[h|c]: Added
216 modest_tny_folder_is_memory_card_folder().
217 * src/modest-ui-dimming-rules.c:
218 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
219 menu item for memory cards, as per the UI spec (section 7.4). This should
220 fix projects.maemo.org bug NB#59297.
222 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
224 * src/maemo/modest-main-window.c: (sync_accounts_cb):
225 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
226 is another problem with the code, see Murray's comment at line 772)
228 2007-06-08 Murray Cumming <murrayc@murrayc.com>
230 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
231 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
232 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
233 (load_from_file), (easysetup_country_combo_box_init),
234 (easysetup_country_combo_box_get_active_country_ids),
235 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
236 instead of just one ID, to avoid duplicate country names in the UI.
238 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
239 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
240 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
241 a single ID, avoiding duplicate providers.
242 * src/maemo/easysetup/modest-easysetup-wizard.c:
243 (on_combo_account_country): Adapt to use a list.
245 2007-06-08 Murray Cumming <murrayc@murrayc.com>
247 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
248 keys changed in the last X seconds.
250 * src/modest-account-mgr.h:
251 * src/modest-account-mgr.c: (on_timeout_notify_changes),
252 (on_key_change), (modest_account_mgr_class_init),
253 (modest_account_mgr_init), (modest_account_mgr_finalize):
254 As the keys are changed, save them in a GSList* and signal that GSList*
255 further every X seconds, to batch changes, to allow us to do just one
256 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
257 bug NB#56941 and other (UI-blocking) delays when changing account settings.
259 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
260 changed signal signature.
262 * src/modest-conf.c: (modest_conf_set_list),
263 (modest_conf_on_change): Reenable notification.
265 (modest_conf_maemo_fake_on_change): Comment out the hack that
266 notified immediately instead of asynchronously.
268 * src/widgets/modest-account-view.h:
269 * src/widgets/modest-account-view.c:
270 (update_account_view): Select the previously-selected account ID,
271 if possible. This fixes projects.maemo.org bug NB#56933.
273 (on_account_changed), (on_account_removed),
274 (modest_account_view_select_account):
276 Remove the block/unblock functions
277 because they were not useful.
279 * src/maemo/modest-account-view-window.c:
280 (on_delete_button_clicked), (on_edit_button_clicked),
281 (on_new_button_clicked): Remove the use of the non-working block/unblock.
283 2007-06-08 Murray Cumming <murrayc@murrayc.com>
285 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
286 Improve the error dialog to show Incorrect Account Settings, which seems
287 clearer, and say that the internal error message (to be removed from the
288 dialog later) is often misleading.
289 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
291 * src/modest-tny-account.c:
292 (modest_tny_account_new_from_server_account): Uncomment the printf of the
293 URL because this is so useful for debugging on the device.
295 * src/widgets/modest-serversecurity-combo-box.c:
296 (modest_serversecurity_combo_box_fill): Correct a logical ID.
298 2007-06-08 Murray Cumming <murrayc@murrayc.com>
300 * src/modest-mail-operation.c:
301 (modest_mail_operation_send_new_mail):
302 Added a comment about a nasty but apparently harmless message. Details
303 added to the wiki g_warnings() page.
305 2007-06-08 Murray Cumming <murrayc@murrayc.com>
307 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
308 (modest_tny_send_queue_class_init):
309 Do not use the priv struct because it is empty, to avoid g_warnings
310 about a non-existant priv struct.
312 * src/modest-tny-account-store.c:
313 (modest_tny_account_store_get_server_account),
314 (modest_tny_account_store_get_transport_account_for_open_connection
315 ): Do not try to get transport server accounts for local folders,
316 because they don't have any. This avoids a g_warning().
318 * src/maemo/modest-main-window.c:
319 (modest_main_window_notify_send_receive_initied),
320 (on_configuration_key_changed):
321 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
323 * src/modest-mail-operation.c:
324 (modest_mail_operation_update_account):
325 * src/modest-tny-account-store.h:
326 * src/modest-tny-account.c:
327 (modest_tny_account_get_special_folder),
328 (modest_tny_account_new_for_local_folders),
329 (modest_tny_account_new_for_per_account_local_outbox_folder):
330 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
331 * src/modest-tny-local-folders-account.c:
332 (add_account_folders_to_merged_folder):
333 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
334 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
335 (modest_ui_actions_on_send):
336 * src/widgets/modest-folder-view.c: (update_model):
337 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
338 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
339 modest_tny_account_store_get_tny_account_by_account() to
340 modest_tny_account_store_get_server_account() to make the code clearer.
342 2007-06-07 Marcus Bauer <marcusb@openismus.com>
344 * src/dbus_api/modest-dbus-api.h:
345 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
346 * src/maemo/modest-msg-edit-window.c:
347 (modest_msg_edit_window_attach_file_noninteractive):
348 added g_warning in case the file to be attached does not exist
349 * tests/dbus_api/test_compose_mail.c: (main):
350 removed obsolete comment, added generic files as test case
352 2007-06-07 Murray Cumming <murrayc@murrayc.com>
354 * src/modest-tny-account-store.c: (get_server_accounts):
355 Create the local folders account only once, not once for each outbox, and
356 not only when there are some outboxes.
358 2007-06-07 Murray Cumming <murrayc@murrayc.com>
360 * src/widgets/modest-folder-view.c: (update_model): Comment out some
361 code that is causing a crash at startup. Sergio says that he is fixing this.
363 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
365 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
366 * src/maemo/modest-account-settings-dialog.c:
367 (create_page_outgoing),
368 (modest_account_settings_dialog_set_account_name),
369 (save_configuration):
370 - Fixed handling of the "Use secure authentication" toggle to comply with
371 the ui specification. See also projects.maemo.org bug NB#58400
373 - Restore the Secure connection setting combo correctly when loading
376 * src/maemo/modest-maemo-utils.c:
377 (on_camel_account_get_supported_secure_authentication),
378 (modest_maemo_utils_get_supported_secure_authentication_methods):
379 Fixed a crasher if operation is canceled
381 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
382 (modest_protocol_info_auth_is_secure):
383 * src/modest-protocol-info.h:
385 Added two new methods to determine if a protocol/auth method is secure/encrypted in
386 the sense of the "Use secure authentication" toggle.
388 2007-06-07 Murray Cumming <murrayc@murrayc.com>
390 * src/modest-tny-account-store.h:
391 * src/modest-tny-account-store.c:
392 Added modest_tny_account_store_get_local_folders_account().
394 * src/modest-tny-folder.h:
395 * src/modest-tny-folder.c:
396 (modest_tny_folder_get_account):
397 Added this replacement for tny_folder_get_account() which returns
398 the local-folders account for TnyMergeFolders, to avoid the
399 warning about the unimplemented get_account_func() vfunc().
401 (modest_tny_folder_get_rules),
402 * src/modest-ui-actions.c:
403 (modest_ui_actions_on_folder_selection_changed):
404 * src/modest-mail-operation.c:
405 (modest_mail_operation_remove_folder),
406 (modest_mail_operation_xfer_folder),
407 (modest_mail_operation_rename_folder),
408 (modest_mail_operation_get_msg),
409 (modest_mail_operation_get_msgs_full),
410 (modest_mail_operation_remove_msg),
411 (modest_mail_operation_xfer_msgs),
412 (modest_mail_operation_refresh_folder):
413 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
415 2007-06-07 Murray Cumming <murrayc@murrayc.com>
417 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
418 (modest_server_account_set_security):
419 * src/modest-defs.h: Add comments explaining that our
420 UI spec means TLS when it says Normal, so these do not look like errors.
422 * src/modest-tny-account.c:
423 (modest_tny_account_new_from_server_account): Use the new tinymail
424 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
425 for TLS. This should fix projects.maemo.org bug NB#58460.
427 2007-06-06 Murray Cumming <murrayc@murrayc.com>
429 * src/maemo/easysetup/modest-easysetup-wizard.c:
430 (create_account): Correct the position of the gconf sanity check warning.
431 (on_button_edit_advanced_settings): Show the dialog immediately, instead
432 of using the g_idle_add() hack, because this does not seem to be necessary
433 on osso 1.1. It might even work on Maemo Bora if the problems were actually
434 caused by something other than maemo's gconf.
435 This fixes projects.maemo.org bug #59022.
437 2007-06-06 Murray Cumming <murrayc@murrayc.com>
439 * src/modest-account-mgr-helpers.c:
440 (modest_account_mgr_get_default_account): Do not check that the account
441 exists if there is no default account (NULL), to fix a runtime warning.
443 2007-06-06 Murray Cumming <murrayc@murrayc.com>
445 * src/widgets/modest-folder-view.c: (update_model):
446 Do not unref the treemodel before we have finished with it.
447 This prevents a valgrind warning and an occasional crash at startup.
449 2007-06-06 Marcus Bauer <marcusb@openismus.com>
451 * libmodest-dbus-client/libmodest-dbus-client.h:
452 added libmodest_dbus_client_compose_mail()
453 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
455 added functions needed for SendAsMail() functionality
456 * src/maemo/modest-msg-edit-window.c:
457 (modest_msg_edit_window_attach_file_noninteractive):
458 non interactively attaching files to message edit window
459 * src/widgets/modest-msg-edit-window.h:
460 * tests/dbus_api/Makefile.am:
461 added test_compose_mail.c
462 * tests/dbus_api/test_compose_mail.c: (main):
464 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
466 * src/modest-account-view.c:
467 Fixed bug projects.maemo.org bug NB#59307
469 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
471 * src/maemo/easysetup/modest-easysetup-wizard.c:
472 (get_serverport_incoming), (on_before_next), (create_account):
473 * src/maemo/modest-account-settings-dialog.c:
474 (modest_account_settings_dialog_set_account_name):
475 * src/maemo/modest-maemo-utils.c:
476 (on_camel_account_get_supported_secure_authentication_status),
477 (on_camel_account_get_supported_secure_authentication),
478 (on_secure_auth_cancel),
479 (modest_maemo_utils_get_supported_secure_authentication_methods):
481 Implemented security authentication for settings and easysetup.
483 2007-06-05 Murray Cumming <murrayc@murrayc.com>
485 * src/maemo/modest-main-window.c: (create_details_widget):
486 Show the total size for memory card accounts too, instead of showing
487 the name again. Fixes bug projects.maemo.org bug NB#59307.
489 2007-06-05 Murray Cumming <murrayc@murrayc.com>
492 * src/modest-tny-simple-folder-store.c:
493 * src/modest-tny-simple-folder-store.h: Removed.
495 * src/modest-tny-local-folders-account.h
496 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
497 for the local-folders maildir, with an extra TnyMergedFolder containing
498 the folders of the per-account outbox store accounts.
499 * src/modest-tny-account-store.c: (get_server_accounts):
500 Add the outboxes to the special local folders account after creating it.
502 * src/modest-tny-account.c:
503 (modest_tny_account_new_for_local_folders): Create the derived
504 account when creating the main local-folders account.
506 * src/maemo/modest-main-window.c: (create_details_widget),
507 (modest_main_window_set_contents_style):
508 Adapted to the use of the derived account instead of the folder store.
510 * src/modest-ui-actions.c:
511 (modest_ui_actions_on_folder_selection_changed):
512 * src/modest-ui-dimming-rules.c:
513 (modest_ui_dimming_rules_on_new_folder):
514 * src/widgets/modest-folder-view.c: (text_cell_data),
515 (icon_cell_data), (filter_row), (update_model),
516 (get_cmp_rows_type_pos):
519 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
520 Do not get the priv struct, because no priv struct has been set,
521 to avoid a runtime warning.
523 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
524 #ifelse with #else, to fix a warning, to fix the build.
527 2007-06-05 Christian Kellner <ckellner@openismus.com>
529 * libmodest-dbus-client/libmodest-dbus-client.c:
530 Fix small typo in doc (why do you always see them
531 AFTER committing stuff?)
534 2007-06-05 Christian Kellner <ckellner@openismus.com>
536 * libmodest-dbus-client/libmodest-dbus-client.c:
537 (libmodest_dbus_client_search):
538 Initialize hit list with NULL. Also set folder list
539 to "" if NULL was supplied.
542 2007-06-03 Christian Kellner <ckellner@openismus.com>
544 * libmodest-dbus-client/libmodest-dbus-client.c:
545 (modest_search_hit_list_free):
546 Make it save to call it with NULL.
548 * src/dbus_api/modest-dbus-callbacks.c:
549 * src/modest-search.c:
550 Return full ModestSearchHits as the search result list not TnyHeader
551 since can't be around withouth the correspoding TnyFolder.
553 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
555 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
556 Added currently commented code to check for secure auth
558 * src/maemo/modest-account-settings-dialog.c: (on_response),
559 (save_configuration), (show_ok):
560 Fixed projects.maemo.org bugs NB #59248 and #59251
562 * src/maemo/modest-maemo-utils.c:
563 (on_camel_account_get_supported_secure_authentication_status),
564 (on_camel_account_get_supported_secure_authentication),
565 (modest_maemo_utils_get_supported_secure_authentication_methods):
566 * src/maemo/modest-maemo-utils.h:
567 Moved get_supported_secure_authentication() method here to be able
568 to use it from easysetup wizard.
570 * src/modest-pair.c: (on_pair_compare_as_string):
571 Should compare string with first part of pair and not
572 strcmp pairs which will crash.
574 * src/modest-protocol-info.c:
575 (modest_protocol_info_protocol_is_store):
576 * src/modest-protocol-info.h:
577 Added modest_protocol_info_get_auth_protocol_name()
579 2007-06-03 Armin Burgmeier <armin@openismus.com>
581 * src/modest-mail-operation.c:
582 (modest_mail_operation_get_msgs_full): Set priv->account also when
583 only retrieving a single message. This avoids a crash when canceling
586 (modest_mail_operation_notify_end): Do not explicitely remove the
587 operation from the queue but only emit the progress_changed signal.
588 The queue itself listens to that signal to remove the operation when
589 it is finished. This reduces coupling and removes a potential deadlock
590 when modest_mail_operation_notify_end() is called from the queue
591 itself. If that is a problem performance-wise, I would suggest to
592 implement a status-changed signal or something.
594 * src/modest-mail-operation-queue.c: Make sure to never call a
595 function from another file while the queue is locked. This (hopefully)
596 fixes another deadlock when exiting the application while retrieving
599 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
601 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
602 Fixed build if libogs is not available
604 2007-06-03 Christian Kellner <ckellner@openismus.com>
606 * libmodest-dbus-client/libmodest-dbus-client.h:
607 * libmodest-dbus-client/libmodest-dbus-client.c:
608 (libmodest_dbus_client_delete_message):
609 Implement deletion of messages (Client side).
611 (modest_search_hit_free),
612 (modest_search_hit_list_free):
613 Utility functions to free the result hits.
615 * src/dbus_api/modest-dbus-api.h:
616 * src/dbus_api/modest-dbus-callbacks.c:
618 (modest_dbus_req_handler):
619 Implement deletion of messages (Server side).
621 * tests/dbus_api/test_search.c: (main):
624 * tests/dbus_api/Makefile.am:
625 * tests/dbus_api/test_delete_message:
626 Add little test for the message deletion logic
628 2007-06-03 Armin Burgmeier <armin@openismus.com>
630 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
631 when the operation queue was not empty. projects.maemo.org bug
634 2007-06-03 Armin Burgmeier <armin@openismus.com>
636 * src/widgets/modest-account-view.c
637 (on_account_default_toggled): Toggle default account column
638 explicitely instead of waiting for gconf notification (which is
639 currently ignored). This should fix projects.maemo.org bug NB#56910
640 for now. It should probably be removed when gconf notifications are
643 2007-06-03 Christian Kellner <ckellner@openismus.com>
645 * libmodest-dbus-client/libmodest-dbus-client.c:
646 Removed debugging spew.
648 * src/dbus_api/modest-dbus-callbacks.c:
649 Added debugging info.
651 * src/modest-search.c:
652 (modest_search_all_accounts):
653 Use tny_account_store_get_accounts () on the account store
654 to get all accounts which is the way to get all accounts.
656 * tests/dbus_api/test_search.c: (main):
657 Make it possible to supply the search term on the command line.
659 2007-06-03 Christian Kellner <ckellner@openismus.com>
661 * libmodest-dbus-client/libmodest-dbus-client.c:
662 * libmodest-dbus-client/libmodest-dbus-client.h:
663 Implement searching for mesages over raw dbus. (Client side)
665 * src/dbus_api/Makefile.am:
666 * src/dbus_api/modest-dbus-api.h:
667 * src/dbus_api/modest-dbus-callbacks.c:
668 * src/dbus_api/modest-dbus-callbacks.h:
669 Search framework (Server side). Also implement on_idle_open_message().
671 * src/maemo/modest-platform.c: (modest_platform_init):
672 Prepare for raw dbus/osso rpc interaction.
674 * src/modest-search.h:
675 Changed minsize from unspecific guint to guint32.
677 * src/modest-search.c:
679 Added strange hack which magically made tnymail work.
681 (modest_search_folder),
682 (modest_search_account),
683 (modest_search_all_accounts):
684 Implement helper functions to search all accounts, specific account
687 * tests/dbus_api/Makefile.am:
688 * tests/dbus_api/test_open_message.c:
689 Read url to open from commandline.
691 * tests/dbus_api/test_search.c:
692 Implement small test for dbus search stuff
694 2007-06-02 Armin Burgmeier <armin@openismus.com>
696 * src/maemo/modest-account-settings-dialog.c: Changed window title to
697 include account type and account title. This fixes projects.maemo.org
700 * src/maemo/modest-account-view-window.c: Set a title for the window.
702 2007-06-02 Armin Burgmeier <armin@openismus.com>
704 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
705 incoming and outgoing server name based on email address and server
706 types as long as the names have not been edited manually. This fixes
707 projects.maemo.org bug NB#58671.
709 2007-06-02 Armin Burgmeier <armin@openismus.com>
711 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
712 server type cannot be changed in future to the incoming details page
713 when creating an account. This fixes projects.maemo.org bug NB#59029.
715 2007-06-02 Armin Burgmeier <armin@openismus.com>
717 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
718 and assigned max width chars so that they wrap instead of being
719 truncated. Fixes projects.maemo.org bug NB#56126.
721 2007-06-02 Armin Burgmeier <armin@openismus.com>
723 * src/maemo/modest-connection-specific-smtp-window.c: Add an
724 introductory note to the connection specific smtp servers dialog, as
725 section 8.12 of the email UI specification requires. This fixes
726 projects.maemo.org bug NB#59212.
728 2007-06-01 Murray Cumming <murrayc@murrayc.com>
730 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
731 Check for running mail operations, and offer to cancel them, as per the UI
732 spec. This fixes projects.maemo.org bug NB#59041 .
733 However, I suspect that tinymail may still use the network connection
734 in ways that we cannot detect or cancel. But it should at least adapt to
737 2007-06-01 Murray Cumming <murrayc@murrayc.com>
739 * src/modest-tny-account-store.c: (recreate_all_accounts),
740 (get_cached_accounts), (get_server_accounts): Do more sensible
741 ref-counting of the temporarily-cached outbox accounts list. This seems
742 to fix a crash when entering the password when the password was wrong.
744 2007-06-01 Murray Cumming <murrayc@murrayc.com>
746 * src/gnome/modest-main-window.c: (connect_signals):
747 * src/modest-tny-account-store.c: (get_password),
748 (modest_tny_account_store_alert): Added comments and clues and
749 commented-out code about how we currently fail to deal with connection
750 errors and wrong passwords, and how we should.
752 2007-06-01 Murray Cumming <murrayc@murrayc.com>
754 * src/widgets/modest-retrieve-combo-box.c:
755 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
756 This fixes projects.maemo.org bug NB#58472 .
758 2007-06-01 Murray Cumming <murrayc@murrayc.com>
760 * src/maemo/easysetup/modest-easysetup-wizard.c:
761 (create_page_complete_easysetup):
762 (create_page_complete_custom): Correct the last commit,
763 putting the correct sentences in the correct pages.
765 2007-06-01 Murray Cumming <murrayc@murrayc.com>
767 * src/maemo/easysetup/modest-easysetup-wizard.c:
768 (create_page_complete_custom): Show the second sentence of text
769 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
772 2007-06-01 Murray Cumming <murrayc@murrayc.com>
774 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
775 Set the leave-on-server conf key by default. This fixes
776 projects.maemo.org bug NB#59258 .
778 2007-06-01 Murray Cumming <murrayc@murrayc.com>
780 * src/maemo/modest-account-view-window.c:
781 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
782 logical ID for the confirmation messages. Fixed projects.maemo.org bug
785 2007-06-01 Murray Cumming <murrayc@murrayc.com>
787 * src/maemo/easysetup/modest-easysetup-wizard.c:
788 (create_caption_new_with_asterisk):
789 * src/maemo/modest-account-settings-dialog.c:
790 (create_caption_new_with_asterisk):
791 Uncomment the code to add the asterisk, because they are no longer in the
792 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
793 (update_incoming_server_title): Add an asterisk here too.
795 2007-06-01 Murray Cumming <murrayc@murrayc.com>
797 * src/maemo/modest-maemo-global-settings-dialog.c:
798 (current_connection): Check that we are even connected before trying to
799 get the current connection name, to prevent a warning.
801 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
802 Change the comments because tny_maemo_conic_device_connect() is now meant to
804 * src/modest-mail-operation.c:
805 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
806 make sure we have a connection and fail if we can't connect.
808 2007-05-31 Murray Cumming <murrayc@murrayc.com>
810 * src/maemo/modest-main-window.c:
811 (on_account_store_connecting_finished): Do not try to get the
812 connection ID if we are not really connected. I am surprised that
813 this signal handler is called when we are not connected.
815 2007-05-31 Murray Cumming <murrayc@murrayc.com>
817 * src/modest-error.h:
818 * src/modest-ui-actions.c:
819 (modest_ui_actions_get_msgs_full_error_handler):
820 Renamed an enum, added comments, added an enum
821 for retrieve-limit errors.
823 * src/modest-mail-operation.c: (foreach_add_item),
824 (internal_folder_observer_update), (update_account_thread),
825 (modest_mail_operation_get_msgs_full):
826 (modest_mail_operation_update_account),
827 Added comments about how this works, and some code that should
828 (but does not) check the retrieve-limit. See the TODO comment.
830 2007-05-31 Murray Cumming <murrayc@murrayc.com>
832 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
833 Initialize help_id to fix the build. Warnings are good.
835 2007-05-31 Murray Cumming <murrayc@murrayc.com>
837 * src/widgets/modest-hbox-cell-renderer.c:
838 (modest_hbox_cell_renderer_append):
839 * src/widgets/modest-vbox-cell-renderer.c:
840 (modest_vbox_cell_renderer_append):
841 Fix the last commit by doing an extra ref.
843 2007-05-31 Murray Cumming <murrayc@murrayc.com>
845 * src/widgets/modest-hbox-cell-renderer.c:
846 (modest_hbox_cell_renderer_append):
847 * src/widgets/modest-vbox-cell-renderer.c:
848 (modest_vbox_cell_renderer_append):
849 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
850 to fix the build with Maemo Bora.
851 However, there seems to be a remaining crash, probably due to reference
854 2007-05-30 Murray Cumming <murrayc@murrayc.com>
856 * src/modest-tny-account.c:
857 (modest_tny_account_new_for_local_folders):
858 Use hildon_file_system_info_async_new() to get a better name for
859 the memory card account, setting it as the account name.
860 The timing seems to work, but this is probably
861 not the best place to do this. See the TODO comment.
862 * src/maemo/modest-main-window.c: (create_details_widget):
863 * src/widgets/modest-folder-view.c: (text_cell_data):
864 Use the tny account name instead of hardcoding a name.
866 2007-05-30 Christian Kellner <ckellner@openismus.com>
868 * src/modest-search.c: (modest_search):
869 Correctly set part_search_func even if we have already parsed
870 the query and thus a valid OgsTextSearcher object.
872 2007-05-30 Christian Kellner <ckellner@openismus.com>
875 Search and check for libogs.
878 Incooparte the ogs build env.
880 * src/modest-mime-part-search-stream.c:
881 * src/modest-mime-part-search-stream.h:
882 Removed since we do the real searching now in modest-search.c.
884 * src/modest-search.c:
885 * src/modest-search.h:
886 Implement support for ogs. We use that if available and requested
887 and fall back to modest_text_utils_utf8_strcmp (). The search logic
888 should now handle the corner case when the search term is spread
889 across multiple reads.
890 Also the logic in modest_search () was corrected to search all
891 requested fields until one is found.
893 2007-05-30 Murray Cumming <murrayc@murrayc.com>
895 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
898 * src/modest-init.c: Made modest_init_local_folders() take a
899 path and be public so we can iniitialize maildir folders on
902 * src/modest-local-folder-info.h:
903 * src/modest-local-folder-info.c:
904 (modest_local_folder_info_get_maildir_path): Add a path parameter.
906 * src/modest-tny-account.c:
907 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
908 still means the standard local-folders path on the local volume.
910 * src/modest-tny-account-store.c:
911 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
912 signal so we can detect mount/unmount of the MMC1 card, and do an update of
913 all accounts when that happens.
914 (get_server_accounts): If the MMC1 card is mounted, create a store account for
915 this too, so it shows up in the treeview.
917 2007-05-28 Murray Cumming <murrayc@murrayc.com>
919 * src/maemo/modest-maemo-global-settings-dialog.c:
920 (current_connection):
921 * src/widgets/modest-global-settings-dialog.c:
922 (current_connection_default):
923 Use the enum values instead of 0, 1 and -1,
924 to make the code clearer.
926 * src/modest-account-mgr-helpers.c:
927 (modest_account_mgr_get_connection_specific_smtp): Make this code
930 * src/modest-runtime.h:
931 * src/modest-runtime.c:
932 Added modest_runtime_remove_all_send_queues().
933 * src/maemo/modest-main-window.c:
934 (on_account_store_connecting_finished): Recreate the send queues,
935 using the appropriate transport accounts for this new connection.
936 Some futher adapting might be needed if the old send queues are not
937 automatically stopped at this point.
939 * src/modest-tny-account-store.c: (get_server_accounts):
940 Create the connection-specific transport accounts, so that they can
941 be found later by their ID.
943 * src/modest-tny-account.h:
944 * src/modest-tny-account.c:
945 Added modest_tny_account_new_from_server_account_name().
946 modest_tny_account_new_from_server_account(): Do not create the
947 send queues here, because they will be
948 recreated anyway when the connection changes for the first time.
950 2007-05-28 Murray Cumming <murrayc@murrayc.com>
952 * src/modest-local-folder-info.h:
953 * src/modest-local-folder-info.c:
954 (modest_per_account_local_outbox_folder_info_get_maildir_path),
955 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
956 tbox_folder): Take a modest account name instead of a server TnyAccount,
957 so we can have per-modest-account rather than per-transport-account
959 We must make sure that we change or recreate the exisitng send queues
960 when the connection changes for connection-specific transport accounts.
962 * src/modest-tny-account-store.c:
963 (create_per_account_local_outbox_folders): Create outboxed per modest
964 account, not per transport account.
966 * src/modest-tny-account.h:
967 * src/modest-tny-account.c:
968 (modest_tny_account_get_special_folder): For outboxes, get the
969 parent modest account name. The account is ignored for other folders.
970 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
971 modest account name rather than a server TnyAccount.
973 2007-05-25 Murray Cumming <murrayc@murrayc.com>
975 * src/modest-tny-account.c:
976 (modest_tny_account_new_from_server_account):
977 Call modest_runtime_get_send_queue() immediately after creating transport
978 accounts, so that they start trying to send email from the outbox as soon
979 as possible at startup. This is probably what we want.
981 * src/modest-mail-operation.c: (update_account_thread):
982 * src/modest-runtime.c: (modest_runtime_get_send_queue):
983 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
984 * src/modest-tny-send-queue.h:
985 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
986 (modest_ui_actions_on_send):
987 Added comments about how sending works, though it needs some more work.
989 2007-05-25 Murray Cumming <murrayc@murrayc.com>
991 * src/modest-tny-account.c:
992 (modest_tny_account_get_special_folder): Add TODO because this fails when
994 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
995 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
996 Do not try to show this window when there is no active account. The UI
997 specs does not tell us what to do in this case.
999 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1003 * src/maemo/Makefile.am:
1004 * src/widgets/Makefile.am: Some dist fixes.
1006 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1008 * src/maemo/modest-connection-specific-smtp-window.c:
1009 (on_button_edit): Make the code clearer, to prevent a double free.
1011 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1013 * src/maemo/modest-account-settings-dialog.c:
1014 (modest_account_settings_dialog_set_account_name),
1015 Check the connection-specific smtp servers checkbox if there are any.
1017 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1018 (modest_connection_specific_smtp_edit_window_init):
1019 Start with a suitable port number.
1021 * src/modest-account-mgr-helpers.h:
1022 * src/modest-account-mgr-helpers.c: Added
1023 modest_account_mgr_get_has_connection_specific_smtp().
1025 (modest_account_mgr_set_connection_specific_smtp),
1026 (modest_account_mgr_remove_connection_specific_smtp),
1027 (modest_account_mgr_get_has_connection_specific_smtp),
1028 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1029 connection-specific smtp server accounts in the account, rather than
1030 the server account conf dir.
1032 This fixes bug projects.maemo.org bug NB#58263 .
1034 * src/modest-tny-account-store.c:
1035 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1036 if there are no server accounts yet, to prevent an infinite loop when there
1037 are no accounts. Document that one must be called before the other.
1039 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1041 * src/modest-account-mgr-helpers.c:
1042 (modest_account_mgr_get_default_account): Make sure that at least
1043 one account is always the default, if there are any enabled accounts.
1044 This is just a sanity check that shouldn't be necessary.
1046 * src/modest-account-mgr-priv.c:
1047 (_modest_account_mgr_account_from_key): Unescape the conf key to
1048 get the real account name. For instance, this is an issue if a space
1049 was in the account name, which can happen because the account name
1050 is generated from the display name.
1051 (_modest_account_mgr_get_account_keyname): Always escape the
1053 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1054 Unescape the conf keys to get the real account names.
1056 For instance, previously the is-default radio button in the accounts
1057 list was not checked for any accounts at first. This fixes that,
1058 and might fix several similar bugs.
1060 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1062 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1063 Removed some debug printfs.
1065 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1067 Modest on-disk outbox directories are now here, for instance:
1068 $HOME/.modest/outboxes/<account-id-1>/outbox
1069 $HOME/.modest/outboxes/<account-id-2>/outbox
1071 $HOME/.modest/local-folders/outbox
1072 so we can have a separate outbox for each account.
1073 But they are shown as one outbox in the GtkTreeView, by using a
1074 TnyMergeFolder in a ModestTnySimpleFolderStore.
1077 * src/modest-tny-simple-folder-store.c:
1078 * src/modest-tny-simple-folder-store.h:
1079 Added ModestTnySimpleFolderStore, used to contain folders from
1080 other folder stores, such as other accounts.
1082 * src/modest-tny-outbox-account.h:
1083 * src/modest-tny-outbox-account.c:
1084 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1085 used for the per-account local outbox folders.
1087 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1088 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1089 only use this (internally) now for the non-outbox local folders.
1091 * src/modest-init.h:
1092 * src/modest-init.c: Added modest_init_one_local_folder(), for
1093 setting up the directory structure for each local folder.
1095 * src/modest-local-folder-info.c:
1096 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1097 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1099 * src/modest-local-folder-info.h:
1100 * src/modest-tny-account-store.c: (on_account_removed),
1101 (on_account_changed), (create_per_account_local_outbox_folders),
1102 (get_server_accounts), (modest_tny_account_store_get_accounts),
1103 (modest_tny_account_store_get_tny_account_by_account),
1104 (modest_tny_folder_store_is_virtual_local_folders):
1106 * src/modest-tny-account.h:
1107 * src/modest-tny-account.c:
1108 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1109 to create an on-disk per-account local outbox folder for each
1111 (create_per_account_local_outbox_folders): Create a local outbox folder
1112 for each transport account.
1113 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1114 for all local folders.
1116 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1117 instead of using g_object_get/set() directly. It is clearer.
1119 (modest_tny_folder_store_get_message_count),
1120 (modest_tny_folder_store_get_local_size
1121 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1122 because we now use these with non-acount folder stores.
1124 (modest_tny_account_get_special_folder),
1125 (modest_tny_account_new_from_server_account),
1126 (modest_tny_account_new_from_account):
1127 (recurse_folders): Adjust to the new outbox system.
1129 * src/modest-tny-folder.h:
1130 * src/modest-tny-folder.c:
1131 (modest_tny_folder_is_local_folder),
1132 (modest_tny_folder_get_local_folder_type),
1133 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1135 * src/widgets/modest-main-window.h:
1136 * src/maemo/modest-main-window.c: (create_details_widget),
1137 (modest_main_window_set_contents_style): Show details for any folder store,
1140 (modest_tny_folder_get_rules):
1141 Remove the const. C does not support constness enough for this.
1143 * src/modest-ui-actions.c:
1144 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1145 make all outboxes appear as one, in the usual local-folders tree node.
1147 (set_active_account_from_tny_account),
1148 (modest_ui_actions_on_folder_selection_changed):
1149 * src/widgets/modest-folder-view.c: (text_cell_data),
1150 (icon_cell_data), (filter_row),
1151 (add_account_folders_to_merged_folder),
1152 (add_account_folders_to_simple_folder_store), (),
1153 (get_cmp_rows_type_pos), (cmp_rows),
1154 (modest_folder_view_set_account_id_of_visible_server_account):
1155 Adjust to the new outbox system, using generic folder stores and folders
1156 in the GtkTreeModel.
1158 2007-05-23 Christian Kellner <ckellner@openismus.com>
1160 * src/modest-mail-operation.c:
1161 (modest_mail_operation_update_account):
1162 Use info->max_size instead of unintialized local var [small
1163 build fix]. (Added TODO to review that change since I don't
1166 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1168 * libmodest-dbus-client/libmodest-dbus-client.c:
1169 (libmodest_dbus_client_compose_mail): function added
1170 * src/dbus_api/modest-dbus-api.h:
1171 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1172 (on_compose_mail): Implementation of the SendAsMail functionality
1174 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1176 * src/modest-account-mgr.c:
1177 (modest_account_mgr_add_server_account): Set the secure-connection
1178 conf key for transport accounts as well as store accounts. I don't know
1179 why the if was there. For instance, this makes sure that we use SSL
1180 for the gmail preset from the easysetup wizard.
1182 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1184 * src/gnome/modest-main-window.c:
1185 (on_account_store_connecting_finished), (connect_signals):
1186 * src/maemo/modest-main-window.c:
1187 (on_account_store_connecting_finished), (connect_signals),
1188 (modest_main_window_new):
1189 Handle TnyAccountStore::connecting-finished instead of
1190 TnyDevice::connection-changed, because we cannot actually perform
1191 operations on accounts until TnyAccountStore has itself responded to
1192 the TnyDevice::connection-changed signal. This prevents a GError from
1194 Do not try to update at startup, because we (at least on scratchbox)
1195 already do an update at startup when the device goes online.
1196 This prevents a GError from tinymail.
1197 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1198 Added TODO about stopping simultaneous operations.
1200 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1202 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1203 * src/modest-mail-operation-queue.c:
1204 (modest_mail_operation_queue_remove):
1205 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1206 about where they happened.
1208 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1210 * src/modest-ui-actions.c:
1211 (modest_ui_actions_on_password_requested): Make sure that the remember
1212 output parameter is always TRUE.
1214 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1216 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1217 Show a OK/Cancel dialog if the error is a question, though we still do not
1218 know anything more about what we are asking the user.
1219 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1220 Fix an uninitialized variable (helper). This is a logic error, however.
1222 2007-05-21 Christian Kellner <ckellner@openismus.com>
1224 * src/modest-search.h:
1225 Correct bit shifting in the ModestSearchFlags enum.
1227 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1229 * src/modest-tny-account.c:
1230 (modest_tny_account_new_from_server_account): Do not use the lsub and
1231 check-all hard-coded IMAP options when using POP.
1233 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1235 * src/modest-tny-account.c:
1236 (modest_tny_account_new_from_server_account):
1237 Use NULL for the secure-auth method for POP when Password auth has been
1238 specified by the user, as we already do for IMAP. "auth=Login" causes
1239 an error from camel or the server.
1241 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1243 * src/maemo/modest-account-settings-dialog.c:
1244 (create_page_account_details),
1245 (modest_account_settings_dialog_set_account_name):
1246 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1247 for the leave-on-server checkbox, rathr than just the checkbox, when
1248 the protocol is not POP.
1250 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1252 * src/widgets/modest-account-view.c:
1253 * src/widgets/modest-account-view.h:
1254 Added modest_account_view_select_account() which will be useful later
1255 to asynchronously re-select the edited account.
1257 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1259 * src/maemo/modest-account-settings-dialog.c:
1260 (modest_account_settings_dialog_set_account_name):
1261 Automatically choose the port numbers based on the secure authentication
1262 methods, if they have not been chosen before.
1263 This fixes projects.maemo.org bug NB#56273 .
1265 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1267 * src/maemo/modest-main-window-ui.h:
1268 * src/modest-ui-actions.c:
1269 * src/modest-ui-actions.h:
1270 Connect the Tools/SMTP Servers menu item to
1271 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1272 SMTP servers dialog, as in the UI specification and saves changes when it
1273 is closed. This fixed projects.maemo.org bug NB#56305 .
1275 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1277 * src/maemo/modest-connection-specific-smtp-window.c:
1278 (modest_connection_specific_smtp_window_init):
1279 Use gtk_window_set_default_size() to make this window big enough, so
1280 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1282 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1284 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1285 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1286 (modest_connection_specific_smtp_edit_window_init),
1287 Do not try to connect to a combobox signal before the combobox exists.
1288 This fixes the cras in projects.maemo.org bug NB#56288 .
1289 (modest_connection_specific_smtp_edit_window_get_settings):
1290 Remove the server_account_name parameter which was being checked for NULL
1291 though it was not used.
1293 * src/maemo/modest-connection-specific-smtp-window.c:
1294 (modest_connection_specific_smtp_window_fill_with_connections),
1295 (on_button_edit), (modest_connection_specific_smtp_window_init):
1296 Correct the number of treemodel columns to prevent a warning.
1297 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1298 libconic does not work.
1300 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1302 * src/modest-tny-account.c:
1303 (modest_tny_account_new_from_server_account):
1304 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1305 SMTP when "None" was chosen by the user. However, with my SMTP server that
1306 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1309 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1311 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1312 to explain the memory management issue with the ID in the ModestPair.
1314 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1315 (add_sending_page), (modest_account_assistant_finalize):
1316 * src/gnome/modest-gnome-global-settings-dialog.c:
1317 (create_updating_page), (create_composing_page):
1318 * src/gnome/modest-msg-edit-window.c: (get_transports),
1319 (init_window), (modest_msg_edit_window_finalize),
1320 (modest_msg_edit_window_get_msg_data):
1321 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1322 * src/gnome/modest-transport-widget.c:
1323 (modest_transport_widget_finalize), (smtp_configuration):
1324 * src/maemo/modest-maemo-global-settings-dialog.c:
1325 (create_updating_page), (create_composing_page):
1326 * src/maemo/modest-msg-edit-window.c: (get_transports),
1327 (init_window), (modest_msg_edit_window_finalize),
1328 (modest_msg_edit_window_get_msg_data),
1329 (modest_msg_edit_window_free_msg_data):
1330 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1331 (modest_store_widget_finalize):
1332 * src/maemo/modest-transport-widget.c:
1333 (modest_transport_widget_finalize), (smtp_configuration):
1334 * src/modest-main.c: (send_mail):
1335 * src/widgets/modest-combo-box.h:
1336 * src/widgets/modest-global-settings-dialog-priv.h:
1337 * src/widgets/modest-global-settings-dialog.c:
1338 (modest_global_settings_dialog_finalize):
1339 * src/widgets/modest-msg-edit-window.h:
1340 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1341 as long as the combo box, to prevent use of freed memory for the ID.
1343 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1345 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1346 get_accounts(), to make this clearer. Do not check for the enabled gconf
1347 key, because we do not use this for server accounts (at least, not yet).
1348 This allows us to send email again.
1350 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1352 * src/maemo/modest-platform.c:
1353 (on_modest_conf_update_interval_changed), (modest_platform_init):
1354 Only respond to this particular key change. All these strcmp()s cannot be
1357 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1359 * src/maemo/modest-maemo-global-settings-dialog.c:
1360 (current_connection): Prevent a crash in scratchbox when
1361 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1362 * src/maemo/modest-platform.c:
1363 (on_modest_conf_update_interval_changed), (modest_platform_init):
1364 Get the update interval from gconf and reset it when the gconf key changes.
1366 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1368 * src/modest-protocol-info.c:
1369 * src/modest-protocol-info.h: Adde enum-specific get functions,
1370 instead of using a ModestProtocolType enum parameter.
1372 * src/gnome/modest-account-assistant.c:
1373 * src/gnome/modest-store-widget.c:
1374 * src/gnome/modest-store-widget.h:
1375 * src/gnome/modest-transport-widget.c:
1376 * src/gnome/modest-transport-widget.h:
1377 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1378 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1379 * src/maemo/easysetup/modest-easysetup-wizard.c:
1380 * src/maemo/modest-account-settings-dialog.c:
1381 * src/maemo/modest-account-settings-dialog.h:
1382 * src/maemo/modest-store-widget.c:
1383 * src/maemo/modest-store-widget.h:
1384 * src/maemo/modest-transport-widget.c:
1385 * src/maemo/modest-transport-widget.h:
1386 * src/modest-account-mgr-helpers.c:
1387 * src/modest-account-mgr-helpers.h:
1388 * src/modest-account-mgr.c:
1389 * src/modest-account-mgr.h:
1390 * src/modest-tny-account.c:
1391 * src/modest-tny-folder.c:
1392 * src/widgets/modest-account-view.c:
1393 * src/widgets/modest-retrieve-combo-box.c:
1394 * src/widgets/modest-retrieve-combo-box.h:
1395 * src/widgets/modest-secureauth-combo-box.c:
1396 * src/widgets/modest-serversecurity-combo-box.c:
1397 * src/widgets/modest-serversecurity-combo-box.h:
1398 * tests/check_account-mgr.c:
1399 Use the specific functions, and use the re-renamed enum values for GNOME too.
1401 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1403 * src/modest-pair.h:
1404 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1405 so we can get the second based on the first.
1407 * src/maemo/modest-account-settings-dialog.h:
1408 * src/maemo/modest-account-settings-dialog.c:
1409 Added get_supported_secure_authentication_methods(), though it is mostly
1410 commented-out for now until the necessary API is committed to tinymail.
1411 (modest_account_settings_dialog_set_account_name),
1412 (save_configuration): Request the supported authentication methods from the
1413 server, so we can choose a working method.
1415 * src/modest-tny-account-store.h:
1416 * src/modest-tny-account-store.c:
1417 (modest_tny_account_store_get_session): Rename from
1418 tny_account_store_get_session().
1420 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1422 * src/modest-protocol-info.h: Split the ModestProtocol enum
1423 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1424 There was no need to have these unrelated values in one enum.
1426 * src/: many files: Adapted to changed enum. This makes the code a bit
1427 clearer, and the compiler could catch some errors.
1429 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1431 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1432 Show the detailed internal camel error message when an error happens
1433 during the configuration, so that our testers can give us more clues.
1434 For instance, in projects.maemo.org bug NB#56910 .
1436 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1438 * src/modest-tny-account.c:
1439 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1440 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1442 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1444 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1445 * src/maemo/modest-account-settings-dialog.c:
1446 (modest_account_settings_dialog_set_account_name),
1447 (save_configuration): For the incoming secure authentication checkbox,
1448 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1449 the UI specification. PLAIN does not seem to be supported for most IMAP
1450 servers anyway, and I am not sure what it would mean.
1451 However, we probably need to discover which of the secure-authentication
1452 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1453 * src/modest-account-mgr-helpers.c:
1454 (modest_account_mgr_get_server_account_data):
1456 * src/modest-tny-account.c:
1457 (modest_tny_account_new_from_server_account):
1458 Use tny_account_set_mech() to set secure-authentication methods,
1459 with some special-casing for IMAP, based on my observations of how
1462 * src/modest-account-mgr-helpers.h:
1463 * src/modest-account-mgr.c:
1464 * src/modest-defs.h: Comment that the URI is only used for local folders.
1466 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1468 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1469 parameter const, just to be neat.
1470 * src/modest-text-utils.c: (modest_text_utils_inline):
1471 End g_strconcat() with NULL, as its documentation says. This is almost
1472 certainly the cause of my crash at startup on the device. Interestingly,
1473 valgrind doesn't tell us about these errors.
1475 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1477 * scripts/build-packages: Added more precise comments about how to use
1478 this script, though I still get this error:
1479 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1480 error building tinymail
1482 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1484 * src/maemo/modest-main-window.c: (on_account_update):
1485 Very slight cleanup, hoping to make it simpler to discover what causes
1486 a crash here sometimes.
1488 * src/modest-tny-account.c:
1489 (modest_tny_account_new_from_server_account): Set the port. Added
1490 comments about the options and a TODO comment because I need to find out
1491 how to specify the secure authentication method.
1493 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1495 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1496 changed CFlags paths form modest to libmodest
1498 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1500 * src/modest-account-mgr-helpers.c:
1501 (modest_account_mgr_get_server_account_data),
1502 (modest_account_mgr_free_server_account_data):
1503 * src/modest-account-mgr-helpers.h:
1504 * src/modest-account-mgr.c:
1505 (modest_account_mgr_add_server_account):
1506 * src/modest-defs.h:
1507 * src/modest-tny-account.c:
1508 (modest_tny_account_new_from_server_account):
1509 Determine the options for tny_camel_account_add_option() here,
1510 based on the settings, rather than storing them directly in gconf.
1512 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1514 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1515 Show a more friendly error dialog now that we expect (from the tinymail
1516 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1518 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1520 * src/maemo/modest-main-window.c: (on_account_update): Check that
1521 account_name is not NULL, to prevent a crash at startup that I am
1522 seeing on the N800. I do wonder why it is NULL.
1524 * src/maemo/easysetup/modest-easysetup-wizard.c:
1525 (create_page_user_details):
1526 * src/maemo/modest-account-settings-dialog.c:
1527 (create_page_user_details), (create_page_outgoing):
1528 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1529 (modest_connection_specific_smtp_edit_window_init):
1530 * src/modest-ui-actions.c:
1531 (modest_ui_actions_on_password_requested):
1532 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1533 might do something useful with the on-screen keyboard.
1535 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1537 * src/maemo/modest-main-window.c: (on_account_update):
1538 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1539 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1541 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1543 * src/modest-tny-account-store.c: (on_account_changed):
1544 Correct the signature of this signal handler.
1546 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1548 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1549 Show a HildonNote instead of a GtkDialog for Maemo.
1551 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1553 * src/widgets/modest-account-view.h:
1554 * src/widgets/modest-account-view.c: (on_account_changed),
1555 (on_account_removed). Added a boolean flag, set/unset by
1556 modest_account_view_block_conf_updates(),
1557 modest_account_view_unblock_conf_updates() to prevent unnecessary
1558 updates, but this is not very useful because the gconf notifications are
1559 so delays (maybe only on Maemo Bora).
1560 So auto-updating is turned off, and these functions do an explicit
1561 update when necessary.
1562 However, something else is still doing too much work when adding/removing
1563 accounts, probably in another part of the application.
1565 * src/maemo/modest-account-view-window.c:
1566 (on_delete_button_clicked), (on_edit_button_clicked),
1567 (on_new_button_clicked): Use the new functions.
1569 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1571 * src/modest-account-mgr-helpers.c:
1572 (modest_account_mgr_set_first_account_as_default):
1573 Sort the list of names alphabetically-by-title, so we choose the first one
1575 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1576 alphabetically by the title.
1578 This fixes projects.maemo.org bug NB#56418 .
1580 * src/modest-account-mgr-priv.c:
1581 (_modest_account_mgr_account_from_key):
1582 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1583 avoid a valgrind error, and possible random behaviour.
1585 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1587 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1588 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1589 tinymail documentation to say that this can be expected.
1590 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1591 pretty, and should not happen, but I would prefer to know when it does.
1593 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1595 * configure.ac: When using the older hildon version, probably on Bora,
1596 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1598 * src/widgets/modest-attachment-view.c:
1599 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1602 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1604 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1605 Implemented the prototype. Can be tested with
1606 tests/dbus_api/test_open_message:
1608 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1610 * src/modest-tny-account-store.c:
1611 (modest_tny_account_store_instance_init), (get_password):
1612 * src/modest-ui-actions.c:
1613 (modest_ui_actions_on_password_requested):
1614 Do not store the password in gconf, because this function is called
1615 for non-remembered passwords. Actually use the cached (in the hash map)
1616 password instead of releasing it.
1617 The password will now not be remembered if it is asked via the protected
1618 password dialog, as per the UI spec.
1620 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1622 * src/modest-defs.h:
1623 * src/modest-account-mgr-helpers.h:
1624 * src/modest-account-mgr-helpers.c:
1625 Added modest_server_account_get_username_has_succeeded(),
1626 modest_server_account_set_username_has_succeeded().
1627 (modest_server_account_set_username),
1628 Reset the has-succeeded flag if the username changes.
1630 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1631 * src/maemo/modest-connection-specific-smtp-window.c:
1632 (modest_connection_specific_smtp_window_save_server_accounts):
1633 Use modest_server_account_set_username() instead of using
1634 modest_conf_set_string() directly, so that the has-succeeded flag is always
1637 * src/modest-ui-actions.c:
1638 (modest_ui_actions_on_password_requested): Dim the username entry if
1639 the username has ever worked, as per the UI spec.
1641 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1643 * src/modest-tny-account-store.c: (get_password):
1644 * src/modest-ui-actions.c:
1645 (modest_ui_actions_on_password_requested):
1646 Allow the username to be changed too, though there is more work to
1647 be done on exactly how this behaves.
1649 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1651 * src/modest-account-mgr-helpers.h:
1652 * src/modest-account-mgr-helpers.c:
1653 Added modest_account_mgr_get_display_name(),
1654 modest_server_account_get_username(),
1655 modest_server_account_set_username(),
1656 modest_server_account_set_password(),
1657 modest_server_account_get_hostname() functions so we do not need to
1658 use the conf API directly.
1660 * src/maemo/modest-main-window.c: (connect_signals):
1661 Actually connect ot the ModestAccountStore::request-password signal,
1662 so that we show the dialog when the password is requested by Tinymail,
1663 for isntance if it is empty.
1665 * src/modest-marshal.list:
1666 * src/modest-tny-account-store.c:
1667 (modest_tny_account_store_class_init), (get_password),
1668 (modest_tny_account_store_alert):
1669 * src/modest-tny-account-store.h:
1670 * src/modest-ui-actions.h:
1671 * src/modest-ui-actions.c:
1672 (modest_ui_actions_on_password_requested):
1673 Change the signal parameters, so it is obvious that we are providing
1674 the non human-readable server name, and receiving both the username
1675 and password, though changing of the username is not yet implemented.
1676 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1677 for the GNOME version.
1679 This should fix the projects.maemo.org bug NB#56209, though it does not
1680 work on Bora, because the gconf_client_get() for the password fails
1681 immediately after we save it with gconf_client_set().
1683 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1686 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1687 caused an undefined symbol error:
1688 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1690 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1692 * src/modest-tny-account-store.c:
1693 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1694 using a GError instead of a string message, so we can translate it in
1697 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1699 * src/maemo/modest-address-book.c:
1700 (modest_address_book_check_names):
1701 * src/maemo/modest-msg-view-window.c:
1702 (modest_msg_view_window_clipboard_owner_change):
1703 * src/modest-init.c: (modest_init_init_ui):
1704 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1705 (update_folders_cb), (modest_mail_operation_update_account):
1706 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1707 (modest_ui_actions_on_msg_attachment_clicked),
1708 (modest_ui_actions_on_msg_recpt_activated):
1709 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1710 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1711 (modest_msg_view_search_next):
1712 * src/widgets/modest-recpt-editor.c:
1713 (modest_recpt_editor_on_button_release_event),
1714 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1715 g_message(). At this point we should only be seeing interesting errors on
1716 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1718 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1720 (modest_wizard_dialog_force_title_update):
1721 * src/maemo/easysetup/modest-wizard-dialog.h:
1722 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1723 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1724 can update the title when appropriate. Otherwise the title is wrong if the
1725 pages are added after adding the notebook to the dialog.
1726 This must be a problem in HildonWizardDialog too.
1727 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1729 * src/maemo/easysetup/modest-easysetup-wizard.c:
1730 (create_subsequent_customsetup_pages),
1731 (create_subsequent_easysetup_pages):
1732 Call modest_wizard_dialog_force_title_update() so that the title is
1733 correct even with GTK+ < 2.10.
1734 This fixes projects.maemo.org bug NB#56145 .
1736 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1738 * src/maemo/modest-platform.c:
1739 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1740 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1743 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1745 * src/widgets/modest-window.h:
1746 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1747 and modest_window_save_state(), which invokes it.
1749 * src/widgets/modest-window-mgr.h:
1750 * src/widgets/modest-window-mgr.c:
1751 Added modest_window_mgr_save_state_for_all_windows(), which calls
1752 the save_state vfunc on all registered windows, if implemented.
1754 * src/gnome/modest-msg-edit-window.c:
1755 * src/gnome/modest-msg-view-window.c:
1756 * src/maemo/modest-msg-edit-window.c:
1757 * src/maemo/modest-msg-view-window.c:
1758 * src/maemo/modest-main-window.c:
1759 Specify the existing save_settings functions as implementations of
1760 ModestWindow::save_state_func().
1762 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1763 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1764 enabling hibernation, for instance.
1766 We may need to do the same thing for restoring settings.
1769 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1771 * src/widgets/modest-window-mgr.c:
1772 * src/widgets/modest-window-mgr.h:
1773 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1774 modest_window_mgr_get_hibernation_is_prevented().
1776 * src/maemo/modest-main-window.c:
1777 (on_hildon_program_is_topmost_notify): Prevent hibernation
1778 (possible when the application goes to the background in the WM),
1779 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1781 * src/maemo/easysetup/modest-easysetup-wizard.c:
1782 (modest_easysetup_wizard_dialog_init):
1783 * src/maemo/modest-account-settings-dialog.c:
1784 (modest_account_settings_dialog_init):
1785 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1786 (modest_connection_specific_smtp_edit_window_init):
1787 * src/maemo/modest-connection-specific-smtp-window.c:
1788 (modest_connection_specific_smtp_window_init):
1789 * src/maemo/modest-signature-editor-dialog.c:
1790 (modest_signature_editor_dialog_init):
1791 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1792 prevent hibernation while any of these account settings dialogs are open.
1794 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1796 * src/maemo/Makefile.am:
1797 * src/maemo/modest-osso-state-saving.c:
1798 * src/maemo/modest-osso-state-saving.h: Added
1799 modest_osso_load_state() and modest_osso_save_state() though they do
1800 nothing now. They should iterate through all the open windows and load/save
1802 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1803 save state when closing.
1805 * src/maemo/modest-main-window.c:
1806 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1807 Add a notification handler for the HildonProgram::is-topmost property,
1808 so we can allow hibernation when the application goes into the background.
1809 But we still need to detect when the accounts setup windows are open so
1810 we can stop hibernation when they are open.
1811 To do this, I also added the main window the HildonProgram. This might have
1812 other side-effects/benefits, and should maybe be done for other windows.
1814 * src/maemo/modest-osso-autosave-callbacks.h:
1815 * src/maemo/modest-osso-autosave-callbacks.c:
1816 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1817 though it does not do anything yet, and we might never need this to do
1818 anything. For instance, we already save drafts.
1820 * src/maemo/modest-platform.c: (modest_platform_init):
1821 Specify the libosso auto-save callback.
1823 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1825 * src/maemo/modest-platform.c:
1826 (modest_platform_set_update_interval):
1827 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1828 aparently stays valid between application instances, so we can use this
1829 to remove and reset it later. According to a maemo-developers email from
1832 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1834 * configure.ac: Depend on libalarm for Maemo.
1836 * src/dbus_api/modest-dbus-api.h:
1837 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1838 (on_send_receive), (modest_dbus_req_handler):
1839 Handle a SEND_RECEIVE D-Bus method.
1841 * libmodest-dbus-client/libmodest-dbus-client.c:
1842 (libmodest_dbus_client_send_and_receive):
1843 * libmodest-dbus-client/libmodest-dbus-client.h:
1844 Add C convenience functions for calling the new D-Bus method.
1846 * src/modest-platform.h:
1847 * src/gnome/modest-platform.c:
1848 * src/maemo/modest-platform.c:
1849 Added modest_platform_set_update_interval(), which uses the
1850 alarmd API on Maemo.
1851 (modest_platform_init),
1852 Call modest_platform_set_update_interval(), using a hard-coded
1853 interval for now (until the global settings dialog is implemented),
1854 though I am not sure that this makes sense yet.
1856 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1858 * src/dbus_api/modest-dbus-callbacks.c:
1859 (modest_osso_cb_hw_state_handler):
1860 * src/dbus_api/modest-dbus-callbacks.h:
1861 * src/maemo/modest-platform.c: (modest_platform_init):
1862 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1863 in case this has some effect on the ability for Maemo to ping the
1866 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1868 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1869 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1870 warning. It is probably a logic error, but I need to fix the build.
1872 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-account-mgr.h:
1875 * src/modest-account-mgr.c:
1876 (modest_account_mgr_account_names): Add a gboolean enabled_only
1877 parameter, so we can get lists of onlt the enabled accounts.
1879 (modest_account_mgr_add_account),,
1880 (modest_account_mgr_account_with_display_name_exists):
1881 * src/maemo/modest-msg-edit-window.c: (get_transports):
1882 * src/modest-account-mgr-helpers.c:
1883 (modest_account_mgr_set_first_account_as_default):
1884 * src/modest-init.c: (init_default_account_maybe):
1885 * src/modest-tny-account-store.c: (get_accounts):
1886 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1887 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1888 * tests/check_account-mgr.c: (START_TEST):
1889 Provide the extra parameter, as appropriate.
1891 * src/widgets/modest-account-view.c: (update_account_view):
1892 Do not show disabled accounts (meaning that there is no way to
1893 enable/disable accounts in the UI (the feature is not in our UI
1894 specification), so we can use this internally only to mark unfinished
1895 or temporary account data.
1897 * src/maemo/easysetup/modest-easysetup-wizard.c:
1898 (create_account): Add boolean enable parameter, so we can specify FALSE
1899 to create the temporary account.
1900 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1901 (on_before_next): When finishing, when there is a temporary account, just
1903 Also, use a timeout to delay the showing of the dialog until gconf is likely
1904 to return correct information, due to a maemo gconf bug that is fixed in
1905 osso 1.1, but not yet in Bora.
1906 However, the dialog stays on screen after it is destroyed.
1908 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1909 for invalid data when cancelling. Use a hildon note instead of a dialog
1910 to complain about invalid data. Do not show the account-saved note if the
1911 account is disabled (a temporary account that will not really be saved for use
1914 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1916 * src/modest-account-mgr-helpers.h:
1917 * src/modest-account-mgr-helpers.c:
1918 Added modest_account_mgr_unset_default_account(),
1919 Added modest_account_mgr_set_first_account_as_default().
1921 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1922 If it was the default account, unset the default account name.
1924 * src/maemo/modest-account-view-window.c:
1925 (on_delete_button_clicked): If it was the default account,
1926 set the first remaining account as the default instead.
1928 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1929 a NULL account or a NULL default account, to prevent a crash. This should
1930 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1933 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1935 * src/widgets/modest-recpt-editor.c:
1936 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1937 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1938 TODO comment for this. This fixes the build.
1940 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1941 be the best place for it. This will in future update all auto-update accounts,
1942 rather than just the current/default account, when that gconf key exists.
1943 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1944 if there are no accounts, before calling do_send_receive().
1945 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1947 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1948 * src/maemo/modest-main-window-ui.h:
1949 * src/maemo/modest-main-window.c: (on_connection_changed),
1950 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1951 directly, becaue the signal handler does more.
1953 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1955 * src/modest-account-mgr-helpers.c:
1956 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1957 for the case that the account does not exist.
1959 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1960 (equivalent to the modest account name) rather than the tinymail account name
1961 (equivalent to the modest account title - human readable) to get the account data.
1962 Check for null account data to prevent the crash, and add a TODO comment saying that
1963 this needs fixing because it is using the server account name instead of the account name.
1965 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1967 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1968 * src/maemo/modest-account-settings-dialog.c: (show_error),
1970 Use hildon_note_new_information() for informative and error messages,
1971 which seems to be expected for Maemo applications (no documentation that I know of
1972 says this). I am surprised that there is no distinction between info and error
1975 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1977 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1978 it is easy to find where this is used.
1980 * src/maemo/easysetup/modest-easysetup-wizard.c:
1981 (create_page_welcome), (create_page_account_details),
1982 (create_page_user_details), (create_page_complete_easysetup),
1983 (create_page_custom_incoming), (create_page_custom_outgoing),
1984 (create_page_complete_custom):
1985 * src/maemo/modest-account-settings-dialog.c:
1986 (create_page_account_details), (create_page_user_details),
1987 (create_page_incoming), (create_page_outgoing):
1988 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1989 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1990 (modest_connection_specific_smtp_edit_window_init):
1991 * src/maemo/modest-connection-specific-smtp-window.c:
1992 (modest_connection_specific_smtp_window_init):
1993 * src/maemo/modest-signature-editor-dialog.c:
1994 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1995 and scrolling policy as per the Email Application Layout Guide, if I have
1998 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2000 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2001 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2002 which were empty, because these vfuncs have been removed from TnyAccountStore.
2003 This fixes the build.
2005 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2007 * src/maemo/modest-main-window.c:
2008 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2009 showing/hiding it. Added TODO because it probably should not be NULL.
2010 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2011 because unnecessary g_warnings() make degugging difficult.
2013 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2015 * src/maemo/modest-msg-edit-window.c:
2016 (modest_msg_edit_window_select_color),
2017 (modest_msg_edit_window_select_background_color): 2 const corrections and
2018 moving 2 #endifs before closing brackets, to fix the build.
2020 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2022 * src/maemo/easysetup/modest-easysetup-wizard.h:
2023 * src/maemo/easysetup/modest-easysetup-wizard.c:
2024 (modest_easysetup_wizard_dialog_finalize),
2025 (on_button_edit_advanced_settings), (create_page_complete_custom),
2026 (on_response), (create_account):
2027 Implement the Advanced Settings edit button, by saving the account information,
2028 for the Advanded Settings dialog to use directly from gconf, and removing it
2029 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2030 Bug #5533 in the projects.maemo.org bugzilla.
2032 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2034 * src/maemo/modest-msg-view-window.c:
2035 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2036 when opening a message window.
2038 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2040 * src/maemo/easysetup/modest-easysetup-wizard.c:
2041 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2044 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2045 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2046 gconf settings. I probably added more checks than necessary, but that is safer.
2048 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2049 variable to fix the build, but this seems to be used when it is still NULL.
2051 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2053 * src/modest-platform.h:
2054 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2055 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2056 * src/modest-main.c: Implement this function so we can avoid using
2057 maemo-specific API from cross-platform code.
2059 * src/modest-tny-account-store.c:
2060 (get_smtp_specific_transport_account_for_open_connection):
2061 * src/modest-ui-actions.c: (check_for_connection),
2062 (modest_ui_actions_on_item_not_found):
2063 Use modest_platform_connect_and_wait() and put #idefs around other
2064 maemo-specific code, because only maemo currently has a way to
2065 identify connection names.
2067 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2069 * src/modest-tny-account-store.h:
2070 * src/modest-tny-account-store.c:
2071 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2072 the connection-specific SMTP server settings in the configuration.
2074 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2076 * src/maemo/modest-main-window.c: (on_connection_changed),
2078 * src/modest-main.c: (main), (start_ui), (send_mail):
2079 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2080 that is what is intended.
2082 * src/modest-ui-actions.c: (action_send), (action_receive),
2083 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2084 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2085 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2086 SMTP server is used when it is specified.
2088 (modest_ui_actions_on_send_receive):
2089 Check that a connection is open before proceeding.
2090 Receive and then send, instead of vice-versa, as per the specification.
2092 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2094 * src/modest-mail-operation.c:
2095 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2096 though I guess it should be something other than NULL.
2098 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2100 * src/maemo/easysetup/modest-easysetup-wizard.c:
2101 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2102 combo twice, to avoid an g_warning and to make it visible again.
2103 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2104 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2105 (already intended) dereference when detaching, because we then recreate the menu.
2106 But I am not sure why the warning was happening, and it is possible that this is a memory
2109 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2111 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2112 and uri_parse_mailto() utility functions.
2113 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2115 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2117 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2119 * src/dbus_api/modest-dbus-api.h:
2120 * src/dbus_api/modest-dbus-callbacks.c:
2121 Use an idle callback to execute the modest code in the application's own thread.
2122 Remove the helloworld example method.
2123 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2124 parsed, and the open-message method is not implemented because this is not yet implemented in
2126 * libmodest-dbus-client/libmodest-dbus-client.c:
2127 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2128 (libmodest_dbus_client_open_message):
2129 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2131 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2132 body without crashing.
2134 * tests/dbus_api/Makefile.am:
2135 * tests/dbus_api/test_mail_to.c:
2136 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2138 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2140 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2141 Added file to fix the build. Sorry.
2143 * src/dbus_api/Makefile.am:
2144 * src/dbus_api/modest-dbus-api.h:
2145 * src/dbus_api/modest-dbus-callbacks.h:
2146 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2147 (modest_dbus_req_handler):
2148 Put constants in a separate header so it can be reused by the
2149 client library, without duplication
2151 * libmodest-dbus-client/Makefile.am:
2152 * libmodest-dbus-client/libmodest-dbus-client.c:
2153 (libmodest_dbus_client_call_helloworld),
2154 (libmodfest_dbus_client_send_mail),
2155 (libmodfest_dbus_client_mailto),
2156 (libmodfest_dbus_client_open_message):
2157 * libmodest-dbus-client/libmodest-dbus-client.h:
2158 (Partly) Implement a send_mail D-Bus method.
2160 * tests/dbus_api/Makefile.am:
2161 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2162 the send_email D-Bus method.
2164 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2168 * libmodest-dbus-client/Makefile.am:
2169 * libmodest-dbus-client/libmodest-dbus-client.c:
2170 * libmodest-dbus-client/libmodest-dbus-client.h:
2171 * tests/dbus_api/Makefile.am:
2172 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2173 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2175 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2177 * src/maemo/easysetup/modest-easysetup-wizard.c:
2178 (create_page_account_details):
2179 * src/maemo/modest-account-settings-dialog.c:
2180 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2181 widgets, because this might not be the default in future versions of the Maemo GTK+.
2182 However, I can not not get capitalization to work even in a simple test case.
2184 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2186 * src/maemo/easysetup/modest-easysetup-wizard.c:
2187 (create_page_custom_incoming), (create_page_custom_outgoing):
2188 * src/maemo/modest-account-settings-dialog.c:
2189 (create_page_account_details), (create_page_incoming),
2190 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2191 instead of using gtk_check_button_with_label(), so they are aligned like the other
2192 widgets, as per the UI spec.
2194 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2196 * src/maemo/easysetup/modest-easysetup-wizard.c:
2197 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2198 * src/widgets/modest-validating-entry.c:
2199 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2200 Modest prefix instead of an EasySetup prefix.
2202 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2204 * src/widgets/modest-validating-entry.h:
2205 * src/widgets/modest-validating-entry.c: (on_insert_text),
2206 Added easysetup_validating_entry_set_max_func(), used to set a callback
2207 to call when the max number of characters is reached. GtkEntry has a max-length
2208 already but is silent about it.
2210 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2211 (create_page_account_details), (create_page_user_details),
2213 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2214 (create_page_account_details), (create_page_user_details),
2215 (create_page_outgoing):
2216 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2217 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2218 the UI spec, when the user tries to enter more than the max number of characters.
2220 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2222 * src/maemo/easysetup/modest-easysetup-wizard.c:
2223 (create_page_user_details), (create_page_custom_incoming),
2224 (create_page_custom_outgoing):
2225 * src/maemo/modest-account-settings-dialog.c:
2226 (create_page_user_details), (create_page_incoming),
2227 (create_page_outgoing):
2228 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2229 (modest_connection_specific_smtp_edit_window_init):
2230 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2231 not appropriate. Bad Maemo-specific defaults!.
2233 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2235 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2236 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2237 (modest_signature_editor_dialog_set_settings):
2238 Disable the label and textview when the checkbox is disabled, and use the
2239 specified (UI spec) default signature text.
2241 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2243 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2244 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2246 * src/modest-defs.h:
2247 * src/modest-account-mgr-helpers.h:
2248 * src/modest-account-mgr-helpers.c:
2249 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2251 * src/maemo/Makefile.am:
2252 * src/maemo/modest-signature-editor-dialog.c:
2253 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2256 * src/maemo/modest-account-settings-dialog.h:
2257 * src/maemo/modest-account-settings-dialog.c:
2258 (modest_account_settings_dialog_finalize), (on_button_signature),
2259 (save_configuration): Use the new dialog when the Edit button is pressed, and
2260 save the changes if necessary, as per the UI spec.
2262 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2264 * src/maemo/Makefile.am:
2265 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2266 based on maemo-develoers email from Dirk.
2268 * src/maemo/easysetup/modest-easysetup-wizard.c:
2269 (create_page_welcome), (create_page_account_details),
2270 (create_page_user_details), (create_page_complete_easysetup),
2271 (create_page_custom_incoming), (create_page_custom_outgoing),
2272 (create_page_complete_custom),
2273 (modest_easysetup_wizard_dialog_init):
2274 * src/maemo/modest-account-settings-dialog.c:
2275 (create_page_account_details), (create_page_user_details),
2276 (create_page_incoming), (create_page_outgoing),
2277 (modest_account_settings_dialog_init):
2278 * src/maemo/modest-connection-specific-smtp-window.c:
2279 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2281 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2283 * src/maemo/easysetup/modest-easysetup-wizard.c:
2284 (create_page_account_details), (create_page_custom_outgoing),
2285 (create_page_complete_custom):
2286 * src/maemo/modest-account-settings-dialog.c:
2287 (create_page_user_details), (create_page_incoming),
2288 (create_page_outgoing):
2289 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2290 (modest_connection_specific_smtp_edit_window_init):
2291 Use the correct (UI spec) port min/max, and use horizontal separators,
2294 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2296 * src/maemo/easysetup/modest-easysetup-wizard.c:
2297 (set_default_custom_servernames):
2298 * src/maemo/modest-account-settings-dialog.c:
2299 (create_page_incoming), (on_combo_outgoing_security_changed),
2300 (on_combo_incoming_security_changed), (create_page_outgoing),
2301 (modest_account_settings_dialog_set_account_name),
2302 (save_configuration):
2303 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2304 (on_combo_security_changed),
2305 (modest_connection_specific_smtp_edit_window_init),
2306 (modest_connection_specific_smtp_edit_window_set_connection),
2307 (modest_connection_specific_smtp_edit_window_get_settings):
2308 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2311 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2314 * src/maemo/easysetup/modest-easysetup-wizard.c:
2315 (create_page_custom_outgoing), (create_page_complete_custom):
2316 * src/maemo/modest-account-settings-dialog.c:
2317 (create_page_user_details), (create_page_outgoing):
2318 * src/maemo/modest-account-view-window.c: (button_box_new):
2319 Use changed logical IDs as per the most recent UI spec:
2320 mcen_bd_emailsetup_edit -> mcen_bd_edit
2321 mcen_bd_emailsetup_delete -> mcen_bd_delete
2322 mcen_bd_emailsetup_close -> mcen_bd_close
2324 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2328 * src/dbus_api/Makefile.am:
2329 * src/dbus_api/modest-dbus-callbacks.c:
2330 * src/dbus_api/modest-dbus-callbacks.h:
2331 * src/maemo/modest-platform.c: (modest_platform_init):
2332 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2334 * tests/Makefile.am:
2335 * tests/dbus_api/Makefile.am:
2336 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2338 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2340 * src/maemo/modest-account-settings-dialog.c:
2341 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2342 Removed unnecessary includes.
2344 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2346 * src/maemo/easysetup/modest-easysetup-wizard.c:
2347 * src/maemo/modest-account-settings-dialog.c:
2348 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2349 * src/widgets/Makefile.am:
2350 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2351 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2352 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2353 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2354 * src/widgets/modest-secureauth-combo-box.c:
2355 * src/widgets/modest-secureauth-combo-box.h:
2356 * src/widgets/modest-serversecurity-combo-box.c:
2357 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2358 made the GObject names more consistent with the rest of the Modest code.
2360 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2362 * src/maemo/easysetup/Makefile.am:
2363 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2364 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2365 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2366 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2367 * src/maemo/easysetup/modest-easysetup-wizard.c:
2368 * src/maemo/easysetup/modest-validating-entry.c:
2369 * src/maemo/easysetup/modest-validating-entry.h:
2370 * src/maemo/modest-account-settings-dialog.c:
2371 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2372 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2373 widgets/ because they are used outside of easysetup too. After checking in,
2374 svn will allow me to rename them too.
2376 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2378 * src/gnome/modest-msg-edit-window.c:
2379 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2380 linker error, to fix the build on the GNOME platform.
2381 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2382 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2383 ifdefed out to avoid a warning.
2385 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2387 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2388 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2389 some alternative for GTK+ 2.6.
2391 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2393 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2395 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2396 specified for EmailAccountsDialog in UI spec.
2398 * src/maemo/easysetup/modest-easysetup-wizard.c:
2399 * src/maemo/easysetup/modest-easysetup-wizard.h:
2400 * src/maemo/modest-account-settings-dialog.c:
2401 * src/maemo/modest-account-settings-dialog.h:
2402 Reuse a member window widget for the connection-specific SMTP server accounts,
2403 so we can tell it to create/save the accounts only if we actually save changes.
2405 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2406 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2407 (modest_connection_specific_smtp_edit_window_get_settings):
2408 Return a struct instance for temporarily remembering the entered data.
2410 * src/maemo/modest-connection-specific-smtp-window.h:
2411 * src/maemo/modest-connection-specific-smtp-window.c:
2412 (modest_connection_specific_smtp_window_finalize),
2413 (modest_connection_specific_smtp_window_fill_with_connections),
2415 (modest_connection_specific_smtp_window_save_server_accounts),
2416 (update_model_server_names): Do not actually save data until asked,
2417 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2419 (on_selection_changed),
2420 (modest_connection_specific_smtp_window_init): Disable the edit
2421 button when nothing is selected.
2423 * src/modest-account-mgr-helpers.c:
2424 * src/modest-account-mgr-helpers.h:
2425 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2428 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2430 * src/modest-account-mgr-helpers.h:
2431 * src/modest-account-mgr-helpers.c:
2432 (modest_account_mgr_get_unused_account_name),
2433 (modest_account_mgr_get_unused_account_display_name): Added these
2434 utility functions, to avoid code duplication.
2436 * src/maemo/easysetup/modest-easysetup-wizard.c:
2437 (create_page_account_details), (create_account):
2438 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2439 (on_combo_security_changed),
2440 (modest_connection_specific_smtp_edit_window_init),
2441 (modest_connection_specific_smtp_edit_window_save_settings):
2442 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2443 * src/maemo/modest-connection-specific-smtp-window.c:
2444 (modest_connection_specific_smtp_window_finalize),
2445 (modest_connection_specific_smtp_window_fill_with_connections),
2446 (on_button_edit), (modest_connection_specific_smtp_window_init):
2447 * src/maemo/modest-connection-specific-smtp-window.h:
2448 Implementing saving of connection-specific server accounts.
2450 But I need to refactor this so we can save the data for each
2451 possible connection-specific account and only actually create the server accounts
2452 when the easysetup finished, or the OK button is pressed on the account settings
2455 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2457 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2458 (on_combo_security_changed):
2459 (modest_connection_specific_smtp_edit_window_init):
2460 Auto-fill the port number as in the account settings.
2462 (modest_connection_specific_smtp_edit_window_set_connection):
2463 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2464 * src/maemo/modest-connection-specific-smtp-window.c:
2465 (fill_with_connections), (on_button_edit),
2466 (modest_connection_specific_smtp_window_init):
2467 Turn the edit window into a dialog to simplify the code, and
2468 set a WM hint as in a GtkDialog, because only a popup can be on top of
2469 another window in Maemo, and popups usually have no WM decoration.
2471 * src/modest-defs.h:
2472 * src/modest-account-mgr-helpers.c:
2473 (modest_account_mgr_set_connection_specific_smtp),
2474 (modest_account_mgr_remove_connection_specific_smtp),
2475 (modest_account_mgr_get_connection_specific_smtp):
2476 * src/modest-account-mgr-helpers.h: Some functions to write the
2477 connection-specific SMTP server information. Not yet used.
2480 * src/widgets/modest-folder-view.c: (text_cell_data):
2481 Fix a warning about an uninitialized variable.
2482 (on_configuration_key_changed): Put an #ifdef around the use
2483 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2485 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2487 * src/maemo/modest-account-settings-dialog.h:
2488 * src/maemo/modest-account-settings-dialog.c:
2489 Added connect_for_modified() utility function to mark the new modified boolean.
2491 (create_page_account_details), (create_page_user_details),
2492 (create_page_incoming), (create_page_outgoing), (on_response),
2493 (modest_account_settings_dialog_init),
2494 (modest_account_settings_dialog_set_account_name):
2495 Only warn about unsaved changes when there are actually unsaved changes.
2497 * src/modest-account-mgr-helpers.c:
2498 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2499 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2500 to get the data from there in future.
2502 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2504 * src/modest-defs.h:
2506 * src/modest-account-mgr-helpers.h:
2507 * src/modest-account-mgr-helpers.c:
2508 Store the security account setting in a single conf key instead of using
2509 the options list, so that the list is left for just the to-be-removed camel hack,
2510 and because gconf_client_set_list() is failing for some reason.
2512 * src/modest-account-mgr.c:
2513 (modest_account_mgr_add_server_account):
2514 * src/maemo/modest-account-settings-dialog.c:
2515 (modest_account_settings_dialog_set_account_name),
2516 (save_configuration): Use the renamed functions.
2519 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2521 * src/widgets/Makefile.am:
2522 * src/widgets/modest-limit-retrieve-combo-box.c:
2523 * src/widgets/modest-limit-retrieve-combo-box.h:
2524 * src/widgets/modest-retrieve-combo-box.c:
2525 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2526 the account settings dialog.
2528 * src/modest-defs.h:
2529 * src/modest-account-mgr-helpers.h:
2530 * src/modest-account-mgr-helpers.c:
2531 (modest_server_account_get_option_secure_auth),
2532 (modest_server_account_set_option_secure_auth):
2533 * src/modest-account-mgr.c:
2534 (modest_account_mgr_add_server_account):
2535 Use the existing AUTH_MECH conf key for the secure-auth setting,
2536 instead of putting it in the list options, because this was actually used already.
2538 * src/maemo/modest-account-settings-dialog.c:
2539 (create_page_account_details),
2540 (modest_account_settings_dialog_set_account_name),
2541 (save_configuration):
2542 * src/maemo/modest-account-settings-dialog.h:
2543 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2544 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2546 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2548 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2549 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2550 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2552 * src/modest-defs.h:
2553 * src/maemo/modest-account-settings-dialog.c:
2554 (create_page_incoming), (on_combo_outgoing_security_changed),
2555 (on_combo_incoming_security_changed), (create_page_outgoing),
2556 (modest_account_settings_dialog_set_account_name),
2557 (save_configuration): Load/Save the port number, and change it when the
2558 security combo changes, to suitable defaults.
2560 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2562 * src/modest-account-mgr.c:
2563 (modest_account_mgr_add_server_account): Set the security and secure-auth
2564 options, and add a comment saying that the other camel-specific options should be
2567 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2569 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2571 * src/modest-tny-account-store.c: (account_list_free),
2572 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2573 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2576 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2578 * src/modest-protocol-info.c:
2579 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2580 is required by our UI spec. Maybe something in our implementation will use this eventually.
2581 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2582 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2583 instead of the previous 0 placeholder.
2585 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2586 secure-auth settings.
2587 * src/modest-account-mgr-helpers.h:
2588 * src/modest-account-mgr-helpers.c:
2589 (modest_server_account_data_get_option_secure_auth),
2590 (modest_server_account_set_option_secure_auth),
2591 (modest_server_account_data_get_option_security),
2592 (modest_server_account_set_option_security): Added this API for getting and setting the security
2593 and secure-auth settings.
2595 * src/maemo/modest-account-settings-dialog.h:
2596 * src/maemo/modest-account-settings-dialog.c:
2597 (modest_account_settings_dialog_finalize), (check_data),
2598 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2599 about changing titles.
2600 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2601 (save_configuration): Save the security and secure-auth settings.
2603 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2604 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2606 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2608 * src/modest-defs.h:
2609 * src/modest-account-mgr.c:
2610 (modest_account_mgr_add_server_account):
2611 Added and used defines for the options key and value pair strings,
2612 that are used so far, though they do not seem to correspond to anything in our
2613 UI specs or ModestProtocol enum.
2615 * src/modest-account-mgr-helpers.h:
2616 * src/modest-account-mgr-helpers.c:
2617 (compare_option_strings_for_name),
2618 (modest_server_account_data_get_option_value),
2619 (modest_server_account_data_get_option_bool),
2620 (modest_account_mgr_get_server_account_option):
2621 Added helper functions for parsing the options GSList.
2623 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2625 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2626 display name is based on the supplied account name.
2627 * src/modest-account-mgr.c:
2628 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2629 with an inefficient, but good-enough, implementation.
2631 * src/maemo/easysetup/modest-easysetup-wizard.c:
2632 (create_page_account_details), (on_before_next), (create_account):
2633 Check for existing display names rather than (non-user-visible) account names, and just
2634 create and set a unique account name at the end.
2636 * src/maemo/modest-account-settings-dialog.c:
2637 (modest_account_settings_dialog_init),
2638 (modest_account_settings_dialog_set_account_name),
2639 (create_page_incoming): Show the display name, instead of the account name.
2640 (on_response): Do some (not all) extra checks, as in the UI spec.
2641 (save_configuration): Save the display name if it was changed.
2643 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2645 * po/en_GB.po: Added needed logical ID and translation.
2646 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2647 (init_view): Made the is-default column clicking work.
2649 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2652 * src/maemo/easysetup/Makefile.am:
2653 * src/maemo/easysetup/modest-easysetup-wizard.c:
2654 (modest_easysetup_wizard_dialog_init):
2655 * src/maemo/easysetup/provider-data-test.keyfile:
2656 * src/maemo/easysetup/provider-data.keyfile:
2657 Moved the provider data file to the new modest-providers-data package and used it from there.
2659 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2661 * src/modest-local-folder-info.c:
2662 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2663 N_() was already used on the static strings, but this just marks it for translation without
2664 using the translation.
2666 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2668 * src/maemo/modest-account-settings-dialog.c:
2669 (create_page_incoming),
2670 (modest_account_settings_dialog_set_account_name):
2671 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2672 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2673 I will do this if nobody else gets there first.
2675 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2677 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2678 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2679 save the security stuff.
2681 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2683 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2684 Set the email address and user fullname, which I now see must be
2687 * src/maemo/modest-account-settings-dialog.h:
2688 * src/maemo/modest-account-settings-dialog.c:
2690 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2691 leave-on-server and authentication.
2692 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2695 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2698 * src/maemo/modest-account-settings-dialog.c:
2699 * src/maemo/modest-account-settings-dialog.h:
2700 Most (but not all) of the widgets are now present as specified by the UI spec.
2701 No changes are yet saved, and some details are not properly shown yet.
2703 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2705 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2707 * src/maemo/Makefile.am:
2708 * src/maemo/modest-account-settings-dialog.c:
2709 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2710 an existing account. Doesn't do much yet.
2712 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2713 Open the accounts settings dialog when Edit is clicked.
2715 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2717 * src/maemo/easysetup/Makefile.am:
2718 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2720 * src/maemo/easysetup/modest-easysetup-wizard.c:
2721 (modest_easysetup_wizard_dialog_init):
2722 Try to get the source directory from the build system,
2723 instead of hard-coding "./" into the source code, when opening our local
2724 copies of the configuration files.
2725 But this still fails when opening the wizard from the Accounts window,
2726 maybe because the working directory seems to change at runtime.
2727 So the wizard will fail the second time unless you copy the files into their
2728 proper locations - see the stdout warnings for the paths.
2730 (create_page_account_details),(on_before_next):
2731 Check for existing non-server accounts instead of server accounts,
2732 so the default account name is useful again, and to prevent trying to
2735 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2736 Show the wizard when New is clicked.
2738 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2739 (init_view): Show the column headers, and show the columns that are
2740 specified in the UI specs. However, something in Maemo's GTK+ prevents
2741 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2742 change the default account. This is despite unsetting the special properties.
2744 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2746 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2747 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2748 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2749 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2750 to make that clearer.
2751 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2753 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2755 * src/maemo/modest-account-view-window.c:
2756 (modest_account_view_window_init),
2757 (modest_account_view_window_new):
2758 Use the same buttons as specified in the
2759 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2760 the existing widgets, which never had a chance of working.
2761 Put the ModestAccountView treeview in a scrolled window.
2762 Do not repeat the initialization in both _init() and _new().
2764 * src/widgets/modest-account-view.c: (update_account_view):
2765 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2766 this widget and window shows no accounts.
2768 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2770 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2772 * src/maemo/easysetup/modest-easysetup-wizard.c:
2773 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2774 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2775 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2778 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2779 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2780 accounts exist yet, as in the UI spec.
2782 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2784 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2786 * src/maemo/Makefile.am:
2787 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2788 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2789 New window for editing connection-specific smtp details.
2790 Not fully implemented.
2792 * src/maemo/modest-connection-specific-smtp-window.c:
2793 (modest_connection_specific_smtp_window_finalize) :
2794 unref the tree model.
2795 (on_button_edit): Show the edit window.
2797 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2799 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2802 * src/maemo/Makefile.am:
2803 * src/maemo/modest-connection-specific-smtp-window.c:
2804 * src/maemo/modest-connection-specific-smtp-window.h:
2805 New window for showing the list of connections, for connection-specific
2806 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2807 * src/maemo/easysetup/modest-easysetup-wizard.c:
2808 (create_page_custom_outgoing): Show the new window when the button is clicked.
2810 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2812 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2813 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2814 * src/maemo/modest-msg-edit-window.c:
2815 (modest_msg_edit_window_insert_image):
2816 * src/modest-conf.c: (modest_conf_key_escape):
2817 * src/modest-mail-operation.c:
2818 (modest_mail_operation_send_new_mail):
2819 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2820 (modest_ui_actions_on_new_account):
2821 * src/widgets/modest-attachment-view.c: (update_filename_request):
2822 * src/widgets/modest-mail-header-view.c:
2823 Corrected warnings that were breaking the build, by commenting out unused variables,
2824 and a function, and by including a header.
2826 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2828 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2829 so we can #ifdef around platform-specific code when necessary.
2830 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2831 to allow this to build for the GNOME platform too.
2833 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2835 * src/maemo/easysetup/modest-easysetup-wizard.c:
2836 Added util_increment_name() and used it in create_page_account_details()
2837 to make sure that the default account name is always a new name.
2839 (modest_easysetup_wizard_dialog_init),
2840 (set_default_custom_servernames): Some minor memory management fixes.
2842 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2846 * src/modest-runtime.c: (init_i18n): Restored the translation
2847 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2848 are defined in config.h, and the translations are installed.
2850 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2851 is defined for translation.
2853 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2855 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2857 * src/maemo/easysetup/modest-easysetup-wizard.c:
2858 (modest_easysetup_wizard_dialog_init):
2859 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2860 Use realistic paths (though they should use $prefix generically) to the
2861 mcc_mapping and provider-data.keyfile files which might work when they
2862 are installed by the future version of the operator-wizard package,
2863 and then fallback to paths in our source code, with an explanatory
2866 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2870 * src/maemo/Makefile.am:
2871 * src/maemo/easysetup/: Added files from the previously-exernal
2872 osso-modest-easysetup.
2873 * src/maemo/modest-main-window-ui.h:
2874 * src/modest-ui-actions.c:
2875 * src/modest-ui-actions.h:
2876 Added modest_ui_actions_on_new_account() as a signal handler for the
2877 New Account menu item. It shows the easysetup wizard.
2878 * po/en_GB.po: Added additional needed logical IDs and translations.
2880 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2881 Apparently ChangeLog is not used for some vague Nokia legal reasons.