1 2007-04-18 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4 (on_combo_security_changed):
5 (modest_connection_specific_smtp_edit_window_init):
6 Auto-fill the port number as in the account settings.
8 (modest_connection_specific_smtp_edit_window_set_connection):
9 * src/maemo/modest-connection-specific-smtp-edit-window.h:
10 * src/maemo/modest-connection-specific-smtp-window.c:
11 (fill_with_connections), (on_button_edit),
12 (modest_connection_specific_smtp_window_init):
13 Turn the edit window into a dialog to simplify the code, and
14 set a WM hint as in a GtkDialog, because only a popup can be on top of
15 another window in Maemo, and popups usually have no WM decoration.
18 * src/modest-account-mgr-helpers.c:
19 (modest_account_mgr_set_connection_specific_smtp),
20 (modest_account_mgr_remove_connection_specific_smtp),
21 (modest_account_mgr_get_connection_specific_smtp):
22 * src/modest-account-mgr-helpers.h: Some functions to write the
23 connection-specific SMTP server information. Not yet used.
26 * src/widgets/modest-folder-view.c: (text_cell_data):
27 Fix a warning about an uninitialized variable.
28 (on_configuration_key_changed): Put an #ifdef around the use
29 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
31 2007-04-18 Murray Cumming <murrayc@murrayc.com>
33 * src/maemo/modest-account-settings-dialog.h:
34 * src/maemo/modest-account-settings-dialog.c:
35 Added connect_for_modified() utility function to mark the new modified boolean.
37 (create_page_account_details), (create_page_user_details),
38 (create_page_incoming), (create_page_outgoing), (on_response),
39 (modest_account_settings_dialog_init),
40 (modest_account_settings_dialog_set_account_name):
41 Only warn about unsaved changes when there are actually unsaved changes.
43 * src/modest-account-mgr-helpers.c:
44 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
45 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
46 to get the data from there in future.
48 2007-04-18 Murray Cumming <murrayc@murrayc.com>
52 * src/modest-account-mgr-helpers.h:
53 * src/modest-account-mgr-helpers.c:
54 Store the security account setting in a single conf key instead of using
55 the options list, so that the list is left for just the to-be-removed camel hack,
56 and because gconf_client_set_list() is failing for some reason.
58 * src/modest-account-mgr.c:
59 (modest_account_mgr_add_server_account):
60 * src/maemo/modest-account-settings-dialog.c:
61 (modest_account_settings_dialog_set_account_name),
62 (save_configuration): Use the renamed functions.
65 2007-04-18 Murray Cumming <murrayc@murrayc.com>
67 * src/widgets/Makefile.am:
68 * src/widgets/modest-limit-retrieve-combo-box.c:
69 * src/widgets/modest-limit-retrieve-combo-box.h:
70 * src/widgets/modest-retrieve-combo-box.c:
71 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
72 the account settings dialog.
75 * src/modest-account-mgr-helpers.h:
76 * src/modest-account-mgr-helpers.c:
77 (modest_server_account_get_option_secure_auth),
78 (modest_server_account_set_option_secure_auth):
79 * src/modest-account-mgr.c:
80 (modest_account_mgr_add_server_account):
81 Use the existing AUTH_MECH conf key for the secure-auth setting,
82 instead of putting it in the list options, because this was actually used already.
84 * src/maemo/modest-account-settings-dialog.c:
85 (create_page_account_details),
86 (modest_account_settings_dialog_set_account_name),
88 * src/maemo/modest-account-settings-dialog.h:
89 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
90 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
92 2007-04-18 Murray Cumming <murrayc@murrayc.com>
94 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
95 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
96 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
99 * src/maemo/modest-account-settings-dialog.c:
100 (create_page_incoming), (on_combo_outgoing_security_changed),
101 (on_combo_incoming_security_changed), (create_page_outgoing),
102 (modest_account_settings_dialog_set_account_name),
103 (save_configuration): Load/Save the port number, and change it when the
104 security combo changes, to suitable defaults.
106 2007-04-17 Murray Cumming <murrayc@murrayc.com>
108 * src/modest-account-mgr.c:
109 (modest_account_mgr_add_server_account): Set the security and secure-auth
110 options, and add a comment saying that the other camel-specific options should be
113 2007-04-17 Murray Cumming <murrayc@murrayc.com>
115 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
117 * src/modest-tny-account-store.c: (account_list_free),
118 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
119 cursor->data after unreffing it. But there is some strange stuff there so it might not be
122 2007-04-17 Murray Cumming <murrayc@murrayc.com>
124 * src/modest-protocol-info.c:
125 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
126 is required by our UI spec. Maybe something in our implementation will use this eventually.
127 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
128 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
129 instead of the previous 0 placeholder.
131 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
132 secure-auth settings.
133 * src/modest-account-mgr-helpers.h:
134 * src/modest-account-mgr-helpers.c:
135 (modest_server_account_data_get_option_secure_auth),
136 (modest_server_account_set_option_secure_auth),
137 (modest_server_account_data_get_option_security),
138 (modest_server_account_set_option_security): Added this API for getting and setting the security
139 and secure-auth settings.
141 * src/maemo/modest-account-settings-dialog.h:
142 * src/maemo/modest-account-settings-dialog.c:
143 (modest_account_settings_dialog_finalize), (check_data),
144 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
145 about changing titles.
146 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
147 (save_configuration): Save the security and secure-auth settings.
149 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
150 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
152 2007-04-17 Murray Cumming <murrayc@murrayc.com>
155 * src/modest-account-mgr.c:
156 (modest_account_mgr_add_server_account):
157 Added and used defines for the options key and value pair strings,
158 that are used so far, though they do not seem to correspond to anything in our
159 UI specs or ModestProtocol enum.
161 * src/modest-account-mgr-helpers.h:
162 * src/modest-account-mgr-helpers.c:
163 (compare_option_strings_for_name),
164 (modest_server_account_data_get_option_value),
165 (modest_server_account_data_get_option_bool),
166 (modest_account_mgr_get_server_account_option):
167 Added helper functions for parsing the options GSList.
169 2007-04-16 Murray Cumming <murrayc@murrayc.com>
171 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
172 display name is based on the supplied account name.
173 * src/modest-account-mgr.c:
174 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
175 with an inefficient, but good-enough, implementation.
177 * src/maemo/easysetup/modest-easysetup-wizard.c:
178 (create_page_account_details), (on_before_next), (create_account):
179 Check for existing display names rather than (non-user-visible) account names, and just
180 create and set a unique account name at the end.
182 * src/maemo/modest-account-settings-dialog.c:
183 (modest_account_settings_dialog_init),
184 (modest_account_settings_dialog_set_account_name),
185 (create_page_incoming): Show the display name, instead of the account name.
186 (on_response): Do some (not all) extra checks, as in the UI spec.
187 (save_configuration): Save the display name if it was changed.
189 2007-04-16 Murray Cumming <murrayc@murrayc.com>
191 * po/en_GB.po: Added needed logical ID and translation.
192 * src/widgets/modest-account-view.c: (on_account_default_toggled),
193 (init_view): Made the is-default column clicking work.
195 2007-04-16 Murray Cumming <murrayc@murrayc.com>
198 * src/maemo/easysetup/Makefile.am:
199 * src/maemo/easysetup/modest-easysetup-wizard.c:
200 (modest_easysetup_wizard_dialog_init):
201 * src/maemo/easysetup/provider-data-test.keyfile:
202 * src/maemo/easysetup/provider-data.keyfile:
203 Moved the provider data file to the new modest-providers-data package and used it from there.
205 2007-04-16 Murray Cumming <murrayc@murrayc.com>
207 * src/modest-local-folder-info.c:
208 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
209 N_() was already used on the static strings, but this just marks it for translation without
210 using the translation.
212 2007-04-06 Murray Cumming <murrayc@murrayc.com>
214 * src/maemo/modest-account-settings-dialog.c:
215 (create_page_incoming),
216 (modest_account_settings_dialog_set_account_name):
217 Added comments about the need for new API in ModestAccountMgr to handle the authentication
218 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
219 I will do this if nobody else gets there first.
221 2007-04-06 Murray Cumming <murrayc@murrayc.com>
223 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
224 Saved much of the incoming and outgoing data too, though I cannot yet see how to
225 save the security stuff.
227 2007-04-06 Murray Cumming <murrayc@murrayc.com>
229 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
230 Set the email address and user fullname, which I now see must be
233 * src/maemo/modest-account-settings-dialog.h:
234 * src/maemo/modest-account-settings-dialog.c:
236 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
237 leave-on-server and authentication.
238 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
241 2007-04-06 Murray Cumming <murrayc@murrayc.com>
244 * src/maemo/modest-account-settings-dialog.c:
245 * src/maemo/modest-account-settings-dialog.h:
246 Most (but not all) of the widgets are now present as specified by the UI spec.
247 No changes are yet saved, and some details are not properly shown yet.
249 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
251 2007-04-06 Murray Cumming <murrayc@murrayc.com>
253 * src/maemo/Makefile.am:
254 * src/maemo/modest-account-settings-dialog.c:
255 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
256 an existing account. Doesn't do much yet.
258 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
259 Open the accounts settings dialog when Edit is clicked.
261 2007-04-05 Murray Cumming <murrayc@murrayc.com>
263 * src/maemo/easysetup/Makefile.am:
264 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
266 * src/maemo/easysetup/modest-easysetup-wizard.c:
267 (modest_easysetup_wizard_dialog_init):
268 Try to get the source directory from the build system,
269 instead of hard-coding "./" into the source code, when opening our local
270 copies of the configuration files.
271 But this still fails when opening the wizard from the Accounts window,
272 maybe because the working directory seems to change at runtime.
273 So the wizard will fail the second time unless you copy the files into their
274 proper locations - see the stdout warnings for the paths.
276 (create_page_account_details),(on_before_next):
277 Check for existing non-server accounts instead of server accounts,
278 so the default account name is useful again, and to prevent trying to
281 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
282 Show the wizard when New is clicked.
284 * src/widgets/modest-account-view.c: (on_account_default_toggled),
285 (init_view): Show the column headers, and show the columns that are
286 specified in the UI specs. However, something in Maemo's GTK+ prevents
287 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
288 change the default account. This is despite unsetting the special properties.
290 2007-04-05 Murray Cumming <murrayc@murrayc.com>
292 * docs/reference/modest-design.sgml: Corrected spelling mistake.
293 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
294 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
295 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
296 to make that clearer.
297 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
299 2007-04-05 Murray Cumming <murrayc@murrayc.com>
301 * src/maemo/modest-account-view-window.c:
302 (modest_account_view_window_init),
303 (modest_account_view_window_new):
304 Use the same buttons as specified in the
305 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
306 the existing widgets, which never had a chance of working.
307 Put the ModestAccountView treeview in a scrolled window.
308 Do not repeat the initialization in both _init() and _new().
310 * src/widgets/modest-account-view.c: (update_account_view):
311 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
312 this widget and window shows no accounts.
314 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
316 2007-04-05 Murray Cumming <murrayc@murrayc.com>
318 * src/maemo/easysetup/modest-easysetup-wizard.c:
319 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
320 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
321 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
324 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
325 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
326 accounts exist yet, as in the UI spec.
328 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
330 2007-04-05 Murray Cumming <murrayc@murrayc.com>
332 * src/maemo/Makefile.am:
333 * src/maemo/modest-connection-specific-smtp-edit-window.c:
334 * src/maemo/modest-connection-specific-smtp-edit-window.h:
335 New window for editing connection-specific smtp details.
336 Not fully implemented.
338 * src/maemo/modest-connection-specific-smtp-window.c:
339 (modest_connection_specific_smtp_window_finalize) :
340 unref the tree model.
341 (on_button_edit): Show the edit window.
343 2007-04-05 Murray Cumming <murrayc@murrayc.com>
345 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
348 * src/maemo/Makefile.am:
349 * src/maemo/modest-connection-specific-smtp-window.c:
350 * src/maemo/modest-connection-specific-smtp-window.h:
351 New window for showing the list of connections, for connection-specific
352 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
353 * src/maemo/easysetup/modest-easysetup-wizard.c:
354 (create_page_custom_outgoing): Show the new window when the button is clicked.
356 2007-04-04 Murray Cumming <murrayc@murrayc.com>
358 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
359 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
360 * src/maemo/modest-msg-edit-window.c:
361 (modest_msg_edit_window_insert_image):
362 * src/modest-conf.c: (modest_conf_key_escape):
363 * src/modest-mail-operation.c:
364 (modest_mail_operation_send_new_mail):
365 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
366 (modest_ui_actions_on_new_account):
367 * src/widgets/modest-attachment-view.c: (update_filename_request):
368 * src/widgets/modest-mail-header-view.c:
369 Corrected warnings that were breaking the build, by commenting out unused variables,
370 and a function, and by including a header.
372 2007-04-04 Murray Cumming <murrayc@murrayc.com>
374 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
375 so we can #ifdef around platform-specific code when necessary.
376 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
377 to allow this to build for the GNOME platform too.
379 2007-04-04 Murray Cumming <murrayc@murrayc.com>
381 * src/maemo/easysetup/modest-easysetup-wizard.c:
382 Added util_increment_name() and used it in create_page_account_details()
383 to make sure that the default account name is always a new name.
385 (modest_easysetup_wizard_dialog_init),
386 (set_default_custom_servernames): Some minor memory management fixes.
388 2007-04-04 Murray Cumming <murrayc@murrayc.com>
392 * src/modest-runtime.c: (init_i18n): Restored the translation
393 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
394 are defined in config.h, and the translations are installed.
396 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
397 is defined for translation.
399 2007-04-03 Murray Cumming <murrayc@murrayc.com>
401 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
403 * src/maemo/easysetup/modest-easysetup-wizard.c:
404 (modest_easysetup_wizard_dialog_init):
405 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
406 Use realistic paths (though they should use $prefix generically) to the
407 mcc_mapping and provider-data.keyfile files which might work when they
408 are installed by the future version of the operator-wizard package,
409 and then fallback to paths in our source code, with an explanatory
412 2007-04-03 Murray Cumming <murrayc@murrayc.com>
416 * src/maemo/Makefile.am:
417 * src/maemo/easysetup/: Added files from the previously-exernal
418 osso-modest-easysetup.
419 * src/maemo/modest-main-window-ui.h:
420 * src/modest-ui-actions.c:
421 * src/modest-ui-actions.h:
422 Added modest_ui_actions_on_new_account() as a signal handler for the
423 New Account menu item. It shows the easysetup wizard.
424 * po/en_GB.po: Added additional needed logical IDs and translations.
426 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
427 Apparently ChangeLog is not used for some vague Nokia legal reasons.