1 2007-06-12 Murray Cumming <murrayc@murrayc.com>
3 * src/maemo/modest-main-window.c: (create_details_widget):
4 Use the mcen_va_never logical ID.
6 2007-06-12 Murray Cumming <murrayc@murrayc.com>
8 * src/dbus_api/modest-dbus-api.h:
9 * src/dbus_api/modest-dbus-callbacks.c:
10 (on_idle_open_default_inbox), (on_open_default_inbox),
11 (modest_dbus_req_handler):
12 Added a new OpenDefaultInbox method.
14 * libmodest-dbus-client/libmodest-dbus-client.h:
15 * libmodest-dbus-client/libmodest-dbus-client.c:
16 Added libmodest_dbus_client_open_default_inbox() to call the new
17 dbus method. This should be useful to projects.maemo.org bug NB#57214,
18 though it should maybe be used by a new osso-email-interface function.
20 * tests/dbus_api/Makefile.am:
21 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
24 2007-06-12 Murray Cumming <murrayc@murrayc.com>
26 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
27 NULL, so that the signals get all the keys. This should not actually
28 change any behaviour because we currently update everything when anything
31 2007-06-12 Murray Cumming <murrayc@murrayc.com>
33 * src/widgets/modest-folder-view.c: (text_cell_data),
34 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
35 (find_inbox_iter): If tinymail tells us that the folder is
36 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
37 This causes the inbox to be selected at startup, fixing part of
38 projects.maemo.org bug NB#56305.
40 * src/modest-ui-dimming-rules.c:
41 (modest_ui_dimming_rules_on_tools_smtp_servers):
42 * src/modest-ui-dimming-rules.h: Added a callback function to dim
43 the SMTP servers menu item.
44 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
45 that the SMTP Servers menu item is dimmed when there are no accounts,
46 as a future version of the UI spec will require. This fixes
47 projects.maemo.org bug NB#56305.
49 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
51 * src/maemo/modest-maemo-utils.c:
52 (modest_maemo_utils_get_supported_secure_authentication_methods):
53 Added label to dialog instead of unreadable title
55 * src/maemo/modest-main-window.c: (sync_accounts_cb),
56 (modest_main_window_new):
57 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
60 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
61 * src/modest-account-mgr.h:
62 Added method to avoid code duplication
64 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
65 (modest_ui_actions_on_send_receive):
66 Use modest_account_mgr_has_accounts
68 2007-06-11 Murray Cumming <murrayc@murrayc.com>
70 * src/maemo/easysetup/modest-presets.c:
71 (modest_presets_get_info_server_security): Do not report secure auth
73 * src/modest-protocol-info.c: Use the defines for the gconf key names
74 for secure authentication. This was not working because we were writing
75 Password and reading password, and the check was case sensitive.
76 With this, gmail now works for receiving and sending when created via
79 2007-06-11 Murray Cumming <murrayc@murrayc.com>
81 * src/maemo/easysetup/modest-presets.c:
82 (modest_presets_get_info_server_security): Correct the key name for
83 SecureSmtp, because it seems to be case-sensitive.
84 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
85 Do not try to get the 0th notebook page if there are 0 pages, to
88 2007-06-11 Murray Cumming <murrayc@murrayc.com>
90 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
91 Prevent use of the new notification feature for now, because it currently
92 shows one dialog for each new email, which is annoying.
94 2007-06-11 Murray Cumming <murrayc@murrayc.com>
96 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
97 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
98 when no country was selected, so that we show the global ones.
99 * src/maemo/easysetup/modest-presets.c:
100 (modest_presets_get_providers): Return only the global providers, not
101 all providers when mmc=0 was requested.
103 2007-06-11 Murray Cumming <murrayc@murrayc.com>
105 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
106 (easysetup_provider_combo_box_fill): Remove debug code that showed the
107 provider ID in the combo.
109 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
110 Do not show the page numbers, because it would be confusing when we add
111 the 2 extra pages for the custom setup, when the user chooses the "Other"
112 provider. This fixes projects.maemo.org bug NB#59028
114 * src/modest-init.c: (modest_init_init_core),
115 (modest_init_local_folders):
117 * src/modest-tny-account.c:
118 (modest_tny_account_new_for_local_folders): Do not create default folders
119 for the memory card. This should fix projects.maemo.org bug NB#59328.
121 2007-06-11 Murray Cumming <murrayc@murrayc.com>
123 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
124 Free the changed_conf_keys string items. They are already freed in the
125 idle handler if that runs first.
127 2007-06-11 Murray Cumming <murrayc@murrayc.com>
129 * src/modest-ui-actions.c:
130 (modest_ui_actions_on_password_requested): Check that the server name
131 is not NULL, because I just saw a password dialog with (null) as the
134 * src/modest-tny-folder.[h|c]: Added
135 modest_tny_folder_is_memory_card_folder().
136 * src/modest-ui-dimming-rules.c:
137 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
138 menu item for memory cards, as per the UI spec (section 7.4). This should
139 fix projects.maemo.org bug NB#59297.
141 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
143 * src/maemo/modest-main-window.c: (sync_accounts_cb):
144 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
145 is another problem with the code, see Murray's comment at line 772)
147 2007-06-08 Murray Cumming <murrayc@murrayc.com>
149 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
150 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
151 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
152 (load_from_file), (easysetup_country_combo_box_init),
153 (easysetup_country_combo_box_get_active_country_ids),
154 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
155 instead of just one ID, to avoid duplicate country names in the UI.
157 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
158 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
159 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
160 a single ID, avoiding duplicate providers.
161 * src/maemo/easysetup/modest-easysetup-wizard.c:
162 (on_combo_account_country): Adapt to use a list.
164 2007-06-08 Murray Cumming <murrayc@murrayc.com>
166 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
167 keys changed in the last X seconds.
169 * src/modest-account-mgr.h:
170 * src/modest-account-mgr.c: (on_timeout_notify_changes),
171 (on_key_change), (modest_account_mgr_class_init),
172 (modest_account_mgr_init), (modest_account_mgr_finalize):
173 As the keys are changed, save them in a GSList* and signal that GSList*
174 further every X seconds, to batch changes, to allow us to do just one
175 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
176 bug NB#56941 and other (UI-blocking) delays when changing account settings.
178 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
179 changed signal signature.
181 * src/modest-conf.c: (modest_conf_set_list),
182 (modest_conf_on_change): Reenable notification.
184 (modest_conf_maemo_fake_on_change): Comment out the hack that
185 notified immediately instead of asynchronously.
187 * src/widgets/modest-account-view.h:
188 * src/widgets/modest-account-view.c:
189 (update_account_view): Select the previously-selected account ID,
190 if possible. This fixes projects.maemo.org bug NB#56933.
192 (on_account_changed), (on_account_removed),
193 (modest_account_view_select_account):
195 Remove the block/unblock functions
196 because they were not useful.
198 * src/maemo/modest-account-view-window.c:
199 (on_delete_button_clicked), (on_edit_button_clicked),
200 (on_new_button_clicked): Remove the use of the non-working block/unblock.
202 2007-06-08 Murray Cumming <murrayc@murrayc.com>
204 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
205 Improve the error dialog to show Incorrect Account Settings, which seems
206 clearer, and say that the internal error message (to be removed from the
207 dialog later) is often misleading.
208 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
210 * src/modest-tny-account.c:
211 (modest_tny_account_new_from_server_account): Uncomment the printf of the
212 URL because this is so useful for debugging on the device.
214 * src/widgets/modest-serversecurity-combo-box.c:
215 (modest_serversecurity_combo_box_fill): Correct a logical ID.
217 2007-06-08 Murray Cumming <murrayc@murrayc.com>
219 * src/modest-mail-operation.c:
220 (modest_mail_operation_send_new_mail):
221 Added a comment about a nasty but apparently harmless message. Details
222 added to the wiki g_warnings() page.
224 2007-06-08 Murray Cumming <murrayc@murrayc.com>
226 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
227 (modest_tny_send_queue_class_init):
228 Do not use the priv struct because it is empty, to avoid g_warnings
229 about a non-existant priv struct.
231 * src/modest-tny-account-store.c:
232 (modest_tny_account_store_get_server_account),
233 (modest_tny_account_store_get_transport_account_for_open_connection
234 ): Do not try to get transport server accounts for local folders,
235 because they don't have any. This avoids a g_warning().
237 * src/maemo/modest-main-window.c:
238 (modest_main_window_notify_send_receive_initied),
239 (on_configuration_key_changed):
240 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
242 * src/modest-mail-operation.c:
243 (modest_mail_operation_update_account):
244 * src/modest-tny-account-store.h:
245 * src/modest-tny-account.c:
246 (modest_tny_account_get_special_folder),
247 (modest_tny_account_new_for_local_folders),
248 (modest_tny_account_new_for_per_account_local_outbox_folder):
249 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
250 * src/modest-tny-local-folders-account.c:
251 (add_account_folders_to_merged_folder):
252 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
253 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
254 (modest_ui_actions_on_send):
255 * src/widgets/modest-folder-view.c: (update_model):
256 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
257 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
258 modest_tny_account_store_get_tny_account_by_account() to
259 modest_tny_account_store_get_server_account() to make the code clearer.
261 2007-06-07 Marcus Bauer <marcusb@openismus.com>
263 * src/dbus_api/modest-dbus-api.h:
264 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
265 * src/maemo/modest-msg-edit-window.c:
266 (modest_msg_edit_window_attach_file_noninteractive):
267 added g_warning in case the file to be attached does not exist
268 * tests/dbus_api/test_compose_mail.c: (main):
269 removed obsolete comment, added generic files as test case
271 2007-06-07 Murray Cumming <murrayc@murrayc.com>
273 * src/modest-tny-account-store.c: (get_server_accounts):
274 Create the local folders account only once, not once for each outbox, and
275 not only when there are some outboxes.
277 2007-06-07 Murray Cumming <murrayc@murrayc.com>
279 * src/widgets/modest-folder-view.c: (update_model): Comment out some
280 code that is causing a crash at startup. Sergio says that he is fixing this.
282 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
284 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
285 * src/maemo/modest-account-settings-dialog.c:
286 (create_page_outgoing),
287 (modest_account_settings_dialog_set_account_name),
288 (save_configuration):
289 - Fixed handling of the "Use secure authentication" toggle to comply with
290 the ui specification. See also projects.maemo.org bug NB#58400
292 - Restore the Secure connection setting combo correctly when loading
295 * src/maemo/modest-maemo-utils.c:
296 (on_camel_account_get_supported_secure_authentication),
297 (modest_maemo_utils_get_supported_secure_authentication_methods):
298 Fixed a crasher if operation is canceled
300 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
301 (modest_protocol_info_auth_is_secure):
302 * src/modest-protocol-info.h:
304 Added two new methods to determine if a protocol/auth method is secure/encrypted in
305 the sense of the "Use secure authentication" toggle.
307 2007-06-07 Murray Cumming <murrayc@murrayc.com>
309 * src/modest-tny-account-store.h:
310 * src/modest-tny-account-store.c:
311 Added modest_tny_account_store_get_local_folders_account().
313 * src/modest-tny-folder.h:
314 * src/modest-tny-folder.c:
315 (modest_tny_folder_get_account):
316 Added this replacement for tny_folder_get_account() which returns
317 the local-folders account for TnyMergeFolders, to avoid the
318 warning about the unimplemented get_account_func() vfunc().
320 (modest_tny_folder_get_rules),
321 * src/modest-ui-actions.c:
322 (modest_ui_actions_on_folder_selection_changed):
323 * src/modest-mail-operation.c:
324 (modest_mail_operation_remove_folder),
325 (modest_mail_operation_xfer_folder),
326 (modest_mail_operation_rename_folder),
327 (modest_mail_operation_get_msg),
328 (modest_mail_operation_get_msgs_full),
329 (modest_mail_operation_remove_msg),
330 (modest_mail_operation_xfer_msgs),
331 (modest_mail_operation_refresh_folder):
332 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
334 2007-06-07 Murray Cumming <murrayc@murrayc.com>
336 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
337 (modest_server_account_set_security):
338 * src/modest-defs.h: Add comments explaining that our
339 UI spec means TLS when it says Normal, so these do not look like errors.
341 * src/modest-tny-account.c:
342 (modest_tny_account_new_from_server_account): Use the new tinymail
343 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
344 for TLS. This should fix projects.maemo.org bug NB#58460.
346 2007-06-06 Murray Cumming <murrayc@murrayc.com>
348 * src/maemo/easysetup/modest-easysetup-wizard.c:
349 (create_account): Correct the position of the gconf sanity check warning.
350 (on_button_edit_advanced_settings): Show the dialog immediately, instead
351 of using the g_idle_add() hack, because this does not seem to be necessary
352 on osso 1.1. It might even work on Maemo Bora if the problems were actually
353 caused by something other than maemo's gconf.
354 This fixes projects.maemo.org bug #59022.
356 2007-06-06 Murray Cumming <murrayc@murrayc.com>
358 * src/modest-account-mgr-helpers.c:
359 (modest_account_mgr_get_default_account): Do not check that the account
360 exists if there is no default account (NULL), to fix a runtime warning.
362 2007-06-06 Murray Cumming <murrayc@murrayc.com>
364 * src/widgets/modest-folder-view.c: (update_model):
365 Do not unref the treemodel before we have finished with it.
366 This prevents a valgrind warning and an occasional crash at startup.
368 2007-06-06 Marcus Bauer <marcusb@openismus.com>
370 * libmodest-dbus-client/libmodest-dbus-client.h:
371 added libmodest_dbus_client_compose_mail()
372 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
374 added functions needed for SendAsMail() functionality
375 * src/maemo/modest-msg-edit-window.c:
376 (modest_msg_edit_window_attach_file_noninteractive):
377 non interactively attaching files to message edit window
378 * src/widgets/modest-msg-edit-window.h:
379 * tests/dbus_api/Makefile.am:
380 added test_compose_mail.c
381 * tests/dbus_api/test_compose_mail.c: (main):
383 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
385 * src/modest-account-view.c:
386 Fixed bug projects.maemo.org bug NB#59307
388 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
390 * src/maemo/easysetup/modest-easysetup-wizard.c:
391 (get_serverport_incoming), (on_before_next), (create_account):
392 * src/maemo/modest-account-settings-dialog.c:
393 (modest_account_settings_dialog_set_account_name):
394 * src/maemo/modest-maemo-utils.c:
395 (on_camel_account_get_supported_secure_authentication_status),
396 (on_camel_account_get_supported_secure_authentication),
397 (on_secure_auth_cancel),
398 (modest_maemo_utils_get_supported_secure_authentication_methods):
400 Implemented security authentication for settings and easysetup.
402 2007-06-05 Murray Cumming <murrayc@murrayc.com>
404 * src/maemo/modest-main-window.c: (create_details_widget):
405 Show the total size for memory card accounts too, instead of showing
406 the name again. Fixes bug projects.maemo.org bug NB#59307.
408 2007-06-05 Murray Cumming <murrayc@murrayc.com>
411 * src/modest-tny-simple-folder-store.c:
412 * src/modest-tny-simple-folder-store.h: Removed.
414 * src/modest-tny-local-folders-account.h
415 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
416 for the local-folders maildir, with an extra TnyMergedFolder containing
417 the folders of the per-account outbox store accounts.
418 * src/modest-tny-account-store.c: (get_server_accounts):
419 Add the outboxes to the special local folders account after creating it.
421 * src/modest-tny-account.c:
422 (modest_tny_account_new_for_local_folders): Create the derived
423 account when creating the main local-folders account.
425 * src/maemo/modest-main-window.c: (create_details_widget),
426 (modest_main_window_set_contents_style):
427 Adapted to the use of the derived account instead of the folder store.
429 * src/modest-ui-actions.c:
430 (modest_ui_actions_on_folder_selection_changed):
431 * src/modest-ui-dimming-rules.c:
432 (modest_ui_dimming_rules_on_new_folder):
433 * src/widgets/modest-folder-view.c: (text_cell_data),
434 (icon_cell_data), (filter_row), (update_model),
435 (get_cmp_rows_type_pos):
438 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
439 Do not get the priv struct, because no priv struct has been set,
440 to avoid a runtime warning.
442 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
443 #ifelse with #else, to fix a warning, to fix the build.
446 2007-06-05 Christian Kellner <ckellner@openismus.com>
448 * libmodest-dbus-client/libmodest-dbus-client.c:
449 Fix small typo in doc (why do you always see them
450 AFTER committing stuff?)
453 2007-06-05 Christian Kellner <ckellner@openismus.com>
455 * libmodest-dbus-client/libmodest-dbus-client.c:
456 (libmodest_dbus_client_search):
457 Initialize hit list with NULL. Also set folder list
458 to "" if NULL was supplied.
461 2007-06-03 Christian Kellner <ckellner@openismus.com>
463 * libmodest-dbus-client/libmodest-dbus-client.c:
464 (modest_search_hit_list_free):
465 Make it save to call it with NULL.
467 * src/dbus_api/modest-dbus-callbacks.c:
468 * src/modest-search.c:
469 Return full ModestSearchHits as the search result list not TnyHeader
470 since can't be around withouth the correspoding TnyFolder.
472 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
474 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
475 Added currently commented code to check for secure auth
477 * src/maemo/modest-account-settings-dialog.c: (on_response),
478 (save_configuration), (show_ok):
479 Fixed projects.maemo.org bugs NB #59248 and #59251
481 * src/maemo/modest-maemo-utils.c:
482 (on_camel_account_get_supported_secure_authentication_status),
483 (on_camel_account_get_supported_secure_authentication),
484 (modest_maemo_utils_get_supported_secure_authentication_methods):
485 * src/maemo/modest-maemo-utils.h:
486 Moved get_supported_secure_authentication() method here to be able
487 to use it from easysetup wizard.
489 * src/modest-pair.c: (on_pair_compare_as_string):
490 Should compare string with first part of pair and not
491 strcmp pairs which will crash.
493 * src/modest-protocol-info.c:
494 (modest_protocol_info_protocol_is_store):
495 * src/modest-protocol-info.h:
496 Added modest_protocol_info_get_auth_protocol_name()
498 2007-06-03 Armin Burgmeier <armin@openismus.com>
500 * src/modest-mail-operation.c:
501 (modest_mail_operation_get_msgs_full): Set priv->account also when
502 only retrieving a single message. This avoids a crash when canceling
505 (modest_mail_operation_notify_end): Do not explicitely remove the
506 operation from the queue but only emit the progress_changed signal.
507 The queue itself listens to that signal to remove the operation when
508 it is finished. This reduces coupling and removes a potential deadlock
509 when modest_mail_operation_notify_end() is called from the queue
510 itself. If that is a problem performance-wise, I would suggest to
511 implement a status-changed signal or something.
513 * src/modest-mail-operation-queue.c: Make sure to never call a
514 function from another file while the queue is locked. This (hopefully)
515 fixes another deadlock when exiting the application while retrieving
518 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
520 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
521 Fixed build if libogs is not available
523 2007-06-03 Christian Kellner <ckellner@openismus.com>
525 * libmodest-dbus-client/libmodest-dbus-client.h:
526 * libmodest-dbus-client/libmodest-dbus-client.c:
527 (libmodest_dbus_client_delete_message):
528 Implement deletion of messages (Client side).
530 (modest_search_hit_free),
531 (modest_search_hit_list_free):
532 Utility functions to free the result hits.
534 * src/dbus_api/modest-dbus-api.h:
535 * src/dbus_api/modest-dbus-callbacks.c:
537 (modest_dbus_req_handler):
538 Implement deletion of messages (Server side).
540 * tests/dbus_api/test_search.c: (main):
543 * tests/dbus_api/Makefile.am:
544 * tests/dbus_api/test_delete_message:
545 Add little test for the message deletion logic
547 2007-06-03 Armin Burgmeier <armin@openismus.com>
549 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
550 when the operation queue was not empty. projects.maemo.org bug
553 2007-06-03 Armin Burgmeier <armin@openismus.com>
555 * src/widgets/modest-account-view.c
556 (on_account_default_toggled): Toggle default account column
557 explicitely instead of waiting for gconf notification (which is
558 currently ignored). This should fix projects.maemo.org bug NB#56910
559 for now. It should probably be removed when gconf notifications are
562 2007-06-03 Christian Kellner <ckellner@openismus.com>
564 * libmodest-dbus-client/libmodest-dbus-client.c:
565 Removed debugging spew.
567 * src/dbus_api/modest-dbus-callbacks.c:
568 Added debugging info.
570 * src/modest-search.c:
571 (modest_search_all_accounts):
572 Use tny_account_store_get_accounts () on the account store
573 to get all accounts which is the way to get all accounts.
575 * tests/dbus_api/test_search.c: (main):
576 Make it possible to supply the search term on the command line.
578 2007-06-03 Christian Kellner <ckellner@openismus.com>
580 * libmodest-dbus-client/libmodest-dbus-client.c:
581 * libmodest-dbus-client/libmodest-dbus-client.h:
582 Implement searching for mesages over raw dbus. (Client side)
584 * src/dbus_api/Makefile.am:
585 * src/dbus_api/modest-dbus-api.h:
586 * src/dbus_api/modest-dbus-callbacks.c:
587 * src/dbus_api/modest-dbus-callbacks.h:
588 Search framework (Server side). Also implement on_idle_open_message().
590 * src/maemo/modest-platform.c: (modest_platform_init):
591 Prepare for raw dbus/osso rpc interaction.
593 * src/modest-search.h:
594 Changed minsize from unspecific guint to guint32.
596 * src/modest-search.c:
598 Added strange hack which magically made tnymail work.
600 (modest_search_folder),
601 (modest_search_account),
602 (modest_search_all_accounts):
603 Implement helper functions to search all accounts, specific account
606 * tests/dbus_api/Makefile.am:
607 * tests/dbus_api/test_open_message.c:
608 Read url to open from commandline.
610 * tests/dbus_api/test_search.c:
611 Implement small test for dbus search stuff
613 2007-06-02 Armin Burgmeier <armin@openismus.com>
615 * src/maemo/modest-account-settings-dialog.c: Changed window title to
616 include account type and account title. This fixes projects.maemo.org
619 * src/maemo/modest-account-view-window.c: Set a title for the window.
621 2007-06-02 Armin Burgmeier <armin@openismus.com>
623 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
624 incoming and outgoing server name based on email address and server
625 types as long as the names have not been edited manually. This fixes
626 projects.maemo.org bug NB#58671.
628 2007-06-02 Armin Burgmeier <armin@openismus.com>
630 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
631 server type cannot be changed in future to the incoming details page
632 when creating an account. This fixes projects.maemo.org bug NB#59029.
634 2007-06-02 Armin Burgmeier <armin@openismus.com>
636 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
637 and assigned max width chars so that they wrap instead of being
638 truncated. Fixes projects.maemo.org bug NB#56126.
640 2007-06-02 Armin Burgmeier <armin@openismus.com>
642 * src/maemo/modest-connection-specific-smtp-window.c: Add an
643 introductory note to the connection specific smtp servers dialog, as
644 section 8.12 of the email UI specification requires. This fixes
645 projects.maemo.org bug NB#59212.
647 2007-06-01 Murray Cumming <murrayc@murrayc.com>
649 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
650 Check for running mail operations, and offer to cancel them, as per the UI
651 spec. This fixes projects.maemo.org bug NB#59041 .
652 However, I suspect that tinymail may still use the network connection
653 in ways that we cannot detect or cancel. But it should at least adapt to
656 2007-06-01 Murray Cumming <murrayc@murrayc.com>
658 * src/modest-tny-account-store.c: (recreate_all_accounts),
659 (get_cached_accounts), (get_server_accounts): Do more sensible
660 ref-counting of the temporarily-cached outbox accounts list. This seems
661 to fix a crash when entering the password when the password was wrong.
663 2007-06-01 Murray Cumming <murrayc@murrayc.com>
665 * src/gnome/modest-main-window.c: (connect_signals):
666 * src/modest-tny-account-store.c: (get_password),
667 (modest_tny_account_store_alert): Added comments and clues and
668 commented-out code about how we currently fail to deal with connection
669 errors and wrong passwords, and how we should.
671 2007-06-01 Murray Cumming <murrayc@murrayc.com>
673 * src/widgets/modest-retrieve-combo-box.c:
674 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
675 This fixes projects.maemo.org bug NB#58472 .
677 2007-06-01 Murray Cumming <murrayc@murrayc.com>
679 * src/maemo/easysetup/modest-easysetup-wizard.c:
680 (create_page_complete_easysetup):
681 (create_page_complete_custom): Correct the last commit,
682 putting the correct sentences in the correct pages.
684 2007-06-01 Murray Cumming <murrayc@murrayc.com>
686 * src/maemo/easysetup/modest-easysetup-wizard.c:
687 (create_page_complete_custom): Show the second sentence of text
688 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
691 2007-06-01 Murray Cumming <murrayc@murrayc.com>
693 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
694 Set the leave-on-server conf key by default. This fixes
695 projects.maemo.org bug NB#59258 .
697 2007-06-01 Murray Cumming <murrayc@murrayc.com>
699 * src/maemo/modest-account-view-window.c:
700 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
701 logical ID for the confirmation messages. Fixed projects.maemo.org bug
704 2007-06-01 Murray Cumming <murrayc@murrayc.com>
706 * src/maemo/easysetup/modest-easysetup-wizard.c:
707 (create_caption_new_with_asterisk):
708 * src/maemo/modest-account-settings-dialog.c:
709 (create_caption_new_with_asterisk):
710 Uncomment the code to add the asterisk, because they are no longer in the
711 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
712 (update_incoming_server_title): Add an asterisk here too.
714 2007-06-01 Murray Cumming <murrayc@murrayc.com>
716 * src/maemo/modest-maemo-global-settings-dialog.c:
717 (current_connection): Check that we are even connected before trying to
718 get the current connection name, to prevent a warning.
720 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
721 Change the comments because tny_maemo_conic_device_connect() is now meant to
723 * src/modest-mail-operation.c:
724 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
725 make sure we have a connection and fail if we can't connect.
727 2007-05-31 Murray Cumming <murrayc@murrayc.com>
729 * src/maemo/modest-main-window.c:
730 (on_account_store_connecting_finished): Do not try to get the
731 connection ID if we are not really connected. I am surprised that
732 this signal handler is called when we are not connected.
734 2007-05-31 Murray Cumming <murrayc@murrayc.com>
736 * src/modest-error.h:
737 * src/modest-ui-actions.c:
738 (modest_ui_actions_get_msgs_full_error_handler):
739 Renamed an enum, added comments, added an enum
740 for retrieve-limit errors.
742 * src/modest-mail-operation.c: (foreach_add_item),
743 (internal_folder_observer_update), (update_account_thread),
744 (modest_mail_operation_get_msgs_full):
745 (modest_mail_operation_update_account),
746 Added comments about how this works, and some code that should
747 (but does not) check the retrieve-limit. See the TODO comment.
749 2007-05-31 Murray Cumming <murrayc@murrayc.com>
751 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
752 Initialize help_id to fix the build. Warnings are good.
754 2007-05-31 Murray Cumming <murrayc@murrayc.com>
756 * src/widgets/modest-hbox-cell-renderer.c:
757 (modest_hbox_cell_renderer_append):
758 * src/widgets/modest-vbox-cell-renderer.c:
759 (modest_vbox_cell_renderer_append):
760 Fix the last commit by doing an extra ref.
762 2007-05-31 Murray Cumming <murrayc@murrayc.com>
764 * src/widgets/modest-hbox-cell-renderer.c:
765 (modest_hbox_cell_renderer_append):
766 * src/widgets/modest-vbox-cell-renderer.c:
767 (modest_vbox_cell_renderer_append):
768 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
769 to fix the build with Maemo Bora.
770 However, there seems to be a remaining crash, probably due to reference
773 2007-05-30 Murray Cumming <murrayc@murrayc.com>
775 * src/modest-tny-account.c:
776 (modest_tny_account_new_for_local_folders):
777 Use hildon_file_system_info_async_new() to get a better name for
778 the memory card account, setting it as the account name.
779 The timing seems to work, but this is probably
780 not the best place to do this. See the TODO comment.
781 * src/maemo/modest-main-window.c: (create_details_widget):
782 * src/widgets/modest-folder-view.c: (text_cell_data):
783 Use the tny account name instead of hardcoding a name.
785 2007-05-30 Christian Kellner <ckellner@openismus.com>
787 * src/modest-search.c: (modest_search):
788 Correctly set part_search_func even if we have already parsed
789 the query and thus a valid OgsTextSearcher object.
791 2007-05-30 Christian Kellner <ckellner@openismus.com>
794 Search and check for libogs.
797 Incooparte the ogs build env.
799 * src/modest-mime-part-search-stream.c:
800 * src/modest-mime-part-search-stream.h:
801 Removed since we do the real searching now in modest-search.c.
803 * src/modest-search.c:
804 * src/modest-search.h:
805 Implement support for ogs. We use that if available and requested
806 and fall back to modest_text_utils_utf8_strcmp (). The search logic
807 should now handle the corner case when the search term is spread
808 across multiple reads.
809 Also the logic in modest_search () was corrected to search all
810 requested fields until one is found.
812 2007-05-30 Murray Cumming <murrayc@murrayc.com>
814 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
817 * src/modest-init.c: Made modest_init_local_folders() take a
818 path and be public so we can iniitialize maildir folders on
821 * src/modest-local-folder-info.h:
822 * src/modest-local-folder-info.c:
823 (modest_local_folder_info_get_maildir_path): Add a path parameter.
825 * src/modest-tny-account.c:
826 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
827 still means the standard local-folders path on the local volume.
829 * src/modest-tny-account-store.c:
830 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
831 signal so we can detect mount/unmount of the MMC1 card, and do an update of
832 all accounts when that happens.
833 (get_server_accounts): If the MMC1 card is mounted, create a store account for
834 this too, so it shows up in the treeview.
836 2007-05-28 Murray Cumming <murrayc@murrayc.com>
838 * src/maemo/modest-maemo-global-settings-dialog.c:
839 (current_connection):
840 * src/widgets/modest-global-settings-dialog.c:
841 (current_connection_default):
842 Use the enum values instead of 0, 1 and -1,
843 to make the code clearer.
845 * src/modest-account-mgr-helpers.c:
846 (modest_account_mgr_get_connection_specific_smtp): Make this code
849 * src/modest-runtime.h:
850 * src/modest-runtime.c:
851 Added modest_runtime_remove_all_send_queues().
852 * src/maemo/modest-main-window.c:
853 (on_account_store_connecting_finished): Recreate the send queues,
854 using the appropriate transport accounts for this new connection.
855 Some futher adapting might be needed if the old send queues are not
856 automatically stopped at this point.
858 * src/modest-tny-account-store.c: (get_server_accounts):
859 Create the connection-specific transport accounts, so that they can
860 be found later by their ID.
862 * src/modest-tny-account.h:
863 * src/modest-tny-account.c:
864 Added modest_tny_account_new_from_server_account_name().
865 modest_tny_account_new_from_server_account(): Do not create the
866 send queues here, because they will be
867 recreated anyway when the connection changes for the first time.
869 2007-05-28 Murray Cumming <murrayc@murrayc.com>
871 * src/modest-local-folder-info.h:
872 * src/modest-local-folder-info.c:
873 (modest_per_account_local_outbox_folder_info_get_maildir_path),
874 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
875 tbox_folder): Take a modest account name instead of a server TnyAccount,
876 so we can have per-modest-account rather than per-transport-account
878 We must make sure that we change or recreate the exisitng send queues
879 when the connection changes for connection-specific transport accounts.
881 * src/modest-tny-account-store.c:
882 (create_per_account_local_outbox_folders): Create outboxed per modest
883 account, not per transport account.
885 * src/modest-tny-account.h:
886 * src/modest-tny-account.c:
887 (modest_tny_account_get_special_folder): For outboxes, get the
888 parent modest account name. The account is ignored for other folders.
889 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
890 modest account name rather than a server TnyAccount.
892 2007-05-25 Murray Cumming <murrayc@murrayc.com>
894 * src/modest-tny-account.c:
895 (modest_tny_account_new_from_server_account):
896 Call modest_runtime_get_send_queue() immediately after creating transport
897 accounts, so that they start trying to send email from the outbox as soon
898 as possible at startup. This is probably what we want.
900 * src/modest-mail-operation.c: (update_account_thread):
901 * src/modest-runtime.c: (modest_runtime_get_send_queue):
902 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
903 * src/modest-tny-send-queue.h:
904 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
905 (modest_ui_actions_on_send):
906 Added comments about how sending works, though it needs some more work.
908 2007-05-25 Murray Cumming <murrayc@murrayc.com>
910 * src/modest-tny-account.c:
911 (modest_tny_account_get_special_folder): Add TODO because this fails when
913 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
914 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
915 Do not try to show this window when there is no active account. The UI
916 specs does not tell us what to do in this case.
918 2007-05-24 Murray Cumming <murrayc@murrayc.com>
922 * src/maemo/Makefile.am:
923 * src/widgets/Makefile.am: Some dist fixes.
925 2007-05-24 Murray Cumming <murrayc@murrayc.com>
927 * src/maemo/modest-connection-specific-smtp-window.c:
928 (on_button_edit): Make the code clearer, to prevent a double free.
930 2007-05-24 Murray Cumming <murrayc@murrayc.com>
932 * src/maemo/modest-account-settings-dialog.c:
933 (modest_account_settings_dialog_set_account_name),
934 Check the connection-specific smtp servers checkbox if there are any.
936 * src/maemo/modest-connection-specific-smtp-edit-window.c:
937 (modest_connection_specific_smtp_edit_window_init):
938 Start with a suitable port number.
940 * src/modest-account-mgr-helpers.h:
941 * src/modest-account-mgr-helpers.c: Added
942 modest_account_mgr_get_has_connection_specific_smtp().
944 (modest_account_mgr_set_connection_specific_smtp),
945 (modest_account_mgr_remove_connection_specific_smtp),
946 (modest_account_mgr_get_has_connection_specific_smtp),
947 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
948 connection-specific smtp server accounts in the account, rather than
949 the server account conf dir.
951 This fixes bug projects.maemo.org bug NB#58263 .
953 * src/modest-tny-account-store.c:
954 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
955 if there are no server accounts yet, to prevent an infinite loop when there
956 are no accounts. Document that one must be called before the other.
958 2007-05-24 Murray Cumming <murrayc@murrayc.com>
960 * src/modest-account-mgr-helpers.c:
961 (modest_account_mgr_get_default_account): Make sure that at least
962 one account is always the default, if there are any enabled accounts.
963 This is just a sanity check that shouldn't be necessary.
965 * src/modest-account-mgr-priv.c:
966 (_modest_account_mgr_account_from_key): Unescape the conf key to
967 get the real account name. For instance, this is an issue if a space
968 was in the account name, which can happen because the account name
969 is generated from the display name.
970 (_modest_account_mgr_get_account_keyname): Always escape the
972 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
973 Unescape the conf keys to get the real account names.
975 For instance, previously the is-default radio button in the accounts
976 list was not checked for any accounts at first. This fixes that,
977 and might fix several similar bugs.
979 2007-05-23 Murray Cumming <murrayc@murrayc.com>
981 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
982 Removed some debug printfs.
984 2007-05-23 Murray Cumming <murrayc@murrayc.com>
986 Modest on-disk outbox directories are now here, for instance:
987 $HOME/.modest/outboxes/<account-id-1>/outbox
988 $HOME/.modest/outboxes/<account-id-2>/outbox
990 $HOME/.modest/local-folders/outbox
991 so we can have a separate outbox for each account.
992 But they are shown as one outbox in the GtkTreeView, by using a
993 TnyMergeFolder in a ModestTnySimpleFolderStore.
996 * src/modest-tny-simple-folder-store.c:
997 * src/modest-tny-simple-folder-store.h:
998 Added ModestTnySimpleFolderStore, used to contain folders from
999 other folder stores, such as other accounts.
1001 * src/modest-tny-outbox-account.h:
1002 * src/modest-tny-outbox-account.c:
1003 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1004 used for the per-account local outbox folders.
1006 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1007 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1008 only use this (internally) now for the non-outbox local folders.
1010 * src/modest-init.h:
1011 * src/modest-init.c: Added modest_init_one_local_folder(), for
1012 setting up the directory structure for each local folder.
1014 * src/modest-local-folder-info.c:
1015 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1016 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1018 * src/modest-local-folder-info.h:
1019 * src/modest-tny-account-store.c: (on_account_removed),
1020 (on_account_changed), (create_per_account_local_outbox_folders),
1021 (get_server_accounts), (modest_tny_account_store_get_accounts),
1022 (modest_tny_account_store_get_tny_account_by_account),
1023 (modest_tny_folder_store_is_virtual_local_folders):
1025 * src/modest-tny-account.h:
1026 * src/modest-tny-account.c:
1027 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1028 to create an on-disk per-account local outbox folder for each
1030 (create_per_account_local_outbox_folders): Create a local outbox folder
1031 for each transport account.
1032 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1033 for all local folders.
1035 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1036 instead of using g_object_get/set() directly. It is clearer.
1038 (modest_tny_folder_store_get_message_count),
1039 (modest_tny_folder_store_get_local_size
1040 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1041 because we now use these with non-acount folder stores.
1043 (modest_tny_account_get_special_folder),
1044 (modest_tny_account_new_from_server_account),
1045 (modest_tny_account_new_from_account):
1046 (recurse_folders): Adjust to the new outbox system.
1048 * src/modest-tny-folder.h:
1049 * src/modest-tny-folder.c:
1050 (modest_tny_folder_is_local_folder),
1051 (modest_tny_folder_get_local_folder_type),
1052 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1054 * src/widgets/modest-main-window.h:
1055 * src/maemo/modest-main-window.c: (create_details_widget),
1056 (modest_main_window_set_contents_style): Show details for any folder store,
1059 (modest_tny_folder_get_rules):
1060 Remove the const. C does not support constness enough for this.
1062 * src/modest-ui-actions.c:
1063 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1064 make all outboxes appear as one, in the usual local-folders tree node.
1066 (set_active_account_from_tny_account),
1067 (modest_ui_actions_on_folder_selection_changed):
1068 * src/widgets/modest-folder-view.c: (text_cell_data),
1069 (icon_cell_data), (filter_row),
1070 (add_account_folders_to_merged_folder),
1071 (add_account_folders_to_simple_folder_store), (),
1072 (get_cmp_rows_type_pos), (cmp_rows),
1073 (modest_folder_view_set_account_id_of_visible_server_account):
1074 Adjust to the new outbox system, using generic folder stores and folders
1075 in the GtkTreeModel.
1077 2007-05-23 Christian Kellner <ckellner@openismus.com>
1079 * src/modest-mail-operation.c:
1080 (modest_mail_operation_update_account):
1081 Use info->max_size instead of unintialized local var [small
1082 build fix]. (Added TODO to review that change since I don't
1085 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1087 * libmodest-dbus-client/libmodest-dbus-client.c:
1088 (libmodest_dbus_client_compose_mail): function added
1089 * src/dbus_api/modest-dbus-api.h:
1090 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1091 (on_compose_mail): Implementation of the SendAsMail functionality
1093 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1095 * src/modest-account-mgr.c:
1096 (modest_account_mgr_add_server_account): Set the secure-connection
1097 conf key for transport accounts as well as store accounts. I don't know
1098 why the if was there. For instance, this makes sure that we use SSL
1099 for the gmail preset from the easysetup wizard.
1101 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1103 * src/gnome/modest-main-window.c:
1104 (on_account_store_connecting_finished), (connect_signals):
1105 * src/maemo/modest-main-window.c:
1106 (on_account_store_connecting_finished), (connect_signals),
1107 (modest_main_window_new):
1108 Handle TnyAccountStore::connecting-finished instead of
1109 TnyDevice::connection-changed, because we cannot actually perform
1110 operations on accounts until TnyAccountStore has itself responded to
1111 the TnyDevice::connection-changed signal. This prevents a GError from
1113 Do not try to update at startup, because we (at least on scratchbox)
1114 already do an update at startup when the device goes online.
1115 This prevents a GError from tinymail.
1116 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1117 Added TODO about stopping simultaneous operations.
1119 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1121 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1122 * src/modest-mail-operation-queue.c:
1123 (modest_mail_operation_queue_remove):
1124 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1125 about where they happened.
1127 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1129 * src/modest-ui-actions.c:
1130 (modest_ui_actions_on_password_requested): Make sure that the remember
1131 output parameter is always TRUE.
1133 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1135 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1136 Show a OK/Cancel dialog if the error is a question, though we still do not
1137 know anything more about what we are asking the user.
1138 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1139 Fix an uninitialized variable (helper). This is a logic error, however.
1141 2007-05-21 Christian Kellner <ckellner@openismus.com>
1143 * src/modest-search.h:
1144 Correct bit shifting in the ModestSearchFlags enum.
1146 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1148 * src/modest-tny-account.c:
1149 (modest_tny_account_new_from_server_account): Do not use the lsub and
1150 check-all hard-coded IMAP options when using POP.
1152 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1154 * src/modest-tny-account.c:
1155 (modest_tny_account_new_from_server_account):
1156 Use NULL for the secure-auth method for POP when Password auth has been
1157 specified by the user, as we already do for IMAP. "auth=Login" causes
1158 an error from camel or the server.
1160 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1162 * src/maemo/modest-account-settings-dialog.c:
1163 (create_page_account_details),
1164 (modest_account_settings_dialog_set_account_name):
1165 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1166 for the leave-on-server checkbox, rathr than just the checkbox, when
1167 the protocol is not POP.
1169 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1171 * src/widgets/modest-account-view.c:
1172 * src/widgets/modest-account-view.h:
1173 Added modest_account_view_select_account() which will be useful later
1174 to asynchronously re-select the edited account.
1176 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1178 * src/maemo/modest-account-settings-dialog.c:
1179 (modest_account_settings_dialog_set_account_name):
1180 Automatically choose the port numbers based on the secure authentication
1181 methods, if they have not been chosen before.
1182 This fixes projects.maemo.org bug NB#56273 .
1184 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1186 * src/maemo/modest-main-window-ui.h:
1187 * src/modest-ui-actions.c:
1188 * src/modest-ui-actions.h:
1189 Connect the Tools/SMTP Servers menu item to
1190 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1191 SMTP servers dialog, as in the UI specification and saves changes when it
1192 is closed. This fixed projects.maemo.org bug NB#56305 .
1194 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1196 * src/maemo/modest-connection-specific-smtp-window.c:
1197 (modest_connection_specific_smtp_window_init):
1198 Use gtk_window_set_default_size() to make this window big enough, so
1199 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1201 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1203 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1204 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1205 (modest_connection_specific_smtp_edit_window_init),
1206 Do not try to connect to a combobox signal before the combobox exists.
1207 This fixes the cras in projects.maemo.org bug NB#56288 .
1208 (modest_connection_specific_smtp_edit_window_get_settings):
1209 Remove the server_account_name parameter which was being checked for NULL
1210 though it was not used.
1212 * src/maemo/modest-connection-specific-smtp-window.c:
1213 (modest_connection_specific_smtp_window_fill_with_connections),
1214 (on_button_edit), (modest_connection_specific_smtp_window_init):
1215 Correct the number of treemodel columns to prevent a warning.
1216 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1217 libconic does not work.
1219 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1221 * src/modest-tny-account.c:
1222 (modest_tny_account_new_from_server_account):
1223 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1224 SMTP when "None" was chosen by the user. However, with my SMTP server that
1225 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1228 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1230 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1231 to explain the memory management issue with the ID in the ModestPair.
1233 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1234 (add_sending_page), (modest_account_assistant_finalize):
1235 * src/gnome/modest-gnome-global-settings-dialog.c:
1236 (create_updating_page), (create_composing_page):
1237 * src/gnome/modest-msg-edit-window.c: (get_transports),
1238 (init_window), (modest_msg_edit_window_finalize),
1239 (modest_msg_edit_window_get_msg_data):
1240 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1241 * src/gnome/modest-transport-widget.c:
1242 (modest_transport_widget_finalize), (smtp_configuration):
1243 * src/maemo/modest-maemo-global-settings-dialog.c:
1244 (create_updating_page), (create_composing_page):
1245 * src/maemo/modest-msg-edit-window.c: (get_transports),
1246 (init_window), (modest_msg_edit_window_finalize),
1247 (modest_msg_edit_window_get_msg_data),
1248 (modest_msg_edit_window_free_msg_data):
1249 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1250 (modest_store_widget_finalize):
1251 * src/maemo/modest-transport-widget.c:
1252 (modest_transport_widget_finalize), (smtp_configuration):
1253 * src/modest-main.c: (send_mail):
1254 * src/widgets/modest-combo-box.h:
1255 * src/widgets/modest-global-settings-dialog-priv.h:
1256 * src/widgets/modest-global-settings-dialog.c:
1257 (modest_global_settings_dialog_finalize):
1258 * src/widgets/modest-msg-edit-window.h:
1259 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1260 as long as the combo box, to prevent use of freed memory for the ID.
1262 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1264 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1265 get_accounts(), to make this clearer. Do not check for the enabled gconf
1266 key, because we do not use this for server accounts (at least, not yet).
1267 This allows us to send email again.
1269 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1271 * src/maemo/modest-platform.c:
1272 (on_modest_conf_update_interval_changed), (modest_platform_init):
1273 Only respond to this particular key change. All these strcmp()s cannot be
1276 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1278 * src/maemo/modest-maemo-global-settings-dialog.c:
1279 (current_connection): Prevent a crash in scratchbox when
1280 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1281 * src/maemo/modest-platform.c:
1282 (on_modest_conf_update_interval_changed), (modest_platform_init):
1283 Get the update interval from gconf and reset it when the gconf key changes.
1285 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1287 * src/modest-protocol-info.c:
1288 * src/modest-protocol-info.h: Adde enum-specific get functions,
1289 instead of using a ModestProtocolType enum parameter.
1291 * src/gnome/modest-account-assistant.c:
1292 * src/gnome/modest-store-widget.c:
1293 * src/gnome/modest-store-widget.h:
1294 * src/gnome/modest-transport-widget.c:
1295 * src/gnome/modest-transport-widget.h:
1296 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1297 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1298 * src/maemo/easysetup/modest-easysetup-wizard.c:
1299 * src/maemo/modest-account-settings-dialog.c:
1300 * src/maemo/modest-account-settings-dialog.h:
1301 * src/maemo/modest-store-widget.c:
1302 * src/maemo/modest-store-widget.h:
1303 * src/maemo/modest-transport-widget.c:
1304 * src/maemo/modest-transport-widget.h:
1305 * src/modest-account-mgr-helpers.c:
1306 * src/modest-account-mgr-helpers.h:
1307 * src/modest-account-mgr.c:
1308 * src/modest-account-mgr.h:
1309 * src/modest-tny-account.c:
1310 * src/modest-tny-folder.c:
1311 * src/widgets/modest-account-view.c:
1312 * src/widgets/modest-retrieve-combo-box.c:
1313 * src/widgets/modest-retrieve-combo-box.h:
1314 * src/widgets/modest-secureauth-combo-box.c:
1315 * src/widgets/modest-serversecurity-combo-box.c:
1316 * src/widgets/modest-serversecurity-combo-box.h:
1317 * tests/check_account-mgr.c:
1318 Use the specific functions, and use the re-renamed enum values for GNOME too.
1320 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1322 * src/modest-pair.h:
1323 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1324 so we can get the second based on the first.
1326 * src/maemo/modest-account-settings-dialog.h:
1327 * src/maemo/modest-account-settings-dialog.c:
1328 Added get_supported_secure_authentication_methods(), though it is mostly
1329 commented-out for now until the necessary API is committed to tinymail.
1330 (modest_account_settings_dialog_set_account_name),
1331 (save_configuration): Request the supported authentication methods from the
1332 server, so we can choose a working method.
1334 * src/modest-tny-account-store.h:
1335 * src/modest-tny-account-store.c:
1336 (modest_tny_account_store_get_session): Rename from
1337 tny_account_store_get_session().
1339 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1341 * src/modest-protocol-info.h: Split the ModestProtocol enum
1342 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1343 There was no need to have these unrelated values in one enum.
1345 * src/: many files: Adapted to changed enum. This makes the code a bit
1346 clearer, and the compiler could catch some errors.
1348 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1350 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1351 Show the detailed internal camel error message when an error happens
1352 during the configuration, so that our testers can give us more clues.
1353 For instance, in projects.maemo.org bug NB#56910 .
1355 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1357 * src/modest-tny-account.c:
1358 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1359 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1361 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1363 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1364 * src/maemo/modest-account-settings-dialog.c:
1365 (modest_account_settings_dialog_set_account_name),
1366 (save_configuration): For the incoming secure authentication checkbox,
1367 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1368 the UI specification. PLAIN does not seem to be supported for most IMAP
1369 servers anyway, and I am not sure what it would mean.
1370 However, we probably need to discover which of the secure-authentication
1371 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1372 * src/modest-account-mgr-helpers.c:
1373 (modest_account_mgr_get_server_account_data):
1375 * src/modest-tny-account.c:
1376 (modest_tny_account_new_from_server_account):
1377 Use tny_account_set_mech() to set secure-authentication methods,
1378 with some special-casing for IMAP, based on my observations of how
1381 * src/modest-account-mgr-helpers.h:
1382 * src/modest-account-mgr.c:
1383 * src/modest-defs.h: Comment that the URI is only used for local folders.
1385 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1387 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1388 parameter const, just to be neat.
1389 * src/modest-text-utils.c: (modest_text_utils_inline):
1390 End g_strconcat() with NULL, as its documentation says. This is almost
1391 certainly the cause of my crash at startup on the device. Interestingly,
1392 valgrind doesn't tell us about these errors.
1394 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1396 * scripts/build-packages: Added more precise comments about how to use
1397 this script, though I still get this error:
1398 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1399 error building tinymail
1401 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/modest-main-window.c: (on_account_update):
1404 Very slight cleanup, hoping to make it simpler to discover what causes
1405 a crash here sometimes.
1407 * src/modest-tny-account.c:
1408 (modest_tny_account_new_from_server_account): Set the port. Added
1409 comments about the options and a TODO comment because I need to find out
1410 how to specify the secure authentication method.
1412 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1414 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1415 changed CFlags paths form modest to libmodest
1417 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1419 * src/modest-account-mgr-helpers.c:
1420 (modest_account_mgr_get_server_account_data),
1421 (modest_account_mgr_free_server_account_data):
1422 * src/modest-account-mgr-helpers.h:
1423 * src/modest-account-mgr.c:
1424 (modest_account_mgr_add_server_account):
1425 * src/modest-defs.h:
1426 * src/modest-tny-account.c:
1427 (modest_tny_account_new_from_server_account):
1428 Determine the options for tny_camel_account_add_option() here,
1429 based on the settings, rather than storing them directly in gconf.
1431 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1433 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1434 Show a more friendly error dialog now that we expect (from the tinymail
1435 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1437 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1439 * src/maemo/modest-main-window.c: (on_account_update): Check that
1440 account_name is not NULL, to prevent a crash at startup that I am
1441 seeing on the N800. I do wonder why it is NULL.
1443 * src/maemo/easysetup/modest-easysetup-wizard.c:
1444 (create_page_user_details):
1445 * src/maemo/modest-account-settings-dialog.c:
1446 (create_page_user_details), (create_page_outgoing):
1447 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1448 (modest_connection_specific_smtp_edit_window_init):
1449 * src/modest-ui-actions.c:
1450 (modest_ui_actions_on_password_requested):
1451 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1452 might do something useful with the on-screen keyboard.
1454 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1456 * src/maemo/modest-main-window.c: (on_account_update):
1457 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1458 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1460 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1462 * src/modest-tny-account-store.c: (on_account_changed):
1463 Correct the signature of this signal handler.
1465 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1467 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1468 Show a HildonNote instead of a GtkDialog for Maemo.
1470 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1472 * src/widgets/modest-account-view.h:
1473 * src/widgets/modest-account-view.c: (on_account_changed),
1474 (on_account_removed). Added a boolean flag, set/unset by
1475 modest_account_view_block_conf_updates(),
1476 modest_account_view_unblock_conf_updates() to prevent unnecessary
1477 updates, but this is not very useful because the gconf notifications are
1478 so delays (maybe only on Maemo Bora).
1479 So auto-updating is turned off, and these functions do an explicit
1480 update when necessary.
1481 However, something else is still doing too much work when adding/removing
1482 accounts, probably in another part of the application.
1484 * src/maemo/modest-account-view-window.c:
1485 (on_delete_button_clicked), (on_edit_button_clicked),
1486 (on_new_button_clicked): Use the new functions.
1488 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1490 * src/modest-account-mgr-helpers.c:
1491 (modest_account_mgr_set_first_account_as_default):
1492 Sort the list of names alphabetically-by-title, so we choose the first one
1494 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1495 alphabetically by the title.
1497 This fixes projects.maemo.org bug NB#56418 .
1499 * src/modest-account-mgr-priv.c:
1500 (_modest_account_mgr_account_from_key):
1501 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1502 avoid a valgrind error, and possible random behaviour.
1504 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1506 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1507 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1508 tinymail documentation to say that this can be expected.
1509 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1510 pretty, and should not happen, but I would prefer to know when it does.
1512 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1514 * configure.ac: When using the older hildon version, probably on Bora,
1515 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1517 * src/widgets/modest-attachment-view.c:
1518 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1521 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1523 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1524 Implemented the prototype. Can be tested with
1525 tests/dbus_api/test_open_message:
1527 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1529 * src/modest-tny-account-store.c:
1530 (modest_tny_account_store_instance_init), (get_password):
1531 * src/modest-ui-actions.c:
1532 (modest_ui_actions_on_password_requested):
1533 Do not store the password in gconf, because this function is called
1534 for non-remembered passwords. Actually use the cached (in the hash map)
1535 password instead of releasing it.
1536 The password will now not be remembered if it is asked via the protected
1537 password dialog, as per the UI spec.
1539 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1541 * src/modest-defs.h:
1542 * src/modest-account-mgr-helpers.h:
1543 * src/modest-account-mgr-helpers.c:
1544 Added modest_server_account_get_username_has_succeeded(),
1545 modest_server_account_set_username_has_succeeded().
1546 (modest_server_account_set_username),
1547 Reset the has-succeeded flag if the username changes.
1549 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1550 * src/maemo/modest-connection-specific-smtp-window.c:
1551 (modest_connection_specific_smtp_window_save_server_accounts):
1552 Use modest_server_account_set_username() instead of using
1553 modest_conf_set_string() directly, so that the has-succeeded flag is always
1556 * src/modest-ui-actions.c:
1557 (modest_ui_actions_on_password_requested): Dim the username entry if
1558 the username has ever worked, as per the UI spec.
1560 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1562 * src/modest-tny-account-store.c: (get_password):
1563 * src/modest-ui-actions.c:
1564 (modest_ui_actions_on_password_requested):
1565 Allow the username to be changed too, though there is more work to
1566 be done on exactly how this behaves.
1568 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1570 * src/modest-account-mgr-helpers.h:
1571 * src/modest-account-mgr-helpers.c:
1572 Added modest_account_mgr_get_display_name(),
1573 modest_server_account_get_username(),
1574 modest_server_account_set_username(),
1575 modest_server_account_set_password(),
1576 modest_server_account_get_hostname() functions so we do not need to
1577 use the conf API directly.
1579 * src/maemo/modest-main-window.c: (connect_signals):
1580 Actually connect ot the ModestAccountStore::request-password signal,
1581 so that we show the dialog when the password is requested by Tinymail,
1582 for isntance if it is empty.
1584 * src/modest-marshal.list:
1585 * src/modest-tny-account-store.c:
1586 (modest_tny_account_store_class_init), (get_password),
1587 (modest_tny_account_store_alert):
1588 * src/modest-tny-account-store.h:
1589 * src/modest-ui-actions.h:
1590 * src/modest-ui-actions.c:
1591 (modest_ui_actions_on_password_requested):
1592 Change the signal parameters, so it is obvious that we are providing
1593 the non human-readable server name, and receiving both the username
1594 and password, though changing of the username is not yet implemented.
1595 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1596 for the GNOME version.
1598 This should fix the projects.maemo.org bug NB#56209, though it does not
1599 work on Bora, because the gconf_client_get() for the password fails
1600 immediately after we save it with gconf_client_set().
1602 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1605 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1606 caused an undefined symbol error:
1607 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1609 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1611 * src/modest-tny-account-store.c:
1612 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1613 using a GError instead of a string message, so we can translate it in
1616 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1618 * src/maemo/modest-address-book.c:
1619 (modest_address_book_check_names):
1620 * src/maemo/modest-msg-view-window.c:
1621 (modest_msg_view_window_clipboard_owner_change):
1622 * src/modest-init.c: (modest_init_init_ui):
1623 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1624 (update_folders_cb), (modest_mail_operation_update_account):
1625 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1626 (modest_ui_actions_on_msg_attachment_clicked),
1627 (modest_ui_actions_on_msg_recpt_activated):
1628 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1629 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1630 (modest_msg_view_search_next):
1631 * src/widgets/modest-recpt-editor.c:
1632 (modest_recpt_editor_on_button_release_event),
1633 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1634 g_message(). At this point we should only be seeing interesting errors on
1635 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1637 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1639 (modest_wizard_dialog_force_title_update):
1640 * src/maemo/easysetup/modest-wizard-dialog.h:
1641 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1642 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1643 can update the title when appropriate. Otherwise the title is wrong if the
1644 pages are added after adding the notebook to the dialog.
1645 This must be a problem in HildonWizardDialog too.
1646 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1648 * src/maemo/easysetup/modest-easysetup-wizard.c:
1649 (create_subsequent_customsetup_pages),
1650 (create_subsequent_easysetup_pages):
1651 Call modest_wizard_dialog_force_title_update() so that the title is
1652 correct even with GTK+ < 2.10.
1653 This fixes projects.maemo.org bug NB#56145 .
1655 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1657 * src/maemo/modest-platform.c:
1658 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1659 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1662 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1664 * src/widgets/modest-window.h:
1665 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1666 and modest_window_save_state(), which invokes it.
1668 * src/widgets/modest-window-mgr.h:
1669 * src/widgets/modest-window-mgr.c:
1670 Added modest_window_mgr_save_state_for_all_windows(), which calls
1671 the save_state vfunc on all registered windows, if implemented.
1673 * src/gnome/modest-msg-edit-window.c:
1674 * src/gnome/modest-msg-view-window.c:
1675 * src/maemo/modest-msg-edit-window.c:
1676 * src/maemo/modest-msg-view-window.c:
1677 * src/maemo/modest-main-window.c:
1678 Specify the existing save_settings functions as implementations of
1679 ModestWindow::save_state_func().
1681 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1682 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1683 enabling hibernation, for instance.
1685 We may need to do the same thing for restoring settings.
1688 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1690 * src/widgets/modest-window-mgr.c:
1691 * src/widgets/modest-window-mgr.h:
1692 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1693 modest_window_mgr_get_hibernation_is_prevented().
1695 * src/maemo/modest-main-window.c:
1696 (on_hildon_program_is_topmost_notify): Prevent hibernation
1697 (possible when the application goes to the background in the WM),
1698 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1700 * src/maemo/easysetup/modest-easysetup-wizard.c:
1701 (modest_easysetup_wizard_dialog_init):
1702 * src/maemo/modest-account-settings-dialog.c:
1703 (modest_account_settings_dialog_init):
1704 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1705 (modest_connection_specific_smtp_edit_window_init):
1706 * src/maemo/modest-connection-specific-smtp-window.c:
1707 (modest_connection_specific_smtp_window_init):
1708 * src/maemo/modest-signature-editor-dialog.c:
1709 (modest_signature_editor_dialog_init):
1710 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1711 prevent hibernation while any of these account settings dialogs are open.
1713 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1715 * src/maemo/Makefile.am:
1716 * src/maemo/modest-osso-state-saving.c:
1717 * src/maemo/modest-osso-state-saving.h: Added
1718 modest_osso_load_state() and modest_osso_save_state() though they do
1719 nothing now. They should iterate through all the open windows and load/save
1721 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1722 save state when closing.
1724 * src/maemo/modest-main-window.c:
1725 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1726 Add a notification handler for the HildonProgram::is-topmost property,
1727 so we can allow hibernation when the application goes into the background.
1728 But we still need to detect when the accounts setup windows are open so
1729 we can stop hibernation when they are open.
1730 To do this, I also added the main window the HildonProgram. This might have
1731 other side-effects/benefits, and should maybe be done for other windows.
1733 * src/maemo/modest-osso-autosave-callbacks.h:
1734 * src/maemo/modest-osso-autosave-callbacks.c:
1735 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1736 though it does not do anything yet, and we might never need this to do
1737 anything. For instance, we already save drafts.
1739 * src/maemo/modest-platform.c: (modest_platform_init):
1740 Specify the libosso auto-save callback.
1742 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1744 * src/maemo/modest-platform.c:
1745 (modest_platform_set_update_interval):
1746 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1747 aparently stays valid between application instances, so we can use this
1748 to remove and reset it later. According to a maemo-developers email from
1751 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1753 * configure.ac: Depend on libalarm for Maemo.
1755 * src/dbus_api/modest-dbus-api.h:
1756 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1757 (on_send_receive), (modest_dbus_req_handler):
1758 Handle a SEND_RECEIVE D-Bus method.
1760 * libmodest-dbus-client/libmodest-dbus-client.c:
1761 (libmodest_dbus_client_send_and_receive):
1762 * libmodest-dbus-client/libmodest-dbus-client.h:
1763 Add C convenience functions for calling the new D-Bus method.
1765 * src/modest-platform.h:
1766 * src/gnome/modest-platform.c:
1767 * src/maemo/modest-platform.c:
1768 Added modest_platform_set_update_interval(), which uses the
1769 alarmd API on Maemo.
1770 (modest_platform_init),
1771 Call modest_platform_set_update_interval(), using a hard-coded
1772 interval for now (until the global settings dialog is implemented),
1773 though I am not sure that this makes sense yet.
1775 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1777 * src/dbus_api/modest-dbus-callbacks.c:
1778 (modest_osso_cb_hw_state_handler):
1779 * src/dbus_api/modest-dbus-callbacks.h:
1780 * src/maemo/modest-platform.c: (modest_platform_init):
1781 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1782 in case this has some effect on the ability for Maemo to ping the
1785 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1787 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1788 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1789 warning. It is probably a logic error, but I need to fix the build.
1791 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1793 * src/modest-account-mgr.h:
1794 * src/modest-account-mgr.c:
1795 (modest_account_mgr_account_names): Add a gboolean enabled_only
1796 parameter, so we can get lists of onlt the enabled accounts.
1798 (modest_account_mgr_add_account),,
1799 (modest_account_mgr_account_with_display_name_exists):
1800 * src/maemo/modest-msg-edit-window.c: (get_transports):
1801 * src/modest-account-mgr-helpers.c:
1802 (modest_account_mgr_set_first_account_as_default):
1803 * src/modest-init.c: (init_default_account_maybe):
1804 * src/modest-tny-account-store.c: (get_accounts):
1805 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1806 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1807 * tests/check_account-mgr.c: (START_TEST):
1808 Provide the extra parameter, as appropriate.
1810 * src/widgets/modest-account-view.c: (update_account_view):
1811 Do not show disabled accounts (meaning that there is no way to
1812 enable/disable accounts in the UI (the feature is not in our UI
1813 specification), so we can use this internally only to mark unfinished
1814 or temporary account data.
1816 * src/maemo/easysetup/modest-easysetup-wizard.c:
1817 (create_account): Add boolean enable parameter, so we can specify FALSE
1818 to create the temporary account.
1819 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1820 (on_before_next): When finishing, when there is a temporary account, just
1822 Also, use a timeout to delay the showing of the dialog until gconf is likely
1823 to return correct information, due to a maemo gconf bug that is fixed in
1824 osso 1.1, but not yet in Bora.
1825 However, the dialog stays on screen after it is destroyed.
1827 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1828 for invalid data when cancelling. Use a hildon note instead of a dialog
1829 to complain about invalid data. Do not show the account-saved note if the
1830 account is disabled (a temporary account that will not really be saved for use
1833 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1835 * src/modest-account-mgr-helpers.h:
1836 * src/modest-account-mgr-helpers.c:
1837 Added modest_account_mgr_unset_default_account(),
1838 Added modest_account_mgr_set_first_account_as_default().
1840 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1841 If it was the default account, unset the default account name.
1843 * src/maemo/modest-account-view-window.c:
1844 (on_delete_button_clicked): If it was the default account,
1845 set the first remaining account as the default instead.
1847 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1848 a NULL account or a NULL default account, to prevent a crash. This should
1849 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1852 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1854 * src/widgets/modest-recpt-editor.c:
1855 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1856 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1857 TODO comment for this. This fixes the build.
1859 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1860 be the best place for it. This will in future update all auto-update accounts,
1861 rather than just the current/default account, when that gconf key exists.
1862 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1863 if there are no accounts, before calling do_send_receive().
1864 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1866 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1867 * src/maemo/modest-main-window-ui.h:
1868 * src/maemo/modest-main-window.c: (on_connection_changed),
1869 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1870 directly, becaue the signal handler does more.
1872 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1874 * src/modest-account-mgr-helpers.c:
1875 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
1876 for the case that the account does not exist.
1878 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
1879 (equivalent to the modest account name) rather than the tinymail account name
1880 (equivalent to the modest account title - human readable) to get the account data.
1881 Check for null account data to prevent the crash, and add a TODO comment saying that
1882 this needs fixing because it is using the server account name instead of the account name.
1884 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1886 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
1887 * src/maemo/modest-account-settings-dialog.c: (show_error),
1889 Use hildon_note_new_information() for informative and error messages,
1890 which seems to be expected for Maemo applications (no documentation that I know of
1891 says this). I am surprised that there is no distinction between info and error
1894 2007-04-29 Murray Cumming <murrayc@murrayc.com>
1896 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
1897 it is easy to find where this is used.
1899 * src/maemo/easysetup/modest-easysetup-wizard.c:
1900 (create_page_welcome), (create_page_account_details),
1901 (create_page_user_details), (create_page_complete_easysetup),
1902 (create_page_custom_incoming), (create_page_custom_outgoing),
1903 (create_page_complete_custom):
1904 * src/maemo/modest-account-settings-dialog.c:
1905 (create_page_account_details), (create_page_user_details),
1906 (create_page_incoming), (create_page_outgoing):
1907 * src/maemo/modest-account-view-window.c: (window_vbox_new):
1908 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1909 (modest_connection_specific_smtp_edit_window_init):
1910 * src/maemo/modest-connection-specific-smtp-window.c:
1911 (modest_connection_specific_smtp_window_init):
1912 * src/maemo/modest-signature-editor-dialog.c:
1913 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
1914 and scrolling policy as per the Email Application Layout Guide, if I have
1917 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1919 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
1920 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
1921 which were empty, because these vfuncs have been removed from TnyAccountStore.
1922 This fixes the build.
1924 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1926 * src/maemo/modest-main-window.c:
1927 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
1928 showing/hiding it. Added TODO because it probably should not be NULL.
1929 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
1930 because unnecessary g_warnings() make degugging difficult.
1932 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1934 * src/maemo/modest-msg-edit-window.c:
1935 (modest_msg_edit_window_select_color),
1936 (modest_msg_edit_window_select_background_color): 2 const corrections and
1937 moving 2 #endifs before closing brackets, to fix the build.
1939 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1941 * src/maemo/easysetup/modest-easysetup-wizard.h:
1942 * src/maemo/easysetup/modest-easysetup-wizard.c:
1943 (modest_easysetup_wizard_dialog_finalize),
1944 (on_button_edit_advanced_settings), (create_page_complete_custom),
1945 (on_response), (create_account):
1946 Implement the Advanced Settings edit button, by saving the account information,
1947 for the Advanded Settings dialog to use directly from gconf, and removing it
1948 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
1949 Bug #5533 in the projects.maemo.org bugzilla.
1951 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1953 * src/maemo/modest-msg-view-window.c:
1954 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
1955 when opening a message window.
1957 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1959 * src/maemo/easysetup/modest-easysetup-wizard.c:
1960 (create_page_custom_outgoing): Correct the position of the horizontal separator to
1963 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
1964 before showing/hiding them, to avoid a crash when clicking on folders when there are no
1965 gconf settings. I probably added more checks than necessary, but that is safer.
1967 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
1968 variable to fix the build, but this seems to be used when it is still NULL.
1970 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1972 * src/modest-platform.h:
1973 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
1974 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
1975 * src/modest-main.c: Implement this function so we can avoid using
1976 maemo-specific API from cross-platform code.
1978 * src/modest-tny-account-store.c:
1979 (get_smtp_specific_transport_account_for_open_connection):
1980 * src/modest-ui-actions.c: (check_for_connection),
1981 (modest_ui_actions_on_item_not_found):
1982 Use modest_platform_connect_and_wait() and put #idefs around other
1983 maemo-specific code, because only maemo currently has a way to
1984 identify connection names.
1986 2007-04-27 Murray Cumming <murrayc@murrayc.com>
1988 * src/modest-tny-account-store.h:
1989 * src/modest-tny-account-store.c:
1990 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
1991 the connection-specific SMTP server settings in the configuration.
1993 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
1995 * src/maemo/modest-main-window.c: (on_connection_changed),
1997 * src/modest-main.c: (main), (start_ui), (send_mail):
1998 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
1999 that is what is intended.
2001 * src/modest-ui-actions.c: (action_send), (action_receive),
2002 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2003 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2004 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2005 SMTP server is used when it is specified.
2007 (modest_ui_actions_on_send_receive):
2008 Check that a connection is open before proceeding.
2009 Receive and then send, instead of vice-versa, as per the specification.
2011 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2013 * src/modest-mail-operation.c:
2014 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2015 though I guess it should be something other than NULL.
2017 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2019 * src/maemo/easysetup/modest-easysetup-wizard.c:
2020 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2021 combo twice, to avoid an g_warning and to make it visible again.
2022 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2023 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2024 (already intended) dereference when detaching, because we then recreate the menu.
2025 But I am not sure why the warning was happening, and it is possible that this is a memory
2028 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2030 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2031 and uri_parse_mailto() utility functions.
2032 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2034 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2036 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2038 * src/dbus_api/modest-dbus-api.h:
2039 * src/dbus_api/modest-dbus-callbacks.c:
2040 Use an idle callback to execute the modest code in the application's own thread.
2041 Remove the helloworld example method.
2042 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2043 parsed, and the open-message method is not implemented because this is not yet implemented in
2045 * libmodest-dbus-client/libmodest-dbus-client.c:
2046 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2047 (libmodest_dbus_client_open_message):
2048 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2050 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2051 body without crashing.
2053 * tests/dbus_api/Makefile.am:
2054 * tests/dbus_api/test_mail_to.c:
2055 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2057 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2059 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2060 Added file to fix the build. Sorry.
2062 * src/dbus_api/Makefile.am:
2063 * src/dbus_api/modest-dbus-api.h:
2064 * src/dbus_api/modest-dbus-callbacks.h:
2065 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2066 (modest_dbus_req_handler):
2067 Put constants in a separate header so it can be reused by the
2068 client library, without duplication
2070 * libmodest-dbus-client/Makefile.am:
2071 * libmodest-dbus-client/libmodest-dbus-client.c:
2072 (libmodest_dbus_client_call_helloworld),
2073 (libmodfest_dbus_client_send_mail),
2074 (libmodfest_dbus_client_mailto),
2075 (libmodfest_dbus_client_open_message):
2076 * libmodest-dbus-client/libmodest-dbus-client.h:
2077 (Partly) Implement a send_mail D-Bus method.
2079 * tests/dbus_api/Makefile.am:
2080 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2081 the send_email D-Bus method.
2083 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2087 * libmodest-dbus-client/Makefile.am:
2088 * libmodest-dbus-client/libmodest-dbus-client.c:
2089 * libmodest-dbus-client/libmodest-dbus-client.h:
2090 * tests/dbus_api/Makefile.am:
2091 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2092 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2094 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2096 * src/maemo/easysetup/modest-easysetup-wizard.c:
2097 (create_page_account_details):
2098 * src/maemo/modest-account-settings-dialog.c:
2099 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2100 widgets, because this might not be the default in future versions of the Maemo GTK+.
2101 However, I can not not get capitalization to work even in a simple test case.
2103 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2105 * src/maemo/easysetup/modest-easysetup-wizard.c:
2106 (create_page_custom_incoming), (create_page_custom_outgoing):
2107 * src/maemo/modest-account-settings-dialog.c:
2108 (create_page_account_details), (create_page_incoming),
2109 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2110 instead of using gtk_check_button_with_label(), so they are aligned like the other
2111 widgets, as per the UI spec.
2113 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2115 * src/maemo/easysetup/modest-easysetup-wizard.c:
2116 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2117 * src/widgets/modest-validating-entry.c:
2118 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2119 Modest prefix instead of an EasySetup prefix.
2121 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2123 * src/widgets/modest-validating-entry.h:
2124 * src/widgets/modest-validating-entry.c: (on_insert_text),
2125 Added easysetup_validating_entry_set_max_func(), used to set a callback
2126 to call when the max number of characters is reached. GtkEntry has a max-length
2127 already but is silent about it.
2129 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2130 (create_page_account_details), (create_page_user_details),
2132 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2133 (create_page_account_details), (create_page_user_details),
2134 (create_page_outgoing):
2135 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2136 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2137 the UI spec, when the user tries to enter more than the max number of characters.
2139 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2141 * src/maemo/easysetup/modest-easysetup-wizard.c:
2142 (create_page_user_details), (create_page_custom_incoming),
2143 (create_page_custom_outgoing):
2144 * src/maemo/modest-account-settings-dialog.c:
2145 (create_page_user_details), (create_page_incoming),
2146 (create_page_outgoing):
2147 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2148 (modest_connection_specific_smtp_edit_window_init):
2149 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2150 not appropriate. Bad Maemo-specific defaults!.
2152 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2154 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2155 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2156 (modest_signature_editor_dialog_set_settings):
2157 Disable the label and textview when the checkbox is disabled, and use the
2158 specified (UI spec) default signature text.
2160 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2162 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2163 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2165 * src/modest-defs.h:
2166 * src/modest-account-mgr-helpers.h:
2167 * src/modest-account-mgr-helpers.c:
2168 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2170 * src/maemo/Makefile.am:
2171 * src/maemo/modest-signature-editor-dialog.c:
2172 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2175 * src/maemo/modest-account-settings-dialog.h:
2176 * src/maemo/modest-account-settings-dialog.c:
2177 (modest_account_settings_dialog_finalize), (on_button_signature),
2178 (save_configuration): Use the new dialog when the Edit button is pressed, and
2179 save the changes if necessary, as per the UI spec.
2181 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2183 * src/maemo/Makefile.am:
2184 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2185 based on maemo-develoers email from Dirk.
2187 * src/maemo/easysetup/modest-easysetup-wizard.c:
2188 (create_page_welcome), (create_page_account_details),
2189 (create_page_user_details), (create_page_complete_easysetup),
2190 (create_page_custom_incoming), (create_page_custom_outgoing),
2191 (create_page_complete_custom),
2192 (modest_easysetup_wizard_dialog_init):
2193 * src/maemo/modest-account-settings-dialog.c:
2194 (create_page_account_details), (create_page_user_details),
2195 (create_page_incoming), (create_page_outgoing),
2196 (modest_account_settings_dialog_init):
2197 * src/maemo/modest-connection-specific-smtp-window.c:
2198 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2200 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2202 * src/maemo/easysetup/modest-easysetup-wizard.c:
2203 (create_page_account_details), (create_page_custom_outgoing),
2204 (create_page_complete_custom):
2205 * src/maemo/modest-account-settings-dialog.c:
2206 (create_page_user_details), (create_page_incoming),
2207 (create_page_outgoing):
2208 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2209 (modest_connection_specific_smtp_edit_window_init):
2210 Use the correct (UI spec) port min/max, and use horizontal separators,
2213 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2215 * src/maemo/easysetup/modest-easysetup-wizard.c:
2216 (set_default_custom_servernames):
2217 * src/maemo/modest-account-settings-dialog.c:
2218 (create_page_incoming), (on_combo_outgoing_security_changed),
2219 (on_combo_incoming_security_changed), (create_page_outgoing),
2220 (modest_account_settings_dialog_set_account_name),
2221 (save_configuration):
2222 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2223 (on_combo_security_changed),
2224 (modest_connection_specific_smtp_edit_window_init),
2225 (modest_connection_specific_smtp_edit_window_set_connection),
2226 (modest_connection_specific_smtp_edit_window_get_settings):
2227 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2230 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2233 * src/maemo/easysetup/modest-easysetup-wizard.c:
2234 (create_page_custom_outgoing), (create_page_complete_custom):
2235 * src/maemo/modest-account-settings-dialog.c:
2236 (create_page_user_details), (create_page_outgoing):
2237 * src/maemo/modest-account-view-window.c: (button_box_new):
2238 Use changed logical IDs as per the most recent UI spec:
2239 mcen_bd_emailsetup_edit -> mcen_bd_edit
2240 mcen_bd_emailsetup_delete -> mcen_bd_delete
2241 mcen_bd_emailsetup_close -> mcen_bd_close
2243 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2247 * src/dbus_api/Makefile.am:
2248 * src/dbus_api/modest-dbus-callbacks.c:
2249 * src/dbus_api/modest-dbus-callbacks.h:
2250 * src/maemo/modest-platform.c: (modest_platform_init):
2251 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2253 * tests/Makefile.am:
2254 * tests/dbus_api/Makefile.am:
2255 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2257 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2259 * src/maemo/modest-account-settings-dialog.c:
2260 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2261 Removed unnecessary includes.
2263 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2265 * src/maemo/easysetup/modest-easysetup-wizard.c:
2266 * src/maemo/modest-account-settings-dialog.c:
2267 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2268 * src/widgets/Makefile.am:
2269 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2270 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2271 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2272 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2273 * src/widgets/modest-secureauth-combo-box.c:
2274 * src/widgets/modest-secureauth-combo-box.h:
2275 * src/widgets/modest-serversecurity-combo-box.c:
2276 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2277 made the GObject names more consistent with the rest of the Modest code.
2279 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2281 * src/maemo/easysetup/Makefile.am:
2282 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2283 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2284 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2285 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2286 * src/maemo/easysetup/modest-easysetup-wizard.c:
2287 * src/maemo/easysetup/modest-validating-entry.c:
2288 * src/maemo/easysetup/modest-validating-entry.h:
2289 * src/maemo/modest-account-settings-dialog.c:
2290 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2291 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2292 widgets/ because they are used outside of easysetup too. After checking in,
2293 svn will allow me to rename them too.
2295 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2297 * src/gnome/modest-msg-edit-window.c:
2298 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2299 linker error, to fix the build on the GNOME platform.
2300 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2301 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2302 ifdefed out to avoid a warning.
2304 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2306 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2307 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2308 some alternative for GTK+ 2.6.
2310 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2312 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2314 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2315 specified for EmailAccountsDialog in UI spec.
2317 * src/maemo/easysetup/modest-easysetup-wizard.c:
2318 * src/maemo/easysetup/modest-easysetup-wizard.h:
2319 * src/maemo/modest-account-settings-dialog.c:
2320 * src/maemo/modest-account-settings-dialog.h:
2321 Reuse a member window widget for the connection-specific SMTP server accounts,
2322 so we can tell it to create/save the accounts only if we actually save changes.
2324 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2325 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2326 (modest_connection_specific_smtp_edit_window_get_settings):
2327 Return a struct instance for temporarily remembering the entered data.
2329 * src/maemo/modest-connection-specific-smtp-window.h:
2330 * src/maemo/modest-connection-specific-smtp-window.c:
2331 (modest_connection_specific_smtp_window_finalize),
2332 (modest_connection_specific_smtp_window_fill_with_connections),
2334 (modest_connection_specific_smtp_window_save_server_accounts),
2335 (update_model_server_names): Do not actually save data until asked,
2336 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2338 (on_selection_changed),
2339 (modest_connection_specific_smtp_window_init): Disable the edit
2340 button when nothing is selected.
2342 * src/modest-account-mgr-helpers.c:
2343 * src/modest-account-mgr-helpers.h:
2344 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2347 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2349 * src/modest-account-mgr-helpers.h:
2350 * src/modest-account-mgr-helpers.c:
2351 (modest_account_mgr_get_unused_account_name),
2352 (modest_account_mgr_get_unused_account_display_name): Added these
2353 utility functions, to avoid code duplication.
2355 * src/maemo/easysetup/modest-easysetup-wizard.c:
2356 (create_page_account_details), (create_account):
2357 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2358 (on_combo_security_changed),
2359 (modest_connection_specific_smtp_edit_window_init),
2360 (modest_connection_specific_smtp_edit_window_save_settings):
2361 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2362 * src/maemo/modest-connection-specific-smtp-window.c:
2363 (modest_connection_specific_smtp_window_finalize),
2364 (modest_connection_specific_smtp_window_fill_with_connections),
2365 (on_button_edit), (modest_connection_specific_smtp_window_init):
2366 * src/maemo/modest-connection-specific-smtp-window.h:
2367 Implementing saving of connection-specific server accounts.
2369 But I need to refactor this so we can save the data for each
2370 possible connection-specific account and only actually create the server accounts
2371 when the easysetup finished, or the OK button is pressed on the account settings
2374 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2376 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2377 (on_combo_security_changed):
2378 (modest_connection_specific_smtp_edit_window_init):
2379 Auto-fill the port number as in the account settings.
2381 (modest_connection_specific_smtp_edit_window_set_connection):
2382 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2383 * src/maemo/modest-connection-specific-smtp-window.c:
2384 (fill_with_connections), (on_button_edit),
2385 (modest_connection_specific_smtp_window_init):
2386 Turn the edit window into a dialog to simplify the code, and
2387 set a WM hint as in a GtkDialog, because only a popup can be on top of
2388 another window in Maemo, and popups usually have no WM decoration.
2390 * src/modest-defs.h:
2391 * src/modest-account-mgr-helpers.c:
2392 (modest_account_mgr_set_connection_specific_smtp),
2393 (modest_account_mgr_remove_connection_specific_smtp),
2394 (modest_account_mgr_get_connection_specific_smtp):
2395 * src/modest-account-mgr-helpers.h: Some functions to write the
2396 connection-specific SMTP server information. Not yet used.
2399 * src/widgets/modest-folder-view.c: (text_cell_data):
2400 Fix a warning about an uninitialized variable.
2401 (on_configuration_key_changed): Put an #ifdef around the use
2402 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2404 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2406 * src/maemo/modest-account-settings-dialog.h:
2407 * src/maemo/modest-account-settings-dialog.c:
2408 Added connect_for_modified() utility function to mark the new modified boolean.
2410 (create_page_account_details), (create_page_user_details),
2411 (create_page_incoming), (create_page_outgoing), (on_response),
2412 (modest_account_settings_dialog_init),
2413 (modest_account_settings_dialog_set_account_name):
2414 Only warn about unsaved changes when there are actually unsaved changes.
2416 * src/modest-account-mgr-helpers.c:
2417 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2418 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2419 to get the data from there in future.
2421 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2423 * src/modest-defs.h:
2425 * src/modest-account-mgr-helpers.h:
2426 * src/modest-account-mgr-helpers.c:
2427 Store the security account setting in a single conf key instead of using
2428 the options list, so that the list is left for just the to-be-removed camel hack,
2429 and because gconf_client_set_list() is failing for some reason.
2431 * src/modest-account-mgr.c:
2432 (modest_account_mgr_add_server_account):
2433 * src/maemo/modest-account-settings-dialog.c:
2434 (modest_account_settings_dialog_set_account_name),
2435 (save_configuration): Use the renamed functions.
2438 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2440 * src/widgets/Makefile.am:
2441 * src/widgets/modest-limit-retrieve-combo-box.c:
2442 * src/widgets/modest-limit-retrieve-combo-box.h:
2443 * src/widgets/modest-retrieve-combo-box.c:
2444 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2445 the account settings dialog.
2447 * src/modest-defs.h:
2448 * src/modest-account-mgr-helpers.h:
2449 * src/modest-account-mgr-helpers.c:
2450 (modest_server_account_get_option_secure_auth),
2451 (modest_server_account_set_option_secure_auth):
2452 * src/modest-account-mgr.c:
2453 (modest_account_mgr_add_server_account):
2454 Use the existing AUTH_MECH conf key for the secure-auth setting,
2455 instead of putting it in the list options, because this was actually used already.
2457 * src/maemo/modest-account-settings-dialog.c:
2458 (create_page_account_details),
2459 (modest_account_settings_dialog_set_account_name),
2460 (save_configuration):
2461 * src/maemo/modest-account-settings-dialog.h:
2462 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2463 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2465 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2467 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2468 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2469 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2471 * src/modest-defs.h:
2472 * src/maemo/modest-account-settings-dialog.c:
2473 (create_page_incoming), (on_combo_outgoing_security_changed),
2474 (on_combo_incoming_security_changed), (create_page_outgoing),
2475 (modest_account_settings_dialog_set_account_name),
2476 (save_configuration): Load/Save the port number, and change it when the
2477 security combo changes, to suitable defaults.
2479 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2481 * src/modest-account-mgr.c:
2482 (modest_account_mgr_add_server_account): Set the security and secure-auth
2483 options, and add a comment saying that the other camel-specific options should be
2486 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2488 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2490 * src/modest-tny-account-store.c: (account_list_free),
2491 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2492 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2495 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2497 * src/modest-protocol-info.c:
2498 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2499 is required by our UI spec. Maybe something in our implementation will use this eventually.
2500 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2501 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2502 instead of the previous 0 placeholder.
2504 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2505 secure-auth settings.
2506 * src/modest-account-mgr-helpers.h:
2507 * src/modest-account-mgr-helpers.c:
2508 (modest_server_account_data_get_option_secure_auth),
2509 (modest_server_account_set_option_secure_auth),
2510 (modest_server_account_data_get_option_security),
2511 (modest_server_account_set_option_security): Added this API for getting and setting the security
2512 and secure-auth settings.
2514 * src/maemo/modest-account-settings-dialog.h:
2515 * src/maemo/modest-account-settings-dialog.c:
2516 (modest_account_settings_dialog_finalize), (check_data),
2517 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2518 about changing titles.
2519 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2520 (save_configuration): Save the security and secure-auth settings.
2522 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2523 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2525 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2527 * src/modest-defs.h:
2528 * src/modest-account-mgr.c:
2529 (modest_account_mgr_add_server_account):
2530 Added and used defines for the options key and value pair strings,
2531 that are used so far, though they do not seem to correspond to anything in our
2532 UI specs or ModestProtocol enum.
2534 * src/modest-account-mgr-helpers.h:
2535 * src/modest-account-mgr-helpers.c:
2536 (compare_option_strings_for_name),
2537 (modest_server_account_data_get_option_value),
2538 (modest_server_account_data_get_option_bool),
2539 (modest_account_mgr_get_server_account_option):
2540 Added helper functions for parsing the options GSList.
2542 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2544 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2545 display name is based on the supplied account name.
2546 * src/modest-account-mgr.c:
2547 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2548 with an inefficient, but good-enough, implementation.
2550 * src/maemo/easysetup/modest-easysetup-wizard.c:
2551 (create_page_account_details), (on_before_next), (create_account):
2552 Check for existing display names rather than (non-user-visible) account names, and just
2553 create and set a unique account name at the end.
2555 * src/maemo/modest-account-settings-dialog.c:
2556 (modest_account_settings_dialog_init),
2557 (modest_account_settings_dialog_set_account_name),
2558 (create_page_incoming): Show the display name, instead of the account name.
2559 (on_response): Do some (not all) extra checks, as in the UI spec.
2560 (save_configuration): Save the display name if it was changed.
2562 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2564 * po/en_GB.po: Added needed logical ID and translation.
2565 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2566 (init_view): Made the is-default column clicking work.
2568 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2571 * src/maemo/easysetup/Makefile.am:
2572 * src/maemo/easysetup/modest-easysetup-wizard.c:
2573 (modest_easysetup_wizard_dialog_init):
2574 * src/maemo/easysetup/provider-data-test.keyfile:
2575 * src/maemo/easysetup/provider-data.keyfile:
2576 Moved the provider data file to the new modest-providers-data package and used it from there.
2578 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2580 * src/modest-local-folder-info.c:
2581 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2582 N_() was already used on the static strings, but this just marks it for translation without
2583 using the translation.
2585 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2587 * src/maemo/modest-account-settings-dialog.c:
2588 (create_page_incoming),
2589 (modest_account_settings_dialog_set_account_name):
2590 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2591 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2592 I will do this if nobody else gets there first.
2594 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2596 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2597 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2598 save the security stuff.
2600 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2602 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2603 Set the email address and user fullname, which I now see must be
2606 * src/maemo/modest-account-settings-dialog.h:
2607 * src/maemo/modest-account-settings-dialog.c:
2609 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2610 leave-on-server and authentication.
2611 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2614 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2617 * src/maemo/modest-account-settings-dialog.c:
2618 * src/maemo/modest-account-settings-dialog.h:
2619 Most (but not all) of the widgets are now present as specified by the UI spec.
2620 No changes are yet saved, and some details are not properly shown yet.
2622 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2624 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2626 * src/maemo/Makefile.am:
2627 * src/maemo/modest-account-settings-dialog.c:
2628 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2629 an existing account. Doesn't do much yet.
2631 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2632 Open the accounts settings dialog when Edit is clicked.
2634 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2636 * src/maemo/easysetup/Makefile.am:
2637 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2639 * src/maemo/easysetup/modest-easysetup-wizard.c:
2640 (modest_easysetup_wizard_dialog_init):
2641 Try to get the source directory from the build system,
2642 instead of hard-coding "./" into the source code, when opening our local
2643 copies of the configuration files.
2644 But this still fails when opening the wizard from the Accounts window,
2645 maybe because the working directory seems to change at runtime.
2646 So the wizard will fail the second time unless you copy the files into their
2647 proper locations - see the stdout warnings for the paths.
2649 (create_page_account_details),(on_before_next):
2650 Check for existing non-server accounts instead of server accounts,
2651 so the default account name is useful again, and to prevent trying to
2654 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2655 Show the wizard when New is clicked.
2657 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2658 (init_view): Show the column headers, and show the columns that are
2659 specified in the UI specs. However, something in Maemo's GTK+ prevents
2660 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2661 change the default account. This is despite unsetting the special properties.
2663 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2665 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2666 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2667 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2668 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2669 to make that clearer.
2670 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2672 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2674 * src/maemo/modest-account-view-window.c:
2675 (modest_account_view_window_init),
2676 (modest_account_view_window_new):
2677 Use the same buttons as specified in the
2678 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2679 the existing widgets, which never had a chance of working.
2680 Put the ModestAccountView treeview in a scrolled window.
2681 Do not repeat the initialization in both _init() and _new().
2683 * src/widgets/modest-account-view.c: (update_account_view):
2684 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2685 this widget and window shows no accounts.
2687 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2689 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2691 * src/maemo/easysetup/modest-easysetup-wizard.c:
2692 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2693 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2694 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2697 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2698 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2699 accounts exist yet, as in the UI spec.
2701 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2703 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2705 * src/maemo/Makefile.am:
2706 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2707 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2708 New window for editing connection-specific smtp details.
2709 Not fully implemented.
2711 * src/maemo/modest-connection-specific-smtp-window.c:
2712 (modest_connection_specific_smtp_window_finalize) :
2713 unref the tree model.
2714 (on_button_edit): Show the edit window.
2716 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2718 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2721 * src/maemo/Makefile.am:
2722 * src/maemo/modest-connection-specific-smtp-window.c:
2723 * src/maemo/modest-connection-specific-smtp-window.h:
2724 New window for showing the list of connections, for connection-specific
2725 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2726 * src/maemo/easysetup/modest-easysetup-wizard.c:
2727 (create_page_custom_outgoing): Show the new window when the button is clicked.
2729 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2731 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2732 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2733 * src/maemo/modest-msg-edit-window.c:
2734 (modest_msg_edit_window_insert_image):
2735 * src/modest-conf.c: (modest_conf_key_escape):
2736 * src/modest-mail-operation.c:
2737 (modest_mail_operation_send_new_mail):
2738 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2739 (modest_ui_actions_on_new_account):
2740 * src/widgets/modest-attachment-view.c: (update_filename_request):
2741 * src/widgets/modest-mail-header-view.c:
2742 Corrected warnings that were breaking the build, by commenting out unused variables,
2743 and a function, and by including a header.
2745 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2747 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2748 so we can #ifdef around platform-specific code when necessary.
2749 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2750 to allow this to build for the GNOME platform too.
2752 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2754 * src/maemo/easysetup/modest-easysetup-wizard.c:
2755 Added util_increment_name() and used it in create_page_account_details()
2756 to make sure that the default account name is always a new name.
2758 (modest_easysetup_wizard_dialog_init),
2759 (set_default_custom_servernames): Some minor memory management fixes.
2761 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2765 * src/modest-runtime.c: (init_i18n): Restored the translation
2766 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2767 are defined in config.h, and the translations are installed.
2769 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2770 is defined for translation.
2772 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2774 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2776 * src/maemo/easysetup/modest-easysetup-wizard.c:
2777 (modest_easysetup_wizard_dialog_init):
2778 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2779 Use realistic paths (though they should use $prefix generically) to the
2780 mcc_mapping and provider-data.keyfile files which might work when they
2781 are installed by the future version of the operator-wizard package,
2782 and then fallback to paths in our source code, with an explanatory
2785 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2789 * src/maemo/Makefile.am:
2790 * src/maemo/easysetup/: Added files from the previously-exernal
2791 osso-modest-easysetup.
2792 * src/maemo/modest-main-window-ui.h:
2793 * src/modest-ui-actions.c:
2794 * src/modest-ui-actions.h:
2795 Added modest_ui_actions_on_new_account() as a signal handler for the
2796 New Account menu item. It shows the easysetup wizard.
2797 * po/en_GB.po: Added additional needed logical IDs and translations.
2799 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2800 Apparently ChangeLog is not used for some vague Nokia legal reasons.