1 2007-06-14 Johannes Schmid <johannes.schmid@openismus.com>
3 * src/maemo/modest-connection-specific-smtp-edit-window.c:
4 (on_change), (on_combo_security_changed),
5 (modest_connection_specific_smtp_edit_window_init),
6 (modest_connection_specific_smtp_edit_window_set_connection),
7 (modest_connection_specific_smtp_edit_window_is_dirty):
8 * src/maemo/modest-connection-specific-smtp-edit-window.h:
9 * src/maemo/modest-connection-specific-smtp-window.c:
12 Show an comfirmation dialog for the smpt-edit-window if there are
13 unsaved changes and the user hits cancel.
14 (projects.maemo.org but NB#60479
16 2007-06-14 Armin Burgmeier <armin@openismus.com>
18 * src/maemo/easysetup/modest-easysetup-wizard.c:
19 * src/maemo/modest-account-settings-dialog.c: Show "invalid email
20 address" info in banner instead of node, and select all the text as
21 per UI spec. This fixes projects.maemo.org bug NB#60550.
23 2007-06-14 set REAL_NAME environment variable <set EMAIL_ADDRESS environment variable>
25 reviewed by: <delete if not using a buddy>
27 * src/maemo/modest-main-window.c: (_on_msg_count_changed):
28 * src/modest-ui-actions.c: (folder_refreshed_cb):
30 2007-06-14 Murray Cumming <murrayc@murrayc.com>
32 * src/widgets/modest-folder-view.c: (filter_row):
33 Explictly filter out the per-account outbox accounts. I don't know why
34 these only sometimes show up, but now they should never show up in the UI.
35 This should fix projects.maemo.org bug NB#60160.
37 2007-06-14 Murray Cumming <murrayc@murrayc.com>
39 * src/maemo/modest-main-window.c: (set_toolbar_mode): Prevent a warning
40 when the toolbar does not exist yet.
41 * src/modest-widget-memory.c: (save_settings_header_view):
42 Added g_warnings() to help us to discover when we are trying to set
43 an empty columns list in gconf.
45 2007-06-14 Murray Cumming <murrayc@murrayc.com>
49 Added modest_init_get_default_header_view_column_ids().
51 * src/modest-widget-memory.c: (restore_settings_header_view):
52 Use the new function to get defaults, if the gconf key is empty,
53 instead of not creating any columns. This seems to fix the
54 empty right-hand pane problems.
56 * src/widgets/modest-header-view.h: Improved documentation.
58 2007-06-13 Murray Cumming <murrayc@murrayc.com>
60 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
61 Revert the use of the display name as the account name, because this
62 is generally wrong and would break the code that follows.
64 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
66 * src/maemo/easysetup/modest-easysetup-wizard.c:
67 (check_for_supported_auth_methods), (on_before_next),
70 More correct fix for projects.maemo.org bug NB# 58991
71 Do not longer accept AUTH_PASSWORD as secure method and choose
72 correct method when creating the account.
74 2007-06-13 Johannes Schmid <johannes.schmid@openismus.com>
76 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
77 Fixed projects.maemo.org bug NB# 58991
79 2007-06-13 Murray Cumming <murrayc@murrayc.com>
81 * src/modest-init.c: (modest_init_init_core),
82 (modest_init_local_folders): Fixed compilation errors.
84 2007-06-13 Murray Cumming <murrayc@murrayc.com>
86 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
87 Remove unnecessary lib/include, though it is good in principle when needed.
89 * src/modest-init.c: (modest_init_one_local_folder),
90 (modest_init_local_folders):
91 * src/modest-init.h: Initialize the .modest library for memory cards,
92 instead of just doing nothing for them. This should allow us to create
93 folders there, fixing projects.maemo.org bug NB#59297.
95 2007-06-13 Murray Cumming <murrayc@murrayc.com>
97 * libmodest-dbus-client/libmodest-dbus-client.c:
98 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
99 (libmodest_dbus_client_compose_mail),
100 (libmodest_dbus_client_open_message),
101 (libmodest_dbus_client_send_and_receive),
102 (libmodest_dbus_client_open_default_inbox): Improved debug messages.
104 * src/dbus_api/modest-dbus-callbacks.c: (find_message_by_url),
105 (on_idle_open_message), (modest_dbus_req_handler),
106 (search_result_to_message), (modest_dbus_req_filter):
107 * src/modest-search.c: (add_hit), (modest_search_folder),
108 (modest_search_all_accounts): Improved debug messages.
110 * tests/dbus_api/test_open_message.c: (main): Improved comments.
112 * src/modest-tny-account-store.c:
113 (modest_tny_account_store_get_tny_account_by): Initialize a variable to
116 2007-06-13 Murray Cumming <murrayc@murrayc.com>
119 2007-06-12 Murray Cumming <murrayc@murrayc.com>
121 * src/modest-tny-account-store.c: (get_server_accounts):
122 Call modest_tny_local_folders_account_add_merged_outbox_folders()
123 even when there are no accounts, so that the Outbox folder is always
124 visible. This fixes projects.maemo.org bug NB#60158.
126 2007-06-12 Murray Cumming <murrayc@murrayc.com>
128 * src/maemo/modest-main-window.c: (create_details_widget):
129 Use the mcen_va_never logical ID.
131 2007-06-12 Murray Cumming <murrayc@murrayc.com>
133 * src/dbus_api/modest-dbus-api.h:
134 * src/dbus_api/modest-dbus-callbacks.c:
135 (on_idle_open_default_inbox), (on_open_default_inbox),
136 (modest_dbus_req_handler):
137 Added a new OpenDefaultInbox method.
139 * libmodest-dbus-client/libmodest-dbus-client.h:
140 * libmodest-dbus-client/libmodest-dbus-client.c:
141 Added libmodest_dbus_client_open_default_inbox() to call the new
142 dbus method. This should be useful to projects.maemo.org bug NB#57214,
143 though it should maybe be used by a new osso-email-interface function.
145 * tests/dbus_api/Makefile.am:
146 * tests/dbus_api/test_open_default_inbox.c: Added a test for the new
149 2007-06-12 Murray Cumming <murrayc@murrayc.com>
151 * src/modest-account-mgr.c: (on_key_change): Append to the list, not to
152 NULL, so that the signals get all the keys. This should not actually
153 change any behaviour because we currently update everything when anything
156 2007-06-12 Murray Cumming <murrayc@murrayc.com>
158 * src/widgets/modest-folder-view.c: (text_cell_data),
159 (icon_cell_data), (filter_row), (on_selection_changed), (cmp_rows),
160 (find_inbox_iter): If tinymail tells us that the folder is
161 a non-specific TNY_FOLDER_TYPE_NORMAL then do an extra check on the name.
162 This causes the inbox to be selected at startup, fixing part of
163 projects.maemo.org bug NB#56305.
165 * src/modest-ui-dimming-rules.c:
166 (modest_ui_dimming_rules_on_tools_smtp_servers):
167 * src/modest-ui-dimming-rules.h: Added a callback function to dim
168 the SMTP servers menu item.
169 * src/maemo/modest-main-window-ui-dimming.h: Used the function, so
170 that the SMTP Servers menu item is dimmed when there are no accounts,
171 as a future version of the UI spec will require. This fixes
172 projects.maemo.org bug NB#56305.
174 2007-06-11 Johannes Schmid <johannes.schmid@openismus.com>
176 * src/maemo/modest-maemo-utils.c:
177 (modest_maemo_utils_get_supported_secure_authentication_methods):
178 Added label to dialog instead of unreadable title
180 * src/maemo/modest-main-window.c: (sync_accounts_cb),
181 (modest_main_window_new):
182 Fixed projects.maemo.org bug NB#58576 by moving previous fix out of
185 * src/modest-account-mgr.c: (modest_account_mgr_has_accounts):
186 * src/modest-account-mgr.h:
187 Added method to avoid code duplication
189 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
190 (modest_ui_actions_on_send_receive):
191 Use modest_account_mgr_has_accounts
193 2007-06-11 Murray Cumming <murrayc@murrayc.com>
195 * src/maemo/easysetup/modest-presets.c:
196 (modest_presets_get_info_server_security): Do not report secure auth
198 * src/modest-protocol-info.c: Use the defines for the gconf key names
199 for secure authentication. This was not working because we were writing
200 Password and reading password, and the check was case sensitive.
201 With this, gmail now works for receiving and sending when created via
204 2007-06-11 Murray Cumming <murrayc@murrayc.com>
206 * src/maemo/easysetup/modest-presets.c:
207 (modest_presets_get_info_server_security): Correct the key name for
208 SecureSmtp, because it seems to be case-sensitive.
209 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
210 Do not try to get the 0th notebook page if there are 0 pages, to
213 2007-06-11 Murray Cumming <murrayc@murrayc.com>
215 * src/maemo/modest-platform.c: (modest_platform_on_new_msg):
216 Prevent use of the new notification feature for now, because it currently
217 shows one dialog for each new email, which is annoying.
219 2007-06-11 Murray Cumming <murrayc@murrayc.com>
221 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
222 (easysetup_provider_combo_box_fill): Ask for the providers for mmc=0
223 when no country was selected, so that we show the global ones.
224 * src/maemo/easysetup/modest-presets.c:
225 (modest_presets_get_providers): Return only the global providers, not
226 all providers when mmc=0 was requested.
228 2007-06-11 Murray Cumming <murrayc@murrayc.com>
230 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
231 (easysetup_provider_combo_box_fill): Remove debug code that showed the
232 provider ID in the combo.
234 * src/maemo/easysetup/modest-wizard-dialog.c: (create_title):
235 Do not show the page numbers, because it would be confusing when we add
236 the 2 extra pages for the custom setup, when the user chooses the "Other"
237 provider. This fixes projects.maemo.org bug NB#59028
239 * src/modest-init.c: (modest_init_init_core),
240 (modest_init_local_folders):
242 * src/modest-tny-account.c:
243 (modest_tny_account_new_for_local_folders): Do not create default folders
244 for the memory card. This should fix projects.maemo.org bug NB#59328.
246 2007-06-11 Murray Cumming <murrayc@murrayc.com>
248 * src/modest-account-mgr.c: (modest_account_mgr_finalize):
249 Free the changed_conf_keys string items. They are already freed in the
250 idle handler if that runs first.
252 2007-06-11 Murray Cumming <murrayc@murrayc.com>
254 * src/modest-ui-actions.c:
255 (modest_ui_actions_on_password_requested): Check that the server name
256 is not NULL, because I just saw a password dialog with (null) as the
259 * src/modest-tny-folder.[h|c]: Added
260 modest_tny_folder_is_memory_card_folder().
261 * src/modest-ui-dimming-rules.c:
262 (modest_ui_dimming_rules_on_new_folder): Do not dim the new folder context
263 menu item for memory cards, as per the UI spec (section 7.4). This should
264 fix projects.maemo.org bug NB#59297.
266 2007-06-10 Johannes Schmid <johannes.schmid@openismus.com>
268 * src/maemo/modest-main-window.c: (sync_accounts_cb):
269 Fixed projects.maemo.org bug NB#58576 (not yet activated as there
270 is another problem with the code, see Murray's comment at line 772)
272 2007-06-08 Murray Cumming <murrayc@murrayc.com>
274 * src/maemo/easysetup/modest-easysetup-country-combo-box.h:
275 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
276 (on_model_foreach_release), (easysetup_country_combo_box_finalize),
277 (load_from_file), (easysetup_country_combo_box_init),
278 (easysetup_country_combo_box_get_active_country_ids),
279 (on_model_foreach_select_id): Store a GSList* of IDs in the model row,
280 instead of just one ID, to avoid duplicate country names in the UI.
282 * src/maemo/easysetup/modest-easysetup-provider-combo-box.h:
283 * src/maemo/easysetup/modest-easysetup-provider-combo-box.c:
284 (easysetup_provider_combo_box_fill): Adapt to use a list rather than
285 a single ID, avoiding duplicate providers.
286 * src/maemo/easysetup/modest-easysetup-wizard.c:
287 (on_combo_account_country): Adapt to use a list.
289 2007-06-08 Murray Cumming <murrayc@murrayc.com>
291 * src/modest-account-mgr-priv.h: Added a timeout id and a GSList of
292 keys changed in the last X seconds.
294 * src/modest-account-mgr.h:
295 * src/modest-account-mgr.c: (on_timeout_notify_changes),
296 (on_key_change), (modest_account_mgr_class_init),
297 (modest_account_mgr_init), (modest_account_mgr_finalize):
298 As the keys are changed, save them in a GSList* and signal that GSList*
299 further every X seconds, to batch changes, to allow us to do just one
300 update per batch. This should fix bug projects.maemo.org bug NB#56472 and
301 bug NB#56941 and other (UI-blocking) delays when changing account settings.
303 * src/modest-tny-account-store.c: (on_account_changed): Adapted to
304 changed signal signature.
306 * src/modest-conf.c: (modest_conf_set_list),
307 (modest_conf_on_change): Reenable notification.
309 (modest_conf_maemo_fake_on_change): Comment out the hack that
310 notified immediately instead of asynchronously.
312 * src/widgets/modest-account-view.h:
313 * src/widgets/modest-account-view.c:
314 (update_account_view): Select the previously-selected account ID,
315 if possible. This fixes projects.maemo.org bug NB#56933.
317 (on_account_changed), (on_account_removed),
318 (modest_account_view_select_account):
320 Remove the block/unblock functions
321 because they were not useful.
323 * src/maemo/modest-account-view-window.c:
324 (on_delete_button_clicked), (on_edit_button_clicked),
325 (on_new_button_clicked): Remove the use of the non-working block/unblock.
327 2007-06-08 Murray Cumming <murrayc@murrayc.com>
329 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
330 Improve the error dialog to show Incorrect Account Settings, which seems
331 clearer, and say that the internal error message (to be removed from the
332 dialog later) is often misleading.
333 I have confirmed that projects.maemo.org bug NB#58543 is no longer a problem.
335 * src/modest-tny-account.c:
336 (modest_tny_account_new_from_server_account): Uncomment the printf of the
337 URL because this is so useful for debugging on the device.
339 * src/widgets/modest-serversecurity-combo-box.c:
340 (modest_serversecurity_combo_box_fill): Correct a logical ID.
342 2007-06-08 Murray Cumming <murrayc@murrayc.com>
344 * src/modest-mail-operation.c:
345 (modest_mail_operation_send_new_mail):
346 Added a comment about a nasty but apparently harmless message. Details
347 added to the wiki g_warnings() page.
349 2007-06-08 Murray Cumming <murrayc@murrayc.com>
351 * src/modest-tny-send-queue.c: (modest_tny_send_queue_add),
352 (modest_tny_send_queue_class_init):
353 Do not use the priv struct because it is empty, to avoid g_warnings
354 about a non-existant priv struct.
356 * src/modest-tny-account-store.c:
357 (modest_tny_account_store_get_server_account),
358 (modest_tny_account_store_get_transport_account_for_open_connection
359 ): Do not try to get transport server accounts for local folders,
360 because they don't have any. This avoids a g_warning().
362 * src/maemo/modest-main-window.c:
363 (modest_main_window_notify_send_receive_initied),
364 (on_configuration_key_changed):
365 * src/maemo/modest-msg-edit-window.c: (on_delete_event):
367 * src/modest-mail-operation.c:
368 (modest_mail_operation_update_account):
369 * src/modest-tny-account-store.h:
370 * src/modest-tny-account.c:
371 (modest_tny_account_get_special_folder),
372 (modest_tny_account_new_for_local_folders),
373 (modest_tny_account_new_for_per_account_local_outbox_folder):
374 * src/modest-tny-folder.c: (modest_tny_folder_is_local_folder):
375 * src/modest-tny-local-folders-account.c:
376 (add_account_folders_to_merged_folder):
377 * src/modest-ui-actions.c: (modest_ui_actions_on_new_msg),
378 (reply_forward_cb), (modest_ui_actions_on_save_to_drafts),
379 (modest_ui_actions_on_send):
380 * src/widgets/modest-folder-view.c: (update_model):
381 Rename MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID to
382 MODEST_LOCAL_FOLDERS_ACCOUNT_ID and rename
383 modest_tny_account_store_get_tny_account_by_account() to
384 modest_tny_account_store_get_server_account() to make the code clearer.
386 2007-06-07 Marcus Bauer <marcusb@openismus.com>
388 * src/dbus_api/modest-dbus-api.h:
389 changed MODEST_DBUS_NAME in order to get dbus auto-activation to work
390 * src/maemo/modest-msg-edit-window.c:
391 (modest_msg_edit_window_attach_file_noninteractive):
392 added g_warning in case the file to be attached does not exist
393 * tests/dbus_api/test_compose_mail.c: (main):
394 removed obsolete comment, added generic files as test case
396 2007-06-07 Murray Cumming <murrayc@murrayc.com>
398 * src/modest-tny-account-store.c: (get_server_accounts):
399 Create the local folders account only once, not once for each outbox, and
400 not only when there are some outboxes.
402 2007-06-07 Murray Cumming <murrayc@murrayc.com>
404 * src/widgets/modest-folder-view.c: (update_model): Comment out some
405 code that is causing a crash at startup. Sergio says that he is fixing this.
407 2007-06-07 Johannes Schmid <johannes.schmid@openismus.com>
409 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
410 * src/maemo/modest-account-settings-dialog.c:
411 (create_page_outgoing),
412 (modest_account_settings_dialog_set_account_name),
413 (save_configuration):
414 - Fixed handling of the "Use secure authentication" toggle to comply with
415 the ui specification. See also projects.maemo.org bug NB#58400
417 - Restore the Secure connection setting combo correctly when loading
420 * src/maemo/modest-maemo-utils.c:
421 (on_camel_account_get_supported_secure_authentication),
422 (modest_maemo_utils_get_supported_secure_authentication_methods):
423 Fixed a crasher if operation is canceled
425 * src/modest-protocol-info.c: (modest_protocol_info_is_secure),
426 (modest_protocol_info_auth_is_secure):
427 * src/modest-protocol-info.h:
429 Added two new methods to determine if a protocol/auth method is secure/encrypted in
430 the sense of the "Use secure authentication" toggle.
432 2007-06-07 Murray Cumming <murrayc@murrayc.com>
434 * src/modest-tny-account-store.h:
435 * src/modest-tny-account-store.c:
436 Added modest_tny_account_store_get_local_folders_account().
438 * src/modest-tny-folder.h:
439 * src/modest-tny-folder.c:
440 (modest_tny_folder_get_account):
441 Added this replacement for tny_folder_get_account() which returns
442 the local-folders account for TnyMergeFolders, to avoid the
443 warning about the unimplemented get_account_func() vfunc().
445 (modest_tny_folder_get_rules),
446 * src/modest-ui-actions.c:
447 (modest_ui_actions_on_folder_selection_changed):
448 * src/modest-mail-operation.c:
449 (modest_mail_operation_remove_folder),
450 (modest_mail_operation_xfer_folder),
451 (modest_mail_operation_rename_folder),
452 (modest_mail_operation_get_msg),
453 (modest_mail_operation_get_msgs_full),
454 (modest_mail_operation_remove_msg),
455 (modest_mail_operation_xfer_msgs),
456 (modest_mail_operation_refresh_folder):
457 Use modest_tny_folder_get_account() instead of tny_folder_get_account().
459 2007-06-07 Murray Cumming <murrayc@murrayc.com>
461 * src/modest-account-mgr-helpers.c: (get_security_for_conf_string),
462 (modest_server_account_set_security):
463 * src/modest-defs.h: Add comments explaining that our
464 UI spec means TLS when it says Normal, so these do not look like errors.
466 * src/modest-tny-account.c:
467 (modest_tny_account_new_from_server_account): Use the new tinymail
468 'wrapped' option for regular SSL, and use the new tinymail 'tls' option
469 for TLS. This should fix projects.maemo.org bug NB#58460.
471 2007-06-06 Murray Cumming <murrayc@murrayc.com>
473 * src/maemo/easysetup/modest-easysetup-wizard.c:
474 (create_account): Correct the position of the gconf sanity check warning.
475 (on_button_edit_advanced_settings): Show the dialog immediately, instead
476 of using the g_idle_add() hack, because this does not seem to be necessary
477 on osso 1.1. It might even work on Maemo Bora if the problems were actually
478 caused by something other than maemo's gconf.
479 This fixes projects.maemo.org bug #59022.
481 2007-06-06 Murray Cumming <murrayc@murrayc.com>
483 * src/modest-account-mgr-helpers.c:
484 (modest_account_mgr_get_default_account): Do not check that the account
485 exists if there is no default account (NULL), to fix a runtime warning.
487 2007-06-06 Murray Cumming <murrayc@murrayc.com>
489 * src/widgets/modest-folder-view.c: (update_model):
490 Do not unref the treemodel before we have finished with it.
491 This prevents a valgrind warning and an occasional crash at startup.
493 2007-06-06 Marcus Bauer <marcusb@openismus.com>
495 * libmodest-dbus-client/libmodest-dbus-client.h:
496 added libmodest_dbus_client_compose_mail()
497 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
499 added functions needed for SendAsMail() functionality
500 * src/maemo/modest-msg-edit-window.c:
501 (modest_msg_edit_window_attach_file_noninteractive):
502 non interactively attaching files to message edit window
503 * src/widgets/modest-msg-edit-window.h:
504 * tests/dbus_api/Makefile.am:
505 added test_compose_mail.c
506 * tests/dbus_api/test_compose_mail.c: (main):
508 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
510 * src/modest-account-view.c:
511 Fixed bug projects.maemo.org bug NB#59307
513 2007-06-05 Johannes Schmid <johannes.schmid@openismus.com>
515 * src/maemo/easysetup/modest-easysetup-wizard.c:
516 (get_serverport_incoming), (on_before_next), (create_account):
517 * src/maemo/modest-account-settings-dialog.c:
518 (modest_account_settings_dialog_set_account_name):
519 * src/maemo/modest-maemo-utils.c:
520 (on_camel_account_get_supported_secure_authentication_status),
521 (on_camel_account_get_supported_secure_authentication),
522 (on_secure_auth_cancel),
523 (modest_maemo_utils_get_supported_secure_authentication_methods):
525 Implemented security authentication for settings and easysetup.
527 2007-06-05 Murray Cumming <murrayc@murrayc.com>
529 * src/maemo/modest-main-window.c: (create_details_widget):
530 Show the total size for memory card accounts too, instead of showing
531 the name again. Fixes bug projects.maemo.org bug NB#59307.
533 2007-06-05 Murray Cumming <murrayc@murrayc.com>
536 * src/modest-tny-simple-folder-store.c:
537 * src/modest-tny-simple-folder-store.h: Removed.
539 * src/modest-tny-local-folders-account.h
540 * src/modest-tny-local-folders-account.c: Added a derived TnyAccount
541 for the local-folders maildir, with an extra TnyMergedFolder containing
542 the folders of the per-account outbox store accounts.
543 * src/modest-tny-account-store.c: (get_server_accounts):
544 Add the outboxes to the special local folders account after creating it.
546 * src/modest-tny-account.c:
547 (modest_tny_account_new_for_local_folders): Create the derived
548 account when creating the main local-folders account.
550 * src/maemo/modest-main-window.c: (create_details_widget),
551 (modest_main_window_set_contents_style):
552 Adapted to the use of the derived account instead of the folder store.
554 * src/modest-ui-actions.c:
555 (modest_ui_actions_on_folder_selection_changed):
556 * src/modest-ui-dimming-rules.c:
557 (modest_ui_dimming_rules_on_new_folder):
558 * src/widgets/modest-folder-view.c: (text_cell_data),
559 (icon_cell_data), (filter_row), (update_model),
560 (get_cmp_rows_type_pos):
563 * src/modest-tny-send-queue.c: (modest_tny_send_queue_new):
564 Do not get the priv struct, because no priv struct has been set,
565 to avoid a runtime warning.
567 * src/maemo/modest-platform.c: (modest_platform_show_help): Replace
568 #ifelse with #else, to fix a warning, to fix the build.
571 2007-06-05 Christian Kellner <ckellner@openismus.com>
573 * libmodest-dbus-client/libmodest-dbus-client.c:
574 Fix small typo in doc (why do you always see them
575 AFTER committing stuff?)
578 2007-06-05 Christian Kellner <ckellner@openismus.com>
580 * libmodest-dbus-client/libmodest-dbus-client.c:
581 (libmodest_dbus_client_search):
582 Initialize hit list with NULL. Also set folder list
583 to "" if NULL was supplied.
586 2007-06-03 Christian Kellner <ckellner@openismus.com>
588 * libmodest-dbus-client/libmodest-dbus-client.c:
589 (modest_search_hit_list_free):
590 Make it save to call it with NULL.
592 * src/dbus_api/modest-dbus-callbacks.c:
593 * src/modest-search.c:
594 Return full ModestSearchHits as the search result list not TnyHeader
595 since can't be around withouth the correspoding TnyFolder.
597 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
599 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_before_next):
600 Added currently commented code to check for secure auth
602 * src/maemo/modest-account-settings-dialog.c: (on_response),
603 (save_configuration), (show_ok):
604 Fixed projects.maemo.org bugs NB #59248 and #59251
606 * src/maemo/modest-maemo-utils.c:
607 (on_camel_account_get_supported_secure_authentication_status),
608 (on_camel_account_get_supported_secure_authentication),
609 (modest_maemo_utils_get_supported_secure_authentication_methods):
610 * src/maemo/modest-maemo-utils.h:
611 Moved get_supported_secure_authentication() method here to be able
612 to use it from easysetup wizard.
614 * src/modest-pair.c: (on_pair_compare_as_string):
615 Should compare string with first part of pair and not
616 strcmp pairs which will crash.
618 * src/modest-protocol-info.c:
619 (modest_protocol_info_protocol_is_store):
620 * src/modest-protocol-info.h:
621 Added modest_protocol_info_get_auth_protocol_name()
623 2007-06-03 Armin Burgmeier <armin@openismus.com>
625 * src/modest-mail-operation.c:
626 (modest_mail_operation_get_msgs_full): Set priv->account also when
627 only retrieving a single message. This avoids a crash when canceling
630 (modest_mail_operation_notify_end): Do not explicitely remove the
631 operation from the queue but only emit the progress_changed signal.
632 The queue itself listens to that signal to remove the operation when
633 it is finished. This reduces coupling and removes a potential deadlock
634 when modest_mail_operation_notify_end() is called from the queue
635 itself. If that is a problem performance-wise, I would suggest to
636 implement a status-changed signal or something.
638 * src/modest-mail-operation-queue.c: Make sure to never call a
639 function from another file while the queue is locked. This (hopefully)
640 fixes another deadlock when exiting the application while retrieving
643 2007-06-03 Johannes Schmid <johannes.schmid@openismus.com>
645 * src/dbus_api/modest-dbus-callbacks.c: (modest_dbus_req_filter):
646 Fixed build if libogs is not available
648 2007-06-03 Christian Kellner <ckellner@openismus.com>
650 * libmodest-dbus-client/libmodest-dbus-client.h:
651 * libmodest-dbus-client/libmodest-dbus-client.c:
652 (libmodest_dbus_client_delete_message):
653 Implement deletion of messages (Client side).
655 (modest_search_hit_free),
656 (modest_search_hit_list_free):
657 Utility functions to free the result hits.
659 * src/dbus_api/modest-dbus-api.h:
660 * src/dbus_api/modest-dbus-callbacks.c:
662 (modest_dbus_req_handler):
663 Implement deletion of messages (Server side).
665 * tests/dbus_api/test_search.c: (main):
668 * tests/dbus_api/Makefile.am:
669 * tests/dbus_api/test_delete_message:
670 Add little test for the message deletion logic
672 2007-06-03 Armin Burgmeier <armin@openismus.com>
674 * src/modest-mail-operation-queue.c: Fixed a deadlock in finalize()
675 when the operation queue was not empty. projects.maemo.org bug
678 2007-06-03 Armin Burgmeier <armin@openismus.com>
680 * src/widgets/modest-account-view.c
681 (on_account_default_toggled): Toggle default account column
682 explicitely instead of waiting for gconf notification (which is
683 currently ignored). This should fix projects.maemo.org bug NB#56910
684 for now. It should probably be removed when gconf notifications are
687 2007-06-03 Christian Kellner <ckellner@openismus.com>
689 * libmodest-dbus-client/libmodest-dbus-client.c:
690 Removed debugging spew.
692 * src/dbus_api/modest-dbus-callbacks.c:
693 Added debugging info.
695 * src/modest-search.c:
696 (modest_search_all_accounts):
697 Use tny_account_store_get_accounts () on the account store
698 to get all accounts which is the way to get all accounts.
700 * tests/dbus_api/test_search.c: (main):
701 Make it possible to supply the search term on the command line.
703 2007-06-03 Christian Kellner <ckellner@openismus.com>
705 * libmodest-dbus-client/libmodest-dbus-client.c:
706 * libmodest-dbus-client/libmodest-dbus-client.h:
707 Implement searching for mesages over raw dbus. (Client side)
709 * src/dbus_api/Makefile.am:
710 * src/dbus_api/modest-dbus-api.h:
711 * src/dbus_api/modest-dbus-callbacks.c:
712 * src/dbus_api/modest-dbus-callbacks.h:
713 Search framework (Server side). Also implement on_idle_open_message().
715 * src/maemo/modest-platform.c: (modest_platform_init):
716 Prepare for raw dbus/osso rpc interaction.
718 * src/modest-search.h:
719 Changed minsize from unspecific guint to guint32.
721 * src/modest-search.c:
723 Added strange hack which magically made tnymail work.
725 (modest_search_folder),
726 (modest_search_account),
727 (modest_search_all_accounts):
728 Implement helper functions to search all accounts, specific account
731 * tests/dbus_api/Makefile.am:
732 * tests/dbus_api/test_open_message.c:
733 Read url to open from commandline.
735 * tests/dbus_api/test_search.c:
736 Implement small test for dbus search stuff
738 2007-06-02 Armin Burgmeier <armin@openismus.com>
740 * src/maemo/modest-account-settings-dialog.c: Changed window title to
741 include account type and account title. This fixes projects.maemo.org
744 * src/maemo/modest-account-view-window.c: Set a title for the window.
746 2007-06-02 Armin Burgmeier <armin@openismus.com>
748 * src/maemo/easysetup/modest-easysetup-wizard.c: Always prefill
749 incoming and outgoing server name based on email address and server
750 types as long as the names have not been edited manually. This fixes
751 projects.maemo.org bug NB#58671.
753 2007-06-02 Armin Burgmeier <armin@openismus.com>
755 * src/maemo/easysetup/modest-easysetup-wizard.c: Added a note that the
756 server type cannot be changed in future to the incoming details page
757 when creating an account. This fixes projects.maemo.org bug NB#59029.
759 2007-06-02 Armin Burgmeier <armin@openismus.com>
761 * src/maemo/easysetup/modest-easysetup-wizard.c: Made labels wrapping
762 and assigned max width chars so that they wrap instead of being
763 truncated. Fixes projects.maemo.org bug NB#56126.
765 2007-06-02 Armin Burgmeier <armin@openismus.com>
767 * src/maemo/modest-connection-specific-smtp-window.c: Add an
768 introductory note to the connection specific smtp servers dialog, as
769 section 8.12 of the email UI specification requires. This fixes
770 projects.maemo.org bug NB#59212.
772 2007-06-01 Murray Cumming <murrayc@murrayc.com>
774 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
775 Check for running mail operations, and offer to cancel them, as per the UI
776 spec. This fixes projects.maemo.org bug NB#59041 .
777 However, I suspect that tinymail may still use the network connection
778 in ways that we cannot detect or cancel. But it should at least adapt to
781 2007-06-01 Murray Cumming <murrayc@murrayc.com>
783 * src/modest-tny-account-store.c: (recreate_all_accounts),
784 (get_cached_accounts), (get_server_accounts): Do more sensible
785 ref-counting of the temporarily-cached outbox accounts list. This seems
786 to fix a crash when entering the password when the password was wrong.
788 2007-06-01 Murray Cumming <murrayc@murrayc.com>
790 * src/gnome/modest-main-window.c: (connect_signals):
791 * src/modest-tny-account-store.c: (get_password),
792 (modest_tny_account_store_alert): Added comments and clues and
793 commented-out code about how we currently fail to deal with connection
794 errors and wrong passwords, and how we should.
796 2007-06-01 Murray Cumming <murrayc@murrayc.com>
798 * src/widgets/modest-retrieve-combo-box.c:
799 (modest_retrieve_combo_box_fill): Correc the choices for POP and IMAP.
800 This fixes projects.maemo.org bug NB#58472 .
802 2007-06-01 Murray Cumming <murrayc@murrayc.com>
804 * src/maemo/easysetup/modest-easysetup-wizard.c:
805 (create_page_complete_easysetup):
806 (create_page_complete_custom): Correct the last commit,
807 putting the correct sentences in the correct pages.
809 2007-06-01 Murray Cumming <murrayc@murrayc.com>
811 * src/maemo/easysetup/modest-easysetup-wizard.c:
812 (create_page_complete_custom): Show the second sentence of text
813 (mcen_ia_easysetup_complete). This fixes projects.maemo.org bug
816 2007-06-01 Murray Cumming <murrayc@murrayc.com>
818 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
819 Set the leave-on-server conf key by default. This fixes
820 projects.maemo.org bug NB#59258 .
822 2007-06-01 Murray Cumming <murrayc@murrayc.com>
824 * src/maemo/modest-account-view-window.c:
825 (on_delete_button_clicked): Use the new emev_nc_delete_mailboximap
826 logical ID for the confirmation messages. Fixed projects.maemo.org bug
829 2007-06-01 Murray Cumming <murrayc@murrayc.com>
831 * src/maemo/easysetup/modest-easysetup-wizard.c:
832 (create_caption_new_with_asterisk):
833 * src/maemo/modest-account-settings-dialog.c:
834 (create_caption_new_with_asterisk):
835 Uncomment the code to add the asterisk, because they are no longer in the
836 translated text in the .po file. Fixes projects.maemo.org bug NB#59202 .
837 (update_incoming_server_title): Add an asterisk here too.
839 2007-06-01 Murray Cumming <murrayc@murrayc.com>
841 * src/maemo/modest-maemo-global-settings-dialog.c:
842 (current_connection): Check that we are even connected before trying to
843 get the current connection name, to prevent a warning.
845 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
846 Change the comments because tny_maemo_conic_device_connect() is now meant to
848 * src/modest-mail-operation.c:
849 (modest_mail_operation_update_account): Call modest_platform_connect_and_wait() to
850 make sure we have a connection and fail if we can't connect.
852 2007-05-31 Murray Cumming <murrayc@murrayc.com>
854 * src/maemo/modest-main-window.c:
855 (on_account_store_connecting_finished): Do not try to get the
856 connection ID if we are not really connected. I am surprised that
857 this signal handler is called when we are not connected.
859 2007-05-31 Murray Cumming <murrayc@murrayc.com>
861 * src/modest-error.h:
862 * src/modest-ui-actions.c:
863 (modest_ui_actions_get_msgs_full_error_handler):
864 Renamed an enum, added comments, added an enum
865 for retrieve-limit errors.
867 * src/modest-mail-operation.c: (foreach_add_item),
868 (internal_folder_observer_update), (update_account_thread),
869 (modest_mail_operation_get_msgs_full):
870 (modest_mail_operation_update_account),
871 Added comments about how this works, and some code that should
872 (but does not) check the retrieve-limit. See the TODO comment.
874 2007-05-31 Murray Cumming <murrayc@murrayc.com>
876 * src/modest-ui-actions.c: (modest_ui_actions_on_help):
877 Initialize help_id to fix the build. Warnings are good.
879 2007-05-31 Murray Cumming <murrayc@murrayc.com>
881 * src/widgets/modest-hbox-cell-renderer.c:
882 (modest_hbox_cell_renderer_append):
883 * src/widgets/modest-vbox-cell-renderer.c:
884 (modest_vbox_cell_renderer_append):
885 Fix the last commit by doing an extra ref.
887 2007-05-31 Murray Cumming <murrayc@murrayc.com>
889 * src/widgets/modest-hbox-cell-renderer.c:
890 (modest_hbox_cell_renderer_append):
891 * src/widgets/modest-vbox-cell-renderer.c:
892 (modest_vbox_cell_renderer_append):
893 For glib < 2.10, use gtk_object_sink() instead of g_object_ref_sink(),
894 to fix the build with Maemo Bora.
895 However, there seems to be a remaining crash, probably due to reference
898 2007-05-30 Murray Cumming <murrayc@murrayc.com>
900 * src/modest-tny-account.c:
901 (modest_tny_account_new_for_local_folders):
902 Use hildon_file_system_info_async_new() to get a better name for
903 the memory card account, setting it as the account name.
904 The timing seems to work, but this is probably
905 not the best place to do this. See the TODO comment.
906 * src/maemo/modest-main-window.c: (create_details_widget):
907 * src/widgets/modest-folder-view.c: (text_cell_data):
908 Use the tny account name instead of hardcoding a name.
910 2007-05-30 Christian Kellner <ckellner@openismus.com>
912 * src/modest-search.c: (modest_search):
913 Correctly set part_search_func even if we have already parsed
914 the query and thus a valid OgsTextSearcher object.
916 2007-05-30 Christian Kellner <ckellner@openismus.com>
919 Search and check for libogs.
922 Incooparte the ogs build env.
924 * src/modest-mime-part-search-stream.c:
925 * src/modest-mime-part-search-stream.h:
926 Removed since we do the real searching now in modest-search.c.
928 * src/modest-search.c:
929 * src/modest-search.h:
930 Implement support for ogs. We use that if available and requested
931 and fall back to modest_text_utils_utf8_strcmp (). The search logic
932 should now handle the corner case when the search term is spread
933 across multiple reads.
934 Also the logic in modest_search () was corrected to search all
935 requested fields until one is found.
937 2007-05-30 Murray Cumming <murrayc@murrayc.com>
939 * src/modest-defs.h: Define MODEST_MCC1_VOLUMEPATH and MODEST_MCC1_VOLUMEPATH_URI.
942 * src/modest-init.c: Made modest_init_local_folders() take a
943 path and be public so we can iniitialize maildir folders on
946 * src/modest-local-folder-info.h:
947 * src/modest-local-folder-info.c:
948 (modest_local_folder_info_get_maildir_path): Add a path parameter.
950 * src/modest-tny-account.c:
951 (modest_tny_account_new_for_local_folders): Take a path parameter, though NULL
952 still means the standard local-folders path on the local volume.
954 * src/modest-tny-account-store.c:
955 (modest_tny_account_store_instance_init): Connect to GnomeVfsVolumeMonitor
956 signal so we can detect mount/unmount of the MMC1 card, and do an update of
957 all accounts when that happens.
958 (get_server_accounts): If the MMC1 card is mounted, create a store account for
959 this too, so it shows up in the treeview.
961 2007-05-28 Murray Cumming <murrayc@murrayc.com>
963 * src/maemo/modest-maemo-global-settings-dialog.c:
964 (current_connection):
965 * src/widgets/modest-global-settings-dialog.c:
966 (current_connection_default):
967 Use the enum values instead of 0, 1 and -1,
968 to make the code clearer.
970 * src/modest-account-mgr-helpers.c:
971 (modest_account_mgr_get_connection_specific_smtp): Make this code
974 * src/modest-runtime.h:
975 * src/modest-runtime.c:
976 Added modest_runtime_remove_all_send_queues().
977 * src/maemo/modest-main-window.c:
978 (on_account_store_connecting_finished): Recreate the send queues,
979 using the appropriate transport accounts for this new connection.
980 Some futher adapting might be needed if the old send queues are not
981 automatically stopped at this point.
983 * src/modest-tny-account-store.c: (get_server_accounts):
984 Create the connection-specific transport accounts, so that they can
985 be found later by their ID.
987 * src/modest-tny-account.h:
988 * src/modest-tny-account.c:
989 Added modest_tny_account_new_from_server_account_name().
990 modest_tny_account_new_from_server_account(): Do not create the
991 send queues here, because they will be
992 recreated anyway when the connection changes for the first time.
994 2007-05-28 Murray Cumming <murrayc@murrayc.com>
996 * src/modest-local-folder-info.h:
997 * src/modest-local-folder-info.c:
998 (modest_per_account_local_outbox_folder_info_get_maildir_path),
999 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1000 tbox_folder): Take a modest account name instead of a server TnyAccount,
1001 so we can have per-modest-account rather than per-transport-account
1003 We must make sure that we change or recreate the exisitng send queues
1004 when the connection changes for connection-specific transport accounts.
1006 * src/modest-tny-account-store.c:
1007 (create_per_account_local_outbox_folders): Create outboxed per modest
1008 account, not per transport account.
1010 * src/modest-tny-account.h:
1011 * src/modest-tny-account.c:
1012 (modest_tny_account_get_special_folder): For outboxes, get the
1013 parent modest account name. The account is ignored for other folders.
1014 (modest_tny_account_new_for_per_account_local_outbox_folder): Take a
1015 modest account name rather than a server TnyAccount.
1017 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1019 * src/modest-tny-account.c:
1020 (modest_tny_account_new_from_server_account):
1021 Call modest_runtime_get_send_queue() immediately after creating transport
1022 accounts, so that they start trying to send email from the outbox as soon
1023 as possible at startup. This is probably what we want.
1025 * src/modest-mail-operation.c: (update_account_thread):
1026 * src/modest-runtime.c: (modest_runtime_get_send_queue):
1027 * src/modest-tny-send-queue.c: (modest_tny_send_queue_try_to_send):
1028 * src/modest-tny-send-queue.h:
1029 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive),
1030 (modest_ui_actions_on_send):
1031 Added comments about how sending works, though it needs some more work.
1033 2007-05-25 Murray Cumming <murrayc@murrayc.com>
1035 * src/modest-tny-account.c:
1036 (modest_tny_account_get_special_folder): Add TODO because this fails when
1037 the network is busy.
1038 (modest_tny_folder_store_get_local_size): Fix an incorrect type check.
1039 * src/modest-ui-actions.c: (modest_ui_actions_on_smtp_servers):
1040 Do not try to show this window when there is no active account. The UI
1041 specs does not tell us what to do in this case.
1043 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1047 * src/maemo/Makefile.am:
1048 * src/widgets/Makefile.am: Some dist fixes.
1050 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1052 * src/maemo/modest-connection-specific-smtp-window.c:
1053 (on_button_edit): Make the code clearer, to prevent a double free.
1055 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1057 * src/maemo/modest-account-settings-dialog.c:
1058 (modest_account_settings_dialog_set_account_name),
1059 Check the connection-specific smtp servers checkbox if there are any.
1061 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1062 (modest_connection_specific_smtp_edit_window_init):
1063 Start with a suitable port number.
1065 * src/modest-account-mgr-helpers.h:
1066 * src/modest-account-mgr-helpers.c: Added
1067 modest_account_mgr_get_has_connection_specific_smtp().
1069 (modest_account_mgr_set_connection_specific_smtp),
1070 (modest_account_mgr_remove_connection_specific_smtp),
1071 (modest_account_mgr_get_has_connection_specific_smtp),
1072 (modest_account_mgr_get_connection_specific_smtp): Set/Get the list of
1073 connection-specific smtp server accounts in the account, rather than
1074 the server account conf dir.
1076 This fixes bug projects.maemo.org bug NB#58263 .
1078 * src/modest-tny-account-store.c:
1079 (create_per_account_local_outbox_folders): Do not call get_server_accounts()
1080 if there are no server accounts yet, to prevent an infinite loop when there
1081 are no accounts. Document that one must be called before the other.
1083 2007-05-24 Murray Cumming <murrayc@murrayc.com>
1085 * src/modest-account-mgr-helpers.c:
1086 (modest_account_mgr_get_default_account): Make sure that at least
1087 one account is always the default, if there are any enabled accounts.
1088 This is just a sanity check that shouldn't be necessary.
1090 * src/modest-account-mgr-priv.c:
1091 (_modest_account_mgr_account_from_key): Unescape the conf key to
1092 get the real account name. For instance, this is an issue if a space
1093 was in the account name, which can happen because the account name
1094 is generated from the display name.
1095 (_modest_account_mgr_get_account_keyname): Always escape the
1097 * src/modest-account-mgr.c: (modest_account_mgr_account_names):
1098 Unescape the conf keys to get the real account names.
1100 For instance, previously the is-default radio button in the accounts
1101 list was not checked for any accounts at first. This fixes that,
1102 and might fix several similar bugs.
1104 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1106 * src/modest-ui-actions.c: (set_active_account_from_tny_account):
1107 Removed some debug printfs.
1109 2007-05-23 Murray Cumming <murrayc@murrayc.com>
1111 Modest on-disk outbox directories are now here, for instance:
1112 $HOME/.modest/outboxes/<account-id-1>/outbox
1113 $HOME/.modest/outboxes/<account-id-2>/outbox
1115 $HOME/.modest/local-folders/outbox
1116 so we can have a separate outbox for each account.
1117 But they are shown as one outbox in the GtkTreeView, by using a
1118 TnyMergeFolder in a ModestTnySimpleFolderStore.
1121 * src/modest-tny-simple-folder-store.c:
1122 * src/modest-tny-simple-folder-store.h:
1123 Added ModestTnySimpleFolderStore, used to contain folders from
1124 other folder stores, such as other accounts.
1126 * src/modest-tny-outbox-account.h:
1127 * src/modest-tny-outbox-account.c:
1128 Added ModestTnyOutboxAccount, derived from TnyCamelStoreAccount,
1129 used for the per-account local outbox folders.
1131 * src/modest-defs.h: Rename MODEST_LOCAL_FOLDERS_ACCOUNT_ID to
1132 MODEST_ACTUAL_LOCAL_FOLDERS_ACCOUNT_ID, to make it clearer that we
1133 only use this (internally) now for the non-outbox local folders.
1135 * src/modest-init.h:
1136 * src/modest-init.c: Added modest_init_one_local_folder(), for
1137 setting up the directory structure for each local folder.
1139 * src/modest-local-folder-info.c:
1140 (modest_per_account_local_outbox_folder_info_get_maildir_path),
1141 (modest_per_account_local_outbox_folder_info_get_maildir_path_to_ou
1143 * src/modest-local-folder-info.h:
1144 * src/modest-tny-account-store.c: (on_account_removed),
1145 (on_account_changed), (create_per_account_local_outbox_folders),
1146 (get_server_accounts), (modest_tny_account_store_get_accounts),
1147 (modest_tny_account_store_get_tny_account_by_account),
1148 (modest_tny_folder_store_is_virtual_local_folders):
1150 * src/modest-tny-account.h:
1151 * src/modest-tny-account.c:
1152 Added modest_tny_account_new_for_per_account_local_outbox_folder(),
1153 to create an on-disk per-account local outbox folder for each
1155 (create_per_account_local_outbox_folders): Create a local outbox folder
1156 for each transport account.
1157 (modest_tny_account_new_for_local_folders): Do not create an outbox folder
1158 for all local folders.
1160 Added modest_tny_account_get/set_parent_modest_account_name_for_server_account()
1161 instead of using g_object_get/set() directly. It is clearer.
1163 (modest_tny_folder_store_get_message_count),
1164 (modest_tny_folder_store_get_local_size
1165 (modest_tny_folder_store_get_folder_count): Renamed from modest_tny_account*,
1166 because we now use these with non-acount folder stores.
1168 (modest_tny_account_get_special_folder),
1169 (modest_tny_account_new_from_server_account),
1170 (modest_tny_account_new_from_account):
1171 (recurse_folders): Adjust to the new outbox system.
1173 * src/modest-tny-folder.h:
1174 * src/modest-tny-folder.c:
1175 (modest_tny_folder_is_local_folder),
1176 (modest_tny_folder_get_local_folder_type),
1177 (modest_tny_folder_is_outbox_for_account): Adjust for the new outbox system.
1179 * src/widgets/modest-main-window.h:
1180 * src/maemo/modest-main-window.c: (create_details_widget),
1181 (modest_main_window_set_contents_style): Show details for any folder store,
1184 (modest_tny_folder_get_rules):
1185 Remove the const. C does not support constness enough for this.
1187 * src/modest-ui-actions.c:
1188 update_model(): Use a ModestTnySimpleListStore and a TnyMergeFolder to
1189 make all outboxes appear as one, in the usual local-folders tree node.
1191 (set_active_account_from_tny_account),
1192 (modest_ui_actions_on_folder_selection_changed):
1193 * src/widgets/modest-folder-view.c: (text_cell_data),
1194 (icon_cell_data), (filter_row),
1195 (add_account_folders_to_merged_folder),
1196 (add_account_folders_to_simple_folder_store), (),
1197 (get_cmp_rows_type_pos), (cmp_rows),
1198 (modest_folder_view_set_account_id_of_visible_server_account):
1199 Adjust to the new outbox system, using generic folder stores and folders
1200 in the GtkTreeModel.
1202 2007-05-23 Christian Kellner <ckellner@openismus.com>
1204 * src/modest-mail-operation.c:
1205 (modest_mail_operation_update_account):
1206 Use info->max_size instead of unintialized local var [small
1207 build fix]. (Added TODO to review that change since I don't
1210 2007-05-23 Marcus Bauer <marcusb@openismus.com>
1212 * libmodest-dbus-client/libmodest-dbus-client.c:
1213 (libmodest_dbus_client_compose_mail): function added
1214 * src/dbus_api/modest-dbus-api.h:
1215 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_compose_mail),
1216 (on_compose_mail): Implementation of the SendAsMail functionality
1218 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1220 * src/modest-account-mgr.c:
1221 (modest_account_mgr_add_server_account): Set the secure-connection
1222 conf key for transport accounts as well as store accounts. I don't know
1223 why the if was there. For instance, this makes sure that we use SSL
1224 for the gmail preset from the easysetup wizard.
1226 2007-05-22 Murray Cumming <murrayc@murrayc.com>
1228 * src/gnome/modest-main-window.c:
1229 (on_account_store_connecting_finished), (connect_signals):
1230 * src/maemo/modest-main-window.c:
1231 (on_account_store_connecting_finished), (connect_signals),
1232 (modest_main_window_new):
1233 Handle TnyAccountStore::connecting-finished instead of
1234 TnyDevice::connection-changed, because we cannot actually perform
1235 operations on accounts until TnyAccountStore has itself responded to
1236 the TnyDevice::connection-changed signal. This prevents a GError from
1238 Do not try to update at startup, because we (at least on scratchbox)
1239 already do an update at startup when the device goes online.
1240 This prevents a GError from tinymail.
1241 * src/modest-ui-actions.c: (modest_ui_actions_do_send_receive):
1242 Added TODO about stopping simultaneous operations.
1244 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1246 * src/modest-account-mgr.c: (modest_account_mgr_add_account):
1247 * src/modest-mail-operation-queue.c:
1248 (modest_mail_operation_queue_remove):
1249 * src/modest-tny-account-store.c: When GErrors happen, give more clues
1250 about where they happened.
1252 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1254 * src/modest-ui-actions.c:
1255 (modest_ui_actions_on_password_requested): Make sure that the remember
1256 output parameter is always TRUE.
1258 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1260 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1261 Show a OK/Cancel dialog if the error is a question, though we still do not
1262 know anything more about what we are asking the user.
1263 * src/widgets/modest-folder-view.c: (on_drag_data_received):
1264 Fix an uninitialized variable (helper). This is a logic error, however.
1266 2007-05-21 Christian Kellner <ckellner@openismus.com>
1268 * src/modest-search.h:
1269 Correct bit shifting in the ModestSearchFlags enum.
1271 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1273 * src/modest-tny-account.c:
1274 (modest_tny_account_new_from_server_account): Do not use the lsub and
1275 check-all hard-coded IMAP options when using POP.
1277 2007-05-21 Murray Cumming <murrayc@murrayc.com>
1279 * src/modest-tny-account.c:
1280 (modest_tny_account_new_from_server_account):
1281 Use NULL for the secure-auth method for POP when Password auth has been
1282 specified by the user, as we already do for IMAP. "auth=Login" causes
1283 an error from camel or the server.
1285 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1287 * src/maemo/modest-account-settings-dialog.c:
1288 (create_page_account_details),
1289 (modest_account_settings_dialog_set_account_name):
1290 * src/maemo/modest-account-settings-dialog.h: Hide the whole caption
1291 for the leave-on-server checkbox, rathr than just the checkbox, when
1292 the protocol is not POP.
1294 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1296 * src/widgets/modest-account-view.c:
1297 * src/widgets/modest-account-view.h:
1298 Added modest_account_view_select_account() which will be useful later
1299 to asynchronously re-select the edited account.
1301 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1303 * src/maemo/modest-account-settings-dialog.c:
1304 (modest_account_settings_dialog_set_account_name):
1305 Automatically choose the port numbers based on the secure authentication
1306 methods, if they have not been chosen before.
1307 This fixes projects.maemo.org bug NB#56273 .
1309 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1311 * src/maemo/modest-main-window-ui.h:
1312 * src/modest-ui-actions.c:
1313 * src/modest-ui-actions.h:
1314 Connect the Tools/SMTP Servers menu item to
1315 modest_ui_actions_on_smtp_servers(), which shows the connection-specific
1316 SMTP servers dialog, as in the UI specification and saves changes when it
1317 is closed. This fixed projects.maemo.org bug NB#56305 .
1319 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1321 * src/maemo/modest-connection-specific-smtp-window.c:
1322 (modest_connection_specific_smtp_window_init):
1323 Use gtk_window_set_default_size() to make this window big enough, so
1324 we see more of the GtkTreeView. This fixes projects.maemo.org bug NB#55497 .
1326 2007-05-17 Murray Cumming <murrayc@murrayc.com>
1328 * src/maemo/modest-connection-specific-smtp-edit-window.h:
1329 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1330 (modest_connection_specific_smtp_edit_window_init),
1331 Do not try to connect to a combobox signal before the combobox exists.
1332 This fixes the cras in projects.maemo.org bug NB#56288 .
1333 (modest_connection_specific_smtp_edit_window_get_settings):
1334 Remove the server_account_name parameter which was being checked for NULL
1335 though it was not used.
1337 * src/maemo/modest-connection-specific-smtp-window.c:
1338 (modest_connection_specific_smtp_window_fill_with_connections),
1339 (on_button_edit), (modest_connection_specific_smtp_window_init):
1340 Correct the number of treemodel columns to prevent a warning.
1341 Added DEBUG_WITHOUT_LIBCONIC #define, for debugging on scratchbox, where
1342 libconic does not work.
1344 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1346 * src/modest-tny-account.c:
1347 (modest_tny_account_new_from_server_account):
1348 Explicitly use ANONYMOUS secure authentication, instead of "PLAIN" for
1349 SMTP when "None" was chosen by the user. However, with my SMTP server that
1350 does not support ANONYMOUS, the emails do not leave the Outbox and I see
1353 2007-05-16 Murray Cumming <murrayc@murrayc.com>
1355 * src/modest-pair.h: Improve the documentation for modest_combo_box_new()
1356 to explain the memory management issue with the ID in the ModestPair.
1358 * src/gnome/modest-account-assistant.c: (add_receiving_page),
1359 (add_sending_page), (modest_account_assistant_finalize):
1360 * src/gnome/modest-gnome-global-settings-dialog.c:
1361 (create_updating_page), (create_composing_page):
1362 * src/gnome/modest-msg-edit-window.c: (get_transports),
1363 (init_window), (modest_msg_edit_window_finalize),
1364 (modest_msg_edit_window_get_msg_data):
1365 * src/gnome/modest-store-widget.c: (imap_pop_configuration):
1366 * src/gnome/modest-transport-widget.c:
1367 (modest_transport_widget_finalize), (smtp_configuration):
1368 * src/maemo/modest-maemo-global-settings-dialog.c:
1369 (create_updating_page), (create_composing_page):
1370 * src/maemo/modest-msg-edit-window.c: (get_transports),
1371 (init_window), (modest_msg_edit_window_finalize),
1372 (modest_msg_edit_window_get_msg_data),
1373 (modest_msg_edit_window_free_msg_data):
1374 * src/maemo/modest-store-widget.c: (imap_pop_configuration),
1375 (modest_store_widget_finalize):
1376 * src/maemo/modest-transport-widget.c:
1377 (modest_transport_widget_finalize), (smtp_configuration):
1378 * src/modest-main.c: (send_mail):
1379 * src/widgets/modest-combo-box.h:
1380 * src/widgets/modest-global-settings-dialog-priv.h:
1381 * src/widgets/modest-global-settings-dialog.c:
1382 (modest_global_settings_dialog_finalize):
1383 * src/widgets/modest-msg-edit-window.h:
1384 Whenever using modest_combo_box_new(), keep the ModestPairList alive
1385 as long as the combo box, to prevent use of freed memory for the ID.
1387 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1389 * src/modest-tny-account-store.c: (get_server_accounts): Renamed from
1390 get_accounts(), to make this clearer. Do not check for the enabled gconf
1391 key, because we do not use this for server accounts (at least, not yet).
1392 This allows us to send email again.
1394 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1396 * src/maemo/modest-platform.c:
1397 (on_modest_conf_update_interval_changed), (modest_platform_init):
1398 Only respond to this particular key change. All these strcmp()s cannot be
1401 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1403 * src/maemo/modest-maemo-global-settings-dialog.c:
1404 (current_connection): Prevent a crash in scratchbox when
1405 ny_maemo_conic_device_get_current_iap_id() returns NULL.
1406 * src/maemo/modest-platform.c:
1407 (on_modest_conf_update_interval_changed), (modest_platform_init):
1408 Get the update interval from gconf and reset it when the gconf key changes.
1410 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1412 * src/modest-protocol-info.c:
1413 * src/modest-protocol-info.h: Adde enum-specific get functions,
1414 instead of using a ModestProtocolType enum parameter.
1416 * src/gnome/modest-account-assistant.c:
1417 * src/gnome/modest-store-widget.c:
1418 * src/gnome/modest-store-widget.h:
1419 * src/gnome/modest-transport-widget.c:
1420 * src/gnome/modest-transport-widget.h:
1421 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.c:
1422 * src/maemo/easysetup/modest-easysetup-servertype-combo-box.h:
1423 * src/maemo/easysetup/modest-easysetup-wizard.c:
1424 * src/maemo/modest-account-settings-dialog.c:
1425 * src/maemo/modest-account-settings-dialog.h:
1426 * src/maemo/modest-store-widget.c:
1427 * src/maemo/modest-store-widget.h:
1428 * src/maemo/modest-transport-widget.c:
1429 * src/maemo/modest-transport-widget.h:
1430 * src/modest-account-mgr-helpers.c:
1431 * src/modest-account-mgr-helpers.h:
1432 * src/modest-account-mgr.c:
1433 * src/modest-account-mgr.h:
1434 * src/modest-tny-account.c:
1435 * src/modest-tny-folder.c:
1436 * src/widgets/modest-account-view.c:
1437 * src/widgets/modest-retrieve-combo-box.c:
1438 * src/widgets/modest-retrieve-combo-box.h:
1439 * src/widgets/modest-secureauth-combo-box.c:
1440 * src/widgets/modest-serversecurity-combo-box.c:
1441 * src/widgets/modest-serversecurity-combo-box.h:
1442 * tests/check_account-mgr.c:
1443 Use the specific functions, and use the re-renamed enum values for GNOME too.
1445 2007-05-15 Murray Cumming <murrayc@murrayc.com>
1447 * src/modest-pair.h:
1448 * src/modest-pair.c: Added modest_pair_list_find_by_first_as_string(),
1449 so we can get the second based on the first.
1451 * src/maemo/modest-account-settings-dialog.h:
1452 * src/maemo/modest-account-settings-dialog.c:
1453 Added get_supported_secure_authentication_methods(), though it is mostly
1454 commented-out for now until the necessary API is committed to tinymail.
1455 (modest_account_settings_dialog_set_account_name),
1456 (save_configuration): Request the supported authentication methods from the
1457 server, so we can choose a working method.
1459 * src/modest-tny-account-store.h:
1460 * src/modest-tny-account-store.c:
1461 (modest_tny_account_store_get_session): Rename from
1462 tny_account_store_get_session().
1464 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1466 * src/modest-protocol-info.h: Split the ModestProtocol enum
1467 into ModestProtocol, ModestSecureConnection, and ModestSecureAuthentication.
1468 There was no need to have these unrelated values in one enum.
1470 * src/: many files: Adapted to changed enum. This makes the code a bit
1471 clearer, and the compiler could catch some errors.
1473 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1475 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1476 Show the detailed internal camel error message when an error happens
1477 during the configuration, so that our testers can give us more clues.
1478 For instance, in projects.maemo.org bug NB#56910 .
1480 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1482 * src/modest-tny-account.c:
1483 (modest_tny_account_new_from_server_account): Adapt to changed tinymail API:
1484 change tny_account_set_mech() to tny_account_set_secure_auth_mech().
1486 2007-05-14 Murray Cumming <murrayc@murrayc.com>
1488 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
1489 * src/maemo/modest-account-settings-dialog.c:
1490 (modest_account_settings_dialog_set_account_name),
1491 (save_configuration): For the incoming secure authentication checkbox,
1492 use PASSWORD for unchecked, and CRAM-MD5 for checked, after I reread
1493 the UI specification. PLAIN does not seem to be supported for most IMAP
1494 servers anyway, and I am not sure what it would mean.
1495 However, we probably need to discover which of the secure-authentication
1496 mechanisms are supported by the server, instead of hard-coding CRAM-MD5.
1497 * src/modest-account-mgr-helpers.c:
1498 (modest_account_mgr_get_server_account_data):
1500 * src/modest-tny-account.c:
1501 (modest_tny_account_new_from_server_account):
1502 Use tny_account_set_mech() to set secure-authentication methods,
1503 with some special-casing for IMAP, based on my observations of how
1506 * src/modest-account-mgr-helpers.h:
1507 * src/modest-account-mgr.c:
1508 * src/modest-defs.h: Comment that the URI is only used for local folders.
1510 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1512 * src/maemo/modest-main-window.c: (on_account_update): Make the gchar*
1513 parameter const, just to be neat.
1514 * src/modest-text-utils.c: (modest_text_utils_inline):
1515 End g_strconcat() with NULL, as its documentation says. This is almost
1516 certainly the cause of my crash at startup on the device. Interestingly,
1517 valgrind doesn't tell us about these errors.
1519 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1521 * scripts/build-packages: Added more precise comments about how to use
1522 this script, though I still get this error:
1523 dpkg-genchanges: error: cannot open .dsc file ../tinymail_1.0-svn1938.dsc: No such file or directory
1524 error building tinymail
1526 2007-05-11 Murray Cumming <murrayc@murrayc.com>
1528 * src/maemo/modest-main-window.c: (on_account_update):
1529 Very slight cleanup, hoping to make it simpler to discover what causes
1530 a crash here sometimes.
1532 * src/modest-tny-account.c:
1533 (modest_tny_account_new_from_server_account): Set the port. Added
1534 comments about the options and a TODO comment because I need to find out
1535 how to specify the secure authentication method.
1537 2007-05-11 Marcus Bauer <marcusb@openismus.com>
1539 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
1540 changed CFlags paths form modest to libmodest
1542 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1544 * src/modest-account-mgr-helpers.c:
1545 (modest_account_mgr_get_server_account_data),
1546 (modest_account_mgr_free_server_account_data):
1547 * src/modest-account-mgr-helpers.h:
1548 * src/modest-account-mgr.c:
1549 (modest_account_mgr_add_server_account):
1550 * src/modest-defs.h:
1551 * src/modest-tny-account.c:
1552 (modest_tny_account_new_from_server_account):
1553 Determine the options for tny_camel_account_add_option() here,
1554 based on the settings, rather than storing them directly in gconf.
1556 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1558 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1559 Show a more friendly error dialog now that we expect (from the tinymail
1560 documentation) to get the UNKNOWN_ALERT error. Add explanatory comments.
1562 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1564 * src/maemo/modest-main-window.c: (on_account_update): Check that
1565 account_name is not NULL, to prevent a crash at startup that I am
1566 seeing on the N800. I do wonder why it is NULL.
1568 * src/maemo/easysetup/modest-easysetup-wizard.c:
1569 (create_page_user_details):
1570 * src/maemo/modest-account-settings-dialog.c:
1571 (create_page_user_details), (create_page_outgoing):
1572 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1573 (modest_connection_specific_smtp_edit_window_init):
1574 * src/modest-ui-actions.c:
1575 (modest_ui_actions_on_password_requested):
1576 Use HILDON_GTK_INPUT_MODE_INVISIBLE with password entries, which
1577 might do something useful with the on-screen keyboard.
1579 2007-05-10 Murray Cumming <murrayc@murrayc.com>
1581 * src/maemo/modest-main-window.c: (on_account_update):
1582 Avoid adding a menu item to priv->accounts_popup if accounts_popup is
1583 NULL, to avoid lots of warnings. However, it probably should not be NULL.
1585 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1587 * src/modest-tny-account-store.c: (on_account_changed):
1588 Correct the signature of this signal handler.
1590 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1592 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1593 Show a HildonNote instead of a GtkDialog for Maemo.
1595 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1597 * src/widgets/modest-account-view.h:
1598 * src/widgets/modest-account-view.c: (on_account_changed),
1599 (on_account_removed). Added a boolean flag, set/unset by
1600 modest_account_view_block_conf_updates(),
1601 modest_account_view_unblock_conf_updates() to prevent unnecessary
1602 updates, but this is not very useful because the gconf notifications are
1603 so delays (maybe only on Maemo Bora).
1604 So auto-updating is turned off, and these functions do an explicit
1605 update when necessary.
1606 However, something else is still doing too much work when adding/removing
1607 accounts, probably in another part of the application.
1609 * src/maemo/modest-account-view-window.c:
1610 (on_delete_button_clicked), (on_edit_button_clicked),
1611 (on_new_button_clicked): Use the new functions.
1613 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1615 * src/modest-account-mgr-helpers.c:
1616 (modest_account_mgr_set_first_account_as_default):
1617 Sort the list of names alphabetically-by-title, so we choose the first one
1619 * src/widgets/modest-account-view.c: (init_view): Sort the TreeModel
1620 alphabetically by the title.
1622 This fixes projects.maemo.org bug NB#56418 .
1624 * src/modest-account-mgr-priv.c:
1625 (_modest_account_mgr_account_from_key):
1626 * src/modest-account-mgr.c: (on_key_change): Initialize variables to
1627 avoid a valgrind error, and possible random behaviour.
1629 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1631 * src/modest-tny-account-store.c: (modest_tny_account_store_alert):
1632 Handle the new TNY_ACCOUNT_STORE_ERROR error domain. I will update the
1633 tinymail documentation to say that this can be expected.
1634 Handle the new TNY_ACCOUNT_STORE_ERROR_UNKNOWN_ALERT error code. It is not
1635 pretty, and should not happen, but I would prefer to know when it does.
1637 2007-05-09 Murray Cumming <murrayc@murrayc.com>
1639 * configure.ac: When using the older hildon version, probably on Bora,
1640 require gnome-vfs-module-2.0, which is the old provider of gnome-vfs-mime.h,
1642 * src/widgets/modest-attachment-view.c:
1643 (modest_attachment_view_set_part_default): Initialize variables, to fix the
1646 2007-05-09 Marcus Bauer <marcusb@openismus.com>
1648 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_open_message):
1649 Implemented the prototype. Can be tested with
1650 tests/dbus_api/test_open_message:
1652 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1654 * src/modest-tny-account-store.c:
1655 (modest_tny_account_store_instance_init), (get_password):
1656 * src/modest-ui-actions.c:
1657 (modest_ui_actions_on_password_requested):
1658 Do not store the password in gconf, because this function is called
1659 for non-remembered passwords. Actually use the cached (in the hash map)
1660 password instead of releasing it.
1661 The password will now not be remembered if it is asked via the protected
1662 password dialog, as per the UI spec.
1664 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1666 * src/modest-defs.h:
1667 * src/modest-account-mgr-helpers.h:
1668 * src/modest-account-mgr-helpers.c:
1669 Added modest_server_account_get_username_has_succeeded(),
1670 modest_server_account_set_username_has_succeeded().
1671 (modest_server_account_set_username),
1672 Reset the has-succeeded flag if the username changes.
1674 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
1675 * src/maemo/modest-connection-specific-smtp-window.c:
1676 (modest_connection_specific_smtp_window_save_server_accounts):
1677 Use modest_server_account_set_username() instead of using
1678 modest_conf_set_string() directly, so that the has-succeeded flag is always
1681 * src/modest-ui-actions.c:
1682 (modest_ui_actions_on_password_requested): Dim the username entry if
1683 the username has ever worked, as per the UI spec.
1685 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1687 * src/modest-tny-account-store.c: (get_password):
1688 * src/modest-ui-actions.c:
1689 (modest_ui_actions_on_password_requested):
1690 Allow the username to be changed too, though there is more work to
1691 be done on exactly how this behaves.
1693 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1695 * src/modest-account-mgr-helpers.h:
1696 * src/modest-account-mgr-helpers.c:
1697 Added modest_account_mgr_get_display_name(),
1698 modest_server_account_get_username(),
1699 modest_server_account_set_username(),
1700 modest_server_account_set_password(),
1701 modest_server_account_get_hostname() functions so we do not need to
1702 use the conf API directly.
1704 * src/maemo/modest-main-window.c: (connect_signals):
1705 Actually connect ot the ModestAccountStore::request-password signal,
1706 so that we show the dialog when the password is requested by Tinymail,
1707 for isntance if it is empty.
1709 * src/modest-marshal.list:
1710 * src/modest-tny-account-store.c:
1711 (modest_tny_account_store_class_init), (get_password),
1712 (modest_tny_account_store_alert):
1713 * src/modest-tny-account-store.h:
1714 * src/modest-ui-actions.h:
1715 * src/modest-ui-actions.c:
1716 (modest_ui_actions_on_password_requested):
1717 Change the signal parameters, so it is obvious that we are providing
1718 the non human-readable server name, and receiving both the username
1719 and password, though changing of the username is not yet implemented.
1720 Change the dialog UI to match the Maemo UI specifications, with #idfefing
1721 for the GNOME version.
1723 This should fix the projects.maemo.org bug NB#56209, though it does not
1724 work on Bora, because the gconf_client_get() for the password fails
1725 immediately after we save it with gconf_client_set().
1727 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1730 * src/Makefile.am: Reverted the use of AM_CONDITIONAL(), because it
1731 caused an undefined symbol error:
1732 modest-platform.c:84: undefined reference to `modest_osso_cb_hw_state_handler
1734 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1736 * src/modest-tny-account-store.c:
1737 (modest_tny_account_store_alert): Adapt to the changed tinymail API,
1738 using a GError instead of a string message, so we can translate it in
1741 2007-05-08 Murray Cumming <murrayc@murrayc.com>
1743 * src/maemo/modest-address-book.c:
1744 (modest_address_book_check_names):
1745 * src/maemo/modest-msg-view-window.c:
1746 (modest_msg_view_window_clipboard_owner_change):
1747 * src/modest-init.c: (modest_init_init_ui):
1748 * src/modest-mail-operation.c: (modest_mail_operation_send_mail),
1749 (update_folders_cb), (modest_mail_operation_update_account):
1750 * src/modest-ui-actions.c: (modest_ui_actions_on_msg_link_hover),
1751 (modest_ui_actions_on_msg_attachment_clicked),
1752 (modest_ui_actions_on_msg_recpt_activated):
1753 * src/widgets/modest-header-view.c: (drag_data_get_cb):
1754 * src/widgets/modest-msg-view.c: (modest_msg_view_search),
1755 (modest_msg_view_search_next):
1756 * src/widgets/modest-recpt-editor.c:
1757 (modest_recpt_editor_on_button_release_event),
1758 (modest_recpt_editor_on_key_press_event): Commented-out unnecessary calls to
1759 g_message(). At this point we should only be seeing interesting errors on
1760 stdout. Debugging messages could be #ifdefed-out if they are still useful.
1762 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1764 (modest_wizard_dialog_force_title_update):
1765 * src/maemo/easysetup/modest-wizard-dialog.h:
1766 * src/maemo/easysetup/modest-wizard-dialog.c: (set_property):
1767 For GTK+ 2.10, when present, connect to the GtkNotebook signals so we
1768 can update the title when appropriate. Otherwise the title is wrong if the
1769 pages are added after adding the notebook to the dialog.
1770 This must be a problem in HildonWizardDialog too.
1771 Added modest_wizard_dialog_force_title_update() for GTK+ 2.6.
1773 * src/maemo/easysetup/modest-easysetup-wizard.c:
1774 (create_subsequent_customsetup_pages),
1775 (create_subsequent_easysetup_pages):
1776 Call modest_wizard_dialog_force_title_update() so that the title is
1777 correct even with GTK+ < 2.10.
1778 This fixes projects.maemo.org bug NB#56145 .
1780 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1782 * src/maemo/modest-platform.c:
1783 (modest_platform_set_update_interval): Use the ALARM_EVENT_NO_DIALOG
1784 flag (awful lack of namespacing in this API) to prevent a useless %s dialog
1787 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1789 * src/widgets/modest-window.h:
1790 * src/widgets/modest-window.c: Added a save_state_func vfunc,
1791 and modest_window_save_state(), which invokes it.
1793 * src/widgets/modest-window-mgr.h:
1794 * src/widgets/modest-window-mgr.c:
1795 Added modest_window_mgr_save_state_for_all_windows(), which calls
1796 the save_state vfunc on all registered windows, if implemented.
1798 * src/gnome/modest-msg-edit-window.c:
1799 * src/gnome/modest-msg-view-window.c:
1800 * src/maemo/modest-msg-edit-window.c:
1801 * src/maemo/modest-msg-view-window.c:
1802 * src/maemo/modest-main-window.c:
1803 Specify the existing save_settings functions as implementations of
1804 ModestWindow::save_state_func().
1806 * src/maemo/modest-osso-state-saving.c: modest_osso_save_state():
1807 Call modest_window_mgr_save_state_for_all_windows(). This happens before
1808 enabling hibernation, for instance.
1810 We may need to do the same thing for restoring settings.
1813 2007-05-07 Murray Cumming <murrayc@murrayc.com>
1815 * src/widgets/modest-window-mgr.c:
1816 * src/widgets/modest-window-mgr.h:
1817 Added modest_window_mgr_prevent_hibernation_while_window_is_shown() and
1818 modest_window_mgr_get_hibernation_is_prevented().
1820 * src/maemo/modest-main-window.c:
1821 (on_hildon_program_is_topmost_notify): Prevent hibernation
1822 (possible when the application goes to the background in the WM),
1823 if modest_window_mgr_get_hibernation_is_prevented() is TRUE.
1825 * src/maemo/easysetup/modest-easysetup-wizard.c:
1826 (modest_easysetup_wizard_dialog_init):
1827 * src/maemo/modest-account-settings-dialog.c:
1828 (modest_account_settings_dialog_init):
1829 * src/maemo/modest-connection-specific-smtp-edit-window.c:
1830 (modest_connection_specific_smtp_edit_window_init):
1831 * src/maemo/modest-connection-specific-smtp-window.c:
1832 (modest_connection_specific_smtp_window_init):
1833 * src/maemo/modest-signature-editor-dialog.c:
1834 (modest_signature_editor_dialog_init):
1835 Call modest_window_mgr_prevent_hibernation_while_window_is_shown() to
1836 prevent hibernation while any of these account settings dialogs are open.
1838 2007-05-04 Murray Cumming <murrayc@murrayc.com>
1840 * src/maemo/Makefile.am:
1841 * src/maemo/modest-osso-state-saving.c:
1842 * src/maemo/modest-osso-state-saving.h: Added
1843 modest_osso_load_state() and modest_osso_save_state() though they do
1844 nothing now. They should iterate through all the open windows and load/save
1846 * src/modest-ui-actions.c: (modest_ui_actions_on_quit): For Mameo,
1847 save state when closing.
1849 * src/maemo/modest-main-window.c:
1850 (on_hildon_program_is_topmost_notify), (modest_main_window_new):
1851 Add a notification handler for the HildonProgram::is-topmost property,
1852 so we can allow hibernation when the application goes into the background.
1853 But we still need to detect when the accounts setup windows are open so
1854 we can stop hibernation when they are open.
1855 To do this, I also added the main window the HildonProgram. This might have
1856 other side-effects/benefits, and should maybe be done for other windows.
1858 * src/maemo/modest-osso-autosave-callbacks.h:
1859 * src/maemo/modest-osso-autosave-callbacks.c:
1860 (modest_on_osso_application_autosave): Add a libosso auto-save callback,
1861 though it does not do anything yet, and we might never need this to do
1862 anything. For instance, we already save drafts.
1864 * src/maemo/modest-platform.c: (modest_platform_init):
1865 Specify the libosso auto-save callback.
1867 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1869 * src/maemo/modest-platform.c:
1870 (modest_platform_set_update_interval):
1871 * src/modest-defs.h: Store the alarmd cookie ID in gconf, because it
1872 aparently stays valid between application instances, so we can use this
1873 to remove and reset it later. According to a maemo-developers email from
1876 2007-05-03 Murray Cumming <murrayc@murrayc.com>
1878 * configure.ac: Depend on libalarm for Maemo.
1880 * src/dbus_api/modest-dbus-api.h:
1881 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_receive),
1882 (on_send_receive), (modest_dbus_req_handler):
1883 Handle a SEND_RECEIVE D-Bus method.
1885 * libmodest-dbus-client/libmodest-dbus-client.c:
1886 (libmodest_dbus_client_send_and_receive):
1887 * libmodest-dbus-client/libmodest-dbus-client.h:
1888 Add C convenience functions for calling the new D-Bus method.
1890 * src/modest-platform.h:
1891 * src/gnome/modest-platform.c:
1892 * src/maemo/modest-platform.c:
1893 Added modest_platform_set_update_interval(), which uses the
1894 alarmd API on Maemo.
1895 (modest_platform_init),
1896 Call modest_platform_set_update_interval(), using a hard-coded
1897 interval for now (until the global settings dialog is implemented),
1898 though I am not sure that this makes sense yet.
1900 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1902 * src/dbus_api/modest-dbus-callbacks.c:
1903 (modest_osso_cb_hw_state_handler):
1904 * src/dbus_api/modest-dbus-callbacks.h:
1905 * src/maemo/modest-platform.c: (modest_platform_init):
1906 Registered (empty) callbacks for the osso hardware state D-Bus signals,
1907 in case this has some effect on the ability for Maemo to ping the
1910 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1912 * src/modest-text-utils.c: (modest_text_utils_validate_recipient):
1913 Comment out an if() that checks a gchar for < 0, causing a build-breaking
1914 warning. It is probably a logic error, but I need to fix the build.
1916 2007-05-02 Murray Cumming <murrayc@murrayc.com>
1918 * src/modest-account-mgr.h:
1919 * src/modest-account-mgr.c:
1920 (modest_account_mgr_account_names): Add a gboolean enabled_only
1921 parameter, so we can get lists of onlt the enabled accounts.
1923 (modest_account_mgr_add_account),,
1924 (modest_account_mgr_account_with_display_name_exists):
1925 * src/maemo/modest-msg-edit-window.c: (get_transports):
1926 * src/modest-account-mgr-helpers.c:
1927 (modest_account_mgr_set_first_account_as_default):
1928 * src/modest-init.c: (init_default_account_maybe):
1929 * src/modest-tny-account-store.c: (get_accounts):
1930 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
1931 (do_send_receive_auto), (modest_ui_actions_on_send_receive):
1932 * tests/check_account-mgr.c: (START_TEST):
1933 Provide the extra parameter, as appropriate.
1935 * src/widgets/modest-account-view.c: (update_account_view):
1936 Do not show disabled accounts (meaning that there is no way to
1937 enable/disable accounts in the UI (the feature is not in our UI
1938 specification), so we can use this internally only to mark unfinished
1939 or temporary account data.
1941 * src/maemo/easysetup/modest-easysetup-wizard.c:
1942 (create_account): Add boolean enable parameter, so we can specify FALSE
1943 to create the temporary account.
1944 (on_button_edit_advanced_settings): Create the temporary account as disabled.
1945 (on_before_next): When finishing, when there is a temporary account, just
1947 Also, use a timeout to delay the showing of the dialog until gconf is likely
1948 to return correct information, due to a maemo gconf bug that is fixed in
1949 osso 1.1, but not yet in Bora.
1950 However, the dialog stays on screen after it is destroyed.
1952 * src/maemo/modest-account-settings-dialog.c: on_response(): Do not check
1953 for invalid data when cancelling. Use a hildon note instead of a dialog
1954 to complain about invalid data. Do not show the account-saved note if the
1955 account is disabled (a temporary account that will not really be saved for use
1958 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1960 * src/modest-account-mgr-helpers.h:
1961 * src/modest-account-mgr-helpers.c:
1962 Added modest_account_mgr_unset_default_account(),
1963 Added modest_account_mgr_set_first_account_as_default().
1965 * src/modest-account-mgr.c: (modest_account_mgr_remove_account):
1966 If it was the default account, unset the default account name.
1968 * src/maemo/modest-account-view-window.c:
1969 (on_delete_button_clicked): If it was the default account,
1970 set the first remaining account as the default instead.
1972 * src/maemo/modest-main-window.c: (on_account_update): Do not try to use
1973 a NULL account or a NULL default account, to prevent a crash. This should
1974 not happen now anyway. Bug #55343 in projects.maemo.org/bugzilla.
1977 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1979 * src/widgets/modest-recpt-editor.c:
1980 (modest_recpt_editor_on_key_press_event): Put an #ifdef around the
1981 use of gtk_text_buffer_get_has_selection() (from GTK+ 2.10), and add a
1982 TODO comment for this. This fixes the build.
1984 * src/modest-ui-actions.c: Add do_send_receive(), though it might not
1985 be the best place for it. This will in future update all auto-update accounts,
1986 rather than just the current/default account, when that gconf key exists.
1987 (modest_ui_actions_on_send_receive): Offer the settings dialog (or wizard)
1988 if there are no accounts, before calling do_send_receive().
1989 * src/modest-ui-actions.h: Specify the callback for the Send/Recieve menu item.
1991 * src/gnome/modest-main-window.c: (on_online_toggle_toggled):
1992 * src/maemo/modest-main-window-ui.h:
1993 * src/maemo/modest-main-window.c: (on_connection_changed),
1994 (sync_accounts_cb): Use do_send_receive() instead of calling the signal handler
1995 directly, becaue the signal handler does more.
1997 2007-04-30 Murray Cumming <murrayc@murrayc.com>
1999 * src/modest-account-mgr-helpers.c:
2000 (modest_account_mgr_get_account_data): Add a more helpful error message, and comment,
2001 for the case that the account does not exist.
2003 * src/widgets/modest-folder-view.c: (filter_row): Use the tinymail account ID
2004 (equivalent to the modest account name) rather than the tinymail account name
2005 (equivalent to the modest account title - human readable) to get the account data.
2006 Check for null account data to prevent the crash, and add a TODO comment saying that
2007 this needs fixing because it is using the server account name instead of the account name.
2009 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2011 * src/maemo/easysetup/modest-easysetup-wizard.c: (show_error):
2012 * src/maemo/modest-account-settings-dialog.c: (show_error),
2014 Use hildon_note_new_information() for informative and error messages,
2015 which seems to be expected for Maemo applications (no documentation that I know of
2016 says this). I am surprised that there is no distinction between info and error
2019 2007-04-29 Murray Cumming <murrayc@murrayc.com>
2021 * src/maemo/modest-maemo-ui-constants.h: Add a MODEST_MARGIN_NONE constant, so
2022 it is easy to find where this is used.
2024 * src/maemo/easysetup/modest-easysetup-wizard.c:
2025 (create_page_welcome), (create_page_account_details),
2026 (create_page_user_details), (create_page_complete_easysetup),
2027 (create_page_custom_incoming), (create_page_custom_outgoing),
2028 (create_page_complete_custom):
2029 * src/maemo/modest-account-settings-dialog.c:
2030 (create_page_account_details), (create_page_user_details),
2031 (create_page_incoming), (create_page_outgoing):
2032 * src/maemo/modest-account-view-window.c: (window_vbox_new):
2033 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2034 (modest_connection_specific_smtp_edit_window_init):
2035 * src/maemo/modest-connection-specific-smtp-window.c:
2036 (modest_connection_specific_smtp_window_init):
2037 * src/maemo/modest-signature-editor-dialog.c:
2038 (modest_signature_editor_dialog_init): Use the correct padding/spacing/borders
2039 and scrolling policy as per the Email Application Layout Guide, if I have
2042 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2044 * src/modest-tny-account-store.c: (modest_tny_account_store_init):
2045 Remove the add_transport_account_func and add_store_account_func vfunc implementations,
2046 which were empty, because these vfuncs have been removed from TnyAccountStore.
2047 This fixes the build.
2049 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2051 * src/maemo/modest-main-window.c:
2052 (modest_main_window_show_toolbar): Check that a toolbar item is not NULL before
2053 showing/hiding it. Added TODO because it probably should not be NULL.
2054 * src/modest-init.c: (modest_init_init_ui): Use a g_message() instead of a g_warning()
2055 because unnecessary g_warnings() make degugging difficult.
2057 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2059 * src/maemo/modest-msg-edit-window.c:
2060 (modest_msg_edit_window_select_color),
2061 (modest_msg_edit_window_select_background_color): 2 const corrections and
2062 moving 2 #endifs before closing brackets, to fix the build.
2064 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2066 * src/maemo/easysetup/modest-easysetup-wizard.h:
2067 * src/maemo/easysetup/modest-easysetup-wizard.c:
2068 (modest_easysetup_wizard_dialog_finalize),
2069 (on_button_edit_advanced_settings), (create_page_complete_custom),
2070 (on_response), (create_account):
2071 Implement the Advanced Settings edit button, by saving the account information,
2072 for the Advanded Settings dialog to use directly from gconf, and removing it
2073 if Finish is never clicked. There is still some UI strangeness, so this is not finished.
2074 Bug #5533 in the projects.maemo.org bugzilla.
2076 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2078 * src/maemo/modest-msg-view-window.c:
2079 (modest_msg_view_window_show_toolbar): Prevent hide/show of a NULL toolbar widget,
2080 when opening a message window.
2082 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2084 * src/maemo/easysetup/modest-easysetup-wizard.c:
2085 (create_page_custom_outgoing): Correct the position of the horizontal separator to
2088 * src/maemo/modest-main-window.c: (set_toolbar_mode): Check that widgets are not NULL
2089 before showing/hiding them, to avoid a crash when clicking on folders when there are no
2090 gconf settings. I probably added more checks than necessary, but that is safer.
2092 * src/modest-ui-actions.c: (modest_ui_actions_on_move_to): Initialize the mail_op
2093 variable to fix the build, but this seems to be used when it is still NULL.
2095 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2097 * src/modest-platform.h:
2098 * src/gnome/modest-platform.c: (modest_platform_connect_and_wait):
2099 * src/maemo/modest-platform.c: (modest_platform_connect_and_wait):
2100 * src/modest-main.c: Implement this function so we can avoid using
2101 maemo-specific API from cross-platform code.
2103 * src/modest-tny-account-store.c:
2104 (get_smtp_specific_transport_account_for_open_connection):
2105 * src/modest-ui-actions.c: (check_for_connection),
2106 (modest_ui_actions_on_item_not_found):
2107 Use modest_platform_connect_and_wait() and put #idefs around other
2108 maemo-specific code, because only maemo currently has a way to
2109 identify connection names.
2111 2007-04-27 Murray Cumming <murrayc@murrayc.com>
2113 * src/modest-tny-account-store.h:
2114 * src/modest-tny-account-store.c:
2115 Added modest_tny_account_store_get_transport_account_for_open_connection(), which respects
2116 the connection-specific SMTP server settings in the configuration.
2118 * src/dbus_api/modest-dbus-callbacks.c: (on_idle_send_mail),
2120 * src/maemo/modest-main-window.c: (on_connection_changed),
2122 * src/modest-main.c: (main), (start_ui), (send_mail):
2123 Use tny_maemo_conic_device_connect() instead of tny_maemo_conic_force_online(), when
2124 that is what is intended.
2126 * src/modest-ui-actions.c: (action_send), (action_receive),
2127 (modest_ui_actions_on_item_not_found), (modest_ui_actions_on_send):
2128 Use modest_tny_account_store_get_transport_account_for_open_connection() instead of
2129 modest_tny_account_store_get_tny_account_by_account() so that the connection-specific
2130 SMTP server is used when it is specified.
2132 (modest_ui_actions_on_send_receive):
2133 Check that a connection is open before proceeding.
2134 Receive and then send, instead of vice-versa, as per the specification.
2136 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2138 * src/modest-mail-operation.c:
2139 (modest_mail_operation_remove_folder): Intialize the parent variable, to fix the build,
2140 though I guess it should be something other than NULL.
2142 2007-04-26 Murray Cumming <murrayc@murrayc.com>
2144 * src/maemo/easysetup/modest-easysetup-wizard.c:
2145 (create_page_custom_incoming): Add the checkbox to the caption instead of adding the
2146 combo twice, to avoid an g_warning and to make it visible again.
2147 * src/maemo/modest-main-window.c: (on_account_update): Check whether the popup_menu is
2148 attached before detaching it, to avoid a g_warning, and add comment about the implicit
2149 (already intended) dereference when detaching, because we then recreate the menu.
2150 But I am not sure why the warning was happening, and it is possible that this is a memory
2153 2007-04-25 Murray Cumming <murrayc@murrayc.com>
2155 * src/dbus_api/modest-dbus-callbacks.c: Added uri_unescape(),
2156 and uri_parse_mailto() utility functions.
2157 (on_idle_mail_to): Parse, unescape, and use the subject, cc, bcc, and body items in
2159 * tests/dbus_api/test_mail_to.c: (main): Add escaped spaces in the URI to test this.
2161 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2163 * src/dbus_api/modest-dbus-api.h:
2164 * src/dbus_api/modest-dbus-callbacks.c:
2165 Use an idle callback to execute the modest code in the application's own thread.
2166 Remove the helloworld example method.
2167 Handle mail-to and open-message D-Bus methods, though the mail-to format needs to be
2168 parsed, and the open-message method is not implemented because this is not yet implemented in
2170 * libmodest-dbus-client/libmodest-dbus-client.c:
2171 (libmodest_dbus_client_send_mail), (libmodest_dbus_client_mail_to),
2172 (libmodest_dbus_client_open_message):
2173 * libmodest-dbus-client/libmodest-dbus-client.h: New functions for the new methods.
2175 * src/modest-tny-msg.c: (modest_tny_msg_new), (add_body_part): Handle NULLs for subject and
2176 body without crashing.
2178 * tests/dbus_api/Makefile.am:
2179 * tests/dbus_api/test_mail_to.c:
2180 * tests/dbus_api/test_open_message.c: New tests for the new methods.
2182 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2184 * libmodest-dbus-client/libmodest-dbus-client-1.0.pc.in:
2185 Added file to fix the build. Sorry.
2187 * src/dbus_api/Makefile.am:
2188 * src/dbus_api/modest-dbus-api.h:
2189 * src/dbus_api/modest-dbus-callbacks.h:
2190 * src/dbus_api/modest-dbus-callbacks.c: (on_send_mail),
2191 (modest_dbus_req_handler):
2192 Put constants in a separate header so it can be reused by the
2193 client library, without duplication
2195 * libmodest-dbus-client/Makefile.am:
2196 * libmodest-dbus-client/libmodest-dbus-client.c:
2197 (libmodest_dbus_client_call_helloworld),
2198 (libmodfest_dbus_client_send_mail),
2199 (libmodfest_dbus_client_mailto),
2200 (libmodfest_dbus_client_open_message):
2201 * libmodest-dbus-client/libmodest-dbus-client.h:
2202 (Partly) Implement a send_mail D-Bus method.
2204 * tests/dbus_api/Makefile.am:
2205 * tests/dbus_api/test_send_mail.c: (main): Added a test for
2206 the send_email D-Bus method.
2208 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2212 * libmodest-dbus-client/Makefile.am:
2213 * libmodest-dbus-client/libmodest-dbus-client.c:
2214 * libmodest-dbus-client/libmodest-dbus-client.h:
2215 * tests/dbus_api/Makefile.am:
2216 * tests/dbus_api/test_hello.c: (main): Added directory structure for a C convenience library
2217 for using the modest D-Bus API, and used that from the test. It is still just a helloworld.
2219 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2221 * src/maemo/easysetup/modest-easysetup-wizard.c:
2222 (create_page_account_details):
2223 * src/maemo/modest-account-settings-dialog.c:
2224 (create_page_account_details): Explicitly set auto-capitalization mode for the title
2225 widgets, because this might not be the default in future versions of the Maemo GTK+.
2226 However, I can not not get capitalization to work even in a simple test case.
2228 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2230 * src/maemo/easysetup/modest-easysetup-wizard.c:
2231 (create_page_custom_incoming), (create_page_custom_outgoing):
2232 * src/maemo/modest-account-settings-dialog.c:
2233 (create_page_account_details), (create_page_incoming),
2234 (create_page_outgoing): Use a separate label in a caption for GtkCheckButtons,
2235 instead of using gtk_check_button_with_label(), so they are aligned like the other
2236 widgets, as per the UI spec.
2238 2007-04-24 Murray Cumming <murrayc@murrayc.com>
2240 * src/maemo/easysetup/modest-easysetup-wizard.c:
2241 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2242 * src/widgets/modest-validating-entry.c:
2243 * src/widgets/modest-validating-entry.h: Rename the validating widget so it has a
2244 Modest prefix instead of an EasySetup prefix.
2246 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2248 * src/widgets/modest-validating-entry.h:
2249 * src/widgets/modest-validating-entry.c: (on_insert_text),
2250 Added easysetup_validating_entry_set_max_func(), used to set a callback
2251 to call when the max number of characters is reached. GtkEntry has a max-length
2252 already but is silent about it.
2254 * src/maemo/easysetup/modest-easysetup-wizard.c: (on_entry_max),
2255 (create_page_account_details), (create_page_user_details),
2257 * src/maemo/modest-account-settings-dialog.c: (on_entry_max),
2258 (create_page_account_details), (create_page_user_details),
2259 (create_page_outgoing):
2260 * src/modest-ui-actions.c: (modest_ui_actions_on_details):
2261 Use easysetup_validating_entry_set_max_func() to show the warning dialog, as per
2262 the UI spec, when the user tries to enter more than the max number of characters.
2264 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2266 * src/maemo/easysetup/modest-easysetup-wizard.c:
2267 (create_page_user_details), (create_page_custom_incoming),
2268 (create_page_custom_outgoing):
2269 * src/maemo/modest-account-settings-dialog.c:
2270 (create_page_user_details), (create_page_incoming),
2271 (create_page_outgoing):
2272 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2273 (modest_connection_specific_smtp_edit_window_init):
2274 Use hildon_gtk_entry_set_input_mode() to turn off auto-capitalization where it is
2275 not appropriate. Bad Maemo-specific defaults!.
2277 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2279 * src/maemo/modest-signature-editor-dialog.c: (enable_widgets),
2280 (on_toggle_button_changed), (modest_signature_editor_dialog_init),
2281 (modest_signature_editor_dialog_set_settings):
2282 Disable the label and textview when the checkbox is disabled, and use the
2283 specified (UI spec) default signature text.
2285 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2287 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2288 (modest_connection_specific_smtp_edit_window_init): Use spacing constants.
2290 * src/modest-defs.h:
2291 * src/modest-account-mgr-helpers.h:
2292 * src/modest-account-mgr-helpers.c:
2293 Added modest_account_mgr_get/set_signature(), using new gconf keys.
2295 * src/maemo/Makefile.am:
2296 * src/maemo/modest-signature-editor-dialog.c:
2297 * src/maemo/modest-signature-editor-dialog.h: New dialog for editing signatures,
2300 * src/maemo/modest-account-settings-dialog.h:
2301 * src/maemo/modest-account-settings-dialog.c:
2302 (modest_account_settings_dialog_finalize), (on_button_signature),
2303 (save_configuration): Use the new dialog when the Edit button is pressed, and
2304 save the changes if necessary, as per the UI spec.
2306 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2308 * src/maemo/Makefile.am:
2309 * src/maemo/modest-maemo-ui-constants.h: New header with some defines for widget spacing,
2310 based on maemo-develoers email from Dirk.
2312 * src/maemo/easysetup/modest-easysetup-wizard.c:
2313 (create_page_welcome), (create_page_account_details),
2314 (create_page_user_details), (create_page_complete_easysetup),
2315 (create_page_custom_incoming), (create_page_custom_outgoing),
2316 (create_page_complete_custom),
2317 (modest_easysetup_wizard_dialog_init):
2318 * src/maemo/modest-account-settings-dialog.c:
2319 (create_page_account_details), (create_page_user_details),
2320 (create_page_incoming), (create_page_outgoing),
2321 (modest_account_settings_dialog_init):
2322 * src/maemo/modest-connection-specific-smtp-window.c:
2323 (modest_connection_specific_smtp_window_init): Used the smallest of the spacing constants.
2325 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2327 * src/maemo/easysetup/modest-easysetup-wizard.c:
2328 (create_page_account_details), (create_page_custom_outgoing),
2329 (create_page_complete_custom):
2330 * src/maemo/modest-account-settings-dialog.c:
2331 (create_page_user_details), (create_page_incoming),
2332 (create_page_outgoing):
2333 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2334 (modest_connection_specific_smtp_edit_window_init):
2335 Use the correct (UI spec) port min/max, and use horizontal separators,
2338 2007-04-23 Murray Cumming <murrayc@murrayc.com>
2340 * src/maemo/easysetup/modest-easysetup-wizard.c:
2341 (set_default_custom_servernames):
2342 * src/maemo/modest-account-settings-dialog.c:
2343 (create_page_incoming), (on_combo_outgoing_security_changed),
2344 (on_combo_incoming_security_changed), (create_page_outgoing),
2345 (modest_account_settings_dialog_set_account_name),
2346 (save_configuration):
2347 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2348 (on_combo_security_changed),
2349 (modest_connection_specific_smtp_edit_window_init),
2350 (modest_connection_specific_smtp_edit_window_set_connection),
2351 (modest_connection_specific_smtp_edit_window_get_settings):
2352 Use HildonNumberEditor instead of GtkEntry for the port numbers so it has the - and + buttons,
2355 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2358 * src/maemo/easysetup/modest-easysetup-wizard.c:
2359 (create_page_custom_outgoing), (create_page_complete_custom):
2360 * src/maemo/modest-account-settings-dialog.c:
2361 (create_page_user_details), (create_page_outgoing):
2362 * src/maemo/modest-account-view-window.c: (button_box_new):
2363 Use changed logical IDs as per the most recent UI spec:
2364 mcen_bd_emailsetup_edit -> mcen_bd_edit
2365 mcen_bd_emailsetup_delete -> mcen_bd_delete
2366 mcen_bd_emailsetup_close -> mcen_bd_close
2368 2007-04-20 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2372 * src/dbus_api/Makefile.am:
2373 * src/dbus_api/modest-dbus-callbacks.c:
2374 * src/dbus_api/modest-dbus-callbacks.h:
2375 * src/maemo/modest-platform.c: (modest_platform_init):
2376 Added the beginnings of a D-Bus API. At the moment it just has a HelloWorld
2378 * tests/Makefile.am:
2379 * tests/dbus_api/Makefile.am:
2380 * tests/dbus_api/test_hello.c: (main): Very simple test of the D-Bus API.
2382 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2384 * src/maemo/modest-account-settings-dialog.c:
2385 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2386 Removed unnecessary includes.
2388 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2390 * src/maemo/easysetup/modest-easysetup-wizard.c:
2391 * src/maemo/modest-account-settings-dialog.c:
2392 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2393 * src/widgets/Makefile.am:
2394 * src/widgets/modest-easysetup-secureauth-combo-box.c:
2395 * src/widgets/modest-easysetup-secureauth-combo-box.h:
2396 * src/widgets/modest-easysetup-serversecurity-combo-box.c:
2397 * src/widgets/modest-easysetup-serversecurity-combo-box.h:
2398 * src/widgets/modest-secureauth-combo-box.c:
2399 * src/widgets/modest-secureauth-combo-box.h:
2400 * src/widgets/modest-serversecurity-combo-box.c:
2401 * src/widgets/modest-serversecurity-combo-box.h: Renamed the files and
2402 made the GObject names more consistent with the rest of the Modest code.
2404 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2406 * src/maemo/easysetup/Makefile.am:
2407 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2408 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.h:
2409 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2410 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2411 * src/maemo/easysetup/modest-easysetup-wizard.c:
2412 * src/maemo/easysetup/modest-validating-entry.c:
2413 * src/maemo/easysetup/modest-validating-entry.h:
2414 * src/maemo/modest-account-settings-dialog.c:
2415 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2416 * src/widgets/Makefile.am: Moved these widgets from maemo/easysetup into
2417 widgets/ because they are used outside of easysetup too. After checking in,
2418 svn will allow me to rename them too.
2420 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2422 * src/gnome/modest-msg-edit-window.c:
2423 (modest_msg_edit_window_set_priority_flags): Added an empty implementation to fix a
2424 linker error, to fix the build on the GNOME platform.
2425 modest_msg_edit_window_set_zoom(), modest_msg_edit_window_get_zoom(),
2426 modest_msg_edit_window_zoom_plus(), modest_msg_edit_window_zoom_minus():
2427 ifdefed out to avoid a warning.
2429 2007-04-20 Murray Cumming <murrayc@murrayc.com>
2431 * src/widgets/modest-header-view.c: (on_focus_in): Use GTK_CHECK_VERSION to #ifdef around the
2432 use of gtk_tree_view_get_visible_range(), to fix the build on Mameo. This code probably needs
2433 some alternative for GTK+ 2.6.
2435 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2437 * src/maemo/modest-address-book.c: Added include to avoid a warning.
2439 * po/en_GB.po: Added missing mcen_bd_emailsetup_close string,
2440 specified for EmailAccountsDialog in UI spec.
2442 * src/maemo/easysetup/modest-easysetup-wizard.c:
2443 * src/maemo/easysetup/modest-easysetup-wizard.h:
2444 * src/maemo/modest-account-settings-dialog.c:
2445 * src/maemo/modest-account-settings-dialog.h:
2446 Reuse a member window widget for the connection-specific SMTP server accounts,
2447 so we can tell it to create/save the accounts only if we actually save changes.
2449 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2450 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2451 (modest_connection_specific_smtp_edit_window_get_settings):
2452 Return a struct instance for temporarily remembering the entered data.
2454 * src/maemo/modest-connection-specific-smtp-window.h:
2455 * src/maemo/modest-connection-specific-smtp-window.c:
2456 (modest_connection_specific_smtp_window_finalize),
2457 (modest_connection_specific_smtp_window_fill_with_connections),
2459 (modest_connection_specific_smtp_window_save_server_accounts),
2460 (update_model_server_names): Do not actually save data until asked,
2461 when the caller calls modest_connection_specific_smtp_window_save_server_accounts().
2463 (on_selection_changed),
2464 (modest_connection_specific_smtp_window_init): Disable the edit
2465 button when nothing is selected.
2467 * src/modest-account-mgr-helpers.c:
2468 * src/modest-account-mgr-helpers.h:
2469 Put modest_account_mgr_free_server_account_data() in the header now that I use the struct
2472 2007-04-19 Murray Cumming <murrayc@murrayc.com>
2474 * src/modest-account-mgr-helpers.h:
2475 * src/modest-account-mgr-helpers.c:
2476 (modest_account_mgr_get_unused_account_name),
2477 (modest_account_mgr_get_unused_account_display_name): Added these
2478 utility functions, to avoid code duplication.
2480 * src/maemo/easysetup/modest-easysetup-wizard.c:
2481 (create_page_account_details), (create_account):
2482 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2483 (on_combo_security_changed),
2484 (modest_connection_specific_smtp_edit_window_init),
2485 (modest_connection_specific_smtp_edit_window_save_settings):
2486 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2487 * src/maemo/modest-connection-specific-smtp-window.c:
2488 (modest_connection_specific_smtp_window_finalize),
2489 (modest_connection_specific_smtp_window_fill_with_connections),
2490 (on_button_edit), (modest_connection_specific_smtp_window_init):
2491 * src/maemo/modest-connection-specific-smtp-window.h:
2492 Implementing saving of connection-specific server accounts.
2494 But I need to refactor this so we can save the data for each
2495 possible connection-specific account and only actually create the server accounts
2496 when the easysetup finished, or the OK button is pressed on the account settings
2499 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2501 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2502 (on_combo_security_changed):
2503 (modest_connection_specific_smtp_edit_window_init):
2504 Auto-fill the port number as in the account settings.
2506 (modest_connection_specific_smtp_edit_window_set_connection):
2507 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2508 * src/maemo/modest-connection-specific-smtp-window.c:
2509 (fill_with_connections), (on_button_edit),
2510 (modest_connection_specific_smtp_window_init):
2511 Turn the edit window into a dialog to simplify the code, and
2512 set a WM hint as in a GtkDialog, because only a popup can be on top of
2513 another window in Maemo, and popups usually have no WM decoration.
2515 * src/modest-defs.h:
2516 * src/modest-account-mgr-helpers.c:
2517 (modest_account_mgr_set_connection_specific_smtp),
2518 (modest_account_mgr_remove_connection_specific_smtp),
2519 (modest_account_mgr_get_connection_specific_smtp):
2520 * src/modest-account-mgr-helpers.h: Some functions to write the
2521 connection-specific SMTP server information. Not yet used.
2524 * src/widgets/modest-folder-view.c: (text_cell_data):
2525 Fix a warning about an uninitialized variable.
2526 (on_configuration_key_changed): Put an #ifdef around the use
2527 of gtk_tree_view_column_queue_resize() because it is new in GTK+ 2.10.
2529 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2531 * src/maemo/modest-account-settings-dialog.h:
2532 * src/maemo/modest-account-settings-dialog.c:
2533 Added connect_for_modified() utility function to mark the new modified boolean.
2535 (create_page_account_details), (create_page_user_details),
2536 (create_page_incoming), (create_page_outgoing), (on_response),
2537 (modest_account_settings_dialog_init),
2538 (modest_account_settings_dialog_set_account_name):
2539 Only warn about unsaved changes when there are actually unsaved changes.
2541 * src/modest-account-mgr-helpers.c:
2542 * src/modest-account-mgr-helpers.h: Put the port, secure-auth, and security information
2543 into the ModestServerAccountData struct. I do not use it yet, but someone might expect
2544 to get the data from there in future.
2546 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2548 * src/modest-defs.h:
2550 * src/modest-account-mgr-helpers.h:
2551 * src/modest-account-mgr-helpers.c:
2552 Store the security account setting in a single conf key instead of using
2553 the options list, so that the list is left for just the to-be-removed camel hack,
2554 and because gconf_client_set_list() is failing for some reason.
2556 * src/modest-account-mgr.c:
2557 (modest_account_mgr_add_server_account):
2558 * src/maemo/modest-account-settings-dialog.c:
2559 (modest_account_settings_dialog_set_account_name),
2560 (save_configuration): Use the renamed functions.
2563 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2565 * src/widgets/Makefile.am:
2566 * src/widgets/modest-limit-retrieve-combo-box.c:
2567 * src/widgets/modest-limit-retrieve-combo-box.h:
2568 * src/widgets/modest-retrieve-combo-box.c:
2569 * src/widgets/modest-retrieve-combo-box.h: Added new widgets for use in
2570 the account settings dialog.
2572 * src/modest-defs.h:
2573 * src/modest-account-mgr-helpers.h:
2574 * src/modest-account-mgr-helpers.c:
2575 (modest_server_account_get_option_secure_auth),
2576 (modest_server_account_set_option_secure_auth):
2577 * src/modest-account-mgr.c:
2578 (modest_account_mgr_add_server_account):
2579 Use the existing AUTH_MECH conf key for the secure-auth setting,
2580 instead of putting it in the list options, because this was actually used already.
2582 * src/maemo/modest-account-settings-dialog.c:
2583 (create_page_account_details),
2584 (modest_account_settings_dialog_set_account_name),
2585 (save_configuration):
2586 * src/maemo/modest-account-settings-dialog.h:
2587 Add the retrieve and retrieve-limit combo boxes, as per the UI spec.
2588 Hide the leave-messages checkbox for non-POP accounts, as per the UI spec.
2590 2007-04-18 Murray Cumming <murrayc@murrayc.com>
2592 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.h:
2593 * src/maemo/easysetup/modest-easysetup-serversecurity-combo-box.c:
2594 Added easysetup_serversecurity_combo_box_get_active_serversecurity_port()
2596 * src/modest-defs.h:
2597 * src/maemo/modest-account-settings-dialog.c:
2598 (create_page_incoming), (on_combo_outgoing_security_changed),
2599 (on_combo_incoming_security_changed), (create_page_outgoing),
2600 (modest_account_settings_dialog_set_account_name),
2601 (save_configuration): Load/Save the port number, and change it when the
2602 security combo changes, to suitable defaults.
2604 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2606 * src/modest-account-mgr.c:
2607 (modest_account_mgr_add_server_account): Set the security and secure-auth
2608 options, and add a comment saying that the other camel-specific options should be
2611 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2613 * src/maemo/modest-account-settings-dialog.c: (check_data): Always return something,
2615 * src/modest-tny-account-store.c: (account_list_free),
2616 (on_account_changed): Add a TODO comment about a valgrind error, caused by using
2617 cursor->data after unreffing it. But there is some strange stuff there so it might not be
2620 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2622 * src/modest-protocol-info.c:
2623 * src/modest-protocol-info.h: Added a MODEST_PROTOCOL_AUTH_CRAMMD5 enum value, because it
2624 is required by our UI spec. Maybe something in our implementation will use this eventually.
2625 * src/maemo/easysetup/modest-easysetup-secureauth-combo-box.c:
2626 (easysetup_secureauth_combo_box_fill): Use the CRAM MD5 enum value
2627 instead of the previous 0 placeholder.
2629 * src/modest-defs.h: Added gconf list pair key names and value strings for the security and
2630 secure-auth settings.
2631 * src/modest-account-mgr-helpers.h:
2632 * src/modest-account-mgr-helpers.c:
2633 (modest_server_account_data_get_option_secure_auth),
2634 (modest_server_account_set_option_secure_auth),
2635 (modest_server_account_data_get_option_security),
2636 (modest_server_account_set_option_security): Added this API for getting and setting the security
2637 and secure-auth settings.
2639 * src/maemo/modest-account-settings-dialog.h:
2640 * src/maemo/modest-account-settings-dialog.c:
2641 (modest_account_settings_dialog_finalize), (check_data),
2642 (on_response): Store the original title as well as the name, to avoid unnececessary warnings
2643 about changing titles.
2644 (modest_account_settings_dialog_set_account_name): Load the security and secure-auth settings.
2645 (save_configuration): Save the security and secure-auth settings.
2647 * src/modest-conf.c: (modest_conf_set_list): Get the list after setting it, to show that this
2648 is failing sometimes (though reporting success). I fear I may need to debug gconf to fix this.
2650 2007-04-17 Murray Cumming <murrayc@murrayc.com>
2652 * src/modest-defs.h:
2653 * src/modest-account-mgr.c:
2654 (modest_account_mgr_add_server_account):
2655 Added and used defines for the options key and value pair strings,
2656 that are used so far, though they do not seem to correspond to anything in our
2657 UI specs or ModestProtocol enum.
2659 * src/modest-account-mgr-helpers.h:
2660 * src/modest-account-mgr-helpers.c:
2661 (compare_option_strings_for_name),
2662 (modest_server_account_data_get_option_value),
2663 (modest_server_account_data_get_option_bool),
2664 (modest_account_mgr_get_server_account_option):
2665 Added helper functions for parsing the options GSList.
2667 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2669 * src/modest-account-mgr-helpers.c: Clarified the documentation to say that the initial
2670 display name is based on the supplied account name.
2671 * src/modest-account-mgr.c:
2672 * src/modest-account-mgr.h: Added modest_account_mgr_account_with_display_name_exists(),
2673 with an inefficient, but good-enough, implementation.
2675 * src/maemo/easysetup/modest-easysetup-wizard.c:
2676 (create_page_account_details), (on_before_next), (create_account):
2677 Check for existing display names rather than (non-user-visible) account names, and just
2678 create and set a unique account name at the end.
2680 * src/maemo/modest-account-settings-dialog.c:
2681 (modest_account_settings_dialog_init),
2682 (modest_account_settings_dialog_set_account_name),
2683 (create_page_incoming): Show the display name, instead of the account name.
2684 (on_response): Do some (not all) extra checks, as in the UI spec.
2685 (save_configuration): Save the display name if it was changed.
2687 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2689 * po/en_GB.po: Added needed logical ID and translation.
2690 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2691 (init_view): Made the is-default column clicking work.
2693 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2696 * src/maemo/easysetup/Makefile.am:
2697 * src/maemo/easysetup/modest-easysetup-wizard.c:
2698 (modest_easysetup_wizard_dialog_init):
2699 * src/maemo/easysetup/provider-data-test.keyfile:
2700 * src/maemo/easysetup/provider-data.keyfile:
2701 Moved the provider data file to the new modest-providers-data package and used it from there.
2703 2007-04-16 Murray Cumming <murrayc@murrayc.com>
2705 * src/modest-local-folder-info.c:
2706 (modest_local_folder_info_get_type_display_name): Use _() to actually get the translated string.
2707 N_() was already used on the static strings, but this just marks it for translation without
2708 using the translation.
2710 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2712 * src/maemo/modest-account-settings-dialog.c:
2713 (create_page_incoming),
2714 (modest_account_settings_dialog_set_account_name):
2715 Added comments about the need for new API in ModestAccountMgr to handle the authentication
2716 and secure-connection stuff that is stored in the options GSList* with hard-coded names.
2717 I will do this if nobody else gets there first.
2719 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2721 * src/maemo/modest-account-settings-dialog.c: (save_configuration):
2722 Saved much of the incoming and outgoing data too, though I cannot yet see how to
2723 save the security stuff.
2725 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2727 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2728 Set the email address and user fullname, which I now see must be
2731 * src/maemo/modest-account-settings-dialog.h:
2732 * src/maemo/modest-account-settings-dialog.c:
2734 (modest_account_settings_dialog_set_account_name): Show the email address, fullname,
2735 leave-on-server and authentication.
2736 (save_configuration): Save most of the non-server-account specific stuff, but I don't see
2739 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2742 * src/maemo/modest-account-settings-dialog.c:
2743 * src/maemo/modest-account-settings-dialog.h:
2744 Most (but not all) of the widgets are now present as specified by the UI spec.
2745 No changes are yet saved, and some details are not properly shown yet.
2747 * po/en_GB.po: Added translations for logical IDs used by the Account Settings dialog.
2749 2007-04-06 Murray Cumming <murrayc@murrayc.com>
2751 * src/maemo/Makefile.am:
2752 * src/maemo/modest-account-settings-dialog.c:
2753 * src/maemo/modest-account-settings-dialog.h: The beginnings of the dialog to edit
2754 an existing account. Doesn't do much yet.
2756 * src/maemo/modest-account-view-window.c: (on_edit_button_clicked):
2757 Open the accounts settings dialog when Edit is clicked.
2759 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2761 * src/maemo/easysetup/Makefile.am:
2762 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2764 * src/maemo/easysetup/modest-easysetup-wizard.c:
2765 (modest_easysetup_wizard_dialog_init):
2766 Try to get the source directory from the build system,
2767 instead of hard-coding "./" into the source code, when opening our local
2768 copies of the configuration files.
2769 But this still fails when opening the wizard from the Accounts window,
2770 maybe because the working directory seems to change at runtime.
2771 So the wizard will fail the second time unless you copy the files into their
2772 proper locations - see the stdout warnings for the paths.
2774 (create_page_account_details),(on_before_next):
2775 Check for existing non-server accounts instead of server accounts,
2776 so the default account name is useful again, and to prevent trying to
2779 * src/maemo/modest-account-view-window.c: (on_new_button_clicked):
2780 Show the wizard when New is clicked.
2782 * src/widgets/modest-account-view.c: (on_account_default_toggled),
2783 (init_view): Show the column headers, and show the columns that are
2784 specified in the UI specs. However, something in Maemo's GTK+ prevents
2785 us from handling the GtkCellRendererToggle::toggled signal, so we cannot
2786 change the default account. This is despite unsetting the special properties.
2788 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2790 * docs/reference/modest-design.sgml: Corrected spelling mistake.
2791 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2792 Create the 2 server accounts and then create the account, using the names of the 2 server accounts.
2793 This seems to be how this should be used. If it is, then I will update the AccountMgr documentation
2794 to make that clearer.
2795 * src/modest-account-mgr.h: Corrected the modest_account_mgr_search_server_account() documentation.
2797 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2799 * src/maemo/modest-account-view-window.c:
2800 (modest_account_view_window_init),
2801 (modest_account_view_window_new):
2802 Use the same buttons as specified in the
2803 UI spec. Add the widgets to the vbox and action_area instead of just assigning them to
2804 the existing widgets, which never had a chance of working.
2805 Put the ModestAccountView treeview in a scrolled window.
2806 Do not repeat the initialization in both _init() and _new().
2808 * src/widgets/modest-account-view.c: (update_account_view):
2809 Add a warning about modest_account_mgr_account_names() returning NULL, which is why
2810 this widget and window shows no accounts.
2812 * po/en_GB.po: Added translations needed for the dialog button logical IDs.
2814 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2816 * src/maemo/easysetup/modest-easysetup-wizard.c:
2817 (set_default_custom_servernames): Avoid a dereference of a destroyed widget.
2818 (create_account): Do a sanity check, showing that modest_account_mgr_account_names()
2819 returns NULL after modest_account_mgr_add_server_account() returned TRUE,
2822 * src/maemo/modest-main-window-ui.h: Specify the callback for the Accounts menu item.
2823 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts): Open the wizard if no
2824 accounts exist yet, as in the UI spec.
2826 * src/modest-account-mgr.h: Add TODO comment about a possible memory leak.
2828 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2830 * src/maemo/Makefile.am:
2831 * src/maemo/modest-connection-specific-smtp-edit-window.c:
2832 * src/maemo/modest-connection-specific-smtp-edit-window.h:
2833 New window for editing connection-specific smtp details.
2834 Not fully implemented.
2836 * src/maemo/modest-connection-specific-smtp-window.c:
2837 (modest_connection_specific_smtp_window_finalize) :
2838 unref the tree model.
2839 (on_button_edit): Show the edit window.
2841 2007-04-05 Murray Cumming <murrayc@murrayc.com>
2843 * src/Makefile.am: Change sequence of sub-libraries, which fixed an undefined symbol
2846 * src/maemo/Makefile.am:
2847 * src/maemo/modest-connection-specific-smtp-window.c:
2848 * src/maemo/modest-connection-specific-smtp-window.h:
2849 New window for showing the list of connections, for connection-specific
2850 SMTP servers. Not fully implemented, because it needs an enhancement to TnyMaemoDevice.
2851 * src/maemo/easysetup/modest-easysetup-wizard.c:
2852 (create_page_custom_outgoing): Show the new window when the button is clicked.
2854 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2856 * src/maemo/easysetup/modest-easysetup-wizard.c: (create_account):
2857 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2858 * src/maemo/modest-msg-edit-window.c:
2859 (modest_msg_edit_window_insert_image):
2860 * src/modest-conf.c: (modest_conf_key_escape):
2861 * src/modest-mail-operation.c:
2862 (modest_mail_operation_send_new_mail):
2863 * src/modest-ui-actions.c: (modest_ui_actions_on_accounts),
2864 (modest_ui_actions_on_new_account):
2865 * src/widgets/modest-attachment-view.c: (update_filename_request):
2866 * src/widgets/modest-mail-header-view.c:
2867 Corrected warnings that were breaking the build, by commenting out unused variables,
2868 and a function, and by including a header.
2870 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2872 * configure.ac: Define MODEST_PLATFORM_MAEMO and MODEST_PLATFORM_GNOME in config.h,
2873 so we can #ifdef around platform-specific code when necessary.
2874 * src/modest-ui-actions.c: (modest_ui_actions_on_new_account): Use MODEST_PLATFORM_MAEMO
2875 to allow this to build for the GNOME platform too.
2877 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2879 * src/maemo/easysetup/modest-easysetup-wizard.c:
2880 Added util_increment_name() and used it in create_page_account_details()
2881 to make sure that the default account name is always a new name.
2883 (modest_easysetup_wizard_dialog_init),
2884 (set_default_custom_servernames): Some minor memory management fixes.
2886 2007-04-04 Murray Cumming <murrayc@murrayc.com>
2890 * src/modest-runtime.c: (init_i18n): Restored the translation
2891 infrastructure, so that GETTEXT_PACKAGE and MODEST_LOCALE_DIR
2892 are defined in config.h, and the translations are installed.
2894 * src/maemo/easysetup/: Include config.h so that GETTEXT_PACKAGE
2895 is defined for translation.
2897 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2899 * src/maemo/easysetup/modest-easysetup-country-combo-box.c:
2901 * src/maemo/easysetup/modest-easysetup-wizard.c:
2902 (modest_easysetup_wizard_dialog_init):
2903 * src/maemo/easysetup/modest-presets.c: (modest_presets_new):
2904 Use realistic paths (though they should use $prefix generically) to the
2905 mcc_mapping and provider-data.keyfile files which might work when they
2906 are installed by the future version of the operator-wizard package,
2907 and then fallback to paths in our source code, with an explanatory
2910 2007-04-03 Murray Cumming <murrayc@murrayc.com>
2914 * src/maemo/Makefile.am:
2915 * src/maemo/easysetup/: Added files from the previously-exernal
2916 osso-modest-easysetup.
2917 * src/maemo/modest-main-window-ui.h:
2918 * src/modest-ui-actions.c:
2919 * src/modest-ui-actions.h:
2920 Added modest_ui_actions_on_new_account() as a signal handler for the
2921 New Account menu item. It shows the easysetup wizard.
2922 * po/en_GB.po: Added additional needed logical IDs and translations.
2924 Started ChangeLog2 file, because I cannot work without a ChangeLog. murrayc.
2925 Apparently ChangeLog is not used for some vague Nokia legal reasons.